Skip to contentSkip to conversation

drm/atmel-hlcdc: drop use of drm_irq mid-layer

PATCH New Sam Ravnborg 1 participant 3 messages Jul 11, 2021

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

cover drm/atmel-hlcdc: drop use of drm_irq mid-layer

Two small patches to drop the use of the drm irq mid-layer.
My atmel hlcdc target has stopped working - so unfortunately un-tested :-( I picked up this to continue the work of Thomas Zimmermann.

Sam

Sam Ravnborg (2):
drm/atmel-hlcdc: Move interrupt helper funtions drm/atmel-hlcdc: Convert to Linux IRQ interfaces

 drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c | 63 +++++++++++++---------------
 1 file changed, 30 insertions(+), 33 deletions(-)
#1 lore raw

PATCH 1/1 drm: bridge: Mark deprecated operations in drm_bridge_funcs

drm_bridge_funcs includes several duplicated operations as atomic variants has been added over time.
New bridge drivers shall use the atomic variants - mark the deprecated operations to try to avoid usage in new bridge drivers.

Cc Laurent Pinchart <[email protected]>
Cc Andrzej Hajda <[email protected]>
Cc Maarten Lankhorst <[email protected]>
Cc Maxime Ripard <[email protected]>
Cc Thomas Zimmermann <[email protected]>
Cc David Airlie <[email protected]>
Cc Daniel Vetter <[email protected]>
---
 include/drm/drm_bridge.h | 28 ++++++++++++++++++++++++++--
 1 file changed, 26 insertions(+), 2 deletions(-)
include/drm/drm_bridge.h +26 -2
index 2195daa289d2..6805898d70f5 100644
@@ -171,6 +171,11 @@ struct drm_bridge_funcs {
 	 * signals) feeding it is still running when this callback is called.
 	 *
 	 * The @disable callback is optional.
+	 *
+	 * NOTE:
+	 *
+	 * This is deprecated, do not use!
+	 * New drivers shall use &drm_bridge_funcs.atomic_disable.
 	 */
 	void (*disable)(struct drm_bridge *bridge);
 
@@ -190,6 +195,11 @@ struct drm_bridge_funcs {
 	 * called.
 	 *
 	 * The @post_disable callback is optional.
+	 *
+	 * NOTE:
+	 *
+	 * This is deprecated, do not use!
+	 * New drivers shall use &drm_bridge_funcs.atomic_post_disable.
 	 */
 	void (*post_disable)(struct drm_bridge *bridge);
 
@@ -213,11 +223,15 @@ struct drm_bridge_funcs {
 	 * For atomic drivers the adjusted_mode is the mode stored in
 	 * &drm_crtc_state.adjusted_mode.
 	 *
-	 * NOTE:
-	 *
 	 * If a need arises to store and access modes adjusted for other
 	 * locations than the connection between the CRTC and the first bridge,
 	 * the DRM framework will have to be extended with DRM bridge states.
+	 *
+	 * NOTE:
+	 *
+	 * This is deprecated, do not use!
+	 * New drivers shall set their mode in &drm_bridge_funcs.atomic_enable
+	 * operation.
 	 */
 	void (*mode_set)(struct drm_bridge *bridge,
 			 const struct drm_display_mode *mode,
@@ -239,6 +253,11 @@ struct drm_bridge_funcs {
 	 * there is one) when this callback is called.
 	 *
 	 * The @pre_enable callback is optional.
+	 *
+	 * NOTE:
+	 *
+	 * This is deprecated, do not use!
+	 * New drivers shall use &drm_bridge_funcs.atomic_pre_enable.
 	 */
 	void (*pre_enable)(struct drm_bridge *bridge);
 
@@ -259,6 +278,11 @@ struct drm_bridge_funcs {
 	 * chain if there is one.
 	 *
 	 * The @enable callback is optional.
+	 *
+	 * NOTE:
+	 *
+	 * This is deprecated, do not use!
+	 * New drivers shall use &drm_bridge_funcs.atomic_enable.
 	 */
 	void (*enable)(struct drm_bridge *bridge);
 
Signature · 1 line
2.30.2
#2 lore raw

Re: [PATCH 1/1] drm: bridge: Mark deprecated operations in drm_bridge_funcs

Quoted 5 lines · Sam Ravnborg

drm_bridge_funcs includes several duplicated operations as atomic variants has been added over time.
New bridge drivers shall use the atomic variants - mark the deprecated operations to try to avoid usage in new bridge drivers.

Quoted 8 lines
Cc Laurent Pinchart <[email protected]>
Cc Andrzej Hajda <[email protected]>
Cc Maarten Lankhorst <[email protected]>
Cc Maxime Ripard <[email protected]>
Cc Thomas Zimmermann <[email protected]>
Cc David Airlie <[email protected]>
Cc Daniel Vetter <[email protected]>

Ignore this patch - I managed to chain the wrong patch to the cover letter.

Sam