net/mvpp2: fix declare unsupported vlan offload features
PATCH 1/1 net/mvpp2: fix declare unsupported vlan offload features
From: Meir Levi <[email protected]>
vlan_strip and vlan_extend features need to return "unsupported" error value.
Fixes ff0b8b10dc4 ("net/mvpp2: support VLAN offload")
Signed-off-by Meir Levi <[email protected]>
Reviewed-by Liron Himi <[email protected]>
--- drivers/net/mvpp2/mrvl_ethdev.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-)
drivers/net/mvpp2/mrvl_ethdev.c +6 -2
@@ -1873,8 +1873,10 @@ static int mrvl_vlan_offload_set(struct rte_eth_dev *dev, int mask)uint64_t rx_offloads = dev->data->dev_conf.rxmode.offloads;int ret; -if (mask Ð_VLAN_STRIP_MASK ) +if (mask Ð_VLAN_STRIP_MASK ) {MRVL_LOG (ERR ,"VLAN stripping is not supported\n" ); +return -ENOTSUP ; + }if (mask Ð_VLAN_FILTER_MASK ) {if (rx_offloads &DEV_RX_OFFLOAD_VLAN_FILTER )
@@ -1886,8 +1888,10 @@ static int mrvl_vlan_offload_set(struct rte_eth_dev *dev, int mask)return ret; } -if (mask Ð_VLAN_EXTEND_MASK ) +if (mask Ð_VLAN_EXTEND_MASK ) {MRVL_LOG (ERR ,"Extend VLAN not supported\n" ); +return -ENOTSUP ; + }return 0 ; }
Signature · 1 line
2.17.1
Jerin Jacob
AppliedQuoted 11 lines · On Sun, Jul 11, 2021 at 6:43 PM <[email protected]> wrote:
From: Meir Levi <[email protected]>
vlan_stripandvlan_extendfeatures need to return "unsupported" error value.Fixes ff0b8b10dc4 ("net/mvpp2: support VLAN offload")Signed-off-by Meir Levi <[email protected]>Reviewed-by Liron Himi <[email protected]>
Changed the subject to net/mvpp2: fix VLAN ops return code
Applied to dpdk-next-net-mrvl/for-next-net. Thanks
Quoted 35 lines
--- drivers/net/mvpp2/mrvl_ethdev.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-)drivers/net/mvpp2/mrvl_ethdev.c +6
-3@@ -1873,8 +1873,10 @@ static int mrvl_vlan_offload_set(struct rte_eth_dev *dev, int mask)uint64_t rx_offloads = dev->data->dev_conf.rxmode.offloads;int ret; -if (mask Ð_VLAN_STRIP_MASK ) +if (mask Ð_VLAN_STRIP_MASK ) {MRVL_LOG (ERR ,"VLAN stripping is not supported\n" ); +return -ENOTSUP ; + }if (mask Ð_VLAN_FILTER_MASK ) {if (rx_offloads &DEV_RX_OFFLOAD_VLAN_FILTER )@@ -1886,8 +1888,10 @@ static int mrvl_vlan_offload_set(struct rte_eth_dev *dev, int mask)return ret; } -if (mask Ð_VLAN_EXTEND_MASK ) +if (mask Ð_VLAN_EXTEND_MASK ) {MRVL_LOG (ERR ,"Extend VLAN not supported\n" ); +return -ENOTSUP ; + }return 0 ; } --2.17.1