Skip to contentSkip to conversation

net/mvpp2: fix declare unsupported vlan offload features

PATCH Applied [email protected] 2 participants 2 messages Jul 11, 2021 – Jul 12, 2021 Network drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net/mvpp2: fix declare unsupported vlan offload features

From: Meir Levi <[email protected]>

vlan_strip and vlan_extend features need to return "unsupported" error value.

Fixes ff0b8b10dc4 ("net/mvpp2: support VLAN offload")
---
 drivers/net/mvpp2/mrvl_ethdev.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)
drivers/net/mvpp2/mrvl_ethdev.c +6 -2
index 1802695a0e..078aefbb8d 100644
@@ -1873,8 +1873,10 @@ static int mrvl_vlan_offload_set(struct rte_eth_dev *dev, int mask)
 	uint64_t rx_offloads = dev->data->dev_conf.rxmode.offloads;
 	int ret;
 
-	if (mask & ETH_VLAN_STRIP_MASK)
+	if (mask & ETH_VLAN_STRIP_MASK) {
 		MRVL_LOG(ERR, "VLAN stripping is not supported\n");
+		return -ENOTSUP;
+	}
 
 	if (mask & ETH_VLAN_FILTER_MASK) {
 		if (rx_offloads & DEV_RX_OFFLOAD_VLAN_FILTER)
@@ -1886,8 +1888,10 @@ static int mrvl_vlan_offload_set(struct rte_eth_dev *dev, int mask)
 			return ret;
 	}
 
-	if (mask & ETH_VLAN_EXTEND_MASK)
+	if (mask & ETH_VLAN_EXTEND_MASK) {
 		MRVL_LOG(ERR, "Extend VLAN not supported\n");
+		return -ENOTSUP;
+	}
 
 	return 0;
 }
Signature · 1 line
2.17.1
Applied
#1 lore raw
Quoted 11 lines · On Sun, Jul 11, 2021 at 6:43 PM <[email protected]> wrote:

From: Meir Levi <[email protected]>

vlan_strip and vlan_extend features need to return "unsupported" error value.

Fixes ff0b8b10dc4 ("net/mvpp2: support VLAN offload")

Changed the subject to net/mvpp2: fix VLAN ops return code

Applied to dpdk-next-net-mrvl/for-next-net. Thanks

Quoted 35 lines
---
 drivers/net/mvpp2/mrvl_ethdev.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)
drivers/net/mvpp2/mrvl_ethdev.c +6 -3
index 1802695a0e..078aefbb8d 100644
@@ -1873,8 +1873,10 @@ static int mrvl_vlan_offload_set(struct rte_eth_dev *dev, int mask)
        uint64_t rx_offloads = dev->data->dev_conf.rxmode.offloads;
        int ret;
 
-       if (mask & ETH_VLAN_STRIP_MASK)
+       if (mask & ETH_VLAN_STRIP_MASK) {
                MRVL_LOG(ERR, "VLAN stripping is not supported\n");
+               return -ENOTSUP;
+       }
 
        if (mask & ETH_VLAN_FILTER_MASK) {
                if (rx_offloads & DEV_RX_OFFLOAD_VLAN_FILTER)
@@ -1886,8 +1888,10 @@ static int mrvl_vlan_offload_set(struct rte_eth_dev *dev, int mask)
                        return ret;
        }
 
-       if (mask & ETH_VLAN_EXTEND_MASK)
+       if (mask & ETH_VLAN_EXTEND_MASK) {
                MRVL_LOG(ERR, "Extend VLAN not supported\n");
+               return -ENOTSUP;
+       }
 
        return 0;
 }
--

2.17.1