Skip to contentSkip to conversation

net: use %px to print skb address in trace_netif_receive_skb

PATCH Superseded Cong Wang 1 participant 2 messages Jul 11, 2021

Subsystems (3)
lore
Share & tools
lore

Cong Wang

author
#0 lore raw

PATCH v2 1/1 net: use %px to print skb address in trace_netif_receive_skb

From: Qitao Xu <[email protected]>

The print format of skb adress in tracepoint class net_dev_template is changed to %px from %p, because we want to use skb address as a quick way to identify a packet.

Note, trace ring buffer is only accessible to privileged users, it is safe to use a real kernel address here.

---
 include/trace/events/net.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/trace/events/net.h +1 -1
index 2399073c3afc..78c448c6ab4c 100644
@@ -136,7 +136,7 @@ DECLARE_EVENT_CLASS(net_dev_template,
 		__assign_str(name, skb->dev->name);
 	),
 
-	TP_printk("dev=%s skbaddr=%p len=%u",
+	TP_printk("dev=%s skbaddr=%px len=%u",
 		__get_str(name), __entry->skbaddr, __entry->len)
 )
 
Signature · 1 line
2.27.0
author
#1 lore raw

PATCH v2 1/1 net_sched: use %px to print skb address in trace_qdisc_dequeue()

From: Qitao Xu <[email protected]>

Print format of skbaddr is changed to %px from %p, because we want to use skb address as a quick way to identify a packet.

Note, trace ring buffer is only accessible to privileged users, it is safe to use a real kernel address here.

Cc Jesper Dangaard Brouer <[email protected]>
---
 include/trace/events/qdisc.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/trace/events/qdisc.h +1 -1
index 330d32d84485..58209557cb3a 100644
@@ -41,7 +41,7 @@ TRACE_EVENT(qdisc_dequeue,
 		__entry->txq_state	= txq->state;
 	),
 
-	TP_printk("dequeue ifindex=%d qdisc handle=0x%X parent=0x%X txq_state=0x%lX packets=%d skbaddr=%p",
+	TP_printk("dequeue ifindex=%d qdisc handle=0x%X parent=0x%X txq_state=0x%lX packets=%d skbaddr=%px",
 		  __entry->ifindex, __entry->handle, __entry->parent,
 		  __entry->txq_state, __entry->packets, __entry->skbaddr )
 );
Signature · 1 line
2.27.0