drm/mediatek: dpi: fix NULL dereference in mtk_dpi_bridge_atomic_check
Subsystems (3)
PATCH 1/1 drm/mediatek: dpi: fix NULL dereference in mtk_dpi_bridge_atomic_check
From: Frank Wunderlich <[email protected]>
bridge->driver_private is not set (NULL) so use bridge_to_dpi(bridge) like it's done in bridge_atomic_get_output_bus_fmts
--- drivers/gpu/drm/mediatek/mtk_dpi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/mediatek/mtk_dpi.c +1 -1
@@ -605,7 +605,7 @@ static int mtk_dpi_bridge_atomic_check(struct drm_bridge *bridge,struct drm_crtc_state *crtc_state, struct drm_connector_state *conn_state) { - struct mtk_dpi *dpi = bridge->driver_private; + struct mtk_dpi *dpi = bridge_to_dpi(bridge);unsigned int out_bus_format; out_bus_format = bridge_state->output_bus_cfg.format;
Signature · 7 lines
2.25.1 _______________________________________________ Linux-mediatek mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-mediatek
Quoted 8 lines · Frank Wunderlich
From: Frank Wunderlich <[email protected]>
bridge->driver_privateis not set (NULL) so usebridge_to_dpi(bridge)like it's done inbridge_atomic_get_output_bus_fmtsFixes ec8747c52434 ("drm/mediatek: dpi: Add bus format negotiation")Signed-off-by Frank Wunderlich <[email protected]>
Tested on a mt8183 device.
Quoted 25 lines
--- drivers/gpu/drm/mediatek/mtk_dpi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/mediatek/mtk_dpi.c +1
-2@@ -605,7 +605,7 @@ static int mtk_dpi_bridge_atomic_check(struct drm_bridge *bridge,struct drm_crtc_state *crtc_state, struct drm_connector_state *conn_state) { - struct mtk_dpi *dpi = bridge->driver_private; + struct mtk_dpi *dpi = bridge_to_dpi(bridge);unsigned int out_bus_format; out_bus_format = bridge_state->output_bus_cfg.format; --2.25.1
_______________________________________________
Linux-mediatek mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-mediatek
Hi, Frank:
Quoted 4 lines · Frank Wunderlich
From: Frank Wunderlich <[email protected]>
bridge->driver_privateis not set (NULL) so usebridge_to_dpi(bridge)like it's done inbridge_atomic_get_output_bus_fmts
Quoted 20 lines
Fixes ec8747c52434 ("drm/mediatek: dpi: Add bus format negotiation")Signed-off-by Frank Wunderlich <[email protected]>--- drivers/gpu/drm/mediatek/mtk_dpi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/mediatek/mtk_dpi.c +1
-1@@ -605,7 +605,7 @@ static int mtk_dpi_bridge_atomic_check(struct drm_bridge *bridge,struct drm_crtc_state *crtc_state, struct drm_connector_state *conn_state) { - struct mtk_dpi *dpi = bridge->driver_private; + struct mtk_dpi *dpi = bridge_to_dpi(bridge);unsigned int out_bus_format; out_bus_format = bridge_state->output_bus_cfg.format;
Hi, Frank:
Frank Wunderlich <[email protected]> 於 2021年7月12日 週一 下午4:08寫道:
Quoted 5 lines
From: Frank Wunderlich <[email protected]>
bridge->driver_privateis not set (NULL) so usebridge_to_dpi(bridge)like it's done inbridge_atomic_get_output_bus_fmts
Applied to mediatek-drm-fixes [1], thanks.
[1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-fixes
Regards,
Chun-Kuang.
Quoted 28 lines
Fixes ec8747c52434 ("drm/mediatek: dpi: Add bus format negotiation")Signed-off-by Frank Wunderlich <[email protected]>--- drivers/gpu/drm/mediatek/mtk_dpi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/mediatek/mtk_dpi.c +1
-2@@ -605,7 +605,7 @@ static int mtk_dpi_bridge_atomic_check(struct drm_bridge *bridge,struct drm_crtc_state *crtc_state, struct drm_connector_state *conn_state) { - struct mtk_dpi *dpi = bridge->driver_private; + struct mtk_dpi *dpi = bridge_to_dpi(bridge);unsigned int out_bus_format; out_bus_format = bridge_state->output_bus_cfg.format; --2.25.1
_______________________________________________
Linux-mediatek mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-mediatek