cifs: fix the out of range assignment to bit fields in parse_server_interfaces
Subsystems (2)
PATCH 1/1 cifs: fix the out of range assignment to bit fields in parse_server_interfaces
Because the out of range assignment to bit fields are compiler-dependant, the fields could have wrong value.
Signed-off-by Hyunchul Lee <[email protected]>
--- fs/cifs/smb2ops.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
fs/cifs/smb2ops.c +2 -2
@@ -557,8 +557,8 @@ parse_server_interfaces(struct network_interface_info_ioctl_rsp *buf, p = buf;while (bytes_left >=sizeof (*p)) { info->speed =le64_to_cpu (p->LinkSpeed); - info->rdma_capable =le32_to_cpu (p->Capability &RDMA_CAPABLE ); - info->rss_capable =le32_to_cpu (p->Capability &RSS_CAPABLE ); + info->rdma_capable =le32_to_cpu (p->Capability &RDMA_CAPABLE ) ?1 :0 ; + info->rss_capable =le32_to_cpu (p->Capability &RSS_CAPABLE ) ?1 :0 ;cifs_dbg (FYI ,"%s: adding iface %zu\n" , __func__, *iface_count);cifs_dbg (FYI ,"%s: speed %zu bps\n" , __func__, info->speed);
Signature · 1 line
2.17.1