Skip to contentSkip to conversation

nds32/setup: remove unused memblock_region variable in setup_memory()

PATCH Applied Mike Rapoport 2 participants 2 messages Jul 12, 2021 – Sep 8, 2021 Memory management

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 nds32/setup: remove unused memblock_region variable in setup_memory()

From: Mike Rapoport <[email protected]>

kernel test robot reports unused variable warning:

cppcheck possible warnings: (new ones prefixed by >>, may not real problems)

Quoted 2 lines
Quoted 2 lines

arch/nds32/kernel/setup.c:247:26: warning: Unused variable: region [unusedVariable]

    struct memblock_region *region;
                            ^

Remove the unused variable.

---
 arch/nds32/kernel/setup.c | 1 -
 1 file changed, 1 deletion(-)
arch/nds32/kernel/setup.c +0 -1
index 41725eaf8bac..b3d34d646652 100644
@@ -244,7 +244,6 @@ static void __init setup_memory(void)
 	unsigned long ram_start_pfn;
 	unsigned long free_ram_start_pfn;
 	phys_addr_t memory_start, memory_end;
-	struct memblock_region *region;
 
 	memory_end = memory_start = 0;
 

base-commit: e73f0f0ee7541171d89f2e2491130c7771ba58d3

Signature · 1 line
2.28.0
Reviewed-by Tested-by on v1 1/1
#1 lore raw
Quoted 9 lines · Mike Rapoport

From: Mike Rapoport <[email protected]>

kernel test robot reports unused variable warning:

cppcheck possible warnings: (new ones prefixed by >>, may not real problems)

Quoted 2 lines
Quoted 2 lines

arch/nds32/kernel/setup.c:247:26: warning: Unused variable: region [unusedVariable]

Quoted 7 lines
    struct memblock_region *region;
                            ^

Remove the unused variable.

This is now fatal.

arch/nds32/kernel/setup.c: In function 'setup_memory':
arch/nds32/kernel/setup.c:247:26: error: unused variable 'region'

Anyone care to apply it ?

Guenter

Quoted 21 lines
---
 arch/nds32/kernel/setup.c | 1 -
 1 file changed, 1 deletion(-)
arch/nds32/kernel/setup.c +0 -1
index 41725eaf8bac..b3d34d646652 100644
@@ -244,7 +244,6 @@ static void __init setup_memory(void)
 	unsigned long ram_start_pfn;
 	unsigned long free_ram_start_pfn;
 	phys_addr_t memory_start, memory_end;
-	struct memblock_region *region;
 
 	memory_end = memory_start = 0;
 

base-commit: e73f0f0ee7541171d89f2e2491130c7771ba58d3

Signature · 1 line
2.28.0