mv64361: Remove extra break from a switch case
PATCH 1/1 mv64361: Remove extra break from a switch case
The switch case of writing PCI 1 IO base address had an extra break statement that made part of the code unreachable. This did not cause a problem as guests ususally leave this register at its default value.
--- hw/pci-host/mv64361.c | 1 - 1 file changed, 1 deletion(-)
hw/pci-host/mv64361.c +0 -1
@@ -687,7 +687,6 @@ static void mv64361_write(void *opaque, hwaddr addr, uint64_t val,case MV64340_PCI_1_IO_BASE_ADDR : s->pci[1 ].io_base = val &0x30fffffULL ;warn_swap_bit (val); -break ;if (!(s->cpu_conf &BIT (27 ))) { s->pci[1 ].remap[4 ] = (val &0xffffULL ) <<16 ; }
Signature · 1 line
2.21.4
Quoted 5 lines · BALATON Zoltan
The switch case of writing PCI 1 IO base address had an extra break statement that made part of the code unreachable. This did not cause a problem as guests ususally leave this register at its default value.
Reported-by Coverity (CID 1458135)
controller")
?
Quoted 18 lines
Signed-off-by BALATON Zoltan <[email protected]>--- hw/pci-host/mv64361.c | 1 - 1 file changed, 1 deletion(-)hw/pci-host/mv64361.c +0
-1@@ -687,7 +687,6 @@ static void mv64361_write(void *opaque, hwaddr addr, uint64_t val,case MV64340_PCI_1_IO_BASE_ADDR : s->pci[1 ].io_base = val &0x30fffffULL ;warn_swap_bit (val); -break ;if (!(s->cpu_conf &BIT (27 ))) { s->pci[1 ].remap[4 ] = (val &0xffffULL ) <<16 ; }
Quoted 10 lines · Philippe Mathieu-Daudé
Quoted 5 lines · BALATON Zoltan
The switch case of writing PCI 1 IO base address had an extra break statement that made part of the code unreachable. This did not cause a problem as guests ususally leave this register at its default value.
Reported-by Coverity (CID 1458135)Fixes dcdf98a9015 ("Add emulation of Marvell MV64361 PPC systemcontroller")
?
Yeah, why not. Feel free to add the Fixes tag when merging, although that's the only commit this file had so far so linking to it does not seem to add much more info.
Regards,
BALATON Zoltan
Quoted 20 lines
Quoted 18 lines
Signed-off-by BALATON Zoltan <[email protected]>--- hw/pci-host/mv64361.c | 1 - 1 file changed, 1 deletion(-)hw/pci-host/mv64361.c +0
-1@@ -687,7 +687,6 @@ static void mv64361_write(void *opaque, hwaddr addr, uint64_t val,case MV64340_PCI_1_IO_BASE_ADDR : s->pci[1 ].io_base = val &0x30fffffULL ;warn_swap_bit (val); -break ;if (!(s->cpu_conf &BIT (27 ))) { s->pci[1 ].remap[4 ] = (val &0xffffULL ) <<16 ; }
David Gibson
AppliedQuoted 6 lines · BALATON Zoltan
The switch case of writing PCI 1 IO base address had an extra break statement that made part of the code unreachable. This did not cause a problem as guests ususally leave this register at its default value.
Reported-by Coverity (CID 1458135)Signed-off-by BALATON Zoltan <[email protected]>
Applied to ppc-for-6.1, thanks.
Quoted 16 lines
--- hw/pci-host/mv64361.c | 1 - 1 file changed, 1 deletion(-)hw/pci-host/mv64361.c +0
-1@@ -687,7 +687,6 @@ static void mv64361_write(void *opaque, hwaddr addr, uint64_t val,case MV64340_PCI_1_IO_BASE_ADDR : s->pci[1 ].io_base = val &0x30fffffULL ;warn_swap_bit (val); -break ;if (!(s->cpu_conf &BIT (27 ))) { s->pci[1 ].remap[4 ] = (val &0xffffULL ) <<16 ; }
Signature · 4 lines
David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson