ray_cs: use %*ph to print small buffer
Subsystems (3)
PATCH 1/1 ray_cs: use %*ph to print small buffer
Use %*ph format to print small buffer as hex string.
--- drivers/net/wireless/ray_cs.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/net/wireless/ray_cs.c +1 -3
@@ -2424,9 +2424,7 @@ static void rx_authenticate(ray_dev_t *local, struct rcs __iomem *prcs,copy_from_rx_buff (local, buff, pkt_addr, rx_len &0xff );/* if we are trying to get authenticated */ if (local->sparm.b4.a_network_type ==ADHOC ) { -pr_debug ("ray_cs rx_auth var= %02x %02x %02x %02x %02x %02x\n" , - msg->var[0 ], msg->var[1 ], msg->var[2 ], msg->var[3 ], - msg->var[4 ], msg->var[5 ]); +pr_debug ("ray_cs rx_auth var= %6ph\n" , msg->var);if (msg->var[2 ] ==1 ) {pr_debug ("ray_cs Sending authentication response.\n" ); if (!build_auth_frame
Signature · 1 line
2.30.2
Quoted 3 lines · Andy Shevchenko
Use %*ph format to print small buffer as hex string.
Signed-off-by Andy Shevchenko <[email protected]>
Patch applied to wireless-drivers-next.git, thanks.
502213fd8fca ray_cs: use %*ph to print small buffer
Signature · 3 lines
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Quoted 10 lines · Kalle Valo
Quoted 3 lines · Andy Shevchenko
Use %*ph format to print small buffer as hex string.
Signed-off-by Andy Shevchenko <[email protected]>Patch applied to wireless-drivers-next.git, thanks.
502213fd8fcaray_cs: use %*ph to print small buffer
There's one more of these in the same file but it's in an #ifdef 0 block...
--- drivers/net/wireless/ray_cs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/net/wireless/ray_cs.c +2 -2
@@ -2284,9 +2284,9 @@ static void untranslate(ray_dev_t *local, struct sk_buff *skb, int len)DUMP_PREFIX_NONE ,16 ,1 , skb->data, 64, true);printk (KERN_DEBUG -"type = %08x, xsap = %02x%02x%02x, org = %02x02x02x\n" , +"type = %08x, xsap = %02x%02x%02x, org = %3phN\n" ,ntohs (type), psnap->dsap, psnap->ssap, psnap->ctrl, - psnap->org[0 ], psnap->org[1 ], psnap->org[2 ]); + psnap->org); printk(KERN_DEBUG "untranslate skb->data = %p\n", skb->data); }#endif
Quoted 5 lines · Joe Perches
Quoted 4 lines · Kalle Valo
Quoted 2 lines · Andy Shevchenko
Use %*ph format to print small buffer as hex string.
Quoted 8 lines
Quoted 6 lines
Quoted 1 line
Signed-off-by Andy Shevchenko <[email protected]>Patch applied to wireless-drivers-next.git, thanks.
502213fd8fcaray_cs: use %*ph to print small bufferThere's one more of these in the same file but it's in an #ifdef 0 block...
I would rather remove the whole ifdef 0 block, patches welcome.
Signature · 3 lines
https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Quoted 9 lines · Kalle Valo
Quoted 7 lines · Joe Perches
Quoted 6 lines · Kalle Valo
Quoted 3 lines · Andy Shevchenko
Use %*ph format to print small buffer as hex string.
Signed-off-by Andy Shevchenko <[email protected]>
Quoted 9 lines
Quoted 6 lines
Quoted 4 lines
Patch applied to wireless-drivers-next.git, thanks.
502213fd8fcaray_cs: use %*ph to print small bufferThere's one more of these in the same file but it's in an #ifdef 0 block...
I would rather remove the whole ifdef 0 block, patches welcome.
It'd probably take you about 20 seconds if you do it yourself.
$ git grep -P -n '^\s*#\s*if\s+0\b' drivers/net/wireless/ray_cs.c drivers/net/wireless/ray_cs.c:637:#if 0 drivers/net/wireless/ray_cs.c:2281:#if 0 drivers/net/wireless/ray_cs.c:2341:#if 0
Rather a bit more time if you want to do the whole kernel...
$ git grep -P -n '^\s*#\s*if\s+0\b' | wc -l 1558