netlink_delinearize: stmt and expr error path memleaks
Pablo Neira Ayuso
maintainerPATCH 1/1 netlink_delinearize: stmt and expr error path memleaks
Use stmt_free() and expr_free() to release these objects.
Fixes 671851617c8d ("netlink_delinearize: Fix resource leaks")
Fixes 3a8640672978 ("src: hash: support of symmetric hash")
Signed-off-by Pablo Neira Ayuso <[email protected]>
--- src/netlink_delinearize.c | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-)
src/netlink_delinearize.c +10 -10
@@ -637,7 +637,7 @@ static void netlink_parse_exthdr(struct netlink_parse_ctx *ctx, sreg =netlink_parse_register (nle,NFTNL_EXPR_EXTHDR_SREG ); val =netlink_get_register (ctx, loc, sreg);if (val ==NULL ) { -xfree (expr); +expr_free (expr);return netlink_error (ctx, loc,"exthdr statement has no expression" ); }
@@ -679,7 +679,7 @@ static void netlink_parse_hash(struct netlink_parse_ctx *ctx, len =nftnl_expr_get_u32 (nle,NFTNL_EXPR_HASH_LEN ) *BITS_PER_BYTE ;if (hexpr->len < len) { -xfree (hexpr); +expr_free (hexpr); hexpr =netlink_parse_concat_expr (ctx, loc, sreg, len);if (hexpr ==NULL ) goto out_err;
@@ -691,7 +691,7 @@ static void netlink_parse_hash(struct netlink_parse_ctx *ctx,netlink_set_register (ctx, dreg, expr);return ; out_err: -xfree (expr); +expr_free (expr); } static void netlink_parse_fib(struct netlink_parse_ctx *ctx,
@@ -1196,7 +1196,7 @@ static void netlink_parse_nat(struct netlink_parse_ctx *ctx, ctx->stmt = stmt;return ; out_err: -xfree (stmt); +stmt_free (stmt); } static void netlink_parse_synproxy(struct netlink_parse_ctx *ctx,
@@ -1260,7 +1260,7 @@ static void netlink_parse_tproxy(struct netlink_parse_ctx *ctx, ctx->stmt = stmt;return ; err: -xfree (stmt); +stmt_free (stmt); } static void netlink_parse_masq(struct netlink_parse_ctx *ctx,
@@ -1307,7 +1307,7 @@ static void netlink_parse_masq(struct netlink_parse_ctx *ctx, ctx->stmt = stmt;return ; out_err: -xfree (stmt); +stmt_free (stmt); } static void netlink_parse_redir(struct netlink_parse_ctx *ctx,
@@ -1358,7 +1358,7 @@ static void netlink_parse_redir(struct netlink_parse_ctx *ctx, ctx->stmt = stmt;return ; out_err: -xfree (stmt); +stmt_free (stmt); } static void netlink_parse_dup(struct netlink_parse_ctx *ctx,
@@ -1411,7 +1411,7 @@ static void netlink_parse_dup(struct netlink_parse_ctx *ctx, ctx->stmt = stmt;return ; out_err: -xfree (stmt); +stmt_free (stmt); } static void netlink_parse_fwd(struct netlink_parse_ctx *ctx,
@@ -1473,7 +1473,7 @@ static void netlink_parse_fwd(struct netlink_parse_ctx *ctx, ctx->stmt = stmt;return ; out_err: -xfree (stmt); +stmt_free (stmt); } static void netlink_parse_queue(struct netlink_parse_ctx *ctx,
@@ -1636,7 +1636,7 @@ out_err:list_for_each_entry_safe (dstmt, next, &dynset_parse_ctx.stmt_list, list)stmt_free (dstmt); -xfree (expr); +expr_free (expr); } static void netlink_parse_objref(struct netlink_parse_ctx *ctx,
Signature · 1 line
2.20.1