Skip to contentSkip to conversation

net: dpaa2-mac: add support for more ethtool 10G link modes

RFC PATCH In review Russell King 3 participants 3 messages Jul 12, 2021 – Jul 19, 2021

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

RFC PATCH 1/1 net: dpaa2-mac: add support for more ethtool 10G link modes

Phylink documentation says:
* Note that the PHY may be able to transform from one connection
* technology to another, so, eg, don't clear 1000BaseX just
* because the MAC is unable to BaseX mode. This is more about
* clearing unsupported speeds and duplex settings. The port modes
* should not be cleared; phylink_set_port_modes() will help with this.

So add the missing 10G modes.

---
net-next is currently closed, but I'd like to collect acks for this patch. Thanks.

 drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c | 5 +++++
 1 file changed, 5 insertions(+)
drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c +5 -0
index ae6d382d8735..543c1f202420 100644
@@ -140,6 +140,11 @@ static void dpaa2_mac_validate(struct phylink_config *config,
 	case PHY_INTERFACE_MODE_10GBASER:
 	case PHY_INTERFACE_MODE_USXGMII:
 		phylink_set(mask, 10000baseT_Full);
+		phylink_set(mask, 10000baseCR_Full);
+		phylink_set(mask, 10000baseSR_Full);
+		phylink_set(mask, 10000baseLR_Full);
+		phylink_set(mask, 10000baseLRM_Full);
+		phylink_set(mask, 10000baseER_Full);
 		if (state->interface == PHY_INTERFACE_MODE_10GBASER)
 			break;
 		phylink_set(mask, 5000baseT_Full);
Signature · 1 line
2.20.1
Acked-by on v1 1/1
#1 lore raw

Hi Russell,

Quoted 6 lines · On Mon, 12 Jul 2021 16:47:10 +0100 Russell King <[email protected]>…

Phylink documentation says:
* Note that the PHY may be able to transform from one connection
* technology to another, so, eg, don't clear 1000BaseX just
* because the MAC is unable to BaseX mode. This is more about
* clearing unsupported speeds and duplex settings. The port modes
* should not be cleared; phylink_set_port_modes() will help with this.

At first I thought these are points as in Markdown. Maybe remove the asterisks from the commit message, next time :)

Quoted 17 lines

So add the missing 10G modes.

---
net-next is currently closed, but I'd like to collect acks for this patch. Thanks.

 drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c | 5 +++++
 1 file changed, 5 insertions(+)
drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c +0 -0
index ae6d382d8735..543c1f202420 100644
@@ -140,6 +140,11 @@ static void dpaa2_mac_validate(struct phylink_config *config,
 	case PHY_INTERFACE_MODE_10GBASER:

drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c static void dpaa2_mac_validate(struct phylink_config *config, · line 150

Quoted 10 lines
drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c +5 -0
 	case PHY_INTERFACE_MODE_USXGMII:
 		phylink_set(mask, 10000baseT_Full);
+		phylink_set(mask, 10000baseCR_Full);
+		phylink_set(mask, 10000baseSR_Full);
+		phylink_set(mask, 10000baseLR_Full);
+		phylink_set(mask, 10000baseLRM_Full);
+		phylink_set(mask, 10000baseER_Full);
 		if (state->interface == PHY_INTERFACE_MODE_10GBASER)
 			break;
 		phylink_set(mask, 5000baseT_Full);
maintainer Acked-by on v1 1/1
#2 lore raw
In reply to Russell King
Quoted 10 lines · Russell King

Phylink documentation says:
* Note that the PHY may be able to transform from one connection
* technology to another, so, eg, don't clear 1000BaseX just
* because the MAC is unable to BaseX mode. This is more about
* clearing unsupported speeds and duplex settings. The port modes
* should not be cleared; phylink_set_port_modes() will help with this.

So add the missing 10G modes.

Quoted 26 lines

---
net-next is currently closed, but I'd like to collect acks for this patch. Thanks.

 drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c | 5 +++++
 1 file changed, 5 insertions(+)
drivers/net/ethernet/freescale/dpaa2/dpaa2-mac.c +5 -0
index ae6d382d8735..543c1f202420 100644
@@ -140,6 +140,11 @@ static void dpaa2_mac_validate(struct phylink_config *config,
 	case PHY_INTERFACE_MODE_10GBASER:
 	case PHY_INTERFACE_MODE_USXGMII:
 		phylink_set(mask, 10000baseT_Full);
+		phylink_set(mask, 10000baseCR_Full);
+		phylink_set(mask, 10000baseSR_Full);
+		phylink_set(mask, 10000baseLR_Full);
+		phylink_set(mask, 10000baseLRM_Full);
+		phylink_set(mask, 10000baseER_Full);
 		if (state->interface == PHY_INTERFACE_MODE_10GBASER)
 			break;
 		phylink_set(mask, 5000baseT_Full);
Signature · 1 line
2.20.1