Skip to contentSkip to conversation

net/ice/base: revert the change of first profile mask

PATCH Superseded Wenjun Wu 2 participants 3 messages Jul 13, 2021 Network drivers

lore
Share & tools
lore

Wenjun Wu

author
#0 lore raw

PATCH 1/1 net/ice/base: revert the change of first profile mask

Segmentation fault mentioned in patch[1] is related to hardware issue.
This patch revert patch[1], since patch[1] may have protential risk and side effect if the first profile mask is set to 0.

[1]:
commit 148fdf2d3537 ("net/ice/base: fix first profile mask")

---
 drivers/net/ice/base/ice_flex_pipe.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ice/base/ice_flex_pipe.c +1 -1
index 829d88bba6..b3cea731f3 100644
@@ -3432,7 +3432,7 @@ static void ice_init_prof_masks(struct ice_hw *hw, enum ice_block blk)
 	per_pf = ICE_PROF_MASK_COUNT / hw->dev_caps.num_funcs;
 
 	hw->blk[blk].masks.count = per_pf;
-	hw->blk[blk].masks.first = 0;
+	hw->blk[blk].masks.first = hw->pf_id * per_pf;
 
 	ice_memset(hw->blk[blk].masks.masks, 0,
 		   sizeof(hw->blk[blk].masks.masks), ICE_NONDMA_MEM);
Signature · 1 line
2.25.1
author
#1 lore raw

PATCH v2 1/1 net/ice/base: revert the change of first profile mask

Segmentation fault mentioned in patch[1] is related to hardware issue.
This patch revert patch[1], since patch[1] may have potential risk and side effect if the first profile mask is set to 0.

[1]:
commit 148fdf2d3537 ("net/ice/base: fix first profile mask")

---
v2: correct misspelling in commit message.

---
 drivers/net/ice/base/ice_flex_pipe.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ice/base/ice_flex_pipe.c +1 -1
index 829d88bba6..b3cea731f3 100644
@@ -3432,7 +3432,7 @@ static void ice_init_prof_masks(struct ice_hw *hw, enum ice_block blk)
 	per_pf = ICE_PROF_MASK_COUNT / hw->dev_caps.num_funcs;
 
 	hw->blk[blk].masks.count = per_pf;
-	hw->blk[blk].masks.first = 0;
+	hw->blk[blk].masks.first = hw->pf_id * per_pf;
 
 	ice_memset(hw->blk[blk].masks.masks, 0,
 		   sizeof(hw->blk[blk].masks.masks), ICE_NONDMA_MEM);
Signature · 1 line
2.25.1
Acked-by on v2 1/1 Applied
#2 lore raw
Quoted 10 lines

-----Original Message-----
From: Wu, Wenjun1 <[email protected]>
Sent: Tuesday, July 13, 2021 10:31 AM
To: [email protected]; Yang, Qiming <[email protected]>; Zhang, Qi Z <[email protected]>
Cc: Wu, Wenjun1 <[email protected]>
Subject: [PATCH v2] net/ice/base: revert the change of first profile mask

Quoted 8 lines

Segmentation fault mentioned in patch[1] is related to hardware issue. This patch revert patch[1], since patch[1] may have potential risk and side effect if the first profile mask is set to 0.

[1]:
commit 148fdf2d3537 ("net/ice/base: fix first profile mask")

Applied to dpdk-next-net-intel.

Thanks
Qi