net: fddi: fix UAF in fza_probe
Subsystems (3)
PATCH 1/1 net: fddi: fix UAF in fza_probe
fp is netdev private data and it cannot be
used after free_netdev() call. Using fp after free_netdev() can cause UAF bug. Fix it by moving free_netdev() after error message.
TURBOchannel adapter")
--- drivers/net/fddi/defza.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/net/fddi/defza.c +1 -2
@@ -1504,9 +1504,8 @@ static int fza_probe(struct device *bdev)release_mem_region (start, len); err_out_kfree: -free_netdev (dev); -pr_err ("%s: initialization failure, aborting!\n" , fp->name); +free_netdev (dev);return ret; }
Signature · 1 line
2.32.0
This patch was applied to netdev/net.git (refs/heads/master):
Hello:
This patch was applied to netdev/net.git (refs/heads/master):
Quoted 9 lines · On Tue, 13 Jul 2021 13:58:53 +0300 you wrote:
fp is netdev private data and it cannot be
used afterfree_netdev()call. Using fp afterfree_netdev()can cause UAF bug. Fix it by movingfree_netdev()after error message.Fixes 61414f5ec983 ("FDDI: defza: Add support for DEC FDDIcontroller 700TURBOchannel adapter")
Signed-off-by Pavel Skripkin <[email protected]>[...]
Here is the summary with links:
- net: fddi: fix UAF in fza_probe
https://git.kernel.org/netdev/net/c/deb7178eb940
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
Quoted 3 lines · Pavel Skripkin
fp is netdev private data and it cannot be
used afterfree_netdev()call. Using fp afterfree_netdev()can cause UAF bug. Fix it by movingfree_netdev()after error message.
Can you justify the lines for a better layout? The paragraph looks odd
to me in its current form.
Quoted 3 lines
Fixes 61414f5ec983 ("FDDI: defza: Add support for DEC FDDIcontroller 700TURBOchannel adapter")
Signed-off-by Pavel Skripkin <[email protected]>
Otherwise LGTM. And a good catch, thank you!
Maciej