kbuild: do not suppress Kconfig prompts for silent build
PATCH 1/1 kbuild: do not suppress Kconfig prompts for silent build
When a new CONFIG option is available, Kbuild shows a prompt to get the user input.
$ make [ snip ] Core Scheduling for SMT (SCHED_CORE) [N/y/?] (NEW)
This is the only interactive place during the build process.
Commit 174a1dcc9642 ("kbuild: sink stdout from cmd for silent build") suppressed Kconfig prompts as well because syncconfig is invoked by the 'cmd' macro. You cannot notice the fact that Kconfig is waiting for the user input.
Use 'kecho' to show the equivalent short log without suppressing stdout from sub-make.
---
Makefile | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
Makefile +2 -4
@@ -728,11 +728,9 @@ $(KCONFIG_CONFIG): # This exploits the 'multi-target pattern rule' trick. # The syncconfig should be executed only once to make all the targets. # (Note: use the grouped target '&:' when we bump to GNU Make 4.3) -quiet_cmd_syncconfig = SYNC $@ - cmd_syncconfig = $(MAKE) -f $(srctree)/Makefile syncconfig - %/config/auto.conf %/config/auto.conf.cmd %/generated/autoconf.h: $(KCONFIG_CONFIG) - +$(call cmd,syncconfig) + $(Q)$(kecho) " SYNC $@" + $(Q)$(MAKE) -f $(srctree)/Makefile syncconfig else # !may-sync-config # External modules and some install targets need include/generated/autoconf.h # and include/config/auto.conf but do not care if they are up-to-date.
Signature · 1 line
2.27.0
Quoted 15 lines · Masahiro Yamada
When a new CONFIG option is available,
Kbuildshows a prompt to get the user input.$ make [ snip ] Core Scheduling for SMT (SCHED_CORE) [N/y/?] (NEW)This is the only interactive place during the build process.
Commit
174a1dcc9642("kbuild: sink stdout from cmd for silent build") suppressedKconfigprompts as well because syncconfig is invoked by the 'cmd' macro. You cannot notice the fact thatKconfigis waiting for the user input.
Quoted 7 lines
Use 'kecho' to show the equivalent short log without suppressing stdout from sub-make.
Fixes 174a1dcc9642 ("kbuild: sink stdout from cmd for silent build")Reported-by Tetsuo Handa <[email protected]>Signed-off-by Masahiro Yamada <[email protected]>---
Applied to linux-kbuild.
Quoted 24 lines
Makefile | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)Makefile +2
-5@@ -728,11 +728,9 @@ $(KCONFIG_CONFIG): # This exploits the 'multi-target pattern rule' trick. # The syncconfig should be executed only once to make all the targets. # (Note: use the grouped target '&:' when we bump to GNU Make 4.3) -quiet_cmd_syncconfig = SYNC $@ - cmd_syncconfig = $(MAKE) -f $(srctree)/Makefile syncconfig - %/config/auto.conf %/config/auto.conf.cmd %/generated/autoconf.h: $(KCONFIG_CONFIG) - +$(call cmd,syncconfig) + $(Q)$(kecho) " SYNC $@" + $(Q)$(MAKE) -f $(srctree)/Makefile syncconfig else # !may-sync-config # External modules and some install targets need include/generated/autoconf.h # and include/config/auto.conf but do not care if they are up-to-date. --2.27.0
Signature · 2 lines
Best Regards Masahiro Yamada