Skip to contentSkip to conversation

tests/kms_plane_alpha_blend: Fix a check in is_6bpc function

PATCH In review Vidya Srinivas 4 participants 14 messages Jul 14, 2021 – Jul 22, 2021

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tests/kms_plane_alpha_blend: Fix a check in is_6bpc function

Fixes commit 3bf28f9dffd41b85c262d4e6664ffbdf5b7d9a93.

is_6bpc is supposed to return false if connector is not eDP or DSI. The right check will be DRM_MODE_CONNECTOR_eDP && DRM_MODE_CONNECTOR_DSI By mistake DRM_MODE_CONNECTOR_eDP || DRM_MODE_CONNECTOR_DSI was being used.

Credits-to: Ashutosh Dixit <[email protected]>

---
 tests/kms_plane_alpha_blend.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tests/kms_plane_alpha_blend.c +1 -1
index a3529dc2190f..8020216c1594 100644
@@ -454,7 +454,7 @@ static bool is_6bpc(igt_display_t *display, enum pipe pipe) {
 		return false;
 
 	c = output->config.connector;
-	if (c->connector_type != DRM_MODE_CONNECTOR_eDP ||
+	if (c->connector_type != DRM_MODE_CONNECTOR_eDP &&
 		c->connector_type != DRM_MODE_CONNECTOR_DSI)
 		return false;
 
Signature · 6 lines
2.32.0

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
#1 lore raw

[igt-dev] ✓ Fi.CI.BAT: success for tests/kms_plane_alpha_blend: Fix a check in is_6bpc function

== Series Details ==

== Series Details ==

Series: tests/kms_plane_alpha_blend: Fix a check in is_6bpc function
URL : https://patchwork.freedesktop.org/series/92513/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_10344 -> IGTPW_6019
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6019/index.html

Known issues
------------

Here are the changes found in IGTPW_6019 that come from known issues:

### IGT changes ###

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[i915#1759]: https://gitlab.freedesktop.org/drm/intel/issues/1759
[i915#2373]: https://gitlab.freedesktop.org/drm/intel/issues/2373
[i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575

Participating hosts (39 -> 36)
------------------------------

Missing (3): fi-ilk-m540 fi-bdw-samus fi-hsw-4200u

Build changes
-------------

* CI: CI-20190529 -> None
* IGT: IGT_6138 -> IGTPW_6019

CI-20190529: 20190529
CI_DRM_10344: ea6974acd4fe82ca98cc1390b21af67d63c22471 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_6019: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6019/index.html
IGT_6138: 92bf2c7865037e18946d4c3d705587c8e8c3d1b8 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6019/index.html

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Reviewed-by on v1 1/1
#2 lore raw
In reply to Vidya Srinivas
Quoted 9 lines · Vidya Srinivas

Fixes commit 3bf28f9dffd41b85c262d4e6664ffbdf5b7d9a93.

is_6bpc is supposed to return false if connector is not eDP or DSI. The right check will be DRM_MODE_CONNECTOR_eDP && DRM_MODE_CONNECTOR_DSI By mistake DRM_MODE_CONNECTOR_eDP || DRM_MODE_CONNECTOR_DSI was being used.

Credits-to: Ashutosh Dixit <[email protected]>

LGTM.

Quoted 24 lines
---
 tests/kms_plane_alpha_blend.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tests/kms_plane_alpha_blend.c +1 -1
index a3529dc2190f..8020216c1594 100644
@@ -454,7 +454,7 @@ static bool is_6bpc(igt_display_t *display, enum pipe pipe) {
 		return false;
 
 	c = output->config.connector;
-	if (c->connector_type != DRM_MODE_CONNECTOR_eDP ||
+	if (c->connector_type != DRM_MODE_CONNECTOR_eDP &&
 		c->connector_type != DRM_MODE_CONNECTOR_DSI)
 		return false;
 
Signature · 6 lines
2.32.0

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

author Reviewed-by Ramalingam C
#3 lore raw

Thank you so much Ram. Kunal, kindly help merge this. Sorry for the trouble.

Regards
Vidya

-----Original Message-----
From: C, Ramalingam <[email protected]>
Sent: Wednesday, July 14, 2021 3:34 PM
To: Srinivas, Vidya <[email protected]>
Cc: [email protected]
Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Fix a check in is_6bpc function

Quoted 9 lines · Vidya Srinivas

Fixes commit 3bf28f9dffd41b85c262d4e6664ffbdf5b7d9a93.

is_6bpc is supposed to return false if connector is not eDP or DSI. The right check will be DRM_MODE_CONNECTOR_eDP && DRM_MODE_CONNECTOR_DSI By mistake DRM_MODE_CONNECTOR_eDP || DRM_MODE_CONNECTOR_DSI was being used.

Credits-to: Ashutosh Dixit <[email protected]>

LGTM.

Quoted 21 lines
---
 tests/kms_plane_alpha_blend.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
(quoted diff) +0 -0

b/tests/kms_plane_alpha_blend.c index a3529dc2190f..8020216c1594 100644

tests/kms_plane_alpha_blend.c +1 -2
@@ -454,7 +454,7 @@ static bool is_6bpc(igt_display_t *display, enum pipe pipe) {
 		return false;
 
 	c = output->config.connector;
-	if (c->connector_type != DRM_MODE_CONNECTOR_eDP ||
+	if (c->connector_type != DRM_MODE_CONNECTOR_eDP &&
 		c->connector_type != DRM_MODE_CONNECTOR_DSI)
 		return false;
 
--

2.32.0

Quoted 4 lines

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

#4 lore raw
In reply to Vidya Srinivas
Quoted 6 lines · Vidya Srinivas

Fixes commit 3bf28f9dffd41b85c262d4e6664ffbdf5b7d9a93.

is_6bpc is supposed to return false if connector is not eDP or DSI. The right check will be DRM_MODE_CONNECTOR_eDP && DRM_MODE_CONNECTOR_DSI By mistake DRM_MODE_CONNECTOR_eDP || DRM_MODE_CONNECTOR_DSI was being used.

Instead of these incomplete hacks why aren't we just turning off dithering when doing crc capture?

Quoted 27 lines

Credits-to: Ashutosh Dixit <[email protected]>

---
 tests/kms_plane_alpha_blend.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tests/kms_plane_alpha_blend.c +1 -1
index a3529dc2190f..8020216c1594 100644
@@ -454,7 +454,7 @@ static bool is_6bpc(igt_display_t *display, enum pipe pipe) {
 		return false;
 
 	c = output->config.connector;
-	if (c->connector_type != DRM_MODE_CONNECTOR_eDP ||
+	if (c->connector_type != DRM_MODE_CONNECTOR_eDP &&
 		c->connector_type != DRM_MODE_CONNECTOR_DSI)
 		return false;
 
Signature · 6 lines
2.32.0

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
Signature · 6 lines
Ville Syrjälä
Intel
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
#5 lore raw

Hello Ville,

Apologies. I tried to turn off dithering from kernel itself. But still CRC mismatch came up. This is on Jasperlake chromebook which is using 6bpc panel.

Same jasperlake with 8bpc panel is working fine.

So, as last resort we did this ☹.

Regards
Vidya

-----Original Message-----
From: Ville Syrjälä <[email protected]>
Sent: Wednesday, July 14, 2021 3:55 PM
To: Srinivas, Vidya <[email protected]>
Cc: [email protected]
Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Fix a check in is_6bpc function

Quoted 6 lines · Vidya Srinivas

Fixes commit 3bf28f9dffd41b85c262d4e6664ffbdf5b7d9a93.

is_6bpc is supposed to return false if connector is not eDP or DSI. The right check will be DRM_MODE_CONNECTOR_eDP && DRM_MODE_CONNECTOR_DSI By mistake DRM_MODE_CONNECTOR_eDP || DRM_MODE_CONNECTOR_DSI was being used.

Instead of these incomplete hacks why aren't we just turning off dithering when doing crc capture?

Quoted 24 lines

Credits-to: Ashutosh Dixit <[email protected]>

---
 tests/kms_plane_alpha_blend.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
(quoted diff) +0 -0

b/tests/kms_plane_alpha_blend.c index a3529dc2190f..8020216c1594 100644

tests/kms_plane_alpha_blend.c +1 -2
@@ -454,7 +454,7 @@ static bool is_6bpc(igt_display_t *display, enum pipe pipe) {
 		return false;
 
 	c = output->config.connector;
-	if (c->connector_type != DRM_MODE_CONNECTOR_eDP ||
+	if (c->connector_type != DRM_MODE_CONNECTOR_eDP &&
 		c->connector_type != DRM_MODE_CONNECTOR_DSI)
 		return false;
 
--

2.32.0

Quoted 4 lines

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

--
Ville Syrjälä
Intel
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

#6 lore raw
Quoted 8 lines · Vidya

Hello Ville,

Apologies. I tried to turn off dithering from kernel itself. But still CRC mismatch came up. This is on Jasperlake chromebook which is using 6bpc panel.

Same jasperlake with 8bpc panel is working fine.

So, as last resort we did this ☹.

Well that's a bit unfortunate because now the commit messages are lying, and we still don't know what is going on.

Do the same failures happen with external DP @ 6bpc? I wouldn't really expect any crc differences since AFAIK nothing in the pipe should change before the dithering block, and with dithering disabled the port should just chop off the extra bits at the very end.

Quoted 53 lines

Regards
Vidya

-----Original Message-----
From: Ville Syrjälä <[email protected]>
Sent: Wednesday, July 14, 2021 3:55 PM
To: Srinivas, Vidya <[email protected]>
Cc: [email protected]
Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Fix a check in is_6bpc function

Quoted 6 lines · Vidya Srinivas

Fixes commit 3bf28f9dffd41b85c262d4e6664ffbdf5b7d9a93.

is_6bpc is supposed to return false if connector is not eDP or DSI. The right check will be DRM_MODE_CONNECTOR_eDP && DRM_MODE_CONNECTOR_DSI By mistake DRM_MODE_CONNECTOR_eDP || DRM_MODE_CONNECTOR_DSI was being used.

Instead of these incomplete hacks why aren't we just turning off dithering when doing crc capture?

Quoted 24 lines

Credits-to: Ashutosh Dixit <[email protected]>

---
 tests/kms_plane_alpha_blend.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
(quoted diff) +0 -0

b/tests/kms_plane_alpha_blend.c index a3529dc2190f..8020216c1594 100644

tests/kms_plane_alpha_blend.c +1 -2
@@ -454,7 +454,7 @@ static bool is_6bpc(igt_display_t *display, enum pipe pipe) {
 		return false;
 
 	c = output->config.connector;
-	if (c->connector_type != DRM_MODE_CONNECTOR_eDP ||
+	if (c->connector_type != DRM_MODE_CONNECTOR_eDP &&
 		c->connector_type != DRM_MODE_CONNECTOR_DSI)
 		return false;
 
--

2.32.0

Quoted 4 lines

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

--
Ville Syrjälä
Intel

Signature · 6 lines
Ville Syrjälä
Intel
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
#7 lore raw

Hello Ville,

I am sorry, I don’t have a 6 bpc external panel. Juha-Pekka had suggested we use the set_lut table as being used in kms_flip_scaled_crc.c But when I tried that, max upto 0x7F it would pass (not with original 0xFF00). After that it would give back CRC mismatch.

Set_lut:
uint16_t v = (i * 0xffff / (lut_size - 1)) & 0x7f; lut[i].red = v;
lut[i].green = v;
lut[i].blue = v;

Other solutions which worked were:
1. Use alpha for primary plane https://patchwork.freedesktop.org/patch/440263/?series=90828&rev=6

2. Adding this line before setting the primary gray

	igt_plane_set_prop_value(igt_pipe_get_plane_type(&display->pipes[pipe], DRM_PLANE_TYPE_PRIMARY), IGT_PLANE_ALPHA, 0);

2. Remove primary plane https://patchwork.freedesktop.org/patch/436178/?series=90828&rev=1

3. Use lower alpha values 0x7e for coverage, pre-multiplied and constant https://patchwork.freedesktop.org/patch/438831/?series=90828&rev=3

4. Use an alpha buffer for primary commit https://patchwork.freedesktop.org/patch/440157/?series=90828&rev=5

5. Use black_fb instead of gray_fb in coverage-vs-premult-vs-constant for primary https://patchwork.freedesktop.org/patch/441554/?series=90828&rev=7

Apart from these, I disabled dithering in kernel and that too did not help. Screen shows content correctly but CRC mismatch is seen.

Regards
Vidya

-----Original Message-----
From: Ville Syrjälä <[email protected]>
Sent: Wednesday, July 14, 2021 6:34 PM
To: Srinivas, Vidya <[email protected]>
Cc: [email protected]
Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Fix a check in is_6bpc function

Quoted 8 lines · Vidya

Hello Ville,

Apologies. I tried to turn off dithering from kernel itself. But still CRC mismatch came up. This is on Jasperlake chromebook which is using 6bpc panel.

Same jasperlake with 8bpc panel is working fine.

So, as last resort we did this ☹.

Well that's a bit unfortunate because now the commit messages are lying, and we still don't know what is going on.

Do the same failures happen with external DP @ 6bpc? I wouldn't really expect any crc differences since AFAIK nothing in the pipe should change before the dithering block, and with dithering disabled the port should just chop off the extra bits at the very end.

Quoted 46 lines

Regards
Vidya

-----Original Message-----
From: Ville Syrjälä <[email protected]>
Sent: Wednesday, July 14, 2021 3:55 PM
To: Srinivas, Vidya <[email protected]>
Cc: [email protected]
Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Fix a check in is_6bpc function

Quoted 6 lines · Vidya Srinivas

Fixes commit 3bf28f9dffd41b85c262d4e6664ffbdf5b7d9a93.

is_6bpc is supposed to return false if connector is not eDP or DSI. The right check will be DRM_MODE_CONNECTOR_eDP && DRM_MODE_CONNECTOR_DSI By mistake DRM_MODE_CONNECTOR_eDP || DRM_MODE_CONNECTOR_DSI was being used.

Instead of these incomplete hacks why aren't we just turning off dithering when doing crc capture?

Quoted 24 lines

Credits-to: Ashutosh Dixit <[email protected]>

---
 tests/kms_plane_alpha_blend.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
(quoted diff) +0 -0

b/tests/kms_plane_alpha_blend.c index a3529dc2190f..8020216c1594 100644

tests/kms_plane_alpha_blend.c +1 -2
@@ -454,7 +454,7 @@ static bool is_6bpc(igt_display_t *display, enum pipe pipe) {
 		return false;
 
 	c = output->config.connector;
-	if (c->connector_type != DRM_MODE_CONNECTOR_eDP ||
+	if (c->connector_type != DRM_MODE_CONNECTOR_eDP &&
 		c->connector_type != DRM_MODE_CONNECTOR_DSI)
 		return false;
 
--

2.32.0

Quoted 8 lines
Quoted 4 lines

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

--
Ville Syrjälä
Intel

--
Ville Syrjälä
Intel
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

#8 lore raw
Quoted 3 lines · Vidya

Hello Ville,

I am sorry, I don’t have a 6 bpc external panel.

You don't need one. Just limit the bpp to 18 when computing the link params.

Quoted 108 lines

Juha-Pekka had suggested we use the set_lut table as being used in kms_flip_scaled_crc.c
But when I tried that, max upto 0x7F it would pass (not with original 0xFF00). After that it would give back CRC mismatch.

Set_lut:
uint16_t v = (i * 0xffff / (lut_size - 1)) & 0x7f; lut[i].red = v;
lut[i].green = v;
lut[i].blue = v;

Other solutions which worked were:
1. Use alpha for primary plane https://patchwork.freedesktop.org/patch/440263/?series=90828&rev=6

2. Adding this line before setting the primary gray

	igt_plane_set_prop_value(igt_pipe_get_plane_type(&display->pipes[pipe], DRM_PLANE_TYPE_PRIMARY), IGT_PLANE_ALPHA, 0);

2. Remove primary plane https://patchwork.freedesktop.org/patch/436178/?series=90828&rev=1

3. Use lower alpha values 0x7e for coverage, pre-multiplied and constant https://patchwork.freedesktop.org/patch/438831/?series=90828&rev=3

4. Use an alpha buffer for primary commit https://patchwork.freedesktop.org/patch/440157/?series=90828&rev=5

5. Use black_fb instead of gray_fb in coverage-vs-premult-vs-constant for primary https://patchwork.freedesktop.org/patch/441554/?series=90828&rev=7

Apart from these, I disabled dithering in kernel and that too did not help. Screen shows content correctly but CRC mismatch is seen.

Regards
Vidya

-----Original Message-----
From: Ville Syrjälä <[email protected]>
Sent: Wednesday, July 14, 2021 6:34 PM
To: Srinivas, Vidya <[email protected]>
Cc: [email protected]
Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Fix a check in is_6bpc function

Quoted 8 lines · Vidya

Hello Ville,

Apologies. I tried to turn off dithering from kernel itself. But still CRC mismatch came up. This is on Jasperlake chromebook which is using 6bpc panel.

Same jasperlake with 8bpc panel is working fine.

So, as last resort we did this ☹.

Well that's a bit unfortunate because now the commit messages are lying, and we still don't know what is going on.

Do the same failures happen with external DP @ 6bpc? I wouldn't really expect any crc differences since AFAIK nothing in the pipe should change before the dithering block, and with dithering disabled the port should just chop off the extra bits at the very end.

Quoted 46 lines

Regards
Vidya

-----Original Message-----
From: Ville Syrjälä <[email protected]>
Sent: Wednesday, July 14, 2021 3:55 PM
To: Srinivas, Vidya <[email protected]>
Cc: [email protected]
Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Fix a check in is_6bpc function

Quoted 6 lines · Vidya Srinivas

Fixes commit 3bf28f9dffd41b85c262d4e6664ffbdf5b7d9a93.

is_6bpc is supposed to return false if connector is not eDP or DSI. The right check will be DRM_MODE_CONNECTOR_eDP && DRM_MODE_CONNECTOR_DSI By mistake DRM_MODE_CONNECTOR_eDP || DRM_MODE_CONNECTOR_DSI was being used.

Instead of these incomplete hacks why aren't we just turning off dithering when doing crc capture?

Quoted 24 lines

Credits-to: Ashutosh Dixit <[email protected]>

---
 tests/kms_plane_alpha_blend.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
(quoted diff) +0 -0

b/tests/kms_plane_alpha_blend.c index a3529dc2190f..8020216c1594 100644

tests/kms_plane_alpha_blend.c +1 -2
@@ -454,7 +454,7 @@ static bool is_6bpc(igt_display_t *display, enum pipe pipe) {
 		return false;
 
 	c = output->config.connector;
-	if (c->connector_type != DRM_MODE_CONNECTOR_eDP ||
+	if (c->connector_type != DRM_MODE_CONNECTOR_eDP &&
 		c->connector_type != DRM_MODE_CONNECTOR_DSI)
 		return false;
 
--

2.32.0

Quoted 8 lines
Quoted 4 lines

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

--
Ville Syrjälä
Intel

--
Ville Syrjälä
Intel

Signature · 6 lines
Ville Syrjälä
Intel
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
#9 lore raw

Hello Ville,

Thank you so much. I limited the bpp to 18 in compute_sink_pipe_bpp.
I tested on external monitor both HDMI and DP. Tests did not fail. It passed without CRC mismatch. I checked display_info and ensure bpp shows 18 on pipe B for both HDMI and DP case. Dithering was set to ON.

[CRTC:152:pipe B]:

        uapi: enable=yes, active=yes, mode="3840x2160": 30 266640 3840 3848 3992 4000 2160 2214 2219 2222 0x40 0x9
        hw: active=yes, adjusted_mode="3840x2160": 30 266640 3840 3848 3992 4000 2160 2214 2219 2222 0x40 0x9
        pipe src size=3840x2160, dither=yes, bpp=18

I am really sorry. Should I revert this patch? Kindly guide me further. Thank you so much.

Regards
Vidya

-----Original Message-----
From: Ville Syrjälä <[email protected]>
Sent: Wednesday, July 14, 2021 7:57 PM
To: Srinivas, Vidya <[email protected]>
Cc: [email protected]
Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Fix a check in is_6bpc function

Quoted 3 lines · Vidya

Hello Ville,

I am sorry, I don’t have a 6 bpc external panel.

You don't need one. Just limit the bpp to 18 when computing the link params.

Quoted 113 lines

Juha-Pekka had suggested we use the set_lut table as being used in
kms_flip_scaled_crc.c But when I tried that, max upto 0x7F it would pass (not with original 0xFF00). After that it would give back CRC mismatch.

Set_lut:
uint16_t v = (i * 0xffff / (lut_size - 1)) & 0x7f; lut[i].red = v; lut[i].green = v; lut[i].blue = v;

Other solutions which worked were:
1. Use alpha for primary plane
https://patchwork.freedesktop.org/patch/440263/?series=90828&rev=6

2. Adding this line before setting the primary gray

igt_plane_set_prop_value(igt_pipe_get_plane_type(&display->pipes[pipe] , DRM_PLANE_TYPE_PRIMARY), IGT_PLANE_ALPHA, 0);

2. Remove primary plane
https://patchwork.freedesktop.org/patch/436178/?series=90828&rev=1

3. Use lower alpha values 0x7e for coverage, pre-multiplied and constant
https://patchwork.freedesktop.org/patch/438831/?series=90828&rev=3

4. Use an alpha buffer for primary commit
https://patchwork.freedesktop.org/patch/440157/?series=90828&rev=5

5. Use black_fb instead of gray_fb in coverage-vs-premult-vs-constant for primary
https://patchwork.freedesktop.org/patch/441554/?series=90828&rev=7

Apart from these, I disabled dithering in kernel and that too did not help. Screen shows content correctly but CRC mismatch is seen.

Regards
Vidya

-----Original Message-----
From: Ville Syrjälä <[email protected]>
Sent: Wednesday, July 14, 2021 6:34 PM
To: Srinivas, Vidya <[email protected]>
Cc: [email protected]
Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Fix a check in is_6bpc function

Quoted 8 lines · Vidya

Hello Ville,

Apologies. I tried to turn off dithering from kernel itself. But still CRC mismatch came up. This is on Jasperlake chromebook which is using 6bpc panel.

Same jasperlake with 8bpc panel is working fine.

So, as last resort we did this ☹.

Well that's a bit unfortunate because now the commit messages are lying, and we still don't know what is going on.

Do the same failures happen with external DP @ 6bpc? I wouldn't really expect any crc differences since AFAIK nothing in the pipe should change before the dithering block, and with dithering disabled the port should just chop off the extra bits at the very end.

Quoted 46 lines

Regards
Vidya

-----Original Message-----
From: Ville Syrjälä <[email protected]>
Sent: Wednesday, July 14, 2021 3:55 PM
To: Srinivas, Vidya <[email protected]>
Cc: [email protected]
Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend:
Fix a check in is_6bpc function

Quoted 6 lines · Vidya Srinivas

Fixes commit 3bf28f9dffd41b85c262d4e6664ffbdf5b7d9a93.

is_6bpc is supposed to return false if connector is not eDP or DSI. The right check will be DRM_MODE_CONNECTOR_eDP && DRM_MODE_CONNECTOR_DSI By mistake DRM_MODE_CONNECTOR_eDP || DRM_MODE_CONNECTOR_DSI was being used.

Instead of these incomplete hacks why aren't we just turning off dithering when doing crc capture?

Quoted 24 lines

Credits-to: Ashutosh Dixit <[email protected]>

---
 tests/kms_plane_alpha_blend.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
(quoted diff) +0 -0

b/tests/kms_plane_alpha_blend.c index a3529dc2190f..8020216c1594 100644

tests/kms_plane_alpha_blend.c +1 -2
@@ -454,7 +454,7 @@ static bool is_6bpc(igt_display_t *display, enum pipe pipe) {
 		return false;
 
 	c = output->config.connector;
-	if (c->connector_type != DRM_MODE_CONNECTOR_eDP ||
+	if (c->connector_type != DRM_MODE_CONNECTOR_eDP &&
 		c->connector_type != DRM_MODE_CONNECTOR_DSI)
 		return false;
 
--

2.32.0

Quoted 8 lines
Quoted 4 lines

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

--
Ville Syrjälä
Intel

Quoted 3 lines

--
Ville Syrjälä
Intel

--
Ville Syrjälä
Intel
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

#10 lore raw
Quoted 7 lines · Vidya

Hello Ville,

Thank you so much. I limited the bpp to 18 in compute_sink_pipe_bpp.
I tested on external monitor both HDMI and DP. Tests did not fail. It passed without CRC mismatch. I checked display_info and ensure bpp shows 18 on pipe B for both HDMI and DP case. Dithering was set to ON.

Quoted 6 lines

[CRTC:152:pipe B]:

        uapi: enable=yes, active=yes, mode="3840x2160": 30 266640 3840 3848 3992 4000 2160 2214 2219 2222 0x40 0x9
        hw: active=yes, adjusted_mode="3840x2160": 30 266640 3840 3848 3992 4000 2160 2214 2219 2222 0x40 0x9
        pipe src size=3840x2160, dither=yes, bpp=18

I am really sorry. Should I revert this patch? Kindly guide me further. Thank you so much.

Well, before we go making too many changes would be nice to see if we can figure out what is really causing the crc mismatches on eDP. I can't immediately think of anything eDP specific it could be really, apart from maybe some PSR/etc. related bug. Have we ruled those sort if things out?

Quoted 138 lines

Regards
Vidya

-----Original Message-----
From: Ville Syrjälä <[email protected]>
Sent: Wednesday, July 14, 2021 7:57 PM
To: Srinivas, Vidya <[email protected]>
Cc: [email protected]
Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Fix a check in is_6bpc function

Quoted 3 lines · Vidya

Hello Ville,

I am sorry, I don’t have a 6 bpc external panel.

You don't need one. Just limit the bpp to 18 when computing the link params.

Quoted 113 lines

Juha-Pekka had suggested we use the set_lut table as being used in
kms_flip_scaled_crc.c But when I tried that, max upto 0x7F it would pass (not with original 0xFF00). After that it would give back CRC mismatch.

Set_lut:
uint16_t v = (i * 0xffff / (lut_size - 1)) & 0x7f; lut[i].red = v; lut[i].green = v; lut[i].blue = v;

Other solutions which worked were:
1. Use alpha for primary plane
https://patchwork.freedesktop.org/patch/440263/?series=90828&rev=6

2. Adding this line before setting the primary gray

igt_plane_set_prop_value(igt_pipe_get_plane_type(&display->pipes[pipe] , DRM_PLANE_TYPE_PRIMARY), IGT_PLANE_ALPHA, 0);

2. Remove primary plane
https://patchwork.freedesktop.org/patch/436178/?series=90828&rev=1

3. Use lower alpha values 0x7e for coverage, pre-multiplied and constant
https://patchwork.freedesktop.org/patch/438831/?series=90828&rev=3

4. Use an alpha buffer for primary commit
https://patchwork.freedesktop.org/patch/440157/?series=90828&rev=5

5. Use black_fb instead of gray_fb in coverage-vs-premult-vs-constant for primary
https://patchwork.freedesktop.org/patch/441554/?series=90828&rev=7

Apart from these, I disabled dithering in kernel and that too did not help. Screen shows content correctly but CRC mismatch is seen.

Regards
Vidya

-----Original Message-----
From: Ville Syrjälä <[email protected]>
Sent: Wednesday, July 14, 2021 6:34 PM
To: Srinivas, Vidya <[email protected]>
Cc: [email protected]
Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Fix a check in is_6bpc function

Quoted 8 lines · Vidya

Hello Ville,

Apologies. I tried to turn off dithering from kernel itself. But still CRC mismatch came up. This is on Jasperlake chromebook which is using 6bpc panel.

Same jasperlake with 8bpc panel is working fine.

So, as last resort we did this ☹.

Well that's a bit unfortunate because now the commit messages are lying, and we still don't know what is going on.

Do the same failures happen with external DP @ 6bpc? I wouldn't really expect any crc differences since AFAIK nothing in the pipe should change before the dithering block, and with dithering disabled the port should just chop off the extra bits at the very end.

Quoted 46 lines

Regards
Vidya

-----Original Message-----
From: Ville Syrjälä <[email protected]>
Sent: Wednesday, July 14, 2021 3:55 PM
To: Srinivas, Vidya <[email protected]>
Cc: [email protected]
Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend:
Fix a check in is_6bpc function

Quoted 6 lines · Vidya Srinivas

Fixes commit 3bf28f9dffd41b85c262d4e6664ffbdf5b7d9a93.

is_6bpc is supposed to return false if connector is not eDP or DSI. The right check will be DRM_MODE_CONNECTOR_eDP && DRM_MODE_CONNECTOR_DSI By mistake DRM_MODE_CONNECTOR_eDP || DRM_MODE_CONNECTOR_DSI was being used.

Instead of these incomplete hacks why aren't we just turning off dithering when doing crc capture?

Quoted 24 lines

Credits-to: Ashutosh Dixit <[email protected]>

---
 tests/kms_plane_alpha_blend.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
(quoted diff) +0 -0

b/tests/kms_plane_alpha_blend.c index a3529dc2190f..8020216c1594 100644

tests/kms_plane_alpha_blend.c +1 -2
@@ -454,7 +454,7 @@ static bool is_6bpc(igt_display_t *display, enum pipe pipe) {
 		return false;
 
 	c = output->config.connector;
-	if (c->connector_type != DRM_MODE_CONNECTOR_eDP ||
+	if (c->connector_type != DRM_MODE_CONNECTOR_eDP &&
 		c->connector_type != DRM_MODE_CONNECTOR_DSI)
 		return false;
 
--

2.32.0

Quoted 8 lines
Quoted 4 lines

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

--
Ville Syrjälä
Intel

Quoted 3 lines

--
Ville Syrjälä
Intel

--
Ville Syrjälä
Intel

Signature · 6 lines
Ville Syrjälä
Intel
_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev
#11 lore raw
Quoted 27 lines

-----Original Message-----
From: Ville Syrjälä <[email protected]>
Sent: Thursday, July 15, 2021 8:36 AM
To: Srinivas, Vidya <[email protected]>
Cc: [email protected]
Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Fix a check in is_6bpc function

Quoted 4 lines · Vidya

Hello Ville,

Thank you so much. I limited the bpp to 18 in compute_sink_pipe_bpp. I tested on external monitor both HDMI and DP. Tests did not fail. It passed

without CRC mismatch.

Quoted 1 line

I checked display_info and ensure bpp shows 18 on pipe B for both HDMI

and DP case.

Quoted 4 lines

Dithering was set to ON.

[CRTC:152:pipe B]:

        uapi: enable=yes, active=yes, mode="3840x2160": 30 266640 3840

3848 3992 4000 2160 2214 2219 2222 0x40 0x9

Quoted 1 line
        hw: active=yes, adjusted_mode="3840x2160": 30 266640 3840 3848

3992 4000 2160 2214 2219 2222 0x40 0x9

Quoted 2 lines
        pipe src size=3840x2160, dither=yes, bpp=18
Quoted 7 lines
Quoted 1 line

I am really sorry. Should I revert this patch? Kindly guide me further. Thank

you so much.

Well, before we go making too many changes would be nice to see if we can figure out what is really causing the crc mismatches on eDP. I can't immediately think of anything eDP specific it could be really, apart from maybe some PSR/etc. related bug. Have we ruled those sort if things out?

Hello Ville, thank you so much. The JSL chromebook we are using is a non-PSR panel. I will try to see if I can figure out anything else and update.

Regards
Vidya

Quoted 148 lines
Quoted 13 lines

Regards
Vidya

-----Original Message-----
From: Ville Syrjälä <[email protected]>
Sent: Wednesday, July 14, 2021 7:57 PM
To: Srinivas, Vidya <[email protected]>
Cc: [email protected]
Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Fix a check in is_6bpc function

Quoted 6 lines
Quoted 3 lines · Vidya

Hello Ville,

I am sorry, I don’t have a 6 bpc external panel.

You don't need one. Just limit the bpp to 18 when computing the link

params.

Quoted 3 lines
Quoted 3 lines

Juha-Pekka had suggested we use the set_lut table as being used in kms_flip_scaled_crc.c But when I tried that, max upto 0x7F it would pass

(not with original 0xFF00). After that it would give back CRC mismatch.

Quoted 21 lines
Quoted 21 lines

Set_lut:
uint16_t v = (i * 0xffff / (lut_size - 1)) & 0x7f; lut[i].red = v; lut[i].green = v; lut[i].blue = v;

Other solutions which worked were:
1. Use alpha for primary plane
https://patchwork.freedesktop.org/patch/440263/?series=90828&rev=6

2. Adding this line before setting the primary gray

igt_plane_set_prop_value(igt_pipe_get_plane_type(&display->pipes[pip e] , DRM_PLANE_TYPE_PRIMARY), IGT_PLANE_ALPHA, 0);

2. Remove primary plane
https://patchwork.freedesktop.org/patch/436178/?series=90828&rev=1

3. Use lower alpha values 0x7e for coverage, pre-multiplied and constant
https://patchwork.freedesktop.org/patch/438831/?series=90828&rev=3

Quoted 8 lines
Quoted 8 lines

4. Use an alpha buffer for primary commit
https://patchwork.freedesktop.org/patch/440157/?series=90828&rev=5

5. Use black_fb instead of gray_fb in
coverage-vs-premult-vs-constant for primary
https://patchwork.freedesktop.org/patch/441554/?series=90828&rev=7

Apart from these, I disabled dithering in kernel and that too did not help.

Screen shows content correctly but CRC mismatch is seen.

Quoted 13 lines
Quoted 13 lines

Regards
Vidya

-----Original Message-----
From: Ville Syrjälä <[email protected]>
Sent: Wednesday, July 14, 2021 6:34 PM
To: Srinivas, Vidya <[email protected]>
Cc: [email protected]
Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend:
Fix a check in is_6bpc function

Quoted 4 lines
Quoted 4 lines · Vidya
Quoted 3 lines

Hello Ville,

Apologies. I tried to turn off dithering from kernel itself. But still CRC

mismatch came up.

Quoted 7 lines
Quoted 7 lines
Quoted 5 lines

This is on Jasperlake chromebook which is using 6bpc panel.

Same jasperlake with 8bpc panel is working fine.

So, as last resort we did this ☹.

Well that's a bit unfortunate because now the commit messages are lying,

and we still don't know what is going on.

Quoted 2 lines
Quoted 2 lines

Do the same failures happen with external DP @ 6bpc? I wouldn't really

expect any crc differences since AFAIK nothing in the pipe should change before the dithering block, and with dithering disabled the port should just chop off the extra bits at the very end.

Quoted 13 lines
Quoted 13 lines
Quoted 13 lines

Regards
Vidya

-----Original Message-----
From: Ville Syrjälä <[email protected]>
Sent: Wednesday, July 14, 2021 3:55 PM
To: Srinivas, Vidya <[email protected]>
Cc: [email protected]
Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend:
Fix a check in is_6bpc function

Quoted 6 lines
Quoted 6 lines
Quoted 6 lines · Vidya Srinivas
Quoted 5 lines

Fixes commit 3bf28f9dffd41b85c262d4e6664ffbdf5b7d9a93.

is_6bpc is supposed to return false if connector is not eDP or DSI. The right check will be DRM_MODE_CONNECTOR_eDP && DRM_MODE_CONNECTOR_DSI By mistake

DRM_MODE_CONNECTOR_eDP ||

Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 1 line

DRM_MODE_CONNECTOR_DSI was being used.

Instead of these incomplete hacks why aren't we just turning off

dithering when doing crc capture?

Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines

Credits-to: Ashutosh Dixit <[email protected]>

---
 tests/kms_plane_alpha_blend.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines

tests/kms_plane_alpha_blend.c static bool is_6bpc(igt_display_t *display,

Quoted 6 lines
(quoted diff) +0 -0

b/tests/kms_plane_alpha_blend.c index a3529dc2190f..8020216c1594 100644

tests/kms_plane_alpha_blend.c +0 -0
@@ -454,7 +454,7 @@ static bool is_6bpc(igt_display_t *display,

enum pipe pipe) {

Quoted 24 lines
Quoted 23 lines
Quoted 11 lines
Quoted 11 lines
tests/kms_plane_alpha_blend.c +1 -2
 		return false;
 
 	c = output->config.connector;
-	if (c->connector_type != DRM_MODE_CONNECTOR_eDP ||
+	if (c->connector_type != DRM_MODE_CONNECTOR_eDP &&
 		c->connector_type != DRM_MODE_CONNECTOR_DSI)
 		return false;
 
--

2.32.0

Quoted 8 lines
Quoted 4 lines

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

--
Ville Syrjälä
Intel

--
Ville Syrjälä
Intel

Quoted 7 lines
Quoted 3 lines

--
Ville Syrjälä
Intel

--
Ville Syrjälä
Intel

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

#12 lore raw
Quoted 49 lines

-----Original Message-----
From: Srinivas, Vidya
Sent: Thursday, July 15, 2021 9:21 AM
To: 'Ville Syrjälä' <[email protected]>
Cc: [email protected]
Subject: RE: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Fix a check in is_6bpc function

Quoted 29 lines

-----Original Message-----
From: Ville Syrjälä <[email protected]>
Sent: Thursday, July 15, 2021 8:36 AM
To: Srinivas, Vidya <[email protected]>
Cc: [email protected]
Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend: Fix a check in is_6bpc function

Quoted 5 lines · Vidya

Hello Ville,

Thank you so much. I limited the bpp to 18 in compute_sink_pipe_bpp. I tested on external monitor both HDMI and DP. Tests did not fail. It passed

without CRC mismatch.

Quoted 2 lines

I checked display_info and ensure bpp shows 18 on pipe B for both HDMI

and DP case.

Quoted 5 lines

Dithering was set to ON.

[CRTC:152:pipe B]:

        uapi: enable=yes, active=yes, mode="3840x2160": 30 266640

3840

3848 3992 4000 2160 2214 2219 2222 0x40 0x9

Quoted 2 lines
        hw: active=yes, adjusted_mode="3840x2160": 30 266640 3840

3848

3992 4000 2160 2214 2219 2222 0x40 0x9

Quoted 2 lines
        pipe src size=3840x2160, dither=yes, bpp=18
Quoted 8 lines
Quoted 2 lines

I am really sorry. Should I revert this patch? Kindly guide me further. Thank

you so much.

Well, before we go making too many changes would be nice to see if we can figure out what is really causing the crc mismatches on eDP. I can't immediately think of anything eDP specific it could be really, apart from maybe some PSR/etc. related bug. Have we ruled those sort if

Quoted 8 lines

things out?

Hello Ville, thank you so much. The JSL chromebook we are using is a non- PSR panel.
I will try to see if I can figure out anything else and update.

Regards
Vidya

Hello Ville,

Tejas helped find the root cause. The issue was not with respect to BPC or dithering as you said. The JSL panel I have on this chromebook is 1366x768. If we align the width to 64 for the buffers being created, it works fine. Many thanks to you for pointing out the wrong fix and thanks to Tejas for helping with the fix. He will submit the patch. I will request a revert of the wrong patch. Really sorry for that.

Regards
Vidya

Quoted 54 lines
Quoted 19 lines
Quoted 19 lines

Regards
Vidya

-----Original Message-----
From: Ville Syrjälä <[email protected]>
Sent: Wednesday, July 14, 2021 7:57 PM
To: Srinivas, Vidya <[email protected]>
Cc: [email protected]
Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend:
Fix a check in is_6bpc function

Quoted 3 lines · Vidya

Hello Ville,

I am sorry, I don’t have a 6 bpc external panel.

Quoted 15 lines
Quoted 1 line

You don't need one. Just limit the bpp to 18 when computing the link

params.

Quoted 4 lines
Quoted 4 lines

Juha-Pekka had suggested we use the set_lut table as being used in kms_flip_scaled_crc.c But when I tried that, max upto 0x7F it would pass

(not with original 0xFF00). After that it would give back CRC mismatch.

Quoted 8 lines
Quoted 8 lines

Set_lut:
uint16_t v = (i * 0xffff / (lut_size - 1)) & 0x7f; lut[i].red = v; lut[i].green = v; lut[i].blue = v;

Other solutions which worked were:
1. Use alpha for primary plane

https://patchwork.freedesktop.org/patch/440263/?series=90828&rev=6

Quoted 8 lines
Quoted 8 lines
Quoted 8 lines

2. Adding this line before setting the primary gray

igt_plane_set_prop_value(igt_pipe_get_plane_type(&display->pipes[p ip e] , DRM_PLANE_TYPE_PRIMARY), IGT_PLANE_ALPHA, 0);

2. Remove primary plane

https://patchwork.freedesktop.org/patch/436178/?series=90828&rev=1

Quoted 4 lines
Quoted 4 lines
Quoted 4 lines

3. Use lower alpha values 0x7e for coverage, pre-multiplied and constant

https://patchwork.freedesktop.org/patch/438831/?series=90828&rev=3

Quoted 3 lines
Quoted 3 lines
Quoted 3 lines

4. Use an alpha buffer for primary commit

https://patchwork.freedesktop.org/patch/440157/?series=90828&rev=5

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 114 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines

5. Use black_fb instead of gray_fb in
coverage-vs-premult-vs-constant for primary

https://patchwork.freedesktop.org/patch/441554/?series=90828&rev=7

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

Apart from these, I disabled dithering in kernel and that too did not

help.

Quoted 107 lines

Screen shows content correctly but CRC mismatch is seen.

Quoted 13 lines
Quoted 13 lines

Regards
Vidya

-----Original Message-----
From: Ville Syrjälä <[email protected]>
Sent: Wednesday, July 14, 2021 6:34 PM
To: Srinivas, Vidya <[email protected]>
Cc: [email protected]
Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend:
Fix a check in is_6bpc function

Quoted 5 lines
Quoted 5 lines · Vidya
Quoted 4 lines

Hello Ville,

Apologies. I tried to turn off dithering from kernel itself. But still CRC

mismatch came up.

Quoted 8 lines
Quoted 8 lines
Quoted 5 lines

This is on Jasperlake chromebook which is using 6bpc panel.

Same jasperlake with 8bpc panel is working fine.

So, as last resort we did this ☹.

Well that's a bit unfortunate because now the commit messages are lying,

and we still don't know what is going on.

Quoted 3 lines
Quoted 3 lines

Do the same failures happen with external DP @ 6bpc? I wouldn't really

expect any crc differences since AFAIK nothing in the pipe should change before the dithering block, and with dithering disabled the port should just chop off the extra bits at the very end.

Quoted 13 lines
Quoted 13 lines
Quoted 13 lines

Regards
Vidya

-----Original Message-----
From: Ville Syrjälä <[email protected]>
Sent: Wednesday, July 14, 2021 3:55 PM
To: Srinivas, Vidya <[email protected]>
Cc: [email protected]
Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_plane_alpha_blend:
Fix a check in is_6bpc function

Quoted 6 lines
Quoted 6 lines
Quoted 6 lines · Vidya Srinivas
Quoted 5 lines

Fixes commit 3bf28f9dffd41b85c262d4e6664ffbdf5b7d9a93.

is_6bpc is supposed to return false if connector is not eDP or DSI. The right check will be DRM_MODE_CONNECTOR_eDP && DRM_MODE_CONNECTOR_DSI By mistake

DRM_MODE_CONNECTOR_eDP ||

Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 1 line

DRM_MODE_CONNECTOR_DSI was being used.

Instead of these incomplete hacks why aren't we just turning off

dithering when doing crc capture?

Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines

Credits-to: Ashutosh Dixit <[email protected]>

---
 tests/kms_plane_alpha_blend.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines

tests/kms_plane_alpha_blend.c static bool is_6bpc(igt_display_t · line 454

Quoted 8 lines
(quoted diff) +0 -0

b/tests/kms_plane_alpha_blend.c index
a3529dc2190f..8020216c1594
100644

tests/kms_plane_alpha_blend.c +0 -0
@@ -454,7 +454,7 @@ static bool is_6bpc(igt_display_t
 *display,

enum pipe pipe) {

Quoted 20 lines
Quoted 20 lines
Quoted 19 lines
Quoted 11 lines
tests/kms_plane_alpha_blend.c +1 -2
 		return false;
 
 	c = output->config.connector;
-	if (c->connector_type != DRM_MODE_CONNECTOR_eDP ||
+	if (c->connector_type != DRM_MODE_CONNECTOR_eDP &&
 		c->connector_type != DRM_MODE_CONNECTOR_DSI)
 		return false;
 
--

2.32.0

Quoted 4 lines

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

--
Ville Syrjälä
Intel

Quoted 7 lines
Quoted 3 lines

--
Ville Syrjälä
Intel

--
Ville Syrjälä
Intel

--
Ville Syrjälä
Intel

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev

#13 lore raw

[igt-dev] ✗ Fi.CI.IGT: failure for tests/kms_plane_alpha_blend: Fix a check in is_6bpc function

In reply to Vidya Srinivas
== Series Details ==

== Series Details ==

Series: tests/kms_plane_alpha_blend: Fix a check in is_6bpc function
URL : https://patchwork.freedesktop.org/series/92513/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_10344_full -> IGTPW_6019_full
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with IGTPW_6019_full absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in IGTPW_6019_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6019/index.html

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in IGTPW_6019_full:

### IGT changes ###

#### Possible regressions ####

* igt@i915_selftest@live@sanitycheck:
- shard-kbl: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10344/shard-kbl6/igt@i915_selftest@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6019/shard-kbl2/igt@i915_selftest@[email protected]

* igt@kms_addfb_basic@bad-pitch-63:
- shard-snb: [PASS][3] -> [DMESG-WARN][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10344/shard-snb5/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6019/shard-snb5/igt@[email protected]
- shard-iclb: [PASS][5] -> [DMESG-WARN][6] +1 similar issue
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10344/shard-iclb8/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6019/shard-iclb8/igt@[email protected]
- shard-glk: [PASS][7] -> [DMESG-WARN][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10344/shard-glk2/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6019/shard-glk1/igt@[email protected]
- shard-kbl: [PASS][9] -> [DMESG-WARN][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10344/shard-kbl7/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6019/shard-kbl3/igt@[email protected]
- shard-tglb: [PASS][11] -> [DMESG-WARN][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10344/shard-tglb5/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6019/shard-tglb1/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-a-coverage-vs-premult-vs-constant:
- shard-tglb: [PASS][13] -> [SKIP][14] +1 similar issue
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10344/shard-tglb3/igt@kms_plane_alpha_blend@pipe-a-coverage-vs-premult-vs-constant.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6019/shard-tglb7/igt@kms_plane_alpha_blend@pipe-a-coverage-vs-premult-vs-constant.html

* igt@kms_plane_alpha_blend@pipe-c-coverage-vs-premult-vs-constant:
- shard-tglb: NOTRUN -> [SKIP][15] +1 similar issue
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6019/shard-tglb2/igt@kms_plane_alpha_blend@pipe-c-coverage-vs-premult-vs-constant.html

Known issues
------------

Here are the changes found in IGTPW_6019_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_ctx_isolation@preservation-s3@bcs0:
- shard-kbl: [PASS][16] -> [DMESG-WARN][17] ([i915#180]) +2 similar issues
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10344/shard-kbl1/igt@gem_ctx_isolation@[email protected]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6019/shard-kbl6/igt@gem_ctx_isolation@[email protected]

* igt@gem_ctx_persistence@legacy-engines-mixed-process:
- shard-snb: NOTRUN -> [SKIP][18] ([fdo#109271] / [i915#1099]) +5 similar issues
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6019/shard-snb2/igt@[email protected]

* igt@gem_eio@in-flight-contexts-10ms:
- shard-tglb: [PASS][19] -> [TIMEOUT][20] ([i915#3063])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10344/shard-tglb7/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6019/shard-tglb6/igt@[email protected]

* igt@gem_exec_fair@basic-deadline:
- shard-glk: [PASS][21] -> [FAIL][22] ([i915#2846])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10344/shard-glk4/igt@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6019/shard-glk2/igt@[email protected]
- shard-apl: NOTRUN -> [FAIL][23] ([i915#2846])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6019/shard-apl8/igt@[email protected]

* igt@gem_exec_fair@basic-none@vcs1:
- shard-iclb: NOTRUN -> [FAIL][24] ([i915#2842])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6019/shard-iclb4/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-pace@vcs1:
- shard-kbl: [PASS][25] -> [FAIL][26] ([i915#2842])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10344/shard-kbl2/igt@gem_exec_fair@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6019/shard-kbl3/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-pace@vecs0:
- shard-tglb: [PASS][27] -> [FAIL][28] ([i915#2842]) +1 similar issue
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10344/shard-tglb6/igt@gem_exec_fair@[email protected]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6019/shard-tglb2/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-throttle@rcs0:
- shard-glk: [PASS][29] -> [FAIL][30] ([i915#2842])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10344/shard-glk5/igt@gem_exec_fair@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6019/shard-glk3/igt@gem_exec_fair@[email protected]

* igt@gem_exec_flush@basic-batch-kernel-default-cmd:
- shard-iclb: NOTRUN -> [SKIP][31] ([fdo#109313])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6019/shard-iclb7/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][32] ([fdo#109313])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6019/shard-tglb3/igt@[email protected]

* igt@gem_exec_params@no-vebox:
- shard-iclb: NOTRUN -> [SKIP][33] ([fdo#109283])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6019/shard-iclb6/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][34] ([fdo#109283])
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6019/shard-tglb7/igt@[email protected]

* igt@gem_pread@exhaustion:
- shard-tglb: NOTRUN -> [WARN][35] ([i915#2658])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6019/shard-tglb3/igt@[email protected]
- shard-iclb: NOTRUN -> [WARN][36] ([i915#2658])
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6019/shard-iclb3/igt@[email protected]

* igt@gem_pwrite@basic-exhaustion:
- shard-snb: NOTRUN -> [WARN][37] ([i915#2658])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6019/shard-snb6/igt@[email protected]
- shard-kbl: NOTRUN -> [WARN][38] ([i915#2658]) +1 similar issue
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6019/shard-kbl7/igt@[email protected]

* igt@gem_render_copy@yf-tiled-mc-ccs-to-vebox-yf-tiled:
- shard-iclb: NOTRUN -> [SKIP][39] ([i915#768])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6019/shard-iclb2/igt@[email protected]

* igt@gem_softpin@evict-snoop:
- shard-iclb: NOTRUN -> [SKIP][40] ([fdo#109312])
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6019/shard-iclb6/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][41] ([fdo#109312])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6019/shard-tglb2/igt@[email protected]

* igt@gem_userptr_blits@dmabuf-sync:
- shard-kbl: NOTRUN -> [SKIP][42] ([fdo#109271] / [i915#3323])
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6019/shard-kbl6/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][43] ([i915#3323])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6019/shard-iclb2/igt@[email protected]
- shard-apl: NOTRUN -> [SKIP][44] ([fdo#109271] / [i915#3323])
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6019/shard-apl6/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][45] ([i915#3323])
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6019/shard-tglb2/igt@[email protected]

* igt@gem_userptr_blits@readonly-pwrite-unsync:
- shard-tglb: NOTRUN -> [SKIP][46] ([i915#3297])
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6019/shard-tglb2/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][47] ([i915#3297])
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6019/shard-iclb2/igt@[email protected]

* igt@gen9_exec_parse@bb-start-far:
- shard-iclb: NOTRUN -> [SKIP][48] ([fdo#112306]) +1 similar issue
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6019/shard-iclb7/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][49] ([fdo#112306])
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6019/shard-tglb3/igt@[email protected]

* igt@i915_pm_dc@dc5-psr:
- shard-iclb: [PASS][50] -> [DMESG-WARN][51] ([i915#3698])
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10344/shard-iclb1/igt@[email protected]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6019/shard-iclb8/igt@[email protected]

* igt@i915_pm_dc@dc6-dpms:
- shard-kbl: NOTRUN -> [FAIL][52] ([i915#454])
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6019/shard-kbl7/igt@[email protected]
- shard-tglb: NOTRUN -> [FAIL][53] ([i915#454])
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6019/shard-tglb3/igt@[email protected]

* igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-dp:
- shard-apl: NOTRUN -> [SKIP][54] ([fdo#109271] / [i915#1937])
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6019/shard-apl1/igt@i915_pm_lpsp@[email protected]

* igt@i915_pm_lpsp@screens-disabled:
- shard-tglb: NOTRUN -> [SKIP][55] ([i915#1902])
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6019/shard-tglb5/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][56] ([i915#1902])
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6019/shard-iclb8/igt@[email protected]

* igt@i915_pm_rpm@gem-execbuf-stress-pc8:
- shard-iclb: NOTRUN -> [SKIP][57] ([fdo#109293] / [fdo#109506])
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6019/shard-iclb3/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][58] ([fdo#109506] / [i915#2411])
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6019/shard-tglb3/igt@[email protected]

* igt@kms_addfb_basic@bad-pitch-63:
- shard-apl: [PASS][59] -> [DMESG-WARN][60] ([i915#1982])
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10344/shard-apl1/igt@[email protected]
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6019/shard-apl6/igt@[email protected]

* igt@kms_addfb_basic@invalid-smem-bo-on-discrete:
- shard-snb: NOTRUN -> [FAIL][61] ([i915#3745])
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6019/shard-snb7/igt@[email protected]

* igt@kms_big_fb@linear-16bpp-rotate-270:
- shard-tglb: NOTRUN -> [SKIP][62] ([fdo#111614]) +1 similar issue
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6019/shard-tglb7/igt@[email protected]

* igt@kms_big_fb@x-tiled-32bpp-rotate-180:
- shard-glk: [PASS][63] -> [DMESG-WARN][64] ([i915#118] / [i915#95])
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10344/shard-glk2/igt@[email protected]
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6019/shard-glk9/igt@[email protected]

* igt@kms_big_fb@x-tiled-64bpp-rotate-270:
- shard-iclb: NOTRUN -> [SKIP][65] ([fdo#110725] / [fdo#111614]) +1 similar issue
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6019/shard-iclb4/igt@[email protected]

* igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-0-hflip:
- shard-glk: NOTRUN -> [SKIP][66] ([fdo#109271] / [i915#3777])
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6019/shard-glk1/igt@[email protected]
- shard-kbl: NOTRUN -> [SKIP][67] ([fdo#109271] / [i915#3777])
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6019/shard-kbl4/igt@[email protected]

* igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-0-async-flip:
- shard-tglb: NOTRUN -> [SKIP][68] ([fdo#111615]) +2 similar issues
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6019/shard-tglb1/igt@[email protected]

* igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-0:
- shard-apl: NOTRUN -> [SKIP][69] ([fdo#109271]) +263 similar issues
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6019/shard-apl7/igt@[email protected]

* igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-0-async-flip:
- shard-iclb: NOTRUN -> [SKIP][70] ([fdo#110723]) +2 similar issues
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6019/shard-iclb3/igt@[email protected]

* igt@kms_ccs@pipe-b-crc-sprite-planes-basic-y_tiled_gen12_mc_ccs:
- shard-tglb: NOTRUN -> [SKIP][71] ([i915#3689]) +16 similar issues
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6019/shard-tglb2/igt@kms_ccs@pipe-b-crc-sprite-planes-basic-y_tiled_gen12_mc_ccs.html

* igt@kms_ccs@pipe-d-bad-pixel-format-y_tiled_ccs:
- shard-snb: NOTRUN -> [SKIP][72] ([fdo#109271]) +440 similar issues
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6019/shard-snb7/igt@kms_ccs@pipe-d-bad-pixel-format-y_tiled_ccs.html

* igt@kms_ccs@pipe-d-crc-primary-basic-y_tiled_gen12_mc_ccs:
- shard-iclb: NOTRUN -> [SKIP][73] ([fdo#109278]) +41 similar issues
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6019/shard-iclb5/igt@kms_ccs@pipe-d-crc-primary-basic-y_tiled_gen12_mc_ccs.html

* igt@kms_chamelium@hdmi-mode-timings:
- shard-snb: NOTRUN -> [SKIP][74] ([fdo#109271] / [fdo#111827]) +18 similar issues
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6019/shard-snb5/igt@[email protected]

* igt@kms_chamelium@vga-edid-read:
- shard-apl: NOTRUN -> [SKIP][75] ([fdo#109271] / [fdo#111827]) +21 similar issues
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6019/shard-apl6/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][76] ([fdo#109284] / [fdo#111827]) +4 similar issues
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6019/shard-iclb8/igt@[email protected]
- shard-glk: NOTRUN -> [SKIP][77] ([fdo#109271] / [fdo#111827]) +3 similar issues
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6019/shard-glk1/igt@[email protected]

* igt@kms_color@pipe-d-ctm-0-5:
- shard-iclb: NOTRUN -> [SKIP][78] ([fdo#109278] / [i915#1149])
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6019/shard-iclb7/igt@[email protected]

* igt@kms_color_chamelium@pipe-a-ctm-0-75:
- shard-kbl: NOTRUN -> [SKIP][79] ([fdo#109271] / [fdo#111827]) +8 similar issues
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6019/shard-kbl3/igt@[email protected]

* igt@kms_color_chamelium@pipe-b-ctm-0-75:
- shard-tglb: NOTRUN -> [SKIP][80] ([fdo#109284] / [fdo#111827]) +4 similar issues
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6019/shard-tglb1/igt@[email protected]

* igt@kms_color_chamelium@pipe-d-ctm-0-25:
- shard-iclb: NOTRUN -> [SKIP][81] ([fdo#109278] / [fdo#109284] / [fdo#111827]) +1 similar issue
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6019/shard-iclb8/igt@[email protected]

* igt@kms_content_protection@atomic:
- shard-apl: NOTRUN -> [TIMEOUT][82] ([i915#1319]) +1 similar issue
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6019/shard-apl6/igt@[email protected]

* igt@kms_content_protection@dp-mst-lic-type-0:
- shard-tglb: NOTRUN -> [SKIP][83] ([i915#3116])
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6019/shard-tglb1/igt@[email protected]

* igt@kms_content_protection@dp-mst-lic-type-1:
- shard-iclb: NOTRUN -> [SKIP][84] ([i915#3116])
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6019/shard-iclb8/igt@[email protected]

* igt@kms_content_protection@legacy:
- shard-iclb: NOTRUN -> [SKIP][85] ([fdo#109300] / [fdo#111066])
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6019/shard-iclb3/igt@[email protected]
- shard-kbl: NOTRUN -> [TIMEOUT][86] ([i915#1319])
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6019/shard-kbl7/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][87] ([fdo#111828])
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6019/shard-tglb3/igt@[email protected]

* igt@kms_cursor_crc@pipe-a-cursor-suspend:
- shard-kbl: [PASS][88] -> [FAIL][89] ([i915#3444])
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10344/shard-kbl7/igt@[email protected]
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6019/shard-kbl7/igt@[email protected]
- shard-apl: [PASS][90] -> [FAIL][91] ([i915#3444])
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10344/shard-apl1/igt@[email protected]
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6019/shard-apl1/igt@[email protected]

* igt@kms_cursor_crc@pipe-b-cursor-256x256-onscreen:
- shard-snb: [PASS][92] -> [SKIP][93] ([fdo#109271]) +1 similar issue
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10344/shard-snb7/igt@[email protected]
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6019/shard-snb7/igt@[email protected]

* igt@kms_cursor_crc@pipe-b-cursor-32x32-rapid-movement:
- shard-tglb: NOTRUN -> [SKIP][94] ([i915#3319])
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6019/shard-tglb6/igt@[email protected]

* igt@kms_cursor_crc@pipe-b-cursor-512x170-random:
- shard-iclb: NOTRUN -> [SKIP][95] ([fdo#109278] / [fdo#109279]) +3 similar issues
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6019/shard-iclb5/igt@[email protected]

* igt@kms_cursor_crc@pipe-c-cursor-max-size-sliding:
- shard-tglb: NOTRUN -> [SKIP][96] ([i915#3359]) +5 similar issues
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6019/shard-tglb6/igt@[email protected]

* igt@kms_cursor_crc@pipe-d-cursor-256x85-offscreen:
- shard-tglb: [PASS][97] -> [DMESG-WARN][98] ([i915#2868])
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10344/shard-tglb3/igt@[email protected]
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6019/shard-tglb5/igt@[email protected]

* igt@kms_cursor_crc@pipe-d-cursor-512x170-random:
- shard-tglb: NOTRUN -> [SKIP][99] ([fdo#109279] / [i915#3359]) +4 similar issues
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6019/shard-tglb1/igt@[email protected]

* igt@kms_cursor_legacy@cursorb-vs-flipb-toggle:
- shard-iclb: NOTRUN -> [SKIP][100] ([fdo#109274] / [fdo#109278]) +3 similar issues
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6019/shard-iclb6/igt@[email protected]

* igt@kms_cursor_legacy@pipe-d-torture-bo:
- shard-apl: NOTRUN -> [SKIP][101] ([fdo#109271] / [i915#533]) +1 similar issue
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6019/shard-apl8/igt@[email protected]

* igt@kms_dp_tiled_display@basic-test-pattern:
- shard-tglb: NOTRUN -> [SKIP][102] ([i915#426])
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6019/shard-tglb1/igt@[email protected]

* igt@kms_flip@2x-flip-vs-wf_vblank-interruptible:
- shard-iclb: NOTRUN -> [SKIP][103] ([fdo#109274]) +1 similar issue
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6019/shard-iclb3/igt@kms_flip@2x-flip-vs-wf_vblank-interruptible.html

* igt@kms_flip@flip-vs-expired-vblank-interruptible@a-hdmi-a1:
- shard-glk: [PASS][104] -> [FAIL][105] ([i915#2122])
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10344/shard-glk1/igt@kms_flip@[email protected]
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6019/shard-glk2/igt@kms_flip@[email protected]

* igt@kms_flip@flip-vs-suspend-interruptible@c-dp1:
- shard-apl: [PASS][106] -> [DMESG-WARN][107] ([i915#180]) +3 similar issues
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10344/shard-apl3/igt@kms_flip@[email protected]
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6019/shard-apl3/igt@kms_flip@[email protected]

* igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilercccs:
- shard-kbl: NOTRUN -> [SKIP][108] ([fdo#109271] / [i915#2672])
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6019/shard-kbl3/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-pri-indfb-draw-mmap-wc:
- shard-tglb: NOTRUN -> [SKIP][109] ([fdo#111825]) +27 similar issues
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6019/shard-tglb2/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-pri-indfb-draw-mmap-wc.html

* igt@kms_frontbuffer_tracking@fbc-2p-shrfb-fliptrack-mmap-gtt:
- shard-iclb: NOTRUN -> [SKIP][110] ([fdo#109280]) +22 similar issues
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6019/shard-iclb2/igt@[email protected]

* igt@kms_frontbuffer_tracking@psr-2p-scndscrn-spr-indfb-draw-render:
- shard-glk: NOTRUN -> [SKIP][111] ([fdo#109271]) +73 similar issues
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6019/shard-glk6/igt@kms_frontbuffer_tracking@psr-2p-scndscrn-spr-indfb-draw-render.html

* igt@kms_pipe_b_c_ivb@disable-pipe-b-enable-pipe-c:
- shard-iclb: NOTRUN -> [SKIP][112] ([fdo#109289]) +3 similar issues
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6019/shard-iclb7/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][113] ([fdo#109289]) +1 similar issue
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6019/shard-tglb3/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-a-alpha-opaque-fb:
- shard-glk: NOTRUN -> [FAIL][114] ([fdo#108145] / [i915#265])
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6019/shard-glk6/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-c-alpha-7efc:
- shard-kbl: NOTRUN -> [FAIL][115] ([fdo#108145] / [i915#265]) +2 similar issues
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6019/shard-kbl7/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-c-alpha-basic:
- shard-apl: NOTRUN -> [FAIL][116] ([fdo#108145] / [i915#265]) +1 similar issue
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6019/shard-apl1/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-c-alpha-transparent-fb:
- shard-apl: NOTRUN -> [FAIL][117] ([i915#265])
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6019/shard-apl8/igt@[email protected]
- shard-kbl: NOTRUN -> [FAIL][118] ([i915#265])
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6019/shard-kbl3/igt@[email protected]

* igt@kms_plane_lowres@pipe-a-tiling-y:
- shard-iclb: NOTRUN -> [SKIP][119] ([i915#3536])
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6019/shard-iclb3/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][120] ([i915#3536]) +1 similar issue
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6019/shard-tglb3/igt@[email protected]

* igt@kms_plane_lowres@pipe-d-tiling-yf:
- shard-tglb: NOTRUN -> [SKIP][121] ([fdo#112054]) +1 similar issue
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6019/shard-tglb7/igt@[email protected]

* igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-2:
- shard-tglb: NOTRUN -> [SKIP][122] ([i915#2920]) +4 similar issues
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6019/shard-tglb3/igt@[email protected]

* igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-3:
- shard-iclb: NOTRUN -> [SKIP][123] ([i915#658]) +3 similar issues
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6019/shard-iclb4/igt@[email protected]
- shard-kbl: NOTRUN -> [SKIP][124] ([fdo#109271] / [i915#658]) +5 similar issues
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6019/shard-kbl1/igt@[email protected]

* igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-5:
- shard-apl: NOTRUN -> [SKIP][125] ([fdo#109271] / [i915#658]) +4 similar issues
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6019/shard-apl1/igt@[email protected]
- shard-glk: NOTRUN -> [SKIP][126] ([fdo#109271] / [i915#658]) +2 similar issues
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6019/shard-glk6/igt@[email protected]

* igt@kms_psr@psr2_cursor_plane_onoff:
- shard-iclb: NOTRUN -> [SKIP][127] ([fdo#109441]) +2 similar issues
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6019/shard-iclb5/igt@kms_psr@psr2_cursor_plane_onoff.html

* igt@kms_psr@psr2_no_drrs:
- shard-iclb: [PASS][128] -> [SKIP][129] ([fdo#109441]) +3 similar issues
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10344/shard-iclb2/igt@kms_psr@psr2_no_drrs.html
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6019/shard-iclb1/igt@kms_psr@psr2_no_drrs.html

* igt@kms_psr@psr2_primary_mmap_gtt:
- shard-tglb: NOTRUN -> [FAIL][130] ([i915#132] / [i915#3467]) +2 similar issues
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6019/shard-tglb1/igt@kms_psr@psr2_primary_mmap_gtt.html

* igt@kms_setmode@basic:
- shard-snb: NOTRUN -> [FAIL][131] ([i915#31])
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6019/shard-snb2/igt@[email protected]

* igt@kms_universal_plane@disable-primary-vs-flip-pipe-d:
- shard-kbl: NOTRUN -> [SKIP][132] ([fdo#109271]) +139 similar issues
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6019/shard-kbl7/igt@[email protected]

* igt@kms_vblank@pipe-a-ts-continuation-suspend:
- shard-apl: [PASS][133] -> [DMESG-WARN][134] ([i915#180] / [i915#295])
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10344/shard-apl3/igt@[email protected]
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6019/shard-apl3/igt@[email protected]

* igt@kms_vblank@pipe-d-wait-idle:
- shard-kbl: NOTRUN -> [SKIP][135] ([fdo#109271] / [i915#533]) +1 similar issue
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6019/shard-kbl3/igt@[email protected]
- shard-glk: NOTRUN -> [SKIP][136] ([fdo#109271] / [i915#533]) +1 similar issue
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6019/shard-glk8/igt@[email protected]

* igt@nouveau_crc@pipe-b-ctx-flip-detection:
- shard-iclb: NOTRUN -> [SKIP][137] ([i915#2530])
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6019/shard-iclb7/igt@[email protected]

* igt@nouveau_crc@pipe-d-source-outp-complete:
- shard-tglb: NOTRUN -> [SKIP][138] ([i915#2530])
[138]: https://intel-gfx-ci.01.org/t

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6019/index.html

_______________________________________________
igt-dev mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/igt-dev