PCI: hv: Support host bridge probing on ARM64
Subsystems (5)
v4 cover PCI: hv: Support host bridge probing on ARM64
Hi Bjorn, Arnd and Marc,
This is the v4 for the preparation of virtual PCI support on Hyper-V ARM64. Previous versions:
v1: https://lore.kernel.org/lkml/[email protected]/
v2: https://lore.kernel.org/lkml/[email protected]/
v3: https://lore.kernel.org/lkml/[email protected]/
Changes since last version:
* Rebase to 5.14-rc1.
* Change the ordering of patches, now the first three patches are
non Hyper-V specific ones (i.e. patches touch general code), make it convenient to review.
The basic problem we need to resolve is that ARM64 is an arch with PCI_DOMAINS_GENERIC=y, so the bus sysdata is pci_config_window. However, Hyper-V PCI provides a paravirtualized PCI interface, so there is no actual pci_config_window for a PCI host bridge, so no information can be retrieve from the pci_config_window of a Hyper-V virtual PCI bus. Also there is no corresponding ACPI device for the Hyper-V PCI root bridge, which introduces a special case when trying to find the ACPI device from the sysdata (see patch #3).
With this patchset, we could enable the virtual PCI on Hyper-V ARM64 guest with other code under development.
Comments and suggestions are welcome.
Regards,
Boqun
Arnd Bergmann (1):
PCI: hv: Generify PCI probing
Boqun Feng (6):
PCI: Introduce domain_nr in pci_host_bridge
PCI: Allow msi domain set-up at host probing time
arm64: PCI: Support root bridge preparation for Hyper-V PCI
PCI: hv: Use pci_host_bridge::domain_nr for PCI domain
PCI: hv: Set up msi domain at bridge probing time
PCI: hv: Turn on the host bridge probing on ARM64
arch/arm64/kernel/pci.c | 8 ++- drivers/pci/controller/pci-hyperv.c | 86 +++++++++++++++++------------ drivers/pci/probe.c | 11 +++- include/linux/pci.h | 10 ++++ 4 files changed, 76 insertions(+), 39 deletions(-)
Signature · 1 line
2.30.2
RFC v4 1/7 PCI: Introduce domain_nr in pci_host_bridge
Currently we retrieve the PCI domain number of the host bridge from the bus sysdata (or pci_config_window if PCI_DOMAINS_GENERIC=y). Actually we have the information at PCI host bridge probing time, and it makes sense that we store it into pci_host_bridge. One benefit of doing so is the requirement for supporting PCI on Hyper-V for ARM64, because the host bridge of Hyper-V doesn't have pci_config_window, whereas ARM64 is a PCI_DOMAINS_GENERIC=y arch, so we cannot retrieve the PCI domain number from pci_config_window on ARM64 Hyper-V guest.
As the preparation for ARM64 Hyper-V PCI support, we introduce the domain_nr in pci_host_bridge and a sentinel value to allow drivers to set domain numbers properly at probing time. Currently CONFIG_PCI_DOMAINS_GENERIC=y archs are only users of this newly-introduced field.
--- drivers/pci/probe.c | 6 +++++- include/linux/pci.h | 10 ++++++++++ 2 files changed, 15 insertions(+), 1 deletion(-)
drivers/pci/probe.c +5 -1
@@ -594,6 +594,7 @@ static void pci_init_host_bridge(struct pci_host_bridge *bridge) bridge->native_pme =1 ; bridge->native_ltr =1 ; bridge->native_dpc =1 ; + bridge->domain_nr =PCI_DOMAIN_NR_NOT_SET ;device_initialize (&bridge->dev); }
@@ -898,7 +899,10 @@ static int pci_register_host_bridge(struct pci_host_bridge *bridge) bus->ops = bridge->ops; bus->number = bus->busn_res.start = bridge->busnr;#ifdef CONFIG_PCI_DOMAINS_GENERIC - bus->domain_nr =pci_bus_find_domain_nr (bus, parent); +if (bridge->domain_nr ==PCI_DOMAIN_NR_NOT_SET ) + bus->domain_nr =pci_bus_find_domain_nr (bus, parent); +else + bus->domain_nr = bridge->domain_nr;#endif b =pci_find_bus (pci_domain_nr (bus), bridge->busnr);
include/linux/pci.h +10 -0
@@ -526,6 +526,15 @@ static inline int pci_channel_offline(struct pci_dev *pdev)return (pdev->error_state != pci_channel_io_normal); } +/* +* PCI Conventional has at most 256 PCI bus segments and PCI Express has at +* most 65536 "PCI Segments Groups", therefore -1 is not a valid PCI domain +* number, and can be used as a sentinel value indicating ->domain_nr is not +* set by the driver (and CONFIG_PCI_DOMAINS_GENERIC=y can set it in generic +* code). +*/ +#define PCI_DOMAIN_NR_NOT_SET (-1) +struct pci_host_bridge {struct device dev;struct pci_bus *bus;/* Root bus */
@@ -533,6 +542,7 @@ struct pci_host_bridge {struct pci_ops *child_ops;void *sysdata;int busnr; +int domain_nr;struct list_head windows;/* resource_entry */ struct list_head dma_ranges;/* dma ranges resource list */ u8 (*swizzle_irq)(struct pci_dev *,u8 *);/* Platform IRQ swizzler */
Signature · 1 line
2.30.2
Re: [RFC v4 1/7] PCI: Introduce domain_nr in pci_host_bridge
Quoted 9 lines · Boqun Feng
Currently we retrieve the PCI domain number of the host bridge from the bus sysdata (or
pci_config_windowif PCI_DOMAINS_GENERIC=y). Actually we have the information at PCI host bridge probing time, and it makes sense that we store it intopci_host_bridge. One benefit of doing so is the requirement for supporting PCI on Hyper-V for ARM64, because the host bridge of Hyper-V doesn't havepci_config_window, whereas ARM64 is a PCI_DOMAINS_GENERIC=y arch, so we cannot retrieve the PCI domain number frompci_config_windowon ARM64 Hyper-V guest.
Quoted 5 lines
As the preparation for ARM64 Hyper-V PCI support, we introduce the
domain_nrinpci_host_bridgeand a sentinel value to allow drivers to set domain numbers properly at probing time. CurrentlyCONFIG_PCI_DOMAINS_GENERIC=yarchs are only users of this newly-introduced field.
Thanks for pushing on this. PCI_DOMAINS_GENERIC is really not very generic today and it will be good to make it more so.
Quoted 19 lines
Signed-off-by Boqun Feng <[email protected]>--- drivers/pci/probe.c | 6 +++++- include/linux/pci.h | 10 ++++++++++ 2 files changed, 15 insertions(+), 1 deletion(-)drivers/pci/probe.c +1
-0@@ -594,6 +594,7 @@ static void pci_init_host_bridge(struct pci_host_bridge *bridge) bridge->native_pme =1 ; bridge->native_ltr =1 ; bridge->native_dpc =1 ; + bridge->domain_nr =PCI_DOMAIN_NR_NOT_SET ;device_initialize (&bridge->dev); }
drivers/pci/probe.c static int pci_register_host_bridge(struct pci_host_bridge *bridge) · line 905
Quoted 8 lines
drivers/pci/probe.c +4
-1@@ -898,7 +899,10 @@ static int pci_register_host_bridge(struct pci_host_bridge *bridge) bus->ops = bridge->ops; bus->number = bus->busn_res.start = bridge->busnr;#ifdef CONFIG_PCI_DOMAINS_GENERIC - bus->domain_nr =pci_bus_find_domain_nr (bus, parent); +if (bridge->domain_nr ==PCI_DOMAIN_NR_NOT_SET ) + bus->domain_nr =pci_bus_find_domain_nr (bus, parent); +else + bus->domain_nr = bridge->domain_nr;
The domain_nr in struct pci_bus is really only used by pci_domain_nr(). It seems like it really belongs in the struct pci_host_bridge and probably doesn't need to be duplicated in the struct pci_bus. But that's probably a project for the future.
Quoted 8 lines
drivers/pci/probe.c +0
-0#endif b =pci_find_bus (pci_domain_nr (bus), bridge->busnr);include/linux/pci.h +0
-0
include/linux/pci.h static inline int pci_channel_offline(struct pci_dev *pdev) · line 531
Quoted 6 lines
include/linux/pci.h +3
-0@@ -526,6 +526,15 @@ static inline int pci_channel_offline(struct pci_dev *pdev)return (pdev->error_state != pci_channel_io_normal); } +/* +* PCI Conventional has at most 256 PCI bus segments and PCI Express has at +* most 65536 "PCI Segments Groups", therefore -1 is not a valid PCI domain
s/Segments/Segment/
Do you have a reference for these limits? I don't think either Conventional PCI or PCIe actually specifies a hardware limit on the number of domains (I think PCI uses "segment group" to mean the same thing).
"Segment" in the Conventional PCI spec, r3.0, means a bus segment, which connects all the devices on a single bus. Obviously there's a limit of 256 buses under a single host bridge, but that's different concept than a domain/segment group.
The PCI Firmware spec, r3.3, defines "Segment Group Number" as being in the range 0..65535, but as far as I know, that's just a firmware issue, and it applies equally to Conventional PCI and PCIe.
I think you're right that -1 is a reasonable sentinel; I just don't want to claim a difference here unless there really is one.
Quoted 20 lines
include/linux/pci.h +7
-0+* number, and can be used as a sentinel value indicating ->domain_nr is not +* set by the driver (and CONFIG_PCI_DOMAINS_GENERIC=y can set it in generic +* code). +*/ +#define PCI_DOMAIN_NR_NOT_SET (-1) +struct pci_host_bridge {struct device dev;struct pci_bus *bus;/* Root bus */ @@ -533,6 +542,7 @@ struct pci_host_bridge {struct pci_ops *child_ops;void *sysdata;int busnr; +int domain_nr;struct list_head windows;/* resource_entry */ struct list_head dma_ranges;/* dma ranges resource list */ u8 (*swizzle_irq)(struct pci_dev *,u8 *);/* Platform IRQ swizzler */ Signature · 1 line
2.30.2
Re: [RFC v4 1/7] PCI: Introduce domain_nr in pci_host_bridge
Quoted 35 lines · Bjorn Helgaas
Quoted 9 lines · Boqun Feng
Currently we retrieve the PCI domain number of the host bridge from the bus sysdata (or
pci_config_windowif PCI_DOMAINS_GENERIC=y). Actually we have the information at PCI host bridge probing time, and it makes sense that we store it intopci_host_bridge. One benefit of doing so is the requirement for supporting PCI on Hyper-V for ARM64, because the host bridge of Hyper-V doesn't havepci_config_window, whereas ARM64 is a PCI_DOMAINS_GENERIC=y arch, so we cannot retrieve the PCI domain number frompci_config_windowon ARM64 Hyper-V guest.Quoted 5 lines
As the preparation for ARM64 Hyper-V PCI support, we introduce the
domain_nrinpci_host_bridgeand a sentinel value to allow drivers to set domain numbers properly at probing time. CurrentlyCONFIG_PCI_DOMAINS_GENERIC=yarchs are only users of this newly-introduced field.Thanks for pushing on this.
PCI_DOMAINS_GENERICis really not very generic today and it will be good to make it more so.Quoted 16 lines
Signed-off-by Boqun Feng <[email protected]>--- drivers/pci/probe.c | 6 +++++- include/linux/pci.h | 10 ++++++++++ 2 files changed, 15 insertions(+), 1 deletion(-)drivers/pci/probe.c +1
-0@@ -594,6 +594,7 @@ static void pci_init_host_bridge(struct pci_host_bridge *bridge) bridge->native_pme =1 ; bridge->native_ltr =1 ; bridge->native_dpc =1 ; + bridge->domain_nr =PCI_DOMAIN_NR_NOT_SET ;
Quoted 17 lines
drivers/pci/probe.c static int pci_register_host_bridge(struct pci_host_bridge *bridge) · line 905
Quoted 11 lines
drivers/pci/probe.c +4
-1device_initialize (&bridge->dev); }@@ -898,7 +899,10 @@ static int pci_register_host_bridge(struct pci_host_bridge *bridge) bus->ops = bridge->ops; bus->number = bus->busn_res.start = bridge->busnr;#ifdef CONFIG_PCI_DOMAINS_GENERIC - bus->domain_nr =pci_bus_find_domain_nr (bus, parent); +if (bridge->domain_nr ==PCI_DOMAIN_NR_NOT_SET ) + bus->domain_nr =pci_bus_find_domain_nr (bus, parent); +else + bus->domain_nr = bridge->domain_nr;The
domain_nrin structpci_busis really only used bypci_domain_nr(). It seems like it really belongs in the structpci_host_bridgeand probably doesn't need to be duplicated in the structpci_bus. But that's probably a project for the future.
Agreed. Maybe we can define pci_bus_domain_nr() as:
static inline int pci_domain_nr(struct pci_bus *bus)
{
struct device *bridge = bus->bridge;
struct pci_host_bridge *b = container_of(bridge, struct pci_host_bridge, dev);
return b->domain_nr;
}but apart from corretness (e.g. should we use get_device() for bus->bridge?), it makes more sense if ->domain_nr of pci_host_bridge is used (as a way to set domain number at probing time) for most of drivers and archs. ;-)
Quoted 27 lines
Quoted 8 lines
drivers/pci/probe.c +0
-0#endif b =pci_find_bus (pci_domain_nr (bus), bridge->busnr);include/linux/pci.h +0
-0include/linux/pci.h static inline int pci_channel_offline(struct pci_dev *pdev) · line 531
Quoted 6 lines
include/linux/pci.h +3
-0@@ -526,6 +526,15 @@ static inline int pci_channel_offline(struct pci_dev *pdev)return (pdev->error_state != pci_channel_io_normal); } +/* +* PCI Conventional has at most 256 PCI bus segments and PCI Express has at +* most 65536 "PCI Segments Groups", therefore -1 is not a valid PCI domain s/Segments/Segment/
Do you have a reference for these limits? I don't think either Conventional PCI or PCIe actually specifies a hardware limit on the number of domains (I think PCI uses "segment group" to mean the same thing).
"Segment" in the Conventional PCI spec, r3.0, means a bus segment, which connects all the devices on a single bus. Obviously there's a limit of 256 buses under a single host bridge, but that's different concept than a domain/segment group.
Quoted 7 lines
The PCI Firmware spec, r3.3, defines "Segment Group Number" as being in the range 0..65535, but as far as I know, that's just a firmware issue, and it applies equally to Conventional PCI and PCIe.
I think you're right that -1 is a reasonable sentinel; I just don't want to claim a difference here unless there really is one.
I think you're right, I got confused on the concepts of "Segment" and "Segment Group".
After digging in specs, I haven't find any difference on the limitation between Conventional PCI and PCIe. The PCI Firmware spec, r3.2, refers ACPI (3.0 and later) spec for the details of "Segment Group", and in ACPI spec v6.3, the description _SEG object says:
"""
The lower 16 bits of _SEG returned integer is the PCI Segment Group number. Other bits are reserved.
"""
So I'm thinking replacing the comments with:
Currently in ACPI spec, for each PCI host bridge, PCI Segment Group number is limited to a 16-bit value, therefore (int)-1 is not a valid PCI domain number, and can be used as a sentinel value indicating ->domain_nr is not set by the driver (and CONFIG_PCI_DOMAINS_GENERIC=y archs will set it with pci_bus_find_domain_nr()).
Thoughts?
Regards,
BOqun
Quoted 20 lines
Quoted 20 lines
include/linux/pci.h +7
-0+* number, and can be used as a sentinel value indicating ->domain_nr is not +* set by the driver (and CONFIG_PCI_DOMAINS_GENERIC=y can set it in generic +* code). +*/ +#define PCI_DOMAIN_NR_NOT_SET (-1) +struct pci_host_bridge {struct device dev;struct pci_bus *bus;/* Root bus */ @@ -533,6 +542,7 @@ struct pci_host_bridge {struct pci_ops *child_ops;void *sysdata;int busnr; +int domain_nr;struct list_head windows;/* resource_entry */ struct list_head dma_ranges;/* dma ranges resource list */ u8 (*swizzle_irq)(struct pci_dev *,u8 *);/* Platform IRQ swizzler */ Signature · 1 line
2.30.2
Re: [RFC v4 1/7] PCI: Introduce domain_nr in pci_host_bridge
Quoted 63 lines · Boqun Feng
Quoted 35 lines · Bjorn Helgaas
Quoted 9 lines · Boqun Feng
Currently we retrieve the PCI domain number of the host bridge from the bus sysdata (or
pci_config_windowif PCI_DOMAINS_GENERIC=y). Actually we have the information at PCI host bridge probing time, and it makes sense that we store it intopci_host_bridge. One benefit of doing so is the requirement for supporting PCI on Hyper-V for ARM64, because the host bridge of Hyper-V doesn't havepci_config_window, whereas ARM64 is a PCI_DOMAINS_GENERIC=y arch, so we cannot retrieve the PCI domain number frompci_config_windowon ARM64 Hyper-V guest.Quoted 5 lines
As the preparation for ARM64 Hyper-V PCI support, we introduce the
domain_nrinpci_host_bridgeand a sentinel value to allow drivers to set domain numbers properly at probing time. CurrentlyCONFIG_PCI_DOMAINS_GENERIC=yarchs are only users of this newly-introduced field.Thanks for pushing on this.
PCI_DOMAINS_GENERICis really not very generic today and it will be good to make it more so.Quoted 16 lines
Signed-off-by Boqun Feng <[email protected]>--- drivers/pci/probe.c | 6 +++++- include/linux/pci.h | 10 ++++++++++ 2 files changed, 15 insertions(+), 1 deletion(-)drivers/pci/probe.c +1
-0@@ -594,6 +594,7 @@ static void pci_init_host_bridge(struct pci_host_bridge *bridge) bridge->native_pme =1 ; bridge->native_ltr =1 ; bridge->native_dpc =1 ; + bridge->domain_nr =PCI_DOMAIN_NR_NOT_SET ;Quoted 16 lines
drivers/pci/probe.c static int pci_register_host_bridge(struct pci_host_bridge *bridge) · line 905
Quoted 11 lines
drivers/pci/probe.c +4
-1device_initialize (&bridge->dev); }@@ -898,7 +899,10 @@ static int pci_register_host_bridge(struct pci_host_bridge *bridge) bus->ops = bridge->ops; bus->number = bus->busn_res.start = bridge->busnr;#ifdef CONFIG_PCI_DOMAINS_GENERIC - bus->domain_nr =pci_bus_find_domain_nr (bus, parent); +if (bridge->domain_nr ==PCI_DOMAIN_NR_NOT_SET ) + bus->domain_nr =pci_bus_find_domain_nr (bus, parent); +else + bus->domain_nr = bridge->domain_nr;The
domain_nrin structpci_busis really only used bypci_domain_nr(). It seems like it really belongs in the structpci_host_bridgeand probably doesn't need to be duplicated in the structpci_bus. But that's probably a project for the future.Agreed. Maybe we can define
pci_bus_domain_nr()as:static inline int pci_domain_nr(struct pci_bus *bus) { struct device *bridge = bus->bridge; struct pci_host_bridge *b = container_of(bridge, struct pci_host_bridge, dev); return b->domain_nr; }
Quoted 4 lines
but apart from corretness (e.g. should we use
get_device()forbus->bridge?), it makes more sense if ->domain_nr ofpci_host_bridgeis used (as a way to set domain number at probing time) for most of drivers and archs. ;-)
If we're holding a struct pci_bus *, we must have a reference on the bus, which in turn holds a reference on upstream devices, so there should be no need for get_device() here.
But yes, I think something like this is where we should be heading.
Quoted 48 lines
Quoted 27 lines
Quoted 8 lines
drivers/pci/probe.c +0
-0#endif b =pci_find_bus (pci_domain_nr (bus), bridge->busnr);include/linux/pci.h +0
-0include/linux/pci.h static inline int pci_channel_offline(struct pci_dev *pdev) · line 531
Quoted 6 lines
include/linux/pci.h +3
-0@@ -526,6 +526,15 @@ static inline int pci_channel_offline(struct pci_dev *pdev)return (pdev->error_state != pci_channel_io_normal); } +/* +* PCI Conventional has at most 256 PCI bus segments and PCI Express has at +* most 65536 "PCI Segments Groups", therefore -1 is not a valid PCI domain s/Segments/Segment/
Do you have a reference for these limits? I don't think either Conventional PCI or PCIe actually specifies a hardware limit on the number of domains (I think PCI uses "segment group" to mean the same thing).
"Segment" in the Conventional PCI spec, r3.0, means a bus segment, which connects all the devices on a single bus. Obviously there's a limit of 256 buses under a single host bridge, but that's different concept than a domain/segment group.
Quoted 7 lines
The PCI Firmware spec, r3.3, defines "Segment Group Number" as being in the range 0..65535, but as far as I know, that's just a firmware issue, and it applies equally to Conventional PCI and PCIe.
I think you're right that -1 is a reasonable sentinel; I just don't want to claim a difference here unless there really is one.
I think you're right, I got confused on the concepts of "Segment" and "Segment Group".
After digging in specs, I haven't find any difference on the limitation between Conventional PCI and PCIe. The PCI Firmware spec, r3.2, refers ACPI (3.0 and later) spec for the details of "Segment Group", and in ACPI spec v6.3, the description
_SEGobject says:"""
The lower 16 bits of_SEGreturned integer is the PCI Segment Group number. Other bits are reserved.
"""
Quoted 7 lines
So I'm thinking replacing the comments with:
Currently in ACPI spec, for each PCI host bridge, PCI Segment Group number is limited to a 16-bit value, therefore (int)-1 is not a valid PCI domain number, and can be used as a sentinel value indicating ->domain_nr is not set by the driver (and
CONFIG_PCI_DOMAINS_GENERIC=yarchs will set it withpci_bus_find_domain_nr()).
Yes, I think that's a better description.
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
include/linux/pci.h +3
-0+* number, and can be used as a sentinel value indicating ->domain_nr is not +* set by the driver (and CONFIG_PCI_DOMAINS_GENERIC=y can set it in generic +* code).
Re: [RFC v4 1/7] PCI: Introduce domain_nr in pci_host_bridge
In reply to Boqun FengQuoted 9 lines · Boqun Feng
Quoted 8 lines · Bjorn Helgaas
Quoted 6 lines · Boqun Feng
#ifdef
CONFIG_PCI_DOMAINS_GENERICdrivers/pci/probe.c +4
-1- bus->domain_nr =pci_bus_find_domain_nr (bus, parent); +if (bridge->domain_nr ==PCI_DOMAIN_NR_NOT_SET ) + bus->domain_nr =pci_bus_find_domain_nr (bus, parent); +else + bus->domain_nr = bridge->domain_nr;
Quoted 5 lines
Quoted 5 lines
The
domain_nrin structpci_busis really only used bypci_domain_nr(). It seems like it really belongs in the structpci_host_bridgeand probably doesn't need to be duplicated in the structpci_bus. But that's probably a project for the future.
+1
Quoted 10 lines
Agreed. Maybe we can define
pci_bus_domain_nr()as:static inline int pci_domain_nr(struct pci_bus *bus) { struct device *bridge = bus->bridge; struct pci_host_bridge *b = container_of(bridge, struct pci_host_bridge, dev); return b->domain_nr; }
Quoted 4 lines
but apart from corretness (e.g. should we use
get_device()forbus->bridge?), it makes more sense if ->domain_nr ofpci_host_bridgeis used (as a way to set domain number at probing time) for most of drivers and archs. ;-)
It needs to be "pci_find_host_bridge(bus)" instead of bus->bridge and container_of().
Then again, if we get pci_domain_nr() to be completely generic, I'd prefer to change most callers to just open-code the bridge->domain_nr access, as most of them will already have a pointer to the pci_host_bridge when calling this.
Arnd
RFC v4 2/7 PCI: Allow msi domain set-up at host probing time
In reply to Boqun FengFor GENERIC_MSI_IRQ_DOMAIN drivers, we can set up the msi domain via dev_set_msi_domain() at probing time, and drivers can use this more generic way to set up the msi domain for the host bridge.
This is the preparation for ARM64 Hyper-V PCI support.
--- drivers/pci/probe.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
drivers/pci/probe.c +4 -1
@@ -829,11 +829,14 @@ static struct irq_domain *pci_host_bridge_msi_domain(struct pci_bus *bus) {struct irq_domain *d; +/* Default set by host bridge driver */ + d =dev_get_msi_domain (bus->bridge);/* * Any firmware interface that can resolve the msi_domain * should be called from here. */ - d =pci_host_bridge_of_msi_domain (bus); +if (!d) + d =pci_host_bridge_of_msi_domain (bus);if (!d) d =pci_host_bridge_acpi_msi_domain (bus);
Signature · 1 line
2.30.2
Re: [RFC v4 2/7] PCI: Allow msi domain set-up at host probing time
Capitalize "MSI" in subject and commit log.
Quoted 3 lines · Boqun Feng
For
GENERIC_MSI_IRQ_DOMAINdrivers, we can set up the msi domain viadev_set_msi_domain()at probing time, and drivers can use this more generic way to set up the msi domain for the host bridge.
This doesn't tell me what this patch *does* or why we need it.
Quoted 13 lines
This is the preparation for ARM64 Hyper-V PCI support.
Originally-by Arnd Bergmann <[email protected]>Signed-off-by Boqun Feng <[email protected]>--- drivers/pci/probe.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)drivers/pci/probe.c +0
-0
drivers/pci/probe.c static struct irq_domain *pci_host_bridge_msi_domain(struct pci_bus *bus) · line 833
Quoted 5 lines
drivers/pci/probe.c +2
-0@@ -829,11 +829,14 @@ static struct irq_domain *pci_host_bridge_msi_domain(struct pci_bus *bus) {struct irq_domain *d; +/* Default set by host bridge driver */ + d =dev_get_msi_domain (bus->bridge);
Add blank line here between executable code and the following comment.
Quoted 13 lines
drivers/pci/probe.c +2
-1/* * Any firmware interface that can resolve the msi_domain * should be called from here. */ - d =pci_host_bridge_of_msi_domain (bus); +if (!d) + d =pci_host_bridge_of_msi_domain (bus);if (!d) d =pci_host_bridge_acpi_msi_domain (bus);Signature · 1 line
2.30.2
RFC v4 3/7 arm64: PCI: Support root bridge preparation for Hyper-V PCI
In reply to Boqun FengCurrently at root bridge preparation, the corresponding ACPI device will be set as the companion, however for a Hyper-V virtual PCI root bridge, there is no corresponding ACPI device, because a Hyper-V virtual PCI root bridge is discovered via VMBus rather than ACPI table. In order to support this, we need to make pcibios_root_bridge_prepare() work with cfg->parent being NULL.
--- arch/arm64/kernel/pci.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-)
arch/arm64/kernel/pci.c +7 -1
@@ -84,7 +84,13 @@ int pcibios_root_bridge_prepare(struct pci_host_bridge *bridge) {if (!acpi_disabled) {struct pci_config_window *cfg = bridge->bus->sysdata; -struct acpi_device *adev =to_acpi_device (cfg->parent); +/* +* On Hyper-V there is no corresponding APCI device for a root +* bridge, therefore ->parent is set as NULL by the driver. And +* set 'adev` as NULL in this case because there is no proper +* ACPI device. +*/ +struct acpi_device *adev = cfg->parent ?to_acpi_device (cfg->parent) :NULL ;struct device *bus_dev = &bridge->bus->dev;ACPI_COMPANION_SET (&bridge->dev, adev);
Signature · 1 line
2.30.2
Re: [RFC v4 3/7] arm64: PCI: Support root bridge preparation for Hyper-V PCI
Quoted 6 lines · Boqun Feng
Currently at root bridge preparation, the corresponding ACPI device will be set as the companion, however for a Hyper-V virtual PCI root bridge, there is no corresponding ACPI device, because a Hyper-V virtual PCI root bridge is discovered via VMBus rather than ACPI table. In order to support this, we need to make
pcibios_root_bridge_prepare()work withcfg->parentbeing NULL.
It would be nice to have a hint about why we don't actually need the ACPI companion device in this case.
Quoted 14 lines
Signed-off-by Boqun Feng <[email protected]>--- arch/arm64/kernel/pci.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-)arch/arm64/kernel/pci.c +0
-1@@ -84,7 +84,13 @@ int pcibios_root_bridge_prepare(struct pci_host_bridge *bridge) {if (!acpi_disabled) {struct pci_config_window *cfg = bridge->bus->sysdata; -struct acpi_device *adev =to_acpi_device (cfg->parent);
arch/arm64/kernel/pci.c int pcibios_root_bridge_prepare(struct pci_host_bridge *bridge) · line 96
Quoted 10 lines
arch/arm64/kernel/pci.c +7
-0+/* +* On Hyper-V there is no corresponding APCI device for a root +* bridge, therefore ->parent is set as NULL by the driver. And +* set 'adev` as NULL in this case because there is no proper +* ACPI device. +*/ +struct acpi_device *adev = cfg->parent ?to_acpi_device (cfg->parent) :NULL ;struct device *bus_dev = &bridge->bus->dev;ACPI_COMPANION_SET (&bridge->dev, adev);
s/APCI/ACPI/ above.
I think this would be more readable like this:
struct pci_config_window *cfg = bridge->bus->sysdata; ...
if (acpi_disabled)
return 0;
/*
* On Hyper-V there is no corresponding ACPI device for a root
* ...
*/
cfg = bridge->bus->sysdata;
if (!cfg->parent)
return 0;
adev = to_acpi_device(cfg->parent); bus_dev = &bridge->bus->dev; ACPI_COMPANION_SET(&bridge->dev, adev); ...
This could be done in two steps: the first to restructure the code without making any functional change, and a second to return when there's no cfg->parent. If you do it in one step, the patch will be much harder to read.
Bjorn
RFC v4 4/7 PCI: hv: Generify PCI probing
In reply to Boqun FengFrom: Arnd Bergmann <[email protected]>
In order to support ARM64 Hyper-V PCI, we need to set up the bridge at probing time because ARM64 is a PCI_DOMAIN_GENERIC arch and we don't have pci_config_window (ARM64 sysdata) for a PCI root bus on Hyper-V, so it's impossible to retrieve the information (e.g. PCI domains, irq domains) from bus sysdata on ARM64 after creation.
Originally in create_root_hv_pci_bus(), pci_create_root_bus() is used to create the root bus and the corresponding bridge based on x86 sysdata. Now we create a bridge first and then call pci_scan_root_bus_bridge(), which allows us to do the necessary set-ups for the bridge.
---
Please note that the whole commit message is from me (Boqun), and most of the code is from Arnd, and I believe the initial purpose of the changes is for clean-up and code unification.
I added Hyper-V related rationale in the commit message because I use it to support Hyper-V virtual PCI on ARM64. If the SoB tags should be adjusted, please let me know.
drivers/pci/controller/pci-hyperv.c | 57 +++++++++++++++-------------- 1 file changed, 30 insertions(+), 27 deletions(-)
drivers/pci/controller/pci-hyperv.c +30 -27
@@ -449,6 +449,7 @@ enum hv_pcibus_state {struct hv_pcibus_device {struct pci_sysdata sysdata; +struct pci_host_bridge *bridge;/* Protocol version negotiated with the host */ enum pci_protocol_version_t protocol_version;enum hv_pcibus_state state;
@@ -464,8 +465,6 @@ struct hv_pcibus_device {spinlock_t device_list_lock;/* Protect lists below */ void __iomem *cfg_addr; -struct list_head resources_for_children; -struct list_head children;struct list_head dr_list;
@@ -1797,7 +1796,7 @@ static void hv_pci_assign_slots(struct hv_pcibus_device *hbus) slot_nr =PCI_SLOT (wslot_to_devfn (hpdev->desc.win_slot.slot));snprintf (name,SLOT_NAME_SIZE ,"%u" , hpdev->desc.ser); - hpdev->pci_slot =pci_create_slot (hbus->pci_bus, slot_nr, + hpdev->pci_slot =pci_create_slot (hbus->bridge->bus, slot_nr, name,NULL );if (IS_ERR (hpdev->pci_slot)) {pr_warn ("pci_create slot %s failed\n" , name);
@@ -1827,7 +1826,7 @@ static void hv_pci_remove_slots(struct hv_pcibus_device *hbus)static void hv_pci_assign_numa_node (struct hv_pcibus_device *hbus) {struct pci_dev *dev; -struct pci_bus *bus = hbus->pci_bus; +struct pci_bus *bus = hbus->bridge->bus;struct hv_pci_dev *hv_dev;list_for_each_entry (dev, &bus->devices, bus_list) {
@@ -1850,21 +1849,22 @@ static void hv_pci_assign_numa_node(struct hv_pcibus_device *hbus)*/ static int create_root_hv_pci_bus (struct hv_pcibus_device *hbus) { -/* Register the device */ - hbus->pci_bus =pci_create_root_bus (&hbus->hdev->device, -0 ,/* bus number is always zero */ - &hv_pcifront_ops, - &hbus->sysdata, - &hbus->resources_for_children); -if (!hbus->pci_bus) -return -ENODEV ; +int error; +struct pci_host_bridge *bridge = hbus->bridge; + + bridge->dev.parent = &hbus->hdev->device; + bridge->sysdata = &hbus->sysdata; + bridge->ops = &hv_pcifront_ops; + + error =pci_scan_root_bus_bridge (bridge); +if (error) +return error;pci_lock_rescan_remove (); -pci_scan_child_bus (hbus->pci_bus);hv_pci_assign_numa_node (hbus); -pci_bus_assign_resources (hbus->pci_bus); +pci_bus_assign_resources (bridge->bus);hv_pci_assign_slots (hbus); -pci_bus_add_devices (hbus->pci_bus); +pci_bus_add_devices (bridge->bus);pci_unlock_rescan_remove (); hbus->state = hv_pcibus_installed;return 0 ;
@@ -2127,7 +2127,7 @@ static void pci_devices_present_work(struct work_struct *work)* because there may have been changes. */ pci_lock_rescan_remove (); -pci_scan_child_bus (hbus->pci_bus); +pci_scan_child_bus (hbus->bridge->bus);hv_pci_assign_numa_node (hbus);hv_pci_assign_slots (hbus);pci_unlock_rescan_remove ();
@@ -2295,8 +2295,8 @@ static void hv_eject_device_work(struct work_struct *work)/* * Ejection can come before or after the PCI bus has been set up, so * attempt to find it and tear down the bus state, if it exists. This -* must be done without constructs like pci_domain_nr(hbus->pci_bus) -* because hbus->pci_bus may not exist yet. +* must be done without constructs like pci_domain_nr(hbus->bridge->bus) +* because hbus->bridge->bus may not exist yet. */ wslot =wslot_to_devfn (hpdev->desc.win_slot.slot); pdev =pci_get_domain_bus_and_slot (hbus->sysdata.domain,0 , wslot);
@@ -2662,8 +2662,7 @@ static int hv_pci_allocate_bridge_windows(struct hv_pcibus_device *hbus)/* Modify this resource to become a bridge window. */ hbus->low_mmio_res->flags |=IORESOURCE_WINDOW ; hbus->low_mmio_res->flags &= ~IORESOURCE_BUSY ; -pci_add_resource (&hbus->resources_for_children, - hbus->low_mmio_res); +pci_add_resource (&hbus->bridge->windows, hbus->low_mmio_res); }if (hbus->high_mmio_space) {
@@ -2682,8 +2681,7 @@ static int hv_pci_allocate_bridge_windows(struct hv_pcibus_device *hbus)/* Modify this resource to become a bridge window. */ hbus->high_mmio_res->flags |=IORESOURCE_WINDOW ; hbus->high_mmio_res->flags &= ~IORESOURCE_BUSY ; -pci_add_resource (&hbus->resources_for_children, - hbus->high_mmio_res); +pci_add_resource (&hbus->bridge->windows, hbus->high_mmio_res); }return 0 ;
@@ -3002,6 +3000,7 @@ static void hv_put_dom_num(u16 dom)static int hv_pci_probe (struct hv_device *hdev,const struct hv_vmbus_device_id *dev_id) { +struct pci_host_bridge *bridge;struct hv_pcibus_device *hbus;u16 dom_req, dom;char *name;
@@ -3014,6 +3013,10 @@ static int hv_pci_probe(struct hv_device *hdev,*/ BUILD_BUG_ON (sizeof (*hbus) >HV_HYP_PAGE_SIZE ); + bridge =devm_pci_alloc_host_bridge (&hdev->device,0 ); +if (!bridge) +return -ENOMEM ; +/* * With the recent 59bb47985c1d ("mm, sl[aou]b: guarantee natural * alignment for kmalloc(power-of-two)"), kzalloc() is able to allocate
@@ -3035,6 +3038,8 @@ static int hv_pci_probe(struct hv_device *hdev, hbus =kzalloc (HV_HYP_PAGE_SIZE ,GFP_KERNEL );if (!hbus)return -ENOMEM ; + + hbus->bridge = bridge; hbus->state = hv_pcibus_init; hbus->wslot_res_allocated =-1 ;
@@ -3071,7 +3076,6 @@ static int hv_pci_probe(struct hv_device *hdev, hbus->hdev = hdev;INIT_LIST_HEAD (&hbus->children);INIT_LIST_HEAD (&hbus->dr_list); -INIT_LIST_HEAD (&hbus->resources_for_children);spin_lock_init (&hbus->config_lock);spin_lock_init (&hbus->device_list_lock);spin_lock_init (&hbus->retarget_msi_interrupt_lock);
@@ -3295,9 +3299,9 @@ static int hv_pci_remove(struct hv_device *hdev)/* Remove the bus from PCI's point of view. */ pci_lock_rescan_remove (); -pci_stop_root_bus (hbus->pci_bus); +pci_stop_root_bus (hbus->bridge->bus);hv_pci_remove_slots (hbus); -pci_remove_root_bus (hbus->pci_bus); +pci_remove_root_bus (hbus->bridge->bus);pci_unlock_rescan_remove (); }
@@ -3307,7 +3311,6 @@ static int hv_pci_remove(struct hv_device *hdev)iounmap (hbus->cfg_addr);hv_free_config_window (hbus); -pci_free_resource_list (&hbus->resources_for_children);hv_pci_free_bridge_windows (hbus);irq_domain_remove (hbus->irq_domain);irq_domain_free_fwnode (hbus->sysdata.fwnode);
@@ -3390,7 +3393,7 @@ static int hv_pci_restore_msi_msg(struct pci_dev *pdev, void *arg)*/ static void hv_pci_restore_msi_state (struct hv_pcibus_device *hbus) { -pci_walk_bus (hbus->pci_bus, hv_pci_restore_msi_msg,NULL ); +pci_walk_bus (hbus->bridge->bus, hv_pci_restore_msi_msg,NULL ); }static int hv_pci_resume (struct hv_device *hdev)
Signature · 1 line
2.30.2
Re: [RFC v4 4/7] PCI: hv: Generify PCI probing
Quoted 8 lines · Boqun Feng
From: Arnd Bergmann <[email protected]>
In order to support ARM64 Hyper-V PCI, we need to set up the bridge at probing time because ARM64 is a
PCI_DOMAIN_GENERICarch and we don't havepci_config_window(ARM64 sysdata) for a PCI root bus on Hyper-V, so it's impossible to retrieve the information (e.g. PCI domains, irq domains) from bus sysdata on ARM64 after creation.
Quoted 4 lines
Originally in
create_root_hv_pci_bus(),pci_create_root_bus()is used to create the root bus and the corresponding bridge based on x86 sysdata. Now we create a bridge first and then callpci_scan_root_bus_bridge(), which allows us to do the necessary set-ups for the bridge.
Also here and other patches in this series:
s/irq/IRQ/
s/msi/MSI/
in subject lines, commit logs, comments.
RFC v4 5/7 PCI: hv: Use pci_host_bridge::domain_nr for PCI domain
In reply to Boqun FengNo functional change, just store and maintain the PCI domain number in the generic pci_host_bridge instead of x86 specific pci_sysdata.
--- drivers/pci/controller/pci-hyperv.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-)
drivers/pci/controller/pci-hyperv.c +5 -4
@@ -2299,7 +2299,7 @@ static void hv_eject_device_work(struct work_struct *work)* because hbus->bridge->bus may not exist yet. */ wslot =wslot_to_devfn (hpdev->desc.win_slot.slot); - pdev =pci_get_domain_bus_and_slot (hbus->sysdata.domain,0 , wslot); + pdev =pci_get_domain_bus_and_slot (hbus->bridge->domain_nr,0 , wslot);if (pdev) {pci_lock_rescan_remove ();pci_stop_and_remove_bus_device (pdev);
@@ -3071,6 +3071,7 @@ static int hv_pci_probe(struct hv_device *hdev,"PCI dom# 0x%hx has collision, using 0x%hx" , dom_req, dom); + hbus->bridge->domain_nr = dom; hbus->sysdata.domain = dom; hbus->hdev = hdev;
@@ -3080,7 +3081,7 @@ static int hv_pci_probe(struct hv_device *hdev,spin_lock_init (&hbus->device_list_lock);spin_lock_init (&hbus->retarget_msi_interrupt_lock); hbus->wq =alloc_ordered_workqueue ("hv_pci_%x" ,0 , - hbus->sysdata.domain); + hbus->bridge->domain_nr);if (!hbus->wq) { ret = -ENOMEM ; goto free_dom;
@@ -3207,7 +3208,7 @@ static int hv_pci_probe(struct hv_device *hdev, destroy_wq:destroy_workqueue (hbus->wq); free_dom: -hv_put_dom_num (hbus->sysdata.domain); +hv_put_dom_num (hbus->bridge->domain_nr); free_bus:kfree (hbus);return ret;
@@ -3315,7 +3316,7 @@ static int hv_pci_remove(struct hv_device *hdev)irq_domain_remove (hbus->irq_domain);irq_domain_free_fwnode (hbus->sysdata.fwnode); -hv_put_dom_num (hbus->sysdata.domain); +hv_put_dom_num (hbus->bridge->domain_nr);kfree (hbus);return ret;
Signature · 1 line
2.30.2
RE: [EXTERNAL] [RFC v4 5/7] PCI: hv: Use pci_host_bridge::domain_nr for PCI domain
Quoted 14 lines
drivers/pci/controller/pci-hyperv.c +1
-1@@ -2299,7 +2299,7 @@ static void hv_eject_device_work(struct work_struct *work)* because hbus->bridge->bus may not exist yet. */ wslot =wslot_to_devfn (hpdev->desc.win_slot.slot); - pdev =pci_get_domain_bus_and_slot (hbus->sysdata.domain,0 , wslot); + pdev =pci_get_domain_bus_and_slot (hbus->bridge->domain_nr,0 , wslot);if (pdev) {pci_lock_rescan_remove ();pci_stop_and_remove_bus_device (pdev);
drivers/pci/controller/pci-hyperv.c static int hv_pci_probe(struct hv_device *hdev, · line 3075
Quoted 5 lines
drivers/pci/controller/pci-hyperv.c +1
-0@@ -3071,6 +3071,7 @@ static int hv_pci_probe(struct hv_device *hdev,"PCI dom# 0x%hx has collision, using 0x%hx" , dom_req, dom); + hbus->bridge->domain_nr = dom; hbus->sysdata.domain = dom;
With your other patches everything is moving over to based off of bridge->domain_nr. Do we still need to update sysdata.domain?
Re: [EXTERNAL] [RFC v4 5/7] PCI: hv: Use pci_host_bridge::domain_nr for PCI domain
Quoted 17 lines · Sunil Muthuswamy
Quoted 17 lines
drivers/pci/controller/pci-hyperv.c +1
-1@@ -2299,7 +2299,7 @@ static void hv_eject_device_work(struct work_struct *work)* because hbus->bridge->bus may not exist yet. */ wslot =wslot_to_devfn (hpdev->desc.win_slot.slot); - pdev =pci_get_domain_bus_and_slot (hbus->sysdata.domain,0 , wslot); + pdev =pci_get_domain_bus_and_slot (hbus->bridge->domain_nr,0 , wslot);if (pdev) {pci_lock_rescan_remove ();pci_stop_and_remove_bus_device (pdev);@@ -3071,6 +3071,7 @@ static int hv_pci_probe(struct hv_device *hdev,"PCI dom# 0x%hx has collision, using 0x%hx" , dom_req, dom);
Quoted 4 lines
drivers/pci/controller/pci-hyperv.c static int hv_pci_probe(struct hv_device *hdev, · line 3075
Quoted 2 lines
drivers/pci/controller/pci-hyperv.c +1
-0+ hbus->bridge->domain_nr = dom; hbus->sysdata.domain = dom;With your other patches everything is moving over to based off of
bridge->domain_nr. Do we still need to update sysdata.domain?
Yes, we still need it, because x86 is not a CONFIG_PCI_DOMAINS_GENERIC=y architecture, and this patchset only makes CONFIG_PCI_DOMAINS_GENERIC=y archs work with bridge->domain_nr. x86 still use the arch-specific pci_domain_nr(), so we need to set the field in sysdata.
Regards,
Boqun
Quoted 1 line
RFC v4 6/7 PCI: hv: Set up msi domain at bridge probing time
In reply to Boqun FengSince PCI_HYPERV depends on PCI_MSI_IRQ_DOMAIN which selects GENERIC_MSI_IRQ_DOMAIN, we can use dev_set_msi_domain() to set up the msi irq domain at probing time, and this works for both x86 and ARM64.
Therefore use it as the preparation for ARM64 Hyper-V PCI support.
As a result, no longer need to maintain ->fwnode in x86 specific pci_sysdata, and make hv_pcibus_device own it instead.
--- drivers/pci/controller/pci-hyperv.c | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-)
drivers/pci/controller/pci-hyperv.c +8 -5
@@ -450,6 +450,7 @@ enum hv_pcibus_state {struct hv_pcibus_device {struct pci_sysdata sysdata;struct pci_host_bridge *bridge; +struct fwnode_handle *fwnode;/* Protocol version negotiated with the host */ enum pci_protocol_version_t protocol_version;enum hv_pcibus_state state;
@@ -1565,7 +1566,7 @@ static int hv_pcie_init_irq_domain(struct hv_pcibus_device *hbus) hbus->msi_info.handler = handle_edge_irq; hbus->msi_info.handler_name ="edge" ; hbus->msi_info.data = hbus; - hbus->irq_domain =pci_msi_create_irq_domain (hbus->sysdata.fwnode, + hbus->irq_domain =pci_msi_create_irq_domain (hbus->fwnode, &hbus->msi_info, x86_vector_domain);if (!hbus->irq_domain) {
@@ -1574,6 +1575,8 @@ static int hv_pcie_init_irq_domain(struct hv_pcibus_device *hbus)return -ENODEV ; } +dev_set_msi_domain (&hbus->bridge->dev, hbus->irq_domain); +return 0 ; }
@@ -3118,9 +3121,9 @@ static int hv_pci_probe(struct hv_device *hdev, goto unmap; } - hbus->sysdata.fwnode =irq_domain_alloc_named_fwnode (name); + hbus->fwnode =irq_domain_alloc_named_fwnode (name);kfree (name); -if (!hbus->sysdata.fwnode) { +if (!hbus->fwnode) { ret = -ENOMEM ; goto unmap; }
@@ -3198,7 +3201,7 @@ static int hv_pci_probe(struct hv_device *hdev, free_irq_domain:irq_domain_remove (hbus->irq_domain); free_fwnode: -irq_domain_free_fwnode (hbus->sysdata.fwnode); +irq_domain_free_fwnode (hbus->fwnode); unmap:iounmap (hbus->cfg_addr); free_config:
@@ -3314,7 +3317,7 @@ static int hv_pci_remove(struct hv_device *hdev)hv_free_config_window (hbus);hv_pci_free_bridge_windows (hbus);irq_domain_remove (hbus->irq_domain); -irq_domain_free_fwnode (hbus->sysdata.fwnode); +irq_domain_free_fwnode (hbus->fwnode);hv_put_dom_num (hbus->bridge->domain_nr);
Signature · 1 line
2.30.2
RFC v4 7/7 PCI: hv: Turn on the host bridge probing on ARM64
In reply to Boqun FengNow we have everything we need, just provide a proper sysdata type for the bus to use on ARM64 and everything else works.
--- drivers/pci/controller/pci-hyperv.c | 7 +++++++ 1 file changed, 7 insertions(+)
drivers/pci/controller/pci-hyperv.c +7 -0
@@ -40,6 +40,7 @@#include <linux/kernel.h> #include <linux/module.h> #include <linux/pci.h> +#include <linux/pci-ecam.h> #include <linux/delay.h> #include <linux/semaphore.h> #include <linux/irqdomain.h>
@@ -448,7 +449,11 @@ enum hv_pcibus_state { };struct hv_pcibus_device { +#ifdef CONFIG_X86 struct pci_sysdata sysdata; +#elif defined(CONFIG_ARM64 ) +struct pci_config_window sysdata; +#endif struct pci_host_bridge *bridge;struct fwnode_handle *fwnode;/* Protocol version negotiated with the host */
@@ -3075,7 +3080,9 @@ static int hv_pci_probe(struct hv_device *hdev, dom_req, dom); hbus->bridge->domain_nr = dom; +#ifdef CONFIG_X86 hbus->sysdata.domain = dom; +#endif hbus->hdev = hdev;INIT_LIST_HEAD (&hbus->children);
Signature · 1 line
2.30.2