xfs: detect misaligned rtinherit directory extent size hints
PATCH 1/1 xfs: detect misaligned rtinherit directory extent size hints
From: Darrick J. Wong <[email protected]>
If we encounter a directory that has been configured to pass on an extent size hint to a new realtime file and the hint isn't an integer multiple of the rt extent size, we should flag the hint for administrative review because that is a misconfiguration (that other parts of the kernel will fix automatically).
--- fs/xfs/scrub/inode.c | 18 ++++++++++++++++-- 1 file changed, 16 insertions(+), 2 deletions(-)
fs/xfs/scrub/inode.c +16 -2
@@ -73,11 +73,25 @@ xchk_inode_extsize( uint16_t flags) {xfs_failaddr_t fa; +uint32_t value =be32_to_cpu (dip->di_extsize); - fa =xfs_inode_validate_extsize (sc->mp,be32_to_cpu (dip->di_extsize), - mode, flags); + fa =xfs_inode_validate_extsize (sc->mp, value, mode, flags);if (fa)xchk_ino_set_corrupt (sc, ino); + +/* +* XFS allows a sysadmin to change the rt extent size when adding a rt +* section to a filesystem after formatting. If there are any +* directories with extszinherit and rtinherit set, the hint could +* become misaligned with the new rextsize. The verifier doesn't check +* this, because we allow rtinherit directories even without an rt +* device. Flag this as an administrative warning since we will clean +* this up eventually. +*/ +if ((flags &XFS_DIFLAG_RTINHERIT ) && + (flags &XFS_DIFLAG_EXTSZINHERIT ) && + value % sc->mp->m_sb.sb_rextsize >0 ) +xchk_ino_set_warning (sc, ino); }/*
Quoted 35 lines · Darrick J. Wong
From: Darrick J. Wong <[email protected]>
If we encounter a directory that has been configured to pass on an extent size hint to a new realtime file and the hint isn't an integer multiple of the rt extent size, we should flag the hint for administrative review because that is a misconfiguration (that other parts of the kernel will fix automatically).
Signed-off-by Darrick J. Wong <[email protected]>--- fs/xfs/scrub/inode.c | 18 ++++++++++++++++-- 1 file changed, 16 insertions(+), 2 deletions(-)fs/xfs/scrub/inode.c +9
-2@@ -73,11 +73,25 @@ xchk_inode_extsize( uint16_t flags) {xfs_failaddr_t fa; +uint32_t value =be32_to_cpu (dip->di_extsize); - fa =xfs_inode_validate_extsize (sc->mp,be32_to_cpu (dip->di_extsize), - mode, flags); + fa =xfs_inode_validate_extsize (sc->mp, value, mode, flags);if (fa)xchk_ino_set_corrupt (sc, ino); + +/* +* XFS allows a sysadmin to change the rt extent size when adding a rt +* section to a filesystem after formatting. If there are any +* directories with extszinherit and rtinherit set, the hint could +* become misaligned with the new rextsize. The verifier doesn't check +* this, because we allow rtinherit directories even without an rt
fs/xfs/scrub/inode.c xchk_inode_extsize( · line 97
Quoted 10 lines
fs/xfs/scrub/inode.c +7
-0+* device. Flag this as an administrative warning since we will clean +* this up eventually. +*/ +if ((flags &XFS_DIFLAG_RTINHERIT ) && + (flags &XFS_DIFLAG_EXTSZINHERIT ) && + value % sc->mp->m_sb.sb_rextsize >0 ) +xchk_ino_set_warning (sc, ino); }/*
Looks good. A warning seems appropriate for scrub in this corner case...
Cheers,
Dave.
Signature · 2 lines
Dave Chinner [email protected]
Dave Chinner
Reviewed-byQuoted 45 lines · Dave Chinner
Quoted 44 lines · Darrick J. Wong
From: Darrick J. Wong <[email protected]>
If we encounter a directory that has been configured to pass on an extent size hint to a new realtime file and the hint isn't an integer multiple of the rt extent size, we should flag the hint for administrative review because that is a misconfiguration (that other parts of the kernel will fix automatically).
Signed-off-by Darrick J. Wong <[email protected]>--- fs/xfs/scrub/inode.c | 18 ++++++++++++++++-- 1 file changed, 16 insertions(+), 2 deletions(-)fs/xfs/scrub/inode.c +16
-2@@ -73,11 +73,25 @@ xchk_inode_extsize( uint16_t flags) {xfs_failaddr_t fa; +uint32_t value =be32_to_cpu (dip->di_extsize); - fa =xfs_inode_validate_extsize (sc->mp,be32_to_cpu (dip->di_extsize), - mode, flags); + fa =xfs_inode_validate_extsize (sc->mp, value, mode, flags);if (fa)xchk_ino_set_corrupt (sc, ino); + +/* +* XFS allows a sysadmin to change the rt extent size when adding a rt +* section to a filesystem after formatting. If there are any +* directories with extszinherit and rtinherit set, the hint could +* become misaligned with the new rextsize. The verifier doesn't check +* this, because we allow rtinherit directories even without an rt +* device. Flag this as an administrative warning since we will clean +* this up eventually. +*/ +if ((flags &XFS_DIFLAG_RTINHERIT ) && + (flags &XFS_DIFLAG_EXTSZINHERIT ) && + value % sc->mp->m_sb.sb_rextsize >0 ) +xchk_ino_set_warning (sc, ino); }
Quoted 4 lines
fs/xfs/scrub/inode.c xchk_inode_extsize( · line 97
Quoted 1 line
fs/xfs/scrub/inode.c +0
-0/* Looks good. A warning seems appropriate for scrub in this corner case...
so...
Signature · 2 lines
Dave Chinner [email protected]
Quoted 46 lines · Dave Chinner
Quoted 45 lines · Dave Chinner
Quoted 44 lines · Darrick J. Wong
From: Darrick J. Wong <[email protected]>
If we encounter a directory that has been configured to pass on an extent size hint to a new realtime file and the hint isn't an integer multiple of the rt extent size, we should flag the hint for administrative review because that is a misconfiguration (that other parts of the kernel will fix automatically).
Signed-off-by Darrick J. Wong <[email protected]>--- fs/xfs/scrub/inode.c | 18 ++++++++++++++++-- 1 file changed, 16 insertions(+), 2 deletions(-)fs/xfs/scrub/inode.c +16
-2@@ -73,11 +73,25 @@ xchk_inode_extsize( uint16_t flags) {xfs_failaddr_t fa; +uint32_t value =be32_to_cpu (dip->di_extsize); - fa =xfs_inode_validate_extsize (sc->mp,be32_to_cpu (dip->di_extsize), - mode, flags); + fa =xfs_inode_validate_extsize (sc->mp, value, mode, flags);if (fa)xchk_ino_set_corrupt (sc, ino); + +/* +* XFS allows a sysadmin to change the rt extent size when adding a rt +* section to a filesystem after formatting. If there are any +* directories with extszinherit and rtinherit set, the hint could +* become misaligned with the new rextsize. The verifier doesn't check +* this, because we allow rtinherit directories even without an rt +* device. Flag this as an administrative warning since we will clean +* this up eventually. +*/ +if ((flags &XFS_DIFLAG_RTINHERIT ) && + (flags &XFS_DIFLAG_EXTSZINHERIT ) && + value % sc->mp->m_sb.sb_rextsize >0 ) +xchk_ino_set_warning (sc, ino); }
Quoted 8 lines
Quoted 4 lines
fs/xfs/scrub/inode.c xchk_inode_extsize( · line 97
Quoted 1 line
fs/xfs/scrub/inode.c +0
-0/* Looks good. A warning seems appropriate for scrub in this corner case...
so...
Reviewed-by Dave Chinner <[email protected]>
Cool, thanks for the review!
--D
Quoted 4 lines
Signature · 3 lines
-- Dave Chinner [email protected]
Quoted 7 lines · Darrick J. Wong
From: Darrick J. Wong <[email protected]>
If we encounter a directory that has been configured to pass on an extent size hint to a new realtime file and the hint isn't an integer multiple of the rt extent size, we should flag the hint for administrative review because that is a misconfiguration (that other parts of the kernel will fix automatically).
Looks good,