fs:xfs: cleanup __FUNCTION__ usage
PATCH 1/1 fs:xfs: cleanup __FUNCTION__ usage
__FUNCTION__ exists only for backwards compatibility reasons with old gcc versions. Replace it with __func__.
Signed-off-by Dwaipayan Ray <[email protected]>
--- fs/xfs/xfs_icreate_item.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
fs/xfs/xfs_icreate_item.c +2 -2
@@ -201,7 +201,7 @@ xlog_recover_icreate_commit_pass2(if (length != igeo->ialloc_blks && length != igeo->ialloc_min_blks) {xfs_warn (log->l_mp, -"%s: unsupported chunk length" , __FUNCTION__); +"%s: unsupported chunk length" , __func__);return -EINVAL ; }
@@ -209,7 +209,7 @@ xlog_recover_icreate_commit_pass2(if ((count >> mp->m_sb.sb_inopblog) != length) {xfs_warn (log->l_mp,"%s: inconsistent inode count and chunk length" , - __FUNCTION__); + __func__);return -EINVAL ; }
Signature · 1 line
2.28.0
Quoted 22 lines · Dwaipayan Ray
__FUNCTION__exists only for backwards compatibility reasons with old gcc versions. Replace it with__func__.Signed-off-by Dwaipayan Ray <[email protected]>--- fs/xfs/xfs_icreate_item.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)fs/xfs/xfs_icreate_item.c +1
-1@@ -201,7 +201,7 @@ xlog_recover_icreate_commit_pass2(if (length != igeo->ialloc_blks && length != igeo->ialloc_min_blks) {xfs_warn (log->l_mp, -"%s: unsupported chunk length" , __FUNCTION__); +"%s: unsupported chunk length" , __func__);return -EINVAL ; }
fs/xfs/xfs_icreate_item.c xlog_recover_icreate_commit_pass2( · line 214
Quoted 7 lines
fs/xfs/xfs_icreate_item.c +1
-1@@ -209,7 +209,7 @@ xlog_recover_icreate_commit_pass2(if ((count >> mp->m_sb.sb_inopblog) != length) {xfs_warn (log->l_mp,"%s: inconsistent inode count and chunk length" , - __FUNCTION__); + __func__);return -EINVAL ; }
Looks good.
Reviewed-by Dave Chinner <[email protected]>
For future reference, the subject only needs "xfs:", you can drop the "fs:" prefix from it.
-Dave.
Signature · 2 lines
Dave Chinner [email protected]
Quoted 4 lines · Dwaipayan Ray
__FUNCTION__exists only for backwards compatibility reasons with old gcc versions. Replace it with__func__.Signed-off-by Dwaipayan Ray <[email protected]>
LGTM
Reviewed-by Darrick J. Wong <[email protected]>
--D
Quoted 29 lines
--- fs/xfs/xfs_icreate_item.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)fs/xfs/xfs_icreate_item.c +2
-2@@ -201,7 +201,7 @@ xlog_recover_icreate_commit_pass2(if (length != igeo->ialloc_blks && length != igeo->ialloc_min_blks) {xfs_warn (log->l_mp, -"%s: unsupported chunk length" , __FUNCTION__); +"%s: unsupported chunk length" , __func__);return -EINVAL ; }@@ -209,7 +209,7 @@ xlog_recover_icreate_commit_pass2(if ((count >> mp->m_sb.sb_inopblog) != length) {xfs_warn (log->l_mp,"%s: inconsistent inode count and chunk length" , - __FUNCTION__); + __func__);return -EINVAL ; }Signature · 1 line
2.28.0