Skip to contentSkip to conversation

arm:mmap: fix physical address overflow when CONFIG_ARM_LPAE=y

PATCH New Liang Wang 1 participant 1 message Jul 15, 2021 Library code

lore
Share & tools
lore

Liang Wang

author
#0 lore raw

PATCH 1/1 arm:mmap: fix physical address overflow when CONFIG_ARM_LPAE=y

When the CONFIG_ARM_LPAE is enabled on arm32, the physical address may exceed 32 bits. In the devmem_is_allowed function, the physical address is obtained through displacement of the physical page number.Without explicit translation, the physical address may overflow and be truncated. Use the PFN_PHYS macro to fix this bug.

This bug was initially introduced in v2.6.37 with commit:087aaffcdf9c91. In v5.10, this code has been modified by commit:527701eda5f196.

Fixes 527701eda5f196 ("lib: Add a generic version of devmem_is_allowed")
Fixes 087aaffcdf9c91 ("ARM: implement CONFIG_STRICT_DEVMEM by disabling access to RAM via /dev/mem")
Cc [email protected] # v2.6.37
---
 lib/devmem_is_allowed.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
lib/devmem_is_allowed.c +1 -1
index c0d67c541849..60be9e24bd57 100644
@@ -19,7 +19,7 @@
  */
 int devmem_is_allowed(unsigned long pfn)
 {
-	if (iomem_is_exclusive(pfn << PAGE_SHIFT))
+	if (iomem_is_exclusive(PFN_PHYS(pfn)))
 		return 0;
 	if (!page_is_ram(pfn))
 		return 1;
Signature · 1 line
2.32.0