Skip to contentSkip to conversation

arm64: dts: rockchip: Disable CDN DP on Pinebook Pro

PATCH Applied [email protected] 3 participants 3 messages Jul 15, 2021 – Oct 23, 2021

Subsystems (2)
Device tree bindings Arm Rockchip
lore
Share & tools
lore

[email protected]

author
#0 lore raw

PATCH 1/1 arm64: dts: rockchip: Disable CDN DP on Pinebook Pro

From: Matthias Brugger <[email protected]>

The CDN DP needs a PHY and a extcon to work correctly. But no extcon is provided by the device-tree, which leads to an error:
cdn-dp fec00000.dp: [drm:cdn_dp_probe [rockchipdrm]] *ERROR* missing extcon or phy
cdn-dp: probe of fec00000.dp failed with error -22

Disable the CDN DP to make graphic work on the Pinebook Pro.

Reported-by Guillaume Gardet <[email protected]>
Signed-off-by Matthias Brugger <[email protected]>

---

 arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts | 4 ----
 1 file changed, 4 deletions(-)
arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts +0 -4
index 2b5f001ff4a6..9e5d07f5712e 100644
@@ -385,10 +385,6 @@ mains_charger: dc-charger {
 	};
 };
 
-&cdn_dp {
-	status = "okay";
-};
-
 &cpu_b0 {
 	cpu-supply = <&vdd_cpu_b>;
 };
Signature · 1 line
2.31.1
maintainer Applied
#1 lore raw
Quoted 6 lines · On Thu, 15 Jul 2021 18:41:01 +0200, [email protected] wrote:

The CDN DP needs a PHY and a extcon to work correctly. But no extcon is provided by the device-tree, which leads to an error:
cdn-dp fec00000.dp: [drm:cdn_dp_probe [rockchipdrm]] *ERROR* missing extcon or phy
cdn-dp: probe of fec00000.dp failed with error -22

Disable the CDN DP to make graphic work on the Pinebook Pro.

Applied, thanks!

[1/1] arm64: dts: rockchip: Disable CDN DP on Pinebook Pro

      commit: 714b35da2b6eace13bfe23ae02330e3b6a2ea4e7

Best regards,

Signature · 1 line
Heiko Stuebner <[email protected]>
#2 lore raw
Quoted 6 lines · Heiko Stuebner
Quoted 5 lines · On Thu, 15 Jul 2021 18:41:01 +0200, [email protected] wrote:

The CDN DP needs a PHY and a extcon to work correctly. But no extcon is provided by the device-tree, which leads to an error:
cdn-dp fec00000.dp: [drm:cdn_dp_probe [rockchipdrm]] *ERROR* missing extcon or phy
cdn-dp: probe of fec00000.dp failed with error -22

Quoted 10 lines
Quoted 1 line

Disable the CDN DP to make graphic work on the Pinebook Pro.

Applied, thanks!

[1/1] arm64: dts: rockchip: Disable CDN DP on Pinebook Pro

      commit: 714b35da2b6eace13bfe23ae02330e3b6a2ea4e7

Best regards,

Signature · 1 line
Heiko Stuebner <[email protected]>

Will this patch be submitted to mainline? I can confirm on my pinebook pro that this solves the issue.