misc vgaarb cleanups
Subsystems (8)
Hi all,
this series cleans up a bunch of lose ends in the vgaarb code.
Diffstat:
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 11 +- drivers/gpu/drm/drm_irq.c | 4 drivers/gpu/drm/i915/display/intel_vga.c | 9 +- drivers/gpu/drm/nouveau/nouveau_vga.c | 8 - drivers/gpu/drm/radeon/radeon_device.c | 11 +- drivers/gpu/vga/vgaarb.c | 67 +++++----------- drivers/vfio/pci/vfio_pci.c | 11 +- include/linux/vgaarb.h | 118 ++++++++++------------------- 8 files changed, 93 insertions(+), 146 deletions(-)
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 1/7 vgaarb: remove VGA_DEFAULT_DEVICE
The define is entirely unused.
--- include/linux/vgaarb.h | 6 ------ 1 file changed, 6 deletions(-)
include/linux/vgaarb.h +0 -6
@@ -42,12 +42,6 @@#define VGA_RSRC_NORMAL_IO 0x04#define VGA_RSRC_NORMAL_MEM 0x08 -/* Passing that instead of a pci_dev to use the system "default" -* device, that is the one used by vgacon. Archs will probably -* have to provide their own vga_default_device(); -*/ -#define VGA_DEFAULT_DEVICE (NULL) -struct pci_dev ;/* For use by clients */
Signature · 6 lines
2.30.2 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Christian König
maintainerRe: [PATCH 1/7] vgaarb: remove VGA_DEFAULT_DEVICE
Am 16.07.21 um 08:16 schrieb Christoph Hellwig:
Quoted 3 lines
The define is entirely unused.
Signed-off-by Christoph Hellwig <[email protected]>
I'm not an expert for this particular code, but at least of hand everything you do here makes totally sense.
Whole series is Acked-by: Christian König <[email protected]>
Regards,
Christian.
Quoted 11 lines
--- include/linux/vgaarb.h | 6 ------ 1 file changed, 6 deletions(-)include/linux/vgaarb.h +0
-0@@ -42,12 +42,6 @@#define VGA_RSRC_NORMAL_IO 0x04#define VGA_RSRC_NORMAL_MEM 0x08
include/linux/vgaarb.h line 47
Quoted 10 lines
include/linux/vgaarb.h +0
-6-/* Passing that instead of a pci_dev to use the system "default" -* device, that is the one used by vgacon. Archs will probably -* have to provide their own vga_default_device(); -*/ -#define VGA_DEFAULT_DEVICE (NULL) -struct pci_dev ;/* For use by clients */
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Re: [PATCH 1/7] vgaarb: remove VGA_DEFAULT_DEVICE
Quoted 9 lines · Christian König
Am 16.07.21 um 08:16 schrieb Christoph Hellwig:
Quoted 3 lines
The define is entirely unused.
Signed-off-by Christoph Hellwig <[email protected]>I'm not an expert for this particular code, but at least of hand everything you do here makes totally sense.
Whole series is Acked-by: Christian König <[email protected]>
Care to also push this into drm-misc-next since you looked already? -Daniel
Quoted 24 lines
Regards,
Christian.Quoted 19 lines
--- include/linux/vgaarb.h | 6 ------ 1 file changed, 6 deletions(-)include/linux/vgaarb.h +0
-6@@ -42,12 +42,6 @@#define VGA_RSRC_NORMAL_IO 0x04#define VGA_RSRC_NORMAL_MEM 0x08 -/* Passing that instead of a pci_dev to use the system "default" -* device, that is the one used by vgacon. Archs will probably -* have to provide their own vga_default_device(); -*/ -#define VGA_DEFAULT_DEVICE (NULL) -struct pci_dev ;/* For use by clients */
Signature · 7 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Christian König
maintainerRe: [PATCH 1/7] vgaarb: remove VGA_DEFAULT_DEVICE
Am 20.07.21 um 15:50 schrieb Daniel Vetter:
Quoted 10 lines · Christian König
Quoted 8 lines
Am 16.07.21 um 08:16 schrieb Christoph Hellwig:
Quoted 3 lines
The define is entirely unused.
Signed-off-by Christoph Hellwig <[email protected]>I'm not an expert for this particular code, but at least of hand everything you do here makes totally sense.
Whole series is Acked-by: Christian König <[email protected]>
Care to also push this into drm-misc-next since you looked already?
Sure, but Christoph doesn't has push access himself?
Christian.
Quoted 9 lines
-Daniel
Quoted 7 lines
Regards,
Christian.Quoted 4 lines
--- include/linux/vgaarb.h | 6 ------ 1 file changed, 6 deletions(-)
Quoted 15 lines
Quoted 7 lines
Quoted 7 lines
include/linux/vgaarb.h +0
-0@@ -42,12 +42,6 @@#define VGA_RSRC_NORMAL_IO 0x04#define VGA_RSRC_NORMAL_MEM 0x08Quoted 8 lines
include/linux/vgaarb.h line 47
Quoted 8 lines
include/linux/vgaarb.h +0
-6-/* Passing that instead of a pci_dev to use the system "default" -* device, that is the one used by vgacon. Archs will probably -* have to provide their own vga_default_device(); -*/ -#define VGA_DEFAULT_DEVICE (NULL) -struct pci_dev ;/* For use by clients */
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Re: [PATCH 1/7] vgaarb: remove VGA_DEFAULT_DEVICE
In reply to Daniel VetterAm 20.07.21 um 15:50 schrieb Daniel Vetter:
Quoted 10 lines · Christian König
Quoted 8 lines
Am 16.07.21 um 08:16 schrieb Christoph Hellwig:
Quoted 3 lines
The define is entirely unused.
Signed-off-by Christoph Hellwig <[email protected]>I'm not an expert for this particular code, but at least of hand everything you do here makes totally sense.
Whole series is Acked-by: Christian König <[email protected]>
Care to also push this into drm-misc-next since you looked already?
Done.
Christian.
Quoted 24 lines
-Daniel
Quoted 22 lines
Regards,
Christian.Quoted 19 lines
--- include/linux/vgaarb.h | 6 ------ 1 file changed, 6 deletions(-)include/linux/vgaarb.h +0
-6@@ -42,12 +42,6 @@#define VGA_RSRC_NORMAL_IO 0x04#define VGA_RSRC_NORMAL_MEM 0x08 -/* Passing that instead of a pci_dev to use the system "default" -* device, that is the one used by vgacon. Archs will probably -* have to provide their own vga_default_device(); -*/ -#define VGA_DEFAULT_DEVICE (NULL) -struct pci_dev ;/* For use by clients */
PATCH 2/7 vgaarb: remove vga_conflicts
In reply to Christoph Hellwigvga_conflicts only has a single caller and none of the arch overrides mentioned in the comment. Just remove it and the thus dead check in the caller.
--- drivers/gpu/vga/vgaarb.c | 6 ------ include/linux/vgaarb.h | 12 ------------ 2 files changed, 18 deletions(-)
drivers/gpu/vga/vgaarb.c +0 -6
@@ -284,12 +284,6 @@ static struct vga_device *__vga_tryget(struct vga_device *vgadev,if (vgadev == conflict)continue ; -/* Check if the architecture allows a conflict between those -* 2 devices or if they are on separate domains -*/ -if (!vga_conflicts (vgadev->pdev, conflict->pdev)) -continue ; -/* We have a possible conflict. before we go further, we must * check if we sit on the same bus as the conflicting device. * if we don't, then we must tie both IO and MEM resources
include/linux/vgaarb.h +0 -12
@@ -122,18 +122,6 @@ static inline void vga_set_default_device(struct pci_dev *pdev) { }static inline int vga_remove_vgacon (struct pci_dev *pdev) {return 0 ; }#endif -/* -* Architectures should define this if they have several -* independent PCI domains that can afford concurrent VGA -* decoding -*/ -#ifndef __ARCH_HAS_VGA_CONFLICT -static inline int vga_conflicts (struct pci_dev *p1,struct pci_dev *p2) -{ -return 1 ; -} -#endif -#if defined(CONFIG_VGA_ARB ) int vga_client_register(struct pci_dev *pdev, void *cookie, void (*irq_set_state)(void *cookie, bool state),
Signature · 6 lines
2.30.2 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 3/7 vgaarb: move the kerneldoc for vga_set_legacy_decoding to vgaarb.c
In reply to Christoph HellwigKerneldoc comments should be at the implementation side, not in the header just declaring the prototype.
--- drivers/gpu/vga/vgaarb.c | 11 +++++++++++ include/linux/vgaarb.h | 13 ------------- 2 files changed, 11 insertions(+), 13 deletions(-)
drivers/gpu/vga/vgaarb.c +11 -0
@@ -834,6 +834,17 @@ static void __vga_set_legacy_decoding(struct pci_dev *pdev,spin_unlock_irqrestore (&vga_lock, flags); } +/** +* vga_set_legacy_decoding +* @pdev: pci device of the VGA card +* @decodes: bit mask of what legacy regions the card decodes +* +* Indicates to the arbiter if the card decodes legacy VGA IOs, legacy VGA +* Memory, both, or none. All cards default to both, the card driver (fbdev for +* example) should tell the arbiter if it has disabled legacy decoding, so the +* card can be left out of the arbitration process (and can be safe to take +* interrupts at any time. +*/ void vga_set_legacy_decoding (struct pci_dev *pdev,unsigned int decodes) {__vga_set_legacy_decoding (pdev, decodes, false);
include/linux/vgaarb.h +0 -13
@@ -46,19 +46,6 @@ struct pci_dev;/* For use by clients */ -/** -* vga_set_legacy_decoding -* -* @pdev: pci device of the VGA card -* @decodes: bit mask of what legacy regions the card decodes -* -* Indicates to the arbiter if the card decodes legacy VGA IOs, -* legacy VGA Memory, both, or none. All cards default to both, -* the card driver (fbdev for example) should tell the arbiter -* if it has disabled legacy decoding, so the card can be left -* out of the arbitration process (and can be safe to take -* interrupts at any time. -*/ #if defined(CONFIG_VGA_ARB )extern void vga_set_legacy_decoding (struct pci_dev *pdev,unsigned int decodes);
Signature · 6 lines
2.30.2 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 4/7 vgaarb: cleanup vgaarb.h
In reply to Christoph HellwigMerge the different CONFIG_VGA_ARB ifdef blocks, remove superflous externs, and regularize the stubs for !CONFIG_VGA_ARB.
--- include/linux/vgaarb.h | 90 ++++++++++++++++++++---------------------- 1 file changed, 42 insertions(+), 48 deletions(-)
include/linux/vgaarb.h +42 -48
@@ -33,6 +33,8 @@#include <video/vga.h> +struct pci_dev ; +/* Legacy VGA regions */ #define VGA_RSRC_NONE 0x00#define VGA_RSRC_LEGACY_IO 0x01
@@ -42,23 +44,47 @@#define VGA_RSRC_NORMAL_IO 0x04#define VGA_RSRC_NORMAL_MEM 0x08 -struct pci_dev ; - -/* For use by clients */ - -#if defined(CONFIG_VGA_ARB ) -extern void vga_set_legacy_decoding (struct pci_dev *pdev, -unsigned int decodes); -#else +#ifdef CONFIG_VGA_ARB +void vga_set_legacy_decoding (struct pci_dev *pdev,unsigned int decodes); +int vga_get (struct pci_dev *pdev,unsigned int rsrc,int interruptible); +void vga_put (struct pci_dev *pdev,unsigned int rsrc); +struct pci_dev *vga_default_device (void ); +void vga_set_default_device (struct pci_dev *pdev); +int vga_remove_vgacon (struct pci_dev *pdev); +int vga_client_register (struct pci_dev *pdev,void *cookie, +void (*irq_set_state)(void *cookie,bool state), +unsigned int (*set_vga_decode)(void *cookie,bool state)); +#else /* CONFIG_VGA_ARB */ static inline void vga_set_legacy_decoding (struct pci_dev *pdev, -unsigned int decodes) { }; -#endif - -#if defined(CONFIG_VGA_ARB ) -extern int vga_get (struct pci_dev *pdev,unsigned int rsrc,int interruptible); -#else -static inline int vga_get (struct pci_dev *pdev,unsigned int rsrc,int interruptible) {return 0 ; } -#endif +unsigned int decodes) +{ +}; +static inline int vga_get (struct pci_dev *pdev,unsigned int rsrc, +int interruptible) +{ +return 0 ; +} +static inline void vga_put (struct pci_dev *pdev,unsigned int rsrc) +{ +} +static inline struct pci_dev *vga_default_device (void ) +{ +return NULL ; +} +static inline void vga_set_default_device (struct pci_dev *pdev) +{ +} +static inline int vga_remove_vgacon (struct pci_dev *pdev) +{ +return 0 ; +} +static inline int vga_client_register (struct pci_dev *pdev,void *cookie, +void (*irq_set_state)(void *cookie,bool state), +unsigned int (*set_vga_decode)(void *cookie,bool state)) +{ +return 0 ; +} +#endif /* CONFIG_VGA_ARB */ /** * vga_get_interruptible
@@ -90,36 +116,4 @@ static inline int vga_get_uninterruptible(struct pci_dev *pdev, return vga_get(pdev, rsrc, 0); } -#if defined(CONFIG_VGA_ARB ) -extern void vga_put (struct pci_dev *pdev,unsigned int rsrc); -#else -static inline void vga_put (struct pci_dev *pdev,unsigned int rsrc) -{ -} -#endif - - -#ifdef CONFIG_VGA_ARB -extern struct pci_dev *vga_default_device (void ); -extern void vga_set_default_device (struct pci_dev *pdev); -extern int vga_remove_vgacon (struct pci_dev *pdev); -#else -static inline struct pci_dev *vga_default_device (void ) {return NULL ; } -static inline void vga_set_default_device (struct pci_dev *pdev) { } -static inline int vga_remove_vgacon (struct pci_dev *pdev) {return 0 ; } -#endif - -#if defined(CONFIG_VGA_ARB ) -int vga_client_register (struct pci_dev *pdev,void *cookie, -void (*irq_set_state)(void *cookie,bool state), -unsigned int (*set_vga_decode)(void *cookie,bool state)); -#else -static inline int vga_client_register (struct pci_dev *pdev,void *cookie, -void (*irq_set_state)(void *cookie,bool state), -unsigned int (*set_vga_decode)(void *cookie,bool state)) -{ -return 0 ; -} -#endif -#endif /* LINUX_VGA_H */
Signature · 6 lines
2.30.2 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 5/7 vgaarb: provide a vga_client_unregister wrapper
In reply to Christoph HellwigAdd a trivial wrapper for the unregister case that sets all fields to NULL.
--- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +- drivers/gpu/drm/drm_irq.c | 4 ++-- drivers/gpu/drm/i915/display/intel_vga.c | 2 +- drivers/gpu/drm/nouveau/nouveau_vga.c | 2 +- drivers/gpu/drm/radeon/radeon_device.c | 2 +- drivers/gpu/vga/vgaarb.c | 3 +-- drivers/vfio/pci/vfio_pci.c | 2 +- include/linux/vgaarb.h | 5 +++++ 8 files changed, 13 insertions(+), 9 deletions(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +1 -1
@@ -3838,7 +3838,7 @@ void amdgpu_device_fini_sw(struct amdgpu_device *adev)vga_switcheroo_fini_domain_pm_ops (adev->dev); }if ((adev->pdev->class >>8 ) ==PCI_CLASS_DISPLAY_VGA ) -vga_client_register (adev->pdev,NULL ,NULL ,NULL ); +vga_client_unregister (adev->pdev);if (IS_ENABLED (CONFIG_PERF_EVENTS ))amdgpu_pmu_fini (adev);
drivers/gpu/drm/drm_irq.c +2 -2
@@ -140,7 +140,7 @@ int drm_irq_install(struct drm_device *dev, int irq)if (ret <0 ) { dev->irq_enabled = false;if (drm_core_check_feature (dev,DRIVER_LEGACY )) -vga_client_register (to_pci_dev (dev->dev),NULL ,NULL ,NULL ); +vga_client_unregister (to_pci_dev (dev->dev));free_irq (irq, dev); }else { dev->irq = irq;
@@ -203,7 +203,7 @@ int drm_irq_uninstall(struct drm_device *dev)DRM_DEBUG ("irq=%d\n" , dev->irq);if (drm_core_check_feature (dev,DRIVER_LEGACY )) -vga_client_register (to_pci_dev (dev->dev),NULL ,NULL ,NULL ); +vga_client_unregister (to_pci_dev (dev->dev));if (dev->driver->irq_uninstall) dev->driver->irq_uninstall (dev);
drivers/gpu/drm/i915/display/intel_vga.c +1 -1
@@ -158,5 +158,5 @@ void intel_vga_unregister(struct drm_i915_private *i915) {struct pci_dev *pdev =to_pci_dev (i915->drm.dev); -vga_client_register (pdev,NULL ,NULL ,NULL ); +vga_client_unregister (pdev); }
drivers/gpu/drm/nouveau/nouveau_vga.c +1 -1
@@ -118,7 +118,7 @@ nouveau_vga_fini(struct nouveau_drm *drm)return ; pdev =to_pci_dev (dev->dev); -vga_client_register (pdev,NULL ,NULL ,NULL ); +vga_client_unregister (pdev);if (pci_is_thunderbolt_attached (pdev))return ;
drivers/gpu/drm/radeon/radeon_device.c +1 -1
@@ -1530,7 +1530,7 @@ void radeon_device_fini(struct radeon_device *rdev)vga_switcheroo_unregister_client (rdev->pdev);if (rdev->flags &RADEON_IS_PX )vga_switcheroo_fini_domain_pm_ops (rdev->dev); -vga_client_register (rdev->pdev,NULL ,NULL ,NULL ); +vga_client_unregister (rdev->pdev);if (rdev->rio_mem)pci_iounmap (rdev->pdev, rdev->rio_mem); rdev->rio_mem =NULL ;
drivers/gpu/vga/vgaarb.c +1 -2
@@ -877,8 +877,7 @@ EXPORT_SYMBOL(vga_set_legacy_decoding);* This function does not check whether a client for @pdev has been registered * already. * -* To unregister just call this function with @irq_set_state and @set_vga_decode -* both set to NULL for the same @pdev as originally used to register them. +* To unregister just call vga_client_unregister(). * * Returns: 0 on success, -1 on failure */
drivers/vfio/pci/vfio_pci.c +1 -1
@@ -1967,7 +1967,7 @@ static void vfio_pci_vga_uninit(struct vfio_pci_device *vdev)if (!vfio_pci_is_vga (pdev))return ; -vga_client_register (pdev,NULL ,NULL ,NULL ); +vga_client_unregister (pdev);vga_set_legacy_decoding (pdev,VGA_RSRC_NORMAL_IO |VGA_RSRC_NORMAL_MEM |VGA_RSRC_LEGACY_IO |VGA_RSRC_LEGACY_MEM );
include/linux/vgaarb.h +5 -0
@@ -116,4 +116,9 @@ static inline int vga_get_uninterruptible(struct pci_dev *pdev, return vga_get(pdev, rsrc, 0); } +static inline void vga_client_unregister (struct pci_dev *pdev) +{ +vga_client_register (pdev,NULL ,NULL ,NULL ); +} +#endif /* LINUX_VGA_H */
Signature · 6 lines
2.30.2 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 6/7 vgaarb: remove the unused irq_set_state argument to vga_client_register
In reply to Christoph HellwigAll callers pass NULL as the irq_set_state argument, so remove it and the ->irq_set_state member in struct vga_device.
--- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +- drivers/gpu/drm/i915/display/intel_vga.c | 2 +- drivers/gpu/drm/nouveau/nouveau_vga.c | 2 +- drivers/gpu/drm/radeon/radeon_device.c | 2 +- drivers/gpu/vga/vgaarb.c | 23 +--------------------- drivers/vfio/pci/vfio_pci.c | 2 +- include/linux/vgaarb.h | 4 +--- 7 files changed, 7 insertions(+), 30 deletions(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +1 -1
@@ -3715,7 +3715,7 @@ int amdgpu_device_init(struct amdgpu_device *adev,/* this will fail for cards that aren't VGA class devices, just * ignore it */ if ((adev->pdev->class >>8 ) ==PCI_CLASS_DISPLAY_VGA ) -vga_client_register (adev->pdev, adev,NULL , amdgpu_device_vga_set_decode); +vga_client_register (adev->pdev, adev, amdgpu_device_vga_set_decode);if (amdgpu_device_supports_px (ddev)) { px = true;
drivers/gpu/drm/i915/display/intel_vga.c +1 -1
@@ -147,7 +147,7 @@ int intel_vga_register(struct drm_i915_private *i915)* then we do not take part in VGA arbitration and the * vga_client_register() fails with -ENODEV. */ - ret =vga_client_register (pdev, i915,NULL , intel_vga_set_decode); + ret =vga_client_register (pdev, i915, intel_vga_set_decode);if (ret && ret != -ENODEV )return ret;
drivers/gpu/drm/nouveau/nouveau_vga.c +1 -1
@@ -94,7 +94,7 @@ nouveau_vga_init(struct nouveau_drm *drm)return ; pdev =to_pci_dev (dev->dev); -vga_client_register (pdev, dev,NULL , nouveau_vga_set_decode); +vga_client_register (pdev, dev, nouveau_vga_set_decode);/* don't register Thunderbolt eGPU with vga_switcheroo */ if (pci_is_thunderbolt_attached (pdev))
drivers/gpu/drm/radeon/radeon_device.c +1 -1
@@ -1434,7 +1434,7 @@ int radeon_device_init(struct radeon_device *rdev,/* if we have > 1 VGA cards, then disable the radeon VGA resources */ /* this will fail for cards that aren't VGA class devices, just * ignore it */ -vga_client_register (rdev->pdev, rdev,NULL , radeon_vga_set_decode); +vga_client_register (rdev->pdev, rdev, radeon_vga_set_decode);if (rdev->flags &RADEON_IS_PX ) runtime = true;
drivers/gpu/vga/vgaarb.c +1 -22
@@ -72,9 +72,7 @@ struct vga_device {unsigned int io_norm_cnt;/* normal IO count */ unsigned int mem_norm_cnt;/* normal MEM count */ bool bridge_has_one_vga; -/* allow IRQ enable/disable hook */ void *cookie; -void (*irq_set_state)(void *cookie,bool enable);unsigned int (*set_vga_decode)(void *cookie,bool decode); };
@@ -218,13 +216,6 @@ int vga_remove_vgacon(struct pci_dev *pdev)#endif EXPORT_SYMBOL (vga_remove_vgacon); -static inline void vga_irq_set_state (struct vga_device *vgadev,bool state) -{ -if (vgadev->irq_set_state) - vgadev->irq_set_state (vgadev->cookie, state); -} - -/* If we don't ever use VGA arb we should avoid turning off anything anywhere due to old X servers getting confused about the boot device not being VGA */
@@ -325,10 +316,8 @@ static struct vga_device *__vga_tryget(struct vga_device *vgadev,if ((match & conflict->decodes) &VGA_RSRC_LEGACY_IO ) pci_bits |=PCI_COMMAND_IO ; -if (pci_bits) { -vga_irq_set_state (conflict, false); +if (pci_bits) flags |=PCI_VGA_STATE_CHANGE_DECODES ; - } }if (change_bridge)
@@ -365,9 +354,6 @@ static struct vga_device *__vga_tryget(struct vga_device *vgadev,pci_set_vga_state (vgadev->pdev, true, pci_bits, flags); -if (!vgadev->bridge_has_one_vga) -vga_irq_set_state (vgadev, true); - vgadev->owns |= wants; lock_them: vgadev->locks |= (rsrc &VGA_RSRC_LEGACY_MASK );
@@ -855,15 +841,10 @@ EXPORT_SYMBOL(vga_set_legacy_decoding);* vga_client_register - register or unregister a VGA arbitration client * @pdev: pci device of the VGA client * @cookie: client cookie to be used in callbacks -* @irq_set_state: irq state change callback * @set_vga_decode: vga decode change callback * * Clients have two callback mechanisms they can use. * -* @irq_set_state callback: If a client can't disable its GPUs VGA -* resources, then we need to be able to ask it to turn off its irqs when we -* turn off its mem and io decoding. -* * @set_vga_decode callback: If a client can disable its GPU VGA resource, it * will get a callback from this to set the encode/decode state. *
@@ -882,7 +863,6 @@ EXPORT_SYMBOL(vga_set_legacy_decoding);* Returns: 0 on success, -1 on failure */ int vga_client_register (struct pci_dev *pdev,void *cookie, -void (*irq_set_state)(void *cookie,bool state),unsigned int (*set_vga_decode)(void *cookie,bool decode)) {
@@ -895,7 +875,6 @@ int vga_client_register(struct pci_dev *pdev, void *cookie,if (!vgadev) goto bail; - vgadev->irq_set_state = irq_set_state; vgadev->set_vga_decode = set_vga_decode; vgadev->cookie = cookie; ret =0 ;
drivers/vfio/pci/vfio_pci.c +1 -1
@@ -1954,7 +1954,7 @@ static int vfio_pci_vga_init(struct vfio_pci_device *vdev)if (!vfio_pci_is_vga (pdev))return 0 ; - ret =vga_client_register (pdev, vdev,NULL , vfio_pci_set_vga_decode); + ret =vga_client_register (pdev, vdev, vfio_pci_set_vga_decode);if (ret)return ret;vga_set_legacy_decoding (pdev,vfio_pci_set_vga_decode (vdev, false));
include/linux/vgaarb.h +1 -3
@@ -52,7 +52,6 @@ struct pci_dev *vga_default_device(void);void vga_set_default_device (struct pci_dev *pdev);int vga_remove_vgacon (struct pci_dev *pdev);int vga_client_register (struct pci_dev *pdev,void *cookie, -void (*irq_set_state)(void *cookie,bool state),unsigned int (*set_vga_decode)(void *cookie,bool state));#else /* CONFIG_VGA_ARB */ static inline void vga_set_legacy_decoding(struct pci_dev *pdev,
@@ -79,7 +78,6 @@ static inline int vga_remove_vgacon(struct pci_dev *pdev)return 0 ; }static inline int vga_client_register (struct pci_dev *pdev,void *cookie, -void (*irq_set_state)(void *cookie,bool state),unsigned int (*set_vga_decode)(void *cookie,bool state)) {return 0 ;
@@ -118,7 +116,7 @@ static inline int vga_get_uninterruptible(struct pci_dev *pdev,static inline void vga_client_unregister (struct pci_dev *pdev) { -vga_client_register (pdev,NULL ,NULL ,NULL ); +vga_client_register (pdev,NULL ,NULL ); }#endif /* LINUX_VGA_H */
Signature · 6 lines
2.30.2 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 7/7 vgaarb: don't pass a cookie to vga_client_register
In reply to Christoph HellwigThe VGA arbitration is entirely based on pci_dev structures, so just pass that back to the set_vga_decode callback.
--- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 9 ++++---- drivers/gpu/drm/i915/display/intel_vga.c | 7 ++++--- drivers/gpu/drm/nouveau/nouveau_vga.c | 6 +++--- drivers/gpu/drm/radeon/radeon_device.c | 9 ++++---- drivers/gpu/vga/vgaarb.c | 24 +++++++++------------- drivers/vfio/pci/vfio_pci.c | 9 ++++---- include/linux/vgaarb.h | 10 ++++----- 7 files changed, 36 insertions(+), 38 deletions(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +5 -4
@@ -1266,15 +1266,16 @@ bool amdgpu_device_need_post(struct amdgpu_device *adev)/** * amdgpu_device_vga_set_decode - enable/disable vga decode * -* @cookie: amdgpu_device pointer +* @pdev: PCI device pointer * @state: enable/disable vga decode * * Enable/disable vga decode (all asics). * Returns VGA resource flags. */ -static unsigned int amdgpu_device_vga_set_decode (void *cookie,bool state) +static unsigned int amdgpu_device_vga_set_decode (struct pci_dev *pdev, +bool state) { -struct amdgpu_device *adev = cookie; +struct amdgpu_device *adev =drm_to_adev (pci_get_drvdata (pdev));amdgpu_asic_set_vga_state (adev, state);if (state) return VGA_RSRC_LEGACY_IO | VGA_RSRC_LEGACY_MEM |
@@ -3715,7 +3716,7 @@ int amdgpu_device_init(struct amdgpu_device *adev,/* this will fail for cards that aren't VGA class devices, just * ignore it */ if ((adev->pdev->class >>8 ) ==PCI_CLASS_DISPLAY_VGA ) -vga_client_register (adev->pdev, adev, amdgpu_device_vga_set_decode); +vga_client_register (adev->pdev, amdgpu_device_vga_set_decode);if (amdgpu_device_supports_px (ddev)) { px = true;
drivers/gpu/drm/i915/display/intel_vga.c +4 -3
@@ -121,9 +121,9 @@ intel_vga_set_state(struct drm_i915_private *i915, bool enable_decode) }static unsigned int -intel_vga_set_decode (void *cookie,bool enable_decode) +intel_vga_set_decode (struct pci_dev *pdev,bool enable_decode) { -struct drm_i915_private *i915 = cookie; +struct drm_i915_private *i915 =pdev_to_i915 (pdev);intel_vga_set_state (i915, enable_decode);
@@ -136,6 +136,7 @@ intel_vga_set_decode(void *cookie, bool enable_decode)int intel_vga_register (struct drm_i915_private *i915) { +struct pci_dev *pdev =to_pci_dev (i915->drm.dev);int ret;
@@ -147,7 +148,7 @@ int intel_vga_register(struct drm_i915_private *i915)* then we do not take part in VGA arbitration and the * vga_client_register() fails with -ENODEV. */ - ret =vga_client_register (pdev, i915, intel_vga_set_decode); + ret =vga_client_register (pdev, intel_vga_set_decode);if (ret && ret != -ENODEV )return ret;
drivers/gpu/drm/nouveau/nouveau_vga.c +3 -3
@@ -11,9 +11,9 @@#include "nouveau_vga.h" static unsigned int -nouveau_vga_set_decode (void *priv,bool state) +nouveau_vga_set_decode (struct pci_dev *pdev,bool state) { -struct nouveau_drm *drm =nouveau_drm (priv); +struct nouveau_drm *drm =nouveau_drm (pci_get_drvdata (pdev));struct nvif_object *device = &drm->client.device.object; if (drm->client.device.info.family == NV_DEVICE_INFO_V0_CURIE &&
@@ -94,7 +94,7 @@ nouveau_vga_init(struct nouveau_drm *drm)return ; pdev =to_pci_dev (dev->dev); -vga_client_register (pdev, dev, nouveau_vga_set_decode); +vga_client_register (pdev, nouveau_vga_set_decode);/* don't register Thunderbolt eGPU with vga_switcheroo */ if (pci_is_thunderbolt_attached (pdev))
drivers/gpu/drm/radeon/radeon_device.c +5 -4
@@ -1067,15 +1067,16 @@ void radeon_combios_fini(struct radeon_device *rdev)/** * radeon_vga_set_decode - enable/disable vga decode * -* @cookie: radeon_device pointer +* @pdev: PCI device * @state: enable/disable vga decode * * Enable/disable vga decode (all asics). * Returns VGA resource flags. */ -static unsigned int radeon_vga_set_decode (void *cookie,bool state) +static unsigned int radeon_vga_set_decode (struct pci_dev *pdev,bool state) { -struct radeon_device *rdev = cookie; +struct drm_device *dev =pci_get_drvdata (pdev); +struct radeon_device *rdev = dev->dev_private;radeon_vga_set_state (rdev, state);if (state) return VGA_RSRC_LEGACY_IO | VGA_RSRC_LEGACY_MEM |
@@ -1434,7 +1435,7 @@ int radeon_device_init(struct radeon_device *rdev,/* if we have > 1 VGA cards, then disable the radeon VGA resources */ /* this will fail for cards that aren't VGA class devices, just * ignore it */ -vga_client_register (rdev->pdev, rdev, radeon_vga_set_decode); +vga_client_register (rdev->pdev, radeon_vga_set_decode);if (rdev->flags &RADEON_IS_PX ) runtime = true;
drivers/gpu/vga/vgaarb.c +10 -14
@@ -72,8 +72,7 @@ struct vga_device {unsigned int io_norm_cnt;/* normal IO count */ unsigned int mem_norm_cnt;/* normal MEM count */ bool bridge_has_one_vga; -void *cookie; -unsigned int (*set_vga_decode)(void *cookie,bool decode); +unsigned int (*set_decode)(struct pci_dev *pdev,bool decode); };static LIST_HEAD (vga_list);
@@ -806,7 +805,7 @@ static void __vga_set_legacy_decoding(struct pci_dev *pdev, goto bail;/* don't let userspace futz with kernel driver decodes */ -if (userspace && vgadev->set_vga_decode) +if (userspace && vgadev->set_decode) goto bail;/* update the device decodes + counter */
@@ -840,12 +839,11 @@ EXPORT_SYMBOL(vga_set_legacy_decoding);/** * vga_client_register - register or unregister a VGA arbitration client * @pdev: pci device of the VGA client -* @cookie: client cookie to be used in callbacks -* @set_vga_decode: vga decode change callback +* @set_decode: vga decode change callback * * Clients have two callback mechanisms they can use. * -* @set_vga_decode callback: If a client can disable its GPU VGA resource, it +* @set_decode callback: If a client can disable its GPU VGA resource, it * will get a callback from this to set the encode/decode state. * * Rationale: we cannot disable VGA decode resources unconditionally some single
@@ -862,9 +860,8 @@ EXPORT_SYMBOL(vga_set_legacy_decoding);* * Returns: 0 on success, -1 on failure */ -int vga_client_register (struct pci_dev *pdev,void *cookie, -unsigned int (*set_vga_decode)(void *cookie, -bool decode)) +int vga_client_register (struct pci_dev *pdev, +unsigned int (*set_decode)(struct pci_dev *pdev,bool decode)) {int ret = -ENODEV ;struct vga_device *vgadev;
@@ -875,8 +872,7 @@ int vga_client_register(struct pci_dev *pdev, void *cookie,if (!vgadev) goto bail; - vgadev->set_vga_decode = set_vga_decode; - vgadev->cookie = cookie; + vgadev->set_decode = set_decode; ret =0 ; bail:
@@ -1386,9 +1382,9 @@ static void vga_arbiter_notify_clients(void) new_state = false; else new_state = true; -if (vgadev->set_vga_decode) { - new_decodes = vgadev->set_vga_decode (vgadev->cookie, - new_state); +if (vgadev->set_decode) { + new_decodes = vgadev->set_decode (vgadev->pdev, + new_state);vga_update_device_decodes (vgadev, new_decodes); } }
drivers/vfio/pci/vfio_pci.c +4 -5
@@ -119,10 +119,9 @@ static bool vfio_pci_is_denylisted(struct pci_dev *pdev)* has no way to get to it and routing can be disabled externally at the * bridge. */ -static unsigned int vfio_pci_set_vga_decode (void *opaque,bool single_vga) +static unsigned int vfio_pci_set_decode (struct pci_dev *pdev,bool single_vga) { -struct vfio_pci_device *vdev = opaque; -struct pci_dev *tmp =NULL , *pdev = vdev->pdev; +struct pci_dev *tmp =NULL ;unsigned char max_busnr;unsigned int decodes;
@@ -1954,10 +1953,10 @@ static int vfio_pci_vga_init(struct vfio_pci_device *vdev)if (!vfio_pci_is_vga (pdev))return 0 ; - ret =vga_client_register (pdev, vdev, vfio_pci_set_vga_decode); + ret =vga_client_register (pdev, vfio_pci_set_decode);if (ret)return ret; -vga_set_legacy_decoding (pdev,vfio_pci_set_vga_decode (vdev, false)); +vga_set_legacy_decoding (pdev,vfio_pci_set_decode (pdev, false));return 0 ; }
include/linux/vgaarb.h +5 -5
@@ -51,8 +51,8 @@ void vga_put(struct pci_dev *pdev, unsigned int rsrc);struct pci_dev *vga_default_device (void );void vga_set_default_device (struct pci_dev *pdev);int vga_remove_vgacon (struct pci_dev *pdev); -int vga_client_register (struct pci_dev *pdev,void *cookie, -unsigned int (*set_vga_decode)(void *cookie,bool state)); +int vga_client_register (struct pci_dev *pdev, +unsigned int (*set_decode)(struct pci_dev *pdev,bool state));#else /* CONFIG_VGA_ARB */ static inline void vga_set_legacy_decoding (struct pci_dev *pdev,unsigned int decodes)
@@ -77,8 +77,8 @@ static inline int vga_remove_vgacon(struct pci_dev *pdev) {return 0 ; } -static inline int vga_client_register (struct pci_dev *pdev,void *cookie, -unsigned int (*set_vga_decode)(void *cookie,bool state)) +static inline int vga_client_register (struct pci_dev *pdev, +unsigned int (*set_decode)(struct pci_dev *pdev,bool state)) {return 0 ; }
@@ -116,7 +116,7 @@ static inline int vga_get_uninterruptible(struct pci_dev *pdev,static inline void vga_client_unregister (struct pci_dev *pdev) { -vga_client_register (pdev,NULL ,NULL ); +vga_client_register (pdev,NULL ); }#endif /* LINUX_VGA_H */
Signature · 6 lines
2.30.2 _______________________________________________ Nouveau mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/nouveau
Quoted 8 lines · Christoph Hellwig
Hi all,
this series cleans up a bunch of lose ends in the vgaarb code.
Diffstat:
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 11 +- drivers/gpu/drm/drm_irq.c | 4 drivers/gpu/drm/i915/display/intel_vga.c | 9 +-
The parts touching i915 looks clean to me
Quoted 6 lines
drivers/gpu/drm/nouveau/nouveau_vga.c | 8 - drivers/gpu/drm/radeon/radeon_device.c | 11 +- drivers/gpu/vga/vgaarb.c | 67 +++++----------- drivers/vfio/pci/vfio_pci.c | 11 +- include/linux/vgaarb.h | 118 ++++++++++------------------- 8 files changed, 93 insertions(+), 146 deletions(-)
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Patchwork
CI[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/7] vgaarb: remove VGA_DEFAULT_DEVICE
In reply to Christoph Hellwig== Series Details ==
== Series Details ==
Series: series starting with [1/7] vgaarb: remove VGA_DEFAULT_DEVICE
URL : https://patchwork.freedesktop.org/series/92632/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
1354bf88b4ee vgaarb: remove VGA_DEFAULT_DEVICE
ddb8e5b71998 vgaarb: remove vga_conflicts
769ccfba8a01 vgaarb: move the kerneldoc for vga_set_legacy_decoding to vgaarb.c
b76ffe6766cb vgaarb: cleanup vgaarb.h
-:6: WARNING:TYPO_SPELLING: 'superflous' may be misspelled - perhaps 'superfluous'?
#6:
Merge the different CONFIG_VGA_ARB ifdef blocks, remove superflous
^^^^^^^^^^-:59: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations #59: FILE: include/linux/vgaarb.h:62:
+};
+static inline int vga_get(struct pci_dev *pdev, unsigned int rsrc,
-:60: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #60: FILE: include/linux/vgaarb.h:63:
+static inline int vga_get(struct pci_dev *pdev, unsigned int rsrc,
+ int interruptible)
-:64: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations #64: FILE: include/linux/vgaarb.h:67:
+}
+static inline void vga_put(struct pci_dev *pdev, unsigned int rsrc)
-:67: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations #67: FILE: include/linux/vgaarb.h:70:
+}
+static inline struct pci_dev *vga_default_device(void)
-:71: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations #71: FILE: include/linux/vgaarb.h:74:
+}
+static inline void vga_set_default_device(struct pci_dev *pdev)
-:74: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations #74: FILE: include/linux/vgaarb.h:77:
+}
+static inline int vga_remove_vgacon(struct pci_dev *pdev)
-:78: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations #78: FILE: include/linux/vgaarb.h:81:
+}
+static inline int vga_client_register(struct pci_dev *pdev, void *cookie,
total: 0 errors, 1 warnings, 7 checks, 107 lines checked6a95053499ae vgaarb: provide a vga_client_unregister wrapper 261e516ffd06 vgaarb: remove the unused irq_set_state argument to vga_client_register c464965b3922 vgaarb: don't pass a cookie to vga_client_register
-:28: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #28: FILE: drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:1276:
+static unsigned int amdgpu_device_vga_set_decode(struct pci_dev *pdev,
+ bool state)
-:64: CHECK:BRACES: Blank lines aren't necessary after an open brace '{' #64: FILE: drivers/gpu/drm/i915/display/intel_vga.c:142:
{
+
-:181: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #181: FILE: drivers/gpu/vga/vgaarb.c:864:
+int vga_client_register(struct pci_dev *pdev,
+ unsigned int (*set_decode)(struct pci_dev *pdev, bool decode))
-:249: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #249: FILE: include/linux/vgaarb.h:55:
+int vga_client_register(struct pci_dev *pdev,
+ unsigned int (*set_decode)(struct pci_dev *pdev, bool state));
-:259: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations #259: FILE: include/linux/vgaarb.h:80:
}
+static inline int vga_client_register(struct pci_dev *pdev,
-:260: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #260: FILE: include/linux/vgaarb.h:81:
+static inline int vga_client_register(struct pci_dev *pdev,
+ unsigned int (*set_decode)(struct pci_dev *pdev, bool state))
total: 0 errors, 0 warnings, 6 checks, 214 lines checked
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI[Intel-gfx] ✗ Fi.CI.DOCS: warning for series starting with [1/7] vgaarb: remove VGA_DEFAULT_DEVICE
In reply to Christoph Hellwig== Series Details ==
== Series Details ==
Series: series starting with [1/7] vgaarb: remove VGA_DEFAULT_DEVICE
URL : https://patchwork.freedesktop.org/series/92632/
State : warning
== Summary ==
$ make htmldocs 2>&1 > /dev/null | grep i915 ./drivers/gpu/drm/i915/i915_cmd_parser.c:1436: warning: Excess function parameter 'jump_whitelist' description in 'intel_engine_cmd_parser' ./drivers/gpu/drm/i915/i915_cmd_parser.c:1436: warning: Excess function parameter 'shadow_map' description in 'intel_engine_cmd_parser' ./drivers/gpu/drm/i915/i915_cmd_parser.c:1436: warning: Excess function parameter 'batch_map' description in 'intel_engine_cmd_parser' ./drivers/gpu/drm/i915/i915_cmd_parser.c:1436: warning: Function parameter or member 'trampoline' not described in 'intel_engine_cmd_parser' ./drivers/gpu/drm/i915/i915_cmd_parser.c:1436: warning: Excess function parameter 'jump_whitelist' description in 'intel_engine_cmd_parser' ./drivers/gpu/drm/i915/i915_cmd_parser.c:1436: warning: Excess function parameter 'shadow_map' description in 'intel_engine_cmd_parser' ./drivers/gpu/drm/i915/i915_cmd_parser.c:1436: warning: Excess function parameter 'batch_map' description in 'intel_engine_cmd_parser'
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/7] vgaarb: remove VGA_DEFAULT_DEVICE
In reply to Christoph Hellwig== Series Details ==
== Series Details ==
Series: series starting with [1/7] vgaarb: remove VGA_DEFAULT_DEVICE
URL : https://patchwork.freedesktop.org/series/92632/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10346 -> Patchwork_20633
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20633/index.html
Known issues
------------
Here are the changes found in Patchwork_20633 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@amdgpu/amd_basic@semaphore:
- fi-bdw-5557u: NOTRUN -> [SKIP][1] ([fdo#109271]) +27 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20633/fi-bdw-5557u/igt@amdgpu/[email protected]
* igt@core_hotunplug@unbind-rebind:
- fi-bdw-5557u: NOTRUN -> [WARN][2] ([i915#3718])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20633/fi-bdw-5557u/igt@[email protected]
* igt@kms_chamelium@dp-crc-fast:
- fi-bdw-5557u: NOTRUN -> [SKIP][3] ([fdo#109271] / [fdo#111827]) +8 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20633/fi-bdw-5557u/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#3303]: https://gitlab.freedesktop.org/drm/intel/issues/3303
[i915#3718]: https://gitlab.freedesktop.org/drm/intel/issues/3718
Participating hosts (41 -> 35)
------------------------------
Missing (6): fi-ilk-m540 fi-hsw-4200u fi-bsw-cyan fi-bdw-samus fi-tgl-y bat-jsl-1
Build changes
-------------
* Linux: CI_DRM_10346 -> Patchwork_20633
CI-20190529: 20190529
CI_DRM_10346: 6c4e3c031a995e641cc0d9563d21043415fb8d12 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6144: bc65ee9ee6593716306448c9fb82c77f284f2148 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_20633: c464965b39228f1229073ff63484f7bdf9667ca7 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
c464965b3922 vgaarb: don't pass a cookie to vga_client_register 261e516ffd06 vgaarb: remove the unused irq_set_state argument to vga_client_register 6a95053499ae vgaarb: provide a vga_client_unregister wrapper b76ffe6766cb vgaarb: cleanup vgaarb.h769ccfba8a01 vgaarb: move the kerneldoc for vga_set_legacy_decoding to vgaarb.c ddb8e5b71998 vgaarb: remove vga_conflicts1354bf88b4ee vgaarb: remove VGA_DEFAULT_DEVICE
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20633/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/7] vgaarb: remove VGA_DEFAULT_DEVICE
In reply to Christoph Hellwig== Series Details ==
== Series Details ==
Series: series starting with [1/7] vgaarb: remove VGA_DEFAULT_DEVICE
URL : https://patchwork.freedesktop.org/series/92632/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_10346_full -> Patchwork_20633_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_20633_full absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in Patchwork_20633_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_20633_full:
### IGT changes ###
#### Possible regressions ####
* igt@gen9_exec_parse@bb-start-far:
- shard-iclb: NOTRUN -> [SKIP][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20633/shard-iclb2/igt@[email protected]
Known issues
------------
Here are the changes found in Patchwork_20633_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_persistence@legacy-engines-mixed:
- shard-snb: NOTRUN -> [SKIP][2] ([fdo#109271] / [i915#1099]) +2 similar issues
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20633/shard-snb6/igt@[email protected]
* igt@gem_exec_fair@basic-flow@rcs0:
- shard-tglb: [PASS][3] -> [FAIL][4] ([i915#2842]) +2 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10346/shard-tglb2/igt@gem_exec_fair@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20633/shard-tglb7/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-none@vcs0:
- shard-tglb: NOTRUN -> [FAIL][5] ([i915#2842]) +4 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20633/shard-tglb3/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-glk: [PASS][6] -> [FAIL][7] ([i915#2842])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10346/shard-glk4/igt@gem_exec_fair@[email protected]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20633/shard-glk3/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-pace@vcs0:
- shard-kbl: [PASS][8] -> [FAIL][9] ([i915#2842])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10346/shard-kbl4/igt@gem_exec_fair@[email protected]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20633/shard-kbl3/igt@gem_exec_fair@[email protected]
* igt@gem_pwrite@basic-exhaustion:
- shard-kbl: NOTRUN -> [WARN][10] ([i915#2658])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20633/shard-kbl6/igt@[email protected]
* igt@gem_render_copy@y-tiled-mc-ccs-to-yf-tiled-ccs:
- shard-iclb: NOTRUN -> [SKIP][11] ([i915#768])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20633/shard-iclb2/igt@[email protected]
* igt@gem_softpin@noreloc-s3:
- shard-apl: NOTRUN -> [DMESG-WARN][12] ([i915#180]) +1 similar issue
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20633/shard-apl2/igt@[email protected]
* igt@gen7_exec_parse@chained-batch:
- shard-iclb: NOTRUN -> [SKIP][13] ([fdo#109289]) +1 similar issue
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20633/shard-iclb2/igt@[email protected]
* igt@i915_pm_lpsp@kms-lpsp:
- shard-skl: NOTRUN -> [SKIP][14] ([fdo#109271]) +112 similar issues
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20633/shard-skl7/igt@[email protected]
* igt@i915_pm_rpm@modeset-non-lpsp-stress:
- shard-iclb: NOTRUN -> [SKIP][15] ([fdo#110892])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20633/shard-iclb2/igt@[email protected]
* igt@i915_suspend@forcewake:
- shard-apl: [PASS][16] -> [DMESG-WARN][17] ([i915#180])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10346/shard-apl7/igt@[email protected]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20633/shard-apl1/igt@[email protected]
* igt@kms_async_flips@alternate-sync-async-flip:
- shard-skl: [PASS][18] -> [FAIL][19] ([i915#2521])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10346/shard-skl2/igt@[email protected]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20633/shard-skl10/igt@[email protected]
* igt@kms_big_fb@x-tiled-32bpp-rotate-0:
- shard-glk: [PASS][20] -> [DMESG-WARN][21] ([i915#118] / [i915#95])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10346/shard-glk4/igt@[email protected]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20633/shard-glk3/igt@[email protected]
* igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-0-async-flip:
- shard-skl: NOTRUN -> [FAIL][22] ([i915#3722])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20633/shard-skl7/igt@[email protected]
* igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-0-hflip:
- shard-apl: NOTRUN -> [SKIP][23] ([fdo#109271] / [i915#3777]) +1 similar issue
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20633/shard-apl2/igt@[email protected]
* igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-0-hflip:
- shard-skl: NOTRUN -> [SKIP][24] ([fdo#109271] / [i915#3777])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20633/shard-skl7/igt@[email protected]
* igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-180-hflip:
- shard-kbl: NOTRUN -> [SKIP][25] ([fdo#109271] / [i915#3777])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20633/shard-kbl6/igt@[email protected]
* igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-0:
- shard-iclb: NOTRUN -> [SKIP][26] ([fdo#110723]) +1 similar issue
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20633/shard-iclb2/igt@[email protected]
* igt@kms_ccs@pipe-b-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc:
- shard-skl: NOTRUN -> [FAIL][27] ([i915#3678])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20633/shard-skl7/igt@kms_ccs@pipe-b-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-b-crc-primary-basic-yf_tiled_ccs:
- shard-tglb: NOTRUN -> [SKIP][28] ([i915#3689]) +5 similar issues
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20633/shard-tglb3/igt@kms_ccs@pipe-b-crc-primary-basic-yf_tiled_ccs.html
* igt@kms_chamelium@dp-edid-change-during-suspend:
- shard-apl: NOTRUN -> [SKIP][29] ([fdo#109271] / [fdo#111827]) +14 similar issues
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20633/shard-apl7/igt@[email protected]
* igt@kms_chamelium@dp-hpd-storm-disable:
- shard-tglb: NOTRUN -> [SKIP][30] ([fdo#109284] / [fdo#111827]) +1 similar issue
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20633/shard-tglb3/igt@[email protected]
* igt@kms_chamelium@hdmi-aspect-ratio:
- shard-kbl: NOTRUN -> [SKIP][31] ([fdo#109271] / [fdo#111827]) +1 similar issue
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20633/shard-kbl6/igt@[email protected]
* igt@kms_chamelium@vga-edid-read:
- shard-iclb: NOTRUN -> [SKIP][32] ([fdo#109284] / [fdo#111827]) +1 similar issue
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20633/shard-iclb2/igt@[email protected]
* igt@kms_color@pipe-d-ctm-negative:
- shard-iclb: NOTRUN -> [SKIP][33] ([fdo#109278] / [i915#1149]) +1 similar issue
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20633/shard-iclb2/igt@[email protected]
* igt@kms_color_chamelium@pipe-a-ctm-blue-to-red:
- shard-snb: NOTRUN -> [SKIP][34] ([fdo#109271] / [fdo#111827]) +11 similar issues
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20633/shard-snb6/igt@[email protected]
* igt@kms_color_chamelium@pipe-invalid-ctm-matrix-sizes:
- shard-skl: NOTRUN -> [SKIP][35] ([fdo#109271] / [fdo#111827]) +11 similar issues
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20633/shard-skl7/igt@[email protected]
* igt@kms_cursor_crc@pipe-a-cursor-32x32-sliding:
- shard-tglb: NOTRUN -> [SKIP][36] ([i915#3319]) +2 similar issues
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20633/shard-tglb3/igt@[email protected]
* igt@kms_cursor_crc@pipe-c-cursor-32x32-rapid-movement:
- shard-glk: NOTRUN -> [SKIP][37] ([fdo#109271]) +1 similar issue
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20633/shard-glk6/igt@[email protected]
* igt@kms_cursor_crc@pipe-d-cursor-512x170-offscreen:
- shard-tglb: NOTRUN -> [SKIP][38] ([fdo#109279] / [i915#3359]) +1 similar issue
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20633/shard-tglb1/igt@[email protected]
* igt@kms_cursor_crc@pipe-d-cursor-dpms:
- shard-iclb: NOTRUN -> [SKIP][39] ([fdo#109278]) +11 similar issues
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20633/shard-iclb2/igt@[email protected]
* igt@kms_cursor_legacy@cursorb-vs-flipb-atomic-transitions:
- shard-iclb: NOTRUN -> [SKIP][40] ([fdo#109274] / [fdo#109278])
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20633/shard-iclb2/igt@[email protected]
* igt@kms_cursor_legacy@flip-vs-cursor-atomic:
- shard-skl: [PASS][41] -> [FAIL][42] ([i915#2346])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10346/shard-skl7/igt@[email protected]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20633/shard-skl8/igt@[email protected]
* igt@kms_dp_tiled_display@basic-test-pattern:
- shard-tglb: NOTRUN -> [SKIP][43] ([i915#426])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20633/shard-tglb3/igt@[email protected]
* igt@kms_fbcon_fbt@fbc-suspend:
- shard-apl: [PASS][44] -> [INCOMPLETE][45] ([i915#180])
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10346/shard-apl1/igt@[email protected]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20633/shard-apl6/igt@[email protected]
* igt@kms_flip@2x-flip-vs-modeset-vs-hang:
- shard-iclb: NOTRUN -> [SKIP][46] ([fdo#109274])
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20633/shard-iclb7/igt@[email protected]
* igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1:
- shard-skl: NOTRUN -> [FAIL][47] ([i915#79])
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20633/shard-skl7/igt@kms_flip@[email protected]
* igt@kms_flip@flip-vs-expired-vblank-interruptible@c-edp1:
- shard-skl: NOTRUN -> [FAIL][48] ([i915#2122])
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20633/shard-skl7/igt@kms_flip@[email protected]
* igt@kms_flip@plain-flip-ts-check@c-edp1:
- shard-skl: [PASS][49] -> [FAIL][50] ([i915#2122])
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10346/shard-skl6/igt@kms_flip@[email protected]
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20633/shard-skl7/igt@kms_flip@[email protected]
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-draw-blt:
- shard-kbl: NOTRUN -> [SKIP][51] ([fdo#109271]) +27 similar issues
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20633/shard-kbl6/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-draw-mmap-wc:
- shard-apl: NOTRUN -> [SKIP][52] ([fdo#109271]) +185 similar issues
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20633/shard-apl3/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-draw-mmap-wc.html
* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-onoff:
- shard-iclb: NOTRUN -> [SKIP][53] ([fdo#109280]) +3 similar issues
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20633/shard-iclb2/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-cur-indfb-draw-blt:
- shard-tglb: NOTRUN -> [SKIP][54] ([fdo#111825]) +4 similar issues
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20633/shard-tglb3/igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-cur-indfb-draw-blt.html
* igt@kms_hdr@bpc-switch-suspend:
- shard-skl: NOTRUN -> [FAIL][55] ([i915#1188])
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20633/shard-skl7/igt@[email protected]
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d:
- shard-apl: NOTRUN -> [SKIP][56] ([fdo#109271] / [i915#533]) +2 similar issues
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20633/shard-apl2/igt@[email protected]
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-d:
- shard-skl: NOTRUN -> [SKIP][57] ([fdo#109271] / [i915#533]) +1 similar issue
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20633/shard-skl1/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-a-alpha-opaque-fb:
- shard-apl: NOTRUN -> [FAIL][58] ([fdo#108145] / [i915#265]) +2 similar issues
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20633/shard-apl7/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-b-alpha-opaque-fb:
- shard-skl: NOTRUN -> [FAIL][59] ([fdo#108145] / [i915#265]) +2 similar issues
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20633/shard-skl7/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min:
- shard-skl: [PASS][60] -> [FAIL][61] ([fdo#108145] / [i915#265])
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10346/shard-skl4/igt@[email protected]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20633/shard-skl10/igt@[email protected]
* igt@kms_plane_lowres@pipe-c-tiling-none:
- shard-tglb: NOTRUN -> [SKIP][62] ([i915#3536])
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20633/shard-tglb3/igt@[email protected]
* igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-5:
- shard-apl: NOTRUN -> [SKIP][63] ([fdo#109271] / [i915#658]) +2 similar issues
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20633/shard-apl2/igt@[email protected]
* igt@kms_psr2_sf@plane-move-sf-dmg-area-0:
- shard-skl: NOTRUN -> [SKIP][64] ([fdo#109271] / [i915#658]) +1 similar issue
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20633/shard-skl7/igt@[email protected]
* igt@kms_psr2_sf@plane-move-sf-dmg-area-2:
- shard-kbl: NOTRUN -> [SKIP][65] ([fdo#109271] / [i915#658])
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20633/shard-kbl6/igt@[email protected]
* igt@kms_psr2_su@page_flip:
- shard-iclb: [PASS][66] -> [SKIP][67] ([fdo#109642] / [fdo#111068] / [i915#658])
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10346/shard-iclb2/igt@kms_psr2_su@page_flip.html
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20633/shard-iclb7/igt@kms_psr2_su@page_flip.html
* igt@kms_psr@psr2_primary_page_flip:
- shard-iclb: [PASS][68] -> [SKIP][69] ([fdo#109441]) +2 similar issues
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10346/shard-iclb2/igt@kms_psr@psr2_primary_page_flip.html
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20633/shard-iclb7/igt@kms_psr@psr2_primary_page_flip.html
- shard-tglb: NOTRUN -> [FAIL][70] ([i915#132] / [i915#3467])
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20633/shard-tglb3/igt@kms_psr@psr2_primary_page_flip.html
* igt@kms_vblank@pipe-d-query-forked-hang:
- shard-snb: NOTRUN -> [SKIP][71] ([fdo#109271]) +217 similar issues
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20633/shard-snb2/igt@[email protected]
* igt@kms_vrr@flip-basic:
- shard-iclb: NOTRUN -> [SKIP][72] ([fdo#109502])
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20633/shard-iclb2/igt@[email protected]
* igt@kms_writeback@writeback-invalid-parameters:
- shard-tglb: NOTRUN -> [SKIP][73] ([i915#2437])
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20633/shard-tglb3/igt@[email protected]
* igt@kms_writeback@writeback-pixel-formats:
- shard-apl: NOTRUN -> [SKIP][74] ([fdo#109271] / [i915#2437])
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20633/shard-apl7/igt@[email protected]
* igt@nouveau_crc@pipe-b-source-rg:
- shard-iclb: NOTRUN -> [SKIP][75] ([i915#2530])
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20633/shard-iclb2/igt@[email protected]
* igt@nouveau_crc@pipe-d-source-outp-inactive:
- shard-tglb: NOTRUN -> [SKIP][76] ([i915#2530])
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20633/shard-tglb3/igt@[email protected]
* igt@prime_nv_test@i915_import_gtt_mmap:
- shard-tglb: NOTRUN -> [SKIP][77] ([fdo#109291]) +1 similar issue
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20633/shard-tglb1/igt@prime_nv_test@i915_import_gtt_mmap.html
* igt@sysfs_clients@fair-0:
- shard-apl: NOTRUN -> [SKIP][78] ([fdo#109271] / [i915#2994]) +1 similar issue
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20633/shard-apl7/igt@[email protected]
* igt@sysfs_clients@pidname:
- shard-skl: NOTRUN -> [SKIP][79] ([fdo#109271] / [i915#2994])
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20633/shard-skl7/igt@[email protected]
#### Possible fixes ####
* igt@gem_exec_fair@basic-none@rcs0:
- shard-kbl: [FAIL][80] ([i915#2842]) -> [PASS][81] +1 similar issue
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10346/shard-kbl1/igt@gem_exec_fair@[email protected]
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20633/shard-kbl4/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-pace@rcs0:
- shard-tglb: [FAIL][82] ([i915#2842]) -> [PASS][83]
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10346/shard-tglb1/igt@gem_exec_fair@[email protected]
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20633/shard-tglb7/igt@gem_exec_fair@[email protected]
* igt@gem_mmap_gtt@cpuset-big-copy:
- shard-iclb: [FAIL][84] ([i915#307]) -> [PASS][85]
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10346/shard-iclb4/igt@[email protected]
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20633/shard-iclb2/igt@[email protected]
* igt@gem_workarounds@suspend-resume-context:
- shard-apl: [DMESG-WARN][86] ([i915#180]) -> [PASS][87]
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10346/shard-apl1/igt@[email protected]
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20633/shard-apl3/igt@[email protected]
* igt@kms_cursor_crc@pipe-b-cursor-suspend:
- shard-kbl: [DMESG-WARN][88] ([i915#180]) -> [PASS][89]
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10346/shard-kbl3/igt@[email protected]
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20633/shard-kbl6/igt@[email protected]
* igt@kms_cursor_crc@pipe-c-cursor-suspend:
- shard-skl: [INCOMPLETE][90] ([i915#300]) -> [PASS][91]
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10346/shard-skl2/igt@[email protected]
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20633/shard-skl7/igt@[email protected]
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size:
- shard-skl: [FAIL][92] ([i915#2346] / [i915#533]) -> [PASS][93]
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10346/shard-skl3/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20633/shard-skl1/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
* igt@kms_flip@flip-vs-panning-interruptible@d-edp1:
- shard-tglb: [INCOMPLETE][94] -> [PASS][95]
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10346/shard-tglb6/igt@kms_flip@[email protected]
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20633/shard-tglb3/igt@kms_flip@[email protected]
* igt@kms_flip@flip-vs-suspend-interruptible@c-edp1:
- shard-skl: [INCOMPLETE][96] ([i915#198] / [i915#2910]) -> [PASS][97]
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10346/shard-skl10/igt@kms_flip@[email protected]
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20633/shard-skl7/igt@kms_flip@[email protected]
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
- shard-iclb: [INCOMPLETE][98] ([i915#1185]) -> [PASS][99]
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10346/shard-iclb3/igt@[email protected]
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20633/shard-iclb2/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-b-coverage-vs-premult-vs-constant:
- shard-iclb: [SKIP][100] ([fdo#109278]) -> [PASS][101]
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10346/shard-iclb2/igt@kms_plane_alpha_blend@pipe-b-coverage-vs-premult-vs-constant.html
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20633/shard-iclb7/igt@kms_plane_alpha_blend@pipe-b-coverage-vs-premult-vs-constant.html
* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: [FAIL][102] ([fdo#108145] / [i915#265]) -> [PASS][103] +1 similar issue
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10346/shard-skl8/igt@[email protected]
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20633/shard-skl1/igt@[email protected]
* igt@kms_psr@psr2_cursor_plane_move:
- shard-iclb: [SKIP][104] ([fdo#109441]) -> [PASS][105] +1 similar issue
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10346/shard-iclb1/igt@kms_psr@psr2_cursor_plane_move.html
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20633/shard-iclb2/igt@kms_psr@psr2_cursor_plane_move.html
* igt@perf@polling-small-buf:
- shard-skl: [FAIL][106] ([i915#1722]) -> [PASS][107]
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10346/shard-skl2/igt@[email protected]
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20633/shard-skl9/igt@[email protected]
#### Warnings ####
* igt@gem_exec_fair@basic-none-rrul@rcs0:
- shard-iclb: [FAIL][108] ([i915#2842]) -> [FAIL][109] ([i915#2852])
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10346/shard-iclb1/igt@gem_exec_fair@[email protected]
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20633/shard-iclb7/igt@gem_exec_fair@[email protected]
* igt@i915_pm_rc6_residency@rc6-fence:
- shard-iclb: [WARN][110] ([i915#1804] / [i915#2684]) -> [WARN][111] ([i915#2684]) +1 similar issue
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10346/shard-iclb7/igt@[email protected]
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20633/shard-iclb5/igt@[email protected]
* igt@kms_dp_dsc@basic-dsc-enable-edp:
- shard-iclb: [SKIP][112] ([fdo#109349]) -> [DMESG-WARN][113] ([i915#1226])
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10346/shard-iclb1/igt@[email protected]
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20633/shard-iclb2/igt@[email protected]
* igt@kms_psr2_sf@plane-move-sf-dmg-area-3:
- shard-iclb: [SKIP][114] ([i915#658]) -> [SKIP][115] ([i915#2920]) +1 similar issue
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10346/shard-iclb4/igt@[email protected]
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20633/shard-iclb2/igt@[email protected]
* igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-2:
- shard-iclb: [SKIP][116] ([i915#2920]) -> [SKIP][117] ([i915#658]) +1 similar issue
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10346/shard-iclb2/igt@[email protected]
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20633/shard-iclb6/igt@[email protected]
* igt@runner@aborted:
- shard-kbl: ([FAIL][118], [FAIL][119], [FAIL][120]) ([i915#1814] / [i915#3002] / [i915#3363]) -> ([FAIL][121], [FAIL][122]) ([i915#3002] / [i915#3363])
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10346/shard-kbl4/igt@[email protected]
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10346/shard-kbl3/igt@[email protected]
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10346/shard-kbl3/igt@[email protected]
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20633/shard-kbl7/igt@[email protected]
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20633/shard-kbl3/igt@[email protected]
- shard-apl: ([FAIL][123], [FAIL][124], [FAIL][125], [FAIL][126]) ([fdo#109271] / [i915#180] / [i915#3002] / [i915#3363]) -> ([FAIL][127], [FAIL][128], [FAIL][129], [FAIL][130], [FAIL][131]) ([i915#1610] / [i915#180] / [i915#2292] / [i915#3002] / [i915#3363])
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10346/shard-apl3/igt@[email protected]
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10346/shard-apl3/igt@[email protected]
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10346/shard-apl3/igt@[email protected]
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10346/shard-apl1/igt@[email protected]
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20633/shard-apl1/igt@[email protected]
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20633/shard-apl1/igt@[email protected]
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20633/shard-apl6/igt@[email protected]
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20633/shard-apl2/igt@[email protected]
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20633/shard-apl1/igt@[email protected]
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109279]: https://bugs.freedesktop.org/show_bug.cgi?id=109279
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291
[fdo#109349]: https://bugs.freedesktop.org/show_bug.cgi?id=109349
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109502]: https://bugs.freedesktop.org/show_bug.cgi?id=109502
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
[fdo#110892]: https://bugs.freedesktop.org/show_bug.cgi?id=110892
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1099]: https://gitlab.freedesktop.org/drm/intel/issues/1099
[i915#1149]: https://gitlab.freedesktop.org/drm/intel/issues/1149
[i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
[i915#1185]: https://gitlab.freedesktop.org/drm/intel/issues/1185
[i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188
[i915#1226]: https://gitlab.freedesktop.org/drm/intel/issues/1226
[i915#132]: https://gitlab.freedesktop.org/drm/intel/issues/132
[i915#1610]: https://gitlab.freedesktop.org/drm/intel/issues/1610
[i915#1722
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20633/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx