Skip to contentSkip to conversation

i40e: Fix pre-set max number of queues for VF

PATCH New Mateusz Palczewski 2 participants 2 messages Jul 16, 2021 – Nov 30, 2021

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 i40e: Fix pre-set max number of queues for VF

After setting pre-set combined to 16 queues and reserving 16 queues by tc qdisc, pre-set maximum combined queues returned to default value after VF reset being 4 and this generated errors during removing tc. Fixed by removing clear num_req_queues before reset VF.

Fixes e284fc280473 (i40e: Add and delete cloud filter)
Change-Id Ib2db315e4b04eeb15e12301edf833014a929e914

---
v2: Refactored commit message
v3: Fixed wrong e-mail address in commit message

---
 drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c | 5 -----
 1 file changed, 5 deletions(-)
drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c +0 -5
index 4da982b..c007fba 100644
@@ -3873,11 +3873,6 @@ static int i40e_vc_add_qch_msg(struct i40e_vf *vf, u8 *msg)
 
 	/* set this flag only after making sure all inputs are sane */
 	vf->adq_enabled = true;
-	/* num_req_queues is set when user changes number of queues via ethtool
-	 * and this causes issue for default VSI(which depends on this variable)
-	 * when ADq is enabled, hence reset it.
-	 */
-	vf->num_req_queues = 0;
 
 	/* reset the VF in order to allocate resources */
 	i40e_vc_reset_vf(vf, true);
Signature · 1 line
2.27.0
#1 lore raw

PATCH v3 1/1 i40e: Fix pre-set max number of queues for VF

Quoted 20 lines

-----Original Message-----
From: Intel-wired-lan <[email protected]> On Behalf Of Palczewski, Mateusz
Sent: Friday, July 16, 2021 3:04 PM
To: intel-wired-lan at lists.osuosl.org
Cc: Palczewski, Mateusz <[email protected]>
Subject: [Intel-wired-lan] [PATCH net v3] i40e: Fix pre-set max number of queues for VF

After setting pre-set combined to 16 queues and reserving 16 queues by tc qdisc, pre-set maximum combined queues returned to default value after VF reset being 4 and this generated errors during removing tc. Fixed by removing clear num_req_queues before reset VF.

Fixes e284fc280473 (i40e: Add and delete cloud filter)
Change-Id Ib2db315e4b04eeb15e12301edf833014a929e914
Quoted 7 lines

---
v2: Refactored commit message
v3: Fixed wrong e-mail address in commit message

---
 drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c | 5 -----
 1 file changed, 5 deletions(-)