Introduce webauth auth pending method and deprecate openurl
PATCH 1/1 Introduce webauth auth pending method and deprecate openurl
The experience with openurl/OPEN_URL has shown that just sending a URL to a client is not enough and we often need different behaviour of the client depending on circumstances. Replace OPEN_URL with a more flexible WEBAUTH pending auth method.
--- doc/management-notes.txt | 41 ++++++++++++++++++++++++++----------- include/openvpn-plugin.h.in | 2 +- 2 files changed, 30 insertions(+), 13 deletions(-)
doc/management-notes.txt +29 -12
@@ -645,11 +645,11 @@ Before issuing a client-pending-auth to a client instead of a client-auth/client-deny, the server should check the IV_SSO environment variable for whether the method is supported. Currently defined methods are crtext for challenge/response using text -(e.g., TOTP), openurl and proxy_url for opening a URL in the client to -continue authentication. A client supporting the first two methods would -set +(e.g., TOTP), openurl (deprecated) and webauth for opening a URL in +the client to continue authentication. A client supporting the last +two methods would set - setenv IV_SSO openurl,crtext + setenv IV_SSO webauth,crtext The variable name IV_SSO is historic as AUTH_PENDING was first used to signal single sign on support. To keep compatibility with existing
@@ -668,33 +668,50 @@ notification as where {EXTRA} is formatted as received from the server. Currently defined formats for {EXTRA} are detailed below. -openurl -======== +webauth and openurl +=================== For a web based extra authentication (like for SSO/SAML) {EXTRA} should be OPEN_URL:url -and client should ask the user to open the URL to continue. +or + + WEBAUTH:flags:url + +The OPEN_URL method is deprecated as it does not allow to send flags which +proved to be needed to signal certain behaviour to the client. + +The client should ask the user to open the URL to continue. The space in a control message is limited, so this url should be kept short to avoid issues. If a longer url is required a URL that redirects -to the longer URL should be sent instead. +to the longer URL should be sent instead. The total length is limited to 1024 +bytes which includes the INFO_PRE:WEBAUTH:flags. + +flags is a list of flags which are separated by commas. Currently defined +flags are: + +- proxy (see next pargraph) +- hidden start the webview in hidden mode (see openvpn3 webauth documentation) +- external Do not use an internal webview but use an external browser. Some + authentication providers refuse to work in an internal webview. + A complete documentation how URLs should be handled on the client is available in the openvpn3 repository: https://github.com/OpenVPN/openvpn3/blob/master/doc/webauth.md -proxy_url -======== -This is a variant of openurl that allows opening a url via an +webauth with proxy +================== +This is a variant of webauth that allows opening a url via an HTTP proxy. It could be used to avoid issues with OpenVPN connection's persist-tun that may cause the web server to be unreachable. The client should announce proxy_url in its IV_SSO and parse the PROXY_URL message. The format of {EXTRA} in this case is - PROXY_URL:<proxy>:<proxy_port>:<proxyuser_base64>:<proxy_password_base64>:url + WEBAUTH:proxy=<proxy>;<proxy_port>;<proxyuser_base64>;<proxy_password_base64>,flags:url The proxy should be a literal IPv4 address or IPv6 address enclosed in [] to avoid ambiguity in parsing. A literal IP address is preferred as DNS might not be
include/openvpn-plugin.h.in +1 -1
@@ -578,7 +578,7 @@ OPENVPN_PLUGIN_DEF openvpn_plugin_handle_t OPENVPN_PLUGIN_FUNC(openvpn_plugin_op * auth_pending_file is * line 1: timeout in seconds * line 2: Pending auth method the client needs to support (e.g. openurl) - * line 3: EXTRA (e.g. OPEN_URL:http://www.example.com) + * line 3: EXTRA (e.g. WEBAUTH::http://www.example.com) * * In addition the OPENVPN_PLUGIN_CLIENT_CONNECT_DEFER and * OPENVPN_PLUGIN_CLIENT_CONNECT_DEFER_V2 are called when OpenVPN tries to
Signature · 1 line
2.32.0
Am 16.07.21 um 14:18 schrieb Arne Schwabe:
Quoted 4 lines
The experience with openurl/OPEN_URL has shown that just sending a URL to a client is not enough and we often need different behaviour of the client depending on circumstances. Replace
OPEN_URLwith a more flexible WEBAUTH pending auth method.
Just as FYI this is more of an RFC to give other people an early opportunity to object/remark or request changes to the protocol as we are going to implement this very soon this way if no objections are raised.
Arne
Hi,
Quoted 5 lines · Arne Schwabe
The experience with openurl/OPEN_URL has shown that just sending a URL to a client is not enough and we often need different behaviour of the client depending on circumstances. Replace
OPEN_URLwith a more flexible WEBAUTH pending auth method.
As the two other methods are signalled as OPEN_URL and CR_TEXT, please consider using WEB_AUTH. The corresponding IV_SSO value can still be named "webauth" as you have below, consistent with crtext and openurl.
I know it's just a keyword, but consistency makes it easier to write consuming code without repeatedly referring to the docs.
Quoted 16 lines
Signed-off-by Arne Schwabe <[email protected]...>--- doc/management-notes.txt | 41 ++++++++++++++++++++++++++----------- include/openvpn-plugin.h.in | 2 +- 2 files changed, 30 insertions(+), 13 deletions(-)doc/management-notes.txt +0
-0@@ -645,11 +645,11 @@ Before issuing a client-pending-auth to a clientinstead of a
client-auth/client-deny, the server should check theIV_SSOenvironment variable for whether the method is supported. Currently defined methods are crtext for challenge/response using text
doc/management-notes.txt Before issuing a client-pending-auth to a client instead of a · line 648
Quoted 4 lines
doc/management-notes.txt +1
-3-(e.g., TOTP), openurl and proxy_url for opening a URL in the client to -continue authentication. A client supporting the first two methods would -set +(e.g., TOTP), openurl (deprecated) and webauth for opening a URL in
As we have not released any versions with openurl, why not just replace it webauth? Anyway, below you are replacing proxy_url to use WEB_AUTH instead of PROXY_URL.
doc/management-notes.txt Before issuing a client-pending-auth to a client instead of a · line 652
Quoted 7 lines
doc/management-notes.txt +3
-1+the client to continue authentication. A client supporting the last +two methods would set - setenv IV_SSO openurl,crtext + setenv IV_SSO webauth,crtext
The last two methods as per the text above are openutl and webauth. Reword as
"A client supporting webauth and crtext would set
setenv IV_SSO webauth,crtext"
Quoted 10 lines
The variable name
IV_SSOis historic asAUTH_PENDINGwas first used to signal single sign on support. To keep compatibility with existingdoc/management-notes.txt +1
-2@@ -668,33 +668,50 @@ notification as where {EXTRA} is formatted as received from the server. Currently defined formats for {EXTRA} are detailed below. -openurl -======== +webauth and openurl
doc/management-notes.txt notification as · line 680
Quoted 10 lines
doc/management-notes.txt +4
-1+=================== For a web based extra authentication (like for SSO/SAML) {EXTRA} should be OPEN_URL:url -and client should ask the user to open the URL to continue. +or + + WEBAUTH:flags:url
+
Quoted 11 lines
doc/management-notes.txt +5
-1+The OPEN_URL method is deprecated as it does not allow to send flags which +proved to be needed to signal certain behaviour to the client. + +The client should ask the user to open the URL to continue. The space in a control message is limited, so this url should be kept short to avoid issues. If a longer url is required a URL that redirects -to the longer URL should be sent instead. +to the longer URL should be sent instead. The total length is limited to1024
+bytes which includes the INFO_PRE:WEBAUTH:flags.
+
Quoted 30 lines
doc/management-notes.txt +5
-0+flags is a list of flags which are separated by commas. Currently defined +flags are: + +- proxy (see next pargraph) +- hidden start the webview in hidden mode (see openvpn3 webauthdocumentation)
+- external Do not use an internal webview but use an external browser. Some
+ authentication providers refuse to work in an internal
webview.
+A complete documentation how URLs should be handled on the client is
available
in the openvpn3 repository:https://github.com/OpenVPN/openvpn3/blob/master/doc/webauth.md
doc/management-notes.txt +3
-4-proxy_url -======== -This is a variant of openurl that allows opening a url via an +webauth with proxy +================== +This is a variant of webauth that allows opening a url via an HTTP proxy. It could be used to avoid issues with OpenVPN connection's persist-tun that may cause the web server to be unreachable. The client should announce proxy_url in its IV_SSO and parse the PROXY_URL message. The format of {EXTRA} in this case is -
Quoted 3 lines
PROXY_URL:<proxy>:<proxy_port>:<proxyuser_base64>:<proxy_password_base64>:url + WEBAUTH:proxy=<proxy>;<proxy_port>;<proxyuser_base64>;<proxy_password_base64>,flags:url
The proxy should be a literal IPv4 address or IPv6 address enclosed in []
Quoted 11 lines
to avoid
ambiguity in parsing. A literal IP address is preferred as DNS might not
beinclude/openvpn-plugin.h.in +0
-0@@ -578,7 +578,7 @@ OPENVPN_PLUGIN_DEF openvpn_plugin_handle_tOPENVPN_PLUGIN_FUNC(openvpn_plugin_op
*auth_pending_fileis
* line 1: timeout in seconds
Quoted 9 lines
* line 2: Pending auth method the client needs to support (e.g. openurl)
- * line 3: EXTRA (e.g. OPEN_URL:http://www.example.com)
+ * line 3: EXTRA (e.g. WEBAUTH::http://www.example.com)
*
* In addition theOPENVPN_PLUGIN_CLIENT_CONNECT_DEFERand
*OPENVPN_PLUGIN_CLIENT_CONNECT_DEFER_V2are called when OpenVPN tries to
--
2.32.0
Looks good otherwise.
Selva
PATCH v2 1/1 Introduce webauth auth pending method and deprecate openurl
In reply to Arne SchwabeThe experience with openurl/OPEN_URL has shown that just sending a URL to a client is not enough and we often need different behaviour of the client depending on circumstances. Replace OPEN_URL with a more flexible WEB_AUTH pending auth method.
Patch v2: use WEB_AUTH instead WEBAUTH
--- doc/management-notes.txt | 41 ++++++++++++++++++++++++++----------- include/openvpn-plugin.h.in | 2 +- 2 files changed, 30 insertions(+), 13 deletions(-)
doc/management-notes.txt +29 -12
@@ -645,11 +645,11 @@ Before issuing a client-pending-auth to a client instead of a client-auth/client-deny, the server should check the IV_SSO environment variable for whether the method is supported. Currently defined methods are crtext for challenge/response using text -(e.g., TOTP), openurl and proxy_url for opening a URL in the client to -continue authentication. A client supporting the first two methods would -set +(e.g., TOTP), openurl (deprecated) and webauth for opening a URL in +the client to continue authentication. A client supporting webauth and +crtext would set - setenv IV_SSO openurl,crtext + setenv IV_SSO webauth,crtext The variable name IV_SSO is historic as AUTH_PENDING was first used to signal single sign on support. To keep compatibility with existing
@@ -668,33 +668,50 @@ notification as where {EXTRA} is formatted as received from the server. Currently defined formats for {EXTRA} are detailed below. -openurl -======== +webauth and openurl +=================== For a web based extra authentication (like for SSO/SAML) {EXTRA} should be OPEN_URL:url -and client should ask the user to open the URL to continue. +or + + WEB_AUTH:flags:url + +The OPEN_URL method is deprecated as it does not allow to send flags which +proved to be needed to signal certain behaviour to the client. + +The client should ask the user to open the URL to continue. The space in a control message is limited, so this url should be kept short to avoid issues. If a longer url is required a URL that redirects -to the longer URL should be sent instead. +to the longer URL should be sent instead. The total length is limited to 1024 +bytes which includes the INFO_PRE:WEB_AUTH:flags. + +flags is a list of flags which are separated by commas. Currently defined +flags are: + +- proxy (see next pargraph) +- hidden start the webview in hidden mode (see openvpn3 webauth documentation) +- external Do not use an internal webview but use an external browser. Some + authentication providers refuse to work in an internal webview. + A complete documentation how URLs should be handled on the client is available in the openvpn3 repository: https://github.com/OpenVPN/openvpn3/blob/master/doc/webauth.md -proxy_url -======== -This is a variant of openurl that allows opening a url via an +webauth with proxy +================== +This is a variant of webauth that allows opening a url via an HTTP proxy. It could be used to avoid issues with OpenVPN connection's persist-tun that may cause the web server to be unreachable. The client should announce proxy_url in its IV_SSO and parse the PROXY_URL message. The format of {EXTRA} in this case is - PROXY_URL:<proxy>:<proxy_port>:<proxyuser_base64>:<proxy_password_base64>:url + WEB_AUTH:proxy=<proxy>;<proxy_port>;<proxyuser_base64>;<proxy_password_base64>,flags:url The proxy should be a literal IPv4 address or IPv6 address enclosed in [] to avoid ambiguity in parsing. A literal IP address is preferred as DNS might not be
include/openvpn-plugin.h.in +1 -1
@@ -573,7 +573,7 @@ OPENVPN_PLUGIN_DEF openvpn_plugin_handle_t OPENVPN_PLUGIN_FUNC(openvpn_plugin_op * auth_pending_file is * line 1: timeout in seconds * line 2: Pending auth method the client needs to support (e.g. openurl) - * line 3: EXTRA (e.g. OPEN_URL:http://www.example.com) + * line 3: EXTRA (e.g. WEBAUTH::http://www.example.com) * * In addition the OPENVPN_PLUGIN_CLIENT_CONNECT_DEFER and * OPENVPN_PLUGIN_CLIENT_CONNECT_DEFER_V2 are called when OpenVPN tries to
Signature · 1 line
2.32.0
Hi,
Quoted 6 lines · Arne Schwabe
The experience with openurl/OPEN_URL has shown that just sending a URL to a client is not enough and we often need different behaviour of the client depending on circumstances. Replace
OPEN_URLwith a more flexibleWEB_AUTHpending auth method.Patch v2: use
WEB_AUTHinstead WEBAUTH
[..]
I think this is mostly ready, except for a small oversight:
doc/management-notes.txt notification as · line 712
Quoted 10 lines
doc/management-notes.txt +3
-3-proxy_url -======== -This is a variant of openurl that allows opening a url via an +webauth with proxy +================== +This is a variant of webauth that allows opening a url via an HTTP proxy. It could be used to avoid issues with OpenVPN connection's persist-tun that may cause the web server to be unreachable. The client should announce proxy_url in its IV_SSO and parse the PROXY_URL message. The format of {EXTRA} in this case is
^^^^^^^^^ there is no PROXY_URL anymore, so this might read
... and parse the "proxy=..." part of the "flags" section. The format of {EXTRA} in this case is:
Or something like this.
gert
Signature · 6 lines
"If was one thing all people took for granted, was conviction that if you
feed honest figures into a computer, honest figures come out. Never doubted
it myself till I met a computer with a sense of humor."
Robert A. Heinlein, The Moon is a Harsh Mistress
Gert Doering - Munich, Germany [email protected]...Hi,
-proxy_url
doc/management-notes.txt notification as · line 712
Quoted 10 lines
-========
doc/management-notes.txt +3
-1-This is a variant of openurl that allows opening a url via an +webauth with proxy +================== +This is a variant of webauth that allows opening a url via an HTTP proxy. It could be used to avoid issues with OpenVPN connection's persist-tun that may cause the web server to be unreachable. The client should announce proxy_url in its IV_SSO and parse the PROXY_URL message. The format of {EXTRA} in this case is
"PROXY_URL message" above should be replaced by "proxy flag and related flags in the message" (Gert has already pointed this out.)
But we keep the requirement that compliant clients should announce "proxy" in IV_SSO, right? As the flag is called "proxy", I suggest we change that IV_SSO value to "proxy" as well.
With "flags", WEBAUTH is extensible and we have to decide which features require an explicit announce from the client. As not every client may be ready to support proxy, looks reasonable to require it in IV_SSO.
We may soon require a section titled IV_SSO and list all legal values in there.
-
Quoted 4 lines
PROXY_URL:<proxy>:<proxy_port>:<proxyuser_base64>:<proxy_password_base64>:url + WEB_AUTH:proxy=<proxy>;<proxy_port>;<proxyuser_base64>;<proxy_password_base64>,flags:url
This may be an opportunity to change proxyuser_base64 to proxy_user_base64 as well. That would match proxy_password_base64 and proxy_port.
Quoted 12 lines
The proxy should be a literal IPv4 address or IPv6 address enclosed in []
to avoid
ambiguity in parsing. A literal IP address is preferred as DNS might not
beinclude/openvpn-plugin.h.in +0
-0@@ -573,7 +573,7 @@ OPENVPN_PLUGIN_DEF openvpn_plugin_handle_tOPENVPN_PLUGIN_FUNC(openvpn_plugin_op
*auth_pending_fileis
Quoted 8 lines
* line 1: timeout in seconds
* line 2: Pending auth method the client needs to support (e.g. openurl)
- * line 3: EXTRA (e.g. OPEN_URL:http://www.example.com)
+ * line 3: EXTRA (e.g. WEBAUTH::http://www.example.com)
*
* In addition theOPENVPN_PLUGIN_CLIENT_CONNECT_DEFERand
*OPENVPN_PLUGIN_CLIENT_CONNECT_DEFER_V2are called when OpenVPN tries to
--
Looks good otherwise.
Selva
PATCH v3 1/1 Introduce webauth auth pending method and deprecate openurl
In reply to Arne SchwabeThe experience with openurl/OPEN_URL has shown that just sending a URL to a client is not enough and we often need different behaviour of the client depending on circumstances. Replace OPEN_URL with a more flexible WEB_AUTH pending auth method.
Patch v2: use WEB_AUTH instead WEBAUTH
Patch v3: incooperate other comments from Selva
--- doc/management-notes.txt | 45 +++++++++++++++++++++++++------------ include/openvpn-plugin.h.in | 2 +- 2 files changed, 32 insertions(+), 15 deletions(-)
doc/management-notes.txt +31 -14
@@ -645,11 +645,11 @@ Before issuing a client-pending-auth to a client instead of a client-auth/client-deny, the server should check the IV_SSO environment variable for whether the method is supported. Currently defined methods are crtext for challenge/response using text -(e.g., TOTP), openurl and proxy_url for opening a URL in the client to -continue authentication. A client supporting the first two methods would -set +(e.g., TOTP), openurl (deprecated) and webauth for opening a URL in +the client to continue authentication. A client supporting webauth and +crtext would set - setenv IV_SSO openurl,crtext + setenv IV_SSO webauth,crtext The variable name IV_SSO is historic as AUTH_PENDING was first used to signal single sign on support. To keep compatibility with existing
@@ -668,33 +668,50 @@ notification as where {EXTRA} is formatted as received from the server. Currently defined formats for {EXTRA} are detailed below. -openurl -======== +webauth and openurl +=================== For a web based extra authentication (like for SSO/SAML) {EXTRA} should be OPEN_URL:url -and client should ask the user to open the URL to continue. +or + + WEB_AUTH:flags:url + +The OPEN_URL method is deprecated as it does not allow to send flags which +proved to be needed to signal certain behaviour to the client. + +The client should ask the user to open the URL to continue. The space in a control message is limited, so this url should be kept short to avoid issues. If a longer url is required a URL that redirects -to the longer URL should be sent instead. +to the longer URL should be sent instead. The total length is limited to 1024 +bytes which includes the INFO_PRE:WEB_AUTH:flags. + +flags is a list of flags which are separated by commas. Currently defined +flags are: + +- proxy (see next pargraph) +- hidden start the webview in hidden mode (see openvpn3 webauth documentation) +- external Do not use an internal webview but use an external browser. Some + authentication providers refuse to work in an internal webview. + A complete documentation how URLs should be handled on the client is available in the openvpn3 repository: https://github.com/OpenVPN/openvpn3/blob/master/doc/webauth.md -proxy_url -======== -This is a variant of openurl that allows opening a url via an +webauth with proxy +================== +This is a variant of webauth that allows opening a url via an HTTP proxy. It could be used to avoid issues with OpenVPN connection's persist-tun that may cause the web server to be unreachable. -The client should announce proxy_url in its IV_SSO and parse the -PROXY_URL message. The format of {EXTRA} in this case is +The client should announce proxy in its IV_SSO and parse the +proxy flag in the WEB_AUTH message. The format of {EXTRA} in this case is - PROXY_URL:<proxy>:<proxy_port>:<proxyuser_base64>:<proxy_password_base64>:url + WEB_AUTH:proxy=<proxy>;<proxy_port>;<proxy_user_base64>;<proxy_password_base64>,flags:url The proxy should be a literal IPv4 address or IPv6 address enclosed in [] to avoid ambiguity in parsing. A literal IP address is preferred as DNS might not be
include/openvpn-plugin.h.in +1 -1
@@ -573,7 +573,7 @@ OPENVPN_PLUGIN_DEF openvpn_plugin_handle_t OPENVPN_PLUGIN_FUNC(openvpn_plugin_op * auth_pending_file is * line 1: timeout in seconds * line 2: Pending auth method the client needs to support (e.g. openurl) - * line 3: EXTRA (e.g. OPEN_URL:http://www.example.com) + * line 3: EXTRA (e.g. WEBAUTH::http://www.example.com) * * In addition the OPENVPN_PLUGIN_CLIENT_CONNECT_DEFER and * OPENVPN_PLUGIN_CLIENT_CONNECT_DEFER_V2 are called when OpenVPN tries to
Signature · 1 line
2.32.0
Hi,
Quoted 111 lines · Arne Schwabe
The experience with openurl/OPEN_URL has shown that just sending a URL to a client is not enough and we often need different behaviour of the client depending on circumstances. Replace
OPEN_URLwith a more flexibleWEB_AUTHpending auth method.Patch v2: use
WEB_AUTHinstead WEBAUTH
Patch v3: incooperate other comments from SelvaSigned-off-by Arne Schwabe <[email protected]...>--- doc/management-notes.txt | 45 +++++++++++++++++++++++++------------ include/openvpn-plugin.h.in | 2 +- 2 files changed, 32 insertions(+), 15 deletions(-)doc/management-notes.txt +0
-0@@ -645,11 +645,11 @@ Before issuing a client-pending-auth to a clientinstead of a
client-auth/client-deny, the server should check theIV_SSOenvironment variable for whether the method is supported. Currently defined methods are crtext for challenge/response using textdoc/management-notes.txt +15
-8-(e.g., TOTP), openurl and proxy_url for opening a URL in the client to -continue authentication. A client supporting the first two methods would -set +(e.g., TOTP), openurl (deprecated) and webauth for opening a URL in +the client to continue authentication. A client supporting webauth and +crtext would set - setenv IV_SSO openurl,crtext + setenv IV_SSO webauth,crtext The variable name IV_SSO is historic as AUTH_PENDING was first used to signal single sign on support. To keep compatibility with existing@@ -668,33 +668,50 @@ notification as where {EXTRA} is formatted as received from the server. Currently defined formats for {EXTRA} are detailed below. -openurl -======== +webauth and openurl +=================== For a web based extra authentication (like for SSO/SAML) {EXTRA} should be OPEN_URL:url -and client should ask the user to open the URL to continue. +or + + WEB_AUTH:flags:url + +The OPEN_URL method is deprecated as it does not allow to send flags which +proved to be needed to signal certain behaviour to the client. + +The client should ask the user to open the URL to continue. The space in a control message is limited, so this url should be kept short to avoid issues. If a longer url is required a URL that redirects -to the longer URL should be sent instead. +to the longer URL should be sent instead. The total length is limited to1024
doc/management-notes.txt +7
-0+bytes which includes the INFO_PRE:WEB_AUTH:flags. + +flags is a list of flags which are separated by commas. Currently defined +flags are: + +- proxy (see next pargraph) +- hidden start the webview in hidden mode (see openvpn3 webauthdocumentation)
+- external Do not use an internal webview but use an external browser. Some
+ authentication providers refuse to work in an internal
webview.
+A complete documentation how URLs should be handled on the client is
available
in the openvpn3 repository:https://github.com/OpenVPN/openvpn3/blob/master/doc/webauth.md
doc/management-notes.txt +5
-6-proxy_url -======== -This is a variant of openurl that allows opening a url via an +webauth with proxy +================== +This is a variant of webauth that allows opening a url via an HTTP proxy. It could be used to avoid issues with OpenVPN connection's persist-tun that may cause the web server to be unreachable. -The client should announce proxy_url in its IV_SSO and parse the -PROXY_URL message. The format of {EXTRA} in this case is +The client should announce proxy in its IV_SSO and parse the +proxy flag in the WEB_AUTH message. The format of {EXTRA} in this case is -PROXY_URL:<proxy>:<proxy_port>:<proxyuser_base64>:<proxy_password_base64>:url + WEB_AUTH:proxy=<proxy>;<proxy_port>;<proxy_user_base64>;<proxy_password_base64>,flags:url
The proxy should be a literal IPv4 address or IPv6 address enclosed in []
to avoid
ambiguity in parsing. A literal IP address is preferred as DNS might not
beinclude/openvpn-plugin.h.in +0
-0@@ -573,7 +573,7 @@ OPENVPN_PLUGIN_DEF openvpn_plugin_handle_tOPENVPN_PLUGIN_FUNC(openvpn_plugin_op
Quoted 9 lines
*
auth_pending_fileis
* line 1: timeout in seconds
* line 2: Pending auth method the client needs to support (e.g. openurl)
- * line 3: EXTRA (e.g. OPEN_URL:http://www.example.com)
+ * line 3: EXTRA (e.g. WEBAUTH::http://www.example.com)
*
* In addition theOPENVPN_PLUGIN_CLIENT_CONNECT_DEFERand
*OPENVPN_PLUGIN_CLIENT_CONNECT_DEFER_V2are called when OpenVPN tries to
That was an easy one :-) - no code changes, no testing required.
Your patch has been applied to the master branch.
commit 42f6063f611b75a07c266061dc6a07f6dcfe372c
Author: Arne Schwabe Date: Fri Aug 13 13:55:42 2021 +0200
Introduce webauth auth pending method and deprecate openurl
Signed-off-by: Arne Schwabe <[email protected]...>
Acked-by: Selva Nair <[email protected]...>
Message-Id: <[email protected]...>
URL: https://www.mail-archive.com/[email protected]/msg22737.html
Signed-off-by: Gert Doering <[email protected]...>--
kind regards,
Gert Doering