Skip to contentSkip to conversation

package/qemu: virtfs needs system

PATCH New Fabrice Fontaine 2 participants 2 messages Jul 10, 2021 – Jul 16, 2021

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/qemu: virtfs needs system

build of qemu with virtfs but without system fails since bump to version
6.0.0 in commit 6b86c9335fc3ff381878156c6243454d4b688df9:

../meson.build:1077:6: ERROR: Problem encountered: virtio-9p (virtfs) needs system emulation support

Indeed virtfs needs system support since switch to meson in
https://gitlab.com/qemu-project/qemu/-/commit/69202b406e3a42621a063c3afe80f580d343f59e

Fixes:
- http://autobuild.buildroot.org/results/ee4b2bbc08c58dc972d285eafa43b7ad6586f270

---
 package/qemu/Config.in.host | 2 ++
 1 file changed, 2 insertions(+)
package/qemu/Config.in.host +2 -0
index 3163797067..c176001396 100644
@@ -82,6 +82,8 @@ config BR2_PACKAGE_HOST_QEMU_VDE2
 
 config BR2_PACKAGE_HOST_QEMU_VIRTFS
 	bool "Virtual filesystem support"
+	depends on BR2_PACKAGE_HOST_QEMU_SYSTEM_ARCH_SUPPORTS
+	select BR2_PACKAGE_HOST_QEMU_SYSTEM_MODE
 	help
 	  Enables support for virtual filesystem in Qemu allowing
 	  shared filesystem between Qemu and its emulated target.
Signature · 1 line
2.30.2
#1 lore raw

PATCH 1/1 package/qemu: virtfs needs system

package/qemu/Config.in.host config BR2_PACKAGE_HOST_QEMU_VDE2 · line 86

Quoted 4 lines · On Sat, 10 Jul 2021 17:54:09 +0200 Fabrice Fontaine…

config BR2_PACKAGE_HOST_QEMU_VIRTFS

package/qemu/Config.in.host +2 -0
 	bool "Virtual filesystem support"
+	depends on BR2_PACKAGE_HOST_QEMU_SYSTEM_ARCH_SUPPORTS
+	select BR2_PACKAGE_HOST_QEMU_SYSTEM_MODE

I think a:

depends on BR2_PACKAGE_HOST_QEMU_SYSTEM_MODE

made more sense here. Indeed, if the user wants the "user mode", it's a bit weird to force the user to also have the "system mode". I believe a "depends on" in this case is more appropriate.

Applied with this change. Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com