Skip to contentSkip to conversation

package/mpg123: Remove disable-lfs-alias

PATCH New gameblabla 3 participants 3 messages Jul 12, 2021 – Aug 3, 2021

lore
Share & tools
lore

gameblabla

author
#0 lore raw

PATCH 1/1 package/mpg123: Remove disable-lfs-alias

#1 lore raw

PATCH 1/1 package/mpg123: Remove disable-lfs-alias

Bruno, All,

On 2021-07-12 18:30 +0000, gameblabla via buildroot spake thusly:

Quoted 4 lines

From 81b245ab8b14126a1726154542bcef5e56863649 Mon Sep 17 00:00:00 2001
From: Bruno Marie <[email protected]>
Date: Mon, 12 Jul 2021 20:22:35 +0200
Subject: [PATCH 1/1] package/mpg123: Remove disable-lfs-alias

Not sure how you sent your patch, but the mail was completely mangled, and the patch did not apply.

Please, ue 'git send-email' next time, as this sends proper mails that can be applied without error.

Quoted 1 line

disable-lfs-alias causes undefined references for apps that want to link against mpg123.

I expanded the commit log with the reference to the commit that introduced that option, and added an excerpt for the help entry of that option too, to exp[lain that we should not use it.

However, I don't recall having seen any build issue in the autobuilders. What application is failing to link?

Quoted 1 line

Applied to master, thanks.

Regards,
Yann E. MORIN.

Quoted 25 lines
---
 package/mpg123/mpg123.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/mpg123/mpg123.mk +1 -2
index 9aa9cd1c10..7362db2138 100644
@@ -7,7 +7,7 @@
 MPG123_VERSION = 1.25.15
 MPG123_SOURCE = mpg123-$(MPG123_VERSION).tar.bz2
 MPG123_SITE = http://downloads.sourceforge.net/project/mpg123/mpg123/$(MPG123_VERSION)
-MPG123_CONF_OPTS = --disable-lfs-alias
+MPG123_CONF_OPTS =
 MPG123_INSTALL_STAGING = YES
 MPG123_LICENSE = LGPL-2.1
 MPG123_LICENSE_FILES = COPYING
--

2.32.0

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#2 lore raw
Quoted 21 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Yann" == Yann E MORIN <[email protected]> writes:

Bruno, All,
On 2021-07-12 18:30 +0000, gameblabla via buildroot spake thusly:

Quoted 4 lines

From 81b245ab8b14126a1726154542bcef5e56863649 Mon Sep 17 00:00:00 2001
From: Bruno Marie <[email protected]>
Date: Mon, 12 Jul 2021 20:22:35 +0200
Subject: [PATCH 1/1] package/mpg123: Remove disable-lfs-alias

Not sure how you sent your patch, but the mail was completely mangled, and the patch did not apply.

Please, ue 'git send-email' next time, as this sends proper mails that can be applied without error.

Quoted 1 line

disable-lfs-alias causes undefined references for apps that want to link against mpg123.

I expanded the commit log with the reference to the commit that introduced that option, and added an excerpt for the help entry of that option too, to exp[lain that we should not use it.

Quoted 6 lines

However, I don't recall having seen any build issue in the autobuilders. What application is failing to link?

Quoted 1 line

Applied to master, thanks.

Committed to 2021.02.x and 2021.05.x, thanks.

Signature · 5 lines
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
[email protected]
http://lists.busybox.net/mailman/listinfo/buildroot