Skip to contentSkip to conversation

net: phy: Fix data type in DP83822 dp8382x_disable_wol()

PATCH Applied Marek Vasut 4 participants 4 messages Jul 17, 2021 – Jul 18, 2021

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net: phy: Fix data type in DP83822 dp8382x_disable_wol()

The last argument of phy_clear_bits_mmd(..., u16 val); is u16 and not int, just inline the value into the function call arguments.

No functional change.

Cc Andrew Lunn <[email protected]>
Cc Florian Fainelli <[email protected]>
Cc David S. Miller <[email protected]>
---
 drivers/net/phy/dp83822.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)
drivers/net/phy/dp83822.c +3 -5
index f7a2ec150e54..211b5476a6f5 100644
@@ -326,11 +326,9 @@ static irqreturn_t dp83822_handle_interrupt(struct phy_device *phydev)
 
 static int dp8382x_disable_wol(struct phy_device *phydev)
 {
-	int value = DP83822_WOL_EN | DP83822_WOL_MAGIC_EN |
-		    DP83822_WOL_SECURE_ON;
-
-	return phy_clear_bits_mmd(phydev, DP83822_DEVADDR,
-				  MII_DP83822_WOL_CFG, value);
+	return phy_clear_bits_mmd(phydev, DP83822_DEVADDR, MII_DP83822_WOL_CFG,
+				  DP83822_WOL_EN | DP83822_WOL_MAGIC_EN |
+				  DP83822_WOL_SECURE_ON);
 }
 
 static int dp83822_read_status(struct phy_device *phydev)
Signature · 1 line
2.30.2
maintainer Reviewed-by on v1 1/1
#2 lore raw
In reply to Marek Vasut
Quoted 4 lines · Marek Vasut

The last argument of phy_clear_bits_mmd(..., u16 val); is u16 and not int, just inline the value into the function call arguments.

No functional change.

I don't think there is an overflow issue here, so this can go into net-next. The subject should reflect this, Subject: [PATCH net-next] ...

Thanks for splitting it into a standalone patch.

Quoted 4 lines
Cc Andrew Lunn <[email protected]>
Cc Florian Fainelli <[email protected]>
Cc David S. Miller <[email protected]>

Andrew

#3 lore raw
In reply to Marek Vasut
This patch was applied to netdev/net-next.git (refs/heads/master):

Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

Quoted 11 lines · On Sat, 17 Jul 2021 14:32:49 +0200 you wrote:

The last argument of phy_clear_bits_mmd(..., u16 val); is u16 and not int, just inline the value into the function call arguments.

No functional change.

Cc Andrew Lunn <[email protected]>
Cc Florian Fainelli <[email protected]>
Cc David S. Miller <[email protected]>

[...]

Here is the summary with links:
- net: phy: Fix data type in DP83822 dp8382x_disable_wol()

    https://git.kernel.org/netdev/net-next/c/0d6835ffe50c

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html