Skip to contentSkip to conversation

package/libtirpc: fix rpc.h install path

PATCH New James Hilliard 4 participants 4 messages Jul 17, 2021

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/libtirpc: fix rpc.h install path

When libtirpc installs rpc.h with autoconf it installs it to:
$(HOST_DIR)/include/tirpc/rpc/rpc.h

As this is the expected path we need to do the same.

This should fix the previous attempt at fixing host-nfs-utils:
b991962993357092625e5b18d8203acd1e9b8b1f

Fixes:
http://autobuild.buildroot.net/results/990/990b5e59bacea855c8fce4abb0902bc72422c067

Cc Fabrice Fontaine <[email protected]>
---
 package/libtirpc/libtirpc.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/libtirpc/libtirpc.mk +1 -1
index 8cdc453cd4..fd62ab1f85 100644
@@ -21,7 +21,7 @@ LIBTIRPC_CONF_ENV = CFLAGS="$(TARGET_CFLAGS) -DGQ"
 LIBTIRPC_CONF_OPTS = --disable-gssapi
 
 define HOST_LIBTIRPC_INSTALL_CMDS
-	$(INSTALL) -D -m 0644 $(@D)/tirpc/rpc/rpc.h $(HOST_DIR)/include/rpc/rpc.h
+	$(INSTALL) -D -m 0644 $(@D)/tirpc/rpc/rpc.h $(HOST_DIR)/include/tirpc/rpc/rpc.h
 	$(INSTALL) -D -m 0644 $(@D)/tirpc/rpc/types.h $(HOST_DIR)/include/rpc/types.h
 	$(INSTALL) -D -m 0644 $(@D)/tirpc/netconfig.h $(HOST_DIR)/include/netconfig.h
 endef
Signature · 1 line
2.25.1
#1 lore raw

PATCH 1/1 package/libtirpc: fix rpc.h install path

Dear James,

Le sam. 17 juil. 2021 ? 15:32, James Hilliard
<[email protected]> a ?crit :

Quoted 8 lines

When libtirpc installs rpc.h with autoconf it installs it to:
$(HOST_DIR)/include/tirpc/rpc/rpc.h

As this is the expected path we need to do the same.

This should fix the previous attempt at fixing host-nfs-utils:
b991962993357092625e5b18d8203acd1e9b8b1f

Thanks for trying to fix my mess but I think the issue is raised because rpc.h is not self sufficient.
Here is an extract of
http://autobuild.buildroot.org/results/836/83648a39e960d8f4db0e86ddb48db4b7dd9f91cf//host-nfs-utils-2.5.4/config.log:

configure:19291: checking rpc/rpc.h usability
configure:19291: /usr/bin/gcc -c -O2 -I/home/buildroot/autobuild/run/instance-0/output-1/host/include -I/home/buildroot/autobuild/run/instance-0/output-1/host/include -D_GNU_SOURCE conftest.c >&5
In file included from conftest.c:70:0:
/home/buildroot/autobuild/run/instance-0/output-1/host/include/rpc/rpc.h:70:61:
fatal error: rpc/rpcb_clnt.h: No such file or directory

 #include <rpc/rpcb_clnt.h> /* rpcbind interface functions */
                                                             ^

I sent a new serie here:
https://patchwork.ozlabs.org/project/buildroot/list/?series=253968

Quoted 24 lines

Fixes:
http://autobuild.buildroot.net/results/990/990b5e59bacea855c8fce4abb0902bc72422c067

Cc Fabrice Fontaine <[email protected]>
---
 package/libtirpc/libtirpc.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/libtirpc/libtirpc.mk +1 -2
index 8cdc453cd4..fd62ab1f85 100644
@@ -21,7 +21,7 @@ LIBTIRPC_CONF_ENV = CFLAGS="$(TARGET_CFLAGS) -DGQ"
 LIBTIRPC_CONF_OPTS = --disable-gssapi
 
 define HOST_LIBTIRPC_INSTALL_CMDS
-       $(INSTALL) -D -m 0644 $(@D)/tirpc/rpc/rpc.h $(HOST_DIR)/include/rpc/rpc.h
+       $(INSTALL) -D -m 0644 $(@D)/tirpc/rpc/rpc.h $(HOST_DIR)/include/tirpc/rpc/rpc.h
        $(INSTALL) -D -m 0644 $(@D)/tirpc/rpc/types.h $(HOST_DIR)/include/rpc/types.h
        $(INSTALL) -D -m 0644 $(@D)/tirpc/netconfig.h $(HOST_DIR)/include/netconfig.h
 endef
--
Quoted 2 lines

2.25.1

Best Regards,

Fabrice

#2 lore raw

PATCH 1/1 package/libtirpc: fix rpc.h install path

Fabrice, James, All,

On 2021-07-17 15:48 +0200, Fabrice Fontaine spake thusly:

Quoted 6 lines

Le sam. 17 juil. 2021 ? 15:32, James Hilliard
<[email protected]> a ?crit :

Quoted 4 lines

When libtirpc installs rpc.h with autoconf it installs it to:
$(HOST_DIR)/include/tirpc/rpc/rpc.h

Quoted 6 lines
Quoted 4 lines

As this is the expected path we need to do the same.

This should fix the previous attempt at fixing host-nfs-utils:
b991962993357092625e5b18d8203acd1e9b8b1f

Thanks for trying to fix my mess but I think the issue is raised because rpc.h is not self sufficient.

Agreed.

Quoted 11 lines

Here is an extract of
http://autobuild.buildroot.org/results/836/83648a39e960d8f4db0e86ddb48db4b7dd9f91cf//host-nfs-utils-2.5.4/config.log:

configure:19291: checking rpc/rpc.h usability
configure:19291: /usr/bin/gcc -c -O2

(quoted diff) +0 -3
-I/home/buildroot/autobuild/run/instance-0/output-1/host/include
-I/home/buildroot/autobuild/run/instance-0/output-1/host/include
-D_GNU_SOURCE  conftest.c >&5

In file included from conftest.c:70:0:
/home/buildroot/autobuild/run/instance-0/output-1/host/include/rpc/rpc.h:70:61:
fatal error: rpc/rpcb_clnt.h: No such file or directory

Quoted 2 lines
 #include <rpc/rpcb_clnt.h> /* rpcbind interface functions */
                                                             ^

Yup.

Quoted 2 lines

I sent a new serie here:
https://patchwork.ozlabs.org/project/buildroot/list/?series=253968

Ah, good, this is exactly what I was testing here. I'll look at your series, then.

Regards,
Yann E. MORIN.

Quoted 32 lines
Quoted 23 lines

Fixes:
http://autobuild.buildroot.net/results/990/990b5e59bacea855c8fce4abb0902bc72422c067

Cc Fabrice Fontaine <[email protected]>
---
 package/libtirpc/libtirpc.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/libtirpc/libtirpc.mk +1 -2
index 8cdc453cd4..fd62ab1f85 100644
@@ -21,7 +21,7 @@ LIBTIRPC_CONF_ENV = CFLAGS="$(TARGET_CFLAGS) -DGQ"
 LIBTIRPC_CONF_OPTS = --disable-gssapi
 
 define HOST_LIBTIRPC_INSTALL_CMDS
-       $(INSTALL) -D -m 0644 $(@D)/tirpc/rpc/rpc.h $(HOST_DIR)/include/rpc/rpc.h
+       $(INSTALL) -D -m 0644 $(@D)/tirpc/rpc/rpc.h $(HOST_DIR)/include/tirpc/rpc/rpc.h
        $(INSTALL) -D -m 0644 $(@D)/tirpc/rpc/types.h $(HOST_DIR)/include/rpc/types.h
        $(INSTALL) -D -m 0644 $(@D)/tirpc/netconfig.h $(HOST_DIR)/include/netconfig.h
 endef
--
Quoted 2 lines

2.25.1

Best Regards,

Fabrice
_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#3 lore raw

PATCH 1/1 package/libtirpc: fix rpc.h install path

In reply to Fabrice Fontaine

Hi all,

Quoted 25 lines

Dear James,

Le sam. 17 juil. 2021 ? 15:32, James Hilliard
<[email protected]> a ?crit :

Quoted 7 lines

When libtirpc installs rpc.h with autoconf it installs it to:
$(HOST_DIR)/include/tirpc/rpc/rpc.h

As this is the expected path we need to do the same.

This should fix the previous attempt at fixing host-nfs-utils:
b991962993357092625e5b18d8203acd1e9b8b1f

Thanks for trying to fix my mess but I think the issue is raised because rpc.h is not self sufficient.
Here is an extract of
http://autobuild.buildroot.org/results/836/83648a39e960d8f4db0e86ddb48db4b7dd9f91cf//host-nfs-utils-2.5.4/config.log:

configure:19291: checking rpc/rpc.h usability
configure:19291: /usr/bin/gcc -c -O2

(quoted diff) +0 -3
-I/home/buildroot/autobuild/run/instance-0/output-1/host/include
-I/home/buildroot/autobuild/run/instance-0/output-1/host/include
-D_GNU_SOURCE  conftest.c >&5

In file included from conftest.c:70:0:
/home/buildroot/autobuild/run/instance-0/output-1/host/include/rpc/rpc.h:70:61:
fatal error: rpc/rpcb_clnt.h: No such file or directory

Quoted 4 lines
 #include <rpc/rpcb_clnt.h> /* rpcbind interface functions */
                                                             ^

I sent a new serie here:
https://patchwork.ozlabs.org/project/buildroot/list/?series=253968

Yes, this was a better approach, glad it was merged thank!

Kind regards,
Petr