Skip to contentSkip to conversation

Revert "package/libtirpc: install rpc.h"

PATCH New Fabrice Fontaine 2 participants 4 messages Jul 17, 2021

lore
Share & tools
lore
#0 lore raw

PATCH 1/3 Revert "package/libtirpc: install rpc.h"

This reverts commit b991962993357092625e5b18d8203acd1e9b8b1f.

---
 package/libtirpc/libtirpc.mk | 1 -
 1 file changed, 1 deletion(-)
package/libtirpc/libtirpc.mk +0 -1
index 8cdc453cd4..2678c144e9 100644
@@ -21,7 +21,6 @@ LIBTIRPC_CONF_ENV = CFLAGS="$(TARGET_CFLAGS) -DGQ"
 LIBTIRPC_CONF_OPTS = --disable-gssapi
 
 define HOST_LIBTIRPC_INSTALL_CMDS
-	$(INSTALL) -D -m 0644 $(@D)/tirpc/rpc/rpc.h $(HOST_DIR)/include/rpc/rpc.h
 	$(INSTALL) -D -m 0644 $(@D)/tirpc/rpc/types.h $(HOST_DIR)/include/rpc/types.h
 	$(INSTALL) -D -m 0644 $(@D)/tirpc/netconfig.h $(HOST_DIR)/include/netconfig.h
 endef
Signature · 1 line
2.30.2
#1 lore raw

PATCH 2/3 package/libtirpc: install full host package

Install full host package for rpc.h and all other headers to avoid the following build failure with host-nfs-utils in version 2.5.4 raised since commit 0ce30de72fb303768c5865949b8ce9260d0c43f5:

checking rpc/rpc.h usability... no
checking rpc/rpc.h presence... no
checking for rpc/rpc.h... no
configure: error: Header file rpc/rpc.h not found - maybe try building with --enable-tirpc

This build failure is raised by
http://git.linux-nfs.org/?p=steved/nfs-utils.git;a=commit;h=be7365239abf8556773b063730621967b9971708

Fixes:
- http://autobuild.buildroot.org/results/a5eaf19f58729c4c00a2131b6a0c378c0fc0effb

---
 package/libtirpc/libtirpc.mk | 9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)
package/libtirpc/libtirpc.mk +2 -7
index 2678c144e9..31be113965 100644
@@ -19,12 +19,7 @@ LIBTIRPC_AUTORECONF = YES
 LIBTIRPC_CONF_ENV = CFLAGS="$(TARGET_CFLAGS) -DGQ"
 
 LIBTIRPC_CONF_OPTS = --disable-gssapi
-
-define HOST_LIBTIRPC_INSTALL_CMDS
-	$(INSTALL) -D -m 0644 $(@D)/tirpc/rpc/types.h $(HOST_DIR)/include/rpc/types.h
-	$(INSTALL) -D -m 0644 $(@D)/tirpc/netconfig.h $(HOST_DIR)/include/netconfig.h
-endef
+HOST_LIBTIRPC_CONF_OPTS = --disable-gssapi
 
 $(eval $(autotools-package))
-# We are only copying headers; no need for the autotools infrastructure
-$(eval $(host-generic-package))
+$(eval $(host-autotools-package))
Signature · 1 line
2.30.2
#2 lore raw

PATCH 3/3 package/nfs-utils: fix build with libtirpc

In reply to Fabrice Fontaine

Help nfs-utils to find the path of libtirpc

Fixes:
- http://autobuild.buildroot.org/results/a5eaf19f58729c4c00a2131b6a0c378c0fc0effb

---
 package/nfs-utils/nfs-utils.mk | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
package/nfs-utils/nfs-utils.mk +3 -2
index 4e4cf93587..d36b3f2def 100644
@@ -24,6 +24,7 @@ NFS_UTILS_CONF_OPTS = \
 	--with-rpcgen=$(HOST_DIR)/bin/rpcgen
 
 HOST_NFS_UTILS_CONF_OPTS = \
+	--enable-tirpc \
 	--disable-nfsv4 \
 	--disable-nfsv41 \
 	--disable-gss \
@@ -32,9 +33,9 @@ HOST_NFS_UTILS_CONF_OPTS = \
 	--without-tcp-wrappers \
 	--with-statedir=/run/nfs \
 	--disable-caps \
-	--disable-tirpc \
 	--without-systemd \
-	--with-rpcgen=internal
+	--with-rpcgen=internal \
+	--with-tirpcinclude=$(HOST_DIR)/include/tirpc
 HOST_NFS_UTILS_DEPENDENCIES = host-pkgconf host-libtirpc
 
 NFS_UTILS_TARGETS_$(BR2_PACKAGE_NFS_UTILS_RPCDEBUG) += usr/sbin/rpcdebug
Signature · 1 line
2.30.2
#3 lore raw

PATCH 1/3 Revert "package/libtirpc: install rpc.h"

In reply to Fabrice Fontaine

Fabrice, All,

Series of three patches: applied to master, thanks.

Regards,
Yann E. MORIN.

On 2021-07-17 15:44 +0200, Fabrice Fontaine spake thusly:

Quoted 26 lines

This reverts commit b991962993357092625e5b18d8203acd1e9b8b1f.

---
 package/libtirpc/libtirpc.mk | 1 -
 1 file changed, 1 deletion(-)
package/libtirpc/libtirpc.mk +0 -1
index 8cdc453cd4..2678c144e9 100644
@@ -21,7 +21,6 @@ LIBTIRPC_CONF_ENV = CFLAGS="$(TARGET_CFLAGS) -DGQ"
 LIBTIRPC_CONF_OPTS = --disable-gssapi
 
 define HOST_LIBTIRPC_INSTALL_CMDS
-	$(INSTALL) -D -m 0644 $(@D)/tirpc/rpc/rpc.h $(HOST_DIR)/include/rpc/rpc.h
 	$(INSTALL) -D -m 0644 $(@D)/tirpc/rpc/types.h $(HOST_DIR)/include/rpc/types.h
 	$(INSTALL) -D -m 0644 $(@D)/tirpc/netconfig.h $(HOST_DIR)/include/netconfig.h
 endef
Signature · 6 lines
2.30.2

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'