Skip to contentSkip to conversation

igc: Remove media type checking on the PHY initialization

PATCH New Sasha Neftin 2 participants 2 messages Jul 18, 2021 – Aug 4, 2021

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 igc: Remove media type checking on the PHY initialization

i225 devices have only copper phy media type. There is no point in checking phy media type during the phy initialization.
This patch comes to clean up these pointless checkings.

---
 drivers/net/ethernet/intel/igc/igc_base.c | 5 -----
 1 file changed, 5 deletions(-)
drivers/net/ethernet/intel/igc/igc_base.c +0 -5
index 93feed4f7f1c..260b7b17bbcc 100644
@@ -158,11 +158,6 @@ static s32 igc_init_phy_params_base(struct igc_hw *hw)
 	struct igc_phy_info *phy = &hw->phy;
 	s32 ret_val = 0;
 
-	if (hw->phy.media_type != igc_media_type_copper) {
-		phy->type = igc_phy_none;
-		goto out;
-	}
-
 	phy->autoneg_mask	= AUTONEG_ADVERTISE_SPEED_DEFAULT_2500;
 	phy->reset_delay_us	= 100;
 
Signature · 1 line
2.25.1
#1 lore raw

PATCH 1/1 igc: Remove media type checking on the PHY initialization

Quoted 9 lines · Sasha Neftin

i225 devices have only copper phy media type. There is no point in checking phy media type during the phy initialization.
This patch comes to clean up these pointless checkings.

---
  drivers/net/ethernet/intel/igc/igc_base.c | 5 -----
  1 file changed, 5 deletions(-)