Skip to contentSkip to conversation

package/kodi: enable optional vaapi support also for OpenGLES

PATCH New Bernd Kuhls 2 participants 2 messages Jun 20, 2021 – Jul 18, 2021

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/kodi: enable optional vaapi support also for OpenGLES

Upstream commit
https://github.com/xbmc/xbmc/commit/c638987dd8181765f975763cb643d6869a3f661b

removed the dependency to x11 support in libva keeping only libdrm as dependency. This commit will enable the usage of libva with Kodi's OpenGLES render system.

---
 Config.in.legacy       |  8 ++++++++
 package/kodi/Config.in | 18 ------------------
 package/kodi/kodi.mk   |  5 ++---
 3 files changed, 10 insertions(+), 21 deletions(-)
Config.in.legacy +8 -0
index a0c1a6898f..c10f9c5223 100644
@@ -146,6 +146,14 @@ endif
 
 comment "Legacy options removed in 2021.05"
 
+config BR2_PACKAGE_KODI_LIBVA
+	bool "kodi option to add libva support removed"
+	select BR2_LEGACY
+	help
+	  Kodi still has support for libva if the package is enabled but
+	  the kodi-specific dependencies limiting libva support to non-
+	  OPENGLES platforms were removed including this option.
+
 config BR2_PACKAGE_UDISKS_LVM2
 	bool "udisks lvm2 support removed"
 	select BR2_LEGACY
package/kodi/Config.in +0 -18
index f4cfc6380c..f702ae841a 100644
@@ -238,24 +238,6 @@ config BR2_PACKAGE_KODI_LIBUSB
 	help
 	  Enable libusb support.
 
-config BR2_PACKAGE_KODI_LIBVA
-	bool "va"
-	depends on \
-		BR2_PACKAGE_KODI_PLATFORM_SUPPORTS_GBM || \
-		BR2_PACKAGE_KODI_PLATFORM_SUPPORTS_WAYLAND || \
-		(BR2_PACKAGE_KODI_PLATFORM_SUPPORTS_X11 && \
-			BR2_PACKAGE_KODI_RENDER_SYSTEM_GL)
-	select BR2_PACKAGE_LIBVA
-	help
-	  Enable libva support.
-
-comment "libva support needs platform 'gbm', 'Wayland' or 'X11/OpenGL'"
-	depends on \
-		!BR2_PACKAGE_KODI_PLATFORM_SUPPORTS_GBM && \
-		!BR2_PACKAGE_KODI_PLATFORM_SUPPORTS_WAYLAND && \
-		(!BR2_PACKAGE_KODI_PLATFORM_SUPPORTS_X11 || \
-			!BR2_PACKAGE_KODI_RENDER_SYSTEM_GL)
-
 config BR2_PACKAGE_KODI_LIBVDPAU
 	bool "vdpau"
 	depends on BR2_PACKAGE_KODI_PLATFORM_X11 && \
package/kodi/kodi.mk +2 -3
index a5c9db1d7e..6f020b58b8 100644
@@ -315,9 +315,8 @@ ifeq ($(BR2_PACKAGE_LIRC_TOOLS),y)
 KODI_DEPENDENCIES += lirc-tools
 endif
 
-# kodi needs libva & libva-glx
-ifeq ($(BR2_PACKAGE_KODI_LIBVA)$(BR2_PACKAGE_MESA3D_DRI_DRIVER),yy)
-KODI_DEPENDENCIES += mesa3d libva
+ifeq ($(BR2_PACKAGE_LIBVA),y)
+KODI_DEPENDENCIES += libva
 KODI_CONF_OPTS += -DENABLE_VAAPI=ON
 else
 KODI_CONF_OPTS += -DENABLE_VAAPI=OFF
Signature · 1 line
2.30.2
#1 lore raw

PATCH 1/1 package/kodi: enable optional vaapi support also for OpenGLES

Quoted 7 lines · On Sun, 20 Jun 2021 11:09:00 +0200 Bernd Kuhls <[email protected]> wrote:

Upstream commit
https://github.com/xbmc/xbmc/commit/c638987dd8181765f975763cb643d6869a3f661b

removed the dependency to x11 support in libva keeping only libdrm as dependency. This commit will enable the usage of libva with Kodi's OpenGLES render system.

Quoted 6 lines
---
 Config.in.legacy       |  8 ++++++++
 package/kodi/Config.in | 18 ------------------
 package/kodi/kodi.mk   |  5 ++---
 3 files changed, 10 insertions(+), 21 deletions(-)

Applied to master, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com