Skip to contentSkip to conversation

package/cegui: disable Python SWIG extension modules when OpenGL renderer is disabled

PATCH New Bartosz Bilas 2 participants 4 messages Jun 15, 2021 – Jul 19, 2021

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/cegui: disable Python SWIG extension modules when OpenGL renderer is disabled

Those modules need OpenGL renderer so disable them when it's missing.

Fixes:
- http://autobuild.buildroot.net/results/592/592fcffb226c8b44ada5fa3cdb8ab15c627f29dc/
- http://autobuild.buildroot.net/results/9ad/9ad768b7e2a3c59833e03986c245f2f4b5d25dcd/

and more...

---
 package/cegui/cegui.mk | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
package/cegui/cegui.mk +2 -1
index 747ebbb953..c5ff45818e 100644
@@ -38,7 +38,8 @@ CEGUI_CONF_OPTS += -DCEGUI_USE_EPOXY=ON -DCEGUI_USE_GLEW=OFF \
 else
 CEGUI_CONF_OPTS += -DCEGUI_USE_EPOXY=OFF -DCEGUI_USE_GLEW=OFF \
 	-DCEGUI_BUILD_RENDERER_OPENGL=OFF \
-	-DCEGUI_BUILD_RENDERER_OPENGL3=OFF
+	-DCEGUI_BUILD_RENDERER_OPENGL3=OFF \
+	-DCEGUI_BUILD_PYTHON_MODULES_SWIG=OFF
 endif
 
 ifeq ($(BR2_PACKAGE_EXPAT),y)
Signature · 1 line
2.32.0
#1 lore raw

PATCH 1/1 package/cegui: disable Python SWIG extension modules when OpenGL renderer is disabled

Hello Bartosz,

Quoted 18 lines · On Tue, 15 Jun 2021 21:45:36 +0200 Bartosz Bilas <[email protected]>…

Those modules need OpenGL renderer so disable them when it's missing.

Fixes:
- http://autobuild.buildroot.net/results/592/592fcffb226c8b44ada5fa3cdb8ab15c627f29dc/
- http://autobuild.buildroot.net/results/9ad/9ad768b7e2a3c59833e03986c245f2f4b5d25dcd/

and more...

---
 package/cegui/cegui.mk | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
package/cegui/cegui.mk +0 -0
index 747ebbb953..c5ff45818e 100644

package/cegui/cegui.mk CEGUI_CONF_OPTS += -DCEGUI_USE_EPOXY=ON -DCEGUI_USE_GLEW=OFF \ · line 42

Quoted 6 lines
package/cegui/cegui.mk +2 -1
@@ -38,7 +38,8 @@ CEGUI_CONF_OPTS += -DCEGUI_USE_EPOXY=ON -DCEGUI_USE_GLEW=OFF \
 else
 CEGUI_CONF_OPTS += -DCEGUI_USE_EPOXY=OFF -DCEGUI_USE_GLEW=OFF \
 	-DCEGUI_BUILD_RENDERER_OPENGL=OFF \
-	-DCEGUI_BUILD_RENDERER_OPENGL3=OFF
+	-DCEGUI_BUILD_RENDERER_OPENGL3=OFF \
+	-DCEGUI_BUILD_PYTHON_MODULES_SWIG=OFF

Thanks for the patch, but shouldn't we set -DCEGUI_BUILD_PYTHON_MODULES_SWIG=OFF unconditionally? Indeed, there is nothing in cegui.mk that ensures that Python/SWIG is available prior to the cegui build, i.e there is nothing in place to optionally build this Python SWIG extension.

So if nobody uses it, we should rather disable it unconditionally. Do you agree ?

Thanks a lot,

Thomas

Signature · 3 lines
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#2 lore raw

PATCH 1/1 package/cegui: disable Python SWIG extension modules when OpenGL renderer is disabled

Hello Thomas,

Quoted 35 lines · Thomas Petazzoni

Hello Bartosz,

Quoted 18 lines · On Tue, 15 Jun 2021 21:45:36 +0200 Bartosz Bilas <[email protected]>…

Those modules need OpenGL renderer so disable them when it's missing.

Fixes:
- http://autobuild.buildroot.net/results/592/592fcffb226c8b44ada5fa3cdb8ab15c627f29dc/
- http://autobuild.buildroot.net/results/9ad/9ad768b7e2a3c59833e03986c245f2f4b5d25dcd/

   and more...
---
  package/cegui/cegui.mk | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)
package/cegui/cegui.mk +0 -0
index 747ebbb953..c5ff45818e 100644

package/cegui/cegui.mk CEGUI_CONF_OPTS += -DCEGUI_USE_EPOXY=ON -DCEGUI_USE_GLEW=OFF \ · line 42

Quoted 6 lines
package/cegui/cegui.mk +2 -1
@@ -38,7 +38,8 @@ CEGUI_CONF_OPTS += -DCEGUI_USE_EPOXY=ON -DCEGUI_USE_GLEW=OFF \
  else
  CEGUI_CONF_OPTS += -DCEGUI_USE_EPOXY=OFF -DCEGUI_USE_GLEW=OFF \
  	-DCEGUI_BUILD_RENDERER_OPENGL=OFF \
-	-DCEGUI_BUILD_RENDERER_OPENGL3=OFF
+	-DCEGUI_BUILD_RENDERER_OPENGL3=OFF \
+	-DCEGUI_BUILD_PYTHON_MODULES_SWIG=OFF

Thanks for the patch, but shouldn't we set -DCEGUI_BUILD_PYTHON_MODULES_SWIG=OFF unconditionally? Indeed, there is nothing in cegui.mk that ensures that Python/SWIG is available prior to the cegui build, i.e there is nothing in place to optionally build this Python SWIG extension.

Quoted 2 lines

So if nobody uses it, we should rather disable it unconditionally. Do you agree ?

Yup, let's do that. Should I send v2 or will you do that during committing?

Best
Bartek

Quoted 4 lines

Thanks a lot,

Thomas

#3 lore raw

PATCH 1/1 package/cegui: disable Python SWIG extension modules when OpenGL renderer is disabled

Quoted 4 lines · On Mon, 19 Jul 2021 10:08:01 +0200 Bartosz Bi?as <[email protected]>…
Quoted 2 lines

So if nobody uses it, we should rather disable it unconditionally. Do you agree ?

Yup, let's do that. Should I send v2 or will you do that during committing?

If you could send a v2, it would be great :)

Thanks a lot!

Thomas

Signature · 3 lines
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com