MIPI DSI driver enhancements
Subsystems (3)
cover MIPI DSI driver enhancements
*** BLURB HERE ***
Lee Shawn C (5):
drm/i915/dsi: send correct gpio_number on gen11 platform drm/i915/jsl: program DSI panel GPIOs drm/i915/dsi: wait for header and payload credit available drm/i915/dsi: refine send MIPI DCS command sequence drm/i915: Get proper min cdclk if vDSC enabled
drivers/gpu/drm/i915/display/icl_dsi.c | 50 ++++++++++---------- drivers/gpu/drm/i915/display/intel_cdclk.c | 12 +++++ drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 46 +++++++++++++++++- drivers/gpu/drm/i915/i915_reg.h | 10 ++++ 4 files changed, 90 insertions(+), 28 deletions(-)
Signature · 6 lines
2.17.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 1/5 drm/i915/dsi: send correct gpio_number on gen11 platform
Transfer "gpio_nunmber" instead of "gpio_index" while doing gpio configuration in icl_exec_gpio().
--- drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/display/intel_dsi_vbt.c +1 -1
@@ -381,7 +381,7 @@ static const u8 *mipi_exec_gpio(struct intel_dsi *intel_dsi, const u8 *data) value = *data++ &1 ;if (DISPLAY_VER (dev_priv) >=11 ) -icl_exec_gpio (dev_priv, gpio_source, gpio_index, value); +icl_exec_gpio (dev_priv, gpio_source, gpio_number, value);else if (IS_VALLEYVIEW (dev_priv))vlv_exec_gpio (dev_priv, gpio_source, gpio_number, value);else if (IS_CHERRYVIEW (dev_priv))
Signature · 6 lines
2.17.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 2/5 drm/i915/jsl: program DSI panel GPIOs
In reply to Lee Shawn CDSI driver should have its own implementation to toggle gpio pins based on GPIO info coming from VBT sequences.
--- drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 44 +++++++++++++++++++- drivers/gpu/drm/i915/i915_reg.h | 10 +++++ 2 files changed, 53 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/display/intel_dsi_vbt.c +43 -1
@@ -43,6 +43,7 @@#include "intel_display_types.h" #include "intel_dsi.h" #include "intel_sideband.h" +#include "intel_de.h" #define MIPI_TRANSFER_MODE_SHIFT 0#define MIPI_VIRTUAL_CHANNEL_SHIFT 1
@@ -354,7 +355,48 @@ static void bxt_exec_gpio(struct drm_i915_private *dev_priv,static void icl_exec_gpio (struct drm_i915_private *dev_priv,u8 gpio_source,u8 gpio_index,bool value) { -drm_dbg_kms (&dev_priv->drm,"Skipping ICL GPIO element execution\n" ); +u32 val; + +switch (gpio_index) { +case ICL_GPIO_L_VDDEN_1 : + val =intel_de_read (dev_priv,ICP_PP_CONTROL (1 )); +if (value) + val |=PWR_STATE_TARGET ; +else + val &= ~PWR_STATE_TARGET ; +intel_de_write (dev_priv,ICP_PP_CONTROL (1 ), val); +break ; +case ICL_GPIO_L_BKLTEN_1 : + val =intel_de_read (dev_priv,ICP_PP_CONTROL (1 )); +if (value) + val |=BACKLIGHT_ENABLE ; +else + val &= ~BACKLIGHT_ENABLE ; +intel_de_write (dev_priv,ICP_PP_CONTROL (1 ), val); +break ; +case ICL_GPIO_DDPA_CTRLCLK_1 : + val =intel_de_read (dev_priv,GPIO (1 )); +if (value) + val |=GPIO_CLOCK_VAL_OUT ; +else + val &= ~GPIO_CLOCK_VAL_OUT ; + val |=GPIO_CLOCK_DIR_MASK |GPIO_CLOCK_DIR_OUT |GPIO_CLOCK_VAL_MASK ; +intel_de_write (dev_priv,GPIO (1 ), val); +break ; +case ICL_GPIO_DDPA_CTRLDATA_1 : + val =intel_de_read (dev_priv,GPIO (1 )); +if (value) + val |=GPIO_DATA_VAL_OUT ; +else + val &= ~GPIO_DATA_VAL_OUT ; + val |=GPIO_DATA_DIR_MASK |GPIO_DATA_DIR_OUT |GPIO_DATA_VAL_MASK ; +intel_de_write (dev_priv,GPIO (1 ), val); +break ; +default : +/* TODO: Add support for remaining GPIOs */ +DRM_ERROR ("Invalid GPIO number (%d) from VBT\n" , gpio_index); +break ; + } }static const u8 *mipi_exec_gpio (struct intel_dsi *intel_dsi,const u8 *data)
drivers/gpu/drm/i915/i915_reg.h +10 -0
@@ -5143,6 +5143,16 @@ enum {#define _PP_STATUS 0x61200#define PP_STATUS (pps_idx) _MMIO_PPS(pps_idx, _PP_STATUS)#define PP_ON REG_BIT(31) + +#define _PP_CONTROL_1 0xc7204 +#define _PP_CONTROL_2 0xc7304 +#define ICP_PP_CONTROL (x) _MMIO(((x) == 1) ? _PP_CONTROL_1 : \ + _PP_CONTROL_2) +#define POWER_CYCLE_DELAY_MASK REG_GENMASK(8, 4) +#define VDD_OVERRIDE_FORCE REG_BIT(3) +#define BACKLIGHT_ENABLE REG_BIT(2) +#define PWR_DOWN_ON_RESET REG_BIT(1) +#define PWR_STATE_TARGET REG_BIT(0)/* * Indicates that all dependencies of the panel are on: *
Signature · 6 lines
2.17.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 3/5 drm/i915/dsi: wait for header and payload credit available
In reply to Lee Shawn CDriver should wait for free header or payload buffer in FIFO. It would be good to wait a while for HW to release credit before give it up to write to HW. Without sending initailize command sets completely. It would caused MIPI display can't light up properly.
--- drivers/gpu/drm/i915/display/icl_dsi.c | 40 ++++++++++++-------------- 1 file changed, 19 insertions(+), 21 deletions(-)
drivers/gpu/drm/i915/display/icl_dsi.c +19 -21
@@ -54,20 +54,28 @@ static int payload_credits_available(struct drm_i915_private *dev_priv, >> FREE_PLOAD_CREDIT_SHIFT; } -static void wait_for_header_credits (struct drm_i915_private *dev_priv, -enum transcoder dsi_trans) +static bool wait_for_header_credits (struct drm_i915_private *dev_priv, +enum transcoder dsi_trans,int hdr_credit) {if (wait_for_us (header_credits_available (dev_priv, dsi_trans) >= -MAX_HEADER_CREDIT ,100 )) + hdr_credit,100 )) {drm_err (&dev_priv->drm,"DSI header credits not released\n" ); +return false; + } + +return true; } -static void wait_for_payload_credits (struct drm_i915_private *dev_priv, -enum transcoder dsi_trans) +static bool wait_for_payload_credits (struct drm_i915_private *dev_priv, +enum transcoder dsi_trans,int payld_credit) {if (wait_for_us (payload_credits_available (dev_priv, dsi_trans) >= -MAX_PLOAD_CREDIT ,100 )) + payld_credit,100 )) {drm_err (&dev_priv->drm,"DSI payload credits not released\n" ); +return false; + } + +return true; }static enum transcoder dsi_port_to_transcoder (enum port port)
@@ -90,8 +98,8 @@ static void wait_for_cmds_dispatched_to_panel(struct intel_encoder *encoder)/* wait for header/payload credits to be released */ for_each_dsi_port (port, intel_dsi->ports) { dsi_trans =dsi_port_to_transcoder (port); -wait_for_header_credits (dev_priv, dsi_trans); -wait_for_payload_credits (dev_priv, dsi_trans); +wait_for_header_credits (dev_priv, dsi_trans,MAX_HEADER_CREDIT ); +wait_for_payload_credits (dev_priv, dsi_trans,MAX_PLOAD_CREDIT ); }/* send nop DCS command */
@@ -108,7 +116,7 @@ static void wait_for_cmds_dispatched_to_panel(struct intel_encoder *encoder)/* wait for header credits to be released */ for_each_dsi_port (port, intel_dsi->ports) { dsi_trans =dsi_port_to_transcoder (port); -wait_for_header_credits (dev_priv, dsi_trans); +wait_for_header_credits (dev_priv, dsi_trans,MAX_HEADER_CREDIT ); }/* wait for LP TX in progress bit to be cleared */
@@ -126,18 +134,13 @@ static bool add_payld_to_queue(struct intel_dsi_host *host, const u8 *data,struct intel_dsi *intel_dsi = host->intel_dsi;struct drm_i915_private *dev_priv =to_i915 (intel_dsi->base.base.dev);enum transcoder dsi_trans =dsi_port_to_transcoder (host->port); -int free_credits;int i, j;for (i =0 ; i < len; i +=4 ) {u32 tmp =0 ; - free_credits =payload_credits_available (dev_priv, dsi_trans); -if (free_credits <1 ) { -drm_err (&dev_priv->drm, -"Payload credit not available\n" ); +if (!wait_for_payload_credits (dev_priv, dsi_trans,1 ))return false; - }for (j =0 ; j <min_t (u32, len - i,4 ); j++) tmp |= *data++ <<8 * j;
@@ -155,15 +158,10 @@ static int dsi_send_pkt_hdr(struct intel_dsi_host *host,struct drm_i915_private *dev_priv =to_i915 (intel_dsi->base.base.dev);enum transcoder dsi_trans =dsi_port_to_transcoder (host->port);u32 tmp; -int free_credits;/* check if header credit available */ - free_credits =header_credits_available (dev_priv, dsi_trans); -if (free_credits <1 ) { -drm_err (&dev_priv->drm, -"send pkt header failed, not enough hdr credits\n" ); +if (!wait_for_header_credits (dev_priv, dsi_trans,1 ))return -1 ; - } tmp =intel_de_read (dev_priv,DSI_CMD_TXHDR (dsi_trans));
Signature · 6 lines
2.17.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 4/5 drm/i915/dsi: refine send MIPI DCS command sequence
In reply to Lee Shawn CAccording to chapter "Sending Commands to the Panel" in bspec #29738 and #49188. If driver try to send DCS long pakcet, we have to program TX payload register at first. And configure TX header HW register later. DSC long packet would not be sent properly if we don't follow this sequence.
--- drivers/gpu/drm/i915/display/icl_dsi.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
drivers/gpu/drm/i915/display/icl_dsi.c +5 -5
@@ -1807,11 +1807,6 @@ static ssize_t gen11_dsi_host_transfer(struct mipi_dsi_host *host,if (msg->flags &MIPI_DSI_MSG_USE_LPM ) enable_lpdt = true; -/* send packet header */ - ret =dsi_send_pkt_hdr (intel_dsi_host, dsi_pkt, enable_lpdt); -if (ret <0 ) -return ret; -/* only long packet contains payload */ if (mipi_dsi_packet_format_is_long (msg->type)) { ret =dsi_send_pkt_payld (intel_dsi_host, dsi_pkt);
@@ -1819,6 +1814,11 @@ static ssize_t gen11_dsi_host_transfer(struct mipi_dsi_host *host,return ret; } +/* send packet header */ + ret =dsi_send_pkt_hdr (intel_dsi_host, dsi_pkt, enable_lpdt); +if (ret <0 ) +return ret; +//TODO: add payload receive code if needed ret =sizeof (dsi_pkt.header) + dsi_pkt.payload_length;
Signature · 6 lines
2.17.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 5/5 drm/i915: Get proper min cdclk if vDSC enabled
In reply to Lee Shawn CVDSC engine can process only 1 pixel per Cd clock. In case VDSC is used and max slice count == 1, max supported pixel clock should be 100% of CD clock. Then do min_cdclk and pixel clock comparison to get proper min cdclk.
--- drivers/gpu/drm/i915/display/intel_cdclk.c | 12 ++++++++++++ 1 file changed, 12 insertions(+)
drivers/gpu/drm/i915/display/intel_cdclk.c +12 -0
@@ -2159,6 +2159,18 @@ int intel_crtc_compute_min_cdclk(const struct intel_crtc_state *crtc_state)/* Account for additional needs from the planes */ min_cdclk =max (intel_planes_min_cdclk (crtc_state), min_cdclk); +/* +* VDSC engine can process only 1 pixel per Cd clock. +* In case VDSC is used and max slice count == 1, +* max supported pixel clock should be 100% of CD clock. +* Then do min_cdclk and pixel clock comparison to get cdclk. +*/ +if (DISPLAY_VER (dev_priv) >=11 && +intel_crtc_has_type (crtc_state,INTEL_OUTPUT_DSI ) && + crtc_state->dsc.compression_enable && + crtc_state->dsc.slice_count ==1 ) + min_cdclk =max (min_cdclk, (int )crtc_state->pixel_rate); +/* * HACK. Currently for TGL platforms we calculate * min_cdclk initially based on pixel_rate divided
Signature · 6 lines
2.17.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH 5/5] drm/i915: Get proper min cdclk if vDSC enabled
Quoted 31 lines
-----Original Message-----
From: Lee, Shawn C <[email protected]>
Sent: Monday, July 19, 2021 12:52 PM
To: [email protected]
Cc: Lee, Shawn C <[email protected]>; Ville Syrjala <[email protected]>; Jani Nikula <[email protected]>; Kulkarni, Vandita <[email protected]>; Chiou, Cooper <[email protected]>; Tseng, William <[email protected]>
Subject: [PATCH 5/5] drm/i915: Get proper min cdclk if vDSC enabledVDSC engine can process only 1 pixel per Cd clock. In case VDSC is used and max slice count == 1, max supported pixel clock should be 100% of CD clock. Then do
min_cdclkand pixel clock comparison to get proper min cdclk.Cc Ville Syrjala <[email protected]>Cc Jani Nikula <[email protected]>Cc Vandita Kulkarni <[email protected]>Cc Cooper Chiou <[email protected]>Cc William Tseng <[email protected]>Signed-off-by Lee Shawn C <[email protected]>--- drivers/gpu/drm/i915/display/intel_cdclk.c | 12 ++++++++++++ 1 file changed, 12 insertions(+)drivers/gpu/drm/i915/display/intel_cdclk.c +0
-0@@ -2159,6 +2159,18 @@ int intel_crtc_compute_min_cdclk(const struct intel_crtc_state *crtc_state)
drivers/gpu/drm/i915/display/intel_cdclk.c int intel_crtc_compute_min_cdclk(const struct · line 2169
Quoted 10 lines
drivers/gpu/drm/i915/display/intel_cdclk.c +7
-0/* Account for additional needs from the planes */ min_cdclk =max (intel_planes_min_cdclk (crtc_state), min_cdclk); +/* +* VDSC engine can process only 1 pixel per Cd clock. +* In case VDSC is used and max slice count == 1, +* max supported pixel clock should be 100% of CD clock. +* Then do min_cdclk and pixel clock comparison to get cdclk. +*/ + if (DISPLAY_VER(dev_priv) >= 11 &&
I think you could just check for dsc enable and slice count ==1.
Also better to have a check if crtc_clock exceeds dev_priv->max_cdclk_freq in dsi_dsc compute_config as well. and return -EINVAL .
-Vandita
Quoted 11 lines
drivers/gpu/drm/i915/display/intel_cdclk.c +5
-0+ intel_crtc_has_type(crtc_state, INTEL_OUTPUT_DSI) && + crtc_state->dsc.compression_enable && + crtc_state->dsc.slice_count == 1) + min_cdclk =max (min_cdclk, (int )crtc_state->pixel_rate); +/* drivers/gpu/drm/i915/display/intel_cdclk.c +0
-1* HACK. Currently for TGL platforms we calculate * min_cdclk initially based on pixel_rate divided -- 2.17.1
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH 5/5] drm/i915: Get proper min cdclk if vDSC enabled
Quoted 25 lines · Vandita Kulkarni
Quoted 25 lines
VDSC engine can process only 1 pixel per Cd clock. In case VDSC is used and max slice count == 1, max supported pixel clock should be 100% of CD clock. Then do
min_cdclkand pixel clock comparison to get proper min cdclk.Cc Ville Syrjala <[email protected]>Cc Jani Nikula <[email protected]>Cc Vandita Kulkarni <[email protected]>Cc Cooper Chiou <[email protected]>Cc William Tseng <[email protected]>Signed-off-by Lee Shawn C <[email protected]>--- drivers/gpu/drm/i915/display/intel_cdclk.c | 12 ++++++++++++ 1 file changed, 12 insertions(+)drivers/gpu/drm/i915/display/intel_cdclk.c +0
-0@@ -2159,6 +2159,18 @@ int intel_crtc_compute_min_cdclk(const struct intel_crtc_state *crtc_state)/* Account for additional needs from the planes */ min_cdclk =max (intel_planes_min_cdclk (crtc_state), min_cdclk);
Quoted 10 lines
drivers/gpu/drm/i915/display/intel_cdclk.c int intel_crtc_compute_min_cdclk(const struct intel_crtc_state *crtc_state) · line 2168
Quoted 7 lines
drivers/gpu/drm/i915/display/intel_cdclk.c +7
-0+/* +* VDSC engine can process only 1 pixel per Cd clock. +* In case VDSC is used and max slice count == 1, +* max supported pixel clock should be 100% of CD clock. +* Then do min_cdclk and pixel clock comparison to get cdclk. +*/ +if (DISPLAY_VER(dev_priv) >= 11 &&I think you could just check for dsc enable and slice count ==1.
DP and eDP would apply the same thing if dsc enabled and sink's dsc slice count ==1. Is that right?
Quoted 5 lines
Also better to have a check if
crtc_clockexceedsdev_priv->max_cdclk_freqindsi_dsccompute_configas well. and return-EINVAL.-Vandita
We should have this checking in dsi_dsc_compute_config() just like DP driver did. What do you think?
if (adjusted_mode->crtc_clock > dev_priv->max_cdclk_freq ||
pipe_config->bigjoiner) {
if (pipe_config->dsc.slice_count < 2) {
drm_dbg_kms(&dev_priv->drm,
"Cannot split stream to use 2 VDSC instances\n");
return -EINVAL;
}
pipe_config->dsc.dsc_split = true;
}Best regards,
Shawn
Quoted 4 lines
Quoted 3 lines
drivers/gpu/drm/i915/display/intel_cdclk.c +3
-0+intel_crtc_has_type (crtc_state,INTEL_OUTPUT_DSI ) && + crtc_state->dsc.compression_enable && + crtc_state->dsc.slice_count == 1)
Quoted 9 lines
Quoted 7 lines
drivers/gpu/drm/i915/display/intel_cdclk.c +2
-0+min_cdclk =max (min_cdclk, (int )crtc_state->pixel_rate); +/* * HACK. Currently for TGL platforms we calculate *
min_cdclkinitially based onpixel_ratedivided
--
2.17.1
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH 5/5] drm/i915: Get proper min cdclk if vDSC enabled
Quoted 49 lines
-----Original Message-----
From: Lee, Shawn C <[email protected]>
Sent: Tuesday, July 20, 2021 8:01 PM
To: Kulkarni, Vandita <[email protected]>; intel- [email protected]
Cc: Ville Syrjala <[email protected]>; Jani Nikula <[email protected]>; Chiou, Cooper <[email protected]>; Tseng, William <[email protected]>
Subject: RE: [PATCH 5/5] drm/i915: Get proper min cdclk if vDSC enabledQuoted 3 lines · Vandita Kulkarni
Quoted 3 lines
VDSC engine can process only 1 pixel per Cd clock. In case VDSC is used and max slice count == 1, max supported pixel clock should be 100%
of CD clock.
Quoted 22 lines
Quoted 22 lines
Then do
min_cdclkand pixel clock comparison to get proper min cdclk.Cc Ville Syrjala <[email protected]>Cc Jani Nikula <[email protected]>Cc Vandita Kulkarni <[email protected]>Cc Cooper Chiou <[email protected]>Cc William Tseng <[email protected]>Signed-off-by Lee Shawn C <[email protected]>--- drivers/gpu/drm/i915/display/intel_cdclk.c | 12 ++++++++++++ 1 file changed, 12 insertions(+)drivers/gpu/drm/i915/display/intel_cdclk.c +0
-0@@ -2159,6 +2159,18 @@ int intel_crtc_compute_min_cdclk(const struct intel_crtc_state *crtc_state)/* Account for additional needs from the planes */ min_cdclk =max (intel_planes_min_cdclk (crtc_state), min_cdclk);Quoted 10 lines
drivers/gpu/drm/i915/display/intel_cdclk.c int intel_crtc_compute_min_cdclk(const struct intel_crtc_state *crtc_state) · line 2168
Quoted 7 lines
drivers/gpu/drm/i915/display/intel_cdclk.c +7
-0+/* +* VDSC engine can process only 1 pixel per Cd clock. +* In case VDSC is used and max slice count == 1, +* max supported pixel clock should be 100% of CD clock. +* Then do min_cdclk and pixel clock comparison to get cdclk. +*/ +if (DISPLAY_VER(dev_priv) >= 11 &&I think you could just check for dsc enable and slice count ==1.
Quoted 3 lines
DP and eDP would apply the same thing if dsc enabled and sink's dsc slice count ==1.
Is that right?
Yes.
Quoted 6 lines
Quoted 2 lines
Also better to have a check if
crtc_clockexceedsdev_priv->max_cdclk_freqin
dsi_dsccompute_configas well.Quoted 3 lines
and return
-EINVAL.-Vandita
Since we do not have bigjoiner support on dsi yet and the check wrt max_cdclk_freq is taken care in intel_crtc_compute_config. I think you can leave this for now. You do not need this clock check again in dsi_compute_config
-Vandita
Quoted 17 lines
Quoted 1 line
We should have this checking in
dsi_dsc_compute_config()just like DP driver did. What do you think?if (adjusted_mode->crtc_clock > dev_priv->max_cdclk_freq || pipe_config->bigjoiner) { if (pipe_config->dsc.slice_count < 2) { drm_dbg_kms(&dev_priv->drm, "Cannot split stream to use 2 VDSC instances\n"); return -EINVAL; } pipe_config->dsc.dsc_split = true; }
Quoted 16 lines
Best regards,
ShawnQuoted 13 lines
Quoted 11 lines
drivers/gpu/drm/i915/display/intel_cdclk.c +5
-0+ intel_crtc_has_type(crtc_state, INTEL_OUTPUT_DSI) && + crtc_state->dsc.compression_enable && + crtc_state->dsc.slice_count == 1) +min_cdclk =max (min_cdclk, (int )crtc_state->pixel_rate); +/* * HACK. Currently for TGL platforms we calculate
*min_cdclkinitially based onpixel_ratedivided
--
2.17.1
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI[Intel-gfx] ✗ Fi.CI.SPARSE: warning for MIPI DSI driver enhancements
In reply to Lee Shawn C== Series Details ==
== Series Details ==
Series: MIPI DSI driver enhancements
URL : https://patchwork.freedesktop.org/series/92695/
State : warning
== Summary ==
$ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. - +drivers/gpu/drm/i915/display/intel_display.c:1896:21: expected struct i915_vma *[assigned] vma +drivers/gpu/drm/i915/display/intel_display.c:1896:21: got void [noderef] __iomem *[assigned] iomem +drivers/gpu/drm/i915/display/intel_display.c:1896:21: warning: incorrect type in assignment (different address spaces) +drivers/gpu/drm/i915/gem/i915_gem_context.c:1412:34: expected struct i915_address_space *vm +drivers/gpu/drm/i915/gem/i915_gem_context.c:1412:34: got struct i915_address_space [noderef] __rcu *vm +drivers/gpu/drm/i915/gem/i915_gem_context.c:1412:34: warning: incorrect type in argument 1 (different address spaces) +drivers/gpu/drm/i915/gem/selftests/mock_context.c:43:25: expected struct i915_address_space [noderef] __rcu *vm +drivers/gpu/drm/i915/gem/selftests/mock_context.c:43:25: got struct i915_address_space * +drivers/gpu/drm/i915/gem/selftests/mock_context.c:43:25: warning: incorrect type in assignment (different address spaces) +drivers/gpu/drm/i915/gem/selftests/mock_context.c:60:34: expected struct i915_address_space *vm +drivers/gpu/drm/i915/gem/selftests/mock_context.c:60:34: got struct i915_address_space [noderef] __rcu *vm +drivers/gpu/drm/i915/gem/selftests/mock_context.c:60:34: warning: incorrect type in argument 1 (different address spaces) +drivers/gpu/drm/i915/gt/intel_engine_stats.h:27:9: warning: trying to copy expression type 31 +drivers/gpu/drm/i915/gt/intel_engine_stats.h:27:9: warning: trying to copy expression type 31 +drivers/gpu/drm/i915/gt/intel_engine_stats.h:27:9: warning: trying to copy expression type 31 +drivers/gpu/drm/i915/gt/intel_engine_stats.h:32:9: warning: trying to copy expression type 31 +drivers/gpu/drm/i915/gt/intel_engine_stats.h:32:9: warning: trying to copy expression type 31 +drivers/gpu/drm/i915/gt/intel_engine_stats.h:49:9: warning: trying to copy expression type 31 +drivers/gpu/drm/i915/gt/intel_engine_stats.h:49:9: warning: trying to copy expression type 31 +drivers/gpu/drm/i915/gt/intel_engine_stats.h:49:9: warning: trying to copy expression type 31 +drivers/gpu/drm/i915/gt/intel_engine_stats.h:56:9: warning: trying to copy expression type 31 +drivers/gpu/drm/i915/gt/intel_engine_stats.h:56:9: warning: trying to copy expression type 31 +drivers/gpu/drm/i915/gt/intel_reset.c:1396:5: warning: context imbalance in 'intel_gt_reset_trylock' - different lock contexts for basic block +drivers/gpu/drm/i915/gt/intel_ring_submission.c:1210:24: warning: Using plain integer as NULL pointer +drivers/gpu/drm/i915/i915_perf.c:1434:15: warning: memset with byte count of 16777216 +drivers/gpu/drm/i915/i915_perf.c:1488:15: warning: memset with byte count of 16777216 +./include/asm-generic/bitops/find.h:112:45: warning: shift count is negative (-262080) +./include/asm-generic/bitops/find.h:32:31: warning: shift count is negative (-262080) +./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_read16' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_read32' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_read64' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_read8' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_write16' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_write32' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_write8' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_read16' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_read32' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_read64' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_read8' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_write16' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_write32' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_write8' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_read16' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_read32' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_read64' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_read8' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_write16' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_write32' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_write8' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_read16' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_read32' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_read64' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_read8' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_write16' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_write32' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_write8' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen8_write16' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen8_write32' - different lock contexts for basic block +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen8_write8' - different lock contexts for basic block
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI[Intel-gfx] ✗ Fi.CI.DOCS: warning for MIPI DSI driver enhancements
In reply to Lee Shawn C== Series Details ==
== Series Details ==
Series: MIPI DSI driver enhancements
URL : https://patchwork.freedesktop.org/series/92695/
State : warning
== Summary ==
$ make htmldocs 2>&1 > /dev/null | grep i915 ./drivers/gpu/drm/i915/i915_cmd_parser.c:1436: warning: Excess function parameter 'jump_whitelist' description in 'intel_engine_cmd_parser' ./drivers/gpu/drm/i915/i915_cmd_parser.c:1436: warning: Excess function parameter 'shadow_map' description in 'intel_engine_cmd_parser' ./drivers/gpu/drm/i915/i915_cmd_parser.c:1436: warning: Excess function parameter 'batch_map' description in 'intel_engine_cmd_parser' ./drivers/gpu/drm/i915/i915_cmd_parser.c:1436: warning: Function parameter or member 'trampoline' not described in 'intel_engine_cmd_parser' ./drivers/gpu/drm/i915/i915_cmd_parser.c:1436: warning: Excess function parameter 'jump_whitelist' description in 'intel_engine_cmd_parser' ./drivers/gpu/drm/i915/i915_cmd_parser.c:1436: warning: Excess function parameter 'shadow_map' description in 'intel_engine_cmd_parser' ./drivers/gpu/drm/i915/i915_cmd_parser.c:1436: warning: Excess function parameter 'batch_map' description in 'intel_engine_cmd_parser'
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI[Intel-gfx] ✓ Fi.CI.BAT: success for MIPI DSI driver enhancements
In reply to Lee Shawn C== Series Details ==
== Series Details ==
Series: MIPI DSI driver enhancements
URL : https://patchwork.freedesktop.org/series/92695/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10350 -> Patchwork_20643
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20643/index.html
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_20643:
### IGT changes ###
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses. They do not affect the overall result.
* igt@runner@aborted:
- {fi-tgl-1115g4}: NOTRUN -> [FAIL][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20643/fi-tgl-1115g4/igt@[email protected]
Known issues
------------
Here are the changes found in Patchwork_20643 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@amdgpu/amd_basic@semaphore:
- fi-bdw-5557u: NOTRUN -> [SKIP][2] ([fdo#109271]) +27 similar issues
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20643/fi-bdw-5557u/igt@amdgpu/[email protected]
* igt@amdgpu/amd_cs_nop@sync-fork-compute0:
- fi-kbl-soraka: NOTRUN -> [SKIP][3] ([fdo#109271]) +13 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20643/fi-kbl-soraka/igt@amdgpu/[email protected]
* igt@core_hotunplug@unbind-rebind:
- fi-bdw-5557u: NOTRUN -> [WARN][4] ([i915#3718])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20643/fi-bdw-5557u/igt@[email protected]
* igt@kms_chamelium@dp-crc-fast:
- fi-bdw-5557u: NOTRUN -> [SKIP][5] ([fdo#109271] / [fdo#111827]) +8 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20643/fi-bdw-5557u/igt@[email protected]
#### Possible fixes ####
* igt@gem_exec_suspend@basic-s0:
- {fi-tgl-1115g4}: [FAIL][6] ([i915#1888]) -> [PASS][7]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10350/fi-tgl-1115g4/igt@[email protected]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20643/fi-tgl-1115g4/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1887]: https://gitlab.freedesktop.org/drm/intel/issues/1887
[i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888
[i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
[i915#3718]: https://gitlab.freedesktop.org/drm/intel/issues/3718
Participating hosts (39 -> 35)
------------------------------
Missing (4): fi-ilk-m540 fi-bsw-cyan fi-bdw-samus fi-hsw-4200u
Build changes
-------------
* Linux: CI_DRM_10350 -> Patchwork_20643
CI-20190529: 20190529
CI_DRM_10350: 0da7e60301374bc5d2d53573b061cad7f6e2959e @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6144: bc65ee9ee6593716306448c9fb82c77f284f2148 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_20643: f981830475f75da719fb4dc14d465fedcfb52aa3 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
f981830475f7 drm/i915: Get proper min cdclk if vDSC enabled 81aaf60c9297 drm/i915/dsi: refine send MIPI DCS command sequence aaf3e5434382 drm/i915/dsi: wait for header and payload credit available f470eadd23ac drm/i915/jsl: program DSI panel GPIOs 8480a7a24e8c drm/i915/dsi: send correct gpio_number on gen11 platform
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20643/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI[Intel-gfx] ✓ Fi.CI.IGT: success for MIPI DSI driver enhancements
In reply to Lee Shawn C== Series Details ==
== Series Details ==
Series: MIPI DSI driver enhancements
URL : https://patchwork.freedesktop.org/series/92695/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10350_full -> Patchwork_20643_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Known issues
------------
Here are the changes found in Patchwork_20643_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@feature_discovery@display-4x:
- shard-apl: NOTRUN -> [SKIP][1] ([fdo#109271]) +252 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20643/shard-apl6/igt@[email protected]
* igt@gem_ctx_persistence@legacy-engines-hang@blt:
- shard-skl: NOTRUN -> [SKIP][2] ([fdo#109271]) +106 similar issues
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20643/shard-skl8/igt@gem_ctx_persistence@[email protected]
* igt@gem_ctx_persistence@legacy-engines-mixed:
- shard-snb: NOTRUN -> [SKIP][3] ([fdo#109271] / [i915#1099]) +3 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20643/shard-snb7/igt@[email protected]
* igt@gem_exec_fair@basic-deadline:
- shard-glk: [PASS][4] -> [FAIL][5] ([i915#2846])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10350/shard-glk9/igt@[email protected]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20643/shard-glk3/igt@[email protected]
* igt@gem_exec_fair@basic-none@vcs0:
- shard-glk: [PASS][6] -> [FAIL][7] ([i915#2842])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10350/shard-glk8/igt@gem_exec_fair@[email protected]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20643/shard-glk2/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-pace@vcs0:
- shard-kbl: [PASS][8] -> [FAIL][9] ([i915#2842])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10350/shard-kbl2/igt@gem_exec_fair@[email protected]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20643/shard-kbl3/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-pace@vcs1:
- shard-kbl: [PASS][10] -> [SKIP][11] ([fdo#109271])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10350/shard-kbl2/igt@gem_exec_fair@[email protected]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20643/shard-kbl3/igt@gem_exec_fair@[email protected]
* igt@gem_render_copy@y-tiled-to-vebox-linear:
- shard-iclb: NOTRUN -> [SKIP][12] ([i915#768])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20643/shard-iclb7/igt@[email protected]
* igt@gem_userptr_blits@input-checking:
- shard-skl: NOTRUN -> [DMESG-WARN][13] ([i915#3002])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20643/shard-skl8/igt@[email protected]
* igt@i915_selftest@mock@scatterlist:
- shard-apl: NOTRUN -> [DMESG-WARN][14] ([i915#3746]) +17 similar issues
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20643/shard-apl1/igt@i915_selftest@[email protected]
* igt@i915_selftest@mock@vma:
- shard-snb: NOTRUN -> [DMESG-WARN][15] ([i915#3746]) +17 similar issues
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20643/shard-snb6/igt@i915_selftest@[email protected]
* igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-0-async-flip:
- shard-skl: NOTRUN -> [FAIL][16] ([i915#3722])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20643/shard-skl5/igt@[email protected]
* igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-0-hflip:
- shard-apl: NOTRUN -> [SKIP][17] ([fdo#109271] / [i915#3777]) +1 similar issue
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20643/shard-apl3/igt@[email protected]
* igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-0-async-flip:
- shard-skl: NOTRUN -> [FAIL][18] ([i915#3763])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20643/shard-skl8/igt@[email protected]
* igt@kms_ccs@pipe-a-crc-primary-rotation-180-yf_tiled_ccs:
- shard-tglb: NOTRUN -> [SKIP][19] ([i915#3689])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20643/shard-tglb3/igt@kms_ccs@pipe-a-crc-primary-rotation-180-yf_tiled_ccs.html
* igt@kms_chamelium@hdmi-edid-change-during-suspend:
- shard-apl: NOTRUN -> [SKIP][20] ([fdo#109271] / [fdo#111827]) +22 similar issues
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20643/shard-apl1/igt@[email protected]
* igt@kms_chamelium@hdmi-hpd-fast:
- shard-snb: NOTRUN -> [SKIP][21] ([fdo#109271] / [fdo#111827]) +14 similar issues
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20643/shard-snb6/igt@[email protected]
* igt@kms_chamelium@vga-hpd-for-each-pipe:
- shard-skl: NOTRUN -> [SKIP][22] ([fdo#109271] / [fdo#111827]) +9 similar issues
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20643/shard-skl8/igt@[email protected]
* igt@kms_cursor_crc@pipe-a-cursor-suspend:
- shard-kbl: [PASS][23] -> [DMESG-WARN][24] ([i915#180]) +1 similar issue
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10350/shard-kbl6/igt@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20643/shard-kbl4/igt@[email protected]
* igt@kms_cursor_crc@pipe-c-cursor-32x32-rapid-movement:
- shard-glk: NOTRUN -> [SKIP][25] ([fdo#109271]) +1 similar issue
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20643/shard-glk1/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][26] ([i915#3319])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20643/shard-tglb2/igt@[email protected]
* igt@kms_cursor_crc@pipe-d-cursor-256x85-random:
- shard-iclb: NOTRUN -> [SKIP][27] ([fdo#109278]) +2 similar issues
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20643/shard-iclb7/igt@[email protected]
* igt@kms_cursor_crc@pipe-d-cursor-512x170-offscreen:
- shard-tglb: NOTRUN -> [SKIP][28] ([fdo#109279] / [i915#3359]) +1 similar issue
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20643/shard-tglb3/igt@[email protected]
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
- shard-skl: NOTRUN -> [FAIL][29] ([i915#2346])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20643/shard-skl3/igt@[email protected]
* igt@kms_cursor_legacy@flip-vs-cursor-legacy:
- shard-skl: [PASS][30] -> [FAIL][31] ([i915#2346])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10350/shard-skl9/igt@[email protected]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20643/shard-skl6/igt@[email protected]
* igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1:
- shard-skl: [PASS][32] -> [FAIL][33] ([i915#79])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10350/shard-skl3/igt@kms_flip@[email protected]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20643/shard-skl5/igt@kms_flip@[email protected]
* igt@kms_flip@flip-vs-suspend@c-dp1:
- shard-apl: [PASS][34] -> [DMESG-WARN][35] ([i915#180]) +1 similar issue
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10350/shard-apl7/igt@kms_flip@[email protected]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20643/shard-apl8/igt@kms_flip@[email protected]
* igt@kms_flip@plain-flip-fb-recreate@c-edp1:
- shard-skl: [PASS][36] -> [FAIL][37] ([i915#2122])
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10350/shard-skl3/igt@kms_flip@[email protected]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20643/shard-skl5/igt@kms_flip@[email protected]
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-pri-indfb-draw-pwrite:
- shard-snb: NOTRUN -> [SKIP][38] ([fdo#109271]) +292 similar issues
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20643/shard-snb6/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-pri-indfb-draw-pwrite.html
* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-fullscreen:
- shard-tglb: NOTRUN -> [SKIP][39] ([fdo#111825])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20643/shard-tglb3/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-fullscreen.html
* igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-indfb-draw-mmap-gtt:
- shard-kbl: NOTRUN -> [SKIP][40] ([fdo#109271]) +1 similar issue
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20643/shard-kbl6/igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-indfb-draw-mmap-gtt.html
* igt@kms_hdr@bpc-switch-suspend:
- shard-skl: NOTRUN -> [FAIL][41] ([i915#1188])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20643/shard-skl5/igt@[email protected]
* igt@kms_multipipe_modeset@basic-max-pipe-crc-check:
- shard-iclb: NOTRUN -> [SKIP][42] ([i915#1839])
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20643/shard-iclb7/igt@[email protected]
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d:
- shard-apl: NOTRUN -> [SKIP][43] ([fdo#109271] / [i915#533]) +2 similar issues
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20643/shard-apl3/igt@[email protected]
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-d:
- shard-skl: NOTRUN -> [SKIP][44] ([fdo#109271] / [i915#533])
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20643/shard-skl6/igt@[email protected]
* igt@kms_plane@plane-panning-bottom-right-suspend@pipe-b-planes:
- shard-apl: NOTRUN -> [DMESG-WARN][45] ([i915#180])
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20643/shard-apl2/igt@kms_plane@[email protected]
* igt@kms_plane_alpha_blend@pipe-a-alpha-opaque-fb:
- shard-apl: NOTRUN -> [FAIL][46] ([fdo#108145] / [i915#265]) +5 similar issues
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20643/shard-apl2/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-a-coverage-vs-premult-vs-constant:
- shard-iclb: [PASS][47] -> [SKIP][48] ([fdo#109278])
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10350/shard-iclb5/igt@kms_plane_alpha_blend@pipe-a-coverage-vs-premult-vs-constant.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20643/shard-iclb2/igt@kms_plane_alpha_blend@pipe-a-coverage-vs-premult-vs-constant.html
* igt@kms_plane_alpha_blend@pipe-b-alpha-opaque-fb:
- shard-skl: NOTRUN -> [FAIL][49] ([fdo#108145] / [i915#265]) +2 similar issues
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20643/shard-skl5/igt@[email protected]
* igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-5:
- shard-apl: NOTRUN -> [SKIP][50] ([fdo#109271] / [i915#658]) +4 similar issues
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20643/shard-apl3/igt@[email protected]
* igt@kms_psr2_sf@plane-move-sf-dmg-area-0:
- shard-skl: NOTRUN -> [SKIP][51] ([fdo#109271] / [i915#658])
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20643/shard-skl5/igt@[email protected]
* igt@kms_psr@psr2_no_drrs:
- shard-iclb: [PASS][52] -> [SKIP][53] ([fdo#109441]) +1 similar issue
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10350/shard-iclb2/igt@kms_psr@psr2_no_drrs.html
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20643/shard-iclb7/igt@kms_psr@psr2_no_drrs.html
* igt@kms_vblank@pipe-a-ts-continuation-dpms-suspend:
- shard-skl: [PASS][54] -> [INCOMPLETE][55] ([i915#198])
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10350/shard-skl4/igt@[email protected]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20643/shard-skl4/igt@[email protected]
* igt@kms_vblank@pipe-c-ts-continuation-suspend:
- shard-skl: [PASS][56] -> [INCOMPLETE][57] ([i915#198] / [i915#2828]) +1 similar issue
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10350/shard-skl7/igt@[email protected]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20643/shard-skl9/igt@[email protected]
* igt@kms_writeback@writeback-pixel-formats:
- shard-apl: NOTRUN -> [SKIP][58] ([fdo#109271] / [i915#2437])
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20643/shard-apl2/igt@[email protected]
* igt@prime_nv_test@i915_import_gtt_mmap:
- shard-tglb: NOTRUN -> [SKIP][59] ([fdo#109291])
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20643/shard-tglb3/igt@prime_nv_test@i915_import_gtt_mmap.html
* igt@sysfs_clients@fair-7:
- shard-apl: NOTRUN -> [SKIP][60] ([fdo#109271] / [i915#2994]) +5 similar issues
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20643/shard-apl3/igt@[email protected]
#### Possible fixes ####
* igt@gem_eio@unwedge-stress:
- shard-tglb: [TIMEOUT][61] ([i915#2369] / [i915#3063] / [i915#3648]) -> [PASS][62]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10350/shard-tglb2/igt@[email protected]
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20643/shard-tglb6/igt@[email protected]
* igt@gem_exec_fair@basic-none-share@rcs0:
- shard-iclb: [FAIL][63] ([i915#2842]) -> [PASS][64]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10350/shard-iclb1/igt@gem_exec_fair@[email protected]
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20643/shard-iclb7/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-glk: [FAIL][65] ([i915#2842]) -> [PASS][66]
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10350/shard-glk9/igt@gem_exec_fair@[email protected]
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20643/shard-glk3/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-pace@rcs0:
- shard-kbl: [FAIL][67] ([i915#2842]) -> [PASS][68]
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10350/shard-kbl2/igt@gem_exec_fair@[email protected]
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20643/shard-kbl3/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-pace@vcs0:
- shard-tglb: [FAIL][69] ([i915#2842]) -> [PASS][70]
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10350/shard-tglb6/igt@gem_exec_fair@[email protected]
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20643/shard-tglb3/igt@gem_exec_fair@[email protected]
* igt@i915_pm_dc@dc5-psr:
- shard-iclb: [DMESG-WARN][71] ([i915#3698]) -> [PASS][72]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10350/shard-iclb2/igt@[email protected]
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20643/shard-iclb7/igt@[email protected]
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size:
- shard-skl: [FAIL][73] ([i915#2346] / [i915#533]) -> [PASS][74]
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10350/shard-skl9/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20643/shard-skl6/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
* igt@kms_flip@flip-vs-suspend@a-dp1:
- shard-apl: [DMESG-WARN][75] ([i915#180]) -> [PASS][76] +2 similar issues
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10350/shard-apl7/igt@kms_flip@[email protected]
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20643/shard-apl8/igt@kms_flip@[email protected]
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
- shard-skl: [INCOMPLETE][77] ([i915#198]) -> [PASS][78] +1 similar issue
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10350/shard-skl10/igt@[email protected]
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20643/shard-skl3/igt@[email protected]
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
- shard-skl: [DMESG-WARN][79] ([i915#1982]) -> [PASS][80]
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10350/shard-skl2/igt@[email protected]
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20643/shard-skl1/igt@[email protected]
* igt@kms_psr@psr2_cursor_mmap_cpu:
- shard-iclb: [SKIP][81] ([fdo#109441]) -> [PASS][82]
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10350/shard-iclb5/igt@kms_psr@psr2_cursor_mmap_cpu.html
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20643/shard-iclb2/igt@kms_psr@psr2_cursor_mmap_cpu.html
* igt@perf@polling-parameterized:
- shard-skl: [FAIL][83] ([i915#1542]) -> [PASS][84]
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10350/shard-skl5/igt@[email protected]
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20643/shard-skl7/igt@[email protected]
* igt@sysfs_timeslice_duration@timeout@rcs0:
- shard-skl: [FAIL][85] ([i915#3259]) -> [PASS][86]
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10350/shard-skl2/igt@sysfs_timeslice_duration@[email protected]
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20643/shard-skl1/igt@sysfs_timeslice_duration@[email protected]
#### Warnings ####
* igt@i915_pm_rc6_residency@rc6-fence:
- shard-iclb: [WARN][87] ([i915#2684]) -> [WARN][88] ([i915#1804] / [i915#2684])
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10350/shard-iclb8/igt@[email protected]
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20643/shard-iclb6/igt@[email protected]
* igt@i915_pm_rc6_residency@rc6-idle:
- shard-iclb: [WARN][89] ([i915#1804] / [i915#2684]) -> [WARN][90] ([i915#2684])
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10350/shard-iclb4/igt@[email protected]
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20643/shard-iclb5/igt@[email protected]
* igt@kms_psr2_sf@plane-move-sf-dmg-area-1:
- shard-iclb: [SKIP][91] ([i915#2920]) -> [SKIP][92] ([i915#658])
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10350/shard-iclb2/igt@[email protected]
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20643/shard-iclb7/igt@[email protected]
* igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-4:
- shard-iclb: [SKIP][93] ([i915#658]) -> [SKIP][94] ([i915#2920]) +1 similar issue
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10350/shard-iclb5/igt@[email protected]
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20643/shard-iclb2/igt@[email protected]
* igt@runner@aborted:
- shard-kbl: ([FAIL][95], [FAIL][96]) ([i915#3002] / [i915#3363]) -> ([FAIL][97], [FAIL][98], [FAIL][99], [FAIL][100]) ([i915#180] / [i915#1814] / [i915#3002] / [i915#3363])
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10350/shard-kbl2/igt@[email protected]
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10350/shard-kbl7/igt@[email protected]
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20643/shard-kbl7/igt@[email protected]
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20643/shard-kbl7/igt@[email protected]
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20643/shard-kbl3/igt@[email protected]
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20643/shard-kbl4/igt@[email protected]
- shard-iclb: ([FAIL][101], [FAIL][102], [FAIL][103], [FAIL][104], [FAIL][105]) ([i915#1814] / [i915#3002] / [i915#3702]) -> ([FAIL][106], [FAIL][107], [FAIL][108], [FAIL][109]) ([i915#1814] / [i915#3002])
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10350/shard-iclb3/igt@[email protected]
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10350/shard-iclb6/igt@[email protected]
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10350/shard-iclb1/igt@[email protected]
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10350/shard-iclb2/igt@[email protected]
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10350/shard-iclb1/igt@[email protected]
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20643/shard-iclb3/igt@[email protected]
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20643/shard-iclb6/igt@[email protected]
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20643/shard-iclb1/igt@[email protected]
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20643/shard-iclb3/igt@[email protected]
- shard-apl: ([FAIL][110], [FAIL][111], [FAIL][112], [FAIL][113], [FAIL][114], [FAIL][115], [FAIL][116], [FAIL][117]) ([i915#180] / [i915#3002] / [i915#3363]) -> ([FAIL][118], [FAIL][119], [FAIL][120], [FAIL][121], [FAIL][122]) ([i915#180] / [i915#1814] / [i915#3002] / [i915#3363])
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10350/shard-apl2/igt@[email protected]
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10350/shard-apl3/igt@[email protected]
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10350/shard-apl3/igt@[email protected]
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10350/shard-apl7/igt@[email protected]
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10350/shard-apl8/igt@[email protected]
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10350/shard-apl6/igt@[email protected]
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10350/shard-apl3/igt@[email protected]
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10350/shard-apl3/igt@[email protected]
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20643/shard-apl2/igt@[email protected]
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20643/shard-apl8/igt@[email protected]
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20643/shard-apl2/igt@[email protected]
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20643/shard-apl2/igt@[email protected]
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20643/shard-apl1/igt@[email protected]
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109279]: https://bugs.freedesktop.org/show_bug.cgi?id=109279
[fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1099]: https://gitlab.freedesktop.org/drm/intel/issues/1099
[i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188
[i915#1542]: https://gitlab.freedesktop.org/drm/intel/issues/1542
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1804]: https://gitlab.freedesktop.org/drm/intel/issues/1804
[i915#1814]: https://gitlab.freedesktop.org/drm/intel/issues/1814
[i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839
[i915#198]: https://gitlab.freedesktop.org/drm/intel/issues/198
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2369]: https://gitlab.freedesktop.org/drm/intel/issues/2369
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#2684]: https://gitlab.freedesktop.org/drm/intel/issues/2684
[i915#2828]: https://gitlab.freedesktop.org/drm/intel/issues/2828
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2846]: https://gitlab.freedesktop.org/drm/intel/issues/2846
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#2994]: https://gitlab.freedesktop.org/drm/intel/issues/2994
[i915#3002]: https://gitlab.freedesktop.org/drm/intel/issues/3002
[i915#3063]: https://gitlab.freedesktop.org/drm/intel/issues/3063
[i915#3259]: https://gitlab.freedesktop.org/drm/intel/issues/3259
[i915#3319]: https://gitlab.freedesktop.org/drm/intel/issues/3319
[i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
[i915#3363]: https://gitlab.freedesktop.org/drm/intel/issues/3363
[i915#3648]: https://gitlab.freedesktop.org/drm/intel/issues/3648
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3698]: https://gitlab.freedesktop.org/drm/intel/issues/3698
[i915#3702]: https://gitlab.freedesktop.org/drm/intel/issues/3702
[i915#3722]: https://gitlab.freedesktop.org/drm/intel/issues/3722
[i915#3746]: https://gitlab.freedesktop.org/drm/intel/issues/3746
[i915#3763]: https://gitlab.freedesktop.org/drm/intel/issues/3763
[i915#3777]: https://gitlab.freedesktop.org/drm/intel/issues/3777
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#768]: https://gitlab.freedesktop.org/drm/intel/issues/768
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
Participating hosts (10 -> 10)
------------------------------
No changes in participating hosts
Build changes
-------------
* Linux: CI_DRM_10350 -> Patchwork_20643
CI-20190529: 20190529
CI_DRM_10350: 0da7e60301374bc5d2d53573b061cad7f6e2959e @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6144: bc65ee9ee6593716306448c9fb82c77f284f2148 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_20643: f981830475f75da719fb4dc14d465fedcfb52aa3 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20643/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
v2 cover MIPI DSI driver enhancements
In reply to Lee Shawn Cv2:
- Check for dsc enable and slice count ==1 then allow to double confirm min cdclk value.
- Add more checking in dsi_dsc_compute_config() to avoid crtc_clock exceeds dev_priv->max_cdclk_freq.
Lee Shawn C (5):
drm/i915/dsi: send correct gpio_number on gen11 platform drm/i915/jsl: program DSI panel GPIOs drm/i915/dsi: wait for header and payload credit available drm/i915/dsi: refine send MIPI DCS command sequence drm/i915: Get proper min cdclk if vDSC enabled
drivers/gpu/drm/i915/display/icl_dsi.c | 68 ++++++++++++-------- drivers/gpu/drm/i915/display/intel_cdclk.c | 10 +++ drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 46 ++++++++++++- drivers/gpu/drm/i915/i915_reg.h | 10 +++ 4 files changed, 106 insertions(+), 28 deletions(-)
Signature · 6 lines
2.17.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v2 1/5 drm/i915/dsi: send correct gpio_number on gen11 platform
Transfer "gpio_nunmber" instead of "gpio_index" while doing gpio configuration in icl_exec_gpio().
--- drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/display/intel_dsi_vbt.c +1 -1
@@ -381,7 +381,7 @@ static const u8 *mipi_exec_gpio(struct intel_dsi *intel_dsi, const u8 *data) value = *data++ &1 ;if (DISPLAY_VER (dev_priv) >=11 ) -icl_exec_gpio (dev_priv, gpio_source, gpio_index, value); +icl_exec_gpio (dev_priv, gpio_source, gpio_number, value);else if (IS_VALLEYVIEW (dev_priv))vlv_exec_gpio (dev_priv, gpio_source, gpio_number, value);else if (IS_CHERRYVIEW (dev_priv))
Signature · 6 lines
2.17.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v2 2/5 drm/i915/jsl: program DSI panel GPIOs
In reply to Lee Shawn CDSI driver should have its own implementation to toggle gpio pins based on GPIO info coming from VBT sequences.
--- drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 44 +++++++++++++++++++- drivers/gpu/drm/i915/i915_reg.h | 10 +++++ 2 files changed, 53 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/display/intel_dsi_vbt.c +43 -1
@@ -43,6 +43,7 @@#include "intel_display_types.h" #include "intel_dsi.h" #include "intel_sideband.h" +#include "intel_de.h" #define MIPI_TRANSFER_MODE_SHIFT 0#define MIPI_VIRTUAL_CHANNEL_SHIFT 1
@@ -354,7 +355,48 @@ static void bxt_exec_gpio(struct drm_i915_private *dev_priv,static void icl_exec_gpio (struct drm_i915_private *dev_priv,u8 gpio_source,u8 gpio_index,bool value) { -drm_dbg_kms (&dev_priv->drm,"Skipping ICL GPIO element execution\n" ); +u32 val; + +switch (gpio_index) { +case ICL_GPIO_L_VDDEN_1 : + val =intel_de_read (dev_priv,ICP_PP_CONTROL (1 )); +if (value) + val |=PWR_STATE_TARGET ; +else + val &= ~PWR_STATE_TARGET ; +intel_de_write (dev_priv,ICP_PP_CONTROL (1 ), val); +break ; +case ICL_GPIO_L_BKLTEN_1 : + val =intel_de_read (dev_priv,ICP_PP_CONTROL (1 )); +if (value) + val |=BACKLIGHT_ENABLE ; +else + val &= ~BACKLIGHT_ENABLE ; +intel_de_write (dev_priv,ICP_PP_CONTROL (1 ), val); +break ; +case ICL_GPIO_DDPA_CTRLCLK_1 : + val =intel_de_read (dev_priv,GPIO (1 )); +if (value) + val |=GPIO_CLOCK_VAL_OUT ; +else + val &= ~GPIO_CLOCK_VAL_OUT ; + val |=GPIO_CLOCK_DIR_MASK |GPIO_CLOCK_DIR_OUT |GPIO_CLOCK_VAL_MASK ; +intel_de_write (dev_priv,GPIO (1 ), val); +break ; +case ICL_GPIO_DDPA_CTRLDATA_1 : + val =intel_de_read (dev_priv,GPIO (1 )); +if (value) + val |=GPIO_DATA_VAL_OUT ; +else + val &= ~GPIO_DATA_VAL_OUT ; + val |=GPIO_DATA_DIR_MASK |GPIO_DATA_DIR_OUT |GPIO_DATA_VAL_MASK ; +intel_de_write (dev_priv,GPIO (1 ), val); +break ; +default : +/* TODO: Add support for remaining GPIOs */ +DRM_ERROR ("Invalid GPIO number (%d) from VBT\n" , gpio_index); +break ; + } }static const u8 *mipi_exec_gpio (struct intel_dsi *intel_dsi,const u8 *data)
drivers/gpu/drm/i915/i915_reg.h +10 -0
@@ -5143,6 +5143,16 @@ enum {#define _PP_STATUS 0x61200#define PP_STATUS (pps_idx) _MMIO_PPS(pps_idx, _PP_STATUS)#define PP_ON REG_BIT(31) + +#define _PP_CONTROL_1 0xc7204 +#define _PP_CONTROL_2 0xc7304 +#define ICP_PP_CONTROL (x) _MMIO(((x) == 1) ? _PP_CONTROL_1 : \ + _PP_CONTROL_2) +#define POWER_CYCLE_DELAY_MASK REG_GENMASK(8, 4) +#define VDD_OVERRIDE_FORCE REG_BIT(3) +#define BACKLIGHT_ENABLE REG_BIT(2) +#define PWR_DOWN_ON_RESET REG_BIT(1) +#define PWR_STATE_TARGET REG_BIT(0)/* * Indicates that all dependencies of the panel are on: *
Signature · 6 lines
2.17.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v2 3/5 drm/i915/dsi: wait for header and payload credit available
In reply to Lee Shawn CDriver should wait for free header or payload buffer in FIFO. It would be good to wait a while for HW to release credit before give it up to write to HW. Without sending initailize command sets completely. It would caused MIPI display can't light up properly.
--- drivers/gpu/drm/i915/display/icl_dsi.c | 40 ++++++++++++-------------- 1 file changed, 19 insertions(+), 21 deletions(-)
drivers/gpu/drm/i915/display/icl_dsi.c +19 -21
@@ -54,20 +54,28 @@ static int payload_credits_available(struct drm_i915_private *dev_priv, >> FREE_PLOAD_CREDIT_SHIFT; } -static void wait_for_header_credits (struct drm_i915_private *dev_priv, -enum transcoder dsi_trans) +static bool wait_for_header_credits (struct drm_i915_private *dev_priv, +enum transcoder dsi_trans,int hdr_credit) {if (wait_for_us (header_credits_available (dev_priv, dsi_trans) >= -MAX_HEADER_CREDIT ,100 )) + hdr_credit,100 )) {drm_err (&dev_priv->drm,"DSI header credits not released\n" ); +return false; + } + +return true; } -static void wait_for_payload_credits (struct drm_i915_private *dev_priv, -enum transcoder dsi_trans) +static bool wait_for_payload_credits (struct drm_i915_private *dev_priv, +enum transcoder dsi_trans,int payld_credit) {if (wait_for_us (payload_credits_available (dev_priv, dsi_trans) >= -MAX_PLOAD_CREDIT ,100 )) + payld_credit,100 )) {drm_err (&dev_priv->drm,"DSI payload credits not released\n" ); +return false; + } + +return true; }static enum transcoder dsi_port_to_transcoder (enum port port)
@@ -90,8 +98,8 @@ static void wait_for_cmds_dispatched_to_panel(struct intel_encoder *encoder)/* wait for header/payload credits to be released */ for_each_dsi_port (port, intel_dsi->ports) { dsi_trans =dsi_port_to_transcoder (port); -wait_for_header_credits (dev_priv, dsi_trans); -wait_for_payload_credits (dev_priv, dsi_trans); +wait_for_header_credits (dev_priv, dsi_trans,MAX_HEADER_CREDIT ); +wait_for_payload_credits (dev_priv, dsi_trans,MAX_PLOAD_CREDIT ); }/* send nop DCS command */
@@ -108,7 +116,7 @@ static void wait_for_cmds_dispatched_to_panel(struct intel_encoder *encoder)/* wait for header credits to be released */ for_each_dsi_port (port, intel_dsi->ports) { dsi_trans =dsi_port_to_transcoder (port); -wait_for_header_credits (dev_priv, dsi_trans); +wait_for_header_credits (dev_priv, dsi_trans,MAX_HEADER_CREDIT ); }/* wait for LP TX in progress bit to be cleared */
@@ -126,18 +134,13 @@ static bool add_payld_to_queue(struct intel_dsi_host *host, const u8 *data,struct intel_dsi *intel_dsi = host->intel_dsi;struct drm_i915_private *dev_priv =to_i915 (intel_dsi->base.base.dev);enum transcoder dsi_trans =dsi_port_to_transcoder (host->port); -int free_credits;int i, j;for (i =0 ; i < len; i +=4 ) {u32 tmp =0 ; - free_credits =payload_credits_available (dev_priv, dsi_trans); -if (free_credits <1 ) { -drm_err (&dev_priv->drm, -"Payload credit not available\n" ); +if (!wait_for_payload_credits (dev_priv, dsi_trans,1 ))return false; - }for (j =0 ; j <min_t (u32, len - i,4 ); j++) tmp |= *data++ <<8 * j;
@@ -155,15 +158,10 @@ static int dsi_send_pkt_hdr(struct intel_dsi_host *host,struct drm_i915_private *dev_priv =to_i915 (intel_dsi->base.base.dev);enum transcoder dsi_trans =dsi_port_to_transcoder (host->port);u32 tmp; -int free_credits;/* check if header credit available */ - free_credits =header_credits_available (dev_priv, dsi_trans); -if (free_credits <1 ) { -drm_err (&dev_priv->drm, -"send pkt header failed, not enough hdr credits\n" ); +if (!wait_for_header_credits (dev_priv, dsi_trans,1 ))return -1 ; - } tmp =intel_de_read (dev_priv,DSI_CMD_TXHDR (dsi_trans));
Signature · 6 lines
2.17.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v2 4/5 drm/i915/dsi: refine send MIPI DCS command sequence
In reply to Lee Shawn CAccording to chapter "Sending Commands to the Panel" in bspec #29738 and #49188. If driver try to send DCS long pakcet, we have to program TX payload register at first. And configure TX header HW register later. DSC long packet would not be sent properly if we don't follow this sequence.
--- drivers/gpu/drm/i915/display/icl_dsi.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
drivers/gpu/drm/i915/display/icl_dsi.c +5 -5
@@ -1807,11 +1807,6 @@ static ssize_t gen11_dsi_host_transfer(struct mipi_dsi_host *host,if (msg->flags &MIPI_DSI_MSG_USE_LPM ) enable_lpdt = true; -/* send packet header */ - ret =dsi_send_pkt_hdr (intel_dsi_host, dsi_pkt, enable_lpdt); -if (ret <0 ) -return ret; -/* only long packet contains payload */ if (mipi_dsi_packet_format_is_long (msg->type)) { ret =dsi_send_pkt_payld (intel_dsi_host, dsi_pkt);
@@ -1819,6 +1814,11 @@ static ssize_t gen11_dsi_host_transfer(struct mipi_dsi_host *host,return ret; } +/* send packet header */ + ret =dsi_send_pkt_hdr (intel_dsi_host, dsi_pkt, enable_lpdt); +if (ret <0 ) +return ret; +//TODO: add payload receive code if needed ret =sizeof (dsi_pkt.header) + dsi_pkt.payload_length;
Signature · 6 lines
2.17.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH v2 5/5 drm/i915: Get proper min cdclk if vDSC enabled
In reply to Lee Shawn CVDSC engine can process only 1 pixel per Cd clock. In case VDSC is used and max slice count == 1, max supported pixel clock should be 100% of CD clock. Then do min_cdclk and pixel clock comparison to get proper min cdclk.
v2:
- Check for dsc enable and slice count ==1 then allow to double confirm min cdclk value.
- Add more checking in dsi_dsc_compute_config() to avoid crtc_clock exceeds dev_priv->max_cdclk_freq.
--- drivers/gpu/drm/i915/display/icl_dsi.c | 18 ++++++++++++++++++ drivers/gpu/drm/i915/display/intel_cdclk.c | 10 ++++++++++ 2 files changed, 28 insertions(+)
drivers/gpu/drm/i915/display/icl_dsi.c +18 -0
@@ -1592,6 +1592,8 @@ static int gen11_dsi_dsc_compute_config(struct intel_encoder *encoder, {struct drm_i915_private *dev_priv =to_i915 (encoder->base.dev);struct drm_dsc_config *vdsc_cfg = &crtc_state->dsc.config; +const struct drm_display_mode *adjusted_mode = + &crtc_state->hw.adjusted_mode;int dsc_max_bpc =DISPLAY_VER (dev_priv) >=12 ?12 :10 ;bool use_dsc;int ret;
@@ -1612,6 +1614,22 @@ static int gen11_dsi_dsc_compute_config(struct intel_encoder *encoder,/* FIXME: initialize from VBT */ vdsc_cfg->rc_model_size =DSC_RC_MODEL_SIZE_CONST ; +/* +* VDSC engine operates at 1 Pixel per clock, so if peak pixel rate +* is greater than the maximum Cdclock and if slice count is even +* then we need to use 2 VDSC instances. +*/ +if (adjusted_mode->crtc_clock > dev_priv->max_cdclk_freq || + crtc_state->bigjoiner) { +if (crtc_state->dsc.slice_count <2 ) { +drm_dbg_kms (&dev_priv->drm, +"Cannot split stream to use 2 VDSC instances\n" ); +return -EINVAL ; + } + + crtc_state->dsc.dsc_split = true; + } + ret =intel_dsc_compute_params (encoder, crtc_state);if (ret)return ret;
drivers/gpu/drm/i915/display/intel_cdclk.c +10 -0
@@ -2159,6 +2159,16 @@ int intel_crtc_compute_min_cdclk(const struct intel_crtc_state *crtc_state)/* Account for additional needs from the planes */ min_cdclk =max (intel_planes_min_cdclk (crtc_state), min_cdclk); +/* +* VDSC engine can process only 1 pixel per Cd clock. +* In case VDSC is used and max slice count == 1, +* max supported pixel clock should be 100% of CD clock. +* Then do min_cdclk and pixel clock comparison to get cdclk. +*/ +if (crtc_state->dsc.compression_enable && + crtc_state->dsc.slice_count ==1 ) + min_cdclk =max (min_cdclk, (int )crtc_state->pixel_rate); +/* * HACK. Currently for TGL platforms we calculate * min_cdclk initially based on pixel_rate divided
Signature · 6 lines
2.17.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx