5.12.19-rc1 review
Subsystems (4)
Greg Kroah-Hartman
maintainercover 5.12.19-rc1 review
NOTE, this is going to be the LAST 5.12.y release. After this one, it is end-of-life for this kernel branch. Please move to 5.13.y at this point in time.
---------------
This is the start of the stable review cycle for the 5.12.19 release. There are 292 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Wed, 21 Jul 2021 14:47:42 +0000. Anything received after that time might be too late.
The whole patch series can be found in one patch at:
https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.12.19-rc1.gz
or in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.12.y
and the diffstat can be found below.
thanks,
greg k-h
-------------
Pseudo-Shortlog of commits:
Greg Kroah-Hartman <[email protected]>
Linux 5.12.19-rc1
Tong Zhang <[email protected]>
misc: alcor_pci: fix inverted branch condition
Dan Carpenter <[email protected]>
scsi: scsi_dh_alua: Fix signedness bug in alua_rtpg()
Linus Torvalds <[email protected]>
certs: add 'x509_revocation_list' to gitignore
Viresh Kumar <[email protected]>
cpufreq: CPPC: Fix potential memleak in cppc_cpufreq_cpu_init
Martin Fäcknitz <[email protected]>
MIPS: vdso: Invalid GIC access through VDSO
Sven Schnelle <[email protected]>
s390/irq: remove HAVE_IRQ_EXIT_ON_IRQ_STACK
Kajol Jain <[email protected]>
perf script python: Fix buffer size to report iregs in perf script
Namhyung Kim <[email protected]>
perf report: Fix --task and --stat with pipe input
Randy Dunlap <[email protected]>
mips: disable branch profiling in boot/decompress.o
Arnd Bergmann <[email protected]>
mips: always link byteswap helpers into decompressor
Peter Zijlstra <[email protected]>
kprobe/static_call: Restore missing static_call_text_reserved()
Peter Zijlstra <[email protected]>
static_call: Fix static_call_text_reserved() vs __init
Peter Zijlstra <[email protected]>
jump_label: Fix jump_label_text_reserved() vs __init
Xuewen Yan <[email protected]>
sched/uclamp: Ignore max aggregation if rq is idle
Christophe JAILLET <[email protected]>
scsi: be2iscsi: Fix an error handling path in beiscsi_dev_probe()
Alex Bee <[email protected]>
arm64: dts: rockchip: Re-add regulator-always-on for vcc_sdio for rk3399-roc-pc
Alex Bee <[email protected]>
arm64: dts: rockchip: Re-add regulator-boot-on, regulator-always-on for vdd_gpu on rk3399-roc-pc
Pali Rohár <[email protected]>
firmware: turris-mox-rwtm: show message about HWRNG registration
Pali Rohár <[email protected]>
firmware: turris-mox-rwtm: fail probing when firmware does not support hwrng
Marek Behún <[email protected]>
firmware: turris-mox-rwtm: report failures better
Marek Behún <[email protected]>
firmware: turris-mox-rwtm: fix reply status decoding function
Niklas Söderlund <[email protected]>
thermal/drivers/rcar_gen3_thermal: Fix coefficient calculations
Christoph Niedermaier <[email protected]>
ARM: dts: imx6q-dhcom: Add gpios pinctrl for i2c bus recovery
Christoph Niedermaier <[email protected]>
ARM: dts: imx6q-dhcom: Fix ethernet plugin detection problems
Christoph Niedermaier <[email protected]>
ARM: dts: imx6q-dhcom: Fix ethernet reset time properties
Chunyan Zhang <[email protected]>
thermal/drivers/sprd: Add missing MODULE_DEVICE_TABLE
Aswath Govindraju <[email protected]>
ARM: dts: am437x: align ti,pindir-d0-out-d1-in property with dt-shema
Aswath Govindraju <[email protected]>
ARM: dts: am335x: align ti,pindir-d0-out-d1-in property with dt-shema
Gowtham Tammana <[email protected]>
ARM: dts: dra7: Fix duplicate USB4 target module node
Icenowy Zheng <[email protected]>
arm64: dts: allwinner: a64-sopine-baseboard: change RGMII mode to TXID
Krzysztof Kozlowski <[email protected]>
memory: fsl_ifc: fix leak of private memory on probe failure
Krzysztof Kozlowski <[email protected]>
memory: fsl_ifc: fix leak of IO mapping on probe failure
Kishon Vijay Abraham I <[email protected]>
arm64: dts: ti: k3-j721e-common-proc-board: Re-name "link" name as "phy"
Kishon Vijay Abraham I <[email protected]>
arm64: dts: ti: k3-j721e-common-proc-board: Use external clock for SERDES
Kishon Vijay Abraham I <[email protected]>
arm64: dts: ti: k3-j721e-main: Fix external refclk input to SERDES
Stefan Wahren <[email protected]>
Revert "ARM: dts: bcm283x: increase dwc2's RX FIFO size"
Geert Uytterhoeven <[email protected]>
arm64: dts: renesas: r8a779a0: Drop power-domains property from GIC node
Philipp Zabel <[email protected]>
reset: bail if try_module_get() fails
Rafał Miłecki <[email protected]>
ARM: dts: BCM5301X: Fixup SPI binding
Nicolas Ferre <[email protected]>
dt-bindings: i2c: at91: fix example for scl-gpios
Cristian Marussi <[email protected]>
firmware: arm_scmi: Reset Rx buffer to max size during async commands
Weiyi Lu <[email protected]>
soc: mtk-pm-domains: Fix the clock prepared issue
Hsin-Yi Wang <[email protected]>
soc: mtk-pm-domains: do not register smi node as syscon
Zhen Lei <[email protected]>
firmware: tegra: Fix error return code in tegra210_bpmp_init()
Stephen Boyd <[email protected]>
arm64: dts: qcom: c630: Add no-hpd to DSI bridge node
Stephen Boyd <[email protected]>
arm64: dts: qcom: trogdor: Add no-hpd to DSI bridge node
Petr Vorel <[email protected]>
arm64: dts: qcom: msm8994-angler: Fix gpio-reserved-ranges 85-88
Marek Vasut <[email protected]>
ARM: dts: stm32: Rework LAN8710Ai PHY reset on DHCOM SoM
Geert Uytterhoeven <[email protected]>
arm64: dts: renesas: r8a7796[01]: Fix OPP table entry voltages
Geert Uytterhoeven <[email protected]>
arm64: dts: renesas: Add missing opp-suspend properties
Roger Quadros <[email protected]>
arm64: dts: ti: j7200-main: Enable USB2 PHY RX sensitivity workaround
Caleb Connolly <[email protected]>
arm64: dts: qcom: sdm845-oneplus-common: guard rmtfs-mem
Geert Uytterhoeven <[email protected]>
ARM: dts: r8a7779, marzen: Fix DU clock names
Valentine Barshak <[email protected]>
arm64: dts: renesas: v3msk: Fix memory size
Dan Carpenter <[email protected]>
rtc: fix snprintf() checking in is_rtc_hctosys()
Salvatore Bonaccorso <[email protected]>
ARM: dts: sun8i: h3: orangepi-plus: Fix ethernet phy-mode
Zhen Lei <[email protected]>
memory: pl353: Fix error return code in pl353_smc_probe()
Zou Wei <[email protected]>
reset: brcmstb: Add missing MODULE_DEVICE_TABLE
Krzysztof Kozlowski <[email protected]>
memory: atmel-ebi: add missing of_node_put for loop iteration
Krzysztof Kozlowski <[email protected]>
memory: stm32-fmc2-ebi: add missing of_node_put for loop iteration
Krzysztof Kozlowski <[email protected]>
ARM: dts: exynos: fix PWM LED max brightness on Odroid XU4
Krzysztof Kozlowski <[email protected]>
ARM: dts: exynos: fix PWM LED max brightness on Odroid HC1
Krzysztof Kozlowski <[email protected]>
ARM: dts: exynos: fix PWM LED max brightness on Odroid XU/XU3
Krzysztof Kozlowski <[email protected]>
ARM: exynos: add missing of_node_put for loop iteration
Krzysztof Kozlowski <[email protected]>
reset: a10sr: add missing of_match_table reference
Geert Uytterhoeven <[email protected]>
reset: RESET_INTEL_GW should depend on X86
Geert Uytterhoeven <[email protected]>
reset: RESET_BRCMSTB_RESCAL should depend on ARCH_BRCMSTB
Chen-Yu Tsai <[email protected]>
arm64: dts: rockchip: Drop fephy pinctrl from gmac2phy on rk3328 rock-pi-e
Corentin Labbe <[email protected]>
ARM: dts: gemini-rut1xx: remove duplicate ethernet node
Nathan Chancellor <[email protected]>
hexagon: use common DISCARDS macro
Nathan Chancellor <[email protected]>
hexagon: handle {,SOFT}IRQENTRY_TEXT in linker script
Trond Myklebust <[email protected]>
NFSv4/pNFS: Don't call _nfs4_pnfs_v3_ds_connect multiple times
Trond Myklebust <[email protected]>
NFSv4/pnfs: Fix layoutget behaviour after invalidation
Trond Myklebust <[email protected]>
NFSv4/pnfs: Fix the layout barrier update
Dave Wysochanski <[email protected]>
NFS: Fix fscache read from NFS after cache error
David Hildenbrand <[email protected]>
virtio-mem: don't read big block size in Sub Block Mode
Eli Cohen <[email protected]>
vdpa/mlx5: Clear vq ready indication upon device reset
Zhen Lei <[email protected]>
ALSA: isa: Fix error return code in snd_cmi8330_probe()
Trond Myklebust <[email protected]>
nfsd: Reduce contention for the nfsd_file nf_rwsem
Naveen N. Rao <[email protected]>
powerpc/bpf: Fix detecting BPF atomic instructions
Maurizio Lombardi <[email protected]>
nvme-tcp: can't set sk_user_data without write_lock
Michael S. Tsirkin <[email protected]>
virtio_net: move tx vq operation under tx queue lock
Eli Cohen <[email protected]>
vdp/mlx5: Fix setting the correct dma_device
Eli Cohen <[email protected]>
vdpa/mlx5: Fix possible failure in umem size calculation
Eli Cohen <[email protected]>
vdpa/mlx5: Fix umem sizes assignments on VQ create
Jon Hunter <[email protected]>
PCI: tegra194: Fix tegra_pcie_ep_raise_msi_irq() ill-defined shift
Uwe Kleine-König <[email protected]>
pwm: imx1: Don't disable clocks at device remove time
Martin Blumenstingl <[email protected]>
PCI: intel-gw: Fix INTx enable
Thomas Gleixner <[email protected]>
x86/fpu: Limit xstate copy size in xstateregs_set()
Thomas Gleixner <[email protected]>
x86/fpu: Fix copy_xstate_to_kernel() gap handling
Chao Yu <[email protected]>
f2fs: fix to avoid adding tab before doc section
Sandor Bodo-Merle <[email protected]>
PCI: iproc: Support multi-MSI only on uniprocessor kernel
Sandor Bodo-Merle <[email protected]>
PCI: iproc: Fix multi-MSI base vector number allocation
Zhihao Cheng <[email protected]>
ubifs: Set/Clear I_LINKABLE under i_lock for whiteout inode
Gao Xiang <[email protected]>
nfs: fix acl memory leak of posix_acl_create()
NeilBrown <[email protected]>
SUNRPC: prevent port reuse on transports which don't request it.
Wei Yongjun <[email protected]>
watchdog: jz4740: Fix return value check in jz4740_wdt_probe()
Tao Ren <[email protected]>
watchdog: aspeed: fix hardware timeout calculation
Shruthi Sanil <[email protected]>
watchdog: keembay: Removed timeout update in the TO ISR
Shruthi Sanil <[email protected]>
watchdog: keembay: Remove timeout update in the WDT start function
Shruthi Sanil <[email protected]>
watchdog: keembay: Clear either the TO or TH interrupt bit
Shruthi Sanil <[email protected]>
watchdog: keembay: Update pretimeout to zero in the TH ISR
Shruthi Sanil <[email protected]>
watchdog: keembay: Upadate WDT pretimeout for every update in timeout
Shruthi Sanil <[email protected]>
watchdog: keembay: Update WDT pre-timeout during the initialization
Zhen Lei <[email protected]>
ubifs: journal: Fix error return code in ubifs_jnl_write_inode()
Zhen Lei <[email protected]>
um: fix error return code in winch_tramp()
Zhen Lei <[email protected]>
um: fix error return code in slip_open()
YiFei Zhu <[email protected]>
um: Fix stack pointer alignment
Anna Schumaker <[email protected]>
sunrpc: Avoid a KASAN slab-out-of-bounds bug in xdr_set_page_base()
Trond Myklebust <[email protected]>
NFSv4: Fix an Oops in pnfs_mark_request_commit() when doing O_DIRECT
Trond Myklebust <[email protected]>
NFSv4: Initialise connection to the server in nfs4_alloc_client()
Stephan Gerhold <[email protected]>
power: supply: rt5033_battery: Fix device tree enumeration
Krzysztof Wilczyński <[email protected]>
PCI/sysfs: Fix dsm_label_utf16s_to_utf8s() buffer overrun
Christophe JAILLET <[email protected]>
remoteproc: k3-r5: Fix an error message
Chao Yu <[email protected]>
f2fs: compress: fix to disallow temp extension
Chao Yu <[email protected]>
f2fs: add MODULE_SOFTDEP to ensure crc32 is included in the initramfs
Jon Mediero <[email protected]>
module: correctly exit module_kallsyms_on_each_symbol when fn() != 0
Chang S. Bae <[email protected]>
x86/signal: Detect and prevent an alternate signal stack overflow
Chuck Lever <[email protected]>
NFSD: Fix TP_printk() format specifier in nfsd_clid_class
Chao Yu <[email protected]>
f2fs: atgc: fix to set default age threshold
Chunguang Xu <[email protected]>
block: fix the problem of io_ticks becoming smaller
Xie Yongji <[email protected]>
virtio_console: Assure used length from device is limited
Xie Yongji <[email protected]>
virtio_net: Fix error handling in virtnet_restore()
Xie Yongji <[email protected]>
virtio-blk: Fix memory leak among suspend/resume procedure
Ye Bin <[email protected]>
ext4: fix WARN_ON_ONCE(!buffer_uptodate) after an error writing the superblock
Javier Martinez Canillas <[email protected]>
PCI: rockchip: Register IRQ handlers after device and data are ready
Hans de Goede <[email protected]>
ACPI: video: Add quirk for the Dell Vostro 3350
Liguang Zhang <[email protected]>
ACPI: AMBA: Fix resource name in /proc/iomem
Uwe Kleine-König <[email protected]>
pwm: tegra: Don't modify HW state in .remove callback
Zou Wei <[email protected]>
pwm: img: Fix PM reference leak in img_pwm_enable()
Philip Yang <[email protected]>
drm/amdkfd: fix sysfs kobj leak
Evan Quan <[email protected]>
drm/amdgpu: fix Navi1x tcp power gating hang when issuing lightweight invalidaiton
Hans de Goede <[email protected]>
power: supply: axp288_fuel_gauge: Make "T3 MRD" no_battery_list DMI entry more generic
Zou Wei <[email protected]>
power: supply: ab8500: add missing MODULE_DEVICE_TABLE
Zou Wei <[email protected]>
power: supply: charger-manager: add missing MODULE_DEVICE_TABLE
Zou Wei <[email protected]>
power: reset: regulator-poweroff: add missing MODULE_DEVICE_TABLE
Trond Myklebust <[email protected]>
NFS: nfs_find_open_context() may only select open files
Jing Xiangfeng <[email protected]>
drm/gma500: Add the missed drm_gem_object_put() in psb_user_framebuffer_create()
Jeff Layton <[email protected]>
ceph: remove bogus checks and WARN_ONs from ceph_set_page_dirty
Mike Marshall <[email protected]>
orangefs: fix orangefs df output.
Zou Wei <[email protected]>
PCI: tegra: Add missing MODULE_DEVICE_TABLE
Siddharth Gupta <[email protected]>
remoteproc: core: Fix cdev remove and rproc del
Thomas Gleixner <[email protected]>
x86/fpu: Return proper error codes from user access functions
Jan Kiszka <[email protected]>
watchdog: iTCO_wdt: Account for rebooting on second timeout
Stefan Eichenberger <[email protected]>
watchdog: imx_sc_wdt: fix pretimeout
Zou Wei <[email protected]>
watchdog: Fix possible use-after-free by calling del_timer_sync()
Zou Wei <[email protected]>
watchdog: sc520_wdt: Fix possible use-after-free in wdt_turnoff()
Zou Wei <[email protected]>
watchdog: Fix possible use-after-free in wdt_startup()
Russell King <[email protected]>
PCI: Dynamically map ECAM regions
Lukas Wunner <[email protected]>
PCI: pciehp: Ignore Link Down/Up caused by DPC
Trond Myklebust <[email protected]>
NFSv4: Fix delegation return in cases where we have to retry
Logan Gunthorpe <[email protected]>
PCI/P2PDMA: Avoid pci_get_slot(), which may sleep
Nick Desaulniers <[email protected]>
ARM: 9087/1: kprobes: test-thumb: fix for LLVM_IAS=1
Bixuan Cui <[email protected]>
power: reset: gpio-poweroff: add missing MODULE_DEVICE_TABLE
Krzysztof Kozlowski <[email protected]>
power: supply: max17042: Do not enforce (incorrect) interrupt trigger type
Long Li <[email protected]>
PCI: hv: Fix a race condition when removing the device
Linus Walleij <[email protected]>
power: supply: ab8500: Avoid NULL pointers
Randy Dunlap <[email protected]>
PCI: ftpci100: Rename macro name collision
Uwe Kleine-König <[email protected]>
pwm: spear: Don't modify HW state in .remove callback
Zou Wei <[email protected]>
power: supply: sc2731_charger: Add missing MODULE_DEVICE_TABLE
Zou Wei <[email protected]>
power: supply: sc27xx: Add missing MODULE_DEVICE_TABLE
Marco Elver <[email protected]>
kcov: add __no_sanitize_coverage to fix noinstr for all architectures
Dimitri John Ledkov <[email protected]>
lib/decompress_unlz4.c: correctly handle zero-padding around initrds.
Rashmi A <[email protected]>
phy: intel: Fix for warnings due to EMMC clock 175Mhz change in FIP
Dmitry Torokhov <[email protected]>
i2c: core: Disable client irq on reboot/shutdown
Alexander Shishkin <[email protected]>
intel_th: Wait until port is in reset before programming it
Fabio Aiuto <[email protected]>
staging: rtl8723bs: fix macro value for 2.4Ghz only device
Zou Wei <[email protected]>
leds: turris-omnia: add missing MODULE_DEVICE_TABLE
Takashi Sakamoto <[email protected]>
ALSA: firewire-motu: fix detection for S/PDIF source on optical interface in v2 protocol
Geoffrey D. Bennett <[email protected]>
ALSA: usb-audio: scarlett2: Fix 6i6 Gen 2 line out descriptions
Jiajun Cao <[email protected]>
ALSA: hda: Add IRQ check for platform_get_irq()
Uwe Kleine-König <[email protected]>
backlight: lm3630a: Fix return code of .update_status() callback
Pierre-Louis Bossart <[email protected]>
ASoC: Intel: kbl_da7219_max98357a: shrink platform_id below 20 characters
Yang Yingliang <[email protected]>
ASoC: fsl_xcvr: check return value after calling platform_get_resource_byname()
Benjamin Herrenschmidt <[email protected]>
powerpc/boot: Fixup device-tree on little endian
Yang Yingliang <[email protected]>
usb: gadget: hid: fix error return code in hid_bind()
Ruslan Bilovol <[email protected]>
usb: gadget: f_hid: fix endianness issue with descriptors
Geoffrey D. Bennett <[email protected]>
ALSA: usb-audio: scarlett2: Fix scarlett2_*_ctl_put() return values
Geoffrey D. Bennett <[email protected]>
ALSA: usb-audio: scarlett2: Fix data_mutex lock
Geoffrey D. Bennett <[email protected]>
ALSA: usb-audio: scarlett2: Fix 18i8 Gen 2 PCM Input count
Greg Ungerer <[email protected]>
m68knommu: fix missing LCD splash screen data initializer
Takashi Sakamoto <[email protected]>
ALSA: bebob: add support for ToneWeal FW66
Yizhuo Zhai <[email protected]>
Input: hideep - fix the uninitialized use in hideep_nvm_unlock()
Heiko Carstens <[email protected]>
s390/mem_detect: fix tprot() program check new psw handling
Heiko Carstens <[email protected]>
s390/mem_detect: fix diag260() program check new psw handling
Heiko Carstens <[email protected]>
s390/ipl_parm: fix program check new psw handling
Heiko Carstens <[email protected]>
s390/processor: always inline stap() and __load_psw_mask()
Koby Elbaz <[email protected]>
habanalabs/gaudi: set the correct rc in case of err
Koby Elbaz <[email protected]>
habanalabs: remove node from list before freeing the node
Koby Elbaz <[email protected]>
habanalabs: set rc as 'valid' in case of intentional func exit
Ohad Sharabi <[email protected]>
habanalabs: fix mask to obtain page offset
Koby Elbaz <[email protected]>
habanalabs/gaudi: set the correct cpu_id on MME2_QM failure
Mathias Nyman <[email protected]>
xhci: handle failed buffer copy to URB sg list and fix a W=1 copiler warning
Zhen Lei <[email protected]>
ASoC: soc-core: Fix the error return code in snd_soc_of_parse_audio_routing()
Aneesh Kumar K.V <[email protected]>
powerpc/mm/book3s64: Fix possible build error
Peter Robinson <[email protected]>
gpio: pca953x: Add support for the On Semi pca9655
Athira Rajeev <[email protected]>
selftests/powerpc: Fix "no_handler" EBB selftest
Yang Yingliang <[email protected]>
ALSA: ppc: fix error return code in snd_pmac_probe()
Michael Kelley <[email protected]>
scsi: storvsc: Correctly handle multiple flags in srb_status
Srinivas Neeli <[email protected]>
gpio: zynq: Check return value of irq_get_irq_data
Srinivas Neeli <[email protected]>
gpio: zynq: Check return value of pm_runtime_get_sync
Jaroslav Kysela <[email protected]>
ASoC: soc-pcm: fix the return value in dpcm_apply_symmetry()
Yang Yingliang <[email protected]>
ALSA: n64: check return value after calling platform_get_resource()
Xiyu Yang <[email protected]>
iommu/arm-smmu: Fix arm_smmu_device refcount leak in address translation
Xiyu Yang <[email protected]>
iommu/arm-smmu: Fix arm_smmu_device refcount leak when arm_smmu_rpm_get fails
Geoff Levand <[email protected]>
powerpc/ps3: Add dma_mask to ps3_dma_region
Takashi Iwai <[email protected]>
ALSA: sb: Fix potential double-free of CSP mixer elements
Eric Anholt <[email protected]>
iommu/arm-smmu-qcom: Skip the TTBR1 quirk for db820c.
Po-Hsu Lin <[email protected]>
selftests: timers: rtcpie: skip test if default RTC device does not exist
Fabrice Fontaine <[email protected]>
s390: disable SSP when needed
Valentin Vidic <[email protected]>
s390/sclp_vt220: fix console name to match device
Daniel Mack <[email protected]>
serial: tty: uartlite: fix console setup
Zou Wei <[email protected]>
fsi: Add missing MODULE_DEVICE_TABLE
Yufen Yu <[email protected]>
ASoC: img: Fix PM reference leak in img_i2s_in_probe()
Tony Lindgren <[email protected]>
mfd: cpcap: Fix cpcap dmamask not set warnings
Zou Wei <[email protected]>
mfd: da9052/stmpe: Add and modify MODULE_DEVICE_TABLE
Mike Christie <[email protected]>
scsi: qedi: Fix cleanup session block/unblock use
Mike Christie <[email protected]>
scsi: qedi: Fix TMF session block/unblock use
Mike Christie <[email protected]>
scsi: qedi: Fix race during abort timeouts
Mike Christie <[email protected]>
scsi: qedi: Fix null ref during abort handling
Mike Christie <[email protected]>
scsi: iscsi: Fix shost->max_id use
Mike Christie <[email protected]>
scsi: iscsi: Fix conn use after free during resets
Mike Christie <[email protected]>
scsi: iscsi: Add iscsi_cls_conn refcount helpers
Chandrakanth Patil <[email protected]>
scsi: megaraid_sas: Handle missing interrupts while re-enabling IRQs
Kashyap Desai <[email protected]>
scsi: megaraid_sas: Early detection of VD deletion through RaidMap update
Chandrakanth Patil <[email protected]>
scsi: megaraid_sas: Fix resource leak in case of probe failure
Jiapeng Chong <[email protected]>
fs/jfs: Fix missing error code in lmLogInit()
Hannes Reinecke <[email protected]>
scsi: scsi_dh_alua: Check for negative result value
Hannes Reinecke <[email protected]>
scsi: core: Fixup calling convention for scsi_mode_sense()
Suganath Prabu S <[email protected]>
scsi: mpt3sas: Fix deadlock while cancelling the running firmware event
Christophe JAILLET <[email protected]>
tty: serial: 8250: serial_cs: Fix a memory leak in error handling path
Yufen Yu <[email protected]>
ALSA: ac97: fix PM reference leak in ac97_bus_remove()
John Garry <[email protected]>
scsi: core: Cap scsi_host cmd_per_lun at can_queue
James Smart <[email protected]>
scsi: lpfc: Fix crash when lpfc_sli4_hba_setup() fails to initialize the SGLs
James Smart <[email protected]>
scsi: lpfc: Fix "Unexpected timeout" error in direct attach topology
Sergey Shtylyov <[email protected]>
scsi: hisi_sas: Propagate errors in interrupt_init_v1_hw()
ching Huang <[email protected]>
scsi: arcmsr: Fix doorbell status being updated late on ARC-1886
Vamshi Krishna Gopal <[email protected]>
ASoC: Intel: sof_sdw: add quirk support for Brya and BT-offload
Luiz Sampaio <[email protected]>
w1: ds2438: fixing bug that would always get page0
Chunfeng Yun <[email protected]>
usb: common: usb-conn-gpio: fix NULL pointer dereference of charger
Takashi Sakamoto <[email protected]>
Revert "ALSA: bebob/oxfw: fix Kconfig entry for Mackie d.2 Pro"
Takashi Iwai <[email protected]>
ALSA: usx2y: Don't call free_pages_exact() with NULL address
Takashi Iwai <[email protected]>
ALSA: usx2y: Avoid camelCase
Jonathan Cameron <[email protected]>
iio: magn: bmc150: Balance runtime pm + use pm_runtime_resume_and_get()
Jonathan Cameron <[email protected]>
iio: gyro: fxa21002c: Balance runtime pm + use pm_runtime_resume_and_get().
Sean Nyekjaer <[email protected]>
iio: imu: st_lsm6dsx: correct ODR in header
Arnd Bergmann <[email protected]>
partitions: msdos: fix one-byte get_unaligned()
Zou Wei <[email protected]>
ASoC: intel/boards: add missing MODULE_DEVICE_TABLE
Tong Zhang <[email protected]>
misc: alcor_pci: fix null-ptr-deref when there is no PCI bridge
Lv Yunlong <[email protected]>
misc/libmasm/module: Fix two use after free in ibmasm_init_one
Michael Walle <[email protected]>
serial: fsl_lpuart: disable DMA for console and fix sysrq
Sherry Sun <[email protected]>
tty: serial: fsl_lpuart: fix the potential risk of division or modulo by zero
Raymond Tan <[email protected]>
usb: dwc3: pci: Fix DEFINE for Intel Elkhart Lake
Paul E. McKenney <[email protected]>
rcu: Reject RCU_LOCKDEP_WARN() false positives
Frederic Weisbecker <[email protected]>
srcu: Fix broken node geometry after early ssp init
ching Huang <[email protected]>
scsi: arcmsr: Fix the wrong CDB payload report to IOP
Robin Gong <[email protected]>
dmaengine: fsl-qdma: check dma_set_mask return value
Pierre-Louis Bossart <[email protected]>
ASoC: Intel: sof_sdw: add mutual exclusion between PCH DMIC and RT715
Yang Yingliang <[email protected]>
leds: tlc591xx: fix return value check in tlc591xx_probe()
Nikolay Aleksandrov <[email protected]>
net: bridge: multicast: fix MRD advertisement router port marking race
Nikolay Aleksandrov <[email protected]>
net: bridge: multicast: fix PIM hello router port marking race
Pavel Begunkov <[email protected]>
io_uring: fix link timeout refs
Pavel Begunkov <[email protected]>
io_uring: put link timeout req consistently
José Roberto de Souza <[email protected]>
drm/dp_mst: Add missing drm parameters to recently added call to drm_dbg_kms()
Wayne Lin <[email protected]>
drm/dp_mst: Avoid to mess up payload table by ports in stale topology
Wayne Lin <[email protected]>
drm/dp_mst: Do not set proposed vcpi directly
Filipe Manana <[email protected]>
btrfs: zoned: fix wrong mutex unlock on failure to allocate log root tree
Filipe Manana <[email protected]>
btrfs: rework chunk allocation to avoid exhaustion of the system chunk array
Filipe Manana <[email protected]>
btrfs: fix deadlock with concurrent chunk allocations involving system chunks
Naohiro Aota <[email protected]>
btrfs: properly split extent_map for REQ_OP_ZONE_APPEND
Pavel Begunkov <[email protected]>
io_uring: use right task for exiting checks
Robin Murphy <[email protected]>
arm64: Avoid premature usercopy failure
Joao Martins <[email protected]>
mm/hugetlb: fix refs calculation from unaligned @vaddr
Randy Dunlap <[email protected]>
EDAC/igen6: fix core dependency AGAIN
Zhen Lei <[email protected]>
fbmem: Do not delete the mode that is still in use
Christian Brauner <[email protected]>
cgroup: verify that source is a string
Ville Syrjälä <[email protected]>
drm/i915/gt: Fix -EDEADLK handling regression
Matthew Auld <[email protected]>
drm/i915/gtt: drop the page table optimisation
Jinzhou Su <[email protected]>
drm/amdgpu: add another Renoir DID
Steven Rostedt (VMware) <[email protected]>
tracing: Do not reference char * as a string in histograms
Lu Baolu <[email protected]>
iommu/vt-d: Fix clearing real DMA device's scalable-mode context entries
Sanjay Kumar <[email protected]>
iommu/vt-d: Global devTLB flush when present context entry changed
Steffen Maier <[email protected]>
scsi: zfcp: Report port fc_security as unknown early during remote cable pull
Tyrel Datwyler <[email protected]>
scsi: core: Fix bad pointer dereference when ehandler kthread is invalid
Lai Jiangshan <[email protected]>
KVM: X86: Disable hardware breakpoints unconditionally before kvm_x86->run()
Vitaly Kuznetsov <[email protected]>
KVM: nSVM: Check the value written to MSR_VM_HSAVE_PA
Sean Christopherson <[email protected]>
KVM: x86/mmu: Do not apply HPA (memory encryption) mask to GPAs
Sean Christopherson <[email protected]>
KVM: x86: Use guest MAXPHYADDR from CPUID.0x8000_0008 iff TDP is enabled
Kefeng Wang <[email protected]>
KVM: mmio: Fix use-after-free Read in kvm_vm_ioctl_unregister_coalesced_mmio
Ronnie Sahlberg <[email protected]>
cifs: Do not use the original cruid when following DFS links for multiuser mounts
Paulo Alcantara <[email protected]>
cifs: handle reconnect of tcon when there is no cached dfs referral
Shyam Prasad N <[email protected]>
cifs: use the expiry output of dns_query to schedule next resolution
-------------
Diffstat:
Documentation/devicetree/bindings/i2c/i2c-at91.txt | 2 +- Documentation/filesystems/f2fs.rst | 16 +- Makefile | 4 +- arch/arm/boot/dts/am335x-cm-t335.dts | 2 +- arch/arm/boot/dts/am43x-epos-evm.dts | 4 +- arch/arm/boot/dts/am5718.dtsi | 6 +- arch/arm/boot/dts/bcm283x-rpi-usb-otg.dtsi | 2 +- arch/arm/boot/dts/bcm283x-rpi-usb-peripheral.dtsi | 2 +- arch/arm/boot/dts/bcm5301x.dtsi | 18 +- arch/arm/boot/dts/dra7-l4.dtsi | 22 - arch/arm/boot/dts/dra71x.dtsi | 4 - arch/arm/boot/dts/dra72x.dtsi | 4 - arch/arm/boot/dts/dra74x.dtsi | 92 +-- arch/arm/boot/dts/exynos5422-odroidhc1.dts | 2 +- arch/arm/boot/dts/exynos5422-odroidxu4.dts | 2 +- arch/arm/boot/dts/exynos54xx-odroidxu-leds.dtsi | 4 +- arch/arm/boot/dts/gemini-rut1xx.dts | 12 - arch/arm/boot/dts/imx6q-dhcom-som.dtsi | 41 +- arch/arm/boot/dts/r8a7779-marzen.dts | 2 +- arch/arm/boot/dts/r8a7779.dtsi | 1 + arch/arm/boot/dts/stm32mp15xx-dhcom-som.dtsi | 8 +- arch/arm/boot/dts/sun8i-h3-orangepi-plus.dts | 2 +- arch/arm/mach-exynos/exynos.c | 2 + arch/arm/probes/kprobes/test-thumb.c | 10 +- .../dts/allwinner/sun50i-a64-sopine-baseboard.dts | 2 +- .../arm64/boot/dts/qcom/msm8994-angler-rev-101.dts | 4 + arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 2 + .../arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi | 12 + .../boot/dts/qcom/sdm850-lenovo-yoga-c630.dts | 2 + arch/arm64/boot/dts/renesas/r8a774a1.dtsi | 1 + arch/arm64/boot/dts/renesas/r8a77960.dtsi | 7 +- arch/arm64/boot/dts/renesas/r8a77961.dtsi | 7 +- arch/arm64/boot/dts/renesas/r8a77970-v3msk.dts | 2 +- arch/arm64/boot/dts/renesas/r8a779a0.dtsi | 1 - arch/arm64/boot/dts/rockchip/rk3328-rock-pi-e.dts | 2 - arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dtsi | 3 + arch/arm64/boot/dts/ti/k3-j7200-main.dtsi | 1 + .../boot/dts/ti/k3-j721e-common-proc-board.dts | 52 +- arch/arm64/boot/dts/ti/k3-j721e-main.dtsi | 58 +- arch/arm64/lib/copy_from_user.S | 13 +- arch/arm64/lib/copy_in_user.S | 21 +- arch/arm64/lib/copy_to_user.S | 14 +- arch/hexagon/kernel/vmlinux.lds.S | 9 +- arch/m68k/68000/dragen2.c | 1 + arch/m68k/68000/screen.h | 804 +++++++++++++++++++++ arch/mips/boot/compressed/Makefile | 4 +- arch/mips/boot/compressed/decompress.c | 2 + arch/mips/include/asm/vdso/vdso.h | 2 +- arch/powerpc/boot/devtree.c | 59 +- arch/powerpc/boot/ns16550.c | 9 +- arch/powerpc/include/asm/ps3.h | 2 + arch/powerpc/mm/book3s64/radix_tlb.c | 26 +- arch/powerpc/net/bpf_jit_comp64.c | 4 +- arch/powerpc/platforms/ps3/mm.c | 12 + arch/s390/Kconfig | 1 - arch/s390/Makefile | 1 + arch/s390/boot/ipl_parm.c | 19 +- arch/s390/boot/mem_detect.c | 47 +- arch/s390/include/asm/processor.h | 4 +- arch/s390/kernel/setup.c | 2 +- arch/s390/purgatory/Makefile | 1 + arch/um/drivers/chan_user.c | 3 +- arch/um/drivers/slip_user.c | 3 +- arch/um/drivers/ubd_kern.c | 3 +- arch/um/kernel/skas/clone.c | 2 +- arch/um/os-Linux/helper.c | 4 +- arch/um/os-Linux/signal.c | 2 +- arch/um/os-Linux/skas/process.c | 2 +- arch/x86/include/asm/fpu/internal.h | 19 +- arch/x86/kernel/fpu/regset.c | 2 +- arch/x86/kernel/fpu/xstate.c | 105 +-- arch/x86/kernel/signal.c | 24 +- arch/x86/kvm/cpuid.c | 8 +- arch/x86/kvm/mmu/mmu.c | 2 + arch/x86/kvm/mmu/paging.h | 14 + arch/x86/kvm/mmu/paging_tmpl.h | 4 +- arch/x86/kvm/mmu/spte.h | 6 - arch/x86/kvm/svm/svm.c | 11 +- arch/x86/kvm/x86.c | 2 + block/blk-core.c | 2 +- block/partitions/ldm.c | 2 +- block/partitions/ldm.h | 3 - block/partitions/msdos.c | 24 +- certs/.gitignore | 1 + drivers/acpi/acpi_amba.c | 1 + drivers/acpi/acpi_video.c | 9 + drivers/block/virtio_blk.c | 2 + drivers/char/virtio_console.c | 4 +- drivers/cpufreq/cppc_cpufreq.c | 27 +- drivers/dma/fsl-qdma.c | 6 +- drivers/edac/Kconfig | 2 +- drivers/firmware/arm_scmi/driver.c | 4 + drivers/firmware/tegra/bpmp-tegra210.c | 2 +- drivers/firmware/turris-mox-rwtm.c | 55 +- drivers/fsi/fsi-master-aspeed.c | 1 + drivers/fsi/fsi-master-ast-cf.c | 1 + drivers/fsi/fsi-master-gpio.c | 1 + drivers/fsi/fsi-occ.c | 1 + drivers/gpio/gpio-pca953x.c | 1 + drivers/gpio/gpio-zynq.c | 15 +- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 1 + drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 95 +++ drivers/gpu/drm/amd/amdkfd/kfd_process.c | 14 +- .../gpu/drm/amd/amdkfd/kfd_process_queue_manager.c | 1 + drivers/gpu/drm/drm_dp_mst_topology.c | 68 +- drivers/gpu/drm/gma500/framebuffer.c | 7 +- drivers/gpu/drm/i915/gt/gen8_ppgtt.c | 5 +- drivers/gpu/drm/i915/gt/intel_ggtt_fencing.c | 2 +- drivers/hwtracing/intel_th/core.c | 17 + drivers/hwtracing/intel_th/gth.c | 16 + drivers/hwtracing/intel_th/intel_th.h | 3 + drivers/i2c/i2c-core-base.c | 3 + drivers/iio/gyro/fxas21002c_core.c | 11 +- drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c | 6 +- drivers/iio/magnetometer/bmc150_magn.c | 10 +- drivers/input/touchscreen/hideep.c | 13 +- drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c | 13 +- drivers/iommu/arm/arm-smmu/arm-smmu.c | 10 +- drivers/iommu/intel/iommu.c | 34 +- drivers/leds/leds-tlc591xx.c | 8 +- drivers/leds/leds-turris-omnia.c | 1 + drivers/memory/atmel-ebi.c | 4 +- drivers/memory/fsl_ifc.c | 8 +- drivers/memory/pl353-smc.c | 1 + drivers/memory/stm32-fmc2-ebi.c | 4 + drivers/mfd/da9052-i2c.c | 1 + drivers/mfd/motorola-cpcap.c | 4 + drivers/mfd/stmpe-i2c.c | 2 +- drivers/misc/cardreader/alcor_pci.c | 8 +- drivers/misc/habanalabs/common/device.c | 5 +- drivers/misc/habanalabs/common/firmware_if.c | 5 +- drivers/misc/habanalabs/common/mmu/mmu.c | 14 +- drivers/misc/habanalabs/gaudi/gaudi.c | 7 +- drivers/misc/habanalabs/goya/goya.c | 1 + drivers/misc/ibmasm/module.c | 5 +- drivers/net/virtio_net.c | 27 +- drivers/nvme/target/tcp.c | 1 - drivers/pci/controller/dwc/pcie-intel-gw.c | 10 +- drivers/pci/controller/dwc/pcie-tegra194.c | 2 +- drivers/pci/controller/pci-ftpci100.c | 30 +- drivers/pci/controller/pci-hyperv.c | 30 +- drivers/pci/controller/pci-tegra.c | 1 + drivers/pci/controller/pcie-iproc-msi.c | 29 +- drivers/pci/controller/pcie-rockchip-host.c | 12 +- drivers/pci/ecam.c | 54 +- drivers/pci/hotplug/pciehp_hpc.c | 36 + drivers/pci/p2pdma.c | 34 +- drivers/pci/pci-label.c | 2 +- drivers/pci/pci.h | 4 + drivers/pci/pcie/dpc.c | 74 +- drivers/phy/intel/phy-intel-keembay-emmc.c | 3 +- drivers/power/reset/gpio-poweroff.c | 1 + drivers/power/reset/regulator-poweroff.c | 1 + drivers/power/supply/Kconfig | 3 +- drivers/power/supply/ab8500_btemp.c | 1 + drivers/power/supply/ab8500_charger.c | 19 +- drivers/power/supply/ab8500_fg.c | 1 + drivers/power/supply/axp288_fuel_gauge.c | 18 +- drivers/power/supply/charger-manager.c | 1 + drivers/power/supply/max17042_battery.c | 2 +- drivers/power/supply/rt5033_battery.c | 7 + drivers/power/supply/sc2731_charger.c | 1 + drivers/power/supply/sc27xx_fuel_gauge.c | 1 + drivers/pwm/pwm-img.c | 2 +- drivers/pwm/pwm-imx1.c | 2 - drivers/pwm/pwm-spear.c | 4 - drivers/pwm/pwm-tegra.c | 13 - drivers/remoteproc/remoteproc_cdev.c | 2 +- drivers/remoteproc/remoteproc_core.c | 2 +- drivers/remoteproc/ti_k3_r5_remoteproc.c | 2 +- drivers/reset/Kconfig | 4 +- drivers/reset/core.c | 5 +- drivers/reset/reset-a10sr.c | 1 + drivers/reset/reset-brcmstb.c | 1 + drivers/rtc/proc.c | 4 +- drivers/s390/char/sclp_vt220.c | 4 +- drivers/s390/scsi/zfcp_sysfs.c | 1 + drivers/scsi/arcmsr/arcmsr_hba.c | 19 +- drivers/scsi/be2iscsi/be_main.c | 5 +- drivers/scsi/bnx2i/bnx2i_iscsi.c | 2 +- drivers/scsi/cxgbi/libcxgbi.c | 4 +- drivers/scsi/device_handler/scsi_dh_alua.c | 11 +- drivers/scsi/hisi_sas/hisi_sas_v1_hw.c | 12 +- drivers/scsi/hosts.c | 4 + drivers/scsi/libiscsi.c | 122 ++-- drivers/scsi/lpfc/lpfc_els.c | 9 + drivers/scsi/lpfc/lpfc_sli.c | 5 +- drivers/scsi/megaraid/megaraid_sas.h | 12 + drivers/scsi/megaraid/megaraid_sas_base.c | 96 ++- drivers/scsi/megaraid/megaraid_sas_fp.c | 6 +- drivers/scsi/megaraid/megaraid_sas_fusion.c | 10 +- drivers/scsi/mpt3sas/mpt3sas_scsih.c | 22 + drivers/scsi/qedi/qedi.h | 1 + drivers/scsi/qedi/qedi_fw.c | 24 +- drivers/scsi/qedi/qedi_iscsi.c | 37 +- drivers/scsi/qedi/qedi_main.c | 2 +- drivers/scsi/scsi_lib.c | 10 +- drivers/scsi/scsi_transport_iscsi.c | 12 + drivers/scsi/scsi_transport_sas.c | 9 +- drivers/scsi/sd.c | 12 +- drivers/scsi/sr.c | 2 +- drivers/scsi/storvsc_drv.c | 61 +- drivers/soc/mediatek/mtk-pm-domains.c | 42 +- drivers/staging/rtl8723bs/hal/odm.h | 5 +- drivers/thermal/rcar_gen3_thermal.c | 2 +- drivers/thermal/sprd_thermal.c | 1 + drivers/tty/serial/8250/serial_cs.c | 11 +- drivers/tty/serial/fsl_lpuart.c | 9 + drivers/tty/serial/uartlite.c | 27 +- drivers/usb/common/usb-conn-gpio.c | 44 +- drivers/usb/dwc3/dwc3-pci.c | 8 +- drivers/usb/gadget/function/f_hid.c | 2 +- drivers/usb/gadget/legacy/hid.c | 4 +- drivers/usb/host/xhci.c | 9 +- drivers/vdpa/mlx5/core/mr.c | 9 +- drivers/vdpa/mlx5/net/mlx5_vnet.c | 30 +- drivers/video/backlight/lm3630a_bl.c | 12 +- drivers/video/fbdev/core/fbmem.c | 12 +- drivers/virtio/virtio_mem.c | 15 +- drivers/w1/slaves/w1_ds2438.c | 4 +- drivers/watchdog/aspeed_wdt.c | 2 +- drivers/watchdog/iTCO_wdt.c | 12 +- drivers/watchdog/imx_sc_wdt.c | 11 +- drivers/watchdog/jz4740_wdt.c | 4 +- drivers/watchdog/keembay_wdt.c | 15 +- drivers/watchdog/lpc18xx_wdt.c | 2 +- drivers/watchdog/sbc60xxwdt.c | 2 +- drivers/watchdog/sc520_wdt.c | 2 +- drivers/watchdog/w83877f_wdt.c | 2 +- fs/btrfs/block-group.c | 343 ++++++--- fs/btrfs/block-group.h | 6 +- fs/btrfs/ctree.c | 67 +- fs/btrfs/inode.c | 147 +++- fs/btrfs/transaction.c | 15 +- fs/btrfs/transaction.h | 9 +- fs/btrfs/tree-log.c | 2 +- fs/btrfs/volumes.c | 355 ++++++--- fs/btrfs/volumes.h | 5 +- fs/ceph/addr.c | 10 +- fs/cifs/cifs_dfs_ref.c | 6 +- fs/cifs/cifsglob.h | 4 + fs/cifs/connect.c | 61 +- fs/cifs/dns_resolve.c | 10 +- fs/cifs/dns_resolve.h | 2 +- fs/cifs/misc.c | 2 +- fs/ext4/ext4_jbd2.c | 2 +- fs/ext4/super.c | 12 +- fs/f2fs/gc.c | 1 + fs/f2fs/namei.c | 16 +- fs/f2fs/super.c | 1 + fs/io_uring.c | 11 +- fs/jfs/jfs_logmgr.c | 1 + fs/nfs/delegation.c | 71 +- fs/nfs/delegation.h | 1 + fs/nfs/direct.c | 17 +- fs/nfs/fscache.c | 18 +- fs/nfs/inode.c | 4 + fs/nfs/nfs3proc.c | 4 +- fs/nfs/nfs4_fs.h | 1 + fs/nfs/nfs4client.c | 82 ++- fs/nfs/pnfs.c | 40 +- fs/nfs/pnfs_nfs.c | 52 +- fs/nfs/read.c | 5 +- fs/nfsd/nfs4state.c | 3 - fs/nfsd/trace.h | 29 - fs/nfsd/vfs.c | 18 +- fs/orangefs/super.c | 2 +- fs/ubifs/dir.c | 7 + fs/ubifs/journal.c | 1 + include/linux/compiler-clang.h | 17 + include/linux/compiler-gcc.h | 6 + include/linux/compiler_types.h | 2 +- include/linux/nfs_fs.h | 1 + include/linux/pci-ecam.h | 1 + include/linux/rcupdate.h | 2 +- include/linux/sched/signal.h | 19 +- include/scsi/libiscsi.h | 11 +- include/scsi/scsi_transport_iscsi.h | 2 + kernel/cgroup/cgroup-v1.c | 2 + kernel/jump_label.c | 13 +- kernel/kprobes.c | 2 + kernel/module.c | 3 +- kernel/rcu/rcu.h | 2 + kernel/rcu/srcutree.c | 3 + kernel/rcu/tree.c | 16 +- kernel/rcu/update.c | 2 +- kernel/sched/sched.h | 21 +- kernel/static_call.c | 13 +- kernel/trace/trace_events_hist.c | 6 +- lib/decompress_unlz4.c | 8 + mm/hugetlb.c | 5 +- net/bridge/br_multicast.c | 6 + net/sunrpc/xdr.c | 7 +- net/sunrpc/xprtsock.c | 3 +- sound/ac97/bus.c | 2 +- sound/firewire/Kconfig | 5 +- sound/firewire/bebob/bebob.c | 5 +- sound/firewire/motu/motu-protocol-v2.c | 13 +- sound/firewire/oxfw/oxfw.c | 2 +- sound/isa/cmi8330.c | 2 +- sound/isa/sb/sb16_csp.c | 8 +- sound/mips/snd-n64.c | 4 + sound/pci/hda/hda_tegra.c | 3 + sound/ppc/powermac.c | 6 +- sound/soc/fsl/fsl_xcvr.c | 4 + sound/soc/img/img-i2s-in.c | 2 +- sound/soc/intel/boards/kbl_da7219_max98357a.c | 4 +- sound/soc/intel/boards/sof_da7219_max98373.c | 1 + sound/soc/intel/boards/sof_rt5682.c | 1 + sound/soc/intel/boards/sof_sdw.c | 35 +- sound/soc/intel/boards/sof_sdw_common.h | 1 + sound/soc/intel/common/soc-acpi-intel-kbl-match.c | 2 +- sound/soc/soc-core.c | 2 +- sound/soc/soc-pcm.c | 2 +- sound/usb/mixer_scarlett_gen2.c | 39 +- sound/usb/usx2y/usX2Yhwdep.c | 56 +- sound/usb/usx2y/usX2Yhwdep.h | 2 +- sound/usb/usx2y/usb_stream.c | 7 +- sound/usb/usx2y/usbus428ctldefs.h | 102 +-- sound/usb/usx2y/usbusx2y.c | 218 +++--- sound/usb/usx2y/usbusx2y.h | 58 +- sound/usb/usx2y/usbusx2yaudio.c | 448 ++++++------ sound/usb/usx2y/usx2yhwdeppcm.c | 410 +++++------ sound/usb/usx2y/usx2yhwdeppcm.h | 4 +- tools/perf/builtin-report.c | 6 + .../util/scripting-engines/trace-event-python.c | 17 +- .../selftests/powerpc/pmu/ebb/no_handler_test.c | 2 - tools/testing/selftests/timers/rtcpie.c | 10 +- virt/kvm/coalesced_mmio.c | 2 +- 329 files changed, 4507 insertions(+), 2117 deletions(-)
Greg Kroah-Hartman
maintainerPATCH 1/292 cifs: use the expiry output of dns_query to schedule next resolution
From: Shyam Prasad N <[email protected]>
commit 506c1da44fee32ba1d3a70413289ad58c772bba6 upstream.
We recently fixed DNS resolution of the server hostname during reconnect. However, server IP address may change, even when the old one continues to server (although sub-optimally).
We should schedule the next DNS resolution based on the TTL of the DNS record used for the last resolution. This way, we resolve the server hostname again when a DNS record expires.
--- fs/cifs/cifs_dfs_ref.c | 2 - fs/cifs/cifsglob.h | 4 +++ fs/cifs/connect.c | 55 ++++++++++++++++++++++++++++++++++++++++++++++--- fs/cifs/dns_resolve.c | 10 +++++--- fs/cifs/dns_resolve.h | 2 - fs/cifs/misc.c | 2 - 6 files changed, 65 insertions(+), 10 deletions(-)
fs/cifs/cifs_dfs_ref.c +1 -1
@@ -173,7 +173,7 @@ char *cifs_compose_mount_options(const c } } - rc =dns_resolve_server_name_to_ip (name, &srvIP); + rc =dns_resolve_server_name_to_ip (name, &srvIP,NULL );if (rc <0 ) {cifs_dbg (FYI ,"%s: Failed to resolve server part of %s to IP: %d\n" , __func__, name, rc);
fs/cifs/cifsglob.h +4 -0
@@ -84,6 +84,9 @@#define SMB_ECHO_INTERVAL_MAX 600#define SMB_ECHO_INTERVAL_DEFAULT 60 +/* dns resolution interval in seconds */ +#define SMB_DNS_RESOLVE_INTERVAL_DEFAULT 600 +/* maximum number of PDUs in one compound */ #define MAX_COMPOUND 5
@@ -654,6 +657,7 @@ struct TCP_Server_Info {/* point to the SMBD connection if RDMA is used instead of socket */ struct smbd_connection *smbd_conn;struct delayed_work echo;/* echo ping workqueue job */ +struct delayed_work resolve;/* dns resolution workqueue job */ char *smallbuf;/* pointer to current "small" buffer */ char *bigbuf;/* pointer to current "big" buffer */ /* Total size of this PDU. Only valid from cifs_demultiplex_thread */
fs/cifs/connect.c +52 -3
102 lines not on this page · raw message
fs/cifs/dns_resolve.c +6 -4
@@ -36,6 +36,7 @@* dns_resolve_server_name_to_ip - Resolve UNC server name to ip address. * @unc: UNC path specifying the server (with '/' as delimiter) * @ip_addr: Where to return the IP address. +* @expiry: Where to return the expiry time for the dns record. * * The IP address will be returned in string form, and the caller is * responsible for freeing it.
@@ -43,7 +44,7 @@* Returns length of result on success, -ve on error. */ int -dns_resolve_server_name_to_ip (const char *unc,char **ip_addr) +dns_resolve_server_name_to_ip (const char *unc,char **ip_addr,time64_t *expiry) {struct sockaddr_storage ss;const char *hostname, *sep;
@@ -78,13 +79,14 @@ dns_resolve_server_name_to_ip(const char/* Perform the upcall */ rc =dns_query (current->nsproxy->net_ns,NULL , hostname, len, -NULL , ip_addr,NULL , false); +NULL , ip_addr, expiry, false);if (rc <0 )cifs_dbg (FYI ,"%s: unable to resolve: %*.*s\n" , __func__, len, len, hostname);else -cifs_dbg (FYI ,"%s: resolved: %*.*s to %s\n" , - __func__, len, len, hostname, *ip_addr); +cifs_dbg (FYI ,"%s: resolved: %*.*s to %s expiry %llu\n" , + __func__, len, len, hostname, *ip_addr, + expiry ? (*expiry) :0 );return rc; name_is_IP_address:
fs/cifs/dns_resolve.h +1 -1
@@ -24,7 +24,7 @@#define _DNS_RESOLVE_H#ifdef __KERNEL__ -extern int dns_resolve_server_name_to_ip (const char *unc,char **ip_addr); +extern int dns_resolve_server_name_to_ip (const char *unc,char **ip_addr,time64_t *expiry);#endif /* KERNEL */ #endif /* _DNS_RESOLVE_H */
fs/cifs/misc.c +1 -1
@@ -1105,7 +1105,7 @@ int match_target_ip(struct TCP_Server_Incifs_dbg (FYI ,"%s: target name: %s\n" , __func__, target +2 ); - rc =dns_resolve_server_name_to_ip (target, &tip); + rc =dns_resolve_server_name_to_ip (target, &tip,NULL );if (rc <0 ) goto out;
Greg Kroah-Hartman
maintainerPATCH 2/292 cifs: handle reconnect of tcon when there is no cached dfs referral
In reply to Greg Kroah-HartmanFrom: Paulo Alcantara <[email protected]>
commit 507345b5ae6a57b7ecd7550ff39282ed20de7b8d upstream.
When there is no cached DFS referral of tcon->dfs_path, then reconnect to same share.
--- fs/cifs/connect.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
fs/cifs/connect.c +2 -4
@@ -4185,7 +4185,8 @@ int cifs_tree_connect(const unsigned intif (!tree)return -ENOMEM ; -if (!tcon->dfs_path) { +/* If it is not dfs or there was no cached dfs referral, then reconnect to same share */ +if (!tcon->dfs_path ||dfs_cache_noreq_find (tcon->dfs_path +1 , &ref, &tl)) {if (tcon->ipc) {scnprintf (tree,MAX_TREE_SIZE ,"\\\\%s\\IPC$" , server->hostname); rc = ops->tree_connect (xid, tcon->ses, tree, tcon, nlsc);
@@ -4195,9 +4196,6 @@ int cifs_tree_connect(const unsigned int goto out; } - rc =dfs_cache_noreq_find (tcon->dfs_path +1 , &ref, &tl); -if (rc) - goto out; isroot = ref.server_type ==DFS_TYPE_ROOT ;free_dfs_info_param (&ref);
Greg Kroah-Hartman
maintainerPATCH 3/292 cifs: Do not use the original cruid when following DFS links for multiuser mounts
In reply to Greg Kroah-HartmanFrom: Ronnie Sahlberg <[email protected]>
commit 50630b3f1ada0bf412d3f28e73bac310448d9d6f upstream.
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=213565
cruid should only be used for the initial mount and after this we should use the current users credentials.
Ignore the original cruid mount argument when creating a new context for a multiuser mount following a DFS link.
--- fs/cifs/cifs_dfs_ref.c | 4 ++++ 1 file changed, 4 insertions(+)
fs/cifs/cifs_dfs_ref.c +4 -0
@@ -208,6 +208,10 @@ char *cifs_compose_mount_options(const celse noff = tkn_e - (sb_mountdata + off) +1 ; +if (strncasecmp (sb_mountdata + off,"cruid=" ,6 ) ==0 ) { + off += noff; +continue ; + }if (strncasecmp (sb_mountdata + off,"unc=" ,4 ) ==0 ) { off += noff;continue ;
Greg Kroah-Hartman
maintainerPATCH 4/292 KVM: mmio: Fix use-after-free Read in kvm_vm_ioctl_unregister_coalesced_mmio
In reply to Greg Kroah-HartmanFrom: Kefeng Wang <[email protected]>
commit 23fa2e46a5556f787ce2ea1a315d3ab93cced204 upstream.
BUG: KASAN: use-after-free in kvm_vm_ioctl_unregister_coalesced_mmio+0x7c/0x1ec arch/arm64/kvm/../../../virt/kvm/coalesced_mmio.c:183 Read of size 8 at addr ffff0000c03a2500 by task syz-executor083/4269 CPU: 5 PID: 4269 Comm: syz-executor083 Not tainted 5.10.0 #7 Hardware name: linux,dummy-virt (DT) Call trace: dump_backtrace+0x0/0x2d0 arch/arm64/kernel/stacktrace.c:132 show_stack+0x28/0x34 arch/arm64/kernel/stacktrace.c:196 __dump_stack lib/dump_stack.c:77 [inline] dump_stack+0x110/0x164 lib/dump_stack.c:118 print_address_description+0x78/0x5c8 mm/kasan/report.c:385 __kasan_report mm/kasan/report.c:545 [inline] kasan_report+0x148/0x1e4 mm/kasan/report.c:562 check_memory_region_inline mm/kasan/generic.c:183 [inline] __asan_load8+0xb4/0xbc mm/kasan/generic.c:252 kvm_vm_ioctl_unregister_coalesced_mmio+0x7c/0x1ec arch/arm64/kvm/../../../virt/kvm/coalesced_mmio.c:183 kvm_vm_ioctl+0xe30/0x14c4 arch/arm64/kvm/../../../virt/kvm/kvm_main.c:3755 vfs_ioctl fs/ioctl.c:48 [inline] __do_sys_ioctl fs/ioctl.c:753 [inline] __se_sys_ioctl fs/ioctl.c:739 [inline] __arm64_sys_ioctl+0xf88/0x131c fs/ioctl.c:739 __invoke_syscall arch/arm64/kernel/syscall.c:36 [inline] invoke_syscall arch/arm64/kernel/syscall.c:48 [inline] el0_svc_common arch/arm64/kernel/syscall.c:158 [inline] do_el0_svc+0x120/0x290 arch/arm64/kernel/syscall.c:220 el0_svc+0x1c/0x28 arch/arm64/kernel/entry-common.c:367 el0_sync_handler+0x98/0x170 arch/arm64/kernel/entry-common.c:383 el0_sync+0x140/0x180 arch/arm64/kernel/entry.S:670 Allocated by task 4269: stack_trace_save+0x80/0xb8 kernel/stacktrace.c:121 kasan_save_stack mm/kasan/common.c:48 [inline] kasan_set_track mm/kasan/common.c:56 [inline] __kasan_kmalloc+0xdc/0x120 mm/kasan/common.c:461 kasan_kmalloc+0xc/0x14 mm/kasan/common.c:475 kmem_cache_alloc_trace include/linux/slab.h:450 [inline] kmalloc include/linux/slab.h:552 [inline] kzalloc include/linux/slab.h:664 [inline] kvm_vm_ioctl_register_coalesced_mmio+0x78/0x1cc arch/arm64/kvm/../../../virt/kvm/coalesced_mmio.c:146 kvm_vm_ioctl+0x7e8/0x14c4 arch/arm64/kvm/../../../virt/kvm/kvm_main.c:3746 vfs_ioctl fs/ioctl.c:48 [inline] __do_sys_ioctl fs/ioctl.c:753 [inline] __se_sys_ioctl fs/ioctl.c:739 [inline] __arm64_sys_ioctl+0xf88/0x131c fs/ioctl.c:739 __invoke_syscall arch/arm64/kernel/syscall.c:36 [inline] invoke_syscall arch/arm64/kernel/syscall.c:48 [inline] el0_svc_common arch/arm64/kernel/syscall.c:158 [inline] do_el0_svc+0x120/0x290 arch/arm64/kernel/syscall.c:220 el0_svc+0x1c/0x28 arch/arm64/kernel/entry-common.c:367 el0_sync_handler+0x98/0x170 arch/arm64/kernel/entry-common.c:383 el0_sync+0x140/0x180 arch/arm64/kernel/entry.S:670 Freed by task 4269: stack_trace_save+0x80/0xb8 kernel/stacktrace.c:121 kasan_save_stack mm/kasan/common.c:48 [inline] kasan_set_track+0x38/0x6c mm/kasan/common.c:56 kasan_set_free_info+0x20/0x40 mm/kasan/generic.c:355 __kasan_slab_free+0x124/0x150 mm/kasan/common.c:422 kasan_slab_free+0x10/0x1c mm/kasan/common.c:431 slab_free_hook mm/slub.c:1544 [inline] slab_free_freelist_hook mm/slub.c:1577 [inline] slab_free mm/slub.c:3142 [inline] kfree+0x104/0x38c mm/slub.c:4124 coalesced_mmio_destructor+0x94/0xa4 arch/arm64/kvm/../../../virt/kvm/coalesced_mmio.c:102 kvm_iodevice_destructor include/kvm/iodev.h:61 [inline] kvm_io_bus_unregister_dev+0x248/0x280 arch/arm64/kvm/../../../virt/kvm/kvm_main.c:4374 kvm_vm_ioctl_unregister_coalesced_mmio+0x158/0x1ec arch/arm64/kvm/../../../virt/kvm/coalesced_mmio.c:186 kvm_vm_ioctl+0xe30/0x14c4 arch/arm64/kvm/../../../virt/kvm/kvm_main.c:3755 vfs_ioctl fs/ioctl.c:48 [inline] __do_sys_ioctl fs/ioctl.c:753 [inline] __se_sys_ioctl fs/ioctl.c:739 [inline] __arm64_sys_ioctl+0xf88/0x131c fs/ioctl.c:739 __invoke_syscall arch/arm64/kernel/syscall.c:36 [inline] invoke_syscall arch/arm64/kernel/syscall.c:48 [inline] el0_svc_common arch/arm64/kernel/syscall.c:158 [inline] do_el0_svc+0x120/0x290 arch/arm64/kernel/syscall.c:220 el0_svc+0x1c/0x28 arch/arm64/kernel/entry-common.c:367 el0_sync_handler+0x98/0x170 arch/arm64/kernel/entry-common.c:383 el0_sync+0x140/0x180 arch/arm64/kernel/entry.S:670
If kvm_io_bus_unregister_dev() return -ENOMEM, we already call kvm_iodevice_destructor() inside this function to delete 'struct kvm_coalesced_mmio_dev *dev' from list and free the dev, but kvm_iodevice_destructor() is called again, it will lead the above issue.
Let's check the the return value of kvm_io_bus_unregister_dev(), only call kvm_iodevice_destructor() if the return value is 0.
Message-Id: <[email protected]>
--- virt/kvm/coalesced_mmio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
virt/kvm/coalesced_mmio.c +1 -1
@@ -186,7 +186,6 @@ int kvm_vm_ioctl_unregister_coalesced_mm coalesced_mmio_in_range(dev, zone->addr, zone->size)) { r =kvm_io_bus_unregister_dev (kvm, zone->pio ?KVM_PIO_BUS :KVM_MMIO_BUS , &dev->dev); -kvm_iodevice_destructor (&dev->dev);/* * On failure, unregister destroys all devices on the
@@ -196,6 +195,7 @@ int kvm_vm_ioctl_unregister_coalesced_mm*/ if (r)break ; +kvm_iodevice_destructor (&dev->dev); } }
Greg Kroah-Hartman
maintainerPATCH 5/292 KVM: x86: Use guest MAXPHYADDR from CPUID.0x8000_0008 iff TDP is enabled
In reply to Greg Kroah-HartmanFrom: Sean Christopherson <[email protected]>
commit 4bf48e3c0aafd32b960d341c4925b48f416f14a5 upstream.
Ignore the guest MAXPHYADDR reported by CPUID.0x8000_0008 if TDP, i.e. NPT, is disabled, and instead use the host's MAXPHYADDR. Per AMD'S APM:
Maximum guest physical address size in bits. This number applies only to guests using nested paging. When this field is zero, refer to the PhysAddrSize field for the maximum guest physical address size.
Message-Id: <[email protected]>
--- arch/x86/kvm/cpuid.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-)
arch/x86/kvm/cpuid.c +7 -1
@@ -844,8 +844,14 @@ static inline int __do_cpuid_func(structunsigned virt_as =max ((entry->eax >>8 ) &0xff ,48U );unsigned phys_as = entry->eax &0xff ; -if (!g_phys_as) +/* +* Use bare metal's MAXPHADDR if the CPU doesn't report guest +* MAXPHYADDR separately, or if TDP (NPT) is disabled, as the +* guest version "applies only to guests using nested paging". +*/ +if (!g_phys_as || !tdp_enabled) g_phys_as = phys_as; + entry->eax = g_phys_as | (virt_as <<8 ); entry->edx =0 ;cpuid_entry_override (entry,CPUID_8000_0008_EBX );
Greg Kroah-Hartman
maintainerPATCH 6/292 KVM: x86/mmu: Do not apply HPA (memory encryption) mask to GPAs
In reply to Greg Kroah-HartmanFrom: Sean Christopherson <[email protected]>
commit fc9bf2e087efcd81bda2e52d09616d2a1bf982a8 upstream.
Ignore "dynamic" host adjustments to the physical address mask when generating the masks for guest PTEs, i.e. the guest PA masks. The host physical address space and guest physical address space are two different beasts, e.g. even though SEV's C-bit is the same bit location for both host and guest, disabling SME in the host (which clears shadow_me_mask) does not affect the guest PTE->GPA "translation".
For non-SEV guests, not dropping bits is the correct behavior. Assuming KVM and userspace correctly enumerate/configure guest MAXPHYADDR, bits that are lost as collateral damage from memory encryption are treated as reserved bits, i.e. KVM will never get to the point where it attempts to generate a gfn using the affected bits. And if userspace wants to create a bogus vCPU, then userspace gets to deal with the fallout of hardware doing odd things with bad GPAs.
For SEV guests, not dropping the C-bit is technically wrong, but it's a moot point because KVM can't read SEV guest's page tables in any case since they're always encrypted. Not to mention that the current KVM code is also broken since sme_me_mask does not have to be non-zero for SEV to be supported by KVM. The proper fix would be to teach all of KVM to correctly handle guest private memory, but that's a task for the future.
Message-Id: <[email protected]>
--- arch/x86/kvm/mmu/mmu.c | 2 ++ arch/x86/kvm/mmu/paging.h | 14 ++++++++++++++ arch/x86/kvm/mmu/paging_tmpl.h | 4 ++-- arch/x86/kvm/mmu/spte.h | 6 ------ 4 files changed, 18 insertions(+), 8 deletions(-) create mode 100644 arch/x86/kvm/mmu/paging.h
arch/x86/kvm/mmu/mmu.c +2 -0
@@ -52,6 +52,8 @@#include <asm/kvm_page_track.h> #include "trace.h" +#include "paging.h" +extern bool itlb_multihit_kvm_mitigation;static int __read_mostly nx_huge_pages =-1 ;
arch/x86/kvm/mmu/paging.h new file +14 -0
@@ -0,0 +1,14 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ +/* Shadow paging constants/helpers that don't need to be #undef'd. */ +#ifndef __KVM_X86_PAGING_H +#define __KVM_X86_PAGING_H + +#define GUEST_PT64_BASE_ADDR_MASK (((1ULL << 52) - 1) & ~(u64)(PAGE_SIZE-1)) +#define PT64_LVL_ADDR_MASK (level) \ + (GUEST_PT64_BASE_ADDR_MASK & ~((1ULL << (PAGE_SHIFT + (((level) - 1) \ + * PT64_LEVEL_BITS))) - 1)) +#define PT64_LVL_OFFSET_MASK (level) \ + (GUEST_PT64_BASE_ADDR_MASK & ((1ULL << (PAGE_SHIFT + (((level) - 1) \ + * PT64_LEVEL_BITS))) - 1)) +#endif /* __KVM_X86_PAGING_H */ +
arch/x86/kvm/mmu/paging_tmpl.h +2 -2
@@ -24,7 +24,7 @@#define pt_element_t u64#define guest_walker guest_walker64#define FNAME (name) paging##64_##name -#define PT_BASE_ADDR_MASK PT64_BASE_ADDR_MASK +#define PT_BASE_ADDR_MASK GUEST_PT64_BASE_ADDR_MASK#define PT_LVL_ADDR_MASK (lvl) PT64_LVL_ADDR_MASK(lvl)#define PT_LVL_OFFSET_MASK (lvl) PT64_LVL_OFFSET_MASK(lvl)#define PT_INDEX (addr, level) PT64_INDEX(addr, level)
@@ -57,7 +57,7 @@#define pt_element_t u64#define guest_walker guest_walkerEPT#define FNAME (name) ept_##name -#define PT_BASE_ADDR_MASK PT64_BASE_ADDR_MASK +#define PT_BASE_ADDR_MASK GUEST_PT64_BASE_ADDR_MASK#define PT_LVL_ADDR_MASK (lvl) PT64_LVL_ADDR_MASK(lvl)#define PT_LVL_OFFSET_MASK (lvl) PT64_LVL_OFFSET_MASK(lvl)#define PT_INDEX (addr, level) PT64_INDEX(addr, level)
arch/x86/kvm/mmu/spte.h +0 -6
@@ -23,12 +23,6 @@#else #define PT64_BASE_ADDR_MASK (((1ULL << 52) - 1) & ~(u64)(PAGE_SIZE-1))#endif -#define PT64_LVL_ADDR_MASK (level) \ - (PT64_BASE_ADDR_MASK & ~((1ULL << (PAGE_SHIFT + (((level) - 1) \ - * PT64_LEVEL_BITS))) - 1)) -#define PT64_LVL_OFFSET_MASK (level) \ - (PT64_BASE_ADDR_MASK & ((1ULL << (PAGE_SHIFT + (((level) - 1) \ - * PT64_LEVEL_BITS))) - 1))#define PT64_PERM_MASK (PT_PRESENT_MASK | PT_WRITABLE_MASK | shadow_user_mask \ | shadow_x_mask | shadow_nx_mask | shadow_me_mask)
Greg Kroah-Hartman
maintainerPATCH 7/292 KVM: nSVM: Check the value written to MSR_VM_HSAVE_PA
In reply to Greg Kroah-HartmanFrom: Vitaly Kuznetsov <[email protected]>
commit fce7e152ffc8f89d02a80617b16c7aa1527847c8 upstream.
APM states that #GP is raised upon write to MSR_VM_HSAVE_PA when the supplied address is not page-aligned or is outside of "maximum supported physical address for this implementation". page_address_valid() check seems suitable. Also, forcefully page-align the address when it's written from VMM.
Message-Id: <[email protected]>
--- arch/x86/kvm/svm/svm.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-)
arch/x86/kvm/svm/svm.c +10 -1
@@ -2982,7 +2982,16 @@ static int svm_set_msr(struct kvm_vcpu *svm_disable_lbrv (vcpu);break ;case MSR_VM_HSAVE_PA : - svm->nested.hsave_msr = data; +/* +* Old kernels did not validate the value written to +* MSR_VM_HSAVE_PA. Allow KVM_SET_MSR to set an invalid +* value to allow live migrating buggy or malicious guests +* originating from those kernels. +*/ +if (!msr->host_initiated && !page_address_valid (vcpu, data)) +return 1 ; + + svm->nested.hsave_msr = data &PAGE_MASK ;break ;case MSR_VM_CR :return svm_set_vm_cr (vcpu, data);
Greg Kroah-Hartman
maintainerPATCH 8/292 KVM: X86: Disable hardware breakpoints unconditionally before kvm_x86->run()
In reply to Greg Kroah-HartmanFrom: Lai Jiangshan <[email protected]>
commit f85d40160691881a17a397c448d799dfc90987ba upstream.
When the host is using debug registers but the guest is not using them nor is the guest in guest-debug state, the kvm code does not reset the host debug registers before kvm_x86->run(). Rather, it relies on the hardware vmentry instruction to automatically reset the dr7 registers which ensures that the host breakpoints do not affect the guest.
This however violates the non-instrumentable nature around VM entry and exit; for example, when a host breakpoint is set on vcpu->arch.cr2,
Another issue is consistency. When the guest debug registers are active, the host breakpoints are reset before kvm_x86->run(). But when the guest debug registers are inactive, the host breakpoints are delayed to be disabled. The host tracing tools may see different results depending on what the guest is doing.
To fix the problems, we clear %db7 unconditionally before kvm_x86->run() if the host has set any breakpoints, no matter if the guest is using them or not.
Message-Id: <[email protected]>
--- arch/x86/kvm/x86.c | 2 ++ 1 file changed, 2 insertions(+)
arch/x86/kvm/x86.c +2 -0
@@ -9194,6 +9194,8 @@ static int vcpu_enter_guest(struct kvm_vset_debugreg (vcpu->arch.eff_db[3 ],3 );set_debugreg (vcpu->arch.dr6,6 ); vcpu->arch.switch_db_regs &= ~KVM_DEBUGREG_RELOAD ; + }else if (unlikely (hw_breakpoint_active ())) { +set_debugreg (0 ,7 ); }for (;;) {
Greg Kroah-Hartman
maintainerPATCH 9/292 scsi: core: Fix bad pointer dereference when ehandler kthread is invalid
In reply to Greg Kroah-HartmanFrom: Tyrel Datwyler <[email protected]>
commit 93aa71ad7379900e61c8adff6a710a4c18c7c99b upstream.
Commit 66a834d09293 ("scsi: core: Fix error handling of scsi_host_alloc()") changed the allocation logic to call put_device() to perform host cleanup with the assumption that IDA removal and stopping the kthread would properly be performed in scsi_host_dev_release(). However, in the unlikely case that the error handler thread fails to spawn, shost->ehandler is set to ERR_PTR(-ENOMEM).
The error handler cleanup code in scsi_host_dev_release() will call kthread_stop() if shost->ehandler != NULL which will always be the case whether the kthread was successfully spawned or not. In the case that it failed to spawn this has the nasty side effect of trying to dereference an invalid pointer when kthread_stop() is called. The following splat provides an example of this behavior in the wild:
scsi host11: error handler thread failed to spawn, error = -4 Kernel attempted to read user page (10c) - exploit attempt? (uid: 0)
BUG: Kernel NULL pointer dereference on read at 0x0000010c Faulting instruction address: 0xc00000000818e9a8 Oops: Kernel access of bad area, sig: 11 [#1] LE PAGE_SIZE=64K MMU=Hash SMP NR_CPUS=2048 NUMA pSeries Modules linked in: ibmvscsi(+) scsi_transport_srp dm_multipath dm_mirror dm_region hash dm_log dm_mod fuse overlay squashfs loop CPU: 12 PID: 274 Comm: systemd-udevd Not tainted 5.13.0-rc7 #1 NIP: c00000000818e9a8 LR: c0000000089846e8 CTR: 0000000000007ee8 REGS: c000000037d12ea0 TRAP: 0300 Not tainted (5.13.0-rc7) MSR: 800000000280b033 <SF,VEC,VSX,EE,FP,ME,IR,DR,RI,LE> CR: 28228228
XER: 20040001
CFAR: c0000000089846e4 DAR: 000000000000010c DSISR: 40000000 IRQMASK: 0
GPR00: c0000000089846e8 c000000037d13140 c000000009cc1100 fffffffffffffffc
GPR04: 0000000000000001 0000000000000000 0000000000000000 c000000037dc0000
GPR08: 0000000000000000 c000000037dc0000 0000000000000001 00000000fffff7ff
GPR12: 0000000000008000 c00000000a049000 c000000037d13d00 000000011134d5a0
GPR16: 0000000000001740 c0080000190d0000 c0080000190d1740 c000000009129288
GPR20: c000000037d13bc0 0000000000000001 c000000037d13bc0 c0080000190b7898
GPR24: c0080000190b7708 0000000000000000 c000000033bb2c48 0000000000000000
GPR28: c000000046b28280 0000000000000000 000000000000010c fffffffffffffffc NIP [c00000000818e9a8] kthread_stop+0x38/0x230
LR [c0000000089846e8] scsi_host_dev_release+0x98/0x160
Call Trace:
[c000000033bb2c48] 0xc000000033bb2c48 (unreliable) [c0000000089846e8] scsi_host_dev_release+0x98/0x160 [c00000000891e960] device_release+0x60/0x100 [c0000000087e55c4] kobject_release+0x84/0x210 [c00000000891ec78] put_device+0x28/0x40 [c000000008984ea4] scsi_host_alloc+0x314/0x430 [c0080000190b38bc] ibmvscsi_probe+0x54/0xad0 [ibmvscsi] [c000000008110104] vio_bus_probe+0xa4/0x4b0 [c00000000892a860] really_probe+0x140/0x680 [c00000000892aefc] driver_probe_device+0x15c/0x200 [c00000000892b63c] device_driver_attach+0xcc/0xe0 [c00000000892b740] __driver_attach+0xf0/0x200 [c000000008926f28] bus_for_each_dev+0xa8/0x130 [c000000008929ce4] driver_attach+0x34/0x50 [c000000008928fc0] bus_add_driver+0x1b0/0x300 [c00000000892c798] driver_register+0x98/0x1a0 [c00000000810eb60] __vio_register_driver+0x80/0xe0 [c0080000190b4a30] ibmvscsi_module_init+0x9c/0xdc [ibmvscsi] [c0000000080121d0] do_one_initcall+0x60/0x2d0 [c000000008261abc] do_init_module+0x7c/0x320 [c000000008265700] load_module+0x2350/0x25b0 [c000000008265cb4] __do_sys_finit_module+0xd4/0x160 [c000000008031110] system_call_exception+0x150/0x2d0 [c00000000800d35c] system_call_common+0xec/0x278
Fix this be nulling shost->ehandler when the kthread fails to spawn.
--- drivers/scsi/hosts.c | 1 + 1 file changed, 1 insertion(+)
drivers/scsi/hosts.c +1 -0
@@ -490,6 +490,7 @@ struct Scsi_Host *scsi_host_alloc(structshost_printk (KERN_WARNING , shost,"error handler thread failed to spawn, error = %ld\n" ,PTR_ERR (shost->ehandler)); + shost->ehandler =NULL ; goto fail; }
Greg Kroah-Hartman
maintainerPATCH 10/292 scsi: zfcp: Report port fc_security as unknown early during remote cable pull
In reply to Greg Kroah-HartmanFrom: Steffen Maier <[email protected]>
commit 8b3bdd99c092bbaeaa7d9eecb1a3e5dc9112002b upstream.
On remote cable pull, a zfcp_port keeps its status and only gets ZFCP_STATUS_PORT_LINK_TEST added. Only after an ADISC timeout, we would actually start port recovery and remove ZFCP_STATUS_COMMON_UNBLOCKED which zfcp_sysfs_port_fc_security_show() detected and reported as "unknown" instead of the old and possibly stale zfcp_port->connection_info.
Add check for ZFCP_STATUS_PORT_LINK_TEST for timely "unknown" report.
--- drivers/s390/scsi/zfcp_sysfs.c | 1 + 1 file changed, 1 insertion(+)
drivers/s390/scsi/zfcp_sysfs.c +1 -0
@@ -487,6 +487,7 @@ static ssize_t zfcp_sysfs_port_fc_securiif (0 == (status &ZFCP_STATUS_COMMON_OPEN ) ||0 == (status &ZFCP_STATUS_COMMON_UNBLOCKED ) ||0 == (status &ZFCP_STATUS_PORT_PHYS_OPEN ) || +0 != (status &ZFCP_STATUS_PORT_LINK_TEST ) ||0 != (status &ZFCP_STATUS_COMMON_ERP_FAILED ) ||0 != (status &ZFCP_STATUS_COMMON_ACCESS_BOXED )) i =sprintf (buf,"unknown\n" );
Greg Kroah-Hartman
maintainerPATCH 11/292 iommu/vt-d: Global devTLB flush when present context entry changed
In reply to Greg Kroah-HartmanFrom: Sanjay Kumar <[email protected]>
commit 37764b952e1b39053defc7ebe5dcd8c4e3e78de9 upstream.
This fixes a bug in context cache clear operation. The code was not following the correct invalidation flow. A global device TLB invalidation should be added after the IOTLB invalidation. At the same time, it uses the domain ID from the context entry. But in scalable mode, the domain ID is in PASID table entry, not context entry.
--- drivers/iommu/intel/iommu.c | 31 ++++++++++++++++++++++--------- 1 file changed, 22 insertions(+), 9 deletions(-)
drivers/iommu/intel/iommu.c +22 -9
@@ -2434,10 +2434,11 @@ __domain_mapping(struct dmar_domain *domreturn 0 ; } -static void domain_context_clear_one (struct intel_iommu *iommu,u8 bus,u8 devfn) +static void domain_context_clear_one (struct device_domain_info *info,u8 bus,u8 devfn) { -unsigned long flags; +struct intel_iommu *iommu = info->iommu;struct context_entry *context; +unsigned long flags;u16 did_old;if (!iommu)
@@ -2449,7 +2450,16 @@ static void domain_context_clear_one(strspin_unlock_irqrestore (&iommu->lock, flags);return ; } - did_old =context_domain_id (context); + +if (sm_supported (iommu)) { +if (hw_pass_through &&domain_type_is_si (info->domain)) + did_old =FLPT_DEFAULT_DID ; +else + did_old = info->domain->iommu_did[iommu->seq_id]; + }else { + did_old =context_domain_id (context); + } +context_clear_entry (context);__iommu_flush_cache (iommu, context,sizeof (*context));spin_unlock_irqrestore (&iommu->lock, flags);
@@ -2467,6 +2477,8 @@ static void domain_context_clear_one(str0 ,0 , DMA_TLB_DSI_FLUSH); + +__iommu_flush_dev_iotlb (info,0 ,MAX_AGAW_PFN_WIDTH ); }static inline void unlink_domain_info (struct device_domain_info *info)
@@ -4456,9 +4468,9 @@ out_free_dmar:static int domain_context_clear_one_cb (struct pci_dev *pdev,u16 alias,void *opaque) { -struct intel_iommu *iommu = opaque; +struct device_domain_info *info = opaque; -domain_context_clear_one (iommu,PCI_BUS_NUM (alias), alias &0xff ); +domain_context_clear_one (info,PCI_BUS_NUM (alias), alias &0xff );return 0 ; }
@@ -4468,12 +4480,13 @@ static int domain_context_clear_one_cb(s* devices, unbinding the driver from any one of them will possibly leave * the others unable to operate. */ -static void domain_context_clear (struct intel_iommu *iommu,struct device *dev) +static void domain_context_clear (struct device_domain_info *info) { -if (!iommu || !dev || !dev_is_pci (dev)) +if (!info->iommu || !info->dev || !dev_is_pci (info->dev))return ; -pci_for_each_dma_alias (to_pci_dev (dev), &domain_context_clear_one_cb, iommu); +pci_for_each_dma_alias (to_pci_dev (info->dev), + &domain_context_clear_one_cb, info); }static void __dmar_remove_one_dev_info (struct device_domain_info *info)
@@ -4497,7 +4510,7 @@ static void __dmar_remove_one_dev_info(siommu_disable_dev_iotlb (info);if (!dev_is_real_dma_subdevice (info->dev)) -domain_context_clear (iommu, info->dev); +domain_context_clear (info);intel_pasid_free_table (info->dev); }
Greg Kroah-Hartman
maintainerPATCH 12/292 iommu/vt-d: Fix clearing real DMA devices scalable-mode context entries
In reply to Greg Kroah-HartmanFrom: Lu Baolu <[email protected]>
commit 474dd1c6506411752a9b2f2233eec11f1733a099 upstream.
The commit 2b0140c69637e ("iommu/vt-d: Use pci_real_dma_dev() for mapping") fixes an issue of "sub-device is removed where the context entry is cleared for all aliases". But this commit didn't consider the PASID entry and PASID table in VT-d scalable mode. This fix increases the coverage of scalable mode.
--- drivers/iommu/intel/iommu.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/iommu/intel/iommu.c +2 -3
@@ -4503,14 +4503,13 @@ static void __dmar_remove_one_dev_info(s iommu = info->iommu; domain = info->domain; -if (info->dev) { +if (info->dev && !dev_is_real_dma_subdevice (info->dev)) {if (dev_is_pci (info->dev) &&sm_supported (iommu))intel_pasid_tear_down_entry (iommu, info->dev,PASID_RID2PASID , false);iommu_disable_dev_iotlb (info); -if (!dev_is_real_dma_subdevice (info->dev)) -domain_context_clear (info); +domain_context_clear (info);intel_pasid_free_table (info->dev); }
Greg Kroah-Hartman
maintainerPATCH 13/292 tracing: Do not reference char * as a string in histograms
In reply to Greg Kroah-HartmanFrom: Steven Rostedt (VMware) <[email protected]>
commit 704adfb5a9978462cd861f170201ae2b5e3d3a80 upstream.
The histogram logic was allowing events with char * pointers to be used as normal strings. But it was easy to crash the kernel with:
# echo 'hist:keys=filename' > events/syscalls/sys_enter_openat/trigger
And open some files, and boom!
BUG: unable to handle page fault for address: 00007f2ced0c3280 #PF: supervisor read access in kernel mode #PF: error_code(0x0000) - not-present page PGD 1173fa067 P4D 1173fa067 PUD 1171b6067 PMD 1171dd067 PTE 0 Oops: 0000 [#1] PREEMPT SMP CPU: 6 PID: 1810 Comm: cat Not tainted 5.13.0-rc5-test+ #61 Hardware name: Hewlett-Packard HP Compaq Pro 6300 SFF/339A, BIOS K01 v03.03 07/14/2016 RIP: 0010:strlen+0x0/0x20 Code: f6 82 80 2a 0b a9 20 74 11 0f b6 50 01 48 83 c0 01 f6 82 80 2a 0b
a9 20 75 ef c3 66 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 <80> 3f 00 74 10 48 89 f8 48 83 c0 01 80 38 00 75 f7 48 29 f8 c3
RSP: 0018:ffffbdbf81567b50 EFLAGS: 00010246
RAX: 0000000000000003 RBX: ffff93815cdb3800 RCX: ffff9382401a22d0
RDX: 0000000000000100 RSI: 0000000000000000 RDI: 00007f2ced0c3280
RBP: 0000000000000100 R08: ffff9382409ff074 R09: ffffbdbf81567c98
R10: ffff9382409ff074 R11: 0000000000000000 R12: ffff9382409ff074
R13: 0000000000000001 R14: ffff93815a744f00 R15: 00007f2ced0c3280
FS: 00007f2ced0f8580(0000) GS:ffff93825a800000(0000)
knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00007f2ced0c3280 CR3: 0000000107069005 CR4: 00000000001706e0
Call Trace: event_hist_trigger+0x463/0x5f0 ? find_held_lock+0x32/0x90 ? sched_clock_cpu+0xe/0xd0 ? lock_release+0x155/0x440 ? kernel_init_free_pages+0x6d/0x90 ? preempt_count_sub+0x9b/0xd0 ? kernel_init_free_pages+0x6d/0x90 ? get_page_from_freelist+0x12c4/0x1680 ? __rb_reserve_next+0xe5/0x460 ? ring_buffer_lock_reserve+0x12a/0x3f0 event_triggers_call+0x52/0xe0 ftrace_syscall_enter+0x264/0x2c0 syscall_trace_enter.constprop.0+0x1ee/0x210 do_syscall_64+0x1c/0x80 entry_SYSCALL_64_after_hwframe+0x44/0xae
Where it triggered a fault on strlen(key) where key was the filename.
The reason is that filename is a char * to user space, and the histogram code just blindly dereferenced it, with obvious bad results.
I originally tried to use strncpy_from_user/kernel_nofault() but found that there's other places that its dereferenced and not worth the effort.
Just do not allow "char *" to act like strings.
--- kernel/trace/trace_events_hist.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
kernel/trace/trace_events_hist.c +3 -3
@@ -1673,7 +1673,9 @@ static struct hist_field *create_hist_fiif (WARN_ON_ONCE (!field)) goto out; -if (is_string_field (field)) { +/* Pointers to strings are just pointers and dangerous to dereference */ +if (is_string_field (field) && + (field->filter_type !=FILTER_PTR_STRING )) { flags |=HIST_FIELD_FL_STRING ; hist_field->size =MAX_FILTER_STR_VAL ;
@@ -4469,8 +4471,6 @@ static inline void add_to_key(char *comp field = key_field->field;if (field->filter_type ==FILTER_DYN_STRING ) size = *(u32 *)(rec + field->offset) >>16 ; -else if (field->filter_type ==FILTER_PTR_STRING ) - size =strlen (key);else if (field->filter_type ==FILTER_STATIC_STRING ) size = field->size;
Greg Kroah-Hartman
maintainerPATCH 14/292 drm/amdgpu: add another Renoir DID
In reply to Greg Kroah-HartmanFrom: Jinzhou Su <[email protected]>
commit 775da83005cb61d4c213c636df9337da05714ff1 upstream.
Add new PCI device id.
--- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 1 + 1 file changed, 1 insertion(+)
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c +1 -0
@@ -1092,6 +1092,7 @@ static const struct pci_device_id pciidl {0x1002, 0x734F, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CHIP_NAVI14},/* Renoir */ + {0x1002, 0x15E7, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CHIP_RENOIR|AMD_IS_APU}, {0x1002, 0x1636, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CHIP_RENOIR|AMD_IS_APU}, {0x1002, 0x1638, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CHIP_RENOIR|AMD_IS_APU}, {0x1002, 0x164C, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CHIP_RENOIR|AMD_IS_APU},
Greg Kroah-Hartman
maintainerPATCH 15/292 drm/i915/gtt: drop the page table optimisation
In reply to Greg Kroah-HartmanFrom: Matthew Auld <[email protected]>
commit 0abb33bfca0fb74df76aac03e90ce685016ef7be upstream.
We skip filling out the pt with scratch entries if the va range covers the entire pt, since we later have to fill it with the PTEs for the object pages anyway. However this might leave open a small window where the PTEs don't point to anything valid for the HW to consume.
When for example using 2M GTT pages this fill_px() showed up as being quite significant in perf measurements, and ends up being completely wasted since we ignore the pt and just use the pde directly.
Anyway, currently we have our PTE construction split between alloc and insert, which is probably slightly iffy nowadays, since the alloc doesn't actually allocate anything anymore, instead it just sets up the page directories and points the PTEs at the scratch page. Later when we do the insert step we re-program the PTEs again. Better might be to squash the alloc and insert into a single step, then bringing back this optimisation(along with some others) should be possible.
--- drivers/gpu/drm/i915/gt/gen8_ppgtt.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)
drivers/gpu/drm/i915/gt/gen8_ppgtt.c +1 -4
@@ -298,10 +298,7 @@ static void __gen8_ppgtt_alloc(struct i9__i915_gem_object_pin_pages (pt->base);i915_gem_object_make_unshrinkable (pt->base); -if (lvl || -gen8_pt_count (*start, end) <I915_PDES || -intel_vgpu_active (vm->i915)) -fill_px (pt, vm->scratch[lvl]->encode); +fill_px (pt, vm->scratch[lvl]->encode);spin_lock (&pd->lock);if (likely (!pd->entry[idx])) {
Greg Kroah-Hartman
maintainerPATCH 16/292 drm/i915/gt: Fix -EDEADLK handling regression
In reply to Greg Kroah-HartmanFrom: Ville Syrjälä <[email protected]>
commit 2feeb52859fc1ab94cd35b61ada3a6ac4ff24243 upstream.
The conversion to ww mutexes failed to address the fence code which already returns -EDEADLK when we run out of fences. Ww mutexes on the other hand treat -EDEADLK as an internal errno value indicating a need to restart the operation due to a deadlock. So now when the fence code returns -EDEADLK the higher level code erroneously restarts everything instead of returning the error to userspace as is expected.
To remedy this let's switch the fence code to use a different errno value for this. -ENOBUFS seems like a semi-reasonable unique choice. Apart from igt the only user of this I could find is sna, and even there all we do is dump the current fence registers from debugfs into the X server log. So no user visible functionality is affected. If we really cared about preserving this we could of course convert back to -EDEADLK higher up, but doesn't seem like that's worth the hassle here.
Not quite sure which commit specifically broke this, but I'll just attribute it to the general gem ww mutex work.
Cc: [email protected]
Cc: Maarten Lankhorst <[email protected]>
Cc: Thomas Hellström <[email protected]>
Testcase: igt/gem_pread/exhaustion
Testcase: igt/gem_pwrite/basic-exhaustion
Testcase: igt/gem_fenced_exec_thrash/too-many-fences
--- drivers/gpu/drm/i915/gt/intel_ggtt_fencing.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/gt/intel_ggtt_fencing.c +1 -1
@@ -366,7 +366,7 @@ static struct i915_fence_reg *fence_findif (intel_has_pending_fb_unpin (ggtt->vm.i915))return ERR_PTR (-EAGAIN ); -return ERR_PTR (-EDEADLK ); +return ERR_PTR (-ENOBUFS ); }int __i915_vma_pin_fence (struct i915_vma *vma)
Greg Kroah-Hartman
maintainerPATCH 17/292 cgroup: verify that source is a string
In reply to Greg Kroah-HartmanFrom: Christian Brauner <[email protected]>
commit 3b0462726e7ef281c35a7a4ae33e93ee2bc9975b upstream.
The following sequence can be used to trigger a UAF:
int fscontext_fd = fsopen("cgroup");
int fd_null = open("/dev/null, O_RDONLY);
int fsconfig(fscontext_fd, FSCONFIG_SET_FD, "source", fd_null);
close_range(3, ~0U, 0);The cgroup v1 specific fs parser expects a string for the "source" parameter. However, it is perfectly legitimate to e.g. specify a file descriptor for the "source" parameter. The fs parser doesn't know what a filesystem allows there. So it's a bug to assume that "source" is always of type fs_value_is_string when it can reasonably also be fs_value_is_file.
This assumption in the cgroup code causes a UAF because struct fs_parameter uses a union for the actual value. Access to that union is guarded by the param->type member. Since the cgroup paramter parser didn't check param->type but unconditionally moved param->string into fc->source a close on the fscontext_fd would trigger a UAF during put_fs_context() which frees fc->source thereby freeing the file stashed in param->file causing a UAF during a close of the fd_null.
Fix this by verifying that param->type is actually a string and report an error if not.
In follow up patches I'll add a new generic helper that can be used here and by other filesystems instead of this error-prone copy-pasta fix. But fixing it in here first makes backporting a it to stable a lot easier.
--- kernel/cgroup/cgroup-v1.c | 2 ++ 1 file changed, 2 insertions(+)
kernel/cgroup/cgroup-v1.c +2 -0
@@ -912,6 +912,8 @@ int cgroup1_parse_param(struct fs_contex opt =fs_parse (fc, cgroup1_fs_parameters, param, &result);if (opt == -ENOPARAM ) {if (strcmp (param->key,"source" ) ==0 ) { +if (param->type != fs_value_is_string) +return invalf (fc,"Non-string source" );if (fc->source)return invalf (fc,"Multiple sources not supported" ); fc->source = param->string;
Greg Kroah-Hartman
maintainerPATCH 18/292 fbmem: Do not delete the mode that is still in use
In reply to Greg Kroah-HartmanFrom: Zhen Lei <[email protected]>
commit 0af778269a522c988ef0b4188556aba97fb420cc upstream.
The execution of fb_delete_videomode() is not based on the result of the previous fbcon_mode_deleted(). As a result, the mode is directly deleted, regardless of whether it is still in use, which may cause UAF.
==================================================================
BUG: KASAN: use-after-free in fb_mode_is_equal+0x36e/0x5e0 \ drivers/video/fbdev/core/modedb.c:924 Read of size 4 at addr ffff88807e0ddb1c by task syz-executor.0/18962 CPU: 2 PID: 18962 Comm: syz-executor.0 Not tainted 5.10.45-rc1+ #3 Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS ... Call Trace: __dump_stack lib/dump_stack.c:77 [inline] dump_stack+0x137/0x1be lib/dump_stack.c:118 print_address_description+0x6c/0x640 mm/kasan/report.c:385 __kasan_report mm/kasan/report.c:545 [inline] kasan_report+0x13d/0x1e0 mm/kasan/report.c:562 fb_mode_is_equal+0x36e/0x5e0 drivers/video/fbdev/core/modedb.c:924 fbcon_mode_deleted+0x16a/0x220 drivers/video/fbdev/core/fbcon.c:2746 fb_set_var+0x1e1/0xdb0 drivers/video/fbdev/core/fbmem.c:975 do_fb_ioctl+0x4d9/0x6e0 drivers/video/fbdev/core/fbmem.c:1108 vfs_ioctl fs/ioctl.c:48 [inline] __do_sys_ioctl fs/ioctl.c:753 [inline] __se_sys_ioctl+0xfb/0x170 fs/ioctl.c:739 do_syscall_64+0x2d/0x70 arch/x86/entry/common.c:46 entry_SYSCALL_64_after_hwframe+0x44/0xa9 Freed by task 18960: kasan_save_stack mm/kasan/common.c:48 [inline] kasan_set_track+0x3d/0x70 mm/kasan/common.c:56 kasan_set_free_info+0x17/0x30 mm/kasan/generic.c:355 __kasan_slab_free+0x108/0x140 mm/kasan/common.c:422 slab_free_hook mm/slub.c:1541 [inline] slab_free_freelist_hook+0xd6/0x1a0 mm/slub.c:1574 slab_free mm/slub.c:3139 [inline] kfree+0xca/0x3d0 mm/slub.c:4121 fb_delete_videomode+0x56a/0x820 drivers/video/fbdev/core/modedb.c:1104 fb_set_var+0x1f3/0xdb0 drivers/video/fbdev/core/fbmem.c:978 do_fb_ioctl+0x4d9/0x6e0 drivers/video/fbdev/core/fbmem.c:1108 vfs_ioctl fs/ioctl.c:48 [inline] __do_sys_ioctl fs/ioctl.c:753 [inline] __se_sys_ioctl+0xfb/0x170 fs/ioctl.c:739 do_syscall_64+0x2d/0x70 arch/x86/entry/common.c:46 entry_SYSCALL_64_after_hwframe+0x44/0xa9
--- drivers/video/fbdev/core/fbmem.c | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-)
drivers/video/fbdev/core/fbmem.c +5 -7
@@ -970,13 +970,11 @@ fb_set_var(struct fb_info *info, structfb_var_to_videomode (&mode2, &info->var);/* make sure we don't delete the videomode of current var */ ret =fb_mode_is_equal (&mode1, &mode2); - -if (!ret) -fbcon_mode_deleted (info, &mode1); - -if (!ret) -fb_delete_videomode (&mode1, &info->modelist); - +if (!ret) { + ret =fbcon_mode_deleted (info, &mode1); +if (!ret) +fb_delete_videomode (&mode1, &info->modelist); + }return ret ? -EINVAL :0 ; }
Greg Kroah-Hartman
maintainerPATCH 19/292 EDAC/igen6: fix core dependency AGAIN
In reply to Greg Kroah-HartmanFrom: Randy Dunlap <[email protected]>
commit a1c9ca5f65c9acfd7c02474b9d5cacbd7ea288df upstream.
My previous patch had a typo/thinko which prevents this driver from being enabled: change X64_64 to X86_64.
--- drivers/edac/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/edac/Kconfig +1 -1
@@ -271,7 +271,7 @@ config EDAC_PND2 config EDAC_IGEN6 tristate "Intel client SoC Integrated MC" depends on PCI && PCI_MMCONFIG && ARCH_HAVE_NMI_SAFE_CMPXCHG - depends on X64_64 && X86_MCE_INTEL + depends on X86_64 && X86_MCE_INTEL help Support for error detection and correction on the Intel client SoC Integrated Memory Controller using In-Band ECC IP.
Greg Kroah-Hartman
maintainerPATCH 20/292 mm/hugetlb: fix refs calculation from unaligned @vaddr
In reply to Greg Kroah-HartmanFrom: Joao Martins <[email protected]>
commit d08af0a59684e18a51aa4bfd24c658994ea3fc5b upstream.
Commit 82e5d378b0e47 ("mm/hugetlb: refactor subpage recording") refactored the count of subpages but missed an edge case when @vaddr is not aligned to PAGE_SIZE e.g. when close to vma->vm_end. It would then errousnly set @refs to 0 and record_subpages_vmas() wouldn't set the @pages array element to its value, consequently causing the reported null-deref by syzbot.
Fix it by aligning down @vaddr by PAGE_SIZE in @refs calculation.
--- mm/hugetlb.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
mm/hugetlb.c +3 -2
@@ -5029,8 +5029,9 @@ long follow_hugetlb_page(struct mm_struccontinue ; } - refs =min3 (pages_per_huge_page (h) - pfn_offset, - (vma->vm_end - vaddr) >>PAGE_SHIFT , remainder); +/* vaddr may not be aligned to PAGE_SIZE */ + refs =min3 (pages_per_huge_page (h) - pfn_offset, remainder, + (vma->vm_end -ALIGN_DOWN (vaddr,PAGE_SIZE )) >>PAGE_SHIFT );if (pages || vmas) record_subpages_vmas(mem_map_offset(page, pfn_offset),
Greg Kroah-Hartman
maintainerPATCH 21/292 arm64: Avoid premature usercopy failure
In reply to Greg Kroah-HartmanFrom: Robin Murphy <[email protected]>
commit 295cf156231ca3f9e3a66bde7fab5e09c41835e0 upstream.
Al reminds us that the usercopy API must only return complete failure if absolutely nothing could be copied. Currently, if userspace does something silly like giving us an unaligned pointer to Device memory, or a size which overruns MTE tag bounds, we may fail to honour that requirement when faulting on a multi-byte access even though a smaller access could have succeeded.
Add a mitigation to the fixup routines to fall back to a single-byte copy if we faulted on a larger access before anything has been written to the destination, to guarantee making *some* forward progress. We needn't be too concerned about the overall performance since this should only occur when callers are doing something a bit dodgy in the first place. Particularly broken userspace might still be able to trick generic_perform_write() into an infinite loop by targeting write() at an mmap() of some read-only device register where the fault-in load succeeds but any store synchronously aborts such that copy_to_user() is genuinely unable to make progress, but, well, don't do that...
--- arch/arm64/lib/copy_from_user.S | 13 ++++++++++--- arch/arm64/lib/copy_in_user.S | 21 ++++++++++++++------- arch/arm64/lib/copy_to_user.S | 14 +++++++++++--- 3 files changed, 35 insertions(+), 13 deletions(-)
arch/arm64/lib/copy_from_user.S +10 -3
@@ -29,7 +29,7 @@ .endm .macro ldrh1 reg, ptr, val - user_ldst 9998f, ldtrh, \reg, \ptr, \val + user_ldst 9997f, ldtrh, \reg, \ptr, \val .endm .macro strh1 reg, ptr, val
@@ -37,7 +37,7 @@ .endm .macro ldr1 reg, ptr, val - user_ldst 9998f, ldtr, \reg, \ptr, \val + user_ldst 9997f, ldtr, \reg, \ptr, \val .endm .macro str1 reg, ptr, val
@@ -45,7 +45,7 @@ .endm .macro ldp1 reg1, reg2, ptr, val - user_ldp 9998f, \reg1, \reg2, \ptr, \val + user_ldp 9997f, \reg1, \reg2, \ptr, \val .endm .macro stp1 reg1, reg2, ptr, val
@@ -53,8 +53,10 @@ .endm end .req x5 +srcin .req x15 SYM_FUNC_START(__arch_copy_from_user) add end, x0, x2 + mov srcin, x1 #include "copy_template.S" mov x0, #0 // Nothing to copy ret
@@ -63,6 +65,11 @@ EXPORT_SYMBOL(__arch_copy_from_user) .section .fixup,"ax" .align 2 +9997: cmp dst, dstin + b.ne 9998f + // Before being absolutely sure we couldn't copy anything, try harder +USER(9998f, ldtrb tmp1w, [srcin]) + strb tmp1w, [dst], #1 9998: sub x0, end, dst // bytes not copied ret .previous
arch/arm64/lib/copy_in_user.S +14 -7
@@ -30,33 +30,34 @@ .endm .macro ldrh1 reg, ptr, val - user_ldst 9998f, ldtrh, \reg, \ptr, \val + user_ldst 9997f, ldtrh, \reg, \ptr, \val .endm .macro strh1 reg, ptr, val - user_ldst 9998f, sttrh, \reg, \ptr, \val + user_ldst 9997f, sttrh, \reg, \ptr, \val .endm .macro ldr1 reg, ptr, val - user_ldst 9998f, ldtr, \reg, \ptr, \val + user_ldst 9997f, ldtr, \reg, \ptr, \val .endm .macro str1 reg, ptr, val - user_ldst 9998f, sttr, \reg, \ptr, \val + user_ldst 9997f, sttr, \reg, \ptr, \val .endm .macro ldp1 reg1, reg2, ptr, val - user_ldp 9998f, \reg1, \reg2, \ptr, \val + user_ldp 9997f, \reg1, \reg2, \ptr, \val .endm .macro stp1 reg1, reg2, ptr, val - user_stp 9998f, \reg1, \reg2, \ptr, \val + user_stp 9997f, \reg1, \reg2, \ptr, \val .endm end .req x5 - +srcin .req x15 SYM_FUNC_START(__arch_copy_in_user) add end, x0, x2 + mov srcin, x1 #include "copy_template.S" mov x0, #0 ret
@@ -65,6 +66,12 @@ EXPORT_SYMBOL(__arch_copy_in_user) .section .fixup,"ax" .align 2 +9997: cmp dst, dstin + b.ne 9998f + // Before being absolutely sure we couldn't copy anything, try harder +USER(9998f, ldtrb tmp1w, [srcin]) +USER(9998f, sttrb tmp1w, [dst]) + add dst, dst, #1 9998: sub x0, end, dst // bytes not copied ret .previous
arch/arm64/lib/copy_to_user.S +11 -3
@@ -32,7 +32,7 @@ .endm .macro strh1 reg, ptr, val - user_ldst 9998f, sttrh, \reg, \ptr, \val + user_ldst 9997f, sttrh, \reg, \ptr, \val .endm .macro ldr1 reg, ptr, val
@@ -40,7 +40,7 @@ .endm .macro str1 reg, ptr, val - user_ldst 9998f, sttr, \reg, \ptr, \val + user_ldst 9997f, sttr, \reg, \ptr, \val .endm .macro ldp1 reg1, reg2, ptr, val
@@ -48,12 +48,14 @@ .endm .macro stp1 reg1, reg2, ptr, val - user_stp 9998f, \reg1, \reg2, \ptr, \val + user_stp 9997f, \reg1, \reg2, \ptr, \val .endm end .req x5 +srcin .req x15 SYM_FUNC_START(__arch_copy_to_user) add end, x0, x2 + mov srcin, x1 #include "copy_template.S" mov x0, #0 ret
@@ -62,6 +64,12 @@ EXPORT_SYMBOL(__arch_copy_to_user) .section .fixup,"ax" .align 2 +9997: cmp dst, dstin + b.ne 9998f + // Before being absolutely sure we couldn't copy anything, try harder + ldrb tmp1w, [srcin] +USER(9998f, sttrb tmp1w, [dst]) + add dst, dst, #1 9998: sub x0, end, dst // bytes not copied ret .previous
Greg Kroah-Hartman
maintainerPATCH 22/292 io_uring: use right task for exiting checks
In reply to Greg Kroah-HartmanFrom: Pavel Begunkov <[email protected]>
commit 9c6882608bce249a8918744ecdb65748534e3f17 upstream.
When we use delayed_work for fallback execution of requests, current will be not of the submitter task, and so checks in io_req_task_submit() may not behave as expected. Currently, it leaves inline completions not flushed, so making io_ring_exit_work() to hang. Use the submitter task for all those checks.
--- fs/io_uring.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
fs/io_uring.c +1 -1
@@ -2023,7 +2023,7 @@ static void __io_req_task_submit(struct/* ctx stays valid until unlock, even if we drop all ours ctx->refs */ mutex_lock (&ctx->uring_lock); -if (!(current->flags &PF_EXITING ) && !current->in_execve) +if (!(req->task->flags &PF_EXITING ) && !req->task->in_execve)__io_queue_sqe (req);else __io_req_task_cancel (req, -EFAULT );
Greg Kroah-Hartman
maintainerPATCH 23/292 btrfs: properly split extent_map for REQ_OP_ZONE_APPEND
In reply to Greg Kroah-HartmanFrom: Naohiro Aota <[email protected]>
commit abb99cfdaf0759f8a619e5fecf52ccccdf310c8c upstream.
Damien reported a test failure with btrfs/209. The test itself ran fine, but the fsck ran afterwards reported a corrupted filesystem.
The filesystem corruption happens because we're splitting an extent and then writing the extent twice. We have to split the extent though, because we're creating too large extents for a REQ_OP_ZONE_APPEND operation.
When dumping the extent tree, we can see two EXTENT_ITEMs at the same start address but different lengths.
$ btrfs inspect dump-tree /dev/nullb1 -t extent
...
item 19 key (269484032 EXTENT_ITEM 126976) itemoff 15470 itemsize 53
refs 1 gen 7 flags DATA
extent data backref root FS_TREE objectid 257 offset 786432 count 1
item 20 key (269484032 EXTENT_ITEM 262144) itemoff 15417 itemsize 53
refs 1 gen 7 flags DATA
extent data backref root FS_TREE objectid 257 offset 786432 count 1The duplicated EXTENT_ITEMs originally come from wrongly split extent_map in extract_ordered_extent(). Since extract_ordered_extent() uses create_io_em() to split an existing extent_map, we will have split->orig_start != split->start. Then, it will be logged with non-zero "extent data offset". Finally, the logged entries are replayed into a duplicated EXTENT_ITEM.
Introduce and use proper splitting function for extent_map. The function is intended to be simple and specific usage for extract_ordered_extent() e.g. not supporting compression case (we do not allow splitting compressed extent_map anyway).
There was a question raised by Qu, in summary why we want to split the extent map (and not the bio):
The problem is not the limit on the zone end, which as you mention is the same as the block group end. The problem is that data write use zone append (ZA) operations. ZA BIOs cannot be split so a large extent may need to be processed with multiple ZA BIOs, While that is also true for regular writes, the major difference is that ZA are "nameless" write operation giving back the written sectors on completion. And ZA operations may be reordered by the block layer (not intentionally though). Combine both of these characteristics and you can see that the data for a large extent may end up being shuffled when written resulting in data corruption and the impossibility to map the extent to some start sector.
To avoid this problem, zoned btrfs uses the principle "one data extent == one ZA BIO". So large extents need to be split. This is unfortunate, but we can revisit this later and optimize, e.g. merge back together the fragments of an extent once written if they actually were written sequentially in the zone.
--- fs/btrfs/inode.c | 147 ++++++++++++++++++++++++++++++++++++++++++++----------- 1 file changed, 118 insertions(+), 29 deletions(-)
fs/btrfs/inode.c +118 -29
@@ -2271,13 +2271,127 @@ bool btrfs_bio_fits_in_ordered_extent(streturn ret; } +/* +* Split an extent_map at [start, start + len] +* +* This function is intended to be used only for extract_ordered_extent(). +*/ +static int split_zoned_em (struct btrfs_inode *inode,u64 start,u64 len, +u64 pre,u64 post) +{ +struct extent_map_tree *em_tree = &inode->extent_tree; +struct extent_map *em; +struct extent_map *split_pre =NULL ; +struct extent_map *split_mid =NULL ; +struct extent_map *split_post =NULL ; +int ret =0 ; +int modified; +unsigned long flags; + +/* Sanity check */ +if (pre ==0 && post ==0 ) +return 0 ; + + split_pre =alloc_extent_map (); +if (pre) + split_mid =alloc_extent_map (); +if (post) + split_post =alloc_extent_map (); +if (!split_pre || (pre && !split_mid) || (post && !split_post)) { + ret = -ENOMEM ; + goto out; + } + +ASSERT (pre + post < len); + +lock_extent (&inode->io_tree, start, start + len -1 ); +write_lock (&em_tree->lock); + em =lookup_extent_mapping (em_tree, start, len); +if (!em) { + ret = -EIO ; + goto out_unlock; + } + +ASSERT (em->len == len); +ASSERT (!test_bit (EXTENT_FLAG_COMPRESSED , &em->flags)); +ASSERT (em->block_start <EXTENT_MAP_LAST_BYTE ); + + flags = em->flags; +clear_bit (EXTENT_FLAG_PINNED , &em->flags); +clear_bit (EXTENT_FLAG_LOGGING , &flags); + modified = !list_empty (&em->list); + +/* First, replace the em with a new extent_map starting from * em->start */ + split_pre->start = em->start; + split_pre->len = (pre ? pre : em->len - post); + split_pre->orig_start = split_pre->start; + split_pre->block_start = em->block_start; + split_pre->block_len = split_pre->len; + split_pre->orig_block_len = split_pre->block_len; + split_pre->ram_bytes = split_pre->len; + split_pre->flags = flags; + split_pre->compress_type = em->compress_type; + split_pre->generation = em->generation; + +replace_extent_mapping (em_tree, em, split_pre, modified); + +/* +* Now we only have an extent_map at: +* [em->start, em->start + pre] if pre != 0 +* [em->start, em->start + em->len - post] if pre == 0 +*/ + +if (pre) { +/* Insert the middle extent_map */ + split_mid->start = em->start + pre; + split_mid->len = em->len - pre - post; + split_mid->orig_start = split_mid->start; + split_mid->block_start = em->block_start + pre; + split_mid->block_len = split_mid->len; + split_mid->orig_block_len = split_mid->block_len; + split_mid->ram_bytes = split_mid->len; + split_mid->flags = flags; + split_mid->compress_type = em->compress_type; + split_mid->generation = em->generation; +add_extent_mapping (em_tree, split_mid, modified); + } + +if (post) { + split_post->start = em->start + em->len - post; + split_post->len = post; + split_post->orig_start = split_post->start; + split_post->block_start = em->block_start + em->len - post; + split_post->block_len = split_post->len; + split_post->orig_block_len = split_post->block_len; + split_post->ram_bytes = split_post->len; + split_post->flags = flags; + split_post->compress_type = em->compress_type; + split_post->generation = em->generation; +add_extent_mapping (em_tree, split_post, modified); + } + +/* Once for us */ +free_extent_map (em); +/* Once for the tree */ +free_extent_map (em); + +out_unlock: +write_unlock (&em_tree->lock); +unlock_extent (&inode->io_tree, start, start + len -1 ); +out: +free_extent_map (split_pre); +free_extent_map (split_mid); +free_extent_map (split_post); + +return ret; +} +static blk_status_t extract_ordered_extent (struct btrfs_inode *inode,struct bio *bio,loff_t file_offset) {struct btrfs_ordered_extent *ordered; -struct extent_map *em =NULL , *em_new =NULL ; -struct extent_map_tree *em_tree = &inode->extent_tree;u64 start = (u64 )bio->bi_iter.bi_sector <<SECTOR_SHIFT ; +u64 file_len;u64 len = bio->bi_iter.bi_size;u64 end = start + len;u64 ordered_end;
@@ -2317,41 +2431,16 @@ static blk_status_t extract_ordered_exte goto out; } + file_len = ordered->num_bytes; pre = start - ordered->disk_bytenr; post = ordered_end - end; ret =btrfs_split_ordered_extent (ordered, pre, post);if (ret) goto out; - -read_lock (&em_tree->lock); - em =lookup_extent_mapping (em_tree, ordered->file_offset, len); -if (!em) { -read_unlock (&em_tree->lock); - ret = -EIO ; - goto out; - } -read_unlock (&em_tree->lock); - -ASSERT (!test_bit (EXTENT_FLAG_COMPRESSED , &em->flags)); -/* -* We cannot reuse em_new here but have to create a new one, as -* unpin_extent_cache() expects the start of the extent map to be the -* logical offset of the file, which does not hold true anymore after -* splitting. -*/ - em_new =create_io_em (inode, em->start + pre, len, - em->start + pre, em->block_start + pre, len, - len, len,BTRFS_COMPRESS_NONE , -BTRFS_ORDERED_REGULAR ); -if (IS_ERR (em_new)) { - ret =PTR_ERR (em_new); - goto out; - } -free_extent_map (em_new); + ret =split_zoned_em (inode, file_offset, file_len, pre, post); out: -free_extent_map (em);btrfs_put_ordered_extent (ordered);return errno_to_blk_status (ret);
Greg Kroah-Hartman
maintainerPATCH 24/292 btrfs: fix deadlock with concurrent chunk allocations involving system chunks
In reply to Greg Kroah-HartmanFrom: Filipe Manana <[email protected]>
commit 1cb3db1cf383a3c7dbda1aa0ce748b0958759947 upstream.
When a task attempting to allocate a new chunk verifies that there is not currently enough free space in the system space_info and there is another task that allocated a new system chunk but it did not finish yet the creation of the respective block group, it waits for that other task to finish creating the block group. This is to avoid exhaustion of the system chunk array in the superblock, which is limited, when we have a thundering herd of tasks allocating new chunks. This problem was described and fixed by commit eafa4fd0ad0607 ("btrfs: fix exhaustion of the system chunk array due to concurrent allocations").
However there are two very similar scenarios where this can lead to a deadlock:
1) Task B allocated a new system chunk and task A is waiting on task B to finish creation of the respective system block group. However before task B ends its transaction handle and finishes the creation of the system block group, it attempts to allocate another chunk (like a data chunk for an fallocate operation for a very large range). Task B will be unable to progress and allocate the new chunk, because task A set space_info->chunk_alloc to 1 and therefore it loops at btrfs_chunk_alloc() waiting for task A to finish its chunk allocation and set space_info->chunk_alloc to 0, but task A is waiting on task B to finish creation of the new system block group, therefore resulting in a deadlock;
2) Task B allocated a new system chunk and task A is waiting on task B to finish creation of the respective system block group. By the time that task B enter the final phase of block group allocation, which happens at btrfs_create_pending_block_groups(), when it modifies the extent tree, the device tree or the chunk tree to insert the items for some new block group, it needs to allocate a new chunk, so it ends up at btrfs_chunk_alloc() and keeps looping there because task A has set space_info->chunk_alloc to 1, but task A is waiting for task B to finish creation of the new system block group and release the reserved system space, therefore resulting in a deadlock.
In short, the problem is if a task B needs to allocate a new chunk after it previously allocated a new system chunk and if another task A is currently waiting for task B to complete the allocation of the new system chunk.
Unfortunately this deadlock scenario introduced by the previous fix for the system chunk array exhaustion problem does not have a simple and short fix, and requires a big change to rework the chunk allocation code so that chunk btree updates are all made in the first phase of chunk allocation. And since this deadlock regression is being frequently hit on zoned filesystems and the system chunk array exhaustion problem is triggered in more extreme cases (originally observed on PowerPC with a node size of 64K when running the fallocate tests from stress-ng), revert the changes from that commit. The next patch in the series, with a subject of "btrfs: rework chunk allocation to avoid exhaustion of the system chunk array" does the necessary changes to fix the system chunk array exhaustion problem.
--- fs/btrfs/block-group.c | 58 ------------------------------------------------- fs/btrfs/transaction.c | 5 ---- fs/btrfs/transaction.h | 7 ----- 3 files changed, 1 insertion(+), 69 deletions(-)
fs/btrfs/block-group.c +1 -57
@@ -3269,7 +3269,6 @@ static u64 get_profile_num_devs(struct b*/ void check_system_chunk (struct btrfs_trans_handle *trans,u64 type) { -struct btrfs_transaction *cur_trans = trans->transaction;struct btrfs_fs_info *fs_info = trans->fs_info;struct btrfs_space_info *info;u64 left;
@@ -3284,7 +3283,6 @@ void check_system_chunk(struct btrfs_tralockdep_assert_held (&fs_info->chunk_mutex); info =btrfs_find_space_info (fs_info,BTRFS_BLOCK_GROUP_SYSTEM ); -again:spin_lock (&info->lock); left = info->total_bytes -btrfs_space_info_used (info, true);spin_unlock (&info->lock);
@@ -3303,58 +3301,6 @@ again:if (left < thresh) {u64 flags =btrfs_system_alloc_profile (fs_info); -u64 reserved =atomic64_read (&cur_trans->chunk_bytes_reserved); - -/* -* If there's not available space for the chunk tree (system -* space) and there are other tasks that reserved space for -* creating a new system block group, wait for them to complete -* the creation of their system block group and release excess -* reserved space. We do this because: -* -* *) We can end up allocating more system chunks than necessary -* when there are multiple tasks that are concurrently -* allocating block groups, which can lead to exhaustion of -* the system array in the superblock; -* -* *) If we allocate extra and unnecessary system block groups, -* despite being empty for a long time, and possibly forever, -* they end not being added to the list of unused block groups -* because that typically happens only when deallocating the -* last extent from a block group - which never happens since -* we never allocate from them in the first place. The few -* exceptions are when mounting a filesystem or running scrub, -* which add unused block groups to the list of unused block -* groups, to be deleted by the cleaner kthread. -* And even when they are added to the list of unused block -* groups, it can take a long time until they get deleted, -* since the cleaner kthread might be sleeping or busy with -* other work (deleting subvolumes, running delayed iputs, -* defrag scheduling, etc); -* -* This is rare in practice, but can happen when too many tasks -* are allocating blocks groups in parallel (via fallocate()) -* and before the one that reserved space for a new system block -* group finishes the block group creation and releases the space -* reserved in excess (at btrfs_create_pending_block_groups()), -* other tasks end up here and see free system space temporarily -* not enough for updating the chunk tree. -* -* We unlock the chunk mutex before waiting for such tasks and -* lock it again after the wait, otherwise we would deadlock. -* It is safe to do so because allocating a system chunk is the -* first thing done while allocating a new block group. -*/ -if (reserved > trans->chunk_bytes_reserved) { -const u64 min_needed = reserved - thresh; - -mutex_unlock (&fs_info->chunk_mutex); -wait_event (cur_trans->chunk_reserve_wait, -atomic64_read (&cur_trans->chunk_bytes_reserved) <= - min_needed); -mutex_lock (&fs_info->chunk_mutex); - goto again; - }/* * Ignore failure to create system chunk. We might end up not
@@ -3369,10 +3315,8 @@ again: ret =btrfs_block_rsv_add (fs_info->chunk_root, &fs_info->chunk_block_rsv, thresh,BTRFS_RESERVE_NO_FLUSH ); -if (!ret) { -atomic64_add (thresh, &cur_trans->chunk_bytes_reserved); +if (!ret) trans->chunk_bytes_reserved += thresh; - } } }
fs/btrfs/transaction.c +0 -5
@@ -260,7 +260,6 @@ static inline int extwriter_counter_readvoid btrfs_trans_release_chunk_metadata (struct btrfs_trans_handle *trans) {struct btrfs_fs_info *fs_info = trans->fs_info; -struct btrfs_transaction *cur_trans = trans->transaction;if (!trans->chunk_bytes_reserved)return ;
@@ -269,8 +268,6 @@ void btrfs_trans_release_chunk_metadata(btrfs_block_rsv_release (fs_info, &fs_info->chunk_block_rsv, trans->chunk_bytes_reserved,NULL ); -atomic64_sub (trans->chunk_bytes_reserved, &cur_trans->chunk_bytes_reserved); -cond_wake_up (&cur_trans->chunk_reserve_wait); trans->chunk_bytes_reserved =0 ; }
@@ -386,8 +383,6 @@ loop:spin_lock_init (&cur_trans->dropped_roots_lock);INIT_LIST_HEAD (&cur_trans->releasing_ebs);spin_lock_init (&cur_trans->releasing_ebs_lock); -atomic64_set (&cur_trans->chunk_bytes_reserved,0 ); -init_waitqueue_head (&cur_trans->chunk_reserve_wait);list_add_tail (&cur_trans->list, &fs_info->trans_list);extent_io_tree_init (fs_info, &cur_trans->dirty_pages,IO_TREE_TRANS_DIRTY_PAGES , fs_info->btree_inode);
fs/btrfs/transaction.h +0 -7
@@ -96,13 +96,6 @@ struct btrfs_transaction {spinlock_t releasing_ebs_lock;struct list_head releasing_ebs; - -/* -* The number of bytes currently reserved, by all transaction handles -* attached to this transaction, for metadata extents of the chunk tree. -*/ -atomic64_t chunk_bytes_reserved; -wait_queue_head_t chunk_reserve_wait; };#define __TRANS_FREEZABLE (1U << 0)
Greg Kroah-Hartman
maintainerPATCH 25/292 btrfs: rework chunk allocation to avoid exhaustion of the system chunk array
In reply to Greg Kroah-HartmanFrom: Filipe Manana <[email protected]>
commit 79bd37120b149532af5b21953643ed74af69654f upstream.
Commit eafa4fd0ad0607 ("btrfs: fix exhaustion of the system chunk array due to concurrent allocations") fixed a problem that resulted in exhausting the system chunk array in the superblock when there are many tasks allocating chunks in parallel. Basically too many tasks enter the first phase of chunk allocation without previous tasks having finished their second phase of allocation, resulting in too many system chunks being allocated. That was originally observed when running the fallocate tests of stress-ng on a PowerPC machine, using a node size of 64K.
However that commit also introduced a deadlock where a task in phase 1 of the chunk allocation waited for another task that had allocated a system chunk to finish its phase 2, but that other task was waiting on an extent buffer lock held by the first task, therefore resulting in both tasks not making any progress. That change was later reverted by a patch with the subject "btrfs: fix deadlock with concurrent chunk allocations involving system chunks", since there is no simple and short solution to address it and the deadlock is relatively easy to trigger on zoned filesystems, while the system chunk array exhaustion is not so common.
This change reworks the chunk allocation to avoid the system chunk array exhaustion. It accomplishes that by making the first phase of chunk allocation do the updates of the device items in the chunk btree and the insertion of the new chunk item in the chunk btree. This is done while under the protection of the chunk mutex (fs_info->chunk_mutex), in the same critical section that checks for available system space, allocates a new system chunk if needed and reserves system chunk space. This way we do not have chunk space reserved until the second phase completes.
The same logic is applied to chunk removal as well, since it keeps reserved system space long after it is done updating the chunk btree.
For direct allocation of system chunks, the previous behaviour remains, because otherwise we would deadlock on extent buffers of the chunk btree. Changes to the chunk btree are by large done by chunk allocation and chunk removal, which first reserve chunk system space and then later do changes to the chunk btree. The other remaining cases are uncommon and correspond to adding a device, removing a device and resizing a device. All these other cases do not pre-reserve system space, they modify the chunk btree right away, so they don't hold reserved space for a long period like chunk allocation and chunk removal do.
The diff of this change is huge, but more than half of it is just addition of comments describing both how things work regarding chunk allocation and removal, including both the new behavior and the parts of the old behavior that did not change.
--- fs/btrfs/block-group.c | 285 ++++++++++++++++++++++++++++++++++----- fs/btrfs/block-group.h | 6 fs/btrfs/ctree.c | 67 +-------- fs/btrfs/transaction.c | 10 - fs/btrfs/transaction.h | 2 fs/btrfs/volumes.c | 355 +++++++++++++++++++++++++++++++++++++------------ fs/btrfs/volumes.h | 5 7 files changed, 546 insertions(+), 184 deletions(-)
fs/btrfs/block-group.c +249 -36
@@ -2101,6 +2101,13 @@ error:return ret; } +/* +* This function, insert_block_group_item(), belongs to the phase 2 of chunk +* allocation. +* +* See the comment at btrfs_chunk_alloc() for details about the chunk allocation +* phases. +*/ static int insert_block_group_item (struct btrfs_trans_handle *trans,struct btrfs_block_group *block_group) {
@@ -2123,15 +2130,19 @@ static int insert_block_group_item(strucreturn btrfs_insert_item (trans, root, &key, &bgi,sizeof (bgi)); } +/* +* This function, btrfs_create_pending_block_groups(), belongs to the phase 2 of +* chunk allocation. +* +* See the comment at btrfs_chunk_alloc() for details about the chunk allocation +* phases. +*/ void btrfs_create_pending_block_groups (struct btrfs_trans_handle *trans) {struct btrfs_fs_info *fs_info = trans->fs_info;struct btrfs_block_group *block_group;int ret =0 ; -if (!trans->can_flush_pending_bgs) -return ; -while (!list_empty (&trans->new_bgs)) {int index;
@@ -2146,6 +2157,13 @@ void btrfs_create_pending_block_groups(s ret =insert_block_group_item (trans, block_group);if (ret)btrfs_abort_transaction (trans, ret); +if (!block_group->chunk_item_inserted) { +mutex_lock (&fs_info->chunk_mutex); + ret =btrfs_chunk_alloc_add_chunk_item (trans, block_group); +mutex_unlock (&fs_info->chunk_mutex); +if (ret) +btrfs_abort_transaction (trans, ret); + } ret =btrfs_finish_chunk_alloc (trans, block_group->start, block_group->length);if (ret)
@@ -2169,8 +2187,9 @@ next:btrfs_trans_release_chunk_metadata (trans); } -int btrfs_make_block_group (struct btrfs_trans_handle *trans,u64 bytes_used, -u64 type,u64 chunk_offset,u64 size) +struct btrfs_block_group *btrfs_make_block_group (struct btrfs_trans_handle *trans, +u64 bytes_used,u64 type, +u64 chunk_offset,u64 size) {struct btrfs_fs_info *fs_info = trans->fs_info;struct btrfs_block_group *cache;
@@ -2180,7 +2199,7 @@ int btrfs_make_block_group(struct btrfs_ cache =btrfs_create_block_group_cache (fs_info, chunk_offset);if (!cache) -return -ENOMEM ; +return ERR_PTR (-ENOMEM ); cache->length = size;set_free_space_tree_thresholds (cache);
@@ -2194,7 +2213,7 @@ int btrfs_make_block_group(struct btrfs_ ret =btrfs_load_block_group_zone_info (cache, true);if (ret) {btrfs_put_block_group (cache); -return ret; +return ERR_PTR (ret); } ret =exclude_super_stripes (cache);
@@ -2202,7 +2221,7 @@ int btrfs_make_block_group(struct btrfs_/* We may have excluded something, so call this just in case */ btrfs_free_excluded_extents (cache);btrfs_put_block_group (cache); -return ret; +return ERR_PTR (ret); }add_new_free_space (cache, chunk_offset, chunk_offset + size);
@@ -2229,7 +2248,7 @@ int btrfs_make_block_group(struct btrfs_if (ret) {btrfs_remove_free_space_cache (cache);btrfs_put_block_group (cache); -return ret; +return ERR_PTR (ret); }/*
@@ -2248,7 +2267,7 @@ int btrfs_make_block_group(struct btrfs_btrfs_update_delayed_refs_rsv (trans);set_avail_alloc_bits (fs_info, type); -return 0 ; +return cache; }/*
@@ -3124,11 +3143,203 @@ int btrfs_force_chunk_alloc(struct btrfsreturn btrfs_chunk_alloc (trans, alloc_flags,CHUNK_ALLOC_FORCE ); } +static int do_chunk_alloc (struct btrfs_trans_handle *trans,u64 flags) +{ +struct btrfs_block_group *bg; +int ret; + +/* +* Check if we have enough space in the system space info because we +* will need to update device items in the chunk btree and insert a new +* chunk item in the chunk btree as well. This will allocate a new +* system block group if needed. +*/ +check_system_chunk (trans, flags); + + bg =btrfs_alloc_chunk (trans, flags); +if (IS_ERR (bg)) { + ret =PTR_ERR (bg); + goto out; + } + +/* +* If this is a system chunk allocation then stop right here and do not +* add the chunk item to the chunk btree. This is to prevent a deadlock +* because this system chunk allocation can be triggered while COWing +* some extent buffer of the chunk btree and while holding a lock on a +* parent extent buffer, in which case attempting to insert the chunk +* item (or update the device item) would result in a deadlock on that +* parent extent buffer. In this case defer the chunk btree updates to +* the second phase of chunk allocation and keep our reservation until +* the second phase completes. +* +* This is a rare case and can only be triggered by the very few cases +* we have where we need to touch the chunk btree outside chunk allocation +* and chunk removal. These cases are basically adding a device, removing +* a device or resizing a device. +*/ +if (flags &BTRFS_BLOCK_GROUP_SYSTEM ) +return 0 ; + + ret =btrfs_chunk_alloc_add_chunk_item (trans, bg); +/* +* Normally we are not expected to fail with -ENOSPC here, since we have +* previously reserved space in the system space_info and allocated one +* new system chunk if necessary. However there are two exceptions: +* +* 1) We may have enough free space in the system space_info but all the +* existing system block groups have a profile which can not be used +* for extent allocation. +* +* This happens when mounting in degraded mode. For example we have a +* RAID1 filesystem with 2 devices, lose one device and mount the fs +* using the other device in degraded mode. If we then allocate a chunk, +* we may have enough free space in the existing system space_info, but +* none of the block groups can be used for extent allocation since they +* have a RAID1 profile, and because we are in degraded mode with a +* single device, we are forced to allocate a new system chunk with a +* SINGLE profile. Making check_system_chunk() iterate over all system +* block groups and check if they have a usable profile and enough space +* can be slow on very large filesystems, so we tolerate the -ENOSPC and +* try again after forcing allocation of a new system chunk. Like this +* we avoid paying the cost of that search in normal circumstances, when +* we were not mounted in degraded mode; +* +* 2) We had enough free space info the system space_info, and one suitable +* block group to allocate from when we called check_system_chunk() +* above. However right after we called it, the only system block group +* with enough free space got turned into RO mode by a running scrub, +* and in this case we have to allocate a new one and retry. We only +* need do this allocate and retry once, since we have a transaction +* handle and scrub uses the commit root to search for block groups. +*/ +if (ret == -ENOSPC ) { +const u64 sys_flags =btrfs_system_alloc_profile (trans->fs_info); +struct btrfs_block_group *sys_bg; + + sys_bg =btrfs_alloc_chunk (trans, sys_flags); +if (IS_ERR (sys_bg)) { + ret =PTR_ERR (sys_bg); +btrfs_abort_transaction (trans, ret); + goto out; + } + + ret =btrfs_chunk_alloc_add_chunk_item (trans, sys_bg); +if (ret) { +btrfs_abort_transaction (trans, ret); + goto out; + } + + ret =btrfs_chunk_alloc_add_chunk_item (trans, bg); +if (ret) { +btrfs_abort_transaction (trans, ret); + goto out; + } + }else if (ret) { +btrfs_abort_transaction (trans, ret); + goto out; + } +out: +btrfs_trans_release_chunk_metadata (trans); + +return ret; +} +/* -* If force is CHUNK_ALLOC_FORCE: +* Chunk allocation is done in 2 phases: +* +* 1) Phase 1 - through btrfs_chunk_alloc() we allocate device extents for +* the chunk, the chunk mapping, create its block group and add the items +* that belong in the chunk btree to it - more specifically, we need to +* update device items in the chunk btree and add a new chunk item to it. +* +* 2) Phase 2 - through btrfs_create_pending_block_groups(), we add the block +* group item to the extent btree and the device extent items to the devices +* btree. +* +* This is done to prevent deadlocks. For example when COWing a node from the +* extent btree we are holding a write lock on the node's parent and if we +* trigger chunk allocation and attempted to insert the new block group item +* in the extent btree right way, we could deadlock because the path for the +* insertion can include that parent node. At first glance it seems impossible +* to trigger chunk allocation after starting a transaction since tasks should +* reserve enough transaction units (metadata space), however while that is true +* most of the time, chunk allocation may still be triggered for several reasons: +* +* 1) When reserving metadata, we check if there is enough free space in the +* metadata space_info and therefore don't trigger allocation of a new chunk. +* However later when the task actually tries to COW an extent buffer from +* the extent btree or from the device btree for example, it is forced to +* allocate a new block group (chunk) because the only one that had enough +* free space was just turned to RO mode by a running scrub for example (or +* device replace, block group reclaim thread, etc), so we can not use it +* for allocating an extent and end up being forced to allocate a new one; +* +* 2) Because we only check that the metadata space_info has enough free bytes, +* we end up not allocating a new metadata chunk in that case. However if +* the filesystem was mounted in degraded mode, none of the existing block +* groups might be suitable for extent allocation due to their incompatible +* profile (for e.g. mounting a 2 devices filesystem, where all block groups +* use a RAID1 profile, in degraded mode using a single device). In this case +* when the task attempts to COW some extent buffer of the extent btree for +* example, it will trigger allocation of a new metadata block group with a +* suitable profile (SINGLE profile in the example of the degraded mount of +* the RAID1 filesystem); +* +* 3) The task has reserved enough transaction units / metadata space, but when +* it attempts to COW an extent buffer from the extent or device btree for +* example, it does not find any free extent in any metadata block group, +* therefore forced to try to allocate a new metadata block group. +* This is because some other task allocated all available extents in the +* meanwhile - this typically happens with tasks that don't reserve space +* properly, either intentionally or as a bug. One example where this is +* done intentionally is fsync, as it does not reserve any transaction units +* and ends up allocating a variable number of metadata extents for log +* tree extent buffers. +* +* We also need this 2 phases setup when adding a device to a filesystem with +* a seed device - we must create new metadata and system chunks without adding +* any of the block group items to the chunk, extent and device btrees. If we +* did not do it this way, we would get ENOSPC when attempting to update those +* btrees, since all the chunks from the seed device are read-only. +* +* Phase 1 does the updates and insertions to the chunk btree because if we had +* it done in phase 2 and have a thundering herd of tasks allocating chunks in +* parallel, we risk having too many system chunks allocated by many tasks if +* many tasks reach phase 1 without the previous ones completing phase 2. In the +* extreme case this leads to exhaustion of the system chunk array in the +* superblock. This is easier to trigger if using a btree node/leaf size of 64K +* and with RAID filesystems (so we have more device items in the chunk btree). +* This has happened before and commit eafa4fd0ad0607 ("btrfs: fix exhaustion of +* the system chunk array due to concurrent allocations") provides more details. +* +* For allocation of system chunks, we defer the updates and insertions into the +* chunk btree to phase 2. This is to prevent deadlocks on extent buffers because +* if the chunk allocation is triggered while COWing an extent buffer of the +* chunk btree, we are holding a lock on the parent of that extent buffer and +* doing the chunk btree updates and insertions can require locking that parent. +* This is for the very few and rare cases where we update the chunk btree that +* are not chunk allocation or chunk removal: adding a device, removing a device +* or resizing a device. +* +* The reservation of system space, done through check_system_chunk(), as well +* as all the updates and insertions into the chunk btree must be done while +* holding fs_info->chunk_mutex. This is important to guarantee that while COWing +* an extent buffer from the chunks btree we never trigger allocation of a new +* system chunk, which would result in a deadlock (trying to lock twice an +* extent buffer of the chunk btree, first time before triggering the chunk +* allocation and the second time during chunk allocation while attempting to +* update the chunks btree). The system chunk array is also updated while holding +* that mutex. The same logic applies to removing chunks - we must reserve system +* space, update the chunk btree and the system chunk array in the superblock +* while holding fs_info->chunk_mutex. +* +* This function, btrfs_chunk_alloc(), belongs to phase 1. +* +* If @force is CHUNK_ALLOC_FORCE: * - return 1 if it successfully allocates a chunk, * - return errors including -ENOSPC otherwise. -* If force is NOT CHUNK_ALLOC_FORCE: +* If @force is NOT CHUNK_ALLOC_FORCE: * - return 0 if it doesn't need to allocate a new chunk, * - return 1 if it successfully allocates a chunk, * - return errors including -ENOSPC otherwise.
@@ -3145,6 +3356,13 @@ int btrfs_chunk_alloc(struct btrfs_trans/* Don't re-enter if we're already allocating a chunk */ if (trans->allocating_chunk)return -ENOSPC ; +/* +* If we are removing a chunk, don't re-enter or we would deadlock. +* System space reservation and system chunk allocation is done by the +* chunk remove operation (btrfs_remove_chunk()). +*/ +if (trans->removing_chunk) +return -ENOSPC ; space_info =btrfs_find_space_info (fs_info, flags);ASSERT (space_info);
@@ -3208,13 +3426,7 @@ int btrfs_chunk_alloc(struct btrfs_transforce_metadata_allocation (fs_info); } -/* -* Check if we have enough space in SYSTEM chunk because we may need -* to update devices. -*/ -check_system_chunk (trans, flags); - - ret =btrfs_alloc_chunk (trans, flags); + ret =do_chunk_alloc (trans, flags); trans->allocating_chunk = false;spin_lock (&space_info->lock);
@@ -3233,22 +3445,6 @@ out: space_info->chunk_alloc =0 ;spin_unlock (&space_info->lock);mutex_unlock (&fs_info->chunk_mutex); -/* -* When we allocate a new chunk we reserve space in the chunk block -* reserve to make sure we can COW nodes/leafs in the chunk tree or -* add new nodes/leafs to it if we end up needing to do it when -* inserting the chunk item and updating device items as part of the -* second phase of chunk allocation, performed by -* btrfs_finish_chunk_alloc(). So make sure we don't accumulate a -* large number of new block groups to create in our transaction -* handle's new_bgs list to avoid exhausting the chunk block reserve -* in extreme cases - like having a single transaction create many new -* block groups when starting to write out the free space caches of all -* the block groups that were made dirty during the lifetime of the -* transaction. -*/ -if (trans->chunk_bytes_reserved >= (u64 )SZ_2M ) -btrfs_create_pending_block_groups (trans);return ret; }
@@ -3301,14 +3497,31 @@ void check_system_chunk(struct btrfs_traif (left < thresh) {u64 flags =btrfs_system_alloc_profile (fs_info); +struct btrfs_block_group *bg;/* * Ignore failure to create system chunk. We might end up not * needing it, as we might not need to COW all nodes/leafs from * the paths we visit in the chunk tree (they were already COWed * or created in the current transaction for example). +* +* Also, if our caller is allocating a system chunk, do not +* attempt to insert the chunk item in the chunk btree, as we +* could deadlock on an extent buffer since our caller may be +* COWing an extent buffer from the chunk btree. */ - ret =btrfs_alloc_chunk (trans, flags); + bg =btrfs_alloc_chunk (trans, flags); +if (IS_ERR (bg)) { + ret =PTR_ERR (bg); + }else if (!(type &BTRFS_BLOCK_GROUP_SYSTEM )) { +/* +* If we fail to add the chunk item here, we end up +* trying again at phase 2 of chunk allocation, at +* btrfs_create_pending_block_groups(). So ignore +* any error here. +*/ +btrfs_chunk_alloc_add_chunk_item (trans, bg); + } }if (!ret) {
fs/btrfs/block-group.h +4 -2
@@ -97,6 +97,7 @@ struct btrfs_block_group { unsigned int removed:1; unsigned int to_copy:1; unsigned int relocating_repair:1; + unsigned int chunk_item_inserted:1;int disk_cache_state;
@@ -265,8 +266,9 @@ int btrfs_remove_block_group(struct btrfvoid btrfs_delete_unused_bgs (struct btrfs_fs_info *fs_info);void btrfs_mark_bg_unused (struct btrfs_block_group *bg);int btrfs_read_block_groups (struct btrfs_fs_info *info); -int btrfs_make_block_group (struct btrfs_trans_handle *trans,u64 bytes_used, -u64 type,u64 chunk_offset,u64 size); +struct btrfs_block_group *btrfs_make_block_group (struct btrfs_trans_handle *trans, +u64 bytes_used,u64 type, +u64 chunk_offset,u64 size);void btrfs_create_pending_block_groups (struct btrfs_trans_handle *trans);int btrfs_inc_block_group_ro (struct btrfs_block_group *cache,bool do_chunk_alloc);
fs/btrfs/ctree.c +13 -54
97 lines not on this page · raw message
fs/btrfs/transaction.c +5 -5
@@ -254,8 +254,11 @@ static inline int extwriter_counter_read }/* -* To be called after all the new block groups attached to the transaction -* handle have been created (btrfs_create_pending_block_groups()). +* To be called after doing the chunk btree updates right after allocating a new +* chunk (after btrfs_chunk_alloc_add_chunk_item() is called), when removing a +* chunk after all chunk btree updates and after finishing the second phase of +* chunk allocation (btrfs_create_pending_block_groups()) in case some block +* group had its chunk item insertion delayed to the second phase. */ void btrfs_trans_release_chunk_metadata (struct btrfs_trans_handle *trans) {
@@ -264,8 +267,6 @@ void btrfs_trans_release_chunk_metadata(if (!trans->chunk_bytes_reserved)return ; -WARN_ON_ONCE (!list_empty (&trans->new_bgs)); -btrfs_block_rsv_release (fs_info, &fs_info->chunk_block_rsv, trans->chunk_bytes_reserved,NULL ); trans->chunk_bytes_reserved =0 ;
@@ -697,7 +698,6 @@ again: h->fs_info = root->fs_info; h->type = type; - h->can_flush_pending_bgs = true;INIT_LIST_HEAD (&h->new_bgs);smp_mb ();
fs/btrfs/transaction.h +1 -1
@@ -134,7 +134,7 @@ struct btrfs_trans_handle {short aborted;bool adding_csums;bool allocating_chunk; -bool can_flush_pending_bgs; +bool removing_chunk;bool reloc_reserved;bool in_fsync;struct btrfs_root *root;
fs/btrfs/volumes.c +270 -85
593 lines not on this page · raw message
fs/btrfs/volumes.h +4 -1
@@ -447,7 +447,8 @@ int btrfs_get_io_geometry(struct btrfs_f struct btrfs_io_geometry *io_geom);int btrfs_read_sys_array (struct btrfs_fs_info *fs_info);int btrfs_read_chunk_tree (struct btrfs_fs_info *fs_info); -int btrfs_alloc_chunk (struct btrfs_trans_handle *trans,u64 type); +struct btrfs_block_group *btrfs_alloc_chunk (struct btrfs_trans_handle *trans, +u64 type);void btrfs_mapping_tree_free (struct extent_map_tree *tree);blk_status_t btrfs_map_bio (struct btrfs_fs_info *fs_info,struct bio *bio,int mirror_num);
@@ -505,6 +506,8 @@ unsigned long btrfs_full_stripe_len(stru u64 logical);int btrfs_finish_chunk_alloc (struct btrfs_trans_handle *trans,u64 chunk_offset,u64 chunk_size); +int btrfs_chunk_alloc_add_chunk_item (struct btrfs_trans_handle *trans, +struct btrfs_block_group *bg);int btrfs_remove_chunk (struct btrfs_trans_handle *trans,u64 chunk_offset);struct extent_map *btrfs_get_chunk_map (struct btrfs_fs_info *fs_info,u64 logical,u64 length);
Greg Kroah-Hartman
maintainerPATCH 26/292 btrfs: zoned: fix wrong mutex unlock on failure to allocate log root tree
In reply to Greg Kroah-HartmanFrom: Filipe Manana <[email protected]>
commit ea32af47f00a046a1f953370514d6d946efe0152 upstream.
When syncing the log, if we fail to allocate the root node for the log root tree:
1) We are unlocking fs_info->tree_log_mutex, but at this point we have not yet locked this mutex;
2) We have locked fs_info->tree_root->log_mutex, but we end up not unlocking it;
So fix this by unlocking fs_info->tree_root->log_mutex instead of fs_info->tree_log_mutex.
--- fs/btrfs/tree-log.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
fs/btrfs/tree-log.c +1 -1
@@ -3173,7 +3173,7 @@ int btrfs_sync_log(struct btrfs_trans_haif (!log_root_tree->node) { ret =btrfs_alloc_log_tree_node (trans, log_root_tree);if (ret) { -mutex_unlock (&fs_info->tree_log_mutex); +mutex_unlock (&fs_info->tree_root->log_mutex); goto out; } }
Greg Kroah-Hartman
maintainerPATCH 27/292 drm/dp_mst: Do not set proposed vcpi directly
In reply to Greg Kroah-HartmanFrom: Wayne Lin <[email protected]>
commit 35d3e8cb35e75450f87f87e3d314e2d418b6954b upstream.
[Why]
When we receive CSN message to notify one port is disconnected, we will implicitly set its corresponding num_slots to 0. Later on, we will eventually call drm_dp_update_payload_part1() to arrange down streams.
In drm_dp_update_payload_part1(), we iterate over all proposed_vcpis[] to do the update. Not specific to a target sink only. For example, if we light up 2 monitors, Monitor_A and Monitor_B, and then we unplug Monitor_B. Later on, when we call drm_dp_update_payload_part1() to try to update payload for Monitor_A, we'll also implicitly clean payload for Monitor_B at the same time. And finally, when we try to call drm_dp_update_payload_part1() to clean payload for Monitor_B, we will do nothing at this time since payload for Monitor_B has been cleaned up previously.
For StarTech 1to3 DP hub, it seems like if we didn't update DPCD payload ID table then polling for "ACT Handled"(BIT_1 of DPCD 002C0h) will fail and this polling will last for 3 seconds.
Therefore, guess the best way is we don't set the proposed_vcpi[] diretly. Let user of these herlper functions to set the proposed_vcpi directly.
[How]
1. Revert commit 7617e9621bf2 ("drm/dp_mst: clear time slots for ports invalid")
2. Tackle the issue in previous commit by skipping those trasient proposed VCPIs. These stale VCPIs shoulde be explicitly cleared by user later on.
Changes since v1:
* Change debug macro to use drm_dbg_kms() instead
* Amend the commit message to add Fixed & Cc tags
--- drivers/gpu/drm/drm_dp_mst_topology.c | 36 +++++++++------------------------- 1 file changed, 10 insertions(+), 26 deletions(-)
drivers/gpu/drm/drm_dp_mst_topology.c +10 -26
@@ -2499,7 +2499,7 @@ drm_dp_mst_handle_conn_stat(struct drm_d {struct drm_dp_mst_topology_mgr *mgr = mstb->mgr;struct drm_dp_mst_port *port; -int old_ddps, old_input, ret, i; +int old_ddps, ret;u8 new_pdt;bool new_mcs;bool dowork = false, create_connector = false;
@@ -2531,7 +2531,6 @@ drm_dp_mst_handle_conn_stat(struct drm_d } old_ddps = port->ddps; - old_input = port->input; port->input = conn_stat->input_port; port->ldps = conn_stat->legacy_device_plug_status; port->ddps = conn_stat->displayport_device_plug_status;
@@ -2554,28 +2553,6 @@ drm_dp_mst_handle_conn_stat(struct drm_d dowork = false; } -if (!old_input && old_ddps != port->ddps && !port->ddps) { -for (i =0 ; i < mgr->max_payloads; i++) { -struct drm_dp_vcpi *vcpi = mgr->proposed_vcpis[i]; -struct drm_dp_mst_port *port_validated; - -if (!vcpi) -continue ; - - port_validated = - container_of(vcpi, struct drm_dp_mst_port, vcpi); - port_validated = -drm_dp_mst_topology_get_port_validated (mgr, port_validated); -if (!port_validated) { -mutex_lock (&mgr->payload_lock); - vcpi->num_slots =0 ; -mutex_unlock (&mgr->payload_lock); - }else { -drm_dp_mst_topology_put_port (port_validated); - } - } - } -if (port->connector)drm_modeset_unlock (&mgr->base.lock);else if (create_connector)
@@ -3406,8 +3383,15 @@ int drm_dp_update_payload_part1(struct d port =drm_dp_mst_topology_get_port_validated ( mgr, port);if (!port) { -mutex_unlock (&mgr->payload_lock); -return -EINVAL ; +if (vcpi->num_slots == payload->num_slots) { + cur_slots += vcpi->num_slots; + payload->start_slot = req_payload.start_slot; +continue ; + }else { +drm_dbg_kms ("Fail:set payload to invalid sink" ); +mutex_unlock (&mgr->payload_lock); +return -EINVAL ; + } } put_port = true; }
Greg Kroah-Hartman
maintainerPATCH 28/292 drm/dp_mst: Avoid to mess up payload table by ports in stale topology
In reply to Greg Kroah-HartmanFrom: Wayne Lin <[email protected]>
commit 3769e4c0af5b82c8ea21d037013cb9564dfaa51f upstream.
[Why]
After unplug/hotplug hub from the system, userspace might start to clear stale payloads gradually. If we call drm_dp_mst_deallocate_vcpi() to release stale VCPI of those ports which are not relating to current topology, we have chane to wrongly clear active payload table entry for current topology.
E.g.
We have allocated VCPI 1 in current payload table and we call drm_dp_mst_deallocate_vcpi() to clean VCPI 1 in stale topology. In drm_dp_mst_deallocate_vcpi(), it will call drm_dp_mst_put_payload_id() tp put VCPI 1 and which means ID 1 is available again. Thereafter, if we want to allocate a new payload stream, it will find ID 1 is available by drm_dp_mst_assign_payload_id(). However, ID 1 is being used
[How]
Check target sink is relating to current topology or not before doing any payload table update.
Searching upward to find the target sink's relevant root branch device. If the found root branch device is not the same root of current topology, don't update payload table.
Changes since v1:
* Change debug macro to use drm_dbg_kms() instead
* Amend the commit message to add Cc tag.
--- drivers/gpu/drm/drm_dp_mst_topology.c | 29 +++++++++++++++++++++++++++++ 1 file changed, 29 insertions(+)
drivers/gpu/drm/drm_dp_mst_topology.c +29 -0
@@ -94,6 +94,9 @@ static int drm_dp_mst_register_i2c_bus(sstatic void drm_dp_mst_unregister_i2c_bus (struct drm_dp_mst_port *port);static void drm_dp_mst_kick_tx (struct drm_dp_mst_topology_mgr *mgr); +static bool drm_dp_mst_port_downstream_of_branch (struct drm_dp_mst_port *port, +struct drm_dp_mst_branch *branch); +#define DBG_PREFIX "[dp_mst]"#define DP_STR (x) [DP_ ## x] = #x
@@ -3362,6 +3365,7 @@ int drm_dp_update_payload_part1(struct dstruct drm_dp_mst_port *port;int i, j;int cur_slots =1 ; +bool skip;mutex_lock (&mgr->payload_lock);for (i =0 ; i < mgr->max_payloads; i++) {
@@ -3376,6 +3380,14 @@ int drm_dp_update_payload_part1(struct d port = container_of(vcpi, struct drm_dp_mst_port, vcpi); +mutex_lock (&mgr->lock); + skip = !drm_dp_mst_port_downstream_of_branch (port, mgr->mst_primary); +mutex_unlock (&mgr->lock); + +if (skip) { +drm_dbg_kms ("Virtual channel %d is not in current topology\n" , i); +continue ; + }/* Validated ports don't matter if we're releasing * VCPI */
@@ -3475,6 +3487,7 @@ int drm_dp_update_payload_part2(struct dstruct drm_dp_mst_port *port;int i;int ret =0 ; +bool skip;mutex_lock (&mgr->payload_lock);for (i =0 ; i < mgr->max_payloads; i++) {
@@ -3484,6 +3497,13 @@ int drm_dp_update_payload_part2(struct d port = container_of(mgr->proposed_vcpis[i], struct drm_dp_mst_port, vcpi); +mutex_lock (&mgr->lock); + skip = !drm_dp_mst_port_downstream_of_branch (port, mgr->mst_primary); +mutex_unlock (&mgr->lock); + +if (skip) +continue ; +DRM_DEBUG_KMS ("payload %d %d\n" , i, mgr->payloads[i].payload_state);if (mgr->payloads[i].payload_state ==DP_PAYLOAD_LOCAL ) { ret =drm_dp_create_payload_step2 (mgr, port, mgr->proposed_vcpis[i]->vcpi, &mgr->payloads[i]);
@@ -4565,9 +4585,18 @@ EXPORT_SYMBOL(drm_dp_mst_reset_vcpi_slotvoid drm_dp_mst_deallocate_vcpi (struct drm_dp_mst_topology_mgr *mgr,struct drm_dp_mst_port *port) { +bool skip; +if (!port->vcpi.vcpi)return ; +mutex_lock (&mgr->lock); + skip = !drm_dp_mst_port_downstream_of_branch (port, mgr->mst_primary); +mutex_unlock (&mgr->lock); + +if (skip) +return ; +drm_dp_mst_put_payload_id (mgr, port->vcpi.vcpi); port->vcpi.num_slots =0 ; port->vcpi.pbn =0 ;
Greg Kroah-Hartman
maintainerPATCH 29/292 drm/dp_mst: Add missing drm parameters to recently added call to drm_dbg_kms()
In reply to Greg Kroah-HartmanFrom: José Roberto de Souza <[email protected]>
commit 24ff3dc18b99c4b912ab1746e803ddb3be5ced4c upstream.
Commit 3769e4c0af5b ("drm/dp_mst: Avoid to mess up payload table by ports in stale topology") added to calls to drm_dbg_kms() but it missed the first parameter, the drm device breaking the build.
--- drivers/gpu/drm/drm_dp_mst_topology.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)
drivers/gpu/drm/drm_dp_mst_topology.c +5 -2
@@ -3385,7 +3385,9 @@ int drm_dp_update_payload_part1(struct dmutex_unlock (&mgr->lock);if (skip) { -drm_dbg_kms ("Virtual channel %d is not in current topology\n" , i); +drm_dbg_kms (mgr->dev, +"Virtual channel %d is not in current topology\n" , + i);continue ; }/* Validated ports don't matter if we're releasing
@@ -3400,7 +3402,8 @@ int drm_dp_update_payload_part1(struct d payload->start_slot = req_payload.start_slot;continue ; }else { -drm_dbg_kms ("Fail:set payload to invalid sink" ); +drm_dbg_kms (mgr->dev, +"Fail:set payload to invalid sink" );mutex_unlock (&mgr->payload_lock);return -EINVAL ; }
Greg Kroah-Hartman
maintainerPATCH 30/292 io_uring: put link timeout req consistently
In reply to Greg Kroah-HartmanFrom: Pavel Begunkov <[email protected]>
commit df9727affa058f4f18e388b30247650f8ae13cd8 upstream.
Don't put linked timeout req in io_async_find_and_cancel() but do it in io_link_timeout_fn(), so we have only one point for that and won't have to do it differently as it's now (put vs put_deferred). Btw, improve a bit io_async_find_and_cancel()'s locking.
--- fs/io_uring.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-)
fs/io_uring.c +3 -7
@@ -5727,12 +5727,9 @@ static void io_async_find_and_cancel(strint ret; ret =io_async_cancel_one (req->task->io_uring, sqe_addr, ctx); -if (ret != -ENOENT ) { -spin_lock_irqsave (&ctx->completion_lock, flags); - goto done; - } -spin_lock_irqsave (&ctx->completion_lock, flags); +if (ret != -ENOENT ) + goto done; ret =io_timeout_cancel (ctx, sqe_addr);if (ret != -ENOENT ) goto done;
@@ -5747,7 +5744,6 @@ done:if (ret <0 )req_set_fail_links (req); -io_put_req (req); } static int io_async_cancel_prep(struct io_kiocb *req,
@@ -6310,8 +6306,8 @@ static enum hrtimer_restart io_link_timeio_put_req_deferred (req,1 ); }else {io_req_complete_post (req, -ETIME ,0 ); -io_put_req_deferred (req,1 ); } +io_put_req_deferred (req,1 );return HRTIMER_NORESTART ; }
Greg Kroah-Hartman
maintainerPATCH 31/292 io_uring: fix link timeout refs
In reply to Greg Kroah-HartmanFrom: Pavel Begunkov <[email protected]>
commit a298232ee6b9a1d5d732aa497ff8be0d45b5bd82 upstream.
WARNING: CPU: 0 PID: 10242 at lib/refcount.c:28 refcount_warn_saturate+0x15b/0x1a0 lib/refcount.c:28 RIP: 0010:refcount_warn_saturate+0x15b/0x1a0 lib/refcount.c:28 Call Trace: __refcount_sub_and_test include/linux/refcount.h:283 [inline] __refcount_dec_and_test include/linux/refcount.h:315 [inline] refcount_dec_and_test include/linux/refcount.h:333 [inline] io_put_req fs/io_uring.c:2140 [inline] io_queue_linked_timeout fs/io_uring.c:6300 [inline] __io_queue_sqe+0xbef/0xec0 fs/io_uring.c:6354 io_submit_sqe fs/io_uring.c:6534 [inline] io_submit_sqes+0x2bbd/0x7c50 fs/io_uring.c:6660 __do_sys_io_uring_enter fs/io_uring.c:9240 [inline] __se_sys_io_uring_enter+0x256/0x1d60 fs/io_uring.c:9182
io_link_timeout_fn() should put only one reference of the linked timeout request, however in case of racing with the master request's completion first io_req_complete() puts one and then io_put_req_deferred() is called.
--- fs/io_uring.c | 1 - 1 file changed, 1 deletion(-)
fs/io_uring.c +0 -1
@@ -6307,7 +6307,6 @@ static enum hrtimer_restart io_link_time }else {io_req_complete_post (req, -ETIME ,0 ); } -io_put_req_deferred (req,1 );return HRTIMER_NORESTART ; }
Greg Kroah-Hartman
maintainerPATCH 32/292 net: bridge: multicast: fix PIM hello router port marking race
In reply to Greg Kroah-HartmanFrom: Nikolay Aleksandrov <[email protected]>
commit 04bef83a3358946bfc98a5ecebd1b0003d83d882 upstream.
When a PIM hello packet is received on a bridge port with multicast snooping enabled, we mark it as a router port automatically, that includes adding that port the router port list. The multicast lock protects that list, but it is not acquired in the PIM message case leading to a race condition, we need to take it to fix the race.
--- net/bridge/br_multicast.c | 2 ++ 1 file changed, 2 insertions(+)
net/bridge/br_multicast.c +2 -0
@@ -3087,7 +3087,9 @@ static void br_multicast_pim(struct net_ pim_hdr_type(pimhdr) != PIM_TYPE_HELLO)return ; +spin_lock (&br->multicast_lock);br_multicast_mark_router (br, port); +spin_unlock (&br->multicast_lock); } static int br_ip4_multicast_mrd_rcv(struct net_bridge *br,
Greg Kroah-Hartman
maintainerPATCH 33/292 net: bridge: multicast: fix MRD advertisement router port marking race
In reply to Greg Kroah-HartmanFrom: Nikolay Aleksandrov <[email protected]>
commit 000b7287b67555fee39d39fff75229dedde0dcbf upstream.
When an MRD advertisement is received on a bridge port with multicast snooping enabled, we mark it as a router port automatically, that includes adding that port to the router port list. The multicast lock protects that list, but it is not acquired in the MRD advertisement case leading to a race condition, we need to take it to fix the race.
--- net/bridge/br_multicast.c | 4 ++++ 1 file changed, 4 insertions(+)
net/bridge/br_multicast.c +4 -0
@@ -3100,7 +3100,9 @@ static int br_ip4_multicast_mrd_rcv(stru igmp_hdr(skb)->type != IGMP_MRDISC_ADV)return -ENOMSG ; +spin_lock (&br->multicast_lock);br_multicast_mark_router (br, port); +spin_unlock (&br->multicast_lock);return 0 ; }
@@ -3168,7 +3170,9 @@ static void br_ip6_multicast_mrd_rcv(strif (icmp6_hdr (skb)->icmp6_type !=ICMPV6_MRDISC_ADV )return ; +spin_lock (&br->multicast_lock);br_multicast_mark_router (br, port); +spin_unlock (&br->multicast_lock); } static int br_multicast_ipv6_rcv(struct net_bridge *br,
Greg Kroah-Hartman
maintainerPATCH 34/292 leds: tlc591xx: fix return value check in tlc591xx_probe()
In reply to Greg Kroah-HartmanFrom: Yang Yingliang <[email protected]>
[ Upstream commit ee522bcf026ec82ada793979c3a906274430595a ]
After device_get_match_data(), tlc591xx is not checked, add check for it and also check np after dev_of_node.
--- drivers/leds/leds-tlc591xx.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-)
drivers/leds/leds-tlc591xx.c +6 -2
@@ -148,16 +148,20 @@ static int tlc591xx_probe(struct i2c_client *client, const struct i2c_device_id *id) { - struct device_node *np = dev_of_node(&client->dev), *child; + struct device_node *np, *child;struct device *dev = &client->dev;const struct tlc591xx *tlc591xx;struct tlc591xx_priv *priv;int err, count, reg; - tlc591xx =device_get_match_data (dev); + np =dev_of_node (dev);if (!np)return -ENODEV ; + tlc591xx =device_get_match_data (dev); +if (!tlc591xx) +return -ENODEV ; + count =of_get_available_child_count (np);if (!count || count > tlc591xx->max_leds)return -EINVAL ;
Signature · 1 line
2.30.2
Greg Kroah-Hartman
maintainerPATCH 35/292 ASoC: Intel: sof_sdw: add mutual exclusion between PCH DMIC and RT715
In reply to Greg Kroah-HartmanFrom: Pierre-Louis Bossart <[email protected]>
[ Upstream commit 35564e2bf94611c3eb51d35362addb3cb394ad54 ]
When external RT714/715 devices are used for capture, we don't want the PCH DMICs to be used.
Any information provided by the SOF platform driver or DMI quirks will be overridden.
--- sound/soc/intel/boards/sof_sdw.c | 19 +++++++++++++++++-- sound/soc/intel/boards/sof_sdw_common.h | 1 + 2 files changed, 18 insertions(+), 2 deletions(-)
sound/soc/intel/boards/sof_sdw.c +17 -2
@@ -354,6 +354,7 @@ static struct sof_sdw_codec_info codec_info_list[] = { .part_id = 0x714, .version_id = 3, .direction = {false, true}, + .ignore_pch_dmic = true, .dai_name = "rt715-aif2", .init = sof_sdw_rt715_sdca_init, },
@@ -361,6 +362,7 @@ static struct sof_sdw_codec_info codec_info_list[] = { .part_id = 0x715, .version_id = 3, .direction = {false, true}, + .ignore_pch_dmic = true, .dai_name = "rt715-aif2", .init = sof_sdw_rt715_sdca_init, },
@@ -368,6 +370,7 @@ static struct sof_sdw_codec_info codec_info_list[] = { .part_id = 0x714, .version_id = 2, .direction = {false, true}, + .ignore_pch_dmic = true, .dai_name = "rt715-aif2", .init = sof_sdw_rt715_init, },
@@ -375,6 +378,7 @@ static struct sof_sdw_codec_info codec_info_list[] = { .part_id = 0x715, .version_id = 2, .direction = {false, true}, + .ignore_pch_dmic = true, .dai_name = "rt715-aif2", .init = sof_sdw_rt715_init, },
@@ -730,7 +734,8 @@ static int create_sdw_dailink(struct device *dev, int *be_index, int *cpu_id, bool *group_generated, struct snd_soc_codec_conf *codec_conf, int codec_count, - int *codec_conf_index) + int *codec_conf_index, + bool *ignore_pch_dmic) { const struct snd_soc_acpi_link_adr *link_next;struct snd_soc_dai_link_component *codecs;
@@ -783,6 +788,9 @@ static int create_sdw_dailink(struct device *dev, int *be_index,if (codec_index <0 )return codec_index; +if (codec_info_list[codec_index].ignore_pch_dmic) + *ignore_pch_dmic = true; + cpu_dai_index = *cpu_id;for_each_pcm_streams (stream) {char *name, *cpu_name;
@@ -914,6 +922,7 @@ static int sof_card_dai_links_create(struct device *dev,const struct snd_soc_acpi_link_adr *adr_link;struct snd_soc_dai_link_component *cpus;struct snd_soc_codec_conf *codec_conf; +bool ignore_pch_dmic = false;int codec_conf_count;int codec_conf_index =0 ;bool group_generated[SDW_MAX_GROUPS ];
@@ -1020,7 +1029,8 @@ static int sof_card_dai_links_create(struct device *dev, sdw_cpu_dai_num, cpus, adr_link, &cpu_id, group_generated, codec_conf, codec_conf_count, - &codec_conf_index); + &codec_conf_index, + &ignore_pch_dmic);if (ret <0 ) {dev_err (dev,"failed to create dai link %d" , be_id);return -ENOMEM ;
@@ -1088,6 +1098,10 @@ SSP: DMIC:/* dmic */ if (dmic_num >0 ) { +if (ignore_pch_dmic) { +dev_warn (dev,"Ignoring PCH DMIC\n" ); + goto HDMI; + } cpus[cpu_id].dai_name ="DMIC01 Pin" ; init_dai_link(dev, links + link_id, be_id, "dmic01", 0, 1, // DMIC only supports capture
@@ -1106,6 +1120,7 @@ DMIC:INC_ID (be_id, cpu_id, link_id); } +HDMI:/* HDMI */ if (hdmi_num >0 ) { idisp_components = devm_kcalloc(dev, hdmi_num,
sound/soc/intel/boards/sof_sdw_common.h +1 -0
@@ -56,6 +56,7 @@ struct sof_sdw_codec_info {int amp_num;const u8 acpi_id[ACPI_ID_LEN ];const bool direction[2 ];// playback & capture support +const bool ignore_pch_dmic;const char *dai_name;const struct snd_soc_ops *ops;
Signature · 1 line
2.30.2
Greg Kroah-Hartman
maintainerPATCH 36/292 dmaengine: fsl-qdma: check dma_set_mask return value
In reply to Greg Kroah-HartmanFrom: Robin Gong <[email protected]>
[ Upstream commit f0c07993af0acf5545d5c1445798846565f4f147 ]
For fix below warning reported by static code analysis tool like Coverity from Synopsys:
Addresses-Coverity-ID: 12285639 ("Unchecked return value")
--- drivers/dma/fsl-qdma.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)
drivers/dma/fsl-qdma.c +5 -1
@@ -1235,7 +1235,11 @@ static int fsl_qdma_probe(struct platform_device *pdev) fsl_qdma->dma_dev.device_synchronize = fsl_qdma_synchronize; fsl_qdma->dma_dev.device_terminate_all = fsl_qdma_terminate_all; -dma_set_mask (&pdev->dev,DMA_BIT_MASK (40 )); + ret =dma_set_mask (&pdev->dev,DMA_BIT_MASK (40 )); +if (ret) { +dev_err (&pdev->dev,"dma_set_mask failure.\n" ); +return ret; + }platform_set_drvdata (pdev, fsl_qdma);
Signature · 1 line
2.30.2
Greg Kroah-Hartman
maintainerPATCH 37/292 scsi: arcmsr: Fix the wrong CDB payload report to IOP
In reply to Greg Kroah-HartmanFrom: ching Huang <[email protected]>
[ Upstream commit 5b8644968d2ca85abb785e83efec36934974b0c2 ]
This patch fixes the wrong CDB payload report to IOP.
--- drivers/scsi/arcmsr/arcmsr_hba.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-)
drivers/scsi/arcmsr/arcmsr_hba.c +6 -2
@@ -1923,8 +1923,12 @@ static void arcmsr_post_ccb(struct AdapterControlBlock *acb, struct CommandContrif (ccb->arc_cdb_size <=0x300 ) arc_cdb_size = (ccb->arc_cdb_size -1 ) >>6 |1 ; -else - arc_cdb_size = (((ccb->arc_cdb_size +0xff ) >>8 ) +2 ) <<1 |1 ; +else { + arc_cdb_size = ((ccb->arc_cdb_size +0xff ) >>8 ) +2 ; +if (arc_cdb_size >0xF ) + arc_cdb_size =0xF ; + arc_cdb_size = (arc_cdb_size <<1 ) |1 ; + } ccb_post_stamp = (ccb->smid | arc_cdb_size);writel (0 , &pmu->inbound_queueport_high);writel (ccb_post_stamp, &pmu->inbound_queueport_low);
Signature · 1 line
2.30.2
Greg Kroah-Hartman
maintainerPATCH 38/292 srcu: Fix broken node geometry after early ssp init
In reply to Greg Kroah-HartmanFrom: Frederic Weisbecker <[email protected]>
[ Upstream commit b5befe842e6612cf894cf4a199924ee872d8b7d8 ]
An srcu_struct structure that is initialized before rcu_init_geometry() will have its srcu_node hierarchy based on CONFIG_NR_CPUS. Once rcu_init_geometry() is called, this hierarchy is compressed as needed for the actual maximum number of CPUs for this system.
Later on, that srcu_struct structure is confused, sometimes referring to its initial CONFIG_NR_CPUS-based hierarchy, and sometimes instead to the new num_possible_cpus() hierarchy. For example, each of its ->mynode fields continues to reference the original leaf rcu_node structures, some of which might no longer exist. On the other hand, srcu_for_each_node_breadth_first() traverses to the new node hierarchy.
There are at least two bad possible outcomes to this:
1) a) A callback enqueued early on an srcu_data structure (call it
*sdp) is recorded pending on sdp->mynode->srcu_data_have_cbs in
srcu_funnel_gp_start() with sdp->mynode pointing to a deep leaf
(say 3 levels). b) The grace period ends after rcu_init_geometry() shrinks the nodes level to a single one. srcu_gp_end() walks through the new srcu_node hierarchy without ever reaching the old leaves so the callback is never executed.
This is easily reproduced on an 8 CPUs machine with CONFIG_NR_CPUS >= 32 and "rcupdate.rcu_self_test=1". The srcu_barrier() after early tests verification never completes and the boot hangs:
[ 5413.141029] INFO: task swapper/0:1 blocked for more than 4915 seconds. [ 5413.147564] Not tainted 5.12.0-rc4+ #28 [ 5413.151927] "echo 0 > /proc/sys/kernel/hung_task_timeout_secs" disables this message. [ 5413.159753] task:swapper/0 state:D stack: 0 pid: 1 ppid: 0 flags:0x00004000 [ 5413.168099] Call Trace: [ 5413.170555] __schedule+0x36c/0x930 [ 5413.174057] ? wait_for_completion+0x88/0x110 [ 5413.178423] schedule+0x46/0xf0 [ 5413.181575] schedule_timeout+0x284/0x380 [ 5413.185591] ? wait_for_completion+0x88/0x110 [ 5413.189957] ? mark_held_locks+0x61/0x80 [ 5413.193882] ? mark_held_locks+0x61/0x80 [ 5413.197809] ? _raw_spin_unlock_irq+0x24/0x50 [ 5413.202173] ? wait_for_completion+0x88/0x110 [ 5413.206535] wait_for_completion+0xb4/0x110 [ 5413.210724] ? srcu_torture_stats_print+0x110/0x110 [ 5413.215610] srcu_barrier+0x187/0x200 [ 5413.219277] ? rcu_tasks_verify_self_tests+0x50/0x50 [ 5413.224244] ? rdinit_setup+0x2b/0x2b [ 5413.227907] rcu_verify_early_boot_tests+0x2d/0x40 [ 5413.232700] do_one_initcall+0x63/0x310 [ 5413.236541] ? rdinit_setup+0x2b/0x2b [ 5413.240207] ? rcu_read_lock_sched_held+0x52/0x80 [ 5413.244912] kernel_init_freeable+0x253/0x28f [ 5413.249273] ? rest_init+0x250/0x250 [ 5413.252846] kernel_init+0xa/0x110 [ 5413.256257] ret_from_fork+0x22/0x30
2) An srcu_struct structure that is initialized before rcu_init_geometry() and used afterward will always have stale rdp->mynode references, resulting in callbacks to be missed in srcu_gp_end(), just like in the previous scenario.
This commit therefore causes init_srcu_struct_nodes to initialize the geometry, if needed. This ensures that the srcu_node hierarchy is properly built and distributed from the get-go.
--- kernel/rcu/rcu.h | 2 ++ kernel/rcu/srcutree.c | 3 +++ kernel/rcu/tree.c | 16 +++++++++++++++- 3 files changed, 20 insertions(+), 1 deletion(-)
kernel/rcu/rcu.h +2 -0
@@ -308,6 +308,8 @@ static inline void rcu_init_levelspread(int *levelspread, const int *levelcnt) } } +extern void rcu_init_geometry (void ); +/* Returns a pointer to the first leaf rcu_node structure. */ #define rcu_first_leaf_node () (rcu_state.level[rcu_num_lvls - 1])
kernel/rcu/srcutree.c +3 -0
@@ -90,6 +90,9 @@ static void init_srcu_struct_nodes(struct srcu_struct *ssp, bool is_static)struct srcu_node *snp;struct srcu_node *snp_first; +/* Initialize geometry if it has not already been initialized. */ +rcu_init_geometry (); +/* Work out the overall tree geometry. */ ssp->level[0 ] = &ssp->node[0 ];for (i =1 ; i < rcu_num_lvls; i++)
kernel/rcu/tree.c +15 -1
@@ -4502,11 +4502,25 @@ static void __init rcu_init_one(void)* replace the definitions in tree.h because those are needed to size * the ->node array in the rcu_state structure. */ -static void __init rcu_init_geometry (void ) +void rcu_init_geometry (void ) {ulong d;int i; +static unsigned long old_nr_cpu_ids;int rcu_capacity[RCU_NUM_LVLS ]; +static bool initialized; + +if (initialized) { +/* +* Warn if setup_nr_cpu_ids() had not yet been invoked, +* unless nr_cpus_ids == NR_CPUS, in which case who cares? +*/ +WARN_ON_ONCE (old_nr_cpu_ids != nr_cpu_ids); +return ; + } + + old_nr_cpu_ids = nr_cpu_ids; + initialized = true;/* * Initialize any unspecified boot parameters.
Signature · 1 line
2.30.2
Greg Kroah-Hartman
maintainerPATCH 39/292 rcu: Reject RCU_LOCKDEP_WARN() false positives
In reply to Greg Kroah-HartmanFrom: Paul E. McKenney <[email protected]>
[ Upstream commit 3066820034b5dd4e89bd74a7739c51c2d6f5e554 ]
If another lockdep report runs concurrently with an RCU lockdep report from RCU_LOCKDEP_WARN(), the following sequence of events can occur:
1. debug_lockdep_rcu_enabled() sees that lockdep is enabled
when called from (say) synchronize_rcu().
2. Lockdep is disabled by a concurrent lockdep report.
3. debug_lockdep_rcu_enabled() evaluates its lockdep-expression
argument, for example, lock_is_held(&rcu_bh_lock_map).
4. Because lockdep is now disabled, lock_is_held() plays it safe and
returns the constant 1.
5. But in this case, the constant 1 is not safe, because invoking
synchronize_rcu() under rcu_read_lock_bh() is disallowed.
6. debug_lockdep_rcu_enabled() wrongly invokes lockdep_rcu_suspicious(),
resulting in a false-positive splat.
This commit therefore changes RCU_LOCKDEP_WARN() to check debug_lockdep_rcu_enabled() after checking the lockdep expression, so that any "safe" returns from lock_is_held() are rejected by debug_lockdep_rcu_enabled(). This requires memory ordering, which is supplied by READ_ONCE(debug_locks). The resulting volatile accesses prevent the compiler from reordering and the fact that only one variable is being accessed prevents the underlying hardware from reordering. The combination works for IA64, which can reorder reads to the same location, but this is defeated by the volatile accesses, which compile to load instructions that provide ordering.
--- include/linux/rcupdate.h | 2 +- kernel/rcu/update.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
include/linux/rcupdate.h +1 -1
@@ -315,7 +315,7 @@ static inline int rcu_read_lock_any_held(void)#define RCU_LOCKDEP_WARN (c, s) \ do { \ static bool __section(".data.unlikely") __warned; \ - if (debug_lockdep_rcu_enabled() && !__warned && (c)) { \ + if ((c) && debug_lockdep_rcu_enabled() && !__warned) { \ __warned = true; \ lockdep_rcu_suspicious(__FILE__, __LINE__, s); \ } \
kernel/rcu/update.c +1 -1
@@ -277,7 +277,7 @@ EXPORT_SYMBOL_GPL(rcu_callback_map); noinstr int notrace debug_lockdep_rcu_enabled(void) { -return rcu_scheduler_active !=RCU_SCHEDULER_INACTIVE && debug_locks && +return rcu_scheduler_active !=RCU_SCHEDULER_INACTIVE &&READ_ONCE (debug_locks) && current->lockdep_recursion ==0 ; }EXPORT_SYMBOL_GPL (debug_lockdep_rcu_enabled);
Signature · 1 line
2.30.2
Greg Kroah-Hartman
maintainerPATCH 40/292 usb: dwc3: pci: Fix DEFINE for Intel Elkhart Lake
In reply to Greg Kroah-HartmanFrom: Raymond Tan <[email protected]>
[ Upstream commit 457d22850b27de3aea336108272d08602c55fdf7 ]
There's no separate low power (LP) version of Elkhart Lake, thus this patch updates the PCI Device ID DEFINE to indicate this.
--- drivers/usb/dwc3/dwc3-pci.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/usb/dwc3/dwc3-pci.c +4 -4
@@ -36,7 +36,7 @@#define PCI_DEVICE_ID_INTEL_CNPH 0xa36e#define PCI_DEVICE_ID_INTEL_CNPV 0xa3b0#define PCI_DEVICE_ID_INTEL_ICLLP 0x34ee -#define PCI_DEVICE_ID_INTEL_EHLLP 0x4b7e +#define PCI_DEVICE_ID_INTEL_EHL 0x4b7e#define PCI_DEVICE_ID_INTEL_TGPLP 0xa0ee#define PCI_DEVICE_ID_INTEL_TGPH 0x43ee#define PCI_DEVICE_ID_INTEL_JSP 0x4dee
@@ -167,7 +167,7 @@ static int dwc3_pci_quirks(struct dwc3_pci *dwc)if (pdev->vendor ==PCI_VENDOR_ID_INTEL ) {if (pdev->device ==PCI_DEVICE_ID_INTEL_BXT || pdev->device ==PCI_DEVICE_ID_INTEL_BXT_M || - pdev->device ==PCI_DEVICE_ID_INTEL_EHLLP ) { + pdev->device ==PCI_DEVICE_ID_INTEL_EHL ) {guid_parse (PCI_INTEL_BXT_DSM_GUID , &dwc->guid); dwc->has_dsm_for_pm = true; }
@@ -375,8 +375,8 @@ static const struct pci_device_id dwc3_pci_id_table[] = { {PCI_VDEVICE (INTEL ,PCI_DEVICE_ID_INTEL_ICLLP ), (kernel_ulong_t) &dwc3_pci_intel_swnode, }, - { PCI_VDEVICE(INTEL, PCI_DEVICE_ID_INTEL_EHLLP), - (kernel_ulong_t) &dwc3_pci_intel_swnode }, + { PCI_VDEVICE(INTEL, PCI_DEVICE_ID_INTEL_EHL), + (kernel_ulong_t) &dwc3_pci_intel_swnode, }, { PCI_VDEVICE(INTEL, PCI_DEVICE_ID_INTEL_TGPLP), (kernel_ulong_t) &dwc3_pci_intel_swnode, },
Signature · 1 line
2.30.2
Greg Kroah-Hartman
maintainerPATCH 41/292 tty: serial: fsl_lpuart: fix the potential risk of division or modulo by zero
In reply to Greg Kroah-HartmanFrom: Sherry Sun <[email protected]>
[ Upstream commit fcb10ee27fb91b25b68d7745db9817ecea9f1038 ]
We should be very careful about the register values that will be used for division or modulo operations, althrough the possibility that the UARTBAUD register value is zero is very low, but we had better to deal with the "bad data" of hardware in advance to avoid division or modulo by zero leading to undefined kernel behavior.
--- drivers/tty/serial/fsl_lpuart.c | 3 +++ 1 file changed, 3 insertions(+)
drivers/tty/serial/fsl_lpuart.c +3 -0
@@ -2404,6 +2404,9 @@ lpuart32_console_get_options(struct lpuart_port *sport, int *baud, bd =lpuart32_read (&sport->port,UARTBAUD ); bd &=UARTBAUD_SBR_MASK ; +if (!bd) +return ; + sbr = bd; uartclk =lpuart_get_baud_clk_rate (sport);/*
Signature · 1 line
2.30.2
Greg Kroah-Hartman
maintainerPATCH 42/292 serial: fsl_lpuart: disable DMA for console and fix sysrq
In reply to Greg Kroah-HartmanFrom: Michael Walle <[email protected]>
[ Upstream commit 8cac2f6eb8548245e6f8fb893fc7f2a714952654 ]
SYSRQ doesn't work with DMA. This is because there is no error indication whether a symbol had a framing error or not. Actually, this is not completely correct, there is a bit in the data register which is set in this case, but we'd have to read change the DMA access to 16 bit and we'd need to post process the data, thus make the DMA pointless in the first place.
--- drivers/tty/serial/fsl_lpuart.c | 6 ++++++ 1 file changed, 6 insertions(+)
drivers/tty/serial/fsl_lpuart.c +6 -0
@@ -1571,6 +1571,9 @@ static void lpuart_tx_dma_startup(struct lpuart_port *sport)u32 uartbaud;int ret; +if (uart_console (&sport->port)) + goto err; +if (!sport->dma_tx_chan) goto err;
@@ -1600,6 +1603,9 @@ static void lpuart_rx_dma_startup(struct lpuart_port *sport)int ret;unsigned char cr3; +if (uart_console (&sport->port)) + goto err; +if (!sport->dma_rx_chan) goto err;
Signature · 1 line
2.30.2
Greg Kroah-Hartman
maintainerPATCH 43/292 misc/libmasm/module: Fix two use after free in ibmasm_init_one
In reply to Greg Kroah-HartmanFrom: Lv Yunlong <[email protected]>
[ Upstream commit 7272b591c4cb9327c43443f67b8fbae7657dd9ae ]
In ibmasm_init_one, it calls ibmasm_init_remote_input_dev(). Inside ibmasm_init_remote_input_dev, mouse_dev and keybd_dev are allocated by input_allocate_device(), and assigned to sp->remote.mouse_dev and sp->remote.keybd_dev respectively.
In the err_free_devices error branch of ibmasm_init_one, mouse_dev and keybd_dev are freed by input_free_device(), and return error. Then the execution runs into error_send_message error branch of ibmasm_init_one, where ibmasm_free_remote_input_dev(sp) is called to unregister the freed sp->remote.mouse_dev and sp->remote.keybd_dev.
My patch add a "error_init_remote" label to handle the error of ibmasm_init_remote_input_dev(), to avoid the uaf bugs.
--- drivers/misc/ibmasm/module.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/misc/ibmasm/module.c +3 -2
@@ -111,7 +111,7 @@ static int ibmasm_init_one(struct pci_dev *pdev, const struct pci_device_id *id) result =ibmasm_init_remote_input_dev (sp);if (result) {dev_err (sp->dev,"Failed to initialize remote queue\n" ); - goto error_send_message; + goto error_init_remote; } result =ibmasm_send_driver_vpd (sp);
@@ -131,8 +131,9 @@ static int ibmasm_init_one(struct pci_dev *pdev, const struct pci_device_id *id)return 0 ; error_send_message: -disable_sp_interrupts (sp->base_address);ibmasm_free_remote_input_dev (sp); +error_init_remote: +disable_sp_interrupts (sp->base_address);free_irq (sp->irq, (void *)sp); error_request_irq:iounmap (sp->base_address);
Signature · 1 line
2.30.2
Greg Kroah-Hartman
maintainerPATCH 44/292 misc: alcor_pci: fix null-ptr-deref when there is no PCI bridge
In reply to Greg Kroah-HartmanFrom: Tong Zhang <[email protected]>
[ Upstream commit 3ce3e45cc333da707d4d6eb433574b990bcc26f5 ]
There is an issue with the ASPM(optional) capability checking function. A device might be attached to root complex directly, in this case, bus->self(bridge) will be NULL, thus priv->parent_pdev is NULL. Since alcor_pci_init_check_aspm(priv->parent_pdev) checks the PCI link's ASPM capability and populate parent_cap_off, which will be used later by alcor_pci_aspm_ctrl() to dynamically turn on/off device, what we can do here is to avoid checking the capability if we are on the root complex. This will make pdev_cap_off 0 and alcor_pci_aspm_ctrl() will simply return when bring called, effectively disable ASPM for the device.
[ 1.246492] BUG: kernel NULL pointer dereference, address: 00000000000000c0 [ 1.248731] RIP: 0010:pci_read_config_byte+0x5/0x40 [ 1.253998] Call Trace: [ 1.254131] ? alcor_pci_find_cap_offset.isra.0+0x3a/0x100 [alcor_pci] [ 1.254476] alcor_pci_probe+0x169/0x2d5 [alcor_pci]
--- drivers/misc/cardreader/alcor_pci.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-)
drivers/misc/cardreader/alcor_pci.c +7 -1
@@ -139,7 +139,13 @@ static void alcor_pci_init_check_aspm(struct alcor_pci_priv *priv)u32 val32; priv->pdev_cap_off =alcor_pci_find_cap_offset (priv, priv->pdev); - priv->parent_cap_off =alcor_pci_find_cap_offset (priv, +/* +* A device might be attached to root complex directly and +* priv->parent_pdev will be NULL. In this case we don't check its +* capability and disable ASPM completely. +*/ +if (!priv->parent_pdev) + priv->parent_cap_off =alcor_pci_find_cap_offset (priv, priv->parent_pdev);if ((priv->pdev_cap_off ==0 ) || (priv->parent_cap_off ==0 )) {
Signature · 1 line
2.30.2
Greg Kroah-Hartman
maintainerPATCH 45/292 ASoC: intel/boards: add missing MODULE_DEVICE_TABLE
In reply to Greg Kroah-HartmanFrom: Zou Wei <[email protected]>
[ Upstream commit a75e5cdf4dd1307bb1541edbb0c008f40896644c ]
This patch adds missing MODULE_DEVICE_TABLE definition which generates correct modalias for automatic loading of this driver when it is built as an external module.
--- sound/soc/intel/boards/sof_da7219_max98373.c | 1 + sound/soc/intel/boards/sof_rt5682.c | 1 + 2 files changed, 2 insertions(+)
sound/soc/intel/boards/sof_da7219_max98373.c +1 -0
@@ -440,6 +440,7 @@ static const struct platform_device_id board_ids[] = { }, { } }; +MODULE_DEVICE_TABLE (platform, board_ids);static struct platform_driver audio = { .probe = audio_probe,
sound/soc/intel/boards/sof_rt5682.c +1 -0
@@ -942,6 +942,7 @@ static const struct platform_device_id board_ids[] = { }, { } }; +MODULE_DEVICE_TABLE (platform, board_ids);static struct platform_driver sof_audio = { .probe = sof_audio_probe,
Signature · 1 line
2.30.2
Greg Kroah-Hartman
maintainerPATCH 46/292 partitions: msdos: fix one-byte get_unaligned()
In reply to Greg Kroah-HartmanFrom: Arnd Bergmann <[email protected]>
[ Upstream commit 1b1774998b2dec837a57d729d1a22e5eb2d6d206 ]
A simplification of get_unaligned() clashes with callers that pass in a character pointer, causing a harmless warning like:
block/partitions/msdos.c: In function 'msdos_partition':include/asm-generic/unaligned.h:13:22: warning: 'packed' attribute ignored for field of type 'u8' {aka 'unsigned char'} [-Wattributes]
Remove the SYS_IND() macro with the get_unaligned() call and just use the ->ind field directly.
--- block/partitions/ldm.c | 2 +- block/partitions/ldm.h | 3 --- block/partitions/msdos.c | 24 +++++++++++------------- 3 files changed, 12 insertions(+), 17 deletions(-)
block/partitions/ldm.c +1 -1
@@ -510,7 +510,7 @@ static bool ldm_validate_partition_table(struct parsed_partitions *state) p = (struct msdos_partition *)(data +0x01BE );for (i =0 ; i <4 ; i++, p++) -if (SYS_IND (p) ==LDM_PARTITION ) { +if (p->sys_ind ==LDM_PARTITION ) { result = true;break ; }
block/partitions/ldm.h +0 -3
@@ -84,9 +84,6 @@ struct parsed_partitions;#define TOC_BITMAP1 "config"/* Names of the two defined */ #define TOC_BITMAP2 "log"/* bitmaps in the TOCBLOCK. */ -/* Borrowed from msdos.c */ -#define SYS_IND (p) (get_unaligned(&(p)->sys_ind)) -struct frag {/* VBLK Fragment handling */ struct list_head list;u32 group;
block/partitions/msdos.c +11 -13
@@ -38,8 +38,6 @@*/ #include <asm/unaligned.h> -#define SYS_IND (p) get_unaligned(&p->sys_ind) -static inline sector_t nr_sects (struct msdos_partition *p) {return (sector_t )get_unaligned_le32 (&p->nr_sects);
@@ -52,9 +50,9 @@ static inline sector_t start_sect(struct msdos_partition *p)static inline int is_extended_partition (struct msdos_partition *p) { -return (SYS_IND (p) ==DOS_EXTENDED_PARTITION || -SYS_IND (p) ==WIN98_EXTENDED_PARTITION || -SYS_IND (p) ==LINUX_EXTENDED_PARTITION ); +return (p->sys_ind ==DOS_EXTENDED_PARTITION || + p->sys_ind ==WIN98_EXTENDED_PARTITION || + p->sys_ind ==LINUX_EXTENDED_PARTITION ); }#define MSDOS_LABEL_MAGIC1 0x55
@@ -193,7 +191,7 @@ static void parse_extended(struct parsed_partitions *state,put_partition (state, state->next, next, size);set_info (state, state->next, disksig); -if (SYS_IND (p) ==LINUX_RAID_PARTITION ) +if (p->sys_ind ==LINUX_RAID_PARTITION ) state->parts[state->next].flags =ADDPART_FLAG_RAID ; loopct =0 ;if (++state->next == state->limit)
@@ -546,7 +544,7 @@ static void parse_minix(struct parsed_partitions *state,* a secondary MBR describing its subpartitions, or * the normal boot sector. */ if (msdos_magic_present (data +510 ) && -SYS_IND (p) ==MINIX_PARTITION ) {/* subpartition table present */ + p->sys_ind ==MINIX_PARTITION ) {/* subpartition table present */ char tmp[1 +BDEVNAME_SIZE +10 +9 +1 ];snprintf (tmp,sizeof (tmp)," %s%d: <minix:" , state->name, origin);
@@ -555,7 +553,7 @@ static void parse_minix(struct parsed_partitions *state,if (state->next == state->limit)break ;/* add each partition in use */ -if (SYS_IND (p) ==MINIX_PARTITION ) +if (p->sys_ind ==MINIX_PARTITION )put_partition (state, state->next++,start_sect (p),nr_sects (p)); }
@@ -643,7 +641,7 @@ int msdos_partition(struct parsed_partitions *state) p = (struct msdos_partition *) (data +0x1be );for (slot =1 ; slot <=4 ; slot++, p++) {/* If this is an EFI GPT disk, msdos should ignore it. */ -if (SYS_IND (p) ==EFI_PMBR_OSTYPE_EFI_GPT ) { +if (p->sys_ind ==EFI_PMBR_OSTYPE_EFI_GPT ) {put_dev_sector (sect);return 0 ; }
@@ -685,11 +683,11 @@ int msdos_partition(struct parsed_partitions *state) }put_partition (state, slot, start, size);set_info (state, slot, disksig); -if (SYS_IND (p) ==LINUX_RAID_PARTITION ) +if (p->sys_ind ==LINUX_RAID_PARTITION ) state->parts[slot].flags =ADDPART_FLAG_RAID ; -if (SYS_IND (p) ==DM6_PARTITION ) +if (p->sys_ind ==DM6_PARTITION )strlcat (state->pp_buf,"[DM]" ,PAGE_SIZE ); -if (SYS_IND (p) ==EZD_PARTITION ) +if (p->sys_ind ==EZD_PARTITION )strlcat (state->pp_buf,"[EZD]" ,PAGE_SIZE ); }
@@ -698,7 +696,7 @@ int msdos_partition(struct parsed_partitions *state)/* second pass - output for each on a separate line */ p = (struct msdos_partition *) (0x1be + data);for (slot =1 ; slot <=4 ; slot++, p++) { -unsigned char id =SYS_IND (p); +unsigned char id = p->sys_ind;int n;if (!nr_sects (p))
Signature · 1 line
2.30.2
Greg Kroah-Hartman
maintainerPATCH 47/292 iio: imu: st_lsm6dsx: correct ODR in header
In reply to Greg Kroah-HartmanFrom: Sean Nyekjaer <[email protected]>
[ Upstream commit f7d5c18a8c371c306d73757547c2e0d6cfc764b3 ]
Fix wrongly stated 13 Hz ODR for accelerometers, the correct ODR is 12.5 Hz
--- drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/iio/imu/st_lsm6dsx/st_lsm6dsx_core.c +3 -3
@@ -15,19 +15,19 @@* * Supported sensors: * - LSM6DS3: -* - Accelerometer/Gyroscope supported ODR [Hz]: 13, 26, 52, 104, 208, 416 +* - Accelerometer/Gyroscope supported ODR [Hz]: 12.5, 26, 52, 104, 208, 416 * - Accelerometer supported full-scale [g]: +-2/+-4/+-8/+-16 * - Gyroscope supported full-scale [dps]: +-125/+-245/+-500/+-1000/+-2000 * - FIFO size: 8KB * * - LSM6DS3H/LSM6DSL/LSM6DSM/ISM330DLC/LSM6DS3TR-C: -* - Accelerometer/Gyroscope supported ODR [Hz]: 13, 26, 52, 104, 208, 416 +* - Accelerometer/Gyroscope supported ODR [Hz]: 12.5, 26, 52, 104, 208, 416 * - Accelerometer supported full-scale [g]: +-2/+-4/+-8/+-16 * - Gyroscope supported full-scale [dps]: +-125/+-245/+-500/+-1000/+-2000 * - FIFO size: 4KB * * - LSM6DSO/LSM6DSOX/ASM330LHH/LSM6DSR/ISM330DHCX/LSM6DST/LSM6DSOP: -* - Accelerometer/Gyroscope supported ODR [Hz]: 13, 26, 52, 104, 208, 416, +* - Accelerometer/Gyroscope supported ODR [Hz]: 12.5, 26, 52, 104, 208, 416, * 833 * - Accelerometer supported full-scale [g]: +-2/+-4/+-8/+-16 * - Gyroscope supported full-scale [dps]: +-125/+-245/+-500/+-1000/+-2000
Signature · 1 line
2.30.2
Greg Kroah-Hartman
maintainerPATCH 48/292 iio: gyro: fxa21002c: Balance runtime pm + use pm_runtime_resume_and_get().
In reply to Greg Kroah-HartmanFrom: Jonathan Cameron <[email protected]>
[ Upstream commit 41120ebbb1eb5e9dec93320e259d5b2c93226073 ]
In both the probe() error path and remove() pm_runtime_put_noidle() is called which will decrement the runtime pm reference count. However, there is no matching function to have raised the reference count. Not this isn't a fix as the runtime pm core will stop the reference count going negative anyway.
An alternative would have been to raise the count in these paths, but it is not clear why that would be necessary.
Whilst we are here replace some boilerplate with pm_runtime_resume_and_get() Found using coccicheck script under review at:
https://lore.kernel.org/lkml/[email protected]/
--- drivers/iio/gyro/fxas21002c_core.c | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-)
drivers/iio/gyro/fxas21002c_core.c +1 -10
@@ -366,14 +366,7 @@ out_unlock:static int fxas21002c_pm_get (struct fxas21002c_data *data) { -struct device *dev =regmap_get_device (data->regmap); -int ret; - - ret =pm_runtime_get_sync (dev); -if (ret <0 ) -pm_runtime_put_noidle (dev); - -return ret; +return pm_runtime_resume_and_get (regmap_get_device (data->regmap)); }static int fxas21002c_pm_put (struct fxas21002c_data *data)
@@ -1005,7 +998,6 @@ int fxas21002c_core_probe(struct device *dev, struct regmap *regmap, int irq, pm_disable:pm_runtime_disable (dev);pm_runtime_set_suspended (dev); -pm_runtime_put_noidle (dev);return ret; }
@@ -1019,7 +1011,6 @@ void fxas21002c_core_remove(struct device *dev)pm_runtime_disable (dev);pm_runtime_set_suspended (dev); -pm_runtime_put_noidle (dev); }EXPORT_SYMBOL_GPL (fxas21002c_core_remove);
Signature · 1 line
2.30.2
Greg Kroah-Hartman
maintainerPATCH 49/292 iio: magn: bmc150: Balance runtime pm + use pm_runtime_resume_and_get()
In reply to Greg Kroah-HartmanFrom: Jonathan Cameron <[email protected]>
[ Upstream commit 264da512431495e542fcaf56ffe75e7df0e7db74 ]
probe() error paths after runtime pm is enabled, should disable it. remove() should not call pm_runtime_put_noidle() as there is no matching get() to have raised the reference count. This case has no affect a the runtime pm core protects against going negative.
Whilst here use pm_runtime_resume_and_get() to tidy things up a little. coccicheck script didn't get this one due to complex code structure so found by inspection.
--- drivers/iio/magnetometer/bmc150_magn.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-)
drivers/iio/magnetometer/bmc150_magn.c +4 -6
@@ -265,7 +265,7 @@ static int bmc150_magn_set_power_state(struct bmc150_magn_data *data, bool on)int ret;if (on) { - ret =pm_runtime_get_sync (data->dev); + ret =pm_runtime_resume_and_get (data->dev); }else {pm_runtime_mark_last_busy (data->dev); ret =pm_runtime_put_autosuspend (data->dev);
@@ -274,9 +274,6 @@ static int bmc150_magn_set_power_state(struct bmc150_magn_data *data, bool on)if (ret <0 ) {dev_err (data->dev,"failed to change power state to %d\n" , on); -if (on) -pm_runtime_put_noidle (data->dev); -return ret; }#endif
@@ -967,12 +964,14 @@ int bmc150_magn_probe(struct device *dev, struct regmap *regmap, ret =iio_device_register (indio_dev);if (ret <0 ) {dev_err (dev,"unable to register iio device\n" ); - goto err_buffer_cleanup; + goto err_disable_runtime_pm; }dev_dbg (dev,"Registered device %s\n" , name);return 0 ; +err_disable_runtime_pm: +pm_runtime_disable (dev); err_buffer_cleanup:iio_triggered_buffer_cleanup (indio_dev); err_free_irq:
@@ -996,7 +995,6 @@ int bmc150_magn_remove(struct device *dev)pm_runtime_disable (dev);pm_runtime_set_suspended (dev); -pm_runtime_put_noidle (dev);iio_triggered_buffer_cleanup (indio_dev);
Signature · 1 line
2.30.2
Greg Kroah-Hartman
maintainerPATCH 50/292 ALSA: usx2y: Avoid camelCase
In reply to Greg Kroah-HartmanFrom: Takashi Iwai <[email protected]>
[ Upstream commit bae3ce4942980d5f7b2b9855f4a2db0c00f9dfbd ]
For improving readability, convert camelCase fields, variables and functions to the plain names with underscore. Also align the macros to be capital letters.
All done via sed, no functional changes.
Note that you'll still see many coding style issues even after this patch; the fixes will follow.
--- sound/usb/usx2y/usX2Yhwdep.c | 56 ++-- sound/usb/usx2y/usX2Yhwdep.h | 2 +- sound/usb/usx2y/usbus428ctldefs.h | 102 +++---- sound/usb/usx2y/usbusx2y.c | 218 +++++++-------- sound/usb/usx2y/usbusx2y.h | 58 ++-- sound/usb/usx2y/usbusx2yaudio.c | 448 +++++++++++++++--------------- sound/usb/usx2y/usx2yhwdeppcm.c | 410 +++++++++++++-------------- sound/usb/usx2y/usx2yhwdeppcm.h | 4 +- 8 files changed, 649 insertions(+), 649 deletions(-)
sound/usb/usx2y/usX2Yhwdep.c +28 -28
@@ -29,7 +29,7 @@ static vm_fault_t snd_us428ctls_vm_fault(struct vm_fault *vmf) vmf->pgoff); offset = vmf->pgoff <<PAGE_SHIFT ; - vaddr = (char *)((struct usX2Ydev *)vmf->vma->vm_private_data)->us428ctls_sharedmem + offset; + vaddr = (char *)((struct usx2ydev *)vmf->vma->vm_private_data)->us428ctls_sharedmem + offset; page =virt_to_page (vaddr);get_page (page); vmf->page = page;
@@ -47,7 +47,7 @@ static const struct vm_operations_struct us428ctls_vm_ops = {static int snd_us428ctls_mmap (struct snd_hwdep * hw,struct file *filp,struct vm_area_struct *area) {unsigned long size = (unsigned long )(area->vm_end - area->vm_start); -struct usX2Ydev *us428 = hw->private_data; +struct usx2ydev *us428 = hw->private_data;// FIXME this hwdep interface is used twice: fpga download and mmap for controlling Lights etc. Maybe better using 2 hwdep devs? // so as long as the device isn't fully initialised yet we return -EBUSY here.
@@ -66,7 +66,7 @@ static int snd_us428ctls_mmap(struct snd_hwdep * hw, struct file *filp, struct vif (!us428->us428ctls_sharedmem)return -ENOMEM ;memset (us428->us428ctls_sharedmem,-1 ,sizeof (struct us428ctls_sharedmem )); - us428->us428ctls_sharedmem->CtlSnapShotLast =-2 ; + us428->us428ctls_sharedmem->ctl_snapshot_last =-2 ; } area->vm_ops = &us428ctls_vm_ops; area->vm_flags |=VM_DONTEXPAND |VM_DONTDUMP ;
@@ -77,21 +77,21 @@ static int snd_us428ctls_mmap(struct snd_hwdep * hw, struct file *filp, struct vstatic __poll_t snd_us428ctls_poll (struct snd_hwdep *hw,struct file *file,poll_table *wait) {__poll_t mask =0 ; -struct usX2Ydev *us428 = hw->private_data; +struct usx2ydev *us428 = hw->private_data;struct us428ctls_sharedmem *shm = us428->us428ctls_sharedmem;if (us428->chip_status &USX2Y_STAT_CHIP_HUP )return EPOLLHUP ;poll_wait (file, &us428->us428ctls_wait_queue_head, wait); -if (shm !=NULL && shm->CtlSnapShotLast != shm->CtlSnapShotRed) +if (shm !=NULL && shm->ctl_snapshot_last != shm->ctl_snapshot_red) mask |=EPOLLIN ;return mask; } -static int snd_usX2Y_hwdep_dsp_status (struct snd_hwdep *hw, +static int snd_usx2y_hwdep_dsp_status (struct snd_hwdep *hw,struct snd_hwdep_dsp_status *info) {static const char *const type_ids[USX2Y_TYPE_NUMS ] = {
@@ -99,7 +99,7 @@ static int snd_usX2Y_hwdep_dsp_status(struct snd_hwdep *hw, [USX2Y_TYPE_224] = "us224", [USX2Y_TYPE_428] = "us428", }; -struct usX2Ydev *us428 = hw->private_data; +struct usx2ydev *us428 = hw->private_data;int id =-1 ;switch (le16_to_cpu (us428->dev->descriptor.idProduct)) {
@@ -124,7 +124,7 @@ static int snd_usX2Y_hwdep_dsp_status(struct snd_hwdep *hw, } -static int usX2Y_create_usbmidi (struct snd_card *card) +static int usx2y_create_usbmidi (struct snd_card *card) {static const struct snd_usb_midi_endpoint_info quirk_data_1 = { .out_ep =0x06 ,
@@ -152,28 +152,28 @@ static int usX2Y_create_usbmidi(struct snd_card *card) .type = QUIRK_MIDI_FIXED_ENDPOINT, .data = &quirk_data_2 }; -struct usb_device *dev =usX2Y (card)->dev; +struct usb_device *dev =usx2y (card)->dev;struct usb_interface *iface =usb_ifnum_to_if (dev,0 );const struct snd_usb_audio_quirk *quirk =le16_to_cpu (dev->descriptor.idProduct) ==USB_ID_US428 ? &quirk_2 : &quirk_1; -snd_printdd ("usX2Y_create_usbmidi \n" ); -return snd_usbmidi_create (card, iface, &usX2Y (card)->midi_list, quirk); +snd_printdd ("usx2y_create_usbmidi \n" ); +return snd_usbmidi_create (card, iface, &usx2y (card)->midi_list, quirk); } -static int usX2Y_create_alsa_devices (struct snd_card *card) +static int usx2y_create_alsa_devices (struct snd_card *card) {int err; do { - if ((err = usX2Y_create_usbmidi(card)) < 0) { - snd_printk(KERN_ERR "usX2Y_create_alsa_devices: usX2Y_create_usbmidi error %i \n", err); + if ((err = usx2y_create_usbmidi(card)) < 0) { + snd_printk(KERN_ERR "usx2y_create_alsa_devices: usx2y_create_usbmidi error %i \n", err); break; } - if ((err = usX2Y_audio_create(card)) < 0) + if ((err = usx2y_audio_create(card)) < 0) break; - if ((err = usX2Y_hwdep_pcm_new(card)) < 0) + if ((err = usx2y_hwdep_pcm_new(card)) < 0) break; if ((err = snd_card_register(card)) < 0) break;
@@ -182,10 +182,10 @@ static int usX2Y_create_alsa_devices(struct snd_card *card)return err; } -static int snd_usX2Y_hwdep_dsp_load (struct snd_hwdep *hw, +static int snd_usx2y_hwdep_dsp_load (struct snd_hwdep *hw,struct snd_hwdep_dsp_image *dsp) { -struct usX2Ydev *priv = hw->private_data; +struct usx2ydev *priv = hw->private_data;struct usb_device * dev = priv->dev;int lret, err;char *buf;
@@ -206,19 +206,19 @@ static int snd_usX2Y_hwdep_dsp_load(struct snd_hwdep *hw,return err;if (dsp->index ==1 ) {msleep (250 );// give the device some time - err =usX2Y_AsyncSeq04_init (priv); + err =usx2y_async_seq04_init (priv);if (err) { -snd_printk (KERN_ERR "usX2Y_AsyncSeq04_init error \n" ); +snd_printk (KERN_ERR "usx2y_async_seq04_init error \n" );return err; } - err =usX2Y_In04_init (priv); + err =usx2y_in04_init (priv);if (err) { -snd_printk (KERN_ERR "usX2Y_In04_init error \n" ); +snd_printk (KERN_ERR "usx2y_in04_init error \n" );return err; } - err =usX2Y_create_alsa_devices (hw->card); + err =usx2y_create_alsa_devices (hw->card);if (err) { -snd_printk (KERN_ERR "usX2Y_create_alsa_devices error %i \n" , err); +snd_printk (KERN_ERR "usx2y_create_alsa_devices error %i \n" , err);snd_card_free (hw->card);return err; }
@@ -229,7 +229,7 @@ static int snd_usX2Y_hwdep_dsp_load(struct snd_hwdep *hw, } -int usX2Y_hwdep_new (struct snd_card *card,struct usb_device * device) +int usx2y_hwdep_new (struct snd_card *card,struct usb_device * device) {int err;struct snd_hwdep *hw;
@@ -238,9 +238,9 @@ int usX2Y_hwdep_new(struct snd_card *card, struct usb_device* device)return err; hw->iface =SNDRV_HWDEP_IFACE_USX2Y ; - hw->private_data =usX2Y (card); - hw->ops.dsp_status = snd_usX2Y_hwdep_dsp_status; - hw->ops.dsp_load = snd_usX2Y_hwdep_dsp_load; + hw->private_data =usx2y (card); + hw->ops.dsp_status = snd_usx2y_hwdep_dsp_status; + hw->ops.dsp_load = snd_usx2y_hwdep_dsp_load; hw->ops.mmap = snd_us428ctls_mmap; hw->ops.poll = snd_us428ctls_poll; hw->exclusive =1 ;
sound/usb/usx2y/usX2Yhwdep.h +1 -1
@@ -2,6 +2,6 @@#ifndef USX2YHWDEP_H #define USX2YHWDEP_H -int usX2Y_hwdep_new (struct snd_card *card,struct usb_device * device); +int usx2y_hwdep_new (struct snd_card *card,struct usb_device * device);#endif
sound/usb/usx2y/usbus428ctldefs.h +51 -51
132 lines not on this page · raw message
sound/usb/usx2y/usbusx2y.c +109 -109
399 lines not on this page · raw message
sound/usb/usx2y/usbusx2y.h +29 -29
102 lines not on this page · raw message
sound/usb/usx2y/usbusx2yaudio.c +224 -224
952 lines not on this page · raw message
sound/usb/usx2y/usx2yhwdeppcm.c +205 -205
821 lines not on this page · raw message
sound/usb/usx2y/usx2yhwdeppcm.h +2 -2
@@ -4,7 +4,7 @@#define MAXSTRIDE 3#define SSS (((MAXPACK*MAXBUFFERMS*MAXSTRIDE + 4096) / 4096) * 4096) -struct snd_usX2Y_hwdep_pcm_shm { +struct snd_usx2y_hwdep_pcm_shm {char playback[SSS ];char capture0x8[SSS ];char capture0xA[SSS ];
@@ -20,4 +20,4 @@ struct snd_usX2Y_hwdep_pcm_shm {int capture_iso_start; }; -int usX2Y_hwdep_pcm_new (struct snd_card *card); +int usx2y_hwdep_pcm_new (struct snd_card *card);
Signature · 1 line
2.30.2
Greg Kroah-Hartman
maintainerPATCH 51/292 ALSA: usx2y: Dont call free_pages_exact() with NULL address
In reply to Greg Kroah-HartmanFrom: Takashi Iwai <[email protected]>
[ Upstream commit cae0cf651adccee2c3f376e78f30fbd788d0829f ]
Unlike some other functions, we can't pass NULL pointer to free_pages_exact(). Add a proper NULL check for avoiding possible Oops.
--- sound/usb/usx2y/usb_stream.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)
sound/usb/usx2y/usb_stream.c +5 -2
@@ -142,8 +142,11 @@ void usb_stream_free(struct usb_stream_kernel *sk)if (!s)return ; -free_pages_exact (sk->write_page, s->write_size); - sk->write_page =NULL ; +if (sk->write_page) { +free_pages_exact (sk->write_page, s->write_size); + sk->write_page =NULL ; + } +free_pages_exact (s, s->read_size); sk->s =NULL ; }
Signature · 1 line
2.30.2
Greg Kroah-Hartman
maintainerPATCH 52/292 Revert "ALSA: bebob/oxfw: fix Kconfig entry for Mackie d.2 Pro"
In reply to Greg Kroah-HartmanFrom: Takashi Sakamoto <[email protected]>
[ Upstream commit 5d6fb80a142b5994355ce675c517baba6089d199 ]
This reverts commit 0edabdfe89581669609eaac5f6a8d0ae6fe95e7f.
I've explained that optional FireWire card for d.2 is also built-in to d.2 Pro, however it's wrong. The optional card uses DM1000 ASIC and has 'Mackie DJ Mixer' in its model name of configuration ROM. On the other hand, built-in FireWire card for d.2 Pro and d.4 Pro uses OXFW971 ASIC and has 'd.Pro' in its model name according to manuals and user experiences. The former card is not the card for d.2 Pro. They are similar in appearance but different internally.
--- sound/firewire/Kconfig | 4 ++-- sound/firewire/bebob/bebob.c | 2 +- sound/firewire/oxfw/oxfw.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-)
sound/firewire/Kconfig +2 -2
@@ -38,7 +38,7 @@ config SND_OXFW * Mackie(Loud) Onyx 1640i (former model) * Mackie(Loud) Onyx Satellite * Mackie(Loud) Tapco Link.Firewire - * Mackie(Loud) d.4 pro + * Mackie(Loud) d.2 pro/d.4 pro (built-in FireWire card with OXFW971 ASIC) * Mackie(Loud) U.420/U.420d * TASCAM FireOne * Stanton Controllers & Systems 1 Deck/Mixer
@@ -84,7 +84,7 @@ config SND_BEBOB * PreSonus FIREBOX/FIREPOD/FP10/Inspire1394 * BridgeCo RDAudio1/Audio5 * Mackie Onyx 1220/1620/1640 (FireWire I/O Card) - * Mackie d.2 (FireWire Option) and d.2 Pro + * Mackie d.2 (optional FireWire card with DM1000 ASIC) * Stanton FinalScratch 2 (ScratchAmp) * Tascam IF-FW/DM * Behringer XENIX UFX 1204/1604
sound/firewire/bebob/bebob.c +1 -1
@@ -387,7 +387,7 @@ static const struct ieee1394_device_id bebob_id_table[] = {SND_BEBOB_DEV_ENTRY (VEN_BRIDGECO ,0x00010049 , &spec_normal),/* Mackie, Onyx 1220/1620/1640 (Firewire I/O Card) */ SND_BEBOB_DEV_ENTRY (VEN_MACKIE2 ,0x00010065 , &spec_normal), -// Mackie, d.2 (Firewire option card) and d.2 Pro (the card is built-in). +// Mackie, d.2 (optional Firewire card with DM1000). SND_BEBOB_DEV_ENTRY (VEN_MACKIE1 ,0x00010067 , &spec_normal),/* Stanton, ScratchAmp */ SND_BEBOB_DEV_ENTRY(VEN_STANTON, 0x00000001, &spec_normal),
sound/firewire/oxfw/oxfw.c +1 -1
@@ -355,7 +355,7 @@ static const struct ieee1394_device_id oxfw_id_table[] = {* Onyx-i series (former models): 0x081216 * Mackie Onyx Satellite: 0x00200f * Tapco LINK.firewire 4x6: 0x000460 -* d.4 pro: Unknown +* d.2 pro/d.4 pro (built-in card): Unknown * U.420: Unknown * U.420d: Unknown */
Signature · 1 line
2.30.2
Greg Kroah-Hartman
maintainerPATCH 53/292 usb: common: usb-conn-gpio: fix NULL pointer dereference of charger
In reply to Greg Kroah-HartmanFrom: Chunfeng Yun <[email protected]>
[ Upstream commit 880287910b1892ed2cb38977893b947382a09d21 ]
When power on system with OTG cable, IDDIG's interrupt arises before the charger registration, it will cause a NULL pointer dereference, fix the issue by registering the power supply before requesting IDDIG/VBUS irq.
--- drivers/usb/common/usb-conn-gpio.c | 44 ++++++++++++++++++------------ 1 file changed, 26 insertions(+), 18 deletions(-)
drivers/usb/common/usb-conn-gpio.c +26 -18
@@ -149,14 +149,32 @@ static int usb_charger_get_property(struct power_supply *psy,return 0 ; } -static int usb_conn_probe (struct platform_device *pdev) +static int usb_conn_psy_register (struct usb_conn_info *info) { -struct device *dev = &pdev->dev; -struct power_supply_desc *desc; -struct usb_conn_info *info; +struct device *dev = info->dev; +struct power_supply_desc *desc = &info->desc;struct power_supply_config cfg = { .of_node = dev->of_node, }; + + desc->name ="usb-charger" ; + desc->properties = usb_charger_properties; + desc->num_properties =ARRAY_SIZE (usb_charger_properties); + desc->get_property = usb_charger_get_property; + desc->type =POWER_SUPPLY_TYPE_USB ; + cfg.drv_data = info; + + info->charger =devm_power_supply_register (dev, desc, &cfg); +if (IS_ERR (info->charger)) +dev_err (dev,"Unable to register charger\n" ); + +return PTR_ERR_OR_ZERO (info->charger); +} + +static int usb_conn_probe (struct platform_device *pdev) +{ +struct device *dev = &pdev->dev; +struct usb_conn_info *info;bool need_vbus = true;int ret =0 ;
@@ -218,6 +236,10 @@ static int usb_conn_probe(struct platform_device *pdev)return PTR_ERR (info->role_sw); } + ret =usb_conn_psy_register (info); +if (ret) + goto put_role_sw; +if (info->id_gpiod) { info->id_irq =gpiod_to_irq (info->id_gpiod);if (info->id_irq <0 ) {
@@ -252,20 +274,6 @@ static int usb_conn_probe(struct platform_device *pdev) } } - desc = &info->desc; - desc->name ="usb-charger" ; - desc->properties = usb_charger_properties; - desc->num_properties =ARRAY_SIZE (usb_charger_properties); - desc->get_property = usb_charger_get_property; - desc->type =POWER_SUPPLY_TYPE_USB ; - cfg.drv_data = info; - - info->charger =devm_power_supply_register (dev, desc, &cfg); -if (IS_ERR (info->charger)) { -dev_err (dev,"Unable to register charger\n" ); -return PTR_ERR (info->charger); - } -platform_set_drvdata (pdev, info);/* Perform initial detection */
Signature · 1 line
2.30.2
Greg Kroah-Hartman
maintainerPATCH 54/292 w1: ds2438: fixing bug that would always get page0
In reply to Greg Kroah-HartmanFrom: Luiz Sampaio <[email protected]>
[ Upstream commit 1f5e7518f063728aee0679c5086b92d8ea429e11 ]
The purpose of the w1_ds2438_get_page function is to get the register values at the page passed as the pageno parameter. However, the page0 was hardcoded, such that the function always returned the page0 contents. Fixed so that the function can retrieve any page.
--- drivers/w1/slaves/w1_ds2438.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/w1/slaves/w1_ds2438.c +2 -2
@@ -62,13 +62,13 @@ static int w1_ds2438_get_page(struct w1_slave *sl, int pageno, u8 *buf)if (w1_reset_select_slave (sl))continue ; w1_buf[0 ] =W1_DS2438_RECALL_MEMORY ; - w1_buf[1 ] =0x00 ; + w1_buf[1 ] = (u8 )pageno;w1_write_block (sl->master, w1_buf,2 );if (w1_reset_select_slave (sl))continue ; w1_buf[0 ] =W1_DS2438_READ_SCRATCH ; - w1_buf[1 ] =0x00 ; + w1_buf[1 ] = (u8 )pageno;w1_write_block (sl->master, w1_buf,2 ); count =w1_read_block (sl->master, buf,DS2438_PAGE_SIZE +1 );
Signature · 1 line
2.30.2
Greg Kroah-Hartman
maintainerPATCH 55/292 ASoC: Intel: sof_sdw: add quirk support for Brya and BT-offload
In reply to Greg Kroah-HartmanFrom: Vamshi Krishna Gopal <[email protected]>
[ Upstream commit 03effde3a2ea1d82c4dd6b634fc6174545d2c34f ]
Brya is another ADL-P product.
AlderLake has support for Bluetooth audio offload capability. Enable the BT-offload quirk for ADL-P Brya and the Intel RVP.
--- sound/soc/intel/boards/sof_sdw.c | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-)
sound/soc/intel/boards/sof_sdw.c +15 -1
@@ -197,7 +197,21 @@ static const struct dmi_system_id sof_sdw_quirk_table[] = { .driver_data = (void *)(SOF_RT711_JD_SRC_JD1 | SOF_SDW_TGL_HDMI | SOF_RT715_DAI_ID_FIX | - SOF_SDW_PCH_DMIC), + SOF_SDW_PCH_DMIC | + SOF_BT_OFFLOAD_SSP(2) | + SOF_SSP_BT_OFFLOAD_PRESENT), + }, + { + .callback = sof_sdw_quirk_cb, + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "Google"), + DMI_MATCH(DMI_PRODUCT_NAME, "Brya"), + }, + .driver_data = (void *)(SOF_SDW_TGL_HDMI | + SOF_SDW_PCH_DMIC | + SOF_SDW_FOUR_SPK | + SOF_BT_OFFLOAD_SSP(2) | + SOF_SSP_BT_OFFLOAD_PRESENT), }, {} };
Signature · 1 line
2.30.2
Greg Kroah-Hartman
maintainerPATCH 56/292 scsi: arcmsr: Fix doorbell status being updated late on ARC-1886
In reply to Greg Kroah-HartmanFrom: ching Huang <[email protected]>
[ Upstream commit d9a231226f28261a787535e08d0c78669e1ad010 ]
It is possible for the IOP to be delayed in updating the doorbell status. The doorbell status should not be 0 so loop until the value changes.
--- drivers/scsi/arcmsr/arcmsr_hba.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-)
drivers/scsi/arcmsr/arcmsr_hba.c +9 -2
@@ -2419,10 +2419,17 @@ static void arcmsr_hbaD_doorbell_isr(struct AdapterControlBlock *pACB)static void arcmsr_hbaE_doorbell_isr (struct AdapterControlBlock *pACB) { -uint32_t outbound_doorbell, in_doorbell, tmp; +uint32_t outbound_doorbell, in_doorbell, tmp, i;struct MessageUnit_E __iomem *reg = pACB->pmuE; - in_doorbell =readl (®->iobound_doorbell); +if (pACB->adapter_type ==ACB_ADAPTER_TYPE_F ) { +for (i =0 ; i <5 ; i++) { + in_doorbell =readl (®->iobound_doorbell); +if (in_doorbell !=0 ) +break ; + } + }else + in_doorbell =readl (®->iobound_doorbell); outbound_doorbell = in_doorbell ^ pACB->in_doorbell; do { writel(0, ®->host_int_status); /* clear interrupt */
Signature · 1 line
2.30.2
Greg Kroah-Hartman
maintainerPATCH 57/292 scsi: hisi_sas: Propagate errors in interrupt_init_v1_hw()
In reply to Greg Kroah-HartmanFrom: Sergey Shtylyov <[email protected]>
[ Upstream commit ab17122e758ef68fb21033e25c041144067975f5 ]
After commit 6c11dc060427 ("scsi: hisi_sas: Fix IRQ checks") we have the error codes returned by platform_get_irq() ready for the propagation upsream in interrupt_init_v1_hw() -- that will fix still broken deferred probing. Let's propagate the error codes from devm_request_irq() as well since I don't see the reason to override them with -ENOENT...
--- drivers/scsi/hisi_sas/hisi_sas_v1_hw.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)
drivers/scsi/hisi_sas/hisi_sas_v1_hw.c +6 -6
@@ -1649,7 +1649,7 @@ static int interrupt_init_v1_hw(struct hisi_hba *hisi_hba)if (irq <0 ) {dev_err (dev,"irq init: fail map phy interrupt %d\n" , idx); -return -ENOENT ; +return irq; } rc = devm_request_irq(dev, irq, phy_interrupts[j], 0,
@@ -1657,7 +1657,7 @@ static int interrupt_init_v1_hw(struct hisi_hba *hisi_hba)if (rc) {dev_err (dev,"irq init: could not request phy interrupt %d, rc=%d\n" , irq, rc); -return -ENOENT ; +return rc; } } }
@@ -1668,7 +1668,7 @@ static int interrupt_init_v1_hw(struct hisi_hba *hisi_hba)if (irq <0 ) {dev_err (dev,"irq init: could not map cq interrupt %d\n" , idx); -return -ENOENT ; +return irq; } rc = devm_request_irq(dev, irq, cq_interrupt_v1_hw, 0,
@@ -1676,7 +1676,7 @@ static int interrupt_init_v1_hw(struct hisi_hba *hisi_hba)if (rc) {dev_err (dev,"irq init: could not request cq interrupt %d, rc=%d\n" , irq, rc); -return -ENOENT ; +return rc; } }
@@ -1686,7 +1686,7 @@ static int interrupt_init_v1_hw(struct hisi_hba *hisi_hba)if (irq <0 ) {dev_err (dev,"irq init: could not map fatal interrupt %d\n" , idx); -return -ENOENT ; +return irq; } rc = devm_request_irq(dev, irq, fatal_interrupts[i], 0,
@@ -1694,7 +1694,7 @@ static int interrupt_init_v1_hw(struct hisi_hba *hisi_hba)if (rc) {dev_err (dev,"irq init: could not request fatal interrupt %d, rc=%d\n" , irq, rc); -return -ENOENT ; +return rc; } }
Signature · 1 line
2.30.2
Greg Kroah-Hartman
maintainerPATCH 58/292 scsi: lpfc: Fix "Unexpected timeout" error in direct attach topology
In reply to Greg Kroah-HartmanFrom: James Smart <[email protected]>
[ Upstream commit e30d55137edef47434c40d7570276a0846fe922c ]
An 'unexpected timeout' message may be seen in a point-2-point topology. The message occurs when a PLOGI is received before the driver is notified of FLOGI completion. The FLOGI completion failure causes discovery to be triggered for a second time. The discovery timer is restarted but no new discovery activity is initiated, thus the timeout message eventually appears.
In point-2-point, when discovery has progressed before the FLOGI completion is processed, it is not a failure. Add code to FLOGI completion to detect that discovery has progressed and exit the FLOGI handling (noop'ing it).
--- drivers/scsi/lpfc/lpfc_els.c | 9 +++++++++ 1 file changed, 9 insertions(+)
drivers/scsi/lpfc/lpfc_els.c +9 -0
@@ -1175,6 +1175,15 @@ stop_rr_fcf_flogi: phba->fcf.fcf_redisc_attempted =0 ;/* reset */ goto out; } + }else if (vport->port_state >LPFC_FLOGI && + vport->fc_flag &FC_PT2PT ) { +/* +* In a p2p topology, it is possible that discovery has +* already progressed, and this completion can be ignored. +* Recheck the indicated topology. +*/ +if (!sp->cmn.fPort) + goto out; } flogifail:
Signature · 1 line
2.30.2
Greg Kroah-Hartman
maintainerPATCH 59/292 scsi: lpfc: Fix crash when lpfc_sli4_hba_setup() fails to initialize the SGLs
In reply to Greg Kroah-HartmanFrom: James Smart <[email protected]>
[ Upstream commit 5aa615d195f1e142c662cb2253f057c9baec7531 ]
The driver is encountering a crash in lpfc_free_iocb_list() while performing initial attachment.
Code review found this to be an errant failure path that was taken, jumping to a tag that then referenced structures that were uninitialized.
Fix the failure path.
--- drivers/scsi/lpfc/lpfc_sli.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/scsi/lpfc/lpfc_sli.c +3 -2
@@ -7962,7 +7962,7 @@ lpfc_sli4_hba_setup(struct lpfc_hba *phba)"0393 Error %d during rpi post operation\n" , rc); rc = -ENODEV ; - goto out_destroy_queue; + goto out_free_iocblist; }lpfc_sli4_node_prep (phba);
@@ -8128,8 +8128,9 @@ out_io_buff_free: out_unset_queue:/* Unset all the queues set up in this routine when error out */ lpfc_sli4_queue_unset (phba); -out_destroy_queue: +out_free_iocblist:lpfc_free_iocb_list (phba); +out_destroy_queue:lpfc_sli4_queue_destroy (phba); out_stop_timers:lpfc_stop_hba_timers (phba);
Signature · 1 line
2.30.2
Greg Kroah-Hartman
maintainerPATCH 60/292 scsi: core: Cap scsi_host cmd_per_lun at can_queue
In reply to Greg Kroah-HartmanFrom: John Garry <[email protected]>
[ Upstream commit ea2f0f77538c50739b9fb4de4700cee5535e1f77 ]
The sysfs handling function sdev_store_queue_depth() enforces that the sdev queue depth cannot exceed shost can_queue. The initial sdev queue depth comes from shost cmd_per_lun. However, the LLDD may manually set cmd_per_lun to be larger than can_queue, which leads to an initial sdev queue depth greater than can_queue.
Such an issue was reported in [0], which caused a hang. That has since been fixed in commit fc09acb7de31 ("scsi: scsi_debug: Fix cmd_per_lun, set to max_queue").
Stop this possibly happening for other drivers by capping shost cmd_per_lun at shost can_queue.
[0] https://lore.kernel.org/linux-scsi/YHaez6iN2HHYxYOh@T590/
--- drivers/scsi/hosts.c | 3 +++ 1 file changed, 3 insertions(+)
drivers/scsi/hosts.c +3 -0
@@ -220,6 +220,9 @@ int scsi_add_host_with_dma(struct Scsi_Host *shost, struct device *dev, goto fail; } + shost->cmd_per_lun =min_t (short, shost->cmd_per_lun, + shost->can_queue); + error =scsi_init_sense_cache (shost);if (error) goto fail;
Signature · 1 line
2.30.2
Greg Kroah-Hartman
maintainerPATCH 61/292 ALSA: ac97: fix PM reference leak in ac97_bus_remove()
In reply to Greg Kroah-HartmanFrom: Yufen Yu <[email protected]>
[ Upstream commit a38e93302ee25b2ca6f4ee76c6c974cf3637985e ]
pm_runtime_get_sync will increment pm usage counter even it failed. Forgetting to putting operation will result in reference leak here. Fix it by replacing it with pm_runtime_resume_and_get to keep usage counter balanced.
--- sound/ac97/bus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
sound/ac97/bus.c +1 -1
@@ -520,7 +520,7 @@ static int ac97_bus_remove(struct device *dev)struct ac97_codec_driver *adrv =to_ac97_driver (dev->driver);int ret; - ret =pm_runtime_get_sync (dev); + ret =pm_runtime_resume_and_get (dev);if (ret <0 )return ret;
Signature · 1 line
2.30.2
Greg Kroah-Hartman
maintainerPATCH 62/292 tty: serial: 8250: serial_cs: Fix a memory leak in error handling path
In reply to Greg Kroah-HartmanFrom: Christophe JAILLET <[email protected]>
[ Upstream commit fad92b11047a748c996ebd6cfb164a63814eeb2e ]
In the probe function, if the final 'serial_config()' fails, 'info' is leaking.
Add a resource handling path to free this memory.
--- drivers/tty/serial/8250/serial_cs.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-)
drivers/tty/serial/8250/serial_cs.c +10 -1
@@ -306,6 +306,7 @@ static int serial_resume(struct pcmcia_device *link)static int serial_probe (struct pcmcia_device *link) {struct serial_info *info; +int ret;dev_dbg (&link->dev,"serial_attach()\n" );
@@ -320,7 +321,15 @@ static int serial_probe(struct pcmcia_device *link)if (do_sound) link->config_flags |=CONF_ENABLE_SPKR ; -return serial_config (link); + ret =serial_config (link); +if (ret) + goto free_info; + +return 0 ; + +free_info: +kfree (info); +return ret; }static void serial_detach (struct pcmcia_device *link)
Signature · 1 line
2.30.2
Greg Kroah-Hartman
maintainerPATCH 63/292 scsi: mpt3sas: Fix deadlock while cancelling the running firmware event
In reply to Greg Kroah-HartmanFrom: Suganath Prabu S <[email protected]>
[ Upstream commit e2fac6c44ae06e58ac02181b048af31195883c31 ]
Do not cancel current running firmware event work if the event type is different from MPT3SAS_REMOVE_UNRESPONDING_DEVICES. Otherwise a deadlock can be observed while cancelling the current firmware event work if a hard reset operation is called as part of processing the current event.
--- drivers/scsi/mpt3sas/mpt3sas_scsih.c | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+)
drivers/scsi/mpt3sas/mpt3sas_scsih.c +22 -0
@@ -3696,6 +3696,28 @@ _scsih_fw_event_cleanup_queue(struct MPT3SAS_ADAPTER *ioc) ioc->fw_events_cleanup =1 ;while ((fw_event =dequeue_next_fw_event (ioc)) || (fw_event = ioc->current_event)) { + +/* +* Don't call cancel_work_sync() for current_event +* other than MPT3SAS_REMOVE_UNRESPONDING_DEVICES; +* otherwise we may observe deadlock if current +* hard reset issued as part of processing the current_event. +* +* Orginal logic of cleaning the current_event is added +* for handling the back to back host reset issued by the user. +* i.e. during back to back host reset, driver use to process +* the two instances of MPT3SAS_REMOVE_UNRESPONDING_DEVICES +* event back to back and this made the drives to unregister +* the devices from SML. +*/ + +if (fw_event == ioc->current_event && + ioc->current_event->event != +MPT3SAS_REMOVE_UNRESPONDING_DEVICES ) { + ioc->current_event =NULL ; +continue ; + } +/* * Wait on the fw_event to complete. If this returns 1, then * the event was never executed, and we need a put for the
Signature · 1 line
2.30.2
Greg Kroah-Hartman
maintainerPATCH 64/292 scsi: core: Fixup calling convention for scsi_mode_sense()
In reply to Greg Kroah-HartmanFrom: Hannes Reinecke <[email protected]>
[ Upstream commit 8793613de913e03e7c884f4cc56e350bc716431e ]
The description for scsi_mode_sense() claims to return the number of valid bytes on success, which is not what the code does. Additionally there is no gain in returning the SCSI status, as everything the callers do is to check against scsi_result_is_good(), which is what scsi_mode_sense() does already. So change the calling convention to return a standard error code on failure, and 0 on success, and adapt the description and all callers.
--- drivers/scsi/scsi_lib.c | 10 ++++++---- drivers/scsi/scsi_transport_sas.c | 9 ++++----- drivers/scsi/sd.c | 12 ++++++------ drivers/scsi/sr.c | 2 +- 4 files changed, 17 insertions(+), 16 deletions(-)
drivers/scsi/scsi_lib.c +6 -4
@@ -2081,9 +2081,7 @@ EXPORT_SYMBOL_GPL(scsi_mode_select);* @sshdr: place to put sense data (or NULL if no sense to be collected). * must be SCSI_SENSE_BUFFERSIZE big. * -* Returns zero if unsuccessful, or the header offset (either 4 -* or 8 depending on whether a six or ten byte command was -* issued) if successful. +* Returns zero if successful, or a negative error number on failure */ int scsi_mode_sense(struct scsi_device *sdev, int dbd, int modepage,
@@ -2130,6 +2128,8 @@ scsi_mode_sense(struct scsi_device *sdev, int dbd, int modepage, result =scsi_execute_req (sdev, cmd,DMA_FROM_DEVICE , buffer, len, sshdr, timeout, retries,NULL ); +if (result <0 ) +return result;/* This code looks awful: what it's doing is making sure an * ILLEGAL REQUEST sense return identifies the actual command
@@ -2174,13 +2174,15 @@ scsi_mode_sense(struct scsi_device *sdev, int dbd, int modepage, data->block_descriptor_length = buffer[3 ]; } data->header_length = header_length; + result =0 ; }else if ((status_byte (result) ==CHECK_CONDITION ) &&scsi_sense_valid (sshdr) && sshdr->sense_key ==UNIT_ATTENTION && retry_count) { retry_count--; goto retry; } - +if (result >0 ) + result = -EIO ;return result; }EXPORT_SYMBOL (scsi_mode_sense);
drivers/scsi/scsi_transport_sas.c +4 -5
@@ -1229,16 +1229,15 @@ int sas_read_port_mode_page(struct scsi_device *sdev)char *buffer =kzalloc (BUF_SIZE ,GFP_KERNEL ), *msdata;struct sas_end_device *rdev =sas_sdev_to_rdev (sdev);struct scsi_mode_data mode_data; -int res, error; +int error;if (!buffer)return -ENOMEM ; - res =scsi_mode_sense (sdev,1 ,0x19 , buffer,BUF_SIZE ,30 *HZ ,3 , - &mode_data,NULL ); + error =scsi_mode_sense (sdev,1 ,0x19 , buffer,BUF_SIZE ,30 *HZ ,3 , + &mode_data,NULL ); - error = -EINVAL ; -if (!scsi_status_is_good (res)) +if (error) goto out; msdata = buffer + mode_data.header_length +
drivers/scsi/sd.c +6 -6
@@ -2683,18 +2683,18 @@ sd_read_write_protect_flag(struct scsi_disk *sdkp, unsigned char *buffer)* 5: Illegal Request, Sense Code 24: Invalid field in * CDB. */ -if (!scsi_status_is_good (res)) +if (res <0 ) res =sd_do_mode_sense (sdkp,0 ,0 , buffer,4 , &data,NULL );/* * Third attempt: ask 255 bytes, as we did earlier. */ -if (!scsi_status_is_good (res)) +if (res <0 ) res =sd_do_mode_sense (sdkp,0 ,0x3F , buffer,255 , &data,NULL ); } -if (!scsi_status_is_good (res)) { +if (res <0 ) {sd_first_printk (KERN_WARNING , sdkp,"Test WP failed, assume Write Enabled\n" ); }else {
@@ -2755,7 +2755,7 @@ sd_read_cache_type(struct scsi_disk *sdkp, unsigned char *buffer) res =sd_do_mode_sense (sdkp, dbd, modepage, buffer, first_len, &data, &sshdr); -if (!scsi_status_is_good (res)) +if (res <0 ) goto bad_sense;if (!data.header_length) {
@@ -2787,7 +2787,7 @@ sd_read_cache_type(struct scsi_disk *sdkp, unsigned char *buffer) res =sd_do_mode_sense (sdkp, dbd, modepage, buffer, len, &data, &sshdr); -if (scsi_status_is_good (res)) { +if (!res) {int offset = data.header_length + data.block_descriptor_length;while (offset < len) {
@@ -2905,7 +2905,7 @@ static void sd_read_app_tag_own(struct scsi_disk *sdkp, unsigned char *buffer) res =scsi_mode_sense (sdp,1 ,0x0a , buffer,36 ,SD_TIMEOUT , sdkp->max_retries, &data, &sshdr); -if (!scsi_status_is_good (res) || !data.header_length || +if (res <0 || !data.header_length || data.length <6 ) {sd_first_printk (KERN_WARNING , sdkp,"getting Control mode page failed, assume no ATO\n" );
drivers/scsi/sr.c +1 -1
@@ -913,7 +913,7 @@ static void get_capabilities(struct scsi_cd *cd) rc =scsi_mode_sense (cd->device,0 ,0x2a , buffer, ms_len,SR_TIMEOUT ,3 , &data,NULL ); -if (!scsi_status_is_good (rc) || data.length > ms_len || +if (rc <0 || data.length > ms_len || data.header_length + data.block_descriptor_length > data.length) {/* failed, drive doesn't have capabilities mode page */ cd->cdi.speed =1 ;
Signature · 1 line
2.30.2
Greg Kroah-Hartman
maintainerPATCH 65/292 scsi: scsi_dh_alua: Check for negative result value
In reply to Greg Kroah-HartmanFrom: Hannes Reinecke <[email protected]>
[ Upstream commit 7e26e3ea028740f934477ec01ba586ab033c35aa ]
scsi_execute() will now return a negative error if there was an error prior to command submission; evaluate that instead if checking for DRIVER_ERROR.
[mkp: build fix]
--- drivers/scsi/device_handler/scsi_dh_alua.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/scsi/device_handler/scsi_dh_alua.c +4 -4
@@ -556,12 +556,12 @@ static int alua_rtpg(struct scsi_device *sdev, struct alua_port_group *pg)kfree (buff);return SCSI_DH_OK ; } -if (!scsi_sense_valid (&sense_hdr)) { +if (retval <0 || !scsi_sense_valid (&sense_hdr)) {sdev_printk (KERN_INFO , sdev,"%s: rtpg failed, result %d\n" ,ALUA_DH_NAME , retval);kfree (buff); -if (driver_byte (retval) ==DRIVER_ERROR ) +if (retval <0 )return SCSI_DH_DEV_TEMP_BUSY ;return SCSI_DH_IO ; }
@@ -783,11 +783,11 @@ static unsigned alua_stpg(struct scsi_device *sdev, struct alua_port_group *pg) retval =submit_stpg (sdev, pg->group_id, &sense_hdr);if (retval) { -if (!scsi_sense_valid (&sense_hdr)) { +if (retval <0 || !scsi_sense_valid (&sense_hdr)) {sdev_printk (KERN_INFO , sdev,"%s: stpg failed, result %d" ,ALUA_DH_NAME , retval); -if (driver_byte (retval) ==DRIVER_ERROR ) +if (retval <0 )return SCSI_DH_DEV_TEMP_BUSY ; }else { sdev_printk(KERN_INFO, sdev, "%s: stpg failed\n",
Signature · 1 line
2.30.2
Greg Kroah-Hartman
maintainerPATCH 66/292 fs/jfs: Fix missing error code in lmLogInit()
In reply to Greg Kroah-HartmanFrom: Jiapeng Chong <[email protected]>
[ Upstream commit 492109333c29e1bb16d8732e1d597b02e8e0bf2e ]
The error code is missing in this code scenario, add the error code '-EINVAL' to the return value 'rc.
Eliminate the follow smatch warning:
fs/jfs/jfs_logmgr.c:1327 lmLogInit() warn: missing error code 'rc'.
--- fs/jfs/jfs_logmgr.c | 1 + 1 file changed, 1 insertion(+)
fs/jfs/jfs_logmgr.c +1 -0
@@ -1324,6 +1324,7 @@ int lmLogInit(struct jfs_log * log) }else {if (!uuid_equal (&logsuper->uuid, &log->uuid)) {jfs_warn ("wrong uuid on JFS log device" ); + rc = -EINVAL ; goto errout20; } log->size =le32_to_cpu (logsuper->size);
Signature · 1 line
2.30.2
Greg Kroah-Hartman
maintainerPATCH 67/292 scsi: megaraid_sas: Fix resource leak in case of probe failure
In reply to Greg Kroah-HartmanFrom: Chandrakanth Patil <[email protected]>
[ Upstream commit b5438f48fdd8e1c3f130d32637511efd32038152 ]
The driver doesn't clean up all the allocated resources properly when scsi_add_host(), megasas_start_aen() function fails during the PCI device probe.
Clean up all those resources.
--- drivers/scsi/megaraid/megaraid_sas_base.c | 13 +++++++++++++ drivers/scsi/megaraid/megaraid_sas_fusion.c | 1 + 2 files changed, 14 insertions(+)
drivers/scsi/megaraid/megaraid_sas_base.c +13 -0
@@ -7478,11 +7478,16 @@ static int megasas_probe_one(struct pci_dev *pdev,return 0 ; fail_start_aen: + instance->unload =1 ; +scsi_remove_host (instance->host); fail_io_attach: megasas_mgmt_info.count--; megasas_mgmt_info.max_index--; megasas_mgmt_info.instance[megasas_mgmt_info.max_index] =NULL ; +if (instance->requestorId && !instance->skip_heartbeat_timer_del) +del_timer_sync (&instance->sriov_heartbeat_timer); + instance->instancet->disable_intr (instance);megasas_destroy_irqs (instance);
@@ -7490,8 +7495,16 @@ fail_io_attach:megasas_release_fusion (instance); elsemegasas_release_mfi (instance ); +if (instance->msix_vectors)pci_free_irq_vectors (instance->pdev); + instance->msix_vectors =0 ; + +if (instance->fw_crash_state !=UNAVAILABLE ) +megasas_free_host_crash_buffer (instance); + +if (instance->adapter_type !=MFI_SERIES ) +megasas_fusion_stop_watchdog (instance); fail_init_mfi:scsi_host_put (host); fail_alloc_instance:
drivers/scsi/megaraid/megaraid_sas_fusion.c +1 -0
@@ -5201,6 +5201,7 @@ megasas_alloc_fusion_context(struct megasas_instance *instance)if (!fusion->log_to_span) {dev_err (&instance->pdev->dev,"Failed from %s %d\n" , __func__, __LINE__); +kfree (instance->ctrl_context);return -ENOMEM ; } }
Signature · 1 line
2.30.2
Greg Kroah-Hartman
maintainerPATCH 68/292 scsi: megaraid_sas: Early detection of VD deletion through RaidMap update
In reply to Greg Kroah-HartmanFrom: Kashyap Desai <[email protected]>
[ Upstream commit ae6874ba4b43c5a00065f48599811a09d33b873d ]
Consider the case where a VD is deleted and the targetID of that VD is assigned to a newly created VD. If the sequence of deletion/addition of VD happens very quickly there is a possibility that second event (VD add) occurs even before the driver processes the first event (VD delete). As event processing is done in deferred context the device list remains the same (but targetID is re-used) so driver will not learn the VD deletion/additon. I/Os meant for the older VD will be directed to new VD which may lead to data corruption.
Make driver detect the deleted VD as soon as possible based on the RaidMap update and block further I/O to that device.
--- drivers/scsi/megaraid/megaraid_sas.h | 12 ++++ drivers/scsi/megaraid/megaraid_sas_base.c | 83 ++++++++++++++++++++--- drivers/scsi/megaraid/megaraid_sas_fp.c | 6 +- 3 files changed, 92 insertions(+), 9 deletions(-)
drivers/scsi/megaraid/megaraid_sas.h +12 -0
@@ -2259,6 +2259,15 @@ enum MR_PERF_MODE { (mode) == MR_LATENCY_PERF_MODE ? "Latency" : \ "Unknown") +enum MEGASAS_LD_TARGET_ID_STATUS { +LD_TARGET_ID_INITIAL , +LD_TARGET_ID_ACTIVE , +LD_TARGET_ID_DELETED , +}; + +#define MEGASAS_TARGET_ID (sdev) \ + (((sdev->channel % 2) * MEGASAS_MAX_DEV_PER_CHANNEL) + sdev->id) +struct megasas_instance {unsigned int *reply_map;
@@ -2323,6 +2332,9 @@ struct megasas_instance {struct megasas_pd_list pd_list[MEGASAS_MAX_PD ];struct megasas_pd_list local_pd_list[MEGASAS_MAX_PD ];u8 ld_ids[MEGASAS_MAX_LD_IDS ]; +u8 ld_tgtid_status[MEGASAS_MAX_LD_IDS ]; +u8 ld_ids_prev[MEGASAS_MAX_LD_IDS ]; +u8 ld_ids_from_raidmap[MEGASAS_MAX_LD_IDS ];s8 init_id;u16 max_num_sge;
drivers/scsi/megaraid/megaraid_sas_base.c +75 -8
164 lines not on this page · raw message
drivers/scsi/megaraid/megaraid_sas_fp.c +5 -1
@@ -349,6 +349,10 @@ u8 MR_ValidateMapInfo(struct megasas_instance *instance, u64 map_id) num_lds =le16_to_cpu (drv_map->raidMap.ldCount); +memcpy (instance->ld_ids_prev, + instance->ld_ids_from_raidmap, +sizeof (instance->ld_ids_from_raidmap)); +memset (instance->ld_ids_from_raidmap,0xff ,MEGASAS_MAX_LD_IDS );/*Convert Raid capability values to CPU arch */ for (i =0 ; (num_lds >0 ) && (i <MAX_LOGICAL_DRIVES_EXT ); i++) { ld =MR_TargetIdToLdGet (i, drv_map);
@@ -359,7 +363,7 @@ u8 MR_ValidateMapInfo(struct megasas_instance *instance, u64 map_id) raid =MR_LdRaidGet (ld, drv_map);le32_to_cpus ((u32 *)&raid->capability); - + instance->ld_ids_from_raidmap[i] = i; num_lds--; }
Signature · 1 line
2.30.2
Greg Kroah-Hartman
maintainerPATCH 69/292 scsi: megaraid_sas: Handle missing interrupts while re-enabling IRQs
In reply to Greg Kroah-HartmanFrom: Chandrakanth Patil <[email protected]>
[ Upstream commit 9bedd36e9146b34dda4d6994e3aa1d72bc6442c1 ]
While reenabling the IRQ after IRQ poll there may be a small window for the firmware to post the replies with interrupts raised. In that case the driver will not see the interrupts which leads to I/O timeout.
This issue only happens when there are many I/O completions on a single reply queue. This forces the driver to switch between the interrupt and IRQ context.
Make the driver process the reply queue one more time after enabling the IRQ.
--- drivers/scsi/megaraid/megaraid_sas_fusion.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-)
drivers/scsi/megaraid/megaraid_sas_fusion.c +7 -2
@@ -3676,6 +3676,7 @@ static void megasas_sync_irqs(unsigned long instance_addr)if (irq_ctx->irq_poll_scheduled) { irq_ctx->irq_poll_scheduled = false;enable_irq (irq_ctx->os_irq); +complete_cmd_fusion (instance, irq_ctx->MSIxIndex, irq_ctx); } } }
@@ -3707,6 +3708,7 @@ int megasas_irqpoll(struct irq_poll *irqpoll, int budget)irq_poll_complete (irqpoll); irq_ctx->irq_poll_scheduled = false;enable_irq (irq_ctx->os_irq); +complete_cmd_fusion (instance, irq_ctx->MSIxIndex, irq_ctx); }return num_entries;
@@ -3723,6 +3725,7 @@ megasas_complete_cmd_dpc_fusion(unsigned long instance_addr) {struct megasas_instance *instance = (struct megasas_instance *)instance_addr; +struct megasas_irq_context *irq_ctx =NULL ;u32 count, MSIxIndex; count = instance->msix_vectors >0 ? instance->msix_vectors :1 ;
@@ -3731,8 +3734,10 @@ megasas_complete_cmd_dpc_fusion(unsigned long instance_addr)if (atomic_read (&instance->adprecovery) ==MEGASAS_HW_CRITICAL_ERROR )return ; -for (MSIxIndex =0 ; MSIxIndex < count; MSIxIndex++) -complete_cmd_fusion (instance, MSIxIndex,NULL ); +for (MSIxIndex =0 ; MSIxIndex < count; MSIxIndex++) { + irq_ctx = &instance->irq_context[MSIxIndex]; +complete_cmd_fusion (instance, MSIxIndex, irq_ctx); + } }/**
Signature · 1 line
2.30.2
Greg Kroah-Hartman
maintainerPATCH 70/292 scsi: iscsi: Add iscsi_cls_conn refcount helpers
In reply to Greg Kroah-HartmanFrom: Mike Christie <[email protected]>
[ Upstream commit b1d19e8c92cfb0ded180ef3376c20e130414e067 ]
There are a couple places where we could free the iscsi_cls_conn while it's still in use. This adds some helpers to get/put a refcount on the struct and converts an exiting user. Subsequent commits will then use the helpers to fix 2 bugs in the eh code.
--- drivers/scsi/libiscsi.c | 7 ++----- drivers/scsi/scsi_transport_iscsi.c | 12 ++++++++++++ include/scsi/scsi_transport_iscsi.h | 2 ++ 3 files changed, 16 insertions(+), 5 deletions(-)
drivers/scsi/libiscsi.c +2 -5
@@ -1361,7 +1361,6 @@ void iscsi_session_failure(struct iscsi_session *session, enum iscsi_err err) {struct iscsi_conn *conn; -struct device *dev;spin_lock_bh (&session->frwd_lock); conn = session->leadconn;
@@ -1370,10 +1369,8 @@ void iscsi_session_failure(struct iscsi_session *session,return ; } - dev =get_device (&conn->cls_conn->dev); +iscsi_get_conn (conn->cls_conn);spin_unlock_bh (&session->frwd_lock); -if (!dev) -return ;/* * if the host is being removed bypass the connection * recovery initialization because we are going to kill
@@ -1383,7 +1380,7 @@ void iscsi_session_failure(struct iscsi_session *session,iscsi_conn_error_event (conn->cls_conn, err); elseiscsi_conn_failure (conn ,err ); -put_device (dev); +iscsi_put_conn (conn->cls_conn); }EXPORT_SYMBOL_GPL (iscsi_session_failure);
drivers/scsi/scsi_transport_iscsi.c +12 -0
@@ -2459,6 +2459,18 @@ int iscsi_destroy_conn(struct iscsi_cls_conn *conn) }EXPORT_SYMBOL_GPL (iscsi_destroy_conn); +void iscsi_put_conn (struct iscsi_cls_conn *conn) +{ +put_device (&conn->dev); +} +EXPORT_SYMBOL_GPL (iscsi_put_conn); + +void iscsi_get_conn (struct iscsi_cls_conn *conn) +{ +get_device (&conn->dev); +} +EXPORT_SYMBOL_GPL (iscsi_get_conn); +/* * iscsi interface functions */
include/scsi/scsi_transport_iscsi.h +2 -0
@@ -443,6 +443,8 @@ extern void iscsi_remove_session(struct iscsi_cls_session *session);extern void iscsi_free_session (struct iscsi_cls_session *session);extern struct iscsi_cls_conn *iscsi_create_conn (struct iscsi_cls_session *sess,int dd_size,uint32_t cid); +extern void iscsi_put_conn (struct iscsi_cls_conn *conn); +extern void iscsi_get_conn (struct iscsi_cls_conn *conn);extern int iscsi_destroy_conn (struct iscsi_cls_conn *conn);extern void iscsi_unblock_session (struct iscsi_cls_session *session);extern void iscsi_block_session (struct iscsi_cls_session *session);
Signature · 1 line
2.30.2
Greg Kroah-Hartman
maintainerPATCH 71/292 scsi: iscsi: Fix conn use after free during resets
In reply to Greg Kroah-HartmanFrom: Mike Christie <[email protected]>
[ Upstream commit ec29d0ac29be366450a7faffbcf8cba3a6a3b506 ]
If we haven't done a unbind target call we can race where iscsi_conn_teardown wakes up the EH thread and then frees the conn while those threads are still accessing the conn ehwait.
We can only do one TMF per session so this just moves the TMF fields from the conn to the session. We can then rely on the iscsi_session_teardown->iscsi_remove_session->__iscsi_unbind_session call to remove the target and it's devices, and know after that point there is no device or scsi-ml callout trying to access the session.
--- drivers/scsi/libiscsi.c | 115 +++++++++++++++++++--------------------- include/scsi/libiscsi.h | 11 ++-- 2 files changed, 60 insertions(+), 66 deletions(-)
drivers/scsi/libiscsi.c +55 -60
@@ -230,11 +230,11 @@ static int iscsi_prep_ecdb_ahs(struct iscsi_task *task)*/ static int iscsi_check_tmf_restrictions (struct iscsi_task *task,int opcode) { -struct iscsi_conn *conn = task->conn; -struct iscsi_tm *tmf = &conn->tmhdr; +struct iscsi_session *session = task->conn->session; +struct iscsi_tm *tmf = &session->tmhdr;u64 hdr_lun; -if (conn->tmf_state ==TMF_INITIAL ) +if (session->tmf_state ==TMF_INITIAL )return 0 ;if ((tmf->opcode &ISCSI_OPCODE_MASK ) !=ISCSI_OP_SCSI_TMFUNC )
@@ -254,24 +254,19 @@ static int iscsi_check_tmf_restrictions(struct iscsi_task *task, int opcode)* Fail all SCSI cmd PDUs */ if (opcode !=ISCSI_OP_SCSI_DATA_OUT ) { -iscsi_conn_printk (KERN_INFO , conn, -"task [op %x itt " -"0x%x/0x%x] " -"rejected.\n" , - opcode, task->itt, - task->hdr_itt); +iscsi_session_printk (KERN_INFO , session, +"task [op %x itt 0x%x/0x%x] rejected.\n" , + opcode, task->itt, task->hdr_itt);return -EACCES ; }/* * And also all data-out PDUs in response to R2T * if fast_abort is set. */ -if (conn->session->fast_abort) { -iscsi_conn_printk (KERN_INFO , conn, -"task [op %x itt " -"0x%x/0x%x] fast abort.\n" , - opcode, task->itt, - task->hdr_itt); +if (session->fast_abort) { +iscsi_session_printk (KERN_INFO , session, +"task [op %x itt 0x%x/0x%x] fast abort.\n" , + opcode, task->itt, task->hdr_itt);return -EACCES ; }break ;
@@ -284,7 +279,7 @@ static int iscsi_check_tmf_restrictions(struct iscsi_task *task, int opcode)*/ if (opcode ==ISCSI_OP_SCSI_DATA_OUT && task->hdr_itt == tmf->rtt) { - ISCSI_DBG_SESSION(conn->session, + ISCSI_DBG_SESSION(session, "Preventing task %x/%x from sending " "data-out due to abort task in " "progress\n", task->itt,
@@ -936,20 +931,21 @@ iscsi_data_in_rsp(struct iscsi_conn *conn, struct iscsi_hdr *hdr,static void iscsi_tmf_rsp (struct iscsi_conn *conn,struct iscsi_hdr *hdr) {struct iscsi_tm_rsp *tmf = (struct iscsi_tm_rsp *)hdr; +struct iscsi_session *session = conn->session; conn->exp_statsn =be32_to_cpu (hdr->statsn) +1 ; conn->tmfrsp_pdus_cnt++; -if (conn->tmf_state !=TMF_QUEUED ) +if (session->tmf_state !=TMF_QUEUED )return ;if (tmf->response ==ISCSI_TMF_RSP_COMPLETE ) - conn->tmf_state =TMF_SUCCESS ; + session->tmf_state =TMF_SUCCESS ;else if (tmf->response ==ISCSI_TMF_RSP_NO_TASK ) - conn->tmf_state =TMF_NOT_FOUND ; + session->tmf_state =TMF_NOT_FOUND ;else - conn->tmf_state =TMF_FAILED ; -wake_up (&conn->ehwait); + session->tmf_state =TMF_FAILED ; +wake_up (&session->ehwait); }static int iscsi_send_nopout (struct iscsi_conn *conn,struct iscsi_nopin *rhdr)
@@ -1826,15 +1822,14 @@ EXPORT_SYMBOL_GPL(iscsi_target_alloc);static void iscsi_tmf_timedout (struct timer_list *t) { -struct iscsi_conn *conn =from_timer (conn, t, tmf_timer); -struct iscsi_session *session = conn->session; +struct iscsi_session *session =from_timer (session, t, tmf_timer);spin_lock (&session->frwd_lock); -if (conn->tmf_state ==TMF_QUEUED ) { - conn->tmf_state =TMF_TIMEDOUT ; +if (session->tmf_state ==TMF_QUEUED ) { + session->tmf_state =TMF_TIMEDOUT ;ISCSI_DBG_EH (session,"tmf timedout\n" );/* unblock eh_abort() */ -wake_up (&conn->ehwait); +wake_up (&session->ehwait); }spin_unlock (&session->frwd_lock); }
@@ -1857,8 +1852,8 @@ static int iscsi_exec_task_mgmt_fn(struct iscsi_conn *conn,return -EPERM ; } conn->tmfcmd_pdus_cnt++; - conn->tmf_timer.expires = timeout *HZ + jiffies; -add_timer (&conn->tmf_timer); + session->tmf_timer.expires = timeout *HZ + jiffies; +add_timer (&session->tmf_timer);ISCSI_DBG_EH (session,"tmf set timeout\n" );spin_unlock_bh (&session->frwd_lock);
@@ -1872,12 +1867,12 @@ static int iscsi_exec_task_mgmt_fn(struct iscsi_conn *conn,* 3) session is terminated or restarted or userspace has * given up on recovery */ -wait_event_interruptible (conn->ehwait, age != session->age || +wait_event_interruptible (session->ehwait, age != session->age || session->state !=ISCSI_STATE_LOGGED_IN || - conn->tmf_state !=TMF_QUEUED ); + session->tmf_state !=TMF_QUEUED );if (signal_pending (current))flush_signals (current); -del_timer_sync (&conn->tmf_timer); +del_timer_sync (&session->tmf_timer);mutex_lock (&session->eh_mutex);spin_lock_bh (&session->frwd_lock);
@@ -2309,17 +2304,17 @@ int iscsi_eh_abort(struct scsi_cmnd *sc) }/* only have one tmf outstanding at a time */ -if (conn->tmf_state !=TMF_INITIAL ) +if (session->tmf_state !=TMF_INITIAL ) goto failed; - conn->tmf_state =TMF_QUEUED ; + session->tmf_state =TMF_QUEUED ; - hdr = &conn->tmhdr; + hdr = &session->tmhdr;iscsi_prep_abort_task_pdu (task, hdr);if (iscsi_exec_task_mgmt_fn (conn, hdr, age, session->abort_timeout)) goto failed; -switch (conn->tmf_state) { +switch (session->tmf_state) {case TMF_SUCCESS :spin_unlock_bh (&session->frwd_lock);/*
@@ -2334,7 +2329,7 @@ int iscsi_eh_abort(struct scsi_cmnd *sc)*/ spin_lock_bh (&session->frwd_lock);fail_scsi_task (task,DID_ABORT ); - conn->tmf_state =TMF_INITIAL ; + session->tmf_state =TMF_INITIAL ;memset (hdr,0 ,sizeof (*hdr));spin_unlock_bh (&session->frwd_lock);iscsi_start_tx (conn);
@@ -2345,7 +2340,7 @@ int iscsi_eh_abort(struct scsi_cmnd *sc) goto failed_unlocked;case TMF_NOT_FOUND :if (!sc->SCp.ptr) { - conn->tmf_state =TMF_INITIAL ; + session->tmf_state =TMF_INITIAL ;memset (hdr,0 ,sizeof (*hdr));/* task completed before tmf abort response */ ISCSI_DBG_EH(session, "sc completed while abort in "
@@ -2354,7 +2349,7 @@ int iscsi_eh_abort(struct scsi_cmnd *sc) } fallthrough;default : - conn->tmf_state =TMF_INITIAL ; + session->tmf_state =TMF_INITIAL ; goto failed; }
@@ -2413,11 +2408,11 @@ int iscsi_eh_device_reset(struct scsi_cmnd *sc) conn = session->leadconn;/* only have one tmf outstanding at a time */ -if (conn->tmf_state !=TMF_INITIAL ) +if (session->tmf_state !=TMF_INITIAL ) goto unlock; - conn->tmf_state =TMF_QUEUED ; + session->tmf_state =TMF_QUEUED ; - hdr = &conn->tmhdr; + hdr = &session->tmhdr;iscsi_prep_lun_reset_pdu (sc, hdr); if (iscsi_exec_task_mgmt_fn(conn, hdr, session->age,
@@ -2426,7 +2421,7 @@ int iscsi_eh_device_reset(struct scsi_cmnd *sc) goto unlock; } -switch (conn->tmf_state) { +switch (session->tmf_state) {case TMF_SUCCESS :break ;case TMF_TIMEDOUT :
@@ -2434,7 +2429,7 @@ int iscsi_eh_device_reset(struct scsi_cmnd *sc)iscsi_conn_failure (conn,ISCSI_ERR_SCSI_EH_SESSION_RST ); goto done;default : - conn->tmf_state =TMF_INITIAL ; + session->tmf_state =TMF_INITIAL ; goto unlock; }
@@ -2446,7 +2441,7 @@ int iscsi_eh_device_reset(struct scsi_cmnd *sc)spin_lock_bh (&session->frwd_lock);memset (hdr,0 ,sizeof (*hdr));fail_scsi_tasks (conn, sc->device->lun,DID_ERROR ); - conn->tmf_state =TMF_INITIAL ; + session->tmf_state =TMF_INITIAL ;spin_unlock_bh (&session->frwd_lock);iscsi_start_tx (conn);
@@ -2469,8 +2464,7 @@ void iscsi_session_recovery_timedout(struct iscsi_cls_session *cls_session)spin_lock_bh (&session->frwd_lock);if (session->state !=ISCSI_STATE_LOGGED_IN ) { session->state =ISCSI_STATE_RECOVERY_FAILED ; -if (session->leadconn) -wake_up (&session->leadconn->ehwait); +wake_up (&session->ehwait); }spin_unlock_bh (&session->frwd_lock); }
@@ -2515,7 +2509,7 @@ failed:iscsi_conn_failure (conn,ISCSI_ERR_SCSI_EH_SESSION_RST );ISCSI_DBG_EH (session,"wait for relogin\n" ); -wait_event_interruptible (conn->ehwait, +wait_event_interruptible (session->ehwait, session->state ==ISCSI_STATE_TERMINATE || session->state ==ISCSI_STATE_LOGGED_IN || session->state ==ISCSI_STATE_RECOVERY_FAILED );
@@ -2576,11 +2570,11 @@ static int iscsi_eh_target_reset(struct scsi_cmnd *sc) conn = session->leadconn;/* only have one tmf outstanding at a time */ -if (conn->tmf_state !=TMF_INITIAL ) +if (session->tmf_state !=TMF_INITIAL ) goto unlock; - conn->tmf_state =TMF_QUEUED ; + session->tmf_state =TMF_QUEUED ; - hdr = &conn->tmhdr; + hdr = &session->tmhdr;iscsi_prep_tgt_reset_pdu (sc, hdr); if (iscsi_exec_task_mgmt_fn(conn, hdr, session->age,
@@ -2589,7 +2583,7 @@ static int iscsi_eh_target_reset(struct scsi_cmnd *sc) goto unlock; } -switch (conn->tmf_state) { +switch (session->tmf_state) {case TMF_SUCCESS :break ;case TMF_TIMEDOUT :
@@ -2597,7 +2591,7 @@ static int iscsi_eh_target_reset(struct scsi_cmnd *sc)iscsi_conn_failure (conn,ISCSI_ERR_SCSI_EH_SESSION_RST ); goto done;default : - conn->tmf_state =TMF_INITIAL ; + session->tmf_state =TMF_INITIAL ; goto unlock; }
@@ -2609,7 +2603,7 @@ static int iscsi_eh_target_reset(struct scsi_cmnd *sc)spin_lock_bh (&session->frwd_lock);memset (hdr,0 ,sizeof (*hdr));fail_scsi_tasks (conn,-1 ,DID_ERROR ); - conn->tmf_state =TMF_INITIAL ; + session->tmf_state =TMF_INITIAL ;spin_unlock_bh (&session->frwd_lock);iscsi_start_tx (conn);
@@ -2939,7 +2933,10 @@ iscsi_session_setup(struct iscsi_transport *iscsit, struct Scsi_Host *shost, session->tt = iscsit; session->dd_data = cls_session->dd_data +sizeof (*session); + session->tmf_state =TMF_INITIAL ; +timer_setup (&session->tmf_timer, iscsi_tmf_timedout,0 );mutex_init (&session->eh_mutex); +spin_lock_init (&session->frwd_lock);spin_lock_init (&session->back_lock);
@@ -3043,7 +3040,6 @@ iscsi_conn_setup(struct iscsi_cls_session *cls_session, int dd_size, conn->c_stage =ISCSI_CONN_INITIAL_STAGE ; conn->id = conn_idx; conn->exp_statsn =0 ; - conn->tmf_state =TMF_INITIAL ;timer_setup (&conn->transport_timer, iscsi_check_transport_timeouts,0 );
@@ -3068,8 +3064,7 @@ iscsi_conn_setup(struct iscsi_cls_session *cls_session, int dd_size, goto login_task_data_alloc_fail; conn->login_task->data = conn->data = data; -timer_setup (&conn->tmf_timer, iscsi_tmf_timedout,0 ); -init_waitqueue_head (&conn->ehwait); +init_waitqueue_head (&session->ehwait);return cls_conn;
@@ -3104,7 +3099,7 @@ void iscsi_conn_teardown(struct iscsi_cls_conn *cls_conn)* leading connection? then give up on recovery. */ session->state =ISCSI_STATE_TERMINATE ; -wake_up (&conn->ehwait); +wake_up (&session->ehwait); }spin_unlock_bh (&session->frwd_lock);
@@ -3179,7 +3174,7 @@ int iscsi_conn_start(struct iscsi_cls_conn *cls_conn)* commands after successful recovery */ conn->stop_stage =0 ; - conn->tmf_state =TMF_INITIAL ; + session->tmf_state =TMF_INITIAL ; session->age++;if (session->age ==16 ) session->age =0 ;
@@ -3193,7 +3188,7 @@ int iscsi_conn_start(struct iscsi_cls_conn *cls_conn)spin_unlock_bh (&session->frwd_lock);iscsi_unblock_session (session->cls_session); -wake_up (&conn->ehwait); +wake_up (&session->ehwait);return 0 ; }EXPORT_SYMBOL_GPL (iscsi_conn_start);
@@ -3287,7 +3282,7 @@ void iscsi_conn_stop(struct iscsi_cls_conn *cls_conn, int flag)spin_lock_bh (&session->frwd_lock);fail_scsi_tasks (conn,-1 ,DID_TRANSPORT_DISRUPTED );fail_mgmt_tasks (session, conn); -memset (&conn->tmhdr,0 ,sizeof (conn->tmhdr)); +memset (&session->tmhdr,0 ,sizeof (session->tmhdr));spin_unlock_bh (&session->frwd_lock);mutex_unlock (&session->eh_mutex); }
include/scsi/libiscsi.h +5 -6
@@ -195,12 +195,6 @@ struct iscsi_conn {unsigned long suspend_tx;/* suspend Tx */ unsigned long suspend_rx;/* suspend Rx */ -/* abort */ -wait_queue_head_t ehwait;/* used in eh_abort() */ -struct iscsi_tm tmhdr; -struct timer_list tmf_timer; -int tmf_state;/* see TMF_INITIAL, etc.*/ -/* negotiated params */ unsigned max_recv_dlength;/* initiator_max_recv_dsl*/ unsigned max_xmit_dlength;/* target_max_recv_dsl */
@@ -270,6 +264,11 @@ struct iscsi_session {* and recv lock. */ struct mutex eh_mutex; +/* abort */ +wait_queue_head_t ehwait;/* used in eh_abort() */ +struct iscsi_tm tmhdr; +struct timer_list tmf_timer; +int tmf_state;/* see TMF_INITIAL, etc.*/ /* iSCSI session-wide sequencing */ uint32_t cmdsn;
Signature · 1 line
2.30.2
Greg Kroah-Hartman
maintainerPATCH 72/292 scsi: iscsi: Fix shost->max_id use
In reply to Greg Kroah-HartmanFrom: Mike Christie <[email protected]>
[ Upstream commit bdd4aad7ff92ae39c2e93c415bb6761cb8b584da ]
The iscsi offload drivers are setting the shost->max_id to the max number of sessions they support. The problem is that max_id is not the max number of targets but the highest identifier the targets can have. To use it to limit the number of targets we need to set it to max sessions - 1, or we can end up with a session we might not have preallocated resources for.
--- drivers/scsi/be2iscsi/be_main.c | 4 ++-- drivers/scsi/bnx2i/bnx2i_iscsi.c | 2 +- drivers/scsi/cxgbi/libcxgbi.c | 4 ++-- drivers/scsi/qedi/qedi_main.c | 2 +- 4 files changed, 6 insertions(+), 6 deletions(-)
drivers/scsi/be2iscsi/be_main.c +2 -2
@@ -416,7 +416,7 @@ static struct beiscsi_hba *beiscsi_hba_alloc(struct pci_dev *pcidev) "beiscsi_hba_alloc - iscsi_host_alloc failed\n");return NULL ; } - shost->max_id =BE2_MAX_SESSIONS ; + shost->max_id =BE2_MAX_SESSIONS -1 ; shost->max_channel =0 ; shost->max_cmd_len =BEISCSI_MAX_CMD_LEN ; shost->max_lun =BEISCSI_NUM_MAX_LUN ;
@@ -5318,7 +5318,7 @@ static int beiscsi_enable_port(struct beiscsi_hba *phba)/* Re-enable UER. If different TPE occurs then it is recoverable. */ beiscsi_set_uer_feature (phba); - phba->shost->max_id = phba->params.cxns_per_ctrl; + phba->shost->max_id = phba->params.cxns_per_ctrl -1 ; phba->shost->can_queue = phba->params.ios_per_ctrl; ret =beiscsi_init_port (phba);if (ret <0 ) {
drivers/scsi/bnx2i/bnx2i_iscsi.c +1 -1
@@ -791,7 +791,7 @@ struct bnx2i_hba *bnx2i_alloc_hba(struct cnic_dev *cnic)return NULL ; shost->dma_boundary = cnic->pcidev->dma_mask; shost->transportt = bnx2i_scsi_xport_template; - shost->max_id =ISCSI_MAX_CONNS_PER_HBA ; + shost->max_id =ISCSI_MAX_CONNS_PER_HBA -1 ; shost->max_channel =0 ; shost->max_lun =512 ; shost->max_cmd_len =16 ;
drivers/scsi/cxgbi/libcxgbi.c +2 -2
@@ -337,7 +337,7 @@ void cxgbi_hbas_remove(struct cxgbi_device *cdev)EXPORT_SYMBOL_GPL (cxgbi_hbas_remove);int cxgbi_hbas_add (struct cxgbi_device *cdev,u64 max_lun, -unsigned int max_id,struct scsi_host_template *sht, +unsigned int max_conns,struct scsi_host_template *sht,struct scsi_transport_template *stt) {struct cxgbi_hba *chba;
@@ -357,7 +357,7 @@ int cxgbi_hbas_add(struct cxgbi_device *cdev, u64 max_lun, shost->transportt = stt; shost->max_lun = max_lun; - shost->max_id = max_id; + shost->max_id = max_conns -1 ; shost->max_channel =0 ; shost->max_cmd_len =SCSI_MAX_VARLEN_CDB_SIZE ;
drivers/scsi/qedi/qedi_main.c +1 -1
@@ -642,7 +642,7 @@ static struct qedi_ctx *qedi_host_alloc(struct pci_dev *pdev) goto exit_setup_shost; } - shost->max_id =QEDI_MAX_ISCSI_CONNS_PER_HBA ; + shost->max_id =QEDI_MAX_ISCSI_CONNS_PER_HBA -1 ; shost->max_channel =0 ; shost->max_lun = ~0 ; shost->max_cmd_len =16 ;
Signature · 1 line
2.30.2
Greg Kroah-Hartman
maintainerPATCH 73/292 scsi: qedi: Fix null ref during abort handling
In reply to Greg Kroah-HartmanFrom: Mike Christie <[email protected]>
[ Upstream commit 5777b7f0f03ce49372203b6521631f62f2810c8f ]
If qedi_process_cmd_cleanup_resp finds the cmd it frees the work and sets list_tmf_work to NULL, so qedi_tmf_work should check if list_tmf_work is non-NULL when it wants to force cleanup.
--- drivers/scsi/qedi/qedi_fw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/scsi/qedi/qedi_fw.c +1 -1
@@ -1453,7 +1453,7 @@ abort_ret: ldel_exit:spin_lock_bh (&qedi_conn->tmf_work_lock); -if (!qedi_cmd->list_tmf_work) { +if (qedi_cmd->list_tmf_work) {list_del_init (&list_work->list); qedi_cmd->list_tmf_work =NULL ;kfree (list_work);
Signature · 1 line
2.30.2
Greg Kroah-Hartman
maintainerPATCH 74/292 scsi: qedi: Fix race during abort timeouts
In reply to Greg Kroah-HartmanFrom: Mike Christie <[email protected]>
[ Upstream commit 2ce002366a3fcc3f9616d4583194f65dde0ad253 ]
If the SCSI cmd completes after qedi_tmf_work calls iscsi_itt_to_task then the qedi qedi_cmd->task_id could be freed and used for another cmd. If we then call qedi_iscsi_cleanup_task with that task_id we will be cleaning up the wrong cmd.
Wait to release the task_id until the last put has been done on the iscsi_task. Because libiscsi grabs a ref to the task when sending the abort, we know that for the non-abort timeout case that the task_id we are referencing is for the cmd that was supposed to be aborted.
A latter commit will fix the case where the abort times out while we are running qedi_tmf_work.
--- drivers/scsi/qedi/qedi_fw.c | 15 --------------- drivers/scsi/qedi/qedi_iscsi.c | 20 +++++++++++++++++--- 2 files changed, 17 insertions(+), 18 deletions(-)
drivers/scsi/qedi/qedi_fw.c +0 -15
@@ -73,7 +73,6 @@ static void qedi_process_logout_resp(struct qedi_ctx *qedi,spin_unlock (&qedi_conn->list_lock); cmd->state =RESPONSE_RECEIVED ; -qedi_clear_task_idx (qedi, cmd->task_id);__iscsi_complete_pdu (conn, (struct iscsi_hdr *)resp_hdr,NULL ,0 );spin_unlock (&session->back_lock);
@@ -138,7 +137,6 @@ static void qedi_process_text_resp(struct qedi_ctx *qedi,spin_unlock (&qedi_conn->list_lock); cmd->state =RESPONSE_RECEIVED ; -qedi_clear_task_idx (qedi, cmd->task_id); __iscsi_complete_pdu(conn, (struct iscsi_hdr *)resp_hdr_ptr, qedi_conn->gen_pdu.resp_buf,
@@ -164,13 +162,11 @@ static void qedi_tmf_resp_work(struct work_struct *work)iscsi_block_session (session->cls_session); rval =qedi_cleanup_all_io (qedi, qedi_conn, qedi_cmd->task, true);if (rval) { -qedi_clear_task_idx (qedi, qedi_cmd->task_id);iscsi_unblock_session (session->cls_session); goto exit_tmf_resp; }iscsi_unblock_session (session->cls_session); -qedi_clear_task_idx (qedi, qedi_cmd->task_id);spin_lock (&session->back_lock);__iscsi_complete_pdu (conn, (struct iscsi_hdr *)resp_hdr_ptr,NULL ,0 );
@@ -245,8 +241,6 @@ static void qedi_process_tmf_resp(struct qedi_ctx *qedi, goto unblock_sess; } -qedi_clear_task_idx (qedi, qedi_cmd->task_id); -__iscsi_complete_pdu (conn, (struct iscsi_hdr *)resp_hdr_ptr,NULL ,0 );kfree (resp_hdr_ptr);
@@ -314,7 +308,6 @@ static void qedi_process_login_resp(struct qedi_ctx *qedi,"Freeing tid=0x%x for cid=0x%x\n" , cmd->task_id, qedi_conn->iscsi_conn_id); cmd->state =RESPONSE_RECEIVED ; -qedi_clear_task_idx (qedi, cmd->task_id); } static void qedi_get_rq_bdq_buf(struct qedi_ctx *qedi,
@@ -468,7 +461,6 @@ static int qedi_process_nopin_mesg(struct qedi_ctx *qedi, }spin_unlock (&qedi_conn->list_lock); -qedi_clear_task_idx (qedi, cmd->task_id); } done:
@@ -673,7 +665,6 @@ static void qedi_scsi_completion(struct qedi_ctx *qedi,if (qedi_io_tracing)qedi_trace_io (qedi, task, cmd->task_id,QEDI_IO_TRACE_RSP ); -qedi_clear_task_idx (qedi, cmd->task_id);__iscsi_complete_pdu (conn, (struct iscsi_hdr *)hdr, conn->data, datalen); error:
@@ -730,7 +721,6 @@ static void qedi_process_nopin_local_cmpl(struct qedi_ctx *qedi, cqe->itid, cmd->task_id); cmd->state =RESPONSE_RECEIVED ; -qedi_clear_task_idx (qedi, cmd->task_id);spin_lock_bh (&session->back_lock);__iscsi_put_task (task);
@@ -748,7 +738,6 @@ static void qedi_process_cmd_cleanup_resp(struct qedi_ctx *qedi,itt_t protoitt =0 ;int found =0 ;struct qedi_cmd *qedi_cmd =NULL ; -u32 rtid =0 ;u32 iscsi_cid;struct qedi_conn *qedi_conn;struct qedi_cmd *dbg_cmd;
@@ -779,7 +768,6 @@ static void qedi_process_cmd_cleanup_resp(struct qedi_ctx *qedi, found =1 ; mtask = qedi_cmd->task; tmf_hdr = (struct iscsi_tm *)mtask->hdr; - rtid = work->rtid;list_del_init (&work->list);kfree (work);
@@ -821,8 +809,6 @@ static void qedi_process_cmd_cleanup_resp(struct qedi_ctx *qedi,if (qedi_cmd->state ==CLEANUP_WAIT_FAILED ) qedi_cmd->state =CLEANUP_RECV ; -qedi_clear_task_idx (qedi_conn->qedi, rtid); -spin_lock (&qedi_conn->list_lock);if (likely (dbg_cmd->io_cmd_in_list)) { dbg_cmd->io_cmd_in_list = false;
@@ -856,7 +842,6 @@ static void qedi_process_cmd_cleanup_resp(struct qedi_ctx *qedi,QEDI_INFO (&qedi->dbg_ctx,QEDI_LOG_TID ,"Freeing tid=0x%x for cid=0x%x\n" , cqe->itid, qedi_conn->iscsi_conn_id); -qedi_clear_task_idx (qedi_conn->qedi, cqe->itid); }else {qedi_get_proto_itt (qedi, cqe->itid, &ptmp_itt);
drivers/scsi/qedi/qedi_iscsi.c +17 -3
@@ -783,7 +783,6 @@ static int qedi_mtask_xmit(struct iscsi_conn *conn, struct iscsi_task *task) } cmd->conn = conn->dd_data; - cmd->scsi_cmd =NULL ;return qedi_iscsi_send_generic_request (task); }
@@ -794,6 +793,10 @@ static int qedi_task_xmit(struct iscsi_task *task)struct qedi_cmd *cmd = task->dd_data;struct scsi_cmnd *sc = task->sc; +/* Clear now so in cleanup_task we know it didn't make it */ + cmd->scsi_cmd =NULL ; + cmd->task_id =U16_MAX ; +if (test_bit (QEDI_IN_SHUTDOWN , &qedi_conn->qedi->flags))return -ENODEV ;
@@ -1394,13 +1397,24 @@ static umode_t qedi_attr_is_visible(int param_type, int param)static void qedi_cleanup_task (struct iscsi_task *task) { -if (!task->sc || task->state ==ISCSI_TASK_PENDING ) { +struct qedi_cmd *cmd; + +if (task->state ==ISCSI_TASK_PENDING ) {QEDI_INFO (NULL ,QEDI_LOG_IO ,"Returning ref_cnt=%d\n" ,refcount_read (&task->refcount));return ; } -qedi_iscsi_unmap_sg_list (task->dd_data); +if (task->sc) +qedi_iscsi_unmap_sg_list (task->dd_data); + + cmd = task->dd_data; +if (cmd->task_id !=U16_MAX ) +qedi_clear_task_idx (iscsi_host_priv (task->conn->session->host), + cmd->task_id); + + cmd->task_id =U16_MAX ; + cmd->scsi_cmd =NULL ; }struct iscsi_transport qedi_iscsi_transport = {
Signature · 1 line
2.30.2
Greg Kroah-Hartman
maintainerPATCH 75/292 scsi: qedi: Fix TMF session block/unblock use
In reply to Greg Kroah-HartmanFrom: Mike Christie <[email protected]>
[ Upstream commit 2819b4ae2873d50fd55292877b0231ec936c3b2e ]
Drivers shouldn't be calling block/unblock session for tmf handling because the functions can change the session state from under libiscsi. iscsi_queuecommand's call to iscsi_prep_scsi_cmd_pdu-> iscsi_check_tmf_restrictions will prevent new cmds from being sent to qedi after we've started handling a TMF. So we don't need to try and block it in the driver, and we can remove these block calls.
--- drivers/scsi/qedi/qedi_fw.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-)
drivers/scsi/qedi/qedi_fw.c +1 -6
@@ -159,14 +159,9 @@ static void qedi_tmf_resp_work(struct work_struct *work)set_bit (QEDI_CONN_FW_CLEANUP , &qedi_conn->flags); resp_hdr_ptr = (struct iscsi_tm_rsp *)qedi_cmd->tmf_resp_buf; -iscsi_block_session (session->cls_session); rval =qedi_cleanup_all_io (qedi, qedi_conn, qedi_cmd->task, true); -if (rval) { -iscsi_unblock_session (session->cls_session); +if (rval) goto exit_tmf_resp; - } - -iscsi_unblock_session (session->cls_session);spin_lock (&session->back_lock);__iscsi_complete_pdu (conn, (struct iscsi_hdr *)resp_hdr_ptr,NULL ,0 );
Signature · 1 line
2.30.2
Greg Kroah-Hartman
maintainerPATCH 76/292 scsi: qedi: Fix cleanup session block/unblock use
In reply to Greg Kroah-HartmanFrom: Mike Christie <[email protected]>
[ Upstream commit 0c72191da68638a479602dd515b587ada913184a ]
Drivers shouldn't be calling block/unblock session for cmd cleanup because the functions can change the session state from under libiscsi. This adds a new a driver level bit so it can block all I/O the host while it drains the card.
--- drivers/scsi/qedi/qedi.h | 1 + drivers/scsi/qedi/qedi_iscsi.c | 17 +++++++++++++++-- 2 files changed, 16 insertions(+), 2 deletions(-)
drivers/scsi/qedi/qedi.h +1 -0
@@ -284,6 +284,7 @@ struct qedi_ctx {#define QEDI_IN_RECOVERY 5#define QEDI_IN_OFFLINE 6#define QEDI_IN_SHUTDOWN 7 +#define QEDI_BLOCK_IO 8u8 mac[ETH_ALEN ];u32 src_ip[4 ];
drivers/scsi/qedi/qedi_iscsi.c +15 -2
@@ -330,12 +330,22 @@ free_conn:void qedi_mark_device_missing (struct iscsi_cls_session *cls_session) { -iscsi_block_session (cls_session); +struct iscsi_session *session = cls_session->dd_data; +struct qedi_conn *qedi_conn = session->leadconn->dd_data; + +spin_lock_bh (&session->frwd_lock); +set_bit (QEDI_BLOCK_IO , &qedi_conn->qedi->flags); +spin_unlock_bh (&session->frwd_lock); }void qedi_mark_device_available (struct iscsi_cls_session *cls_session) { -iscsi_unblock_session (cls_session); +struct iscsi_session *session = cls_session->dd_data; +struct qedi_conn *qedi_conn = session->leadconn->dd_data; + +spin_lock_bh (&session->frwd_lock); +clear_bit (QEDI_BLOCK_IO , &qedi_conn->qedi->flags); +spin_unlock_bh (&session->frwd_lock); } static int qedi_bind_conn_to_iscsi_cid(struct qedi_ctx *qedi,
@@ -800,6 +810,9 @@ static int qedi_task_xmit(struct iscsi_task *task)if (test_bit (QEDI_IN_SHUTDOWN , &qedi_conn->qedi->flags))return -ENODEV ; +if (test_bit (QEDI_BLOCK_IO , &qedi_conn->qedi->flags)) +return -EACCES ; + cmd->state =0 ; cmd->task =NULL ; cmd->use_slowpath = false;
Signature · 1 line
2.30.2
Greg Kroah-Hartman
maintainerPATCH 77/292 mfd: da9052/stmpe: Add and modify MODULE_DEVICE_TABLE
In reply to Greg Kroah-HartmanFrom: Zou Wei <[email protected]>
[ Upstream commit 4700ef326556ed74aba188f12396740a8c1c21dd ]
This patch adds/modifies MODULE_DEVICE_TABLE definition which generates correct modalias for automatic loading of this driver when it is built as an external module.
--- drivers/mfd/da9052-i2c.c | 1 + drivers/mfd/stmpe-i2c.c | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-)
drivers/mfd/da9052-i2c.c +1 -0
@@ -113,6 +113,7 @@ static const struct i2c_device_id da9052_i2c_id[] = { {"da9053-bc", DA9053_BC}, {} }; +MODULE_DEVICE_TABLE (i2c, da9052_i2c_id);#ifdef CONFIG_OF static const struct of_device_id dialog_dt_ids[] = {
drivers/mfd/stmpe-i2c.c +1 -1
@@ -109,7 +109,7 @@ static const struct i2c_device_id stmpe_i2c_id[] = { { "stmpe2403", STMPE2403 }, { } }; -MODULE_DEVICE_TABLE(i2c, stmpe_id); +MODULE_DEVICE_TABLE(i2c, stmpe_i2c_id); static struct i2c_driver stmpe_i2c_driver = { .driver = {
Signature · 1 line
2.30.2
Greg Kroah-Hartman
maintainerPATCH 78/292 mfd: cpcap: Fix cpcap dmamask not set warnings
In reply to Greg Kroah-HartmanFrom: Tony Lindgren <[email protected]>
[ Upstream commit 0b7cbe811ca524295ea43d9a4d73d3427e419c54 ]
We have started to get a bunch of pointless dmamask not set warnings that makes the output of dmesg -l err,warn hard to read with many extra warnings:
cpcap-regulator cpcap-regulator.0: DMA mask not set cpcap_adc cpcap_adc.0: DMA mask not set cpcap_battery cpcap_battery.0: DMA mask not set cpcap-charger cpcap-charger.0: DMA mask not set cpcap-pwrbutton cpcap-pwrbutton.0: DMA mask not set cpcap-led cpcap-led.0: DMA mask not set cpcap-led cpcap-led.1: DMA mask not set cpcap-led cpcap-led.2: DMA mask not set cpcap-led cpcap-led.3: DMA mask not set cpcap-led cpcap-led.4: DMA mask not set cpcap-rtc cpcap-rtc.0: DMA mask not set cpcap-usb-phy cpcap-usb-phy.0: DMA mask not set
This seems to have started with commit 4d8bde883bfb ("OF: Don't set default coherent DMA mask"). We have the parent SPI controller use DMA, while CPCAP driver and it's children do not. For audio, the DMA is handled over I2S bus with the McBSP driver.
--- drivers/mfd/motorola-cpcap.c | 4 ++++ 1 file changed, 4 insertions(+)
drivers/mfd/motorola-cpcap.c +4 -0
@@ -327,6 +327,10 @@ static int cpcap_probe(struct spi_device *spi)if (ret)return ret; +/* Parent SPI controller uses DMA, CPCAP and child devices do not */ + spi->dev.coherent_dma_mask =0 ; + spi->dev.dma_mask = &spi->dev.coherent_dma_mask; +return devm_mfd_add_devices (&spi->dev,0 , cpcap_mfd_devices,ARRAY_SIZE (cpcap_mfd_devices),NULL ,0 ,NULL ); }
Signature · 1 line
2.30.2
Greg Kroah-Hartman
maintainerPATCH 79/292 ASoC: img: Fix PM reference leak in img_i2s_in_probe()
In reply to Greg Kroah-HartmanFrom: Yufen Yu <[email protected]>
[ Upstream commit 81aad47278539f02de808bcc8251fed0ad3d6f55 ]
pm_runtime_get_sync will increment pm usage counter even it failed. Forgetting to putting operation will result in reference leak here. Fix it by replacing it with pm_runtime_resume_and_get to keep usage counter balanced.
--- sound/soc/img/img-i2s-in.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/img/img-i2s-in.c +1 -1
@@ -464,7 +464,7 @@ static int img_i2s_in_probe(struct platform_device *pdev)if (ret) goto err_pm_disable; } - ret =pm_runtime_get_sync (&pdev->dev); + ret =pm_runtime_resume_and_get (&pdev->dev);if (ret <0 ) goto err_suspend;
Signature · 1 line
2.30.2
Greg Kroah-Hartman
maintainerPATCH 80/292 fsi: Add missing MODULE_DEVICE_TABLE
In reply to Greg Kroah-HartmanFrom: Zou Wei <[email protected]>
[ Upstream commit 19a52178125c1e8b84444d85f2ce34c0964b4a91 ]
This patch adds missing MODULE_DEVICE_TABLE definition which generates correct modalias for automatic loading of this driver when it is built as an external module.
--- drivers/fsi/fsi-master-aspeed.c | 1 + drivers/fsi/fsi-master-ast-cf.c | 1 + drivers/fsi/fsi-master-gpio.c | 1 + drivers/fsi/fsi-occ.c | 1 + 4 files changed, 4 insertions(+)
drivers/fsi/fsi-master-aspeed.c +1 -0
@@ -645,6 +645,7 @@ static const struct of_device_id fsi_master_aspeed_match[] = { { .compatible = "aspeed,ast2600-fsi-master" }, { }, }; +MODULE_DEVICE_TABLE (of, fsi_master_aspeed_match);static struct platform_driver fsi_master_aspeed_driver = { .driver = {
drivers/fsi/fsi-master-ast-cf.c +1 -0
@@ -1427,6 +1427,7 @@ static const struct of_device_id fsi_master_acf_match[] = { { .compatible = "aspeed,ast2500-cf-fsi-master" }, { }, }; +MODULE_DEVICE_TABLE (of, fsi_master_acf_match);static struct platform_driver fsi_master_acf = { .driver = {
drivers/fsi/fsi-master-gpio.c +1 -0
@@ -882,6 +882,7 @@ static const struct of_device_id fsi_master_gpio_match[] = { { .compatible = "fsi-master-gpio" }, { }, }; +MODULE_DEVICE_TABLE (of, fsi_master_gpio_match);static struct platform_driver fsi_master_gpio_driver = { .driver = {
drivers/fsi/fsi-occ.c +1 -0
@@ -636,6 +636,7 @@ static const struct of_device_id occ_match[] = { }, { }, }; +MODULE_DEVICE_TABLE (of, occ_match);static struct platform_driver occ_driver = { .driver = {
Signature · 1 line
2.30.2
Greg Kroah-Hartman
maintainerPATCH 81/292 serial: tty: uartlite: fix console setup
In reply to Greg Kroah-HartmanFrom: Daniel Mack <[email protected]>
[ Upstream commit d157fca711ad42e75efef3444c83d2e1a17be27a ]
Remove the hack to assign the global console_port variable at probe time. This assumption that cons->index is -1 is wrong for systems that specify 'console=' in the cmdline (or 'stdout-path' in dts). Hence, on such system the actual console assignment is ignored, and the first UART that happens to be probed is used as console instead.
Move the logic to console_setup() and map the console to the correct port through the array of available ports instead.
--- drivers/tty/serial/uartlite.c | 27 ++++++--------------------- 1 file changed, 6 insertions(+), 21 deletions(-)
drivers/tty/serial/uartlite.c +6 -21
@@ -505,21 +505,23 @@ static void ulite_console_write(struct console *co, const char *s,static int ulite_console_setup (struct console *co,char *options) { -struct uart_port *port; +struct uart_port *port =NULL ;int baud =9600 ;int bits =8 ;int parity ='n' ;int flow ='n' ; - - port = console_port; +if (co->index >=0 && co->index <ULITE_NR_UARTS ) + port = ulite_ports + co->index;/* Has the device been initialized yet? */ -if (!port->mapbase) { +if (!port || !port->mapbase) {pr_debug ("console on ttyUL%i not present\n" , co->index);return -ENODEV ; } + console_port = port; +/* not initialized yet? */ if (!port->membase) {if (ulite_request_port (port))
@@ -655,17 +657,6 @@ static int ulite_assign(struct device *dev, int id, u32 base, int irq,dev_set_drvdata (dev, port); -#ifdef CONFIG_SERIAL_UARTLITE_CONSOLE -/* -* If console hasn't been found yet try to assign this port -* because it is required to be assigned for console setup function. -* If register_console() don't assign value, then console_port pointer -* is cleanup. -*/ -if (ulite_uart_driver.cons->index ==-1 ) - console_port = port; -#endif -/* Register the port */ rc =uart_add_one_port (&ulite_uart_driver, port);if (rc) {
@@ -675,12 +666,6 @@ static int ulite_assign(struct device *dev, int id, u32 base, int irq,return rc; } -#ifdef CONFIG_SERIAL_UARTLITE_CONSOLE -/* This is not port which is used for console that's why clean it up */ -if (ulite_uart_driver.cons->index ==-1 ) - console_port =NULL ; -#endif -return 0 ; }
Signature · 1 line
2.30.2
Greg Kroah-Hartman
maintainerPATCH 82/292 s390/sclp_vt220: fix console name to match device
In reply to Greg Kroah-HartmanFrom: Valentin Vidic <[email protected]>
[ Upstream commit b7d91d230a119fdcc334d10c9889ce9c5e15118b ]
Console name reported in /proc/consoles:
ttyS1 -W- (EC p ) 4:65
does not match the char device name:
crw--w---- 1 root root 4, 65 May 17 12:18 /dev/ttysclp0
so debian-installer inside a QEMU s390x instance gets confused and fails to start with the following error:
steal-ctty: No such file or directory
--- arch/s390/kernel/setup.c | 2 +- drivers/s390/char/sclp_vt220.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-)
arch/s390/kernel/setup.c +1 -1
@@ -165,7 +165,7 @@ static void __init set_preferred_console(void)else if (CONSOLE_IS_3270 )add_preferred_console ("tty3270" ,0 ,NULL );else if (CONSOLE_IS_VT220 ) -add_preferred_console ("ttyS" ,1 ,NULL ); +add_preferred_console ("ttysclp" ,0 ,NULL );else if (CONSOLE_IS_HVC )add_preferred_console ("hvc" ,0 ,NULL ); }
drivers/s390/char/sclp_vt220.c +2 -2
@@ -35,8 +35,8 @@#define SCLP_VT220_MINOR 65#define SCLP_VT220_DRIVER_NAME "sclp_vt220"#define SCLP_VT220_DEVICE_NAME "ttysclp" -#define SCLP_VT220_CONSOLE_NAME "ttyS" -#define SCLP_VT220_CONSOLE_INDEX 1/* console=ttyS1 */ +#define SCLP_VT220_CONSOLE_NAME "ttysclp" +#define SCLP_VT220_CONSOLE_INDEX 0/* console=ttysclp0 */ /* Representation of a single write request */ struct sclp_vt220_request {
Signature · 1 line
2.30.2
Greg Kroah-Hartman
maintainerPATCH 83/292 s390: disable SSP when needed
In reply to Greg Kroah-HartmanFrom: Fabrice Fontaine <[email protected]>
[ Upstream commit 42e8d652438f5ddf04e5dac299cb5e623d113dc0 ]
Though -nostdlib is passed in PURGATORY_LDFLAGS and -ffreestanding in KBUILD_CFLAGS_DECOMPRESSOR, -fno-stack-protector must also be passed to avoid linking errors related to undefined references to '__stack_chk_guard' and '__stack_chk_fail' if toolchain enforces -fstack-protector.
Fixes
- https://gitlab.com/kubu93/buildroot/-/jobs/1247043361
--- arch/s390/Makefile | 1 + arch/s390/purgatory/Makefile | 1 + 2 files changed, 2 insertions(+)
arch/s390/Makefile +1 -0
@@ -28,6 +28,7 @@ KBUILD_CFLAGS_DECOMPRESSOR += -DDISABLE_BRANCH_PROFILING -D__NO_FORTIFY KBUILD_CFLAGS_DECOMPRESSOR += -fno-delete-null-pointer-checks -msoft-float -mbackchain KBUILD_CFLAGS_DECOMPRESSOR += -fno-asynchronous-unwind-tables KBUILD_CFLAGS_DECOMPRESSOR += -ffreestanding +KBUILD_CFLAGS_DECOMPRESSOR += -fno-stack-protector KBUILD_CFLAGS_DECOMPRESSOR += $(call cc-disable-warning, address-of-packed-member) KBUILD_CFLAGS_DECOMPRESSOR += $(if $(CONFIG_DEBUG_INFO),-g) KBUILD_CFLAGS_DECOMPRESSOR += $(if $(CONFIG_DEBUG_INFO_DWARF4), $(call cc-option, -gdwarf-4,))
arch/s390/purgatory/Makefile +1 -0
@@ -24,6 +24,7 @@ KBUILD_CFLAGS := -fno-strict-aliasing -Wall -Wstrict-prototypes KBUILD_CFLAGS += -Wno-pointer-sign -Wno-sign-compare KBUILD_CFLAGS += -fno-zero-initialized-in-bss -fno-builtin -ffreestanding KBUILD_CFLAGS += -c -MD -Os -m64 -msoft-float -fno-common +KBUILD_CFLAGS += -fno-stack-protector KBUILD_CFLAGS += $(CLANG_FLAGS) KBUILD_CFLAGS += $(call cc-option,-fno-PIE) KBUILD_AFLAGS := $(filter-out -DCC_USING_EXPOLINE,$(KBUILD_AFLAGS))
Signature · 1 line
2.30.2
Greg Kroah-Hartman
maintainerPATCH 84/292 selftests: timers: rtcpie: skip test if default RTC device does not exist
In reply to Greg Kroah-HartmanFrom: Po-Hsu Lin <[email protected]>
[ Upstream commit 0d3e5a057992bdc66e4dca2ca50b77fa4a7bd90e ]
This test will require /dev/rtc0, the default RTC device, or one specified by user to run. Since this default RTC is not guaranteed to exist on all of the devices, so check its existence first, otherwise skip this test with the kselftest skip code 4.
Without this patch this test will fail like this on a s390x zVM:
$ selftests: timers: rtcpie $ /dev/rtc0: No such file or directory not ok 1 selftests: timers: rtcpie # exit=22
With this patch:
$ selftests: timers: rtcpie $ Default RTC /dev/rtc0 does not exist. Test Skipped! not ok 9 selftests: timers: rtcpie # SKIP
Fixed up change log so "With this patch" text doesn't get dropped. Shuah Khan <[email protected]>
--- tools/testing/selftests/timers/rtcpie.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-)
tools/testing/selftests/timers/rtcpie.c +9 -1
@@ -18,6 +18,8 @@#include <stdlib.h> #include <errno.h> +#include "../kselftest.h" +/* * This expects the new RTC class driver framework, working with * clocks that will often not be clones of what the PC-AT had.
@@ -35,8 +37,14 @@ int main(int argc, char **argv)switch (argc) {case 2 : rtc = argv[1 ]; -/* FALLTHROUGH */ +break ;case 1 : + fd =open (default_rtc,O_RDONLY ); +if (fd ==-1 ) { +printf ("Default RTC %s does not exist. Test Skipped!\n" , default_rtc); +exit (KSFT_SKIP ); + } +close (fd);break ;default :fprintf (stderr,"usage: rtctest [rtcdev] [d]\n" );
Signature · 1 line
2.30.2
Greg Kroah-Hartman
maintainerPATCH 85/292 iommu/arm-smmu-qcom: Skip the TTBR1 quirk for db820c.
In reply to Greg Kroah-HartmanFrom: Eric Anholt <[email protected]>
[ Upstream commit a242f4297cfe3f4589a7620dcd42cc503607fc6b ]
db820c wants to use the qcom smmu path to get HUPCF set (which keeps the GPU from wedging and then sometimes wedging the kernel after a page fault), but it doesn't have separate pagetables support yet in drm/msm so we can't go all the way to the TTBR1 path.
--- drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-)
drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c +12 -1
@@ -130,6 +130,16 @@ static int qcom_adreno_smmu_alloc_context_bank(struct arm_smmu_domain *smmu_domareturn __arm_smmu_alloc_bitmap (smmu->context_map, start, count); } +static bool qcom_adreno_can_do_ttbr1 (struct arm_smmu_device *smmu) +{ +const struct device_node *np = smmu->dev->of_node; + +if (of_device_is_compatible (np,"qcom,msm8996-smmu-v2" )) +return false; + +return true; +} +static int qcom_adreno_smmu_init_context (struct arm_smmu_domain *smmu_domain,struct io_pgtable_cfg *pgtbl_cfg,struct device *dev) {
@@ -144,7 +154,8 @@ static int qcom_adreno_smmu_init_context(struct arm_smmu_domain *smmu_domain,* be AARCH64 stage 1 but double check because the arm-smmu code assumes * that is the case when the TTBR1 quirk is enabled */ -if ((smmu_domain->stage ==ARM_SMMU_DOMAIN_S1 ) && +if (qcom_adreno_can_do_ttbr1 (smmu_domain->smmu) && + (smmu_domain->stage ==ARM_SMMU_DOMAIN_S1 ) && (smmu_domain->cfg.fmt ==ARM_SMMU_CTX_FMT_AARCH64 )) pgtbl_cfg->quirks |=IO_PGTABLE_QUIRK_ARM_TTBR1 ;
Signature · 1 line
2.30.2
Greg Kroah-Hartman
maintainerPATCH 86/292 ALSA: sb: Fix potential double-free of CSP mixer elements
In reply to Greg Kroah-HartmanFrom: Takashi Iwai <[email protected]>
[ Upstream commit c305366a37441c2ac90b08711cb6f032b43672f2 ]
snd_sb_qsound_destroy() contains the calls of removing the previously created mixer controls, but it doesn't clear the pointers. As snd_sb_qsound_destroy() itself may be repeatedly called via ioctl, this could lead to double-free potentially.
Fix it by clearing the struct fields properly afterwards.
--- sound/isa/sb/sb16_csp.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-)
sound/isa/sb/sb16_csp.c +6 -2
@@ -1072,10 +1072,14 @@ static void snd_sb_qsound_destroy(struct snd_sb_csp * p) card = p->chip->card;down_write (&card->controls_rwsem); -if (p->qsound_switch) +if (p->qsound_switch) {snd_ctl_remove (card, p->qsound_switch); -if (p->qsound_space) + p->qsound_switch =NULL ; + } +if (p->qsound_space) {snd_ctl_remove (card, p->qsound_space); + p->qsound_space =NULL ; + }up_write (&card->controls_rwsem);/* cancel pending transfer of QSound parameters */
Signature · 1 line
2.30.2
Greg Kroah-Hartman
maintainerPATCH 87/292 powerpc/ps3: Add dma_mask to ps3_dma_region
In reply to Greg Kroah-HartmanFrom: Geoff Levand <[email protected]>
[ Upstream commit 9733862e50fdba55e7f1554e4286fcc5302ff28e ]
Commit f959dcd6ddfd29235030e8026471ac1b022ad2b0 (dma-direct: Fix potential NULL pointer dereference) added a null check on the dma_mask pointer of the kernel's device structure.
Add a dma_mask variable to the ps3_dma_region structure and set the device structure's dma_mask pointer to point to this new variable.
Fixes runtime errors like these:
# WARNING: Fixes tag on line 10 doesn't match correct format # WARNING: Fixes tag on line 10 doesn't match correct format
ps3_system_bus_match:349: dev=8.0(sb_01), drv=8.0(ps3flash): match
WARNING: CPU: 0 PID: 1 at kernel/dma/mapping.c:151 .dma_map_page_attrs+0x34/0x1e0 ps3flash sb_01: ps3stor_setup:193: map DMA region failed
--- arch/powerpc/include/asm/ps3.h | 2 ++ arch/powerpc/platforms/ps3/mm.c | 12 ++++++++++++ 2 files changed, 14 insertions(+)
arch/powerpc/include/asm/ps3.h +2 -0
@@ -71,6 +71,7 @@ struct ps3_dma_region_ops;* @bus_addr: The 'translated' bus address of the region. * @len: The length in bytes of the region. * @offset: The offset from the start of memory of the region. +* @dma_mask: Device dma_mask. * @ioid: The IOID of the device who owns this region * @chunk_list: Opaque variable used by the ioc page manager. * @region_ops: struct ps3_dma_region_ops - dma region operations
@@ -85,6 +86,7 @@ struct ps3_dma_region {enum ps3_dma_region_type region_type;unsigned long len;unsigned long offset; +u64 dma_mask;/* driver variables (set by ps3_dma_region_create) */ unsigned long bus_addr;
arch/powerpc/platforms/ps3/mm.c +12 -0
@@ -6,6 +6,7 @@* Copyright 2006 Sony Corp. */ +#include <linux/dma-mapping.h> #include <linux/kernel.h> #include <linux/export.h> #include <linux/memblock.h>
@@ -1118,6 +1119,7 @@ int ps3_dma_region_init(struct ps3_system_bus_device *dev, enum ps3_dma_region_type region_type, void *addr, unsigned long len) { unsigned long lpar_addr; +int result; lpar_addr = addr ?ps3_mm_phys_to_lpar (__pa (addr)) :0 ;
@@ -1129,6 +1131,16 @@ int ps3_dma_region_init(struct ps3_system_bus_device *dev, r->offset -= map.r1.offset; r->len = len ? len :ALIGN (map.total,1 << r->page_size); + dev->core.dma_mask = &r->dma_mask; + + result =dma_set_mask_and_coherent (&dev->core,DMA_BIT_MASK (32 )); + +if (result <0 ) { +dev_err (&dev->core,"%s:%d: dma_set_mask_and_coherent failed: %d\n" , + __func__, __LINE__, result); +return result; + } +switch (dev->dev_type) {case PS3_DEVICE_TYPE_SB : r->region_ops = (USE_DYNAMIC_DMA )
Signature · 1 line
2.30.2
Greg Kroah-Hartman
maintainerPATCH 88/292 iommu/arm-smmu: Fix arm_smmu_device refcount leak when arm_smmu_rpm_get fails
In reply to Greg Kroah-HartmanFrom: Xiyu Yang <[email protected]>
[ Upstream commit 1adf30f198c26539a62d761e45af72cde570413d ]
arm_smmu_rpm_get() invokes pm_runtime_get_sync(), which increases the refcount of the "smmu" even though the return value is less than 0.
The reference counting issue happens in some error handling paths of arm_smmu_rpm_get() in its caller functions. When arm_smmu_rpm_get() fails, the caller functions forget to decrease the refcount of "smmu" increased by arm_smmu_rpm_get(), causing a refcount leak.
Fix this issue by calling pm_runtime_resume_and_get() instead of pm_runtime_get_sync() in arm_smmu_rpm_get(), which can keep the refcount balanced in case of failure.
--- drivers/iommu/arm/arm-smmu/arm-smmu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iommu/arm/arm-smmu/arm-smmu.c +1 -1
@@ -74,7 +74,7 @@ static bool using_legacy_binding, using_generic_binding;static inline int arm_smmu_rpm_get (struct arm_smmu_device *smmu) {if (pm_runtime_enabled (smmu->dev)) -return pm_runtime_get_sync (smmu->dev); +return pm_runtime_resume_and_get (smmu->dev);return 0 ; }
Signature · 1 line
2.30.2
Greg Kroah-Hartman
maintainerPATCH 89/292 iommu/arm-smmu: Fix arm_smmu_device refcount leak in address translation
In reply to Greg Kroah-HartmanFrom: Xiyu Yang <[email protected]>
[ Upstream commit 7c8f176d6a3fa18aa0f8875da6f7c672ed2a8554 ]
The reference counting issue happens in several exception handling paths of arm_smmu_iova_to_phys_hard(). When those error scenarios occur, the function forgets to decrease the refcount of "smmu" increased by arm_smmu_rpm_get(), causing a refcount leak.
Fix this issue by jumping to "out" label when those error scenarios occur.
--- drivers/iommu/arm/arm-smmu/arm-smmu.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-)
drivers/iommu/arm/arm-smmu/arm-smmu.c +6 -2
@@ -1268,6 +1268,7 @@ static phys_addr_t arm_smmu_iova_to_phys_hard(struct iommu_domain *domain,u64 phys;unsigned long va, flags;int ret, idx = cfg->cbndx; +phys_addr_t addr =0 ; ret =arm_smmu_rpm_get (smmu);if (ret <0 )
@@ -1287,6 +1288,7 @@ static phys_addr_t arm_smmu_iova_to_phys_hard(struct iommu_domain *domain,dev_err (dev,"iova to phys timed out on %pad. Falling back to software table walk.\n" , &iova); +arm_smmu_rpm_put (smmu);return ops->iova_to_phys (ops, iova); }
@@ -1295,12 +1297,14 @@ static phys_addr_t arm_smmu_iova_to_phys_hard(struct iommu_domain *domain,if (phys &ARM_SMMU_CB_PAR_F ) {dev_err (dev,"translation fault!\n" );dev_err (dev,"PAR = 0x%llx\n" , phys); -return 0 ; + goto out; } + addr = (phys &GENMASK_ULL (39 ,12 )) | (iova &0xfff ); +out:arm_smmu_rpm_put (smmu); -return (phys &GENMASK_ULL (39 ,12 )) | (iova &0xfff ); +return addr; } static phys_addr_t arm_smmu_iova_to_phys(struct iommu_domain *domain,
Signature · 1 line
2.30.2
Greg Kroah-Hartman
maintainerPATCH 90/292 ALSA: n64: check return value after calling platform_get_resource()
In reply to Greg Kroah-HartmanFrom: Yang Yingliang <[email protected]>
[ Upstream commit be471fe332f7f14aa6828010b220d7e6902b91a0 ]
It will cause null-ptr-deref if platform_get_resource() returns NULL, we need check the return value.
--- sound/mips/snd-n64.c | 4 ++++ 1 file changed, 4 insertions(+)
sound/mips/snd-n64.c +4 -0
@@ -338,6 +338,10 @@ static int __init n64audio_probe(struct platform_device *pdev)strcpy (card->longname,"N64 Audio" ); res =platform_get_resource (pdev,IORESOURCE_IRQ ,0 ); +if (!res) { + err = -EINVAL ; + goto fail_dma_alloc; + }if (devm_request_irq (&pdev->dev, res->start, n64audio_isr,IRQF_SHARED ,"N64 Audio" , priv)) { err = -EBUSY ;
Signature · 1 line
2.30.2
Greg Kroah-Hartman
maintainerPATCH 91/292 ASoC: soc-pcm: fix the return value in dpcm_apply_symmetry()
In reply to Greg Kroah-HartmanFrom: Jaroslav Kysela <[email protected]>
[ Upstream commit 12ffd726824a2f52486f72338b6fd3244b512959 ]
In case, where the loops are not executed for a reason, the uninitialized variable 'err' is returned to the caller. Make code fully predictible and assign zero in the declaration.
--- sound/soc/soc-pcm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/soc-pcm.c +1 -1
@@ -1695,7 +1695,7 @@ static int dpcm_apply_symmetry(struct snd_pcm_substream *fe_substream,struct snd_soc_dpcm *dpcm;struct snd_soc_pcm_runtime *fe =asoc_substream_to_rtd (fe_substream);struct snd_soc_dai *fe_cpu_dai; -int err; +int err =0 ;int i;/* apply symmetry for FE */
Signature · 1 line
2.30.2
Greg Kroah-Hartman
maintainerPATCH 92/292 gpio: zynq: Check return value of pm_runtime_get_sync
In reply to Greg Kroah-HartmanFrom: Srinivas Neeli <[email protected]>
[ Upstream commit a51b2fb94b04ab71e53a71b9fad03fa826941254 ]
Return value of "pm_runtime_get_sync" API was neither captured nor checked. Fixed it by capturing the return value and then checking for any warning.
Addresses-Coverity: "check_return"
--- drivers/gpio/gpio-zynq.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
drivers/gpio/gpio-zynq.c +4 -1
@@ -1001,8 +1001,11 @@ err_pm_dis:static int zynq_gpio_remove (struct platform_device *pdev) {struct zynq_gpio *gpio =platform_get_drvdata (pdev); +int ret; -pm_runtime_get_sync (&pdev->dev); + ret =pm_runtime_get_sync (&pdev->dev); +if (ret <0 ) +dev_warn (&pdev->dev,"pm_runtime_get_sync() Failed\n" );gpiochip_remove (&gpio->chip);clk_disable_unprepare (gpio->clk);device_set_wakeup_capable (&pdev->dev,0 );
Signature · 1 line
2.30.2
Greg Kroah-Hartman
maintainerPATCH 93/292 gpio: zynq: Check return value of irq_get_irq_data
In reply to Greg Kroah-HartmanFrom: Srinivas Neeli <[email protected]>
[ Upstream commit 35d7b72a632bc7afb15356f44005554af8697904 ]
In two different instances the return value of "irq_get_irq_data" API was neither captured nor checked.
Fixed it by capturing the return value and then checking for any error.
Addresses-Coverity: "returned_null"
--- drivers/gpio/gpio-zynq.c | 10 ++++++++++ 1 file changed, 10 insertions(+)
drivers/gpio/gpio-zynq.c +10 -0
@@ -736,6 +736,11 @@ static int __maybe_unused zynq_gpio_suspend(struct device *dev)struct zynq_gpio *gpio =dev_get_drvdata (dev);struct irq_data *data =irq_get_irq_data (gpio->irq); +if (!data) { +dev_err (dev,"irq_get_irq_data() failed\n" ); +return -EINVAL ; + } +if (!device_may_wakeup (dev))disable_irq (gpio->irq);
@@ -753,6 +758,11 @@ static int __maybe_unused zynq_gpio_resume(struct device *dev)struct irq_data *data =irq_get_irq_data (gpio->irq);int ret; +if (!data) { +dev_err (dev,"irq_get_irq_data() failed\n" ); +return -EINVAL ; + } +if (!device_may_wakeup (dev))enable_irq (gpio->irq);
Signature · 1 line
2.30.2
Greg Kroah-Hartman
maintainerPATCH 94/292 scsi: storvsc: Correctly handle multiple flags in srb_status
In reply to Greg Kroah-HartmanFrom: Michael Kelley <[email protected]>
[ Upstream commit 52e1b3b3daa9d53f0204bf474ee1d4b1beb38234 ]
Hyper-V is observed to sometimes set multiple flags in the srb_status, such as ABORTED and ERROR. Current code in storvsc_handle_error() handles only a single flag being set, and does nothing when multiple flags are set. Fix this by changing the case statement into a series of "if" statements testing individual flags. The functionality for handling each flag is unchanged.
--- drivers/scsi/storvsc_drv.c | 61 +++++++++++++++++++++----------------- 1 file changed, 33 insertions(+), 28 deletions(-)
drivers/scsi/storvsc_drv.c +33 -28
@@ -1005,17 +1005,40 @@ static void storvsc_handle_error(struct vmscsi_request *vm_srb,struct storvsc_scan_work *wrk;void (*process_err_fn)(struct work_struct *work);struct hv_host_device *host_dev =shost_priv (host); -bool do_work = false; -switch (SRB_STATUS (vm_srb->srb_status)) { -case SRB_STATUS_ERROR : +/* +* In some situations, Hyper-V sets multiple bits in the +* srb_status, such as ABORTED and ERROR. So process them +* individually, with the most specific bits first. +*/ + +if (vm_srb->srb_status &SRB_STATUS_INVALID_LUN ) { +set_host_byte (scmnd,DID_NO_CONNECT ); + process_err_fn = storvsc_remove_lun; + goto do_work; + } + +if (vm_srb->srb_status &SRB_STATUS_ABORTED ) { +if (vm_srb->srb_status &SRB_STATUS_AUTOSENSE_VALID && +/* Capacity data has changed */ + (asc ==0x2a ) && (ascq ==0x9 )) { + process_err_fn = storvsc_device_scan; +/* +* Retry the I/O that triggered this. +*/ +set_host_byte (scmnd,DID_REQUEUE ); + goto do_work; + } + } + +if (vm_srb->srb_status &SRB_STATUS_ERROR ) {/* * Let upper layer deal with error when * sense message is present. */ -if (vm_srb->srb_status &SRB_STATUS_AUTOSENSE_VALID ) -break ; +return ; +/* * If there is an error; offline the device since all * error recovery strategies would have already been
@@ -1028,37 +1051,19 @@ static void storvsc_handle_error(struct vmscsi_request *vm_srb,set_host_byte (scmnd,DID_PASSTHROUGH );break ;/* -* On Some Windows hosts TEST_UNIT_READY command can return -* SRB_STATUS_ERROR, let the upper level code deal with it -* based on the sense information. +* On some Hyper-V hosts TEST_UNIT_READY command can +* return SRB_STATUS_ERROR. Let the upper level code +* deal with it based on the sense information. */ case TEST_UNIT_READY :break ;default :set_host_byte (scmnd,DID_ERROR ); } -break ; -case SRB_STATUS_INVALID_LUN : -set_host_byte (scmnd,DID_NO_CONNECT ); - do_work = true; - process_err_fn = storvsc_remove_lun; -break ; -case SRB_STATUS_ABORTED : -if (vm_srb->srb_status &SRB_STATUS_AUTOSENSE_VALID && - (asc ==0x2a ) && (ascq ==0x9 )) { - do_work = true; - process_err_fn = storvsc_device_scan; -/* -* Retry the I/O that triggered this. -*/ -set_host_byte (scmnd,DID_REQUEUE ); - } -break ; } +return ; -if (!do_work) -return ; - +do_work:/* * We need to schedule work to process this error; schedule it. */
Signature · 1 line
2.30.2
Greg Kroah-Hartman
maintainerPATCH 95/292 ALSA: ppc: fix error return code in snd_pmac_probe()
In reply to Greg Kroah-HartmanFrom: Yang Yingliang <[email protected]>
[ Upstream commit 80b9c1be567c3c6bbe0d4b290af578e630485b5d ]
If snd_pmac_tumbler_init() or snd_pmac_tumbler_post_init() fails, snd_pmac_probe() need return error code.
--- sound/ppc/powermac.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)
sound/ppc/powermac.c +5 -1
@@ -76,7 +76,11 @@ static int snd_pmac_probe(struct platform_device *devptr)sprintf (card->shortname,"PowerMac %s" , name_ext);sprintf (card->longname,"%s (Dev %d) Sub-frame %d" , card->shortname, chip->device_id, chip->subframe); -if (snd_pmac_tumbler_init (chip) <0 ||snd_pmac_tumbler_post_init () <0 ) + err =snd_pmac_tumbler_init (chip); +if (err <0 ) + goto __error; + err =snd_pmac_tumbler_post_init (); +if (err <0 ) goto __error;break ;case PMAC_AWACS :
Signature · 1 line
2.30.2
Greg Kroah-Hartman
maintainerPATCH 96/292 selftests/powerpc: Fix "no_handler" EBB selftest
In reply to Greg Kroah-HartmanFrom: Athira Rajeev <[email protected]>
[ Upstream commit 45677c9aebe926192e59475b35a1ff35ff2d4217 ]
The "no_handler_test" in ebb selftests attempts to read the PMU registers twice via helper function "dump_ebb_state". First dump is just before closing of event and the second invocation is done after closing of the event. The original intention of second dump_ebb_state was to dump the state of registers at the end of the test when the counters are frozen. But this will be achieved with the first call itself since sample period is set to low value and PMU will be frozen by then. Hence patch removes the dump which was done before closing of the event.
--- tools/testing/selftests/powerpc/pmu/ebb/no_handler_test.c | 2 -- 1 file changed, 2 deletions(-)
tools/testing/selftests/powerpc/pmu/ebb/no_handler_test.c +0 -2
@@ -50,8 +50,6 @@ static int no_handler_test(void)event_close (&event); -dump_ebb_state (); -/* The real test is that we never took an EBB at 0x0 */ return 0 ;
Signature · 1 line
2.30.2
Greg Kroah-Hartman
maintainerPATCH 97/292 gpio: pca953x: Add support for the On Semi pca9655
In reply to Greg Kroah-HartmanFrom: Peter Robinson <[email protected]>
[ Upstream commit 6d49b3a0f351925b5ea5047166c112b7590b918a ]
The On Semi pca9655 is a 16 bit variant of the On Semi pca9654 GPIO expander, with 16 GPIOs and interrupt functionality.
--- drivers/gpio/gpio-pca953x.c | 1 + 1 file changed, 1 insertion(+)
drivers/gpio/gpio-pca953x.c +1 -0
@@ -1241,6 +1241,7 @@ static const struct of_device_id pca953x_dt_ids[] = { { .compatible = "onnn,cat9554", .data = OF_953X( 8, PCA_INT), }, { .compatible = "onnn,pca9654", .data = OF_953X( 8, PCA_INT), }, + { .compatible = "onnn,pca9655", .data = OF_953X(16, PCA_INT), }, { .compatible = "exar,xra1202", .data = OF_953X( 8, 0), }, { }
Signature · 1 line
2.30.2
Greg Kroah-Hartman
maintainerPATCH 98/292 powerpc/mm/book3s64: Fix possible build error
In reply to Greg Kroah-HartmanFrom: Aneesh Kumar K.V <[email protected]>
[ Upstream commit 07d8ad6fd8a3d47f50595ca4826f41dbf4f3a0c6 ]
Update _tlbiel_pid() such that we can avoid build errors like below when using this function in other places.
arch/powerpc/mm/book3s64/radix_tlb.c: In function ‘__radix__flush_tlb_range_psize’:arch/powerpc/mm/book3s64/radix_tlb.c:114:2: warning: ‘asm’ operand 3 probably does not match constraints
114 | asm volatile(PPC_TLBIEL(%0, %4, %3, %2, %1)
| ^~~arch/powerpc/mm/book3s64/radix_tlb.c:114:2: error: impossible constraint in ‘asm’ make[4]: *** [scripts/Makefile.build:271: arch/powerpc/mm/book3s64/radix_tlb.o] Error 1 m
With this fix, we can also drop the __always_inline in __radix_flush_tlb_range_psize
which was added by commit e12d6d7d46a6 ("powerpc/mm/radix: mark __radix__flush_tlb_range_psize() as __always_inline")
--- arch/powerpc/mm/book3s64/radix_tlb.c | 26 +++++++++++++++++--------- 1 file changed, 17 insertions(+), 9 deletions(-)
arch/powerpc/mm/book3s64/radix_tlb.c +17 -9
@@ -291,22 +291,30 @@ static inline void fixup_tlbie_lpid(unsigned long lpid)/* * We use 128 set in radix mode and 256 set in hpt mode. */ -static __always_inline void _tlbiel_pid(unsigned long pid, unsigned long ric) +static inline void _tlbiel_pid (unsigned long pid,unsigned long ric) {int set; asmvolatile ("ptesync" : : :"memory" ); -/* -* Flush the first set of the TLB, and if we're doing a RIC_FLUSH_ALL, -* also flush the entire Page Walk Cache. -*/ -__tlbiel_pid (pid,0 , ric); +switch (ric) { +case RIC_FLUSH_PWC : -/* For PWC, only one flush is needed */ -if (ric ==RIC_FLUSH_PWC ) { +/* For PWC, only one flush is needed */ +__tlbiel_pid (pid,0 ,RIC_FLUSH_PWC );ppc_after_tlbiel_barrier ();return ; +case RIC_FLUSH_TLB : +__tlbiel_pid (pid,0 ,RIC_FLUSH_TLB ); +break ; +case RIC_FLUSH_ALL : +default : +/* +* Flush the first set of the TLB, and if +* we're doing a RIC_FLUSH_ALL, also flush +* the entire Page Walk Cache. +*/ +__tlbiel_pid (pid,0 ,RIC_FLUSH_ALL ); }if (!cpu_has_feature (CPU_FTR_ARCH_31 )) {
@@ -1176,7 +1184,7 @@ void radix__tlb_flush(struct mmu_gather *tlb) } } -static __always_inline void __radix__flush_tlb_range_psize(struct mm_struct *mm, +static void __radix__flush_tlb_range_psize (struct mm_struct *mm,unsigned long start,unsigned long end,int psize,bool also_pwc) {
Signature · 1 line
2.30.2
Greg Kroah-Hartman
maintainerPATCH 99/292 ASoC: soc-core: Fix the error return code in snd_soc_of_parse_audio_routing()
In reply to Greg Kroah-HartmanFrom: Zhen Lei <[email protected]>
[ Upstream commit 7d3865a10b9ff2669c531d5ddd60bf46b3d48f1e ]
When devm_kcalloc() fails, the error code -ENOMEM should be returned instead of -EINVAL.
--- sound/soc/soc-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/soc-core.c +1 -1
@@ -2796,7 +2796,7 @@ int snd_soc_of_parse_audio_routing(struct snd_soc_card *card,if (!routes) {dev_err (card->dev,"ASoC: Could not allocate DAPM route table\n" ); -return -EINVAL ; +return -ENOMEM ; }for (i =0 ; i < num_routes; i++) {
Signature · 1 line
2.30.2
Greg Kroah-Hartman
maintainerPATCH 100/292 xhci: handle failed buffer copy to URB sg list and fix a W=1 copiler warning
In reply to Greg Kroah-HartmanFrom: Mathias Nyman <[email protected]>
[ Upstream commit 271a21d8b280b186f8cc9ca6f7151902efde9512 ]
Set the urb->actual_length to bytes successfully copied in case all bytes weren't copied from a temporary buffer to the URB sg list. Also print a debug message
--- drivers/usb/host/xhci.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-)
drivers/usb/host/xhci.c +7 -2
@@ -1362,12 +1362,17 @@ static void xhci_unmap_temp_buf(struct usb_hcd *hcd, struct urb *urb) urb->transfer_buffer_length, dir); -if (usb_urb_dir_in (urb)) +if (usb_urb_dir_in (urb)) { len =sg_pcopy_from_buffer (urb->sg, urb->num_sgs, urb->transfer_buffer, buf_len,0 ); - +if (len != buf_len) { +xhci_dbg (hcd_to_xhci (hcd), +"Copy from tmp buf to urb sg list failed\n" ); + urb->actual_length = len; + } + } urb->transfer_flags &= ~URB_DMA_MAP_SINGLE ;kfree (urb->transfer_buffer); urb->transfer_buffer =NULL ;
Signature · 1 line
2.30.2
Greg Kroah-Hartman
maintainerPATCH 101/292 habanalabs/gaudi: set the correct cpu_id on MME2_QM failure
In reply to Greg Kroah-HartmanFrom: Koby Elbaz <[email protected]>
[ Upstream commit b92c637c5f5ef7e3e21dbc7bfa7f1999450f3902 ]
This fix was applied since there was an incorrect reported CPU ID to GIC such that an error in MME2 QMAN aliased to be an arriving from DMA0_QM.
--- drivers/misc/habanalabs/gaudi/gaudi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/misc/habanalabs/gaudi/gaudi.c +1 -1
@@ -2801,7 +2801,7 @@ static void gaudi_init_mme_qman(struct hl_device *hdev, u32 mme_offset,/* Configure RAZWI IRQ */ mme_id = mme_offset / - (mmMME1_QM_GLBL_CFG0 - mmMME0_QM_GLBL_CFG0); + (mmMME1_QM_GLBL_CFG0 - mmMME0_QM_GLBL_CFG0) /2 ; mme_qm_err_cfg =MME_QMAN_GLBL_ERR_CFG_MSG_EN_MASK ;if (hdev->stop_on_err) {
Signature · 1 line
2.30.2
Greg Kroah-Hartman
maintainerPATCH 102/292 habanalabs: fix mask to obtain page offset
In reply to Greg Kroah-HartmanFrom: Ohad Sharabi <[email protected]>
[ Upstream commit 0f37510ca34848718db1003479bb4671e8f3c112 ]
When converting virtual address to physical we need to add correct offset to the physical page.
For this we need to use mask that include ALL bits of page offset.
--- drivers/misc/habanalabs/common/mmu/mmu.c | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-)
drivers/misc/habanalabs/common/mmu/mmu.c +11 -3
@@ -501,12 +501,20 @@ static void hl_mmu_pa_page_with_offset(struct hl_ctx *ctx, u64 virt_addr,if ((hops->range_type ==HL_VA_RANGE_TYPE_DRAM ) && !is_power_of_2 (prop->dram_page_size)) { -u32 bit; +unsigned long dram_page_size = prop->dram_page_size;u64 page_offset_mask;u64 phys_addr_mask; +u32 bit; - bit =__ffs64 ((u64 )prop->dram_page_size); - page_offset_mask = ((1ull << bit) -1 ); +/* +* find last set bit in page_size to cover all bits of page +* offset. note that 1 has to be added to bit index. +* note that the internal ulong variable is used to avoid +* alignment issue. +*/ + bit =find_last_bit (&dram_page_size, +sizeof (dram_page_size) *BITS_PER_BYTE ) +1 ; + page_offset_mask = (BIT_ULL (bit) -1 ); phys_addr_mask = ~page_offset_mask; *phys_addr = (tmp_phys_addr & phys_addr_mask) | (virt_addr & page_offset_mask);
Signature · 1 line
2.30.2
Greg Kroah-Hartman
maintainerPATCH 103/292 habanalabs: set rc as valid in case of intentional func exit
In reply to Greg Kroah-HartmanFrom: Koby Elbaz <[email protected]>
[ Upstream commit 11d5cb8b95456e2432dfee2ffcebf0623998493a ]
fix the following smatch warnings:hl_fw_static_init_cpu() warn: missing error code 'rc'
--- drivers/misc/habanalabs/common/device.c | 5 +++-- drivers/misc/habanalabs/common/firmware_if.c | 5 ++++- 2 files changed, 7 insertions(+), 3 deletions(-)
drivers/misc/habanalabs/common/device.c +3 -2
@@ -1370,8 +1370,9 @@ int hl_device_init(struct hl_device *hdev, struct class *hclass) }/* -* From this point, in case of an error, add char devices and create -* sysfs nodes as part of the error flow, to allow debugging. +* From this point, override rc (=0) in case of an error to allow +* debugging (by adding char devices and create sysfs nodes as part of +* the error flow). */ add_cdev_sysfs_on_err = true;
drivers/misc/habanalabs/common/firmware_if.c +4 -1
@@ -803,11 +803,14 @@ int hl_fw_init_cpu(struct hl_device *hdev, u32 cpu_boot_status_reg,if (!(hdev->fw_loading &FW_TYPE_LINUX )) {dev_info (hdev->dev,"Skip loading Linux F/W\n" ); + rc =0 ; goto out; } -if (status ==CPU_BOOT_STATUS_SRAM_AVAIL ) +if (status ==CPU_BOOT_STATUS_SRAM_AVAIL ) { + rc =0 ; goto out; + }dev_info (hdev->dev,"Loading firmware to device, may take some time...\n" );
Signature · 1 line
2.30.2
Greg Kroah-Hartman
maintainerPATCH 104/292 habanalabs: remove node from list before freeing the node
In reply to Greg Kroah-HartmanFrom: Koby Elbaz <[email protected]>
[ Upstream commit f5eb7bf0c487a212ebda3c1b048fc3ccabacc147 ]
fix the following smatch warnings:
goya_pin_memory_before_cs()
warn: '&userptr->job_node' not removed from list
gaudi_pin_memory_before_cs()
warn: '&userptr->job_node' not removed from list
--- drivers/misc/habanalabs/gaudi/gaudi.c | 1 + drivers/misc/habanalabs/goya/goya.c | 1 + 2 files changed, 2 insertions(+)
drivers/misc/habanalabs/gaudi/gaudi.c +1 -0
@@ -4901,6 +4901,7 @@ already_pinned:return 0 ; unpin_memory: +list_del (&userptr->job_node);hl_unpin_host_memory (hdev, userptr); free_userptr:kfree (userptr);
drivers/misc/habanalabs/goya/goya.c +1 -0
@@ -3249,6 +3249,7 @@ already_pinned:return 0 ; unpin_memory: +list_del (&userptr->job_node);hl_unpin_host_memory (hdev, userptr); free_userptr:kfree (userptr);
Signature · 1 line
2.30.2
Greg Kroah-Hartman
maintainerPATCH 105/292 habanalabs/gaudi: set the correct rc in case of err
In reply to Greg Kroah-HartmanFrom: Koby Elbaz <[email protected]>
[ Upstream commit 1f7ef4bf41c7c2abad3d21b8c69db11fc3ebc4f5 ]
fix the following smatch warnings:gaudi_internal_cb_pool_init() warn: missing error code 'rc'
--- drivers/misc/habanalabs/gaudi/gaudi.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/misc/habanalabs/gaudi/gaudi.c +3 -1
@@ -8070,8 +8070,10 @@ static int gaudi_internal_cb_pool_init(struct hl_device *hdev,HL_VA_RANGE_TYPE_HOST ,HOST_SPACE_INTERNAL_CB_SZ , HL_MMU_VA_ALIGNMENT_NOT_NEEDED); -if (!hdev->internal_cb_va_base) +if (!hdev->internal_cb_va_base) { + rc = -ENOMEM ; goto destroy_internal_cb_pool; + }mutex_lock (&ctx->mmu_lock); rc = hl_mmu_map_contiguous(ctx, hdev->internal_cb_va_base,
Signature · 1 line
2.30.2
Greg Kroah-Hartman
maintainerPATCH 106/292 s390/processor: always inline stap() and __load_psw_mask()
In reply to Greg Kroah-HartmanFrom: Heiko Carstens <[email protected]>
[ Upstream commit 9c9a915afd90f7534c16a71d1cd44b58596fddf3 ]
s390 is the only architecture which makes use of the __no_kasan_or_inline attribute for two functions. Given that both stap() and __load_psw_mask() are very small functions they can and should be always inlined anyway.
Therefore get rid of __no_kasan_or_inline and always inline these functions.
--- arch/s390/include/asm/processor.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
arch/s390/include/asm/processor.h +2 -2
@@ -207,7 +207,7 @@ static __always_inline unsigned long current_stack_pointer(void)return sp; } -static __no_kasan_or_inline unsigned short stap (void ) +static __always_inline unsigned short stap (void ) {unsigned short cpu_address;
@@ -246,7 +246,7 @@ static inline void __load_psw(psw_t psw)* Set PSW mask to specified value, while leaving the * PSW addr pointing to the next instruction. */ -static __no_kasan_or_inline void __load_psw_mask(unsigned long mask) +static __always_inline void __load_psw_mask(unsigned long mask) {unsigned long addr;psw_t psw;
Signature · 1 line
2.30.2
Greg Kroah-Hartman
maintainerPATCH 107/292 s390/ipl_parm: fix program check new psw handling
In reply to Greg Kroah-HartmanFrom: Heiko Carstens <[email protected]>
[ Upstream commit 88c2510cecb7e2b518e3c4fdf3cf0e13ebe9377c ]
The __diag308() inline asm temporarily changes the program check new psw to redirect a potential program check on the diag instruction. Restoring of the program check new psw is done in C code behind the inline asm.
This can be problematic, especially if the function is inlined, since the compiler can reorder instructions in such a way that a different instruction, which may result in a program check, might be executed before the program check new psw has been restored.
To avoid such a scenario move restoring into the inline asm. For consistency reasons move also saving of the original program check new psw into the inline asm.
--- arch/s390/boot/ipl_parm.c | 19 +++++++++++-------- 1 file changed, 11 insertions(+), 8 deletions(-)
arch/s390/boot/ipl_parm.c +11 -8
@@ -28,22 +28,25 @@ static inline int __diag308(unsigned long subcode, void *addr) register unsigned long _addr asm("0") = (unsigned long)addr; register unsigned long _rc asm("1") = 0;unsigned long reg1, reg2; -psw_t old = S390_lowcore.program_new_psw; +psw_t old; asmvolatile ( +" mvc 0(16,%[psw_old]),0(%[psw_pgm])\n" " epsw %0,%1\n" -" st %0,%[psw_pgm]\n" -" st %1,%[psw_pgm]+4\n" +" st %0,0(%[psw_pgm])\n" +" st %1,4(%[psw_pgm])\n" " larl %0,1f\n" -" stg %0,%[psw_pgm]+8\n" +" stg %0,8(%[psw_pgm])\n" " diag %[addr],%[subcode],0x308\n" -"1: nopr %%r7\n" +"1: mvc 0(16,%[psw_pgm]),0(%[psw_old])\n" :"=&d" (reg1),"=&a" (reg2), - [psw_pgm]"=Q" (S390_lowcore.program_new_psw), +"+Q" (S390_lowcore.program_new_psw), +"=Q" (old), [addr]"+d" (_addr),"+d" (_rc) - : [subcode]"d" (subcode) + : [subcode]"d" (subcode), + [psw_old]"a" (&old), + [psw_pgm]"a" (&S390_lowcore.program_new_psw) :"cc" ,"memory" ); - S390_lowcore.program_new_psw = old;return _rc; }
Signature · 1 line
2.30.2
Greg Kroah-Hartman
maintainerPATCH 108/292 s390/mem_detect: fix diag260() program check new psw handling
In reply to Greg Kroah-HartmanFrom: Heiko Carstens <[email protected]>
[ Upstream commit 86807f348f418a84970eebb8f9912a7eea16b497 ]
The __diag260() inline asm temporarily changes the program check new psw to redirect a potential program check on the diag instruction. Restoring of the program check new psw is done in C code behind the inline asm.
This can be problematic, especially if the function is inlined, since the compiler can reorder instructions in such a way that a different instruction, which may result in a program check, might be executed before the program check new psw has been restored.
To avoid such a scenario move restoring into the inline asm. For consistency reasons move also saving of the original program check new psw into the inline asm.
--- arch/s390/boot/mem_detect.c | 19 +++++++++++-------- 1 file changed, 11 insertions(+), 8 deletions(-)
arch/s390/boot/mem_detect.c +11 -8
@@ -69,24 +69,27 @@ static int __diag260(unsigned long rx1, unsigned long rx2) register unsigned long _ry asm("4") = 0x10; /* storage configuration */int rc =-1 ;/* fail */ unsigned long reg1, reg2; -psw_t old = S390_lowcore.program_new_psw; +psw_t old; asmvolatile ( +" mvc 0(16,%[psw_old]),0(%[psw_pgm])\n" " epsw %0,%1\n" -" st %0,%[psw_pgm]\n" -" st %1,%[psw_pgm]+4\n" +" st %0,0(%[psw_pgm])\n" +" st %1,4(%[psw_pgm])\n" " larl %0,1f\n" -" stg %0,%[psw_pgm]+8\n" +" stg %0,8(%[psw_pgm])\n" " diag %[rx],%[ry],0x260\n" " ipm %[rc]\n" " srl %[rc],28\n" -"1:\n" +"1: mvc 0(16,%[psw_pgm]),0(%[psw_old])\n" :"=&d" (reg1),"=&a" (reg2), - [psw_pgm]"=Q" (S390_lowcore.program_new_psw), +"+Q" (S390_lowcore.program_new_psw), +"=Q" (old), [rc]"+&d" (rc), [ry]"+d" (_ry) - : [rx]"d" (_rx1),"d" (_rx2) + : [rx]"d" (_rx1),"d" (_rx2), + [psw_old]"a" (&old), + [psw_pgm]"a" (&S390_lowcore.program_new_psw) :"cc" ,"memory" ); - S390_lowcore.program_new_psw = old;return rc ==0 ? _ry :-1 ; }
Signature · 1 line
2.30.2
Greg Kroah-Hartman
maintainerPATCH 109/292 s390/mem_detect: fix tprot() program check new psw handling
In reply to Greg Kroah-HartmanFrom: Heiko Carstens <[email protected]>
[ Upstream commit da9057576785aaab52e706e76c0475c85b77ec14 ]
The tprot() inline asm temporarily changes the program check new psw to redirect a potential program check on the diag instruction. Restoring of the program check new psw is done in C code behind the inline asm.
This can be problematic, especially if the function is inlined, since the compiler can reorder instructions in such a way that a different instruction, which may result in a program check, might be executed before the program check new psw has been restored.
To avoid such a scenario move restoring into the inline asm. For consistency reasons move also saving of the original program check new psw into the inline asm.
--- arch/s390/boot/mem_detect.c | 28 +++++++++++++++++----------- 1 file changed, 17 insertions(+), 11 deletions(-)
arch/s390/boot/mem_detect.c +17 -11
@@ -114,24 +114,30 @@ static int diag260(void)static int tprot (unsigned long addr) { -unsigned long pgm_addr; +unsigned long reg1, reg2;int rc = -EFAULT ; -psw_t old = S390_lowcore.program_new_psw; +psw_t old; - S390_lowcore.program_new_psw.mask =__extract_psw (); asmvolatile ( -" larl %[pgm_addr],1f\n" -" stg %[pgm_addr],%[psw_pgm_addr]\n" +" mvc 0(16,%[psw_old]),0(%[psw_pgm])\n" +" epsw %[reg1],%[reg2]\n" +" st %[reg1],0(%[psw_pgm])\n" +" st %[reg2],4(%[psw_pgm])\n" +" larl %[reg1],1f\n" +" stg %[reg1],8(%[psw_pgm])\n" " tprot 0(%[addr]),0\n" " ipm %[rc]\n" " srl %[rc],28\n" -"1:\n" - : [pgm_addr]"=&d" (pgm_addr), - [psw_pgm_addr]"=Q" (S390_lowcore.program_new_psw.addr), - [rc]"+&d" (rc) - : [addr]"a" (addr) +"1: mvc 0(16,%[psw_pgm]),0(%[psw_old])\n" + : [reg1]"=&d" (reg1), + [reg2]"=&a" (reg2), + [rc]"+&d" (rc), +"=Q" (S390_lowcore.program_new_psw.addr), +"=Q" (old) + : [psw_old]"a" (&old), + [psw_pgm]"a" (&S390_lowcore.program_new_psw), + [addr]"a" (addr) :"cc" ,"memory" ); - S390_lowcore.program_new_psw = old;return rc; }
Signature · 1 line
2.30.2
Greg Kroah-Hartman
maintainerPATCH 110/292 Input: hideep - fix the uninitialized use in hideep_nvm_unlock()
In reply to Greg Kroah-HartmanFrom: Yizhuo Zhai <[email protected]>
[ Upstream commit cac7100d4c51c04979dacdfe6c9a5e400d3f0a27 ]
Inside function hideep_nvm_unlock(), variable "unmask_code" could be uninitialized if hideep_pgm_r_reg() returns error, however, it is used in the later if statement after an "and" operation, which is potentially unsafe.
--- drivers/input/touchscreen/hideep.c | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-)
drivers/input/touchscreen/hideep.c +10 -3
@@ -361,13 +361,16 @@ static int hideep_enter_pgm(struct hideep_ts *ts)return -EIO ; } -static void hideep_nvm_unlock (struct hideep_ts *ts) +static int hideep_nvm_unlock (struct hideep_ts *ts) {u32 unmask_code; +int error;hideep_pgm_w_reg (ts,HIDEEP_FLASH_CFG ,HIDEEP_NVM_SFR_RPAGE ); -hideep_pgm_r_reg (ts,0x0000000C , &unmask_code); + error =hideep_pgm_r_reg (ts,0x0000000C , &unmask_code);hideep_pgm_w_reg (ts,HIDEEP_FLASH_CFG ,HIDEEP_NVM_DEFAULT_PAGE ); +if (error) +return error;/* make it unprotected code */ unmask_code &= ~HIDEEP_PROT_MODE ;
@@ -384,6 +387,8 @@ static void hideep_nvm_unlock(struct hideep_ts *ts)NVM_W_SFR (HIDEEP_NVM_MASK_OFS , ts->nvm_mask);SET_FLASH_HWCONTROL ();hideep_pgm_w_reg (ts,HIDEEP_FLASH_CFG ,HIDEEP_NVM_DEFAULT_PAGE ); + +return 0 ; }static int hideep_check_status (struct hideep_ts *ts)
@@ -462,7 +467,9 @@ static int hideep_program_nvm(struct hideep_ts *ts,u32 addr =0 ;int error; -hideep_nvm_unlock (ts); + error =hideep_nvm_unlock (ts); +if (error) +return error;while (ucode_len >0 ) { xfer_len =min_t (size_t, ucode_len,HIDEEP_NVM_PAGE_SIZE );
Signature · 1 line
2.30.2
Greg Kroah-Hartman
maintainerPATCH 111/292 ALSA: bebob: add support for ToneWeal FW66
In reply to Greg Kroah-HartmanFrom: Takashi Sakamoto <[email protected]>
[ Upstream commit 50ebe56222bfa0911a932930f9229ee5995508d9 ]
A user of FFADO project reported the issue of ToneWeal FW66. As a result, the device is identified as one of applications of BeBoB solution.
I note that in the report the device returns contradictory result in plug discovery process for audio subunit. Fortunately ALSA BeBoB driver doesn't perform it thus it's likely to handle the device without issues.
I receive no reaction to test request for this patch yet, however it would be worth to add support for it.
daniel@gibbonmoon:/sys/bus/firewire/devices/fw1$ grep -r . * Binary file config_rom matches dev:244:1 guid:0x0023270002000000 hardware_version:0x000002 is_local:0 model:0x020002 model_name:FW66 power/runtime_active_time:0 power/runtime_active_kids:0 power/runtime_usage:0 power/runtime_status:unsupported power/async:disabled power/runtime_suspended_time:0 power/runtime_enabled:disabled power/control:auto subsystem/drivers_autoprobe:1 uevent:MAJOR=244 uevent:MINOR=1 uevent:DEVNAME=fw1 units:0x00a02d:0x010001 vendor:0x002327 vendor_name:ToneWeal fw1.0/uevent:MODALIAS=ieee1394:ven00002327mo00020002sp0000A02Dver00010001 fw1.0/power/runtime_active_time:0 fw1.0/power/runtime_active_kids:0 fw1.0/power/runtime_usage:0 fw1.0/power/runtime_status:unsupported fw1.0/power/async:disabled fw1.0/power/runtime_suspended_time:0 fw1.0/power/runtime_enabled:disabled fw1.0/power/control:auto fw1.0/model:0x020002 fw1.0/rom_index:15 fw1.0/specifier_id:0x00a02d fw1.0/model_name:FW66 fw1.0/version:0x010001 fw1.0/modalias:ieee1394:ven00002327mo00020002sp0000A02Dver00010001
Cc: Daniel Jozsef <[email protected]>
Reference: https://lore.kernel.org/alsa-devel/20200119164335.GA11974@workstation/
--- sound/firewire/Kconfig | 1 + sound/firewire/bebob/bebob.c | 3 +++ 2 files changed, 4 insertions(+)
sound/firewire/Kconfig +1 -0
@@ -110,6 +110,7 @@ config SND_BEBOB * M-Audio Ozonic/NRV10/ProfireLightBridge * M-Audio FireWire 1814/ProjectMix IO * Digidesign Mbox 2 Pro + * ToneWeal FW66 To compile this driver as a module, choose M here: the module will be called snd-bebob.
sound/firewire/bebob/bebob.c +3 -0
@@ -59,6 +59,7 @@ static DECLARE_BITMAP(devices_used, SNDRV_CARDS);#define VEN_MAUDIO1 0x00000d6c#define VEN_MAUDIO2 0x000007f5#define VEN_DIGIDESIGN 0x00a07e +#define OUI_SHOUYO 0x002327#define MODEL_FOCUSRITE_SAFFIRE_BOTH 0x00000000#define MODEL_MAUDIO_AUDIOPHILE_BOTH 0x00010060
@@ -486,6 +487,8 @@ static const struct ieee1394_device_id bebob_id_table[] = { &maudio_special_spec),/* Digidesign Mbox 2 Pro */ SND_BEBOB_DEV_ENTRY (VEN_DIGIDESIGN ,0x0000a9 , &spec_normal), +// Toneweal FW66. + SND_BEBOB_DEV_ENTRY(OUI_SHOUYO, 0x020002, &spec_normal),/* IDs are unknown but able to be supported */ /* Apogee, Mini-ME Firewire */ /* Apogee, Mini-DAC Firewire */
Signature · 1 line
2.30.2
Greg Kroah-Hartman
maintainerPATCH 112/292 m68knommu: fix missing LCD splash screen data initializer
In reply to Greg Kroah-HartmanFrom: Greg Ungerer <[email protected]>
[ Upstream commit 3f605ee17f8e785ba6ff69bee8e584e377a3cf28 ]
The kernel test robot reports that the "screen_bits" splash screen data is missing for the dragen platform:
arch/m68k/68000/dragen2.c:73:16: error: 'screen_bits' undeclared (first use in this function)
73 | LSSA = (long) screen_bits;
| ^~~~~~~~~~~
arch/m68k/68000/dragen2.c:73:16: note: each undeclared identifier is reported only once for each function it appears inDigging around a bit I found the screen_bits data structure was originally in a screen.h file that was generated from a screen.xbm file. That was removed in commit 0c0e6db80683 ("m68k: drop unused parts of 68VZ328 Makefile").
Other splash screen initializers for 68000 targets are kept here as the C data structures so lets do the same for this one. Add the missing screen.h file and include it in the dragen specific startup code.
--- arch/m68k/68000/dragen2.c | 1 + arch/m68k/68000/screen.h | 804 ++++++++++++++++++++++++++++++++++++++ 2 files changed, 805 insertions(+) create mode 100644 arch/m68k/68000/screen.h
arch/m68k/68000/dragen2.c +1 -0
@@ -11,6 +11,7 @@#include <linux/init.h> #include <asm/machdep.h> #include <asm/MC68VZ328.h> +#include "screen.h" /***************************************************************************/ /* Init Drangon Engine hardware */
arch/m68k/68000/screen.h new file +804 -0
804 lines not on this page · raw message
Signature · 1 line
2.30.2
Greg Kroah-Hartman
maintainerPATCH 113/292 ALSA: usb-audio: scarlett2: Fix 18i8 Gen 2 PCM Input count
In reply to Greg Kroah-HartmanFrom: Geoffrey D. Bennett <[email protected]>
[ Upstream commit c5210f213456383482b4a77c5310282a89a106b5 ]
The 18i8 Gen 2 has 8 PCM Inputs, not 20. Fix the ports entry in s18i8_gen2_info.
--- sound/usb/mixer_scarlett_gen2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
sound/usb/mixer_scarlett_gen2.c +1 -1
@@ -356,7 +356,7 @@ static const struct scarlett2_device_info s18i8_gen2_info = { }, [SCARLETT2_PORT_TYPE_PCM] = { .id = 0x600, - .num = { 20, 18, 18, 14, 10 }, + .num = { 8, 18, 18, 14, 10 }, .src_descr = "PCM %d", .src_num_offset = 1, .dst_descr = "PCM %02d Capture"
Signature · 1 line
2.30.2
Greg Kroah-Hartman
maintainerPATCH 114/292 ALSA: usb-audio: scarlett2: Fix data_mutex lock
In reply to Greg Kroah-HartmanFrom: Geoffrey D. Bennett <[email protected]>
[ Upstream commit 9b5ddea9ce5a68d7d2bedcb69901ac2a86c96c7b ]
The private->vol_updated flag was being checked outside of the mutex_lock/unlock() of private->data_mutex leading to the volume data being fetched twice from the device unnecessarily or old volume data being returned.
Update scarlett2_*_ctl_get() and include the private->vol_updated flag check inside the critical region.
--- sound/usb/mixer_scarlett_gen2.c | 21 +++++++++------------ 1 file changed, 9 insertions(+), 12 deletions(-)
sound/usb/mixer_scarlett_gen2.c +9 -12
@@ -1033,11 +1033,10 @@ static int scarlett2_master_volume_ctl_get(struct snd_kcontrol *kctl,struct usb_mixer_interface *mixer = elem->head.mixer;struct scarlett2_mixer_data *private = mixer->private_data; -if (private->vol_updated) { -mutex_lock (&private->data_mutex); +mutex_lock (&private->data_mutex); +if (private->vol_updated)scarlett2_update_volumes (mixer); -mutex_unlock (&private->data_mutex); - } +mutex_unlock (&private->data_mutex); ucontrol->value.integer.value[0 ] = private->master_vol;return 0 ;
@@ -1051,11 +1050,10 @@ static int scarlett2_volume_ctl_get(struct snd_kcontrol *kctl,struct scarlett2_mixer_data *private = mixer->private_data;int index = elem->control; -if (private->vol_updated) { -mutex_lock (&private->data_mutex); +mutex_lock (&private->data_mutex); +if (private->vol_updated)scarlett2_update_volumes (mixer); -mutex_unlock (&private->data_mutex); - } +mutex_unlock (&private->data_mutex); ucontrol->value.integer.value[0 ] = private->vol[index];return 0 ;
@@ -1319,11 +1317,10 @@ static int scarlett2_button_ctl_get(struct snd_kcontrol *kctl,struct usb_mixer_interface *mixer = elem->head.mixer;struct scarlett2_mixer_data *private = mixer->private_data; -if (private->vol_updated) { -mutex_lock (&private->data_mutex); +mutex_lock (&private->data_mutex); +if (private->vol_updated)scarlett2_update_volumes (mixer); -mutex_unlock (&private->data_mutex); - } +mutex_unlock (&private->data_mutex); ucontrol->value.enumerated.item[0 ] = private->buttons[elem->control];return 0 ;
Signature · 1 line
2.30.2
Greg Kroah-Hartman
maintainerPATCH 115/292 ALSA: usb-audio: scarlett2: Fix scarlett2_*_ctl_put() return values
In reply to Greg Kroah-HartmanFrom: Geoffrey D. Bennett <[email protected]>
[ Upstream commit c5d8e008032f3cd5f266d552732973a960b0bd4b ]
Mixer control put callbacks should return 1 if the value is changed. Fix the sw_hw, level, pad, and button controls accordingly.
--- sound/usb/mixer_scarlett_gen2.c | 8 ++++++++ 1 file changed, 8 insertions(+)
sound/usb/mixer_scarlett_gen2.c +8 -0
@@ -1184,6 +1184,8 @@ static int scarlett2_sw_hw_enum_ctl_put(struct snd_kcontrol *kctl,/* Send SW/HW switch change to the device */ err =scarlett2_usb_set_config (mixer,SCARLETT2_CONFIG_SW_HW_SWITCH , index, val); +if (err ==0 ) + err =1 ; unlock:mutex_unlock (&private->data_mutex);
@@ -1244,6 +1246,8 @@ static int scarlett2_level_enum_ctl_put(struct snd_kcontrol *kctl,/* Send switch change to the device */ err =scarlett2_usb_set_config (mixer,SCARLETT2_CONFIG_LEVEL_SWITCH , index, val); +if (err ==0 ) + err =1 ; unlock:mutex_unlock (&private->data_mutex);
@@ -1294,6 +1298,8 @@ static int scarlett2_pad_ctl_put(struct snd_kcontrol *kctl,/* Send switch change to the device */ err =scarlett2_usb_set_config (mixer,SCARLETT2_CONFIG_PAD_SWITCH , index, val); +if (err ==0 ) + err =1 ; unlock:mutex_unlock (&private->data_mutex);
@@ -1349,6 +1355,8 @@ static int scarlett2_button_ctl_put(struct snd_kcontrol *kctl,/* Send switch change to the device */ err =scarlett2_usb_set_config (mixer,SCARLETT2_CONFIG_BUTTONS , index, val); +if (err ==0 ) + err =1 ; unlock:mutex_unlock (&private->data_mutex);
Signature · 1 line
2.30.2
Greg Kroah-Hartman
maintainerPATCH 116/292 usb: gadget: f_hid: fix endianness issue with descriptors
In reply to Greg Kroah-HartmanFrom: Ruslan Bilovol <[email protected]>
[ Upstream commit 33cb46c4676d01956811b68a29157ea969a5df70 ]
Running sparse checker it shows warning message about incorrect endianness used for descriptor initialization:
| f_hid.c:91:43: warning: incorrect type in initializer (different base types) | f_hid.c:91:43: expected restricted __le16 [usertype] bcdHID | f_hid.c:91:43: got int
Fixing issue with cpu_to_le16() macro, however this is not a real issue as the value is the same both endians.
--- drivers/usb/gadget/function/f_hid.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/usb/gadget/function/f_hid.c +1 -1
@@ -88,7 +88,7 @@ static struct usb_interface_descriptor hidg_interface_desc = {static struct hid_descriptor hidg_desc = { .bLength =sizeof hidg_desc, .bDescriptorType =HID_DT_HID , - .bcdHID =0x0101 , + .bcdHID =cpu_to_le16 (0x0101 ), .bCountryCode =0x00 , .bNumDescriptors =0x1 ,/*.desc[0].bDescriptorType = DYNAMIC */
Signature · 1 line
2.30.2
Greg Kroah-Hartman
maintainerPATCH 117/292 usb: gadget: hid: fix error return code in hid_bind()
In reply to Greg Kroah-HartmanFrom: Yang Yingliang <[email protected]>
[ Upstream commit 88693f770bb09c196b1eb5f06a484a254ecb9924 ]
Fix to return a negative error code from the error handling case instead of 0.
--- drivers/usb/gadget/legacy/hid.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/usb/gadget/legacy/hid.c +3 -1
@@ -171,8 +171,10 @@ static int hid_bind(struct usb_composite_dev *cdev)struct usb_descriptor_header *usb_desc; usb_desc =usb_otg_descriptor_alloc (gadget); -if (!usb_desc) +if (!usb_desc) { + status = -ENOMEM ; goto put; + }usb_otg_descriptor_init (gadget, usb_desc); otg_desc[0 ] = usb_desc; otg_desc[1 ] =NULL ;
Signature · 1 line
2.30.2
Greg Kroah-Hartman
maintainerPATCH 118/292 powerpc/boot: Fixup device-tree on little endian
In reply to Greg Kroah-HartmanFrom: Benjamin Herrenschmidt <[email protected]>
[ Upstream commit c93f80849bdd9b45d834053ae1336e28f0026c84 ]
This fixes the core devtree.c functions and the ns16550 UART backend.
--- arch/powerpc/boot/devtree.c | 59 +++++++++++++++++++++---------------- arch/powerpc/boot/ns16550.c | 9 ++++-- 2 files changed, 41 insertions(+), 27 deletions(-)
arch/powerpc/boot/devtree.c +34 -25
@@ -13,6 +13,7 @@#include "string.h" #include "stdio.h" #include "ops.h" +#include "of.h" void dt_fixup_memory (u64 start,u64 size) {
@@ -23,21 +24,25 @@ void dt_fixup_memory(u64 start, u64 size) root =finddevice ("/" );if (getprop (root,"#address-cells" , &naddr,sizeof (naddr)) <0 ) naddr =2 ; +else + naddr =be32_to_cpu (naddr);if (naddr <1 || naddr >2 )fatal ("Can't cope with #address-cells == %d in /\n\r" , naddr);if (getprop (root,"#size-cells" , &nsize,sizeof (nsize)) <0 ) nsize =1 ; +else + nsize =be32_to_cpu (nsize);if (nsize <1 || nsize >2 )fatal ("Can't cope with #size-cells == %d in /\n\r" , nsize); i =0 ;if (naddr ==2 ) - memreg[i++] = start >>32 ; - memreg[i++] = start &0xffffffff ; + memreg[i++] =cpu_to_be32 (start >>32 ); + memreg[i++] =cpu_to_be32 (start &0xffffffff );if (nsize ==2 ) - memreg[i++] = size >>32 ; - memreg[i++] = size &0xffffffff ; + memreg[i++] =cpu_to_be32 (size >>32 ); + memreg[i++] =cpu_to_be32 (size &0xffffffff ); memory =finddevice ("/memory" );if (! memory) {
@@ -45,9 +50,9 @@ void dt_fixup_memory(u64 start, u64 size)setprop_str (memory,"device_type" ,"memory" ); } -printf ("Memory <- <0x%x" , memreg[0 ]); +printf ("Memory <- <0x%x" ,be32_to_cpu (memreg[0 ]));for (i =1 ; i < (naddr + nsize); i++) -printf (" 0x%x" , memreg[i]); +printf (" 0x%x" ,be32_to_cpu (memreg[i]));printf ("> (%ldMB)\n\r" , (unsigned long )(size >>20 ));setprop (memory,"reg" , memreg, (naddr + nsize)*sizeof (u32));
@@ -65,10 +70,10 @@ void dt_fixup_cpu_clocks(u32 cpu, u32 tb, u32 bus)printf ("CPU bus-frequency <- 0x%x (%dMHz)\n\r" , bus,MHZ (bus));while ((devp =find_node_by_devtype (devp,"cpu" ))) { -setprop_val (devp,"clock-frequency" , cpu); -setprop_val (devp,"timebase-frequency" , tb); +setprop_val (devp,"clock-frequency" ,cpu_to_be32 (cpu)); +setprop_val (devp,"timebase-frequency" ,cpu_to_be32 (tb));if (bus >0 ) -setprop_val (devp,"bus-frequency" , bus); +setprop_val (devp,"bus-frequency" ,cpu_to_be32 (bus)); } timebase_period_ns =1000000000 / tb;
@@ -80,7 +85,7 @@ void dt_fixup_clock(const char *path, u32 freq)if (devp) {printf ("%s: clock-frequency <- %x (%dMHz)\n\r" , path, freq,MHZ (freq)); -setprop_val (devp,"clock-frequency" , freq); +setprop_val (devp,"clock-frequency" ,cpu_to_be32 (freq)); } }
@@ -133,8 +138,12 @@ void dt_get_reg_format(void *node, u32 *naddr, u32 *nsize) {if (getprop (node,"#address-cells" , naddr,4 ) !=4 ) *naddr =2 ; +else + *naddr =be32_to_cpu (*naddr);if (getprop (node,"#size-cells" , nsize,4 ) !=4 ) *nsize =1 ; +else + *nsize =be32_to_cpu (*nsize); }static void copy_val (u32 *dest,u32 *src,int naddr)
@@ -163,9 +172,9 @@ static int add_reg(u32 *reg, u32 *add, int naddr)int i, carry =0 ;for (i =MAX_ADDR_CELLS -1 ; i >=MAX_ADDR_CELLS - naddr; i--) { -u64 tmp = (u64 )reg[i] + add[i] + carry; +u64 tmp = (u64 )be32_to_cpu (reg[i]) +be32_to_cpu (add[i]) + carry; carry = tmp >>32 ; - reg[i] = (u32 )tmp; + reg[i] =cpu_to_be32 ((u32 )tmp); }return !carry;
@@ -180,18 +189,18 @@ static int compare_reg(u32 *reg, u32 *range, u32 *rangesize)u32 end;for (i =0 ; i <MAX_ADDR_CELLS ; i++) { -if (reg[i] < range[i]) +if (be32_to_cpu (reg[i]) <be32_to_cpu (range[i]))return 0 ; -if (reg[i] > range[i]) +if (be32_to_cpu (reg[i]) >be32_to_cpu (range[i]))break ; }for (i =0 ; i <MAX_ADDR_CELLS ; i++) { - end = range[i] + rangesize[i]; + end =be32_to_cpu (range[i]) +be32_to_cpu (rangesize[i]); -if (reg[i] < end) +if (be32_to_cpu (reg[i]) < end)break ; -if (reg[i] > end) +if (be32_to_cpu (reg[i]) > end)return 0 ; }
@@ -240,7 +249,6 @@ static int dt_xlate(void *node, int res, int reglen, unsigned long *addr,return 0 ;dt_get_reg_format (parent, &naddr, &nsize); -if (nsize >2 )return 0 ;
@@ -252,10 +260,10 @@ static int dt_xlate(void *node, int res, int reglen, unsigned long *addr,copy_val (last_addr, prop_buf + offset, naddr); - ret_size = prop_buf[offset + naddr]; + ret_size =be32_to_cpu (prop_buf[offset + naddr]);if (nsize ==2 ) { ret_size <<=32 ; - ret_size |= prop_buf[offset + naddr +1 ]; + ret_size |=be32_to_cpu (prop_buf[offset + naddr +1 ]); }for (;;) {
@@ -278,7 +286,6 @@ static int dt_xlate(void *node, int res, int reglen, unsigned long *addr, offset =find_range (last_addr, prop_buf, prev_naddr, naddr, prev_nsize, buflen /4 ); -if (offset <0 )return 0 ;
@@ -296,8 +303,7 @@ static int dt_xlate(void *node, int res, int reglen, unsigned long *addr,if (naddr >2 )return 0 ; - ret_addr = ((u64 )last_addr[2 ] <<32 ) | last_addr[3 ]; - + ret_addr = ((u64 )be32_to_cpu (last_addr[2 ]) <<32 ) |be32_to_cpu (last_addr[3 ]);if (sizeof (void *) ==4 && (ret_addr >=0x100000000ULL || ret_size >0x100000000ULL || ret_addr + ret_size >0x100000000ULL ))
@@ -350,11 +356,14 @@ int dt_is_compatible(void *node, const char *compat)int dt_get_virtual_reg (void *node,void **addr,int nres) {unsigned long xaddr; -int n; +int n, i; n =getprop (node,"virtual-reg" , addr, nres *4 ); -if (n >0 ) +if (n >0 ) { +for (i =0 ; i < n/4 ; i ++) + ((u32 *)addr)[i] =be32_to_cpu (((u32 *)addr)[i]);return n /4 ; + }for (n =0 ; n < nres; n++) {if (!dt_xlate_reg (node, n, &xaddr,NULL ))
arch/powerpc/boot/ns16550.c +7 -2
@@ -15,6 +15,7 @@#include "stdio.h" #include "io.h" #include "ops.h" +#include "of.h" #define UART_DLL 0/* Out: Divisor Latch Low */ #define UART_DLM 1/* Out: Divisor Latch High */
@@ -58,16 +59,20 @@ int ns16550_console_init(void *devp, struct serial_console_data *scdp)int n;u32 reg_offset; -if (dt_get_virtual_reg (devp, (void **)®_base,1 ) <1 ) +if (dt_get_virtual_reg (devp, (void **)®_base,1 ) <1 ) { +printf ("virt reg parse fail...\r\n" );return -1 ; + } n =getprop (devp,"reg-offset" , ®_offset,sizeof (reg_offset));if (n ==sizeof (reg_offset)) - reg_base += reg_offset; + reg_base +=be32_to_cpu (reg_offset); n =getprop (devp,"reg-shift" , ®_shift,sizeof (reg_shift));if (n !=sizeof (reg_shift)) reg_shift =0 ; +else + reg_shift =be32_to_cpu (reg_shift); scdp->open = ns16550_open; scdp->putc = ns16550_putc;
Signature · 1 line
2.30.2
Greg Kroah-Hartman
maintainerPATCH 119/292 ASoC: fsl_xcvr: check return value after calling platform_get_resource_byname()
In reply to Greg Kroah-HartmanFrom: Yang Yingliang <[email protected]>
[ Upstream commit a2f6ed4a44721d3a9fdf4da7e0743cb13866bf61 ]
It will cause null-ptr-deref if platform_get_resource_byname() returns NULL, we need check the return value.
--- sound/soc/fsl/fsl_xcvr.c | 4 ++++ 1 file changed, 4 insertions(+)
sound/soc/fsl/fsl_xcvr.c +4 -0
@@ -1205,6 +1205,10 @@ static int fsl_xcvr_probe(struct platform_device *pdev) rx_res =platform_get_resource_byname (pdev,IORESOURCE_MEM ,"rxfifo" ); tx_res =platform_get_resource_byname (pdev,IORESOURCE_MEM ,"txfifo" ); +if (!rx_res || !tx_res) { +dev_err (dev,"could not find rxfifo or txfifo resource\n" ); +return -EINVAL ; + } xcvr->dma_prms_rx.chan_name ="rx" ; xcvr->dma_prms_tx.chan_name ="tx" ; xcvr->dma_prms_rx.addr = rx_res->start;
Signature · 1 line
2.30.2
Greg Kroah-Hartman
maintainerPATCH 120/292 ASoC: Intel: kbl_da7219_max98357a: shrink platform_id below 20 characters
In reply to Greg Kroah-HartmanFrom: Pierre-Louis Bossart <[email protected]>
[ Upstream commit 94efd726b947f265bd313605c9f73edec5469d65 ]
Sparse throws the following warnings:
sound/soc/intel/boards/kbl_da7219_max98357a.c:647:25: error: too long initializer-string for array of char(no space for nul char)
Fix by using the 'mx' acronym for Maxim.
--- sound/soc/intel/boards/kbl_da7219_max98357a.c | 4 ++-- sound/soc/intel/common/soc-acpi-intel-kbl-match.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-)
sound/soc/intel/boards/kbl_da7219_max98357a.c +2 -2
@@ -594,7 +594,7 @@ static int kabylake_audio_probe(struct platform_device *pdev)static const struct platform_device_id kbl_board_ids[] = { { - .name ="kbl_da7219_max98357a" , + .name ="kbl_da7219_mx98357a" , .driver_data = (kernel_ulong_t)&kabylake_audio_card_da7219_m98357a, },
@@ -616,4 +616,4 @@ module_platform_driver(kabylake_audio)MODULE_DESCRIPTION ("Audio Machine driver-DA7219 & MAX98357A in I2S mode" );MODULE_AUTHOR ("Naveen Manohar <[email protected]>" );MODULE_LICENSE ("GPL v2" ); -MODULE_ALIAS ("platform:kbl_da7219_max98357a" ); +MODULE_ALIAS ("platform:kbl_da7219_mx98357a" );
sound/soc/intel/common/soc-acpi-intel-kbl-match.c +1 -1
@@ -113,7 +113,7 @@ struct snd_soc_acpi_mach snd_soc_acpi_intel_kbl_machines[] = { }, { .id = "DLGS7219", - .drv_name = "kbl_da7219_max98373", + .drv_name = "kbl_da7219_mx98373", .fw_filename = "intel/dsp_fw_kbl.bin", .machine_quirk = snd_soc_acpi_codec_list, .quirk_data = &kbl_7219_98373_codecs,
Signature · 1 line
2.30.2
Greg Kroah-Hartman
maintainerPATCH 121/292 backlight: lm3630a: Fix return code of .update_status() callback
In reply to Greg Kroah-HartmanFrom: Uwe Kleine-König <[email protected]>
[ Upstream commit b9481a667a90ec739995e85f91f3672ca44d6ffa ]
According to <linux/backlight.h> .update_status() is supposed to return 0 on success and a negative error code otherwise. Adapt lm3630a_bank_a_update_status() and lm3630a_bank_b_update_status() to actually do it.
While touching that also add the error code to the failure message.
--- drivers/video/backlight/lm3630a_bl.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)
drivers/video/backlight/lm3630a_bl.c +6 -6
@@ -190,7 +190,7 @@ static int lm3630a_bank_a_update_status(struct backlight_device *bl)if ((pwm_ctrl &LM3630A_PWM_BANK_A ) !=0 ) {lm3630a_pwm_ctrl (pchip, bl->props.brightness, bl->props.max_brightness); -return bl->props.brightness; +return 0 ; }/* disable sleep */
@@ -210,8 +210,8 @@ static int lm3630a_bank_a_update_status(struct backlight_device *bl)return 0 ; out_i2c_err: -dev_err (pchip->dev,"i2c failed to access\n" ); -return bl->props.brightness; +dev_err (pchip->dev,"i2c failed to access (%pe)\n" ,ERR_PTR (ret)); +return ret; }static int lm3630a_bank_a_get_brightness (struct backlight_device *bl)
@@ -267,7 +267,7 @@ static int lm3630a_bank_b_update_status(struct backlight_device *bl)if ((pwm_ctrl &LM3630A_PWM_BANK_B ) !=0 ) {lm3630a_pwm_ctrl (pchip, bl->props.brightness, bl->props.max_brightness); -return bl->props.brightness; +return 0 ; }/* disable sleep */
@@ -287,8 +287,8 @@ static int lm3630a_bank_b_update_status(struct backlight_device *bl)return 0 ; out_i2c_err: -dev_err (pchip->dev,"i2c failed to access REG_CTRL\n" ); -return bl->props.brightness; +dev_err (pchip->dev,"i2c failed to access (%pe)\n" ,ERR_PTR (ret)); +return ret; }static int lm3630a_bank_b_get_brightness (struct backlight_device *bl)
Signature · 1 line
2.30.2
Greg Kroah-Hartman
maintainerPATCH 122/292 ALSA: hda: Add IRQ check for platform_get_irq()
In reply to Greg Kroah-HartmanFrom: Jiajun Cao <[email protected]>
[ Upstream commit 8c13212443230d03ff25014514ec0d53498c0912 ]
The function hda_tegra_first_init() neglects to check the return value after executing platform_get_irq().
hda_tegra_first_init() should check the return value (if negative error number) for errors so as to not pass a negative value to the devm_request_irq().
Fix it by adding a check for the return value irq_id.
--- sound/pci/hda/hda_tegra.c | 3 +++ 1 file changed, 3 insertions(+)
sound/pci/hda/hda_tegra.c +3 -0
@@ -262,6 +262,9 @@ static int hda_tegra_first_init(struct azx *chip, struct platform_device *pdev)const char *sname, *drv_name ="tegra-hda" ;struct device_node *np = pdev->dev.of_node; +if (irq_id <0 ) +return irq_id; + err =hda_tegra_init_chip (chip, pdev);if (err)return err;
Signature · 1 line
2.30.2
Greg Kroah-Hartman
maintainerPATCH 123/292 ALSA: usb-audio: scarlett2: Fix 6i6 Gen 2 line out descriptions
In reply to Greg Kroah-HartmanFrom: Geoffrey D. Bennett <[email protected]>
[ Upstream commit c712c6c0ff2d60478582e337185bcdd520a7dc2e ]
There are two headphone outputs, and they map to the four analogue outputs.
--- sound/usb/mixer_scarlett_gen2.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
sound/usb/mixer_scarlett_gen2.c +4 -4
@@ -254,10 +254,10 @@ static const struct scarlett2_device_info s6i6_gen2_info = { .pad_input_count = 2, .line_out_descrs = { -"Monitor L" , -"Monitor R" , -"Headphones L" , - "Headphones R", +"Headphones 1 L" , +"Headphones 1 R" , +"Headphones 2 L" , + "Headphones 2 R", }, .ports = {
Signature · 1 line
2.30.2
Greg Kroah-Hartman
maintainerPATCH 124/292 ALSA: firewire-motu: fix detection for S/PDIF source on optical interface in v2 protocol
In reply to Greg Kroah-HartmanFrom: Takashi Sakamoto <[email protected]>
[ Upstream commit fa4db23233eb912234bdfb0b26a38be079c6b5ea ]
The devices in protocol version 2 has a register with flag for IEC 60958 signal detection as source of sampling clock without discrimination between coaxial and optical interfaces. On the other hand, current implementation of driver manage to interpret type of signal on optical interface instead.
This commit fixes the detection of optical/coaxial interface for S/PDIF signal.
--- sound/firewire/motu/motu-protocol-v2.c | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-)
sound/firewire/motu/motu-protocol-v2.c +6 -7
@@ -86,24 +86,23 @@ static int detect_clock_source_optical_model(struct snd_motu *motu, u32 data, *src =SND_MOTU_CLOCK_SOURCE_INTERNAL ;break ;case 1 : + *src =SND_MOTU_CLOCK_SOURCE_ADAT_ON_OPT ; +break ; +case 2 : {__be32 reg;// To check the configuration of optical interface. -int err =snd_motu_transaction_read (motu,V2_IN_OUT_CONF_OFFSET , - ®,sizeof (reg)); +int err =snd_motu_transaction_read (motu,V2_IN_OUT_CONF_OFFSET , ®,sizeof (reg));if (err <0 )return err; -if (be32_to_cpu (reg) &0x00000200 ) +if (((data &V2_OPT_IN_IFACE_MASK ) >>V2_OPT_IN_IFACE_SHIFT ) ==V2_OPT_IFACE_MODE_SPDIF ) *src =SND_MOTU_CLOCK_SOURCE_SPDIF_ON_OPT ;else - *src =SND_MOTU_CLOCK_SOURCE_ADAT_ON_OPT ; + *src =SND_MOTU_CLOCK_SOURCE_SPDIF_ON_COAX ;break ; } -case 2 : - *src =SND_MOTU_CLOCK_SOURCE_SPDIF_ON_COAX ; -break ;case 3 : *src =SND_MOTU_CLOCK_SOURCE_SPH ;break ;
Signature · 1 line
2.30.2
Greg Kroah-Hartman
maintainerPATCH 125/292 leds: turris-omnia: add missing MODULE_DEVICE_TABLE
In reply to Greg Kroah-HartmanFrom: Zou Wei <[email protected]>
[ Upstream commit 9d0150db97583cfbb6b44cbe02241a1a48f90210 ]
This patch adds missing MODULE_DEVICE_TABLE definition which generates correct modalias for automatic loading of this driver when it is built as an external module.
--- drivers/leds/leds-turris-omnia.c | 1 + 1 file changed, 1 insertion(+)
drivers/leds/leds-turris-omnia.c +1 -0
@@ -274,6 +274,7 @@ static const struct i2c_device_id omnia_id[] = { { "omnia", 0 }, { } }; +MODULE_DEVICE_TABLE (i2c, omnia_id);static struct i2c_driver omnia_leds_driver = { .probe = omnia_leds_probe,
Signature · 1 line
2.30.2
Greg Kroah-Hartman
maintainerPATCH 126/292 staging: rtl8723bs: fix macro value for 2.4Ghz only device
In reply to Greg Kroah-HartmanFrom: Fabio Aiuto <[email protected]>
[ Upstream commit 6d490a27e23c5fb79b766530016ab8665169498e ]
fix IQK_Matrix_Settings_NUM macro value to 14 which is the max channel number value allowed in a 2.4Ghz device.
--- drivers/staging/rtl8723bs/hal/odm.h | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)
drivers/staging/rtl8723bs/hal/odm.h +1 -4
@@ -197,10 +197,7 @@ typedef struct _ODM_RATE_ADAPTIVE {#define AVG_THERMAL_NUM 8#define IQK_Matrix_REG_NUM 8 -#define IQK_Matrix_Settings_NUM (14 + 24 + 21)/* Channels_2_4G_NUM -* + Channels_5G_20M_NUM -* + Channels_5G -*/ +#define IQK_Matrix_Settings_NUM 14/* Channels_2_4G_NUM */ #define DM_Type_ByFW 0#define DM_Type_ByDriver 1
Signature · 1 line
2.30.2
Greg Kroah-Hartman
maintainerPATCH 127/292 intel_th: Wait until port is in reset before programming it
In reply to Greg Kroah-HartmanFrom: Alexander Shishkin <[email protected]>
[ Upstream commit ab1afed701d2db7eb35c1a2526a29067a38e93d1 ]
Some devices don't drain their pipelines if we don't make sure that the corresponding output port is in reset before programming it for a new trace capture, resulting in bits of old trace appearing in the new trace capture. Fix that by explicitly making sure the reset is asserted before programming new trace capture.
--- drivers/hwtracing/intel_th/core.c | 17 +++++++++++++++++ drivers/hwtracing/intel_th/gth.c | 16 ++++++++++++++++ drivers/hwtracing/intel_th/intel_th.h | 3 +++ 3 files changed, 36 insertions(+)
drivers/hwtracing/intel_th/core.c +17 -0
@@ -215,6 +215,22 @@ static ssize_t port_show(struct device *dev, struct device_attribute *attr,static DEVICE_ATTR_RO (port); +static void intel_th_trace_prepare (struct intel_th_device *thdev) +{ +struct intel_th_device *hub =to_intel_th_hub (thdev); +struct intel_th_driver *hubdrv =to_intel_th_driver (hub->dev.driver); + +if (hub->type !=INTEL_TH_SWITCH ) +return ; + +if (thdev->type !=INTEL_TH_OUTPUT ) +return ; + +pm_runtime_get_sync (&thdev->dev); + hubdrv->prepare (hub, &thdev->output); +pm_runtime_put (&thdev->dev); +} +static int intel_th_output_activate (struct intel_th_device *thdev) { struct intel_th_driver *thdrv =
@@ -235,6 +251,7 @@ static int intel_th_output_activate(struct intel_th_device *thdev)if (ret) goto fail_put; +intel_th_trace_prepare (thdev);if (thdrv->activate) ret = thdrv->activate (thdev);else
drivers/hwtracing/intel_th/gth.c +16 -0
@@ -564,6 +564,21 @@ static void gth_tscu_resync(struct gth_device *gth)iowrite32 (reg, gth->base +REG_TSCU_TSUCTRL ); } +static void intel_th_gth_prepare (struct intel_th_device *thdev, +struct intel_th_output *output) +{ +struct gth_device *gth =dev_get_drvdata (&thdev->dev); +int count; + +/* +* Wait until the output port is in reset before we start +* programming it. +*/ +for (count =GTH_PLE_WAITLOOP_DEPTH ; + count && !(gth_output_get (gth, output->port) &BIT (5 )); count--) +cpu_relax (); +} +/** * intel_th_gth_enable() - enable tracing to an output device * @thdev: GTH device
@@ -815,6 +830,7 @@ static struct intel_th_driver intel_th_gth_driver = { .assign = intel_th_gth_assign, .unassign = intel_th_gth_unassign, .set_output = intel_th_gth_set_output, + .prepare = intel_th_gth_prepare, .enable = intel_th_gth_enable, .trig_switch = intel_th_gth_switch, .disable = intel_th_gth_disable,
drivers/hwtracing/intel_th/intel_th.h +3 -0
@@ -143,6 +143,7 @@ intel_th_output_assigned(struct intel_th_device *thdev)* @remove: remove method * @assign: match a given output type device against available outputs * @unassign: deassociate an output type device from an output port +* @prepare: prepare output port for tracing * @enable: enable tracing for a given output device * @disable: disable tracing for a given output device * @irq: interrupt callback
@@ -164,6 +165,8 @@ struct intel_th_driver { struct intel_th_device *othdev);void (*unassign)(struct intel_th_device *thdev,struct intel_th_device *othdev); +void (*prepare)(struct intel_th_device *thdev, +struct intel_th_output *output);void (*enable)(struct intel_th_device *thdev,struct intel_th_output *output); void (*trig_switch)(struct intel_th_device *thdev,
Signature · 1 line
2.30.2
Greg Kroah-Hartman
maintainerPATCH 128/292 i2c: core: Disable client irq on reboot/shutdown
In reply to Greg Kroah-HartmanFrom: Dmitry Torokhov <[email protected]>
[ Upstream commit b64210f2f7c11c757432ba3701d88241b2b98fb1 ]
If an i2c client receives an interrupt during reboot or shutdown it may be too late to service it by making an i2c transaction on the bus because the i2c controller has already been shutdown. This can lead to system hangs if the i2c controller tries to make a transfer that is doomed to fail because the access to the i2c pins is already shut down, or an iommu translation has been torn down so i2c controller register access doesn't work.
Let's simply disable the irq if there isn't a shutdown callback for an i2c client when there is an irq associated with the device. This will make sure that irqs don't come in later than the time that we can handle it. We don't do this if the i2c client device already has a shutdown callback because presumably they're doing the right thing and quieting the device so irqs don't come in after the shutdown callback returns.
[[email protected]: Dropped newline, added commit text, added interrupt.h for robot build error]
--- drivers/i2c/i2c-core-base.c | 3 +++ 1 file changed, 3 insertions(+)
drivers/i2c/i2c-core-base.c +3 -0
@@ -24,6 +24,7 @@#include <linux/i2c-smbus.h> #include <linux/idr.h> #include <linux/init.h> +#include <linux/interrupt.h> #include <linux/irqflags.h> #include <linux/jump_label.h> #include <linux/kernel.h>
@@ -587,6 +588,8 @@ static void i2c_device_shutdown(struct device *dev) driver =to_i2c_driver (dev->driver);if (driver->shutdown) driver->shutdown (client); +else if (client->irq >0 ) +disable_irq (client->irq); }static void i2c_client_dev_release (struct device *dev)
Signature · 1 line
2.30.2
Greg Kroah-Hartman
maintainerPATCH 129/292 phy: intel: Fix for warnings due to EMMC clock 175Mhz change in FIP
In reply to Greg Kroah-HartmanFrom: Rashmi A <[email protected]>
[ Upstream commit 2f2b73a29d2aabf5ad0150856c3e5cb6e04dcfc1 ]
Since the EMMC clock was changed from 200Mhz to 175Mhz in FIP, there were some warnings introduced, as the frequency values being checked was still wrt 200Mhz in code. Hence, the frequency checks are now updated based on the current 175Mhz EMMC clock changed in FIP.
Spamming kernel log msg:
"phy phy-20290000.mmc_phy.2: Unsupported rate: 43750000"
--- drivers/phy/intel/phy-intel-keembay-emmc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/phy/intel/phy-intel-keembay-emmc.c +2 -1
@@ -95,7 +95,8 @@ static int keembay_emmc_phy_power(struct phy *phy, bool on_off)else freqsel =0x0 ; -if (mhz <50 || mhz >200 ) +/* Check for EMMC clock rate*/ +if (mhz >175 )dev_warn (&phy->dev,"Unsupported rate: %d MHz\n" , mhz);/*
Signature · 1 line
2.30.2
Greg Kroah-Hartman
maintainerPATCH 130/292 lib/decompress_unlz4.c: correctly handle zero-padding around initrds.
In reply to Greg Kroah-HartmanFrom: Dimitri John Ledkov <[email protected]>
[ Upstream commit 2c484419efc09e7234c667aa72698cb79ba8d8ed ]
lz4 compatible decompressor is simple. The format is underspecified and relies on EOF notification to determine when to stop. Initramfs buffer format[1] explicitly states that it can have arbitrary number of zero padding. Thus when operating without a fill function, be extra careful to ensure that sizes less than 4, or apperantly empty chunksizes are treated as EOF.
To test this I have created two cpio initrds, first a normal one, main.cpio. And second one with just a single /test-file with content "second" second.cpio. Then i compressed both of them with gzip, and with lz4 -l. Then I created a padding of 4 bytes (dd if=/dev/zero of=pad4 bs=1 count=4). To create four testcase initrds:
1) main.cpio.gzip + extra.cpio.gzip = pad0.gzip
2) main.cpio.lz4 + extra.cpio.lz4 = pad0.lz4
3) main.cpio.gzip + pad4 + extra.cpio.gzip = pad4.gzip
4) main.cpio.lz4 + pad4 + extra.cpio.lz4 = pad4.lz4
The pad4 test-cases replicate the initrd load by grub, as it pads and aligns every initrd it loads.
All of the above boot, however /test-file was not accessible in the initrd for the testcase #4, as decoding in lz4 decompressor failed. Also an error message printed which usually is harmless.
Whith a patched kernel, all of the above testcases now pass, and /test-file is accessible.
This fixes lz4 initrd decompress warning on every boot with grub. And more importantly this fixes inability to load multiple lz4 compressed initrds with grub. This patch has been shipping in Ubuntu kernels since January 2021.
[1] ./Documentation/driver-api/early-userspace/buffer-format.rst
--- lib/decompress_unlz4.c | 8 ++++++++ 1 file changed, 8 insertions(+)
lib/decompress_unlz4.c +8 -0
@@ -112,6 +112,9 @@ STATIC inline int INIT unlz4(u8 *input, long in_len,error ("data corrupted" ); goto exit_2; } + }else if (size <4 ) { +/* empty or end-of-file */ + goto exit_3; } chunksize =get_unaligned_le32 (inp);
@@ -125,6 +128,10 @@ STATIC inline int INIT unlz4(u8 *input, long in_len,continue ; } +if (!fill && chunksize ==0 ) { +/* empty or end-of-file */ + goto exit_3; + }if (posp) *posp +=4 ;
@@ -184,6 +191,7 @@ STATIC inline int INIT unlz4(u8 *input, long in_len, } } +exit_3: ret =0 ; exit_2:if (!input)
Signature · 1 line
2.30.2
Greg Kroah-Hartman
maintainerPATCH 131/292 kcov: add __no_sanitize_coverage to fix noinstr for all architectures
In reply to Greg Kroah-HartmanFrom: Marco Elver <[email protected]>
[ Upstream commit 540540d06e9d9b3769b46d88def90f7e7c002322 ]
Until now no compiler supported an attribute to disable coverage instrumentation as used by KCOV.
To work around this limitation on x86, noinstr functions have their coverage instrumentation turned into nops by objtool. However, this solution doesn't scale automatically to other architectures, such as arm64, which are migrating to use the generic entry code.
Clang [1] and GCC [2] have added support for the attribute recently.
[1] https://github.com/llvm/llvm-project/commit/280333021e9550d80f5c1152a34e33e81df1e178
[2] https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=cec4d4a6782c9bd8d071839c50a239c49caca689
The changes will appear in Clang 13 and GCC 12.
Add __no_sanitize_coverage for both compilers, and add it to noinstr.
Note: In the Clang case, __has_feature(coverage_sanitizer) is only true if the feature is enabled, and therefore we do not require an additional defined(CONFIG_KCOV) (like in the GCC case where __has_attribute(..) is always true) to avoid adding redundant attributes to functions if KCOV is off. That being said, compilers that support the attribute will not generate errors/warnings if the attribute is redundantly used; however, where possible let's avoid it as it reduces preprocessed code size and associated compile-time overheads.
--- include/linux/compiler-clang.h | 17 +++++++++++++++++ include/linux/compiler-gcc.h | 6 ++++++ include/linux/compiler_types.h | 2 +- 3 files changed, 24 insertions(+), 1 deletion(-)
include/linux/compiler-clang.h +17 -0
@@ -13,6 +13,12 @@/* all clang versions usable with the kernel support KASAN ABI version 5 */ #define KASAN_ABI_VERSION 5 +/* +* Note: Checking __has_feature(*_sanitizer) is only true if the feature is +* enabled. Therefore it is not required to additionally check defined(CONFIG_*) +* to avoid adding redundant attributes in other configurations. +*/ +#if __has_feature (address_sanitizer) ||__has_feature (hwaddress_sanitizer)/* Emulate GCC's __SANITIZE_ADDRESS__ flag */ #define __SANITIZE_ADDRESS__
@@ -45,6 +51,17 @@#define __no_sanitize_undefined#endif +/* +* Support for __has_feature(coverage_sanitizer) was added in Clang 13 together +* with no_sanitize("coverage"). Prior versions of Clang support coverage +* instrumentation, but cannot be queried for support by the preprocessor. +*/ +#if __has_feature (coverage_sanitizer) +#define __no_sanitize_coverage __attribute__((no_sanitize("coverage"))) +#else +#define __no_sanitize_coverage +#endif +/* * Not all versions of clang implement the type-generic versions * of the builtin overflow checkers. Fortunately, clang implements
include/linux/compiler-gcc.h +6 -0
@@ -126,6 +126,12 @@#define __no_sanitize_undefined#endif +#if defined(CONFIG_KCOV ) &&__has_attribute (__no_sanitize_coverage__) +#define __no_sanitize_coverage __attribute__((no_sanitize_coverage)) +#else +#define __no_sanitize_coverage +#endif +#if GCC_VERSION >=50100 #define COMPILER_HAS_GENERIC_BUILTIN_OVERFLOW 1#endif
include/linux/compiler_types.h +1 -1
@@ -210,7 +210,7 @@ struct ftrace_likely_data {/* Section for code which can't be instrumented at all */ #define noinstr \ noinline notrace __attribute((__section__(".noinstr.text"))) \ - __no_kcsan __no_sanitize_address + __no_kcsan __no_sanitize_address __no_sanitize_coverage#endif /* __KERNEL__ */
Signature · 1 line
2.30.2
Greg Kroah-Hartman
maintainerPATCH 132/292 power: supply: sc27xx: Add missing MODULE_DEVICE_TABLE
In reply to Greg Kroah-HartmanFrom: Zou Wei <[email protected]>
[ Upstream commit 603fcfb9d4ec1cad8d66d3bb37f3613afa8a661a ]
This patch adds missing MODULE_DEVICE_TABLE definition which generates correct modalias for automatic loading of this driver when it is built as an external module.
--- drivers/power/supply/sc27xx_fuel_gauge.c | 1 + 1 file changed, 1 insertion(+)
drivers/power/supply/sc27xx_fuel_gauge.c +1 -0
@@ -1342,6 +1342,7 @@ static const struct of_device_id sc27xx_fgu_of_match[] = { { .compatible = "sprd,sc2731-fgu", }, { } }; +MODULE_DEVICE_TABLE (of, sc27xx_fgu_of_match);static struct platform_driver sc27xx_fgu_driver = { .probe = sc27xx_fgu_probe,
Signature · 1 line
2.30.2
Greg Kroah-Hartman
maintainerPATCH 133/292 power: supply: sc2731_charger: Add missing MODULE_DEVICE_TABLE
In reply to Greg Kroah-HartmanFrom: Zou Wei <[email protected]>
[ Upstream commit 2aac79d14d76879c8e307820b31876e315b1b242 ]
This patch adds missing MODULE_DEVICE_TABLE definition which generates correct modalias for automatic loading of this driver when it is built as an external module.
--- drivers/power/supply/sc2731_charger.c | 1 + 1 file changed, 1 insertion(+)
drivers/power/supply/sc2731_charger.c +1 -0
@@ -524,6 +524,7 @@ static const struct of_device_id sc2731_charger_of_match[] = { { .compatible = "sprd,sc2731-charger", }, { } }; +MODULE_DEVICE_TABLE (of, sc2731_charger_of_match);static struct platform_driver sc2731_charger_driver = { .driver = {
Signature · 1 line
2.30.2
Greg Kroah-Hartman
maintainerPATCH 134/292 pwm: spear: Dont modify HW state in .remove callback
In reply to Greg Kroah-HartmanFrom: Uwe Kleine-König <[email protected]>
[ Upstream commit b601a18f12383001e7a8da238de7ca1559ebc450 ]
A consumer is expected to disable a PWM before calling pwm_put(). And if they didn't there is hopefully a good reason (or the consumer needs fixing). Also if disabling an enabled PWM was the right thing to do, this should better be done in the framework instead of in each low level driver.
So drop the hardware modification from the .remove() callback.
--- drivers/pwm/pwm-spear.c | 4 ---- 1 file changed, 4 deletions(-)
drivers/pwm/pwm-spear.c +0 -4
@@ -229,10 +229,6 @@ static int spear_pwm_probe(struct platform_device *pdev)static int spear_pwm_remove (struct platform_device *pdev) {struct spear_pwm_chip *pc =platform_get_drvdata (pdev); -int i; - -for (i =0 ; i <NUM_PWM ; i++) -pwm_disable (&pc->chip.pwms[i]);/* clk was prepared in probe, hence unprepare it here */ clk_unprepare (pc->clk);
Signature · 1 line
2.30.2
Greg Kroah-Hartman
maintainerPATCH 135/292 PCI: ftpci100: Rename macro name collision
In reply to Greg Kroah-HartmanFrom: Randy Dunlap <[email protected]>
[ Upstream commit 5be967d5016ac5ffb9c4d0df51b48441ee4d5ed1 ]
PCI_IOSIZE is defined in mach-loongson64/spaces.h, so change the name of the PCI_* macros in pci-ftpci100.c to use FTPCI_* so that they are more localized and won't conflict with other drivers or arches.
../drivers/pci/controller/pci-ftpci100.c:37: warning: "PCI_IOSIZE" redefined
37 | #define PCI_IOSIZE 0x00
|
In file included from ../arch/mips/include/asm/addrspace.h:13,
... from ../drivers/pci/controller/pci-ftpci100.c:15:arch/mips/include/asm/mach-loongson64/spaces.h:11: note: this is the location of the previous definition
11 | #define PCI_IOSIZE SZ_16M
--- drivers/pci/controller/pci-ftpci100.c | 30 +++++++++++++-------------- 1 file changed, 15 insertions(+), 15 deletions(-)
drivers/pci/controller/pci-ftpci100.c +15 -15
@@ -34,12 +34,12 @@* Special configuration registers directly in the first few words * in I/O space. */ -#define PCI_IOSIZE 0x00 -#define PCI_PROT 0x04/* AHB protection */ -#define PCI_CTRL 0x08/* PCI control signal */ -#define PCI_SOFTRST 0x10/* Soft reset counter and response error enable */ -#define PCI_CONFIG 0x28/* PCI configuration command register */ -#define PCI_DATA 0x2C +#define FTPCI_IOSIZE 0x00 +#define FTPCI_PROT 0x04/* AHB protection */ +#define FTPCI_CTRL 0x08/* PCI control signal */ +#define FTPCI_SOFTRST 0x10/* Soft reset counter and response error enable */ +#define FTPCI_CONFIG 0x28/* PCI configuration command register */ +#define FTPCI_DATA 0x2C#define FARADAY_PCI_STATUS_CMD 0x04/* Status and command */ #define FARADAY_PCI_PMC 0x40/* Power management control */
@@ -195,9 +195,9 @@ static int faraday_raw_pci_read_config(struct faraday_pci *p, int bus_number,PCI_CONF_FUNCTION (PCI_FUNC (fn)) |PCI_CONF_WHERE (config) |PCI_CONF_ENABLE , - p->base + PCI_CONFIG); + p->base + FTPCI_CONFIG); - *value =readl (p->base +PCI_DATA ); + *value =readl (p->base +FTPCI_DATA );if (size ==1 ) *value = (*value >> (8 * (config &3 ))) &0xFF ;
@@ -230,17 +230,17 @@ static int faraday_raw_pci_write_config(struct faraday_pci *p, int bus_number,PCI_CONF_FUNCTION (PCI_FUNC (fn)) |PCI_CONF_WHERE (config) |PCI_CONF_ENABLE , - p->base + PCI_CONFIG); + p->base + FTPCI_CONFIG);switch (size) {case 4 : -writel (value, p->base +PCI_DATA ); +writel (value, p->base +FTPCI_DATA );break ;case 2 : -writew (value, p->base +PCI_DATA + (config &3 )); +writew (value, p->base +FTPCI_DATA + (config &3 ));break ;case 1 : -writeb (value, p->base +PCI_DATA + (config &3 )); +writeb (value, p->base +FTPCI_DATA + (config &3 ));break ;default : ret =PCIBIOS_BAD_REGISTER_NUMBER ;
@@ -469,7 +469,7 @@ static int faraday_pci_probe(struct platform_device *pdev)if (!faraday_res_to_memcfg (io->start - win->offset,resource_size (io), &val)) {/* setup I/O space size */ -writel (val, p->base +PCI_IOSIZE ); +writel (val, p->base +FTPCI_IOSIZE ); }else {dev_err (dev,"illegal IO mem size\n" );return -EINVAL ;
@@ -477,11 +477,11 @@ static int faraday_pci_probe(struct platform_device *pdev) }/* Setup hostbridge */ - val =readl (p->base +PCI_CTRL ); + val =readl (p->base +FTPCI_CTRL ); val |=PCI_COMMAND_IO ; val |=PCI_COMMAND_MEMORY ; val |=PCI_COMMAND_MASTER ; -writel (val, p->base +PCI_CTRL ); +writel (val, p->base +FTPCI_CTRL );/* Mask and clear all interrupts */ faraday_raw_pci_write_config (p,0 ,0 ,FARADAY_PCI_CTRL2 +2 ,2 ,0xF000 );if (variant->cascaded_irq) {
Signature · 1 line
2.30.2
Greg Kroah-Hartman
maintainerPATCH 136/292 power: supply: ab8500: Avoid NULL pointers
In reply to Greg Kroah-HartmanFrom: Linus Walleij <[email protected]>
[ Upstream commit 5bcb5087c9dd3dca1ff0ebd8002c5313c9332b56 ]
Sometimes the code will crash because we haven't enabled AC or USB charging and thus not created the corresponding psy device. Fix it by checking that it is there before notifying.
--- drivers/power/supply/ab8500_charger.c | 18 +++++++++++++++++- 1 file changed, 17 insertions(+), 1 deletion(-)
drivers/power/supply/ab8500_charger.c +17 -1
@@ -413,6 +413,14 @@ disable_otp:static void ab8500_power_supply_changed (struct ab8500_charger *di,struct power_supply *psy) { +/* +* This happens if we get notifications or interrupts and +* the platform has been configured not to support one or +* other type of charging. +*/ +if (!psy) +return ; +if (di->autopower_cfg) { if (!di->usb.charger_connected && !di->ac.charger_connected &&
@@ -439,7 +447,15 @@ static void ab8500_charger_set_usb_connected(struct ab8500_charger *di,if (!connected) di->flags.vbus_drop_end = false; -sysfs_notify (&di->usb_chg.psy->dev.kobj,NULL ,"present" ); +/* +* Sometimes the platform is configured not to support +* USB charging and no psy has been created, but we still +* will get these notifications. +*/ +if (di->usb_chg.psy) { +sysfs_notify (&di->usb_chg.psy->dev.kobj,NULL , +"present" ); + }if (connected) {mutex_lock (&di->charger_attached_mutex);
Signature · 1 line
2.30.2
Greg Kroah-Hartman
maintainerPATCH 137/292 PCI: hv: Fix a race condition when removing the device
In reply to Greg Kroah-HartmanFrom: Long Li <[email protected]>
[ Upstream commit 94d22763207ac6633612b8d8e0ca4fba0f7aa139 ]
On removing the device, any work item (hv_pci_devices_present() or hv_pci_eject_device()) scheduled on workqueue hbus->wq may still be running and race with hv_pci_remove().
This can happen because the host may send PCI_EJECT or PCI_BUS_RELATIONS(2) and decide to rescind the channel immediately after that.
Fix this by flushing/destroying the workqueue of hbus before doing hbus remove.
--- drivers/pci/controller/pci-hyperv.c | 30 ++++++++++++++++++++++------- 1 file changed, 23 insertions(+), 7 deletions(-)
drivers/pci/controller/pci-hyperv.c +23 -7
@@ -444,7 +444,6 @@ enum hv_pcibus_state { hv_pcibus_probed, hv_pcibus_installed, hv_pcibus_removing, - hv_pcibus_removed, hv_pcibus_maximum };
@@ -3247,8 +3246,9 @@ static int hv_pci_bus_exit(struct hv_device *hdev, bool keep_devs)struct pci_packet teardown_packet;u8 buffer[sizeof (struct pci_message )]; } pkt; -struct hv_dr_state *dr;struct hv_pci_compl comp_pkt; +struct hv_pci_dev *hpdev, *tmp; +unsigned long flags;int ret;/*
@@ -3260,9 +3260,16 @@ static int hv_pci_bus_exit(struct hv_device *hdev, bool keep_devs)if (!keep_devs) {/* Delete any children which might still exist. */ - dr =kzalloc (sizeof (*dr),GFP_KERNEL ); -if (dr &&hv_pci_start_relations_work (hbus, dr)) -kfree (dr); +spin_lock_irqsave (&hbus->device_list_lock, flags); +list_for_each_entry_safe (hpdev, tmp, &hbus->children, list_entry) { +list_del (&hpdev->list_entry); +if (hpdev->pci_slot) +pci_destroy_slot (hpdev->pci_slot); +/* For the two refs got in new_pcichild_device() */ +put_pcichild (hpdev); +put_pcichild (hpdev); + } +spin_unlock_irqrestore (&hbus->device_list_lock, flags); } ret =hv_send_resources_released (hdev);
@@ -3305,13 +3312,23 @@ static int hv_pci_remove(struct hv_device *hdev) hbus =hv_get_drvdata (hdev);if (hbus->state == hv_pcibus_installed) { +tasklet_disable (&hdev->channel->callback_event); + hbus->state = hv_pcibus_removing; +tasklet_enable (&hdev->channel->callback_event); +destroy_workqueue (hbus->wq); + hbus->wq =NULL ; +/* +* At this point, no work is running or can be scheduled +* on hbus-wq. We can't race with hv_pci_devices_present() +* or hv_pci_eject_device(), it's safe to proceed. +*/ +/* Remove the bus from PCI's point of view. */ pci_lock_rescan_remove ();pci_stop_root_bus (hbus->pci_bus);hv_pci_remove_slots (hbus);pci_remove_root_bus (hbus->pci_bus);pci_unlock_rescan_remove (); - hbus->state = hv_pcibus_removed; } ret =hv_pci_bus_exit (hdev, false);
@@ -3326,7 +3343,6 @@ static int hv_pci_remove(struct hv_device *hdev)irq_domain_free_fwnode (hbus->sysdata.fwnode);put_hvpcibus (hbus);wait_for_completion (&hbus->remove_event); -destroy_workqueue (hbus->wq);hv_put_dom_num (hbus->sysdata.domain);
Signature · 1 line
2.30.2
Greg Kroah-Hartman
maintainerPATCH 138/292 power: supply: max17042: Do not enforce (incorrect) interrupt trigger type
In reply to Greg Kroah-HartmanFrom: Krzysztof Kozlowski <[email protected]>
[ Upstream commit 7fbf6b731bca347700e460d94b130f9d734b33e9 ]
Interrupt line can be configured on different hardware in different way, even inverted. Therefore driver should not enforce specific trigger type - edge falling - but instead rely on Devicetree to configure it.
The Maxim 17047/77693 datasheets describe the interrupt line as active low with a requirement of acknowledge from the CPU therefore the edge falling is not correct.
The interrupt line is shared between PMIC and RTC driver, so using level sensitive interrupt is here especially important to avoid races. With an edge configuration in case if first PMIC signals interrupt followed shortly after by the RTC, the interrupt might not be yet cleared/acked thus the second one would not be noticed.
--- drivers/power/supply/max17042_battery.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/power/supply/max17042_battery.c +1 -1
@@ -1104,7 +1104,7 @@ static int max17042_probe(struct i2c_client *client, }if (client->irq) { -unsigned int flags =IRQF_TRIGGER_FALLING |IRQF_ONESHOT ; +unsigned int flags =IRQF_ONESHOT ;/* * On ACPI systems the IRQ may be handled by ACPI-event code,
Signature · 1 line
2.30.2
Greg Kroah-Hartman
maintainerPATCH 139/292 power: reset: gpio-poweroff: add missing MODULE_DEVICE_TABLE
In reply to Greg Kroah-HartmanFrom: Bixuan Cui <[email protected]>
[ Upstream commit ed3443fb4df4e140a22f65144546c8a8e1e27f4e ]
This patch adds missing MODULE_DEVICE_TABLE definition which generates correct modalias for automatic loading of this driver when it is built as an external module.
--- drivers/power/reset/gpio-poweroff.c | 1 + 1 file changed, 1 insertion(+)
drivers/power/reset/gpio-poweroff.c +1 -0
@@ -90,6 +90,7 @@ static const struct of_device_id of_gpio_poweroff_match[] = { { .compatible = "gpio-poweroff", }, {}, }; +MODULE_DEVICE_TABLE (of, of_gpio_poweroff_match);static struct platform_driver gpio_poweroff_driver = { .probe = gpio_poweroff_probe,
Signature · 1 line
2.30.2
Greg Kroah-Hartman
maintainerPATCH 140/292 ARM: 9087/1: kprobes: test-thumb: fix for LLVM_IAS=1
In reply to Greg Kroah-HartmanFrom: Nick Desaulniers <[email protected]>
[ Upstream commit 8b95a7d90ce8160ac5cffd5bace6e2eba01a871e ]
There's a few instructions that GAS infers operands but Clang doesn't; from what I can tell the Arm ARM doesn't say these are optional.
F5.1.257 TBB, TBH T1 Halfword variant
F5.1.238 STREXD T1 variant
F5.1.84 LDREXD T1 variant
--- arch/arm/probes/kprobes/test-thumb.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
arch/arm/probes/kprobes/test-thumb.c +5 -5
@@ -441,21 +441,21 @@ void kprobe_thumb32_test_cases(void) "3: mvn r0, r0 \n\t" "2: nop \n\t") - TEST_RX("tbh [pc, r",7, (9f-(1f+4))>>1,"]", + TEST_RX("tbh [pc, r",7, (9f-(1f+4))>>1,", lsl #1]", "9: \n\t" ".short (2f-1b-4)>>1 \n\t" ".short (3f-1b-4)>>1 \n\t" "3: mvn r0, r0 \n\t" "2: nop \n\t") - TEST_RX("tbh [pc, r",12, ((9f-(1f+4))>>1)+1,"]", + TEST_RX("tbh [pc, r",12, ((9f-(1f+4))>>1)+1,", lsl #1]", "9: \n\t" ".short (2f-1b-4)>>1 \n\t" ".short (3f-1b-4)>>1 \n\t" "3: mvn r0, r0 \n\t" "2: nop \n\t") -TEST_RRX ("tbh [r" ,1 ,9f ,", r" ,14 ,1 ,"]" , +TEST_RRX ("tbh [r" ,1 ,9f ,", r" ,14 ,1 ,", lsl #1]" ,"9: \n\t" ".short (2f-1b-4)>>1 \n\t" ".short (3f-1b-4)>>1 \n\t"
@@ -468,10 +468,10 @@ void kprobe_thumb32_test_cases(void) TEST_UNSUPPORTED("strexb r0, r1, [r2]") TEST_UNSUPPORTED("strexh r0, r1, [r2]") - TEST_UNSUPPORTED("strexd r0, r1, [r2]") + TEST_UNSUPPORTED("strexd r0, r1, r2, [r2]") TEST_UNSUPPORTED("ldrexb r0, [r1]") TEST_UNSUPPORTED("ldrexh r0, [r1]") - TEST_UNSUPPORTED("ldrexd r0, [r1]") + TEST_UNSUPPORTED("ldrexd r0, r1, [r1]")TEST_GROUP ("Data-processing (shifted register) and (modified immediate)" )
Signature · 1 line
2.30.2
Greg Kroah-Hartman
maintainerPATCH 141/292 PCI/P2PDMA: Avoid pci_get_slot(), which may sleep
In reply to Greg Kroah-HartmanFrom: Logan Gunthorpe <[email protected]>
[ Upstream commit 3ec0c3ec2d92c09465534a1ff9c6f9d9506ffef6 ]
In order to use upstream_bridge_distance_warn() from a dma_map function, it must not sleep. However, pci_get_slot() takes the pci_bus_sem so it might sleep.
In order to avoid this, try to get the host bridge's device from the first element in the device list. It should be impossible for the host bridge's device to go away while references are held on child devices, so the first element should not be able to change and, thus, this should be safe.
Introduce a static function called pci_host_bridge_dev() to obtain the host bridge's root device.
--- drivers/pci/p2pdma.c | 34 ++++++++++++++++++++++++++++++++-- 1 file changed, 32 insertions(+), 2 deletions(-)
drivers/pci/p2pdma.c +32 -2
@@ -308,10 +308,41 @@ static const struct pci_p2pdma_whitelist_entry { {} }; +/* +* This lookup function tries to find the PCI device corresponding to a given +* host bridge. +* +* It assumes the host bridge device is the first PCI device in the +* bus->devices list and that the devfn is 00.0. These assumptions should hold +* for all the devices in the whitelist above. +* +* This function is equivalent to pci_get_slot(host->bus, 0), however it does +* not take the pci_bus_sem lock seeing __host_bridge_whitelist() must not +* sleep. +* +* For this to be safe, the caller should hold a reference to a device on the +* bridge, which should ensure the host_bridge device will not be freed +* or removed from the head of the devices list. +*/ +static struct pci_dev *pci_host_bridge_dev (struct pci_host_bridge *host) +{ +struct pci_dev *root; + + root =list_first_entry_or_null (&host->bus->devices, + struct pci_dev, bus_list); + +if (!root) +return NULL ; +if (root->devfn !=PCI_DEVFN (0 ,0 )) +return NULL ; + +return root; +} +static bool __host_bridge_whitelist (struct pci_host_bridge *host,bool same_host_bridge) { -struct pci_dev *root =pci_get_slot (host->bus,PCI_DEVFN (0 ,0 )); +struct pci_dev *root =pci_host_bridge_dev (host);const struct pci_p2pdma_whitelist_entry *entry;unsigned short vendor, device;
@@ -320,7 +351,6 @@ static bool __host_bridge_whitelist(struct pci_host_bridge *host, vendor = root->vendor; device = root->device; -pci_dev_put (root);for (entry = pci_p2pdma_whitelist; entry->vendor; entry++) {if (vendor != entry->vendor || device != entry->device)
Signature · 1 line
2.30.2
Greg Kroah-Hartman
maintainerPATCH 142/292 NFSv4: Fix delegation return in cases where we have to retry
In reply to Greg Kroah-HartmanFrom: Trond Myklebust <[email protected]>
[ Upstream commit be20037725d17935ec669044bd2b15bc40c3b5ab ]
If we're unable to immediately recover all locks because the server is unable to immediately service our reclaim calls, then we want to retry after we've finished servicing all the other asynchronous delegation returns on our queue.
--- fs/nfs/delegation.c | 71 +++++++++++++++++++++++++++++++++++---------- fs/nfs/delegation.h | 1 + fs/nfs/nfs4_fs.h | 1 + 3 files changed, 58 insertions(+), 15 deletions(-)
fs/nfs/delegation.c +56 -15
@@ -75,6 +75,13 @@ void nfs_mark_delegation_referenced(struct nfs_delegation *delegation)set_bit (NFS_DELEGATION_REFERENCED , &delegation->flags); } +static void nfs_mark_return_delegation (struct nfs_server *server, +struct nfs_delegation *delegation) +{ +set_bit (NFS_DELEGATION_RETURN , &delegation->flags); +set_bit (NFS4CLNT_DELEGRETURN , &server->nfs_client->cl_state); +} +static bool nfs4_is_valid_delegation (const struct nfs_delegation *delegation,fmode_t flags)
@@ -293,6 +300,7 @@ nfs_start_delegation_return_locked(struct nfs_inode *nfsi) goto out;spin_lock (&delegation->lock);if (!test_and_set_bit (NFS_DELEGATION_RETURNING , &delegation->flags)) { +clear_bit (NFS_DELEGATION_RETURN_DELAYED , &delegation->flags);/* Refcount matched in nfs_end_delegation_return() */ ret =nfs_get_delegation (delegation); }
@@ -314,16 +322,17 @@ nfs_start_delegation_return(struct nfs_inode *nfsi)return delegation; } -static void -nfs_abort_delegation_return (struct nfs_delegation *delegation, -struct nfs_client *clp) +static void nfs_abort_delegation_return (struct nfs_delegation *delegation, +struct nfs_client *clp,int err) {spin_lock (&delegation->lock);clear_bit (NFS_DELEGATION_RETURNING , &delegation->flags); -set_bit (NFS_DELEGATION_RETURN , &delegation->flags); +if (err == -EAGAIN ) { +set_bit (NFS_DELEGATION_RETURN_DELAYED , &delegation->flags); +set_bit (NFS4CLNT_DELEGRETURN_DELAYED , &clp->cl_state); + }spin_unlock (&delegation->lock); -set_bit (NFS4CLNT_DELEGRETURN , &clp->cl_state); } static struct nfs_delegation *
@@ -528,7 +537,7 @@ static int nfs_end_delegation_return(struct inode *inode, struct nfs_delegation }while (err ==0 );if (err) { -nfs_abort_delegation_return (delegation, clp); +nfs_abort_delegation_return (delegation, clp, err); goto out; }
@@ -557,6 +566,7 @@ static bool nfs_delegation_need_return(struct nfs_delegation *delegation)if (ret)clear_bit (NFS_DELEGATION_RETURN_IF_CLOSED , &delegation->flags);if (test_bit (NFS_DELEGATION_RETURNING , &delegation->flags) || +test_bit (NFS_DELEGATION_RETURN_DELAYED , &delegation->flags) ||test_bit (NFS_DELEGATION_REVOKED , &delegation->flags)) ret = false;
@@ -636,6 +646,38 @@ out:return err; } +static bool nfs_server_clear_delayed_delegations (struct nfs_server *server) +{ +struct nfs_delegation *d; +bool ret = false; + + list_for_each_entry_rcu (d, &server->delegations, super_list) { +if (!test_bit (NFS_DELEGATION_RETURN_DELAYED , &d->flags)) +continue ; +nfs_mark_return_delegation (server, d); +clear_bit (NFS_DELEGATION_RETURN_DELAYED , &d->flags); + ret = true; + } +return ret; +} + +static bool nfs_client_clear_delayed_delegations (struct nfs_client *clp) +{ +struct nfs_server *server; +bool ret = false; + +if (!test_and_clear_bit (NFS4CLNT_DELEGRETURN_DELAYED , &clp->cl_state)) + goto out; +rcu_read_lock (); + list_for_each_entry_rcu (server, &clp->cl_superblocks, client_link) { +if (nfs_server_clear_delayed_delegations (server)) + ret = true; + } +rcu_read_unlock (); +out: +return ret; +} +/** * nfs_client_return_marked_delegations - return previously marked delegations * @clp: nfs_client to process
@@ -648,8 +690,14 @@ out:*/ int nfs_client_return_marked_delegations (struct nfs_client *clp) { -return nfs_client_for_each_server (clp, - nfs_server_return_marked_delegations,NULL ); +int err =nfs_client_for_each_server ( + clp, nfs_server_return_marked_delegations,NULL ); +if (err) +return err; +/* If a return was delayed, sleep to prevent hard looping */ +if (nfs_client_clear_delayed_delegations (clp)) +ssleep (1 ); +return 0 ; }/**
@@ -764,13 +812,6 @@ static void nfs_mark_return_if_closed_delegation(struct nfs_server *server,set_bit (NFS4CLNT_DELEGRETURN , &server->nfs_client->cl_state); } -static void nfs_mark_return_delegation (struct nfs_server *server, -struct nfs_delegation *delegation) -{ -set_bit (NFS_DELEGATION_RETURN , &delegation->flags); -set_bit (NFS4CLNT_DELEGRETURN , &server->nfs_client->cl_state); -} -static bool nfs_server_mark_return_all_delegations (struct nfs_server *server) {struct nfs_delegation *delegation;
fs/nfs/delegation.h +1 -0
@@ -36,6 +36,7 @@ enum {NFS_DELEGATION_REVOKED ,NFS_DELEGATION_TEST_EXPIRED ,NFS_DELEGATION_INODE_FREEING , + NFS_DELEGATION_RETURN_DELAYED, }; int nfs_inode_set_delegation(struct inode *inode, const struct cred *cred,
fs/nfs/nfs4_fs.h +1 -0
@@ -45,6 +45,7 @@ enum nfs4_client_state {NFS4CLNT_RECALL_RUNNING ,NFS4CLNT_RECALL_ANY_LAYOUT_READ ,NFS4CLNT_RECALL_ANY_LAYOUT_RW , + NFS4CLNT_DELEGRETURN_DELAYED, };#define NFS4_RENEW_TIMEOUT 0x01
Signature · 1 line
2.30.2