drm/amdgpu: Fix documentaion for dm_dmub_outbox1_low_irq
Subsystems (3)
PATCH 1/1 drm/amdgpu: Fix documentaion for dm_dmub_outbox1_low_irq
Fix make htmldocs complaint:./drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c:628: warning: Excess function parameter 'interrupt_params' description in 'DMUB_TRACE_MAX_READ'
--- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +2 -1
@@ -625,7 +625,6 @@ static void dm_dcn_vertical_interrupt0_high_irq(void *interrupt_params)* Handles the Outbox Interrupt * event handler. */ -#define DMUB_TRACE_MAX_READ 64static void dm_dmub_outbox1_low_irq (void *interrupt_params) {struct dmub_notification notify;
@@ -635,6 +634,8 @@ static void dm_dmub_outbox1_low_irq(void *interrupt_params)struct dmcub_trace_buf_entry entry = {0 };uint32_t count =0 ; +#define DMUB_TRACE_MAX_READ 64 +if (dc_enable_dmub_notifications (adev->dm.dc)) {if (irq_params->irq_src ==DC_IRQ_SOURCE_DMCUB_OUTBOX ) { do {
Signature · 6 lines
2.25.1 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Harry Wentland
maintainerQuoted 21 lines · Anson Jacob
Fix make htmldocs complaint:
./drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c:628: warning: Excess function parameter 'interrupt_params' description in 'DMUB_TRACE_MAX_READ'Signed-off-by Anson Jacob <[email protected]>--- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +0
-1@@ -625,7 +625,6 @@ static void dm_dcn_vertical_interrupt0_high_irq(void *interrupt_params)* Handles the Outbox Interrupt * event handler. */ -#define DMUB_TRACE_MAX_READ 64static void dm_dmub_outbox1_low_irq (void *interrupt_params) {struct dmub_notification notify;
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c static void dm_dmub_outbox1_low_irq(void *interrupt_params) · line 638
Quoted 5 lines
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +2
-0@@ -635,6 +634,8 @@ static void dm_dmub_outbox1_low_irq(void *interrupt_params)struct dmcub_trace_buf_entry entry = {0 };uint32_t count =0 ; +#define DMUB_TRACE_MAX_READ 64 +
I'd prefer to keep macro definitions separate from functions. A better place for this would be right before the function comment.
Harry
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c static void dm_dmub_outbox1_low_irq(void *interrupt_params) · line 641
Quoted 4 lines
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +0
-0if (dc_enable_dmub_notifications (adev->dm.dc)) {if (irq_params->irq_src ==DC_IRQ_SOURCE_DMCUB_OUTBOX ) { do {
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx