Skip to contentSkip to conversation

drm/i915/display: Fix shared dpll mismatch for bigjoiner slave

PATCH In review Manasi Navare 4 participants 9 messages Jul 14, 2021 – Aug 10, 2021

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/i915/display: Fix shared dpll mismatch for bigjoiner slave

Currently when we do the HW state readout, we dont set the shared dpll to NULL for the bigjoiner slave which should not have a DPLL assigned. So it has some garbage while the HW state readout is NULL. So explicitly reset the shared dpll for bigjoiner slave pipe.

---
 drivers/gpu/drm/i915/display/intel_display.c | 4 ++++
 1 file changed, 4 insertions(+)
drivers/gpu/drm/i915/display/intel_display.c +4 -0
index 65ddb6ca16e6..c274bfb8e549 100644
@@ -9006,6 +9006,10 @@ verify_crtc_state(struct intel_crtc *crtc,
 	if (!new_crtc_state->hw.active)
 		return;
 
+	if (new_crtc_state->bigjoiner_slave)
+		/* No PLLs set for slave */
+		pipe_config->shared_dpll = NULL;
+
 	intel_pipe_config_sanity_check(dev_priv, pipe_config);
 
 	if (!intel_pipe_config_compare(new_crtc_state,
Signature · 6 lines
2.19.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
CI Tested-by Swati Sharma on v1 1/1
#1 lore raw

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/display: Fix shared dpll mismatch for bigjoiner slave (rev3)

== Series Details ==

== Series Details ==

Series: drm/i915/display: Fix shared dpll mismatch for bigjoiner slave (rev3)
URL : https://patchwork.freedesktop.org/series/91830/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
e5339cc39b24 drm/i915/display: Fix shared dpll mismatch for bigjoiner slave
-:10: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#10: 
Currently when we do the HW state readout, we dont set the shared dpll to NULL

-:18: WARNING:BAD_SIGN_OFF: 'Tested-by:' is the preferred signature form #18:

total: 0 errors, 2 warnings, 0 checks, 10 lines checked

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#2 lore raw

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display: Fix shared dpll mismatch for bigjoiner slave (rev3)

In reply to Manasi Navare
== Series Details ==

== Series Details ==

Series: drm/i915/display: Fix shared dpll mismatch for bigjoiner slave (rev3)
URL : https://patchwork.freedesktop.org/series/91830/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_10345 -> Patchwork_20623
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20623/index.html

Known issues
------------

Here are the changes found in Patchwork_20623 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@amdgpu/amd_prime@amd-to-i915:
- fi-kbl-soraka: NOTRUN -> [SKIP][1] ([fdo#109271])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20623/fi-kbl-soraka/igt@amdgpu/[email protected]

* igt@kms_chamelium@dp-crc-fast:
- fi-kbl-7500u: [PASS][2] -> [FAIL][3] ([i915#1372])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10345/fi-kbl-7500u/igt@[email protected]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20623/fi-kbl-7500u/igt@[email protected]

#### Possible fixes ####

* igt@gem_exec_suspend@basic-s3:
- {fi-tgl-1115g4}: [FAIL][4] ([i915#1888]) -> [PASS][5]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10345/fi-tgl-1115g4/igt@[email protected]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20623/fi-tgl-1115g4/igt@[email protected]

* igt@kms_chamelium@common-hpd-after-suspend:
- fi-kbl-7500u: [DMESG-FAIL][6] ([i915#165]) -> [PASS][7]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10345/fi-kbl-7500u/igt@[email protected]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20623/fi-kbl-7500u/igt@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#1372]: https://gitlab.freedesktop.org/drm/intel/issues/1372
[i915#165]: https://gitlab.freedesktop.org/drm/intel/issues/165
[i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888

Participating hosts (41 -> 36)
------------------------------

Missing (5): fi-ilk-m540 fi-hsw-4200u fi-bsw-cyan bat-jsl-1 fi-bdw-samus

Build changes
-------------

* Linux: CI_DRM_10345 -> Patchwork_20623

CI-20190529: 20190529
CI_DRM_10345: 8c6a974b932fbaa798102b4713ceedf3b04227d9 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6142: 16e753fc5e1e51395e1df40865c569984a74c5ed @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_20623: e5339cc39b2489408746b00e12117e7992296ab1 @ git://anongit.freedesktop.org/gfx-ci/linux

== Linux commits ==

e5339cc39b24 drm/i915/display: Fix shared dpll mismatch for bigjoiner slave

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20623/index.html

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#3 lore raw

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/display: Fix shared dpll mismatch for bigjoiner slave (rev3)

In reply to Manasi Navare
== Series Details ==

== Series Details ==

Series: drm/i915/display: Fix shared dpll mismatch for bigjoiner slave (rev3)
URL : https://patchwork.freedesktop.org/series/91830/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_10345_full -> Patchwork_20623_full
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with Patchwork_20623_full absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in Patchwork_20623_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in Patchwork_20623_full:

### IGT changes ###

#### Possible regressions ####

* igt@kms_addfb_basic@invalid-smem-bo-on-discrete:
- shard-iclb: NOTRUN -> [SKIP][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20623/shard-iclb5/igt@[email protected]

#### Suppressed ####

The following results come from untrusted machines, tests, or statuses. They do not affect the overall result.

* igt@runner@aborted:
- {shard-rkl}: ([FAIL][2], [FAIL][3], [FAIL][4], [FAIL][5], [FAIL][6]) ([i915#3002]) -> ([FAIL][7], [FAIL][8], [FAIL][9], [FAIL][10]) ([i915#2029] / [i915#3002])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10345/shard-rkl-1/igt@[email protected]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10345/shard-rkl-1/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10345/shard-rkl-5/igt@[email protected]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10345/shard-rkl-6/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10345/shard-rkl-6/igt@[email protected]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20623/shard-rkl-2/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20623/shard-rkl-6/igt@[email protected]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20623/shard-rkl-1/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20623/shard-rkl-2/igt@[email protected]

Known issues
------------

Here are the changes found in Patchwork_20623_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@feature_discovery@display-4x:
- shard-iclb: NOTRUN -> [SKIP][11] ([i915#1839])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20623/shard-iclb5/igt@[email protected]

* igt@feature_discovery@psr2:
- shard-iclb: [PASS][12] -> [SKIP][13] ([i915#658])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10345/shard-iclb2/igt@[email protected]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20623/shard-iclb5/igt@[email protected]

* igt@gem_ctx_isolation@preservation-s3@vcs0:
- shard-kbl: [PASS][14] -> [DMESG-WARN][15] ([i915#180]) +5 similar issues
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10345/shard-kbl1/igt@gem_ctx_isolation@[email protected]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20623/shard-kbl7/igt@gem_ctx_isolation@[email protected]

* igt@gem_ctx_isolation@preservation-s3@vecs0:
- shard-skl: [PASS][16] -> [INCOMPLETE][17] ([i915#146] / [i915#198])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10345/shard-skl2/igt@gem_ctx_isolation@[email protected]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20623/shard-skl1/igt@gem_ctx_isolation@[email protected]
- shard-apl: [PASS][18] -> [DMESG-WARN][19] ([i915#180]) +1 similar issue
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10345/shard-apl2/igt@gem_ctx_isolation@[email protected]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20623/shard-apl3/igt@gem_ctx_isolation@[email protected]

* igt@gem_ctx_persistence@legacy-engines-cleanup:
- shard-snb: NOTRUN -> [SKIP][20] ([fdo#109271] / [i915#1099]) +1 similar issue
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20623/shard-snb5/igt@[email protected]

* igt@gem_eio@unwedge-stress:
- shard-skl: [PASS][21] -> [TIMEOUT][22] ([i915#2369] / [i915#3063])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10345/shard-skl9/igt@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20623/shard-skl7/igt@[email protected]
- shard-iclb: NOTRUN -> [TIMEOUT][23] ([i915#2369] / [i915#2481] / [i915#3070])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20623/shard-iclb6/igt@[email protected]

* igt@gem_exec_fair@basic-deadline:
- shard-glk: [PASS][24] -> [FAIL][25] ([i915#2846])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10345/shard-glk8/igt@[email protected]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20623/shard-glk7/igt@[email protected]

* igt@gem_exec_fair@basic-none@vcs0:
- shard-kbl: [PASS][26] -> [FAIL][27] ([i915#2842]) +2 similar issues
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10345/shard-kbl4/igt@gem_exec_fair@[email protected]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20623/shard-kbl3/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-glk: [PASS][28] -> [FAIL][29] ([i915#2842])
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10345/shard-glk9/igt@gem_exec_fair@[email protected]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20623/shard-glk8/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-pace@vcs1:
- shard-iclb: NOTRUN -> [FAIL][30] ([i915#2842])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20623/shard-iclb4/igt@gem_exec_fair@[email protected]

* igt@gem_exec_params@no-blt:
- shard-iclb: NOTRUN -> [SKIP][31] ([fdo#109283])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20623/shard-iclb6/igt@[email protected]

* igt@gem_mmap_gtt@cpuset-basic-small-copy-xy:
- shard-iclb: NOTRUN -> [FAIL][32] ([i915#2428])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20623/shard-iclb5/igt@[email protected]

* igt@gem_mmap_gtt@cpuset-big-copy-xy:
- shard-iclb: [PASS][33] -> [FAIL][34] ([i915#2428])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10345/shard-iclb7/igt@[email protected]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20623/shard-iclb3/igt@[email protected]

* igt@gem_pread@exhaustion:
- shard-apl: NOTRUN -> [WARN][35] ([i915#2658])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20623/shard-apl7/igt@[email protected]

* igt@gem_render_copy@x-tiled-to-vebox-yf-tiled:
- shard-iclb: NOTRUN -> [SKIP][36] ([i915#768]) +1 similar issue
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20623/shard-iclb5/igt@[email protected]

* igt@gem_userptr_blits@input-checking:
- shard-apl: NOTRUN -> [DMESG-WARN][37] ([i915#3002]) +1 similar issue
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20623/shard-apl3/igt@[email protected]

* igt@gem_userptr_blits@unsync-overlap:
- shard-tglb: NOTRUN -> [SKIP][38] ([i915#3297])
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20623/shard-tglb2/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][39] ([i915#3297])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20623/shard-iclb7/igt@[email protected]

* igt@gem_userptr_blits@vma-merge:
- shard-iclb: NOTRUN -> [FAIL][40] ([i915#3318])
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20623/shard-iclb7/igt@[email protected]
- shard-tglb: NOTRUN -> [FAIL][41] ([i915#3318])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20623/shard-tglb2/igt@[email protected]

* igt@gen9_exec_parse@allowed-all:
- shard-iclb: NOTRUN -> [SKIP][42] ([fdo#112306]) +1 similar issue
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20623/shard-iclb7/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][43] ([fdo#112306]) +1 similar issue
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20623/shard-tglb2/igt@[email protected]

* igt@gen9_exec_parse@allowed-single:
- shard-skl: NOTRUN -> [DMESG-WARN][44] ([i915#1436] / [i915#716])
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20623/shard-skl2/igt@[email protected]

* igt@gen9_exec_parse@batch-invalid-length:
- shard-snb: NOTRUN -> [SKIP][45] ([fdo#109271]) +226 similar issues
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20623/shard-snb5/igt@[email protected]

* igt@gen9_exec_parse@bb-large:
- shard-apl: NOTRUN -> [FAIL][46] ([i915#3296])
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20623/shard-apl1/igt@[email protected]
- shard-kbl: NOTRUN -> [FAIL][47] ([i915#3296])
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20623/shard-kbl4/igt@[email protected]

* igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-dp:
- shard-apl: NOTRUN -> [SKIP][48] ([fdo#109271] / [i915#1937])
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20623/shard-apl7/igt@i915_pm_lpsp@[email protected]

* igt@i915_pm_rc6_residency@media-rc6-accuracy:
- shard-iclb: NOTRUN -> [SKIP][49] ([fdo#109289])
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20623/shard-iclb5/igt@[email protected]

* igt@kms_atomic_transition@plane-all-modeset-transition:
- shard-iclb: NOTRUN -> [SKIP][50] ([i915#1769])
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20623/shard-iclb5/igt@[email protected]

* igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-180-hflip:
- shard-apl: NOTRUN -> [SKIP][51] ([fdo#109271] / [i915#3777]) +1 similar issue
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20623/shard-apl8/igt@[email protected]

* igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-180-async-flip:
- shard-skl: NOTRUN -> [FAIL][52] ([i915#3763])
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20623/shard-skl5/igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-180-async-flip.html

* igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-0-hflip:
- shard-kbl: NOTRUN -> [SKIP][53] ([fdo#109271] / [i915#3777])
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20623/shard-kbl3/igt@[email protected]

* igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-0:
- shard-apl: NOTRUN -> [SKIP][54] ([fdo#109271]) +214 similar issues
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20623/shard-apl7/igt@[email protected]

* igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-180:
- shard-iclb: NOTRUN -> [SKIP][55] ([fdo#110723])
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20623/shard-iclb7/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][56] ([fdo#111615])
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20623/shard-tglb2/igt@[email protected]

* igt@kms_ccs@pipe-a-ccs-on-another-bo-y_tiled_ccs:
- shard-tglb: NOTRUN -> [SKIP][57] ([i915#3689])
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20623/shard-tglb7/igt@kms_ccs@pipe-a-ccs-on-another-bo-y_tiled_ccs.html

* igt@kms_chamelium@hdmi-crc-multiple:
- shard-kbl: NOTRUN -> [SKIP][58] ([fdo#109271] / [fdo#111827]) +4 similar issues
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20623/shard-kbl4/igt@[email protected]

* igt@kms_chamelium@hdmi-hpd-after-suspend:
- shard-skl: NOTRUN -> [SKIP][59] ([fdo#109271] / [fdo#111827])
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20623/shard-skl4/igt@[email protected]

* igt@kms_chamelium@hdmi-hpd-enable-disable-mode:
- shard-iclb: NOTRUN -> [SKIP][60] ([fdo#109284] / [fdo#111827]) +11 similar issues
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20623/shard-iclb5/igt@[email protected]

* igt@kms_chamelium@hdmi-hpd-fast:
- shard-snb: NOTRUN -> [SKIP][61] ([fdo#109271] / [fdo#111827]) +13 similar issues
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20623/shard-snb5/igt@[email protected]

* igt@kms_color_chamelium@pipe-c-ctm-0-25:
- shard-apl: NOTRUN -> [SKIP][62] ([fdo#109271] / [fdo#111827]) +17 similar issues
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20623/shard-apl3/igt@[email protected]

* igt@kms_color_chamelium@pipe-d-ctm-blue-to-red:
- shard-tglb: NOTRUN -> [SKIP][63] ([fdo#109284] / [fdo#111827]) +4 similar issues
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20623/shard-tglb7/igt@[email protected]

* igt@kms_content_protection@dp-mst-lic-type-1:
- shard-iclb: NOTRUN -> [SKIP][64] ([i915#3116])
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20623/shard-iclb5/igt@[email protected]

* igt@kms_content_protection@legacy:
- shard-iclb: NOTRUN -> [SKIP][65] ([fdo#109300] / [fdo#111066])
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20623/shard-iclb6/igt@[email protected]

* igt@kms_content_protection@lic:
- shard-apl: NOTRUN -> [TIMEOUT][66] ([i915#1319]) +1 similar issue
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20623/shard-apl7/igt@[email protected]

* igt@kms_cursor_crc@pipe-b-cursor-max-size-sliding:
- shard-tglb: NOTRUN -> [SKIP][67] ([i915#3359])
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20623/shard-tglb3/igt@[email protected]

* igt@kms_cursor_crc@pipe-c-cursor-512x170-sliding:
- shard-iclb: NOTRUN -> [SKIP][68] ([fdo#109278] / [fdo#109279])
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20623/shard-iclb5/igt@[email protected]

* igt@kms_cursor_crc@pipe-d-cursor-256x256-onscreen:
- shard-kbl: NOTRUN -> [SKIP][69] ([fdo#109271]) +39 similar issues
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20623/shard-kbl3/igt@[email protected]

* igt@kms_cursor_crc@pipe-d-cursor-512x512-onscreen:
- shard-tglb: NOTRUN -> [SKIP][70] ([fdo#109279] / [i915#3359]) +2 similar issues
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20623/shard-tglb2/igt@[email protected]

* igt@kms_cursor_edge_walk@pipe-b-64x64-top-edge:
- shard-skl: [PASS][71] -> [DMESG-WARN][72] ([i915#1982])
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10345/shard-skl1/igt@[email protected]
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20623/shard-skl3/igt@[email protected]

* igt@kms_cursor_edge_walk@pipe-d-128x128-top-edge:
- shard-iclb: NOTRUN -> [SKIP][73] ([fdo#109278]) +25 similar issues
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20623/shard-iclb5/igt@[email protected]

* igt@kms_cursor_legacy@cursora-vs-flipb-varying-size:
- shard-iclb: NOTRUN -> [SKIP][74] ([fdo#109274] / [fdo#109278]) +1 similar issue
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20623/shard-iclb5/igt@[email protected]

* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size:
- shard-skl: [PASS][75] -> [FAIL][76] ([i915#2346] / [i915#533])
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10345/shard-skl7/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20623/shard-skl6/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html

* igt@kms_cursor_legacy@flip-vs-cursor-varying-size:
- shard-skl: [PASS][77] -> [FAIL][78] ([i915#2346])
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10345/shard-skl4/igt@[email protected]
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20623/shard-skl10/igt@[email protected]

* igt@kms_cursor_legacy@pipe-d-single-bo:
- shard-apl: NOTRUN -> [SKIP][79] ([fdo#109271] / [i915#533])
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20623/shard-apl8/igt@[email protected]

* igt@kms_draw_crc@draw-method-rgb565-render-untiled:
- shard-glk: [PASS][80] -> [FAIL][81] ([i915#3451])
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10345/shard-glk3/igt@[email protected]
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20623/shard-glk2/igt@[email protected]

* igt@kms_flip@2x-flip-vs-wf_vblank-interruptible:
- shard-iclb: NOTRUN -> [SKIP][82] ([fdo#109274]) +3 similar issues
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20623/shard-iclb5/igt@kms_flip@2x-flip-vs-wf_vblank-interruptible.html

* igt@kms_flip@flip-vs-absolute-wf_vblank-interruptible@c-edp1:
- shard-skl: [PASS][83] -> [FAIL][84] ([i915#2122])
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10345/shard-skl10/igt@kms_flip@[email protected]
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20623/shard-skl9/igt@kms_flip@[email protected]

* igt@kms_flip@flip-vs-expired-vblank-interruptible@b-edp1:
- shard-skl: [PASS][85] -> [FAIL][86] ([i915#79])
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10345/shard-skl7/igt@kms_flip@[email protected]
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20623/shard-skl2/igt@kms_flip@[email protected]

* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs:
- shard-apl: NOTRUN -> [SKIP][87] ([fdo#109271] / [i915#2672])
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20623/shard-apl7/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytilegen12rcccs.html

* igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilercccs:
- shard-kbl: NOTRUN -> [SKIP][88] ([fdo#109271] / [i915#2672])
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20623/shard-kbl3/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-indfb-plflip-blt:
- shard-skl: NOTRUN -> [SKIP][89] ([fdo#109271]) +21 similar issues
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20623/shard-skl5/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-spr-indfb-draw-mmap-cpu:
- shard-iclb: NOTRUN -> [SKIP][90] ([fdo#109280]) +18 similar issues
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20623/shard-iclb6/igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-spr-indfb-draw-mmap-cpu.html

* igt@kms_frontbuffer_tracking@psr-2p-primscrn-shrfb-plflip-blt:
- shard-tglb: NOTRUN -> [SKIP][91] ([fdo#111825]) +3 similar issues
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20623/shard-tglb2/igt@[email protected]

* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
- shard-apl: NOTRUN -> [DMESG-WARN][92] ([i915#180])
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20623/shard-apl1/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-b-constant-alpha-max:
- shard-apl: NOTRUN -> [FAIL][93] ([fdo#108145] / [i915#265]) +2 similar issues
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20623/shard-apl1/igt@[email protected]

* igt@kms_plane_lowres@pipe-a-tiling-yf:
- shard-iclb: NOTRUN -> [SKIP][94] ([i915#3536]) +1 similar issue
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20623/shard-iclb6/igt@[email protected]

* igt@kms_plane_lowres@pipe-b-tiling-yf:
- shard-tglb: NOTRUN -> [SKIP][95] ([fdo#112054])
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20623/shard-tglb7/igt@[email protected]

* igt@kms_plane_lowres@pipe-c-tiling-x:
- shard-tglb: NOTRUN -> [SKIP][96] ([i915#3536])
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20623/shard-tglb3/igt@[email protected]

* igt@kms_plane_scaling@scaler-with-clipping-clamping@pipe-c-scaler-with-clipping-clamping:
- shard-apl: NOTRUN -> [SKIP][97] ([fdo#109271] / [i915#2733])
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20623/shard-apl8/igt@kms_plane_scaling@scaler-with-clipping-clamping@pipe-c-scaler-with-clipping-clamping.html

* igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-1:
- shard-kbl: NOTRUN -> [SKIP][98] ([fdo#109271] / [i915#658]) +1 similar issue
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20623/shard-kbl4/igt@[email protected]

* igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-2:
- shard-tglb: NOTRUN -> [SKIP][99] ([i915#2920])
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20623/shard-tglb3/igt@[email protected]

* igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-4:
- shard-iclb: NOTRUN -> [SKIP][100] ([i915#658]) +1 similar issue
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20623/shard-iclb5/igt@[email protected]

* igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-4:
- shard-apl: NOTRUN -> [SKIP][101] ([fdo#109271] / [i915#658]) +4 similar issues
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20623/shard-apl6/igt@[email protected]

* igt@kms_psr2_su@page_flip:
- shard-iclb: [PASS][102] -> [SKIP][103] ([fdo#109642] / [fdo#111068] / [i915#658])
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10345/shard-iclb2/igt@kms_psr2_su@page_flip.html
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20623/shard-iclb5/igt@kms_psr2_su@page_flip.html

* igt@kms_psr@psr2_cursor_mmap_cpu:
- shard-iclb: NOTRUN -> [SKIP][104] ([fdo#109441])
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20623/shard-iclb5/igt@kms_psr@psr2_cursor_mmap_cpu.html

* igt@kms_psr@psr2_sprite_blt:
- shard-iclb: [PASS][105] -> [SKIP][106] ([fdo#109441]) +1 similar issue
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10345/shard-iclb2/igt@kms_psr@psr2_sprite_blt.html
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20623/shard-iclb7/igt@kms_psr@psr2_sprite_blt.html

* igt@kms_vblank@pipe-b-ts-continuation-suspend:
- shard-kbl: NOTRUN -> [DMESG-WARN][107] ([i915#180])
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20623/shard-kbl3/igt@[email protected]

* igt@nouveau_crc@pipe-c-source-outp-complete:
- shard-iclb: NOTRUN -> [SKIP][108] ([i915#2530])
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20623/shard-iclb5/igt@[email protected]

* igt@prime_nv_pcopy@test3_1:
- shard-tglb: NOTRUN -> [SKIP][109] ([fdo#109291]) +1 similar issue
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20623/shard-tglb3/igt@prime_nv_pcopy@test3_1.html

* igt@prime_nv_test@i915_import_pread_pwrite:
- shard-iclb: NOTRUN -> [SKIP][110] ([fdo#109291]) +1 similar issue
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20623/shard-iclb7/igt@prime_nv_test@i915_import_pread_pwrite.html

* igt@sysfs_clients@fair-1:
- shard-apl: NOTRUN -> [SKIP][111] ([fdo#109271] / [i915#2994]) +4 similar issues
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20623/shard-apl8/igt@[email protected]

* igt@sysfs_clients@split-10:
- shard-tglb: NOTRUN -> [SKIP][112] ([i915#2994])
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20623/shard-tglb7/igt@[email protected]

#### Possible fixes ####

* igt@fbdev@nullptr:
- {shard-rkl}: [SKIP][113] ([i915#2582]) -> [PASS][114]
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10345/shard-rkl-1/igt@[email protected]
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20623/shard-rkl-6/igt@[email protected]

* igt@gem_ctx_persistence@many-contexts:
- {shard-rkl}: [FAIL][115] ([i915#2410]) -> [PASS][116] +1 similar issue
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10345/shard-rkl-5/igt@[email protected]
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20623/shard-rkl-2/igt@[email protected]

* igt@gem_eio@hibernate:
- {shard-rkl}: [INCOMPLETE][117] -> [PASS][118]
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10345/shard-rkl-6/igt@[email protected]
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20623/shard-rkl-1/igt@[email protected]

* igt@gem_exec_fair@basic-flow@rcs0:
- shard-tglb: [FAIL][119] ([i915#2842]) -> [PASS][120] +2 similar issues
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10345/shard-tglb2/igt@gem_exec_fair@[email protected]
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20623/shard-tglb1/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-none-share@rcs0:
- shard-iclb: [FAIL][121] ([i915#2842]) -> [PASS][122]
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10345/shard-iclb6/igt@gem_exec_fair@[email protected]
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20623/shard-iclb8/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-none-solo@rcs0:
- shard-kbl: [FAIL][123] ([i915#2842]) -> [PASS][124]
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10345/shard-kbl4/igt@gem_exec_fair@[email protected]
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20623/shard-kbl2/igt@gem_exec_fair@[email protected]
- {shard-rkl}: [FAIL][125] ([i915#2842]) -> [PASS][126]
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10345/shard-rkl-1/igt@gem_exec_fair@[email protected]
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20623/shard-rkl-1/igt@gem_exec_fair@[email protected]

* igt@gem_exec_whisper@basic-normal-all:
- shard-glk: [DMESG-WARN][127] ([i915#118] / [i915#95]) -> [PASS][128]
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10345/shard-glk3/igt@[email protected]
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20623/shard-glk6/igt@[email protected]

* igt@i915_pm_backlight@fade:
- {shard-rkl}: [SKIP][129] ([i915#3012]) -> [PASS][130]
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10345/shard-rkl-5/igt@[email protected]
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20623/shard-rkl-6/igt@[email protected]

* igt@i915_pm_dc@dc5-psr:
- shard-iclb: [DMESG-WARN][131] ([i915#3698]) -> [PASS][132]
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10345/shard-iclb5/igt@[email protected]
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20623/shard-iclb6/igt@[email protected]

* igt@i915_pm_rpm@basic-rte:
- {shard-rkl}: [SKIP][133] ([fdo#109308]) -> [PASS][134]
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10345/shard-rkl-1/igt@[email protected]
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20623/shard-rkl-6/igt@[email protected]

* igt@i915_pm_rpm@modeset-lpsp-stress:
- {shard-rkl}: [SKIP][135] ([i915#1397]) -> [PASS][136] +1 similar issue
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10345/shard-rkl-1/igt@[email protected]
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20623/shard-rkl-6/igt@[email protected]

* igt@i915_suspend@sysfs-reader:
- shard-apl: [DMESG-WARN][137] ([i915#180]) -> [PASS][138]
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10345/shard-apl1/igt@[email protected]
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20623/shard-apl6/igt@[email protected]

* igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-180-hflip-async-flip:
- {shard-rkl}: [SKIP][139] ([i915#3721]) -> [PASS][140] +5 similar issues
[139]: https://intel-gfx-ci.01.or

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20623/index.html

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Reviewed-by on v1 1/1
#4 lore raw
In reply to Manasi Navare

Patch looks good to me.

Please find below some suggestions

Quoted 9 lines · Manasi Navare

Currently when we do the HW state readout, we dont set the shared dpll to NULL for the bigjoiner slave which should not have a DPLL assigned. So it has some garbage while the HW state readout is NULL. So explicitly reset the shared dpll for bigjoiner slave pipe.

checkpatch warning about tested-by tag.

Quoted 10 lines
---
  drivers/gpu/drm/i915/display/intel_display.c | 4 ++++
  1 file changed, 4 insertions(+)
drivers/gpu/drm/i915/display/intel_display.c +0 -0
index 65ddb6ca16e6..c274bfb8e549 100644

drivers/gpu/drm/i915/display/intel_display.c verify_crtc_state(struct intel_crtc *crtc, · line 9012

Quoted 7 lines
drivers/gpu/drm/i915/display/intel_display.c +4 -0
@@ -9006,6 +9006,10 @@ verify_crtc_state(struct intel_crtc *crtc,
  	if (!new_crtc_state->hw.active)
  		return;
 
+	if (new_crtc_state->bigjoiner_slave)
+		/* No PLLs set for slave */
+		pipe_config->shared_dpll = NULL;
+

there is a check for bigjoiner_slave, couple of lines above this:

if (new_crtc_state->bigjoiner_slave)
                master = new_crtc_state->bigjoiner_linked_crtc;

Perhaps it will make sense to club the set shared_dpll to NULL, along with these lines.

In any case:

drivers/gpu/drm/i915/display/intel_display.c verify_crtc_state(struct intel_crtc *crtc, · line 9015

Quoted 3 lines
drivers/gpu/drm/i915/display/intel_display.c +0 -0
  	intel_pipe_config_sanity_check(dev_priv, pipe_config);
 
  	if (!intel_pipe_config_compare(new_crtc_state,

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#5 lore raw
Quoted 34 lines · Ankit K

Patch looks good to me.

Please find below some suggestions

Quoted 9 lines · Manasi Navare

Currently when we do the HW state readout, we dont set the shared dpll to NULL for the bigjoiner slave which should not have a DPLL assigned. So it has some garbage while the HW state readout is NULL. So explicitly reset the shared dpll for bigjoiner slave pipe.

checkpatch warning about tested-by tag.

Quoted 10 lines
---
 drivers/gpu/drm/i915/display/intel_display.c | 4 ++++
 1 file changed, 4 insertions(+)
drivers/gpu/drm/i915/display/intel_display.c +0 -0
index 65ddb6ca16e6..c274bfb8e549 100644

drivers/gpu/drm/i915/display/intel_display.c verify_crtc_state(struct intel_crtc *crtc, · line 9011

Quoted 6 lines
drivers/gpu/drm/i915/display/intel_display.c +4 -0
@@ -9006,6 +9006,10 @@ verify_crtc_state(struct intel_crtc *crtc,
 	if (!new_crtc_state->hw.active)
 		return;
+	if (new_crtc_state->bigjoiner_slave)
+		/* No PLLs set for slave */
+		pipe_config->shared_dpll = NULL;
+

there is a check for bigjoiner_slave, couple of lines above this:

Quoted 5 lines

if (new_crtc_state->bigjoiner_slave)
                master = new_crtc_state->bigjoiner_linked_crtc;

Perhaps it will make sense to club the set shared_dpll to NULL, along with these lines.

Yup, thats where I was resetting in earlier patch but then it actually gets overridden in a function call after this point so need to reset it after separately.

Manasi

Quoted 7 lines

In any case:

Quoted 2 lines
drivers/gpu/drm/i915/display/intel_display.c +0 -0
 	intel_pipe_config_sanity_check(dev_priv, pipe_config);
 	if (!intel_pipe_config_compare(new_crtc_state,

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#6 lore raw
Quoted 37 lines · Manasi
Quoted 36 lines · Ankit K

Patch looks good to me.

Please find below some suggestions

Quoted 9 lines · Manasi Navare

Currently when we do the HW state readout, we dont set the shared dpll to NULL for the bigjoiner slave which should not have a DPLL assigned. So it has some garbage while the HW state readout is NULL. So explicitly reset the shared dpll for bigjoiner slave pipe.

checkpatch warning about tested-by tag.

Quoted 10 lines
---
  drivers/gpu/drm/i915/display/intel_display.c | 4 ++++
  1 file changed, 4 insertions(+)
drivers/gpu/drm/i915/display/intel_display.c +0 -0
index 65ddb6ca16e6..c274bfb8e549 100644

drivers/gpu/drm/i915/display/intel_display.c verify_crtc_state(struct intel_crtc *crtc, · line 9011

Quoted 6 lines
drivers/gpu/drm/i915/display/intel_display.c +4 -0
@@ -9006,6 +9006,10 @@ verify_crtc_state(struct intel_crtc *crtc,
  	if (!new_crtc_state->hw.active)
  		return;
+	if (new_crtc_state->bigjoiner_slave)
+		/* No PLLs set for slave */
+		pipe_config->shared_dpll = NULL;
+

there is a check for bigjoiner_slave, couple of lines above this:

if (new_crtc_state->bigjoiner_slave)
                master = new_crtc_state->bigjoiner_linked_crtc;

Quoted 6 lines
Quoted 2 lines

Perhaps it will make sense to club the set shared_dpll to NULL, along with these lines.

Yup, thats where I was resetting in earlier patch but then it actually gets overridden in a function call after this point so need to reset it after separately.

Manasi

You are right. I missed that, pipe_config gets overwritten just before this point, so the change is at the right place.

Regards,

Ankit

Quoted 7 lines
Quoted 7 lines

In any case:

Quoted 2 lines
drivers/gpu/drm/i915/display/intel_display.c +0 -0
  	intel_pipe_config_sanity_check(dev_priv, pipe_config);
  	if (!intel_pipe_config_compare(new_crtc_state,

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

author Applied
#7 lore raw

Pushed to drm-intel-next, tahnks for the reviews.

Manasi

Quoted 44 lines · Ankit K
Quoted 42 lines · Manasi
Quoted 33 lines · Ankit K

Patch looks good to me.

Please find below some suggestions

Quoted 9 lines · Manasi Navare

Currently when we do the HW state readout, we dont set the shared dpll to NULL for the bigjoiner slave which should not have a DPLL assigned. So it has some garbage while the HW state readout is NULL. So explicitly reset the shared dpll for bigjoiner slave pipe.

checkpatch warning about tested-by tag.

Quoted 10 lines
---
 drivers/gpu/drm/i915/display/intel_display.c | 4 ++++
 1 file changed, 4 insertions(+)
drivers/gpu/drm/i915/display/intel_display.c +0 -0
index 65ddb6ca16e6..c274bfb8e549 100644

drivers/gpu/drm/i915/display/intel_display.c verify_crtc_state(struct intel_crtc *crtc, · line 9011

Quoted 6 lines
drivers/gpu/drm/i915/display/intel_display.c +4 -0
@@ -9006,6 +9006,10 @@ verify_crtc_state(struct intel_crtc *crtc,
 	if (!new_crtc_state->hw.active)
 		return;
+	if (new_crtc_state->bigjoiner_slave)
+		/* No PLLs set for slave */
+		pipe_config->shared_dpll = NULL;
+

there is a check for bigjoiner_slave, couple of lines above this:

Quoted 5 lines

if (new_crtc_state->bigjoiner_slave)
                master = new_crtc_state->bigjoiner_linked_crtc;

Perhaps it will make sense to club the set shared_dpll to NULL, along with these lines.

Yup, thats where I was resetting in earlier patch but then it actually gets overridden in a function call after this point so need to reset it after separately.

Quoted 17 lines
Quoted 1 line

Manasi

You are right. I missed that, pipe_config gets overwritten just before this point, so the change is at the right place.

Regards,

Ankit

Quoted 7 lines
Quoted 7 lines

In any case:

Quoted 2 lines
drivers/gpu/drm/i915/display/intel_display.c +0 -0
 	intel_pipe_config_sanity_check(dev_priv, pipe_config);
 	if (!intel_pipe_config_compare(new_crtc_state,

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

maintainer
#8 lore raw
In reply to Manasi Navare
Quoted 19 lines · Manasi Navare

Currently when we do the HW state readout, we dont set the shared dpll to NULL for the bigjoiner slave which should not have a DPLL assigned. So it has some garbage while the HW state readout is NULL. So explicitly reset the shared dpll for bigjoiner slave pipe.

---
 drivers/gpu/drm/i915/display/intel_display.c | 4 ++++
 1 file changed, 4 insertions(+)
drivers/gpu/drm/i915/display/intel_display.c +0 -0
index 65ddb6ca16e6..c274bfb8e549 100644

drivers/gpu/drm/i915/display/intel_display.c verify_crtc_state(struct intel_crtc *crtc, · line 9012

Quoted 7 lines
drivers/gpu/drm/i915/display/intel_display.c +4 -0
@@ -9006,6 +9006,10 @@ verify_crtc_state(struct intel_crtc *crtc,
 	if (!new_crtc_state->hw.active)
 		return;
 
+	if (new_crtc_state->bigjoiner_slave)
+		/* No PLLs set for slave */
+		pipe_config->shared_dpll = NULL;
+

I know it's been merged already, but feels wrong to have this in verify_crtc_state(). Kind of out of place.

BR,
Jani.

Quoted 3 lines
drivers/gpu/drm/i915/display/intel_display.c +0 -0
 	intel_pipe_config_sanity_check(dev_priv, pipe_config);
 
 	if (!intel_pipe_config_compare(new_crtc_state,
Signature · 1 line
Jani Nikula, Intel Open Source Graphics Center