Skip to contentSkip to conversation

dt-bindings: display: Fix graph 'unevaluatedProperties' related warnings

PATCH Applied Rob Herring 2 participants 4 messages Jul 19, 2021 – Jul 23, 2021

Subsystems (5)
Device tree bindings DRM drivers DRM misc DRM driver for Qualcomm display hardware +1 more subsystems
lore
Share & tools
lore

Rob Herring

author maintainer
#0 lore raw

PATCH 1/1 dt-bindings: display: Fix graph 'unevaluatedProperties' related warnings

The graph schema doesn't allow custom properties on endpoint nodes for '#/properties/port' and '#/$defs/port-base' should be used instead. This doesn't matter until 'unevaluatedProperties' support is implemented.

Cc David Airlie <[email protected]>
Cc Daniel Vetter <[email protected]>
Cc Rob Clark <[email protected]>
Cc Sean Paul <[email protected]>
Cc Marek Vasut <[email protected]>
Cc Krishna Manikandan <[email protected]>
Cc [email protected]
Signed-off-by Rob Herring <[email protected]>
---
 .../devicetree/bindings/display/bridge/ti,sn65dsi83.yaml    | 6 ++++--
 .../bindings/display/msm/dsi-controller-main.yaml           | 6 ++++--
 2 files changed, 8 insertions(+), 4 deletions(-)
Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml +4 -2
index d101233ae17f..07b20383cbca 100644
@@ -37,7 +37,8 @@ properties:
 
     properties:
       port@0:
-        $ref: /schemas/graph.yaml#/properties/port
+        $ref: /schemas/graph.yaml#/$defs/port-base
+        unevaluatedProperties: false
         description: Video port for MIPI DSI Channel-A input
 
         properties:

@@ -57,7 +58,8 @@ properties:
                   - const: 4
 
       port@1:
-        $ref: /schemas/graph.yaml#/properties/port
+        $ref: /schemas/graph.yaml#/$defs/port-base
+        unevaluatedProperties: false
         description: Video port for MIPI DSI Channel-B input
 
         properties:
Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml +4 -2
index 76348b71f736..de23cab9b5f1 100644
@@ -77,7 +77,8 @@ properties:
 
     properties:
       port@0:
-        $ref: "/schemas/graph.yaml#/properties/port"
+        $ref: "/schemas/graph.yaml#/$defs/port-base"
+        unevaluatedProperties: false
         description: |
           Input endpoints of the controller.
         properties:

@@ -92,7 +93,8 @@ properties:
                   enum: [ 0, 1, 2, 3 ]
 
       port@1:
-        $ref: "/schemas/graph.yaml#/properties/port"
+        $ref: "/schemas/graph.yaml#/$defs/port-base"
+        unevaluatedProperties: false
         description: |
           Output endpoints of the controller.
         properties:
Signature · 1 line
2.27.0
Acked-by on v1 1/1
#1 lore raw

Hi Rob,

Quoted 4 lines · Rob Herring

The graph schema doesn't allow custom properties on endpoint nodes for '#/properties/port' and '#/$defs/port-base' should be used instead. This doesn't matter until 'unevaluatedProperties' support is implemented.

Quoted 8 lines
Cc David Airlie <[email protected]>
Cc Daniel Vetter <[email protected]>
Cc Rob Clark <[email protected]>
Cc Sean Paul <[email protected]>
Cc Marek Vasut <[email protected]>
Cc Krishna Manikandan <[email protected]>
Cc [email protected]
Signed-off-by Rob Herring <[email protected]>
Acked-by Sam Ravnborg <[email protected]>
author maintainer
#2 lore raw
Quoted 15 lines · Sam Ravnborg

Hi Rob,

Quoted 4 lines · Rob Herring

The graph schema doesn't allow custom properties on endpoint nodes for '#/properties/port' and '#/$defs/port-base' should be used instead. This doesn't matter until 'unevaluatedProperties' support is implemented.

Quoted 8 lines
Cc David Airlie <[email protected]>
Cc Daniel Vetter <[email protected]>
Cc Rob Clark <[email protected]>
Cc Sean Paul <[email protected]>
Cc Marek Vasut <[email protected]>
Cc Krishna Manikandan <[email protected]>
Cc [email protected]
Signed-off-by Rob Herring <[email protected]>
Quoted 1 line
Acked-by Sam Ravnborg <[email protected]>

Thanks. FYI, your mail only went thru on dri-devel, but not DT or LKML lists.

Rob

author maintainer Applied
#3 lore raw
In reply to Rob Herring
Quoted 12 lines · Rob Herring

The graph schema doesn't allow custom properties on endpoint nodes for '#/properties/port' and '#/$defs/port-base' should be used instead. This doesn't matter until 'unevaluatedProperties' support is implemented.

Cc David Airlie <[email protected]>
Cc Daniel Vetter <[email protected]>
Cc Rob Clark <[email protected]>
Cc Sean Paul <[email protected]>
Cc Marek Vasut <[email protected]>
Cc Krishna Manikandan <[email protected]>
Cc [email protected]
Signed-off-by Rob Herring <[email protected]>
Quoted 5 lines
---
 .../devicetree/bindings/display/bridge/ti,sn65dsi83.yaml    | 6 ++++--
 .../bindings/display/msm/dsi-controller-main.yaml           | 6 ++++--
 2 files changed, 8 insertions(+), 4 deletions(-)

Applied, thanks!