Skip to contentSkip to conversation

dt-bindings: clk: Convert rockchip,rk3399-cru to DT schema

PATCH Applied Nícolas F. R. A. Prado 3 participants 6 messages Jun 10, 2021 – Jul 23, 2021

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dt-bindings: clk: Convert rockchip,rk3399-cru to DT schema

Convert the rockchip,rk3399-cru binding to DT schema format.
Tested with
ARCH=arm64 make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/clock/rockchip,rk3399-cru.yaml ARCH=arm64 make dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/clock/rockchip,rk3399-cru.yaml

---

One caveat is that this node expects certain external clocks, mainly 'xin24m'. From what I read of clock-bindings.txt, it seems the way to make this dependency explicit would be to add 'clocks' and 'clock-names' properties to both the DT and the binding. But since I'm not sure changing the DT ABI is desirable, I just moved that information to the binding description for now.

 .../bindings/clock/rockchip,rk3399-cru.txt    | 68 --------------
 .../bindings/clock/rockchip,rk3399-cru.yaml   | 92 +++++++++++++++++++
 2 files changed, 92 insertions(+), 68 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/clock/rockchip,rk3399-cru.txt
 create mode 100644 Documentation/devicetree/bindings/clock/rockchip,rk3399-cru.yaml
Documentation/devicetree/bindings/clock/rockchip,rk3399-cru.txt deleted +0 -68
deleted file mode 100644
index 3bc56fae90ac..000000000000
@@ -1,68 +0,0 @@
-* Rockchip RK3399 Clock and Reset Unit
-
-The RK3399 clock controller generates and supplies clock to various
-controllers within the SoC and also implements a reset controller for SoC
-peripherals.
-
-Required Properties:
-
-- compatible: PMU for CRU should be "rockchip,rk3399-pmucru"
-- compatible: CRU should be "rockchip,rk3399-cru"
-- reg: physical base address of the controller and length of memory mapped
-  region.
-- #clock-cells: should be 1.
-- #reset-cells: should be 1.
-
-Optional Properties:
-
-- rockchip,grf: phandle to the syscon managing the "general register files".
-  It is used for GRF muxes, if missing any muxes present in the GRF will not
-  be available.
-
-Each clock is assigned an identifier and client nodes can use this identifier
-to specify the clock which they consume. All available clocks are defined as
-preprocessor macros in the dt-bindings/clock/rk3399-cru.h headers and can be
-used in device tree sources. Similar macros exist for the reset sources in
-these files.
-
-External clocks:
-
-There are several clocks that are generated outside the SoC. It is expected
-that they are defined using standard clock bindings with following
-clock-output-names:
- - "xin24m" - crystal input - required,
- - "xin32k" - rtc clock - optional,
- - "clkin_gmac" - external GMAC clock - optional,
- - "clkin_i2s" - external I2S clock - optional,
- - "pclkin_cif" - external ISP clock - optional,
- - "clk_usbphy0_480m" - output clock of the pll in the usbphy0
- - "clk_usbphy1_480m" - output clock of the pll in the usbphy1
-
-Example: Clock controller node:
-
-	pmucru: pmu-clock-controller@ff750000 {
-		compatible = "rockchip,rk3399-pmucru";
-		reg = <0x0 0xff750000 0x0 0x1000>;
-		#clock-cells = <1>;
-		#reset-cells = <1>;
-	};
-
-	cru: clock-controller@ff760000 {
-		compatible = "rockchip,rk3399-cru";
-		reg = <0x0 0xff760000 0x0 0x1000>;
-		#clock-cells = <1>;
-		#reset-cells = <1>;
-	};
-
-Example: UART controller node that consumes the clock generated by the clock
-  controller:
-
-	uart0: serial@ff1a0000 {
-		compatible = "rockchip,rk3399-uart", "snps,dw-apb-uart";
-		reg = <0x0 0xff180000 0x0 0x100>;
-		clocks = <&cru SCLK_UART0>, <&cru PCLK_UART0>;
-		clock-names = "baudclk", "apb_pclk";
-		interrupts = <GIC_SPI 99 IRQ_TYPE_LEVEL_HIGH>;
-		reg-shift = <2>;
-		reg-io-width = <4>;
-	};
Documentation/devicetree/bindings/clock/rockchip,rk3399-cru.yaml new file +92 -0

92 lines not on this page · raw message

Signature · 1 line
2.32.0
maintainer Reviewed-by on v1 1/1
#1 lore raw
Quoted 10 lines · Nícolas F. R. A. Prado

Convert the rockchip,rk3399-cru binding to DT schema format.
Tested with
ARCH=arm64 make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/clock/rockchip,rk3399-cru.yaml ARCH=arm64 make dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/clock/rockchip,rk3399-cru.yaml

---

One caveat is that this node expects certain external clocks, mainly 'xin24m'.

#2 lore raw
Quoted 6 lines · Rob Herring
Quoted 5 lines · Nícolas F. R. A. Prado

Convert the rockchip,rk3399-cru binding to DT schema format.
Tested with
ARCH=arm64 make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/clock/rockchip,rk3399-cru.yaml ARCH=arm64 make dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/clock/rockchip,rk3399-cru.yaml

Quoted 7 lines
Quoted 5 lines

---

One caveat is that this node expects certain external clocks, mainly 'xin24m'.

Thanks! Is this blocked on something else?

Thanks,
Nícolas

_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip

maintainer
#3 lore raw
Quoted 11 lines · Nícolas F. R. A. Prado
Quoted 9 lines · Rob Herring
Quoted 8 lines · Nícolas F. R. A. Prado

Convert the rockchip,rk3399-cru binding to DT schema format.
Tested with
ARCH=arm64 make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/clock/rockchip,rk3399-cru.yaml ARCH=arm64 make dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/clock/rockchip,rk3399-cru.yaml

---

Quoted 6 lines
Quoted 4 lines
Quoted 2 lines

One caveat is that this node expects certain external clocks, mainly 'xin24m'.

Thanks! Is this blocked on something else?

I'm expecting Stephen to pick this up.

Rob

_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip

maintainer
#4 lore raw

Am Montag, 19. Juli 2021, 22:12:10 CEST schrieb Rob Herring:

Quoted 13 lines
Quoted 11 lines · Nícolas F. R. A. Prado
Quoted 9 lines · Rob Herring
Quoted 8 lines · Nícolas F. R. A. Prado

Convert the rockchip,rk3399-cru binding to DT schema format.
Tested with
ARCH=arm64 make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/clock/rockchip,rk3399-cru.yaml ARCH=arm64 make dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/clock/rockchip,rk3399-cru.yaml

---

Quoted 8 lines
Quoted 6 lines
Quoted 4 lines
Quoted 2 lines

One caveat is that this node expects certain external clocks, mainly 'xin24m'.

Thanks! Is this blocked on something else?

I'm expecting Stephen to pick this up.

actually I'm expecting me to pick this up ;-)

With the merge window closing last sunday I haven't made my way that far down my inbox yet. I'll just fix that right now :-)

Heiko

_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip

maintainer Applied
#5 lore raw
In reply to Nícolas F. R. A. Prado
Quoted 4 lines · Nícolas F. R. A. Prado

Convert the rockchip,rk3399-cru binding to DT schema format.
Tested with
ARCH=arm64 make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/clock/rockchip,rk3399-cru.yaml ARCH=arm64 make dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/clock/rockchip,rk3399-cru.yaml

Applied, thanks!

[1/1] dt-bindings: clk: Convert rockchip,rk3399-cru to DT schema

      commit: d475653672b730a30bd1391f68c98f450afaf725

Best regards,

Signature · 1 line
Heiko Stuebner <[email protected]>