board/mx6cubox: Switch to extlinux.conf
PATCH v2 1/1 board/mx6cubox: Switch to extlinux.conf
Currently mx6cubox uses a custom boot.scr.txt script and custom image generation scripts: genimage.cfg, post-build.sh and post-image.sh.
Switch to using the more standard extlinux.conf solution and remove the custom scripts in favor of the standard board/freescale/common/imx/post-image.sh one.
---
Changes since v1:
- Fix the console variable to avoid passing the baudrate twice:
console=ttymxc0,115200,115200
board/solidrun/mx6cubox/boot.scr.txt | 7 ---- board/solidrun/mx6cubox/genimage.cfg | 29 -------------- ...xi-Fix-the-mmc-device-for-the-rootfs.patch | 29 ++++++++++++++ ...2-mx6cuboxi-Fix-the-console-variable.patch | 40 +++++++++++++++++++ board/solidrun/mx6cubox/post-build.sh | 8 ---- board/solidrun/mx6cubox/post-image.sh | 14 ------- .../boot/extlinux/extlinux.conf | 4 ++ configs/mx6cubox_defconfig | 5 ++- 8 files changed, 76 insertions(+), 60 deletions(-) delete mode 100644 board/solidrun/mx6cubox/boot.scr.txt delete mode 100644 board/solidrun/mx6cubox/genimage.cfg create mode 100644 board/solidrun/mx6cubox/patches/uboot/0001-mx6cuboxi-Fix-the-mmc-device-for-the-rootfs.patch create mode 100644 board/solidrun/mx6cubox/patches/uboot/0002-mx6cuboxi-Fix-the-console-variable.patch delete mode 100755 board/solidrun/mx6cubox/post-build.sh delete mode 100755 board/solidrun/mx6cubox/post-image.sh create mode 100644 board/solidrun/mx6cubox/rootfs_overlay/boot/extlinux/extlinux.conf
board/solidrun/mx6cubox/boot.scr.txt deleted +0 -7
@@ -1,7 +0,0 @@ -setenv finduuid "part uuid mmc 1:1 uuid" -run finduuid -run findfdt -setenv bootargs "console=ttymxc0,115200 root=PARTUUID=${uuid} rootwait rootfstype=ext4" -load mmc 1:1 ${fdt_addr} boot/${fdtfile} -load mmc 1:1 ${loadaddr} boot/zImage -bootz ${loadaddr} - ${fdt_addr}
board/solidrun/mx6cubox/genimage.cfg deleted +0 -29
@@ -1,29 +0,0 @@ -# Minimal SD card image for the MX6 Cubox/Hummingboard -# -# U-Boot SPL and u-boot.img are flashed in the first 1MB raw partition. -# A single root filesystem partition is used (Ext4 in this case). -# - -image sdcard.img { - hdimage { - } - - partition spl { - in-partition-table = "no" - image = "SPL" - offset = 1K - } - - partition u-boot { - in-partition-table = "no" - image = "u-boot.img" - offset = 69K - } - - partition rootfs { - partition-type = 0x83 - image = "rootfs.ext4" - offset = 1M - size = 512M - } -}
board/solidrun/mx6cubox/patches/uboot/0001-mx6cuboxi-Fix-the-mmc-device-for-the-rootfs.patch new file +29 -0
@@ -0,0 +1,29 @@ +From 96db7c072b96f9b7a1d9a986eff20353f7459004 Mon Sep 17 00:00:00 2001 +From: Fabio Estevam <[email protected]> +Date: Sun, 18 Jul 2021 19:08:36 -0300 +Subject: [PATCH] mx6cuboxi: Fix the mmc device for the rootfs + +After the comversion to DM_MMC, the rootfs is mmc 1, so +adjust it accordingly. + +Signed-off-by: Fabio Estevam <[email protected]> +--- + include/configs/mx6cuboxi.h | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/include/configs/mx6cuboxi.h b/include/configs/mx6cuboxi.h +index 55717c77ab38..1a06f29b8c17 100644 +--- a/include/configs/mx6cuboxi.h ++++ b/include/configs/mx6cuboxi.h +@@ -57,7 +57,7 @@ + "console=" CONSOLE_DEV ",115200\0" \ + "bootm_size=0x10000000\0" \ + "mmcdev=" __stringify(CONFIG_SYS_MMC_ENV_DEV) "\0" \ +- "finduuid=part uuid mmc 0:1 uuid\0" \ ++ "finduuid=part uuid mmc 1:1 uuid\0" \ + "update_sd_firmware=" \ + "if test ${ip_dyn} = yes; then " \ + "setenv get_cmd dhcp; " \ +-- +2.25.1 +
board/solidrun/mx6cubox/patches/uboot/0002-mx6cuboxi-Fix-the-console-variable.patch new file +40 -0
@@ -0,0 +1,40 @@ +From ab1dd9332c379164925aee755a013dbd8839501b Mon Sep 17 00:00:00 2001 +From: Fabio Estevam <[email protected]> +Date: Mon, 19 Jul 2021 16:48:07 -0300 +Subject: [PATCH 2/2] mx6cuboxi: Fix the console variable + +Do not pass the console baudrate to the 'console' variable +to avoid the baudrate being passed twice when using extlinux.conf: + +cat /proc/cmdline +root=PARTUUID=00000000-01 rootwait rw console=ttymxc0,115200,115200 + +Signed-off-by: Fabio Estevam <[email protected]> +--- + include/configs/mx6cuboxi.h | 3 +-- + 1 file changed, 1 insertion(+), 2 deletions(-) + +diff --git a/include/configs/mx6cuboxi.h b/include/configs/mx6cuboxi.h +index 1a06f29b8c17..9e5083b0d876 100644 +--- a/include/configs/mx6cuboxi.h ++++ b/include/configs/mx6cuboxi.h +@@ -38,7 +38,6 @@ + /* Command definition */ + + #define CONFIG_MXC_UART_BASE UART1_BASE +-#define CONSOLE_DEV "ttymxc0" + + #ifndef CONFIG_SPL_BUILD + #define CONFIG_EXTRA_ENV_SETTINGS \ +@@ -54,7 +53,7 @@ + "ramdiskaddr=0x13000000\0" \ + "initrd_high=0xffffffff\0" \ + "ip_dyn=yes\0" \ +- "console=" CONSOLE_DEV ",115200\0" \ ++ "console=ttymxc0\0" \ + "bootm_size=0x10000000\0" \ + "mmcdev=" __stringify(CONFIG_SYS_MMC_ENV_DEV) "\0" \ + "finduuid=part uuid mmc 1:1 uuid\0" \ +-- +2.25.1 +
board/solidrun/mx6cubox/post-build.sh deleted +0 -8
@@ -1,8 +0,0 @@ -#!/bin/sh - -BOARD_DIR="$(dirname $0)" - -install -d -m 755 $TARGET_DIR/boot - -$HOST_DIR/bin/mkimage -A arm -O linux -T script -C none \ - -n "boot script" -d $BOARD_DIR/boot.scr.txt $TARGET_DIR/boot/boot.scr
board/solidrun/mx6cubox/post-image.sh deleted +0 -14
@@ -1,14 +0,0 @@ -#!/usr/bin/env bash - -BOARD_DIR="$(dirname $0)" -GENIMAGE_CFG="${BOARD_DIR}/genimage.cfg" -GENIMAGE_TMP="${BUILD_DIR}/genimage.tmp" - -rm -rf "${GENIMAGE_TMP}" - -genimage \ - --rootpath "${TARGET_DIR}" \ - --tmppath "${GENIMAGE_TMP}" \ - --inputpath "${BINARIES_DIR}" \ - --outputpath "${BINARIES_DIR}" \ - --config "${GENIMAGE_CFG}"
board/solidrun/mx6cubox/rootfs_overlay/boot/extlinux/extlinux.conf new file +4 -0
@@ -0,0 +1,4 @@ +Label imx6qdl-cubox Buildroot + kernel ../zImage + fdtdir ../ + append root=PARTUUID=${uuid} rootwait rw console=${console},${baudrate}
configs/mx6cubox_defconfig +3 -2
@@ -11,8 +11,9 @@ BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_5_10=y # System configuration BR2_TARGET_GENERIC_GETTY_PORT="ttymxc0" -BR2_ROOTFS_POST_BUILD_SCRIPT="board/solidrun/mx6cubox/post-build.sh" -BR2_ROOTFS_POST_IMAGE_SCRIPT="board/solidrun/mx6cubox/post-image.sh" +BR2_ROOTFS_OVERLAY="board/solidrun/mx6cubox/rootfs_overlay" +BR2_ROOTFS_POST_IMAGE_SCRIPT="board/freescale/common/imx/post-image.sh" +BR2_GLOBAL_PATCH_DIR="board/solidrun/mx6cubox/patches" # Kernel BR2_LINUX_KERNEL=y
Signature · 1 line
2.25.1
PATCH v2 1/1 board/mx6cubox: Switch to extlinux.conf
Le lun. 19 juil. 2021 ? 21:55, Fabio Estevam <[email protected]> a ?crit :
Quoted 8 lines
Currently mx6cubox uses a custom boot.scr.txt script and custom image generation scripts: genimage.cfg,
post-build.shandpost-image.sh.Switch to using the more standard extlinux.conf solution and remove the custom scripts in favor of the standard
board/freescale/common/imx/post-image.shone.
Quoted 7 lines
Signed-off-by Fabio Estevam <[email protected]>---
Changes since v1:
- Fix the console variable to avoid passing the baudrate twice:
console=ttymxc0,115200,115200
Now fixed:
# cat /proc/cmdline root=PARTUUID=00000000-01 rootwait rw console=ttymxc0,115200
Quoted 225 lines
board/solidrun/mx6cubox/boot.scr.txt | 7 ---- board/solidrun/mx6cubox/genimage.cfg | 29 -------------- ...xi-Fix-the-mmc-device-for-the-rootfs.patch | 29 ++++++++++++++ ...2-mx6cuboxi-Fix-the-console-variable.patch | 40 +++++++++++++++++++ board/solidrun/mx6cubox/post-build.sh | 8 ---- board/solidrun/mx6cubox/post-image.sh | 14 ------- .../boot/extlinux/extlinux.conf | 4 ++ configs/mx6cubox_defconfig | 5 ++- 8 files changed, 76 insertions(+), 60 deletions(-) delete mode 100644 board/solidrun/mx6cubox/boot.scr.txt delete mode 100644 board/solidrun/mx6cubox/genimage.cfg create mode 100644 board/solidrun/mx6cubox/patches/uboot/0001-mx6cuboxi-Fix-the-mmc-device-for-the-rootfs.patch create mode 100644 board/solidrun/mx6cubox/patches/uboot/0002-mx6cuboxi-Fix-the-console-variable.patch delete mode 100755 board/solidrun/mx6cubox/post-build.sh delete mode 100755 board/solidrun/mx6cubox/post-image.sh create mode 100644
board/solidrun/mx6cubox/rootfs_overlay/boot/extlinux/extlinux.confboard/solidrun/mx6cubox/boot.scr.txt deleted +0
-4@@ -1,7 +0,0 @@ -setenv finduuid "part uuid mmc 1:1 uuid" -run finduuid -run findfdt -setenv bootargs "console=ttymxc0,115200 root=PARTUUID=${uuid} rootwaitrootfstype=ext4"
board/solidrun/mx6cubox/boot.scr.txt deleted +0
-3-load mmc 1:1 ${fdt_addr} boot/${fdtfile} -load mmc 1:1 ${loadaddr} boot/zImage -bootz ${loadaddr} - ${fdt_addr}board/solidrun/mx6cubox/genimage.cfg deleted +0
-29@@ -1,29 +0,0 @@ -# Minimal SD card image for the MX6 Cubox/Hummingboard -# -# U-Boot SPL and u-boot.img are flashed in the first 1MB raw partition. -# A single root filesystem partition is used (Ext4 in this case). -# - -image sdcard.img { - hdimage { - } - - partition spl { - in-partition-table = "no" - image = "SPL" - offset = 1K - } - - partition u-boot { - in-partition-table = "no" - image = "u-boot.img" - offset = 69K - } - - partition rootfs { - partition-type = 0x83 - image = "rootfs.ext4" - offset = 1M - size = 512M - } -}diff --git
a/board/solidrun/mx6cubox/patches/uboot/0001-mx6cuboxi-Fix-the-mmc-device-for-the-rootfs.patchb/board/solidrun/mx6cubox/patches/uboot/0001-mx6cuboxi-Fix-the-mmc-device-for-the-rootfs.patchnew file mode 100644
index 000000000000..b9755a042b1d
---/dev/null
+++b/board/solidrun/mx6cubox/patches/uboot/0001-mx6cuboxi-Fix-the-mmc-device-for-the-rootfs.patchboard/solidrun/mx6cubox/genimage.cfg deleted +29
-0@@ -0,0 +1,29 @@ +From 96db7c072b96f9b7a1d9a986eff20353f7459004 Mon Sep 17 00:00:00 2001 +From: Fabio Estevam <[email protected]> +Date: Sun, 18 Jul 2021 19:08:36 -0300 +Subject: [PATCH] mx6cuboxi: Fix the mmc device for the rootfs + +After the comversion to DM_MMC, the rootfs is mmc 1, so +adjust it accordingly. + +Signed-off-by: Fabio Estevam <[email protected]> +--- + include/configs/mx6cuboxi.h | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/include/configs/mx6cuboxi.h b/include/configs/mx6cuboxi.h +index 55717c77ab38..1a06f29b8c17 100644 +--- a/include/configs/mx6cuboxi.h ++++ b/include/configs/mx6cuboxi.h +@@ -57,7 +57,7 @@ + "console=" CONSOLE_DEV ",115200\0" \ + "bootm_size=0x10000000\0" \ + "mmcdev=" __stringify(CONFIG_SYS_MMC_ENV_DEV) "\0" \ +- "finduuid=part uuid mmc 0:1 uuid\0" \ ++ "finduuid=part uuid mmc 1:1 uuid\0" \ + "update_sd_firmware=" \ + "if test ${ip_dyn} = yes; then " \ + "setenv get_cmd dhcp; " \ +-- +2.25.1 +diff --git
a/board/solidrun/mx6cubox/patches/uboot/0002-mx6cuboxi-Fix-the-console-variable.patchb/board/solidrun/mx6cubox/patches/uboot/0002-mx6cuboxi-Fix-the-console-variable.patchnew file mode 100644
index 000000000000..c02134101fc4
---/dev/null
+++b/board/solidrun/mx6cubox/patches/uboot/0002-mx6cuboxi-Fix-the-console-variable.patchboard/solidrun/mx6cubox/genimage.cfg deleted +40
-0@@ -0,0 +1,40 @@ +From ab1dd9332c379164925aee755a013dbd8839501b Mon Sep 17 00:00:00 2001 +From: Fabio Estevam <[email protected]> +Date: Mon, 19 Jul 2021 16:48:07 -0300 +Subject: [PATCH 2/2] mx6cuboxi: Fix the console variable + +Do not pass the console baudrate to the 'console' variable +to avoid the baudrate being passed twice when using extlinux.conf: + +cat /proc/cmdline +root=PARTUUID=00000000-01 rootwait rw console=ttymxc0,115200,115200 + +Signed-off-by: Fabio Estevam <[email protected]> +--- + include/configs/mx6cuboxi.h | 3 +-- + 1 file changed, 1 insertion(+), 2 deletions(-) + +diff --git a/include/configs/mx6cuboxi.h b/include/configs/mx6cuboxi.h +index 1a06f29b8c17..9e5083b0d876 100644 +--- a/include/configs/mx6cuboxi.h ++++ b/include/configs/mx6cuboxi.h +@@ -38,7 +38,6 @@ + /* Command definition */ + + #define CONFIG_MXC_UART_BASE UART1_BASE +-#define CONSOLE_DEV "ttymxc0" + + #ifndef CONFIG_SPL_BUILD + #define CONFIG_EXTRA_ENV_SETTINGS \ +@@ -54,7 +53,7 @@ + "ramdiskaddr=0x13000000\0" \ + "initrd_high=0xffffffff\0" \ + "ip_dyn=yes\0" \ +- "console=" CONSOLE_DEV ",115200\0" \ ++ "console=ttymxc0\0" \ + "bootm_size=0x10000000\0" \ + "mmcdev=" __stringify(CONFIG_SYS_MMC_ENV_DEV) "\0" \ + "finduuid=part uuid mmc 1:1 uuid\0" \ +-- +2.25.1 +board/solidrun/mx6cubox/post-build.sh deleted +0
-8@@ -1,8 +0,0 @@ -#!/bin/sh - -BOARD_DIR="$(dirname $0)" - -install -d -m 755 $TARGET_DIR/boot - -$HOST_DIR/bin/mkimage -A arm -O linux -T script -C none \ - -n "boot script" -d $BOARD_DIR/boot.scr.txt$TARGET_DIR/boot/boot.scr
board/solidrun/mx6cubox/post-image.sh deleted +0
-14@@ -1,14 +0,0 @@ -#!/usr/bin/env bash - -BOARD_DIR="$(dirname $0)" -GENIMAGE_CFG="${BOARD_DIR}/genimage.cfg" -GENIMAGE_TMP="${BUILD_DIR}/genimage.tmp" - -rm -rf "${GENIMAGE_TMP}" - -genimage \ - --rootpath "${TARGET_DIR}" \ - --tmppath "${GENIMAGE_TMP}" \ - --inputpath "${BINARIES_DIR}" \ - --outputpath "${BINARIES_DIR}" \ - --config "${GENIMAGE_CFG}"diff --git
a/board/solidrun/mx6cubox/rootfs_overlay/boot/extlinux/extlinux.confb/board/solidrun/mx6cubox/rootfs_overlay/boot/extlinux/extlinux.confnew file mode 100644
index 000000000000..d01106635742board/solidrun/mx6cubox/rootfs_overlay/boot/extlinux/extlinux.conf new file +4
-0@@ -0,0 +1,4 @@ +Label imx6qdl-cubox Buildroot + kernel ../zImage + fdtdir ../ + append root=PARTUUID=${uuid} rootwait rwconsole=${console},${baudrate}
configs/mx6cubox_defconfig +3
-3@@ -11,8 +11,9 @@ BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_5_10=y # System configuration BR2_TARGET_GENERIC_GETTY_PORT="ttymxc0" -BR2_ROOTFS_POST_BUILD_SCRIPT="board/solidrun/mx6cubox/post-build.sh" -BR2_ROOTFS_POST_IMAGE_SCRIPT="board/solidrun/mx6cubox/post-image.sh" +BR2_ROOTFS_OVERLAY="board/solidrun/mx6cubox/rootfs_overlay" +BR2_ROOTFS_POST_IMAGE_SCRIPT="board/freescale/common/imx/post-image.sh" +BR2_GLOBAL_PATCH_DIR="board/solidrun/mx6cubox/patches" # Kernel BR2_LINUX_KERNEL=y --
Quoted 3 lines
2.25.1
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20210720/80a867e9/attachment-0001.html>
Thomas Petazzoni
AppliedPATCH v2 1/1 board/mx6cubox: Switch to extlinux.conf
In reply to Fabio EstevamQuoted 8 lines · On Mon, 19 Jul 2021 16:55:37 -0300 Fabio Estevam <[email protected]> wrote:
Currently mx6cubox uses a custom boot.scr.txt script and custom image generation scripts: genimage.cfg,
post-build.shandpost-image.sh.Switch to using the more standard extlinux.conf solution and remove the custom scripts in favor of the standard
board/freescale/common/imx/post-image.shone.
Quoted 5 lines
Signed-off-by Fabio Estevam <[email protected]>---
Changes since v1:
- Fix the console variable to avoid passing the baudrate twice:
console=ttymxc0,115200,115200
Applied to master, thanks.
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com