selftests, bpf: test_tc_tunnel.sh nc: cannot use -p and -l
Subsystems (3)
PATCH 1/1 selftests, bpf: test_tc_tunnel.sh nc: cannot use -p and -l
When run test_tc_tunnel.sh, it complains following error
ipip
encap 192.168.1.1 to 192.168.1.2, type ipip, mac none len 100 test basic connectivity
nc: cannot use -p and -l
nc man page has:
-l Listen for an incoming connection rather than initiating
a connection to a remote host.Cannot be used together with any of the options -psxz. Additionally, any timeouts specified with the -w option are ignored.
Correct nc in server_listen().
--- tools/testing/selftests/bpf/test_tc_tunnel.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tools/testing/selftests/bpf/test_tc_tunnel.sh +1 -1
@@ -69,7 +69,7 @@ cleanup() { } server_listen() { - ip netns exec "${ns2}" nc "${netcat_opt}" -l -p "${port}" > "${outfile}" & + ip netns exec "${ns2}" nc "${netcat_opt}" -l "${port}" > "${outfile}" & server_pid=$! sleep 0.2 }
Signature · 1 line
2.27.0
Quoted 7 lines · Vincent Li
When run
test_tc_tunnel.sh, it complains following erroripip
encap 192.168.1.1 to 192.168.1.2, type ipip, mac none len 100 test basic connectivity
nc: cannot use -p and -l
Quoted 8 lines
nc man page has:
-l Listen for an incoming connection rather than initiating
a connection to a remote host.Cannot be used together with any of the options -psxz. Additionally, any timeouts specified with the -w option are ignored.Correct nc in
server_listen().
I have two distros and both work with -p in listen.
However, they also work the same without -p, so it makes sense to remove it.
Quoted 11 lines · Martin KaFai Lau
Quoted 9 lines · Vincent Li
When run
test_tc_tunnel.sh, it complains following erroripip
encap 192.168.1.1 to 192.168.1.2, type ipip, mac none len 100 test basic connectivity
nc: cannot use -p and -lnc man page has:
Quoted 9 lines
Quoted 6 lines
-l Listen for an incoming connection rather than initiating
a connection to a remote host.Cannot be used together with any of the options -psxz. Additionally, any timeouts specified with the -w option are ignored.Correct nc in
server_listen().I have two distros and both work with -p in listen.
However, they also work the same without -p, so it makes sense to remove it.
Thanks Martin, I use Centos 8 distro.
Quoted 1 line
Acked-by Martin KaFai Lau <[email protected]>
This patch was applied to bpf/bpf-next.git (refs/heads/master):
Hello:
This patch was applied to bpf/bpf-next.git (refs/heads/master):
Quoted 8 lines · On Mon, 19 Jul 2021 15:30:22 -0700 you wrote:
When run
test_tc_tunnel.sh, it complains following erroripip
encap 192.168.1.1 to 192.168.1.2, type ipip, mac none len 100 test basic connectivity
nc: cannot use -p and -l[...]
Here is the summary with links:
- [bpf-next] selftests, bpf: test_tc_tunnel.sh nc: cannot use -p and -l
https://git.kernel.org/bpf/bpf-next/c/875fc315dbc3
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html