xerces-j: Whitelisted CVE-2018-2799
PATCH 1/1 xerces-j: Whitelisted CVE-2018-2799
From: Saloni Jain <[email protected]>
Whitelisted below CVE:
CVE-2018-2799:
CVE only applies to some Oracle Java SE and Red Hat Enterprise Linux versions which is already fixed with updates and the issue is closed.
--- recipes-core/xerces-j/xerces-j_2.11.0.bb | 6 ++++++ 1 file changed, 6 insertions(+)
recipes-core/xerces-j/xerces-j_2.11.0.bb +6 -0
@@ -14,6 +14,12 @@ LIC_FILES_CHKSUM = " \ SRC_URI = "http://archive.apache.org/dist/xerces/j/Xerces-J-src.${PV}.tar.gz" +# CVE only applies to some Oracle Java SE and Red Hat Enterprise Linux versions. +# Already fixed with updates and closed. +# https://access.redhat.com/security/cve/CVE-2018-2799 +# https://bugzilla.redhat.com/show_bug.cgi?id=1567542 +CVE_CHECK_WHITELIST += "CVE-2018-2799" + S = "${WORKDIR}/xerces-2_11_0" inherit java-library
Signature · 1 line
2.17.1
Hi,
thanks for the patch and sorry for the late reply. Unfortunately there are some problems with your patch.
Your git author seems to be set up incorrectly. Please set it up correctly using the following commands before formatting the patch:
$ git config user.name "John Doe" $ git config user.email [email protected]
Quoted 7 lines · Saloni Jain via lists.openembedded.org
Whitelisted below CVE:
CVE-2018-2799:
CVE only applies to some Oracle Java SE and Red Hat Enterprise Linux versions which is already fixed with updates and the issue is closed.
Furthermore you are missing a Signed-Off-By line here. Please add it.
Quoted 23 lines
--- recipes-core/xerces-j/xerces-j_2.11.0.bb | 6 ++++++ 1 file changed, 6 insertions(+)recipes-core/xerces-j/xerces-j_2.11.0.bb +6
-0@@ -14,6 +14,12 @@ LIC_FILES_CHKSUM = " \ SRC_URI = "http://archive.apache.org/dist/xerces/j/Xerces-J-src.${PV}.tar.gz" +# CVE only applies to some Oracle Java SE and Red Hat Enterprise Linux versions. +# Already fixed with updates and closed. +# https://access.redhat.com/security/cve/CVE-2018-2799 +# https://bugzilla.redhat.com/show_bug.cgi?id=1567542 +CVE_CHECK_WHITELIST += "CVE-2018-2799" + S = "${WORKDIR}/xerces-2_11_0" inherit java-librarySignature · 1 line
2.17.1
Otherwise the patch seems fine to me. So I'm looking forward to receive a v2 from you 😉
regards;rl
Hello,
Thank you for your reply and appreciate the feedback. I will fix the mentioned comments and send a v2 for the patch.
Regards,
Saloni Jain
Quoted 53 lines · Richard Leitner - SKIDATA
Hi,
thanks for the patch and sorry for the late reply. Unfortunately there are some problems with your patch.Your git author seems to be set up incorrectly. Please set it up correctly using the following commands before formatting the patch:
$ git config user.name "John Doe" $ git config user.email [email protected]Quoted 7 lines · Saloni Jain via lists.openembedded.org
Whitelisted below CVE:
CVE-2018-2799:
CVE only applies to some Oracle Java SE and Red Hat Enterprise Linux versions which is already fixed with updates and the issue is closed.Furthermore you are missing a Signed-Off-By line here. Please add it.
Review
Quoted 5 lines
--- recipes-core/xerces-j/xerces-j_2.11.0.bb | 6 ++++++ 1 file changed, 6 insertions(+)(quoted diff) +0
-0b/recipes-core/xerces-j/xerces-j_2.11.0.bb
recipes-core/xerces-j/xerces-j_2.11.0.bb LIC_FILES_CHKSUM = " \ · line 15
Quoted 6 lines
index 98ef32f..f2a4434 100644
recipes-core/xerces-j/xerces-j_2.11.0.bb +0
-0@@ -14,6 +14,12 @@ LIC_FILES_CHKSUM = " \ SRC_URI = "http://archive.apache.org/dist/xerces/j/Xerces-J-src.${PV}.tar.gz"
recipes-core/xerces-j/xerces-j_2.11.0.bb LIC_FILES_CHKSUM = " \ · line 16
Quoted 2 lines
recipes-core/xerces-j/xerces-j_2.11.0.bb +1
-0+# CVE only applies to some Oracle Java SE and Red Hat Enterprise Linuxversions.
Quoted 10 lines
recipes-core/xerces-j/xerces-j_2.11.0.bb +5
-1+# Already fixed with updates and closed. +# https://access.redhat.com/security/cve/CVE-2018-2799 +# https://bugzilla.redhat.com/show_bug.cgi?id=1567542 +CVE_CHECK_WHITELIST += "CVE-2018-2799" + S = "${WORKDIR}/xerces-2_11_0" inherit java-library --2.17.1
Otherwise the patch seems fine to me. So I'm looking forward to receive a v2 from you 😉
regards;rl
Hello,
Could anyone please do a review again and confirm if the patch is now okay for integration in upstream branch.
Regards,
Saloni Jain