Skip to contentSkip to conversation

package/python-pysftp: add missing C++ dependency from paramiko

PATCH Applied Thomas Petazzoni 2 participants 3 messages Jul 20, 2021 – Aug 5, 2021

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/python-pysftp: add missing C++ dependency from paramiko

python-paramiko has a dependency on C++ support, which was added in commit 2d7b73cf75daedd4a198a75546308fedae7c9467 in 2016.

When python-pysftp was added in commit 3b920487bad119abf5bfb10a237cedd3b5278c10 in 2020, this C++ dependency was not propagated, even though python-pysftp selects python-paramiko.

This commit fixes this issue by propagating the dependency, which fixes this warning:

WARNING: unmet direct dependencies detected for BR2_PACKAGE_PYTHON_PARAMIKO
Depends on [n]: (BR2_PACKAGE_PYTHON [=n] || BR2_PACKAGE_PYTHON3 [=y]) && BR2_PACKAGE_PYTHON3 [=y] && BR2_INSTALL_LIBSTDCPP [=n] Selected by [y]:
- BR2_PACKAGE_PYTHON_PYSFTP [=y] && (BR2_PACKAGE_PYTHON [=n] || BR2_PACKAGE_PYTHON3 [=y]) && BR2_PACKAGE_PYTHON3 [=y]

That occurs with configuration with C++ disabled, but python-pysftp enabled.

---
 package/python-pysftp/Config.in | 5 +++++
 1 file changed, 5 insertions(+)
package/python-pysftp/Config.in +5 -0
index de2d2df63d..5d5b731f33 100644
@@ -1,8 +1,13 @@
 config BR2_PACKAGE_PYTHON_PYSFTP
 	bool "python-pysftp"
 	depends on BR2_PACKAGE_PYTHON3 # python-paramiko -> python-bcrypt
+	depends on BR2_INSTALL_LIBSTDCPP # python-paramiko
 	select BR2_PACKAGE_PYTHON_PARAMIKO # runtime
 	help
 	  A friendly face on SFTP.
 
 	  https://bitbucket.org/dundeemt/pysftp
+
+comment "python-pysftp needs a toolchain w/ C++"
+	depends on BR2_PACKAGE_PYTHON3
+	depends on !BR2_INSTALL_LIBSTDCPP
Signature · 1 line
2.31.1
author Applied
#1 lore raw
Quoted 15 lines · On Tue, 20 Jul 2021 12:08:28 +0200 Thomas Petazzoni…

python-paramiko has a dependency on C++ support, which was added in commit 2d7b73cf75daedd4a198a75546308fedae7c9467 in 2016.

When python-pysftp was added in commit 3b920487bad119abf5bfb10a237cedd3b5278c10 in 2020, this C++ dependency was not propagated, even though python-pysftp selects python-paramiko.

This commit fixes this issue by propagating the dependency, which fixes this warning:

WARNING: unmet direct dependencies detected for BR2_PACKAGE_PYTHON_PARAMIKO
Depends on [n]: (BR2_PACKAGE_PYTHON [=n] || BR2_PACKAGE_PYTHON3 [=y]) && BR2_PACKAGE_PYTHON3 [=y] && BR2_INSTALL_LIBSTDCPP [=n] Selected by [y]:
- BR2_PACKAGE_PYTHON_PYSFTP [=y] && (BR2_PACKAGE_PYTHON [=n] || BR2_PACKAGE_PYTHON3 [=y]) && BR2_PACKAGE_PYTHON3 [=y]

Quoted 7 lines

That occurs with configuration with C++ disabled, but python-pysftp enabled.

---
 package/python-pysftp/Config.in | 5 +++++
 1 file changed, 5 insertions(+)

Applied to master, thanks.

Thomas

Signature · 7 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
[email protected]
http://lists.busybox.net/mailman/listinfo/buildroot
#2 lore raw
In reply to Thomas Petazzoni
Quoted 17 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas Petazzoni <[email protected]> writes:

python-paramiko has a dependency on C++ support, which was added in commit 2d7b73cf75daedd4a198a75546308fedae7c9467 in 2016.

When python-pysftp was added in commit 3b920487bad119abf5bfb10a237cedd3b5278c10 in 2020, this C++ dependency was not propagated, even though python-pysftp selects python-paramiko.

This commit fixes this issue by propagating the dependency, which fixes this warning:

WARNING: unmet direct dependencies detected for BR2_PACKAGE_PYTHON_PARAMIKO
Depends on [n]: (BR2_PACKAGE_PYTHON [=n] || BR2_PACKAGE_PYTHON3 [=y]) && BR2_PACKAGE_PYTHON3 [=y] && BR2_INSTALL_LIBSTDCPP [=n] Selected by [y]:
- BR2_PACKAGE_PYTHON_PYSFTP [=y] && (BR2_PACKAGE_PYTHON [=n] || BR2_PACKAGE_PYTHON3 [=y]) && BR2_PACKAGE_PYTHON3 [=y]

Quoted 4 lines

That occurs with configuration with C++ disabled, but python-pysftp enabled.

Committed to 2021.02.x and 2021.05.x, thanks.

Signature · 5 lines
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
[email protected]
http://lists.busybox.net/mailman/listinfo/buildroot