Skip to contentSkip to conversation

board/raspberrypi: use kernel Bluetooth mode

PATCH New John Keeping 4 participants 6 messages Jul 14, 2021 – Jul 20, 2021 Broadcom BCM2711/BCM2835 Arm architecture

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 board/raspberrypi: use kernel Bluetooth mode

The default setting with miniuart-bt requires hciattach which is a deprecated utility in BlueZ. Setting the krnbt parameter switches to the modern method of using serdev in the kernel removing the need for any userspace configuration to enable the Bluetooth controller.

This is documented as applying to all Raspberry Pi variants so just enable it globally.

---
 board/raspberrypi/post-image.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
board/raspberrypi/post-image.sh +1 -1
index 9dbd98ef9b..a6728c686e 100755
@@ -16,7 +16,7 @@ do
 			cat << __EOF__ >> "${BINARIES_DIR}/rpi-firmware/config.txt"
 
 # fixes rpi (3B, 3B+, 3A+, 4B and Zero W) ttyAMA0 serial console
-dtoverlay=miniuart-bt
+dtoverlay=miniuart-bt,krnbt=on
 __EOF__
 		fi
 		;;
Signature · 1 line
2.32.0
#1 lore raw

PATCH 1/1 board/raspberrypi: use kernel Bluetooth mode

Hello John,

Quoted 18 lines · John Keeping

The default setting with miniuart-bt requires hciattach which is a deprecated utility in BlueZ. Setting the krnbt parameter switches to the modern method of using serdev in the kernel removing the need for any userspace configuration to enable the Bluetooth controller.

This is documented as applying to all Raspberry Pi variants so just enable it globally.

---
 board/raspberrypi/post-image.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
board/raspberrypi/post-image.sh +0 -0
index 9dbd98ef9b..a6728c686e 100755

board/raspberrypi/post-image.sh do · line 22

Quoted 8 lines
board/raspberrypi/post-image.sh +1 -1
@@ -16,7 +16,7 @@ do
 			cat << __EOF__ >> "${BINARIES_DIR}/rpi-firmware/config.txt"
 
 # fixes rpi (3B, 3B+, 3A+, 4B and Zero W) ttyAMA0 serial console
-dtoverlay=miniuart-bt
+dtoverlay=miniuart-bt,krnbt=on
 __EOF__
 		fi
 		;;

I fully understand the aim of your patch, but it is beyond the the minimal approach of the defconfigs (minimal as as starting point for own enhancements - startup and at minimum serial console access if possible, so even not all rpi defconfigs provide the DTB overlays) or as strong hint your enhancement would not match the comment line above the changed line...

But for an alternative config.txt file handling (with better/easier support for cutomizations) see [1]...

Regards,
Peter

[1] https://patchwork.ozlabs.org/project/buildroot/patch/20210321114002.31000-1-ps.report at gmx.net/

#2 lore raw

PATCH 1/1 board/raspberrypi: use kernel Bluetooth mode

Hi Peter,

Quoted 22 lines · On Sun, 18 Jul 2021 00:22:42 +0200 Peter Seiderer <[email protected]> wrote:
Quoted 20 lines · John Keeping

The default setting with miniuart-bt requires hciattach which is a deprecated utility in BlueZ. Setting the krnbt parameter switches to the modern method of using serdev in the kernel removing the need for any userspace configuration to enable the Bluetooth controller.

This is documented as applying to all Raspberry Pi variants so just enable it globally.

---
 board/raspberrypi/post-image.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
board/raspberrypi/post-image.sh +0 -0
index 9dbd98ef9b..a6728c686e 100755
@@ -16,7 +16,7 @@ do
 			cat << __EOF__ >> "${BINARIES_DIR}/rpi-firmware/config.txt"
 
Quoted 12 lines

board/raspberrypi/post-image.sh do · line 22

Quoted 6 lines
board/raspberrypi/post-image.sh +1 -1
 # fixes rpi (3B, 3B+, 3A+, 4B and Zero W) ttyAMA0 serial console
-dtoverlay=miniuart-bt
+dtoverlay=miniuart-bt,krnbt=on
 __EOF__
 		fi
 		;;  

I fully understand the aim of your patch, but it is beyond the the minimal approach of the defconfigs (minimal as as starting point for own enhancements - startup and at minimum serial console access if possible, so even not all rpi defconfigs provide the DTB overlays) or as strong hint your enhancement would not match the comment line above the changed line...

That comment is still correct - the serial console continues to work with krnbt=on set. What doesn't work any more is hciattach on the Bluetooth serial device since that is no longer exposed and handled internally in the kernel.

I can understand why this isn't the default since RPi want Raspbian to continue to work in the hciattach configuration without any need to upgrade in step, but Buildroot doesn't have the same backwards compatibility requirements and the krnbt=on mode is more usable for modern systems since Bluetooth "just works" without any need for hciattach or other userspace configuration.

Quoted 4 lines

But for an alternative config.txt file handling (with better/easier support for cutomizations) see [1]...

[1] https://patchwork.ozlabs.org/project/buildroot/patch/20210321114002.31000-1-ps.report at gmx.net/

I missed that series when it was posted, but it does look like an improvement in configuring the system. I will try to find some time to review it in depth. But I do still think that whenever miniuart-bt is added as an overlay, the krnbt=on variant should be used.

Regards,
John

#3 lore raw

PATCH 1/1 board/raspberrypi: use kernel Bluetooth mode

John, Peter, All,

On 2021-07-19 12:26 +0100, John Keeping spake thusly:

Quoted 41 lines
Quoted 21 lines · On Sun, 18 Jul 2021 00:22:42 +0200 Peter Seiderer <[email protected]> wrote:
Quoted 20 lines · John Keeping

The default setting with miniuart-bt requires hciattach which is a deprecated utility in BlueZ. Setting the krnbt parameter switches to the modern method of using serdev in the kernel removing the need for any userspace configuration to enable the Bluetooth controller.

This is documented as applying to all Raspberry Pi variants so just enable it globally.

---
 board/raspberrypi/post-image.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
board/raspberrypi/post-image.sh +0 -0
index 9dbd98ef9b..a6728c686e 100755
@@ -16,7 +16,7 @@ do
 			cat << __EOF__ >> "${BINARIES_DIR}/rpi-firmware/config.txt"
 
Quoted 12 lines

board/raspberrypi/post-image.sh do · line 22

Quoted 6 lines
board/raspberrypi/post-image.sh +1 -1
 # fixes rpi (3B, 3B+, 3A+, 4B and Zero W) ttyAMA0 serial console
-dtoverlay=miniuart-bt
+dtoverlay=miniuart-bt,krnbt=on
 __EOF__
 		fi
 		;;  

I fully understand the aim of your patch, but it is beyond the the minimal approach of the defconfigs (minimal as as starting point for own enhancements - startup and at minimum serial console access if possible, so even not all rpi defconfigs provide the DTB overlays) or as strong hint your enhancement would not match the comment line above the changed line...

That comment is still correct - the serial console continues to work with krnbt=on set. What doesn't work any more is hciattach on the Bluetooth serial device since that is no longer exposed and handled internally in the kernel.

Quoted 6 lines

I can understand why this isn't the default since RPi want Raspbian to continue to work in the hciattach configuration without any need to upgrade in step, but Buildroot doesn't have the same backwards compatibility requirements and the krnbt=on mode is more usable for modern systems since Bluetooth "just works" without any need for hciattach or other userspace configuration.

I was a bit undecided on the topic...

On one hand, I agree with Peter that we tend to have minimalist configurations, while on the other hand we also like to have those minimalist configuration to still enable the hardware present on the boards, especially if there are tricks to do so.

Furthermore, we also like to provide configurations that use state-of-the-art setups and technologies (for lack of a better word), e.g. the recommened kernel-side handling in this case.

So, in the end, I think John's proposal does make sense.

However, krnbt is a generic parameter, for the "<The base DTB>". So, it feels awkward to have it set as part of the --add-miniuart-bt-overlay option... But this option applies to all rpis that havea BT chip, so I can see the reasoning...

Quoted 3 lines
Quoted 3 lines

But for an alternative config.txt file handling (with better/easier support
for cutomizations) see [1]...
[1] https://patchwork.ozlabs.org/project/buildroot/patch/20210321114002.31000-1-ps.report at gmx.net/

Peter, could you please rebase and respin that series, please?

There has been no better proposal, especially from my part, so even if I am still not 100% convinced, it does improve the situation by a fair amount, so I will apply it.

Quoted 4 lines

I missed that series when it was posted, but it does look like an improvement in configuring the system. I will try to find some time to review it in depth. But I do still think that whenever miniuart-bt is added as an overlay, the krnbt=on variant should be used.

I think this is the confusing part: miniuart-bt is restoring the UART on the usual port, it is not enabling the BT chip. But in Buildroot, we use miniuart-bt for all rpis that have a BT chip, so I can see how it fits together *in our case*.

There is however one remaining question: is that kernel-side autorpobing specific to the rpi (I guess not)? If not, I guess this is also driven by a kernel cmdline parameter, no? And if so, shouldn't we use that kernel cmdline parameter instead?

Regards,
Yann E. MORIN.

Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#4 lore raw

PATCH 1/1 board/raspberrypi: use kernel Bluetooth mode

Hi Yann,

Quoted 60 lines · On Mon, 19 Jul 2021 22:53:54 +0200 "Yann E. MORIN" <[email protected]>…

On 2021-07-19 12:26 +0100, John Keeping spake thusly:

Quoted 41 lines
Quoted 21 lines · On Sun, 18 Jul 2021 00:22:42 +0200 Peter Seiderer <[email protected]> wrote:
Quoted 20 lines · John Keeping

The default setting with miniuart-bt requires hciattach which is a deprecated utility in BlueZ. Setting the krnbt parameter switches to the modern method of using serdev in the kernel removing the need for any userspace configuration to enable the Bluetooth controller.

This is documented as applying to all Raspberry Pi variants so just enable it globally.

---
 board/raspberrypi/post-image.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
board/raspberrypi/post-image.sh +0 -0
index 9dbd98ef9b..a6728c686e 100755
@@ -16,7 +16,7 @@ do
 			cat << __EOF__ >> "${BINARIES_DIR}/rpi-firmware/config.txt"
 
Quoted 12 lines

board/raspberrypi/post-image.sh do · line 22

Quoted 6 lines
board/raspberrypi/post-image.sh +1 -1
 # fixes rpi (3B, 3B+, 3A+, 4B and Zero W) ttyAMA0 serial console
-dtoverlay=miniuart-bt
+dtoverlay=miniuart-bt,krnbt=on
 __EOF__
 		fi
 		;;    

I fully understand the aim of your patch, but it is beyond the the minimal approach of the defconfigs (minimal as as starting point for own enhancements - startup and at minimum serial console access if possible, so even not all rpi defconfigs provide the DTB overlays) or as strong hint your enhancement would not match the comment line above the changed line...

That comment is still correct - the serial console continues to work with krnbt=on set. What doesn't work any more is hciattach on the Bluetooth serial device since that is no longer exposed and handled internally in the kernel.

Quoted 6 lines

I can understand why this isn't the default since RPi want Raspbian to continue to work in the hciattach configuration without any need to upgrade in step, but Buildroot doesn't have the same backwards compatibility requirements and the krnbt=on mode is more usable for modern systems since Bluetooth "just works" without any need for hciattach or other userspace configuration.

I was a bit undecided on the topic...

On one hand, I agree with Peter that we tend to have minimalist configurations, while on the other hand we also like to have those minimalist configuration to still enable the hardware present on the boards, especially if there are tricks to do so.

Furthermore, we also like to provide configurations that use state-of-the-art setups and technologies (for lack of a better word), e.g. the recommened kernel-side handling in this case.

Quoted 6 lines

So, in the end, I think John's proposal does make sense.

However, krnbt is a generic parameter, for the "<The base DTB>". So, it feels awkward to have it set as part of the --add-miniuart-bt-overlay option... But this option applies to all rpis that havea BT chip, so I can see the reasoning...

This is interesting - it's actually an option in *both* the base DT and the miniuart-bt overlay as documented in:

https://github.com/raspberrypi/linux/blob/rpi-5.10.y/arch/arm/boot/dts/overlays/README

I'm not familiar enough with this to say whether the overlay could reset the value if we were to specify it earlier in the option.

Quoted 20 lines
Quoted 3 lines
Quoted 3 lines

But for an alternative config.txt file handling (with better/easier support
for cutomizations) see [1]...
[1] https://patchwork.ozlabs.org/project/buildroot/patch/20210321114002.31000-1-ps.report at gmx.net/

Peter, could you please rebase and respin that series, please?

There has been no better proposal, especially from my part, so even if I am still not 100% convinced, it does improve the situation by a fair amount, so I will apply it.

Quoted 4 lines

I missed that series when it was posted, but it does look like an improvement in configuring the system. I will try to find some time to review it in depth. But I do still think that whenever miniuart-bt is added as an overlay, the krnbt=on variant should be used.

I think this is the confusing part: miniuart-bt is restoring the UART on the usual port, it is not enabling the BT chip. But in Buildroot, we use miniuart-bt for all rpis that have a BT chip, so I can see how it fits together *in our case*.

Quoted 4 lines

There is however one remaining question: is that kernel-side autorpobing specific to the rpi (I guess not)? If not, I guess this is also driven by a kernel cmdline parameter, no? And if so, shouldn't we use that kernel cmdline parameter instead?

By "kernel-side autoprobing" do you mean the serdev bus support for Bluetooth? That's just the standard driver binding as would be used for any other device; the problem is that the serial device bus is relatively new, so historically the Bluetooth UART was exposed as a normal /dev/ttyS* and then hciattach was needed to install the custom line discipline in order to associate that TTY with a Bluetooth driver (there's some device-specific configuration but basically it just sets the line discipline and waits on ppoll() for SIGTERM).

Letting the driver bind via serdev is definitely the right option given a sufficiently recent kernel (which we have for all the RaspberryPi defconfigs) - you have to enable BR2_PACKAGE_BLUEZ5_UTILS_DEPRECATED to install hciattach.

Regards,
John

#5 lore raw

PATCH 1/1 board/raspberrypi: use kernel Bluetooth mode

In reply to John Keeping

Hello,

Quoted 5 lines · On Wed, 14 Jul 2021 15:51:32 +0100 John Keeping <[email protected]> wrote:

The default setting with miniuart-bt requires hciattach which is a deprecated utility in BlueZ. Setting the krnbt parameter switches to the modern method of using serdev in the kernel removing the need for any userspace configuration to enable the Bluetooth controller.

Quoted 7 lines

This is documented as applying to all Raspberry Pi variants so just enable it globally.

---
 board/raspberrypi/post-image.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Applied to master, thanks.

Peter, Yann: I have read your reviews, and they both have good points. However, I think John's patch keeps the state of a minimal defconfig, it only makes it a bit easier to have operational Bluetooth. I certainly don't mind seeing further improvements on how our RPi support is done, but I believe John's patch was OK as-is as it improves the situation for users, without any specific downside that I can think of.

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com