crypto: sun8i-ss - Use kfree_sensitive
PATCH 1/1 crypto: sun8i-ss - Use kfree_sensitive
The kfree_sensitive is a kernel API to clear sensitive information that should not be leaked to other future users of the same memory objects and free the memory. Its function is the same as the combination of memzero_explicit and kfree. Thus, we can replace the combination APIs with the single kfree_sensitive API.
Signed-off-by Jason Wang <[email protected]>
--- drivers/crypto/allwinner/sun8i-ss/sun8i-ss-prng.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-)
drivers/crypto/allwinner/sun8i-ss/sun8i-ss-prng.c +3 -6
@@ -20,8 +20,7 @@ int sun8i_ss_prng_seed(struct crypto_rng *tfm, const u8 *seed,struct sun8i_ss_rng_tfm_ctx *ctx =crypto_rng_ctx (tfm);if (ctx->seed && ctx->slen != slen) { -memzero_explicit (ctx->seed, ctx->slen); -kfree (ctx->seed); +kfree_sensitive (ctx->seed); ctx->slen =0 ; ctx->seed =NULL ; }
@@ -48,8 +47,7 @@ void sun8i_ss_prng_exit(struct crypto_tfm *tfm) {struct sun8i_ss_rng_tfm_ctx *ctx =crypto_tfm_ctx (tfm); -memzero_explicit (ctx->seed, ctx->slen); -kfree (ctx->seed); +kfree_sensitive (ctx->seed); ctx->seed =NULL ; ctx->slen =0 ; }
@@ -167,9 +165,8 @@ int sun8i_ss_prng_generate(struct crypto_rng *tfm, const u8 *src,/* Update seed */ memcpy (ctx->seed, d + dlen, ctx->slen); } -memzero_explicit (d, todo); err_free: -kfree (d); +kfree_sensitive (d);return err; }
Signature · 7 lines
2.32.0 _______________________________________________ linux-arm-kernel mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Herbert Xu
maintainerQuoted 10 lines · Jason Wang
The
kfree_sensitiveis a kernel API to clear sensitive information that should not be leaked to other future users of the same memory objects and free the memory. Its function is the same as the combination ofmemzero_explicitand kfree. Thus, we can replace the combination APIs with the singlekfree_sensitiveAPI.Signed-off-by Jason Wang <[email protected]>--- drivers/crypto/allwinner/sun8i-ss/sun8i-ss-prng.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-)
Patch applied. Thanks.
Signature · 3 lines
Email: Herbert Xu <[email protected]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt