linux-next: build failure after merge of the printk tree
Hi all,
After merging the printk tree, today's linux-next build (mips allnoconfig) failed like this:
arch/mips/kernel/genex.o: In function `handle_mcheck_int':
(.text+0x190c): undefined reference to printk' arch/mips/kernel/genex.o: In function handle_reserved_int':
(.text+0x1c8c): undefined reference to `printk'
Caused by commit
337015573718 ("printk: Userspace format indexing support")
Signature · 2 lines
Cheers, Stephen Rothwell
Quoted 6 lines · Stephen Rothwell
Hi all,
After merging the printk tree, today's linux-next build (mips allnoconfig) failed like this:
Quoted 8 lines
arch/mips/kernel/genex.o: In function `handle_mcheck_int':
(.text+0x190c): undefined reference toprintk' arch/mips/kernel/genex.o: In functionhandle_reserved_int':
(.text+0x1c8c): undefined reference to `printk'Caused by commit
337015573718 ("printk: Userspace format indexing support")
Following MIPS builds failed at our end due the reported problem.
- build/gcc-10-allnoconfig
- build/gcc-10-ar7_defconfig
- build/gcc-10-ath79_defconfig
- build/gcc-10-bcm47xx_defconfig
- build/gcc-10-bcm63xx_defconfig
- build/gcc-10-cavium_octeon_defconfig
- build/gcc-10-defconfig
- build/gcc-10-e55_defconfig
- build/gcc-10-malta_defconfig
- build/gcc-10-nlm_xlp_defconfig
- build/gcc-10-rt305x_defconfig
Quoted 4 lines
--
Cheers,
Stephen Rothwell
- Naresh
Hey folks,
Quoted 12 lines · Naresh Kamboju
Quoted 11 lines · Stephen Rothwell
Hi all,
After merging the printk tree, today's linux-next build (mips allnoconfig) failed like this:
arch/mips/kernel/genex.o: In function `handle_mcheck_int':
(.text+0x190c): undefined reference toprintk' arch/mips/kernel/genex.o: In functionhandle_reserved_int':
(.text+0x1c8c): undefined reference to `printk'
Quoted 5 lines
Quoted 3 lines
Caused by commit
337015573718 ("printk: Userspace format indexing support")
Following MIPS builds failed at our end due the reported problem.
Thanks: missed this as I made sure to change all .S files to use _printk, but this is in a .h file included in a .S file.
Here's what's needed. :-)
mips/include/asm/asm.h +1 -1
@@ -114,7 +114,7 @@ symbol = value .set push; \ .set reorder; \ PTR_LA a0, 8f; \ -jal printk; \ +jal _printk; \ .set pop; \TEXT (string) #else
Quoted 31 lines · Chris Down
Hey folks,
Quoted 12 lines · Naresh Kamboju
Quoted 11 lines · Stephen Rothwell
Hi all,
After merging the printk tree, today's linux-next build (mips allnoconfig) failed like this:
arch/mips/kernel/genex.o: In function `handle_mcheck_int':
(.text+0x190c): undefined reference toprintk' arch/mips/kernel/genex.o: In functionhandle_reserved_int':
(.text+0x1c8c): undefined reference to `printk'Quoted 5 lines
Quoted 3 lines
Caused by commit
337015573718 ("printk: Userspace format indexing support")
Following MIPS builds failed at our end due the reported problem.
Thanks: missed this as I made sure to change all .S files to use
_printk, but this is in a .h file included in a .S file.Here's what's needed. :-)
mips/include/asm/asm.h +0
-0
mips/include/asm/asm.h symbol = value · line 120
Quoted 8 lines
mips/include/asm/asm.h +1
-1@@ -114,7 +114,7 @@ symbol = value .set push; \ .set reorder; \ PTR_LA a0, 8f; \ -jal printk; \ +jal _printk; \ .set pop; \TEXT (string) #else
Chris, could you please send it as a proper patch?
Best Regards,
Petr
Quoted 1 line · Petr Mladek
Chris, could you please send it as a proper patch?
Sure thing -- just to confirm, resend the whole series to you with these fixes squashed in, right? :-)
Quoted 5 lines · Chris Down
Quoted 1 line · Petr Mladek
Chris, could you please send it as a proper patch?
Sure thing -- just to confirm, resend the whole series to you with these fixes squashed in, right? :-)
Good question. I would prefer to avoid the rebase. Please, send it as a followup patch.
Best Regards,
Petr
Hi all,
Quoted 6 lines · On Tue, 20 Jul 2021 17:43:00 +1000 Stephen Rothwell <[email protected]>…
Hi all,
After merging the printk tree, today's linux-next build (mips allnoconfig) failed like this:
Quoted 8 lines
arch/mips/kernel/genex.o: In function `handle_mcheck_int':
(.text+0x190c): undefined reference toprintk' arch/mips/kernel/genex.o: In functionhandle_reserved_int':
(.text+0x1c8c): undefined reference to `printk'Caused by commit
337015573718 ("printk: Userspace format indexing support")
I am still getting these failures.
Signature · 2 lines
Cheers, Stephen Rothwell
Quoted 14 lines · Stephen Rothwell
Hi all,
Quoted 11 lines · On Tue, 20 Jul 2021 17:43:00 +1000 Stephen Rothwell <[email protected]>…
Hi all,
After merging the printk tree, today's linux-next build (mips allnoconfig) failed like this:
arch/mips/kernel/genex.o: In function `handle_mcheck_int':
(.text+0x190c): undefined reference toprintk' arch/mips/kernel/genex.o: In functionhandle_reserved_int':
(.text+0x1c8c): undefined reference to `printk'
Quoted 5 lines
Quoted 3 lines
Caused by commit
337015573718 ("printk: Userspace format indexing support")
I am still getting these failures.
I have just pushed the proposed fix into printk/linux.git, branch for-5.15-printk-index.
I am sorry for the delay. I waited for a patch with reasonable commit message from Chris. I did it myself after all.
Thanks for the report.
Best Regards,
Petr
Hey folks,
Quoted 2 lines · Petr Mladek
I am sorry for the delay. I waited for a patch with reasonable commit message from Chris. I did it myself after all.
My sincere apologies for the delay. I had it in my calendar to do yesterday afternoon, but ended up with no time left :-(
Thanks Petr for pushing them, and sorry for the trouble caused.