drm/amdgpu/gfx10: fix mixed declaration and code warning
Subsystems (2)
Alex Deucher
maintainerPATCH 1/1 drm/amdgpu/gfx10: fix mixed declaration and code warning
Move the declaration up to the top of the function.
Fixes 631d55e089eaa8 ("drm/amdgpu: Add error message when programing registers fails")
Cc Roy Sun <[email protected]>
Signed-off-by Alex Deucher <[email protected]>
--- drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c +1 -1
@@ -1493,6 +1493,7 @@ static u32 gfx_v10_rlcg_rw(struct amdgpu_device *adev, u32 offset, u32 v, uint32uint32_t i =0 ;uint32_t retries =50000 ;u32 ret =0 ; +u32 tmp; scratch_reg0 = adev->rmmio + (adev->reg_offset[GC_HWIP ][0 ][mmSCRATCH_REG0_BASE_IDX] + mmSCRATCH_REG0) *4 ;
@@ -1526,7 +1527,6 @@ static u32 gfx_v10_rlcg_rw(struct amdgpu_device *adev, u32 offset, u32 v, uint32writel (v, scratch_reg0);writel (offset | flag, scratch_reg1);writel (1 , spare_int); -u32 tmp;for (i =0 ; i < retries; i++) { tmp =readl (scratch_reg1);
Signature · 6 lines
2.31.1 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Am 21.07.21 um 05:14 schrieb Alex Deucher:
Quoted 5 lines
Move the declaration up to the top of the function.
Fixes 631d55e089eaa8 ("drm/amdgpu: Add error message when programing registers fails")Cc Roy Sun <[email protected]>Signed-off-by Alex Deucher <[email protected]>
Acked-by Christian König <[email protected]>
Quoted 17 lines
--- drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c +1
-0@@ -1493,6 +1493,7 @@ static u32 gfx_v10_rlcg_rw(struct amdgpu_device *adev, u32 offset, u32 v, uint32uint32_t i =0 ;uint32_t retries =50000 ;u32 ret =0 ; +u32 tmp; scratch_reg0 = adev->rmmio + (adev->reg_offset[GC_HWIP ][0 ][mmSCRATCH_REG0_BASE_IDX] + mmSCRATCH_REG0) *4 ;
drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c static u32 gfx_v10_rlcg_rw(struct amdgpu_device *adev, u32 offset, u32 v, uint32 · line 1532
Quoted 7 lines
drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c +0
-1@@ -1526,7 +1527,6 @@ static u32 gfx_v10_rlcg_rw(struct amdgpu_device *adev, u32 offset, u32 v, uint32writel (v, scratch_reg0);writel (offset | flag, scratch_reg1);writel (1 , spare_int); -u32 tmp;for (i =0 ; i < retries; i++) { tmp =readl (scratch_reg1);
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx