ftrace: Avoid synchronize_rcu_tasks_rude() call when not necessary
PATCH 1/1 ftrace: Avoid synchronize_rcu_tasks_rude() call when not necessary
synchronize_rcu_tasks_rude() triggers IPIs and forces rescheduling on all CPUs. It is a costly operation and, when targeting nohz_full CPUs, very disrupting (hence the name). So avoid calling it when 'old_hash' doesn't need to be freed.
Signed-off-by Nicolas Saenz Julienne <[email protected]>
--- kernel/trace/ftrace.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
kernel/trace/ftrace.c +2 -1
@@ -5985,7 +5985,8 @@ ftrace_graph_release(struct inode *inode, struct file *file)* infrastructure to do the synchronization, thus we must do it * ourselves. */ -synchronize_rcu_tasks_rude (); +if (old_hash !=EMPTY_HASH ) +synchronize_rcu_tasks_rude ();free_ftrace_hash (old_hash); }
Signature · 1 line
2.31.1