Skip to contentSkip to conversation

virtio-blk: fix virtqueues accounting

PATCH In review Max Gurtovoy 2 participants 3 messages Jul 21, 2021 – Aug 10, 2021

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 virtio-blk: fix virtqueues accounting

Virtqueue index is zero based, thus virtqueue (N-1) refers to requestqN.

---
 content.tex | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
content.tex +1 -1
index 5c70a3c..c266fd5 100644
@@ -4398,7 +4398,7 @@ \subsection{Virtqueues}\label{sec:Device Types / Block Device / Virtqueues}
 \begin{description}
 \item[0] requestq1
 \item[\ldots]
-\item[N] requestqN
+\item[N-1] requestqN
 \end{description}
 
  N=1 if VIRTIO_BLK_F_MQ is not negotiated, otherwise N is set by
Signature · 1 line
2.21.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 6 lines · Max Gurtovoy

Virtqueue index is zero based, thus virtqueue (N-1) refers to requestqN.

---
 content.tex | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

We had an issue for a similar fix for virtio-net, so do we want to use issue+voting here as well, or would that be overkill? I'm inclined to do this as an editorial update.

This publicly archived list offers a means to provide input to the OASIS Virtual I/O Device (VIRTIO) TC.

In order to verify user consent to the Feedback License terms and to minimize spam in the list archive, subscription is required before posting.

Subscribe: [email protected]
Unsubscribe: [email protected]
List help: [email protected]
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/

#2 lore raw
Quoted 9 lines · Cornelia Huck
Quoted 6 lines · Max Gurtovoy

Virtqueue index is zero based, thus virtqueue (N-1) refers to requestqN.

---
 content.tex | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 5 lines

We had an issue for a similar fix for virtio-net, so do we want to use issue+voting here as well, or would that be overkill? I'm inclined to do this as an editorial update.

I just went ahead and pushed it as an editorial update. Thanks.

This publicly archived list offers a means to provide input to the OASIS Virtual I/O Device (VIRTIO) TC.

In order to verify user consent to the Feedback License terms and to minimize spam in the list archive, subscription is required before posting.

Subscribe: [email protected]
Unsubscribe: [email protected]
List help: [email protected]
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/