Skip to contentSkip to conversation

drm/hisilicon/hibmc: Remove variable 'priv' from hibmc_unload()

PATCH In review Thomas Zimmermann 3 participants 3 messages Jul 21, 2021

Subsystems (3)
lore
Share & tools
lore

Thomas Zimmermann

author maintainer
#0 lore raw

PATCH 1/1 drm/hisilicon/hibmc: Remove variable 'priv' from hibmc_unload()

The variable 'priv' got introduced in commit 39a364a19e03 ("drm/hisilicon/hibmc: Convert to Linux IRQ interfaces") by accident. It's unused; remove it. Fixes a compiler warning.

Fixes 39a364a19e03 ("drm/hisilicon/hibmc: Convert to Linux IRQ interfaces")
Cc Thomas Zimmermann <[email protected]>
Cc Tian Tao <[email protected]>
Cc Maxime Ripard <[email protected]>
Cc Daniel Vetter <[email protected]>
Cc Sam Ravnborg <[email protected]>
---
 drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c | 1 -
 1 file changed, 1 deletion(-)
drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c +0 -1
index f73a8e0ea12e..610fc8e135f9 100644
@@ -249,7 +249,6 @@ static int hibmc_hw_init(struct hibmc_drm_private *priv)
 
 static int hibmc_unload(struct drm_device *dev)
 {
-	struct hibmc_drm_private *priv = to_hibmc_drm_private(dev);
 	struct pci_dev *pdev = to_pci_dev(dev->dev);
 
 	drm_atomic_helper_shutdown(dev);
Signature · 1 line
2.32.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 5 lines · Thomas Zimmermann

The variable 'priv' got introduced in commit 39a364a19e03 ("drm/hisilicon/hibmc: Convert to Linux IRQ interfaces") by accident. It's unused; remove it. Fixes a compiler warning.

Quoted 8 lines
Fixes 39a364a19e03 ("drm/hisilicon/hibmc: Convert to Linux IRQ interfaces")
Cc Thomas Zimmermann <[email protected]>
Cc Tian Tao <[email protected]>
Cc Maxime Ripard <[email protected]>
Cc Daniel Vetter <[email protected]>
Cc Sam Ravnborg <[email protected]>
Quoted 19 lines
---
 drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c | 1 -
 1 file changed, 1 deletion(-)
drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c +0 -2
index f73a8e0ea12e..610fc8e135f9 100644
@@ -249,7 +249,6 @@ static int hibmc_hw_init(struct hibmc_drm_private *priv)
 
 static int hibmc_unload(struct drm_device *dev)
 {
-       struct hibmc_drm_private *priv = to_hibmc_drm_private(dev);
        struct pci_dev *pdev = to_pci_dev(dev->dev);
 
        drm_atomic_helper_shutdown(dev);
--

2.32.0

Signature · 3 lines
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
maintainer Reviewed-by on v1 1/1
#2 lore raw
In reply to Thomas Zimmermann

-----邮件原件-----
发件人: Thomas Zimmermann [mailto:[email protected]]
发送时间: 2021年7月21日 21:17
收件人: [email protected]; tiantao (H) <[email protected]>; [email protected]; kongxinwei (A) <[email protected]>; Chenfeng (puck) <[email protected]>; [email protected]; [email protected]; [email protected]; [email protected] 抄送: [email protected]; Thomas Zimmermann <[email protected]>; Dave Airlie <[email protected]>; Daniel Vetter <[email protected]>
主题: [PATCH] drm/hisilicon/hibmc: Remove variable 'priv' from hibmc_unload()

The variable 'priv' got introduced in commit 39a364a19e03 ("drm/hisilicon/hibmc: Convert to Linux IRQ interfaces") by accident. It's unused; remove it. Fixes a compiler warning.

Fixes 39a364a19e03 ("drm/hisilicon/hibmc: Convert to Linux IRQ interfaces")
Cc Thomas Zimmermann <[email protected]>
Cc Tian Tao <[email protected]>
Cc Maxime Ripard <[email protected]>
Cc Daniel Vetter <[email protected]>
Cc Sam Ravnborg <[email protected]>
---
 drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c | 1 -
 1 file changed, 1 deletion(-)
drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c +0 -2
index f73a8e0ea12e..610fc8e135f9 100644
@@ -249,7 +249,6 @@ static int hibmc_hw_init(struct hibmc_drm_private *priv)
 
 static int hibmc_unload(struct drm_device *dev)  {
-	struct hibmc_drm_private *priv = to_hibmc_drm_private(dev);
 	struct pci_dev *pdev = to_pci_dev(dev->dev);
 
 	drm_atomic_helper_shutdown(dev);
--

2.32.0