Skip to contentSkip to conversation

regulator: fixed: use dev_err_probe for register

PATCH In review Chris Morgan 2 participants 2 messages Jul 21, 2021 – Jul 22, 2021 Voltage and current regulator framework

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 regulator: fixed: use dev_err_probe for register

From: Chris Morgan <[email protected]>

Instead of returning error directly, use dev_err_probe. This avoids messages in the dmesg log for devices which will be probed again later.

---
 drivers/regulator/fixed.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/regulator/fixed.c +3 -2
index 39284610a536..599ad201dca7 100644
@@ -287,8 +287,9 @@ static int reg_fixed_voltage_probe(struct platform_device *pdev)
 	drvdata->dev = devm_regulator_register(&pdev->dev, &drvdata->desc,
 					       &cfg);
 	if (IS_ERR(drvdata->dev)) {
-		ret = PTR_ERR(drvdata->dev);
-		dev_err(&pdev->dev, "Failed to register regulator: %d\n", ret);
+		ret = dev_err_probe(&pdev->dev, PTR_ERR(drvdata->dev),
+				    "Failed to register regulator: %ld\n",
+				    PTR_ERR(drvdata->dev));
 		return ret;
 	}
 
Signature · 1 line
2.25.1
maintainer
#1 lore raw
Quoted 2 lines · Chris Morgan

Instead of returning error directly, use dev_err_probe. This avoids messages in the dmesg log for devices which will be probed again later.

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next

Thanks!

[1/1] regulator: fixed: use dev_err_probe for register

      commit: d0f95e6496a974a890df5eda65ffaee66ab0dc73

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark