Skip to contentSkip to conversation

sunrpc: Fix return value of get_srcport()

PATCH New [email protected] 1 participant 1 message Jul 21, 2021

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 sunrpc: Fix return value of get_srcport()

From: Anna Schumaker <[email protected]>

Since bc1c56e9bbe9 transport->srcport may by unset, causing get_srcport() to return 0 when called. Fix this by querying the port from the underlying socket instead of the transport.

Fixes bc1c56e9bbe9 (SUNRPC: prevent port reuse on transports which don't request it)
---
 net/sunrpc/xprtsock.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
net/sunrpc/xprtsock.c +1 -1
index e573dcecdd66..02b071dbdd22 100644
@@ -1656,7 +1656,7 @@ static int xs_get_srcport(struct sock_xprt *transport)
 unsigned short get_srcport(struct rpc_xprt *xprt)
 {
 	struct sock_xprt *sock = container_of(xprt, struct sock_xprt, xprt);
-	return sock->srcport;
+	return xs_sock_getport(sock->sock);
 }
 EXPORT_SYMBOL(get_srcport);
 
Signature · 1 line
2.32.0