Skip to contentSkip to conversation

ARM: dts: stm32: Disable LAN8710 EDPD on DHCOM

PATCH In review Marek Vasut 2 participants 3 messages Jul 21, 2021 – Jul 23, 2021

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: dts: stm32: Disable LAN8710 EDPD on DHCOM

The LAN8710 Energy Detect Power Down (EDPD) functionality might cause unreliable cable detection. There are multiple accounts of this in the SMSC PHY driver patches which attempted to make EDPD reliable, however it seems there is always some sort of corner case left. Unfortunatelly, there is no errata documented which would confirm this to be a silicon bug on the LAN87xx series of PHYs (LAN8700, LAN8710, LAN8720 at least).

Disable EDPD on the DHCOM SoM, just like multiple other boards already do as well, to make the cable detection reliable.

Fixes 34e0c7847dcf ("ARM: dts: stm32: Add DH Electronics DHCOM STM32MP1 SoM and PDK2 board")
Cc Alexandre Torgue <[email protected]>
Cc Patrice Chotard <[email protected]>
Cc Patrick Delaunay <[email protected]>

To: [email protected]

---
 arch/arm/boot/dts/stm32mp15xx-dhcom-som.dtsi | 1 +
 1 file changed, 1 insertion(+)
arch/arm/boot/dts/stm32mp15xx-dhcom-som.dtsi +1 -0
index 8349c9099e301..8c41f819f7769 100644
@@ -140,6 +140,7 @@ phy0: ethernet-phy@1 {
 			reset-gpios = <&gpioh 3 GPIO_ACTIVE_LOW>;
 			reset-assert-us = <500>;
 			reset-deassert-us = <500>;
+			smsc,disable-energy-detect;
 			interrupt-parent = <&gpioi>;
 			interrupts = <11 IRQ_TYPE_LEVEL_LOW>;
 		};
Signature · 7 lines
2.30.2


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
maintainer
#1 lore raw

Hi Marek

Quoted 27 lines · Marek Vasut

The LAN8710 Energy Detect Power Down (EDPD) functionality might cause unreliable cable detection. There are multiple accounts of this in the SMSC PHY driver patches which attempted to make EDPD reliable, however it seems there is always some sort of corner case left. Unfortunatelly, there is no errata documented which would confirm this to be a silicon bug on the LAN87xx series of PHYs (LAN8700, LAN8710, LAN8720 at least).

Disable EDPD on the DHCOM SoM, just like multiple other boards already do as well, to make the cable detection reliable.

Fixes 34e0c7847dcf ("ARM: dts: stm32: Add DH Electronics DHCOM STM32MP1 SoM and PDK2 board")
Cc Alexandre Torgue <[email protected]>
Cc Patrice Chotard <[email protected]>
Cc Patrick Delaunay <[email protected]>

To: [email protected]

---
  arch/arm/boot/dts/stm32mp15xx-dhcom-som.dtsi | 1 +
  1 file changed, 1 insertion(+)
arch/arm/boot/dts/stm32mp15xx-dhcom-som.dtsi +0 -0
index 8349c9099e301..8c41f819f7769 100644

arch/arm/boot/dts/stm32mp15xx-dhcom-som.dtsi phy0: ethernet-phy@1 { · line 146

Quoted 7 lines
arch/arm/boot/dts/stm32mp15xx-dhcom-som.dtsi +1 -0
@@ -140,6 +140,7 @@ phy0: ethernet-phy@1 {
  			reset-gpios = <&gpioh 3 GPIO_ACTIVE_LOW>;
  			reset-assert-us = <500>;
  			reset-deassert-us = <500>;
+			smsc,disable-energy-detect;
  			interrupt-parent = <&gpioi>;
  			interrupts = <11 IRQ_TYPE_LEVEL_LOW>;
  		};

Applied on stm32-next. Note it'll be send through a fixes branch for v5.14.

Regards
alex

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#2 lore raw
Quoted 24 lines · Alexandre TORGUE

Hi Marek

Quoted 21 lines · Marek Vasut

The LAN8710 Energy Detect Power Down (EDPD) functionality might cause unreliable cable detection. There are multiple accounts of this in the SMSC PHY driver patches which attempted to make EDPD reliable, however it seems there is always some sort of corner case left. Unfortunatelly, there is no errata documented which would confirm this to be a silicon bug on the LAN87xx series of PHYs (LAN8700, LAN8710, LAN8720 at least).

Disable EDPD on the DHCOM SoM, just like multiple other boards already do as well, to make the cable detection reliable.

Fixes 34e0c7847dcf ("ARM: dts: stm32: Add DH Electronics DHCOM STM32MP1 SoM and PDK2 board")
Cc Alexandre Torgue <[email protected]>
Cc Patrice Chotard <[email protected]>
Cc Patrick Delaunay <[email protected]>

To: [email protected]
---
  arch/arm/boot/dts/stm32mp15xx-dhcom-som.dtsi | 1 +

  1 file changed, 1 insertion(+)
Quoted 15 lines

arch/arm/boot/dts/stm32mp15xx-dhcom-som.dtsi phy0: ethernet-phy@1 { · line 146

Quoted 13 lines
arch/arm/boot/dts/stm32mp15xx-dhcom-som.dtsi +1 -0
index 8349c9099e301..8c41f819f7769 100644
@@ -140,6 +140,7 @@ phy0: ethernet-phy@1 {
               reset-gpios = <&gpioh 3 GPIO_ACTIVE_LOW>;
               reset-assert-us = <500>;
               reset-deassert-us = <500>;
+            smsc,disable-energy-detect;
               interrupt-parent = <&gpioi>;
               interrupts = <11 IRQ_TYPE_LEVEL_LOW>;
           };

Applied on stm32-next. Note it'll be send through a fixes branch for v5.14.

Nice, thank you

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel